From nobody Fri Jun 12 13:58:29 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB0C83BFAC8 for ; Thu, 14 May 2026 13:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778764597; cv=none; b=PaRdo80ai+2JVT+7b+Fv+/DjN8MHzIVmvBybQk6Wylh7hQ8vhcuLcAxU3cp3E/zYRQGfpcv4hwOooI/uX+kKN4ASCqArGyyb2N2HsY5f0LP1ih5FUjz/6T4sOHuqVgDts2Ko9JU3U0DNlau2ZslDwxDzVMxu0HA88lVqTK0gZHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778764597; c=relaxed/simple; bh=jl08X3NCLgmcZoiX/JRkZFjNthe8bvfBiVgfd+XVW5g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=XIqflW9iKZ40PnHuVQcscrsz6vyZQTKLZgu0VAU5hD+re0Qv7+WRbr7fX99kNrjcVdMIo/FGNzZbC++velc6rTDSPFOprA4QOt6+XCacGpRNyGmiqi69A0WvwoDifQ3JbrlBPXvvK30u+1lu2N/jTxVe9xka6DCYv4PyJJciH9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YgKB6fyI; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YgKB6fyI" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2bcd730e090so34382645ad.2 for ; Thu, 14 May 2026 06:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778764594; x=1779369394; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=dxjsDTEPx7x+FMifRYMV1hqCeB1iIjDkPxo6+pakXPM=; b=YgKB6fyIxmkvEQ/e5HjhkfBnD0diRPyLV36UdaEobnsMsGKEHbeSSi/1oiyamTbB57 VsZNXXLvg9mMcHhpUbZsphR9RBIaUGnbway8RKLTMzNBS2x0PXWoAr3uIR4EoKq76kpr IEan/0Qz1QQXC1kfZZdQPY+LOeLnLABeak0/12GwoFTf7YMKhOGgj31h1ZtDbat/2LEt nuxI8tbUH0dBx+dOk1tL+zYq+2nQBu0Mnt6JR6Qdgyf2I9pyNu5/BEa3zpwmzvS5wxMv s+5NArS5mavtJhpa7cJ3cH1jKy3Ef/V79RrTM6LzGAKvzbs0yyjwhVzNwjrG/qAbPywO RANw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778764594; x=1779369394; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dxjsDTEPx7x+FMifRYMV1hqCeB1iIjDkPxo6+pakXPM=; b=e3RcoFWmeNHAQW7KpIFTW6EXSxFRS2jJRV4+DCmcMdnjrmQMUuMwqYd2IXW7HasClL TAydhDpBZ59gFjBefhg2F3JWOUW5mbBKPoCQOiykBvYfBwY7DfVjoEpSodQjRVY3/8J4 u3lR52pl/QTuLnbCawsbdSjaQUB6f7jVo3NEX2S62jGxKy4Pfk+TuYk0ECNuMLM3dkEE Hz75WvUtJWTb1ANjHPNPf3n1Duwz2MO69/8S7IHPkuQ/GkmgoIlXmWV9mpkdRI6FnOeQ TYSKyzefVQsLEXfCeeqoCgPHM4hRTCRrUidBDLD0Vf07kgNMKj/EJaL9EK/fMsXGYDKx ta2Q== X-Forwarded-Encrypted: i=1; AFNElJ8JU0h8/uy+rigjQDg/KLXiZ/9AJVDdAASOYYs6CqVhcq+KZwHtYPDpC3zogNO6ITO6hp/eYsDWZ61kBxs=@vger.kernel.org X-Gm-Message-State: AOJu0YyaaMC/kthFDqON6bRcppK/otMYKbv8+qq/VRXv8P3kepxYvDqM PyyzujdVylBv2unEsNZZhBj8NLQZ6/ox+6PR2S9sRvmMdlFgQwP5qWEU X-Gm-Gg: Acq92OEque2I0HMgsLOPxIqNG8bBJ1eyOe50nr6vRbZDsLYZCdF4OKQV8HLbZiuAKQR hIYlrfrFr1qBge1utO973LxEUL1QcG4Iq+YjjtE8YfglZmUKQyylcIBHxuFVlFSDs/YEzHiwHfo ZsQxFUKSxj0HGFvkDXxKdNyLlaydz89RQXWHPXVmasd9VDcRvmaxpJfL0zYGuNIMYgk6/gLD/Hi 24GZmewp8J8+w17hHGAw5EKt54u7EucTDOeCsBKDZGsVG8Zg93h8m31KHN11CUSspVJevcBs955 C5NzbWDhY3wD9msjhkfMk/EphJecSav0scxNoadU+7k1Z/qDaHTBOiDQKGMS3A3pWgzPeh9lPvo HHc8kugksZgf2mn4PbOhLu4tCMZuY18Cx//pbJhQ5Mg8Mj1x9k04F4YaEtS5we7z8OsF/ry8sTf JF+FJYl6wfrQSFKZhMohkTRnt2lJuFrIAQbAI= X-Received: by 2002:a17:903:388c:b0:2bc:e62a:979b with SMTP id d9443c01a7336-2bd30333de6mr80854555ad.30.1778764594127; Thu, 14 May 2026 06:16:34 -0700 (PDT) Received: from [127.0.1.1] ([59.188.211.98]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2bd5bd5f30bsm30953275ad.16.2026.05.14.06.16.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 06:16:33 -0700 (PDT) From: Nick Chan Date: Thu, 14 May 2026 21:16:01 +0800 Subject: [PATCH v2] nvme-apple: Reset q->sq_tail during queue init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260514-nvme-apple-sq-reset-v2-1-84cbb5c70bf5@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/32NQQ6CMBBFr0Jm7RhaqFZW3sOwQPzCJECxJY2Gc HcrB3D5XvLfXynACwJV2UoeUYK4KYE+ZNT2zdSB5ZGYdK5PuVElT3EEN/M8gMOLPQIWNgW0hrX t+Z5TWs4eT3nv1VuduJewOP/ZT6L62f+9qFixvRQKpTHaKly7sZHh2LqR6m3bvmtHeGy2AAAA X-Change-ID: 20260514-nvme-apple-sq-reset-53e22e88c7b0 To: Sven Peter , Janne Grunau , Neal Gompa , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yuriy Havrylyuk , Nick Chan X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1204; i=towinchenmi@gmail.com; h=from:subject:message-id; bh=jl08X3NCLgmcZoiX/JRkZFjNthe8bvfBiVgfd+XVW5g=; b=owEBbQKS/ZANAwAKAQHKCLemxQgkAcsmYgBqBcsvQUZgV7lMIoBJkU6SplIAUQALX59m3rswM Ju0qI6zlQ6JAjMEAAEKAB0WIQRLUnh4XJes95w8aIMBygi3psUIJAUCagXLLwAKCRABygi3psUI JN8JEACwOZAPoKWuJZMLfBID3QAgWkZEOfVVIl1hXXM5d17MAF1zrTZA8DDoNnOxJJhQJiRsOlp +QA8rVCZkVF2d3eukmBADzOGA2sLHHgzFHdHsMiC1TzaVmyOyHlosVYQ4QpCOrntfYn8Ief+kf1 dU2C8V6wfmrP69rmjJWBOxIWG/ITq2+A+PgNZFJw8rvIYw7EmdvudX8Ad+9YnsgyRlsTUEBg1zE SPe4LTeH1C9DL0SFhyCuAOsQ3YGr7L0E923wAgUPYmUzmATooVEhyGVouKE0p80jPPTSWjkTq+2 sIBrK9qlOFgLaWFxUgYP6/Y2R6NFal9KSyn9nQtcuc+JrnbXisbX2XRYRnW4T3zIFqBPJeIwaBr HEKQfto0SI0mOrxyueKQsge5FMYjDF5noX0ZqsOmPs9j9yJOI2lAk0PBlAa2trKC3NL1Giz5XuV 6pyftpibUZeTTMDlCKryZCaa7P2htuazpMHGUktU6f3mlGDXKPXLu2KW5kZwRovQFlp6HaMR9/1 4q+WnDsfn8R3j0qo7VGd1uXtbS4gAGtOJHimc54QP82uq/92L8GUEQu2THl1jhNTbPmZ0XSD1Qq JE32qAW2gU2Bskqmit3QUg9ywWgIG/qsW0aqk+BVCKXsASJL2YkOZxQQP1YuKftd/zp6yR95cvp 29qFsWAWPK+XS6Q== X-Developer-Key: i=towinchenmi@gmail.com; a=openpgp; fpr=4B5278785C97ACF79C3C688301CA08B7A6C50824 Fixes a "duplicate tag error for tag 0" firmware crash during controller reset while setting up the admin queue on Apple A11 / T8015. Fixes: 04d8ecf37b5e ("nvme: apple: Add Apple A11 support") Cc: stable@vger.kernel.org Suggested-by: Yuriy Havrylyuk Signed-off-by: Nick Chan Reviewed-by: Sven Peter --- Changes in v2: - Cc stable - Details on how controller reset is fixed - Link to v1: https://lore.kernel.org/r/20260514-nvme-apple-sq-reset-v1-1-8= 931e455281e@gmail.com --- drivers/nvme/host/apple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c index 423c9c628e7b..c692fc73babf 100644 --- a/drivers/nvme/host/apple.c +++ b/drivers/nvme/host/apple.c @@ -1009,6 +1009,7 @@ static void apple_nvme_init_queue(struct apple_nvme_q= ueue *q) unsigned int depth =3D apple_nvme_queue_depth(q); struct apple_nvme *anv =3D queue_to_apple_nvme(q); =20 + q->sq_tail =3D 0; q->cq_head =3D 0; q->cq_phase =3D 1; if (anv->hw->has_lsq_nvmmu) --- base-commit: 5d6919055dec134de3c40167a490f33c74c12581 change-id: 20260514-nvme-apple-sq-reset-53e22e88c7b0 Best regards, --=20 Nick Chan