From nobody Fri Jun 12 15:58:46 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7642E3A9D9F for ; Wed, 13 May 2026 20:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778703634; cv=none; b=mXcwrDVRvY9yryLmz6/oe1IN59puLO5jKVsedGRvD8hrjOHVtlK0q0521H/09IcHMWi760DdRewJArktZtHP0OovYTSR4r60wUkTlesngk9IEMRLPeaiyVPILRjPjRRUAWAM/kBuJiUkP6QKPQTuYNHoI8oGn5SsVUbMHuYTh2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778703634; c=relaxed/simple; bh=1+JfEVh8IHmLlWdK57jRDorQflGfu7RT2ANUDg++Yrc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YDfW+zPdo1vE6z1RqaknIfclHz176KDV5ngfbjGdtwNcjeJw9CWRwG+uJ880MRvwM9fYYZqsTvMr2qw4FvSfSvliQJDUXwPW0DVuPDDkoHWF2s0Y+9JXInaTvFQOv4wJik3K0IixnfAGqD6R4lwPC/oiUzfssMx39wkK5vAcTMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JHcRjM1a; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JHcRjM1a" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2b458ca2296so48748265ad.0 for ; Wed, 13 May 2026 13:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778703632; x=1779308432; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BRdLkjPZb6o4tdcWRE9ouOn7tpuKUG0gkuZr4j3LG1Q=; b=JHcRjM1aeTYnBHVN3npOSGV7nG6uAfxeEgREZ4WR+5wzqH3ifOqb0VmFRw7CHOaXiM jd7b4XajBdJi3XQlFQ4ORj4Eiw2GUEhuJyJcbonoOq5FfNZCbXYudhUdBDJk6GSViS0x uv93Lxc9vaaJhTRH2quKT8UaqXnAMt9zZBhZmpYryYBofEqtqYxBF6AtiKOZylz1TOup K6K43SZN9kHPaK+Sxm8TjWGFzsLMtOciZmI20FVM00QjEEa8TVFaprJX35eg3YJ8tFrZ fNTpbakeKc9rG9xg0q3Rb38jQyxMmEud2Vju31XJkg40aWSOu1DJEb2b3sSD8BLA1rM/ jQOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778703632; x=1779308432; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BRdLkjPZb6o4tdcWRE9ouOn7tpuKUG0gkuZr4j3LG1Q=; b=ZJD5zg9OiulwOiICPEiP8IRbkE4dSbgsX876EdQTfmlcImaGlO3AWXqXJyHyKnP0uC wzLZsJ3klhKesNsyJcYwkBxuCDLd5RK0j9v3iT07LCq8kuDxY9DR34ckVF3Z8gA/ybUP 4IwedQYy+7J/ATcodUQGt3jVaTJZtXfkWKICnq3ERGL6oV7V4HYm2P8rwjk/aYH5lFgj NYqoO7XfgwKrDJT4ujdZTIE5qFaXN3CWZo3hJ8juIdH/UurqSiJY/SoJi9vkOAhWalC9 WGHa6pOfsD2UBKztKmPMBuRhwB9IuDxdvYgZFjeIVvnTGM4PZh6r2gSNpj3R0p8S33IY 6GRw== X-Forwarded-Encrypted: i=1; AFNElJ/TRDgwx0APEelCymwD6zi0f/2Mr4KE0WA3gfTLpK5FAhbCs9HhcFKKnVORyeY9sjdCSO4w+jfIiCbb1IQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9XbYs6a2U9w0y6Ap9QSI26cQH4RlvrNfScH0CMfw1JvQYqIp1 lE+ymVYmpIDeetryYhZSbK5GQKQZXq7QIQo0WngiTT0rMflZO7eTAn3A X-Gm-Gg: Acq92OGjFSWF8qqlvfAVnvaVEE9nJqiiJbN0eTm3nksk46vF+0RSoIHojXRKdtj3zv2 c7jRuoSSccCU9Mz8SpF4ljd25TbzKZn9qQ+WLfzswW4H0C6FAoen69f6Wr9S1ROOP7wStnoImLi e9ZGyQRpJMpd4cSk1E6SZ1Ax0MroLp+N+W97Z43ZIO1NJy/Q8sHqy75+a+ldWUFSNQcUqz2Cs06 GAT5npsGxRYmHrGigYZVAVlHbFUqLptIv2DBvQ0P6H549CF5XH26tyKxi1cOX5UUCfzDqhwIOqO NNk4PSwG3xWyo81d4UvX401IGL+F4MeBibaJFgMuQNNsONyUfQ/8o1JkoTAszAguxc1bAeS9ExN pP8D22d970lmkXmBIiIp1FeHrQQDvoGZ71eWI9PVMm9uuVolk26GLr88XwXt1eWe9bh3jDkgAcZ QHMwTVpdlOKHCA5ZacC31+n2U7dZaRHdknLAn627e6p44= X-Received: by 2002:a17:902:c254:b0:2b4:604c:ec6f with SMTP id d9443c01a7336-2bd273aad39mr36066335ad.32.1778703631600; Wed, 13 May 2026 13:20:31 -0700 (PDT) Received: from FredPC.orting.wednet.edu ([164.116.47.202]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d0fc80esm741775ad.64.2026.05.13.13.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 13:20:31 -0700 (PDT) From: Fredric Cover X-Google-Original-From: Fredric Cover To: Steve French Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Fredric Cover Subject: [PATCH] smb: client: change allocation requirements in DUP_CTX_STR macro Date: Wed, 13 May 2026 13:19:15 -0700 Message-ID: <20260513201915.401320-1-FredTheDude@proton.me> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Fredric Cover Currently, the macro DUP_CTX_STR allocates new_ctx->field using GFP_ATOMIC. DUP_CTX_STR is only used in smb3_fs_context_dup(), which is never called in an atomic context. Using GFP_ATOMIC puts unnecessary pressure on emergency memory pools. Change GFP_ATOMIC to GFP_KERNEL. Signed-off-by: Fredric Cover --- fs/smb/client/fs_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c index b9544eb03..a3ccc06c0 100644 --- a/fs/smb/client/fs_context.c +++ b/fs/smb/client/fs_context.c @@ -420,7 +420,7 @@ static int parse_symlink_flavor(struct fs_context *fc, = char *value, #define DUP_CTX_STR(field) \ do { \ if (ctx->field) { \ - new_ctx->field =3D kstrdup(ctx->field, GFP_ATOMIC); \ + new_ctx->field =3D kstrdup(ctx->field, GFP_KERNEL); \ if (new_ctx->field =3D=3D NULL) { \ smb3_cleanup_fs_context_contents(new_ctx); \ return -ENOMEM; \ --=20 2.53.0