From nobody Fri Jun 12 17:18:48 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011048.outbound.protection.outlook.com [52.101.52.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82DA23A9015; Wed, 13 May 2026 18:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696966; cv=fail; b=C1JRS4BkMOhmxqOIRgbo4Hy2pkaNIukd58qz080MBcrA/PMANB8eCtKnUKy7V4MfTsi0YnRbIStvuZqcdqnjvZ5bXsmjZv6Tie39gzm2jZedXlU/3vRVfnyCpaX+n/rD/KBo+MIsnt6bBjfwQv8LwKSUrdiOtSEzJ3N3oNxWCjM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696966; c=relaxed/simple; bh=uTdKuKt3g7PHqqom3sesRoQzKZVLXJJ51xGJrEbfe0s=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PfRDXZvzQjUcbcbtBJjxUhnS5YUlJbvTDOQiDWvcEHR3xrY2bbWF4VLACF6djnVGsrKNet6upXXAfqvbCHD0qYa8oVP8D47DexJjOizy8vRyRxvF1eYf9HuZ2wnfqMpVTQSNvcElI9UEQWOrxn1rYnlWP+o7Nd1p1CyfT+2s8P0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=OCJbKExF; arc=fail smtp.client-ip=52.101.52.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="OCJbKExF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fIRROuQAWf33YPDH1FSzoolJahI52On91GidvTh3uqc7/8zR/hOTUsoSbhoOcM7J6hbIU+FE2GtkdwHzUf68ZfedJk+oI++R12+HBVSV4eUvo51R5mvVfuwqHzRQB4VCQlLFGXItIbShwxGotSOt1Nse8tOcixmK5YgOn4vQT8kR0nbTotSGbmaGIG/m1nyKASAlupEhtbnmZitUvlBmZCct7EXCgpO6j4ef+N8QC/dbBAGm94+eDycvhUsS9aBQXnobxDWGRnCOU2dx7AmGwkx6/3GD3Vso0/1Kj0JKt3aJWmS7ntYsyeX4mroi5P+mXn7cQC5QGvd2bXCX/PpiSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hhmstGMTLyD/2zh1jEj5JtG5eOscIiTPlDFpv61O5XE=; b=hynXVEb1GlA/WLConNN0Vife54oyZ+uDhr25NZVNuJt30UE9t2yg6fJwIsKqVqMuBwGaTjvKX/LhVHdFLG+iI9vqlDc0xkBiHiFh6kNV52/7Kl1iT/3D88PnIOVULo6pvOa2sw2wcvI1/X1EuZMPlxNwXGRfV7KLlMt6FjlujPJaAE6XR2ZsHEpk3cTTfE/qV2NNKg7hSG3tS2FLEapOQQv6hvNEiUMM7Tt7CpTl9jCOV1rB5sKa/0/q1wMgq5v8rdloec09ETVaufhY0a1cRNU9trbL0dJi7fB+b95T4IYDG6cR3eZtY/Sow1junZfy/I5qheCgh6GMzQJW6wcGEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hhmstGMTLyD/2zh1jEj5JtG5eOscIiTPlDFpv61O5XE=; b=OCJbKExFqafxVg9vg1IzmD+SyiZ50jgFeUDMuWCcpOKzb9sTKaD9E45uqTeeCTKI3OZ3NQ/hrwRENqdjMCS5wugijLpu5CfjAWD2nPZUr1utpROL69xVMNbLxtvL/g7GTEivYfdC0JXVNiL6iDO6Tj/kQrL0fXImsx/mbv/i248= Received: from BN1PR13CA0013.namprd13.prod.outlook.com (2603:10b6:408:e2::18) by IA1PR12MB6186.namprd12.prod.outlook.com (2603:10b6:208:3e6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9913.12; Wed, 13 May 2026 18:29:19 +0000 Received: from BN2PEPF000055DB.namprd21.prod.outlook.com (2603:10b6:408:e2:cafe::29) by BN1PR13CA0013.outlook.office365.com (2603:10b6:408:e2::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.17 via Frontend Transport; Wed, 13 May 2026 18:29:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN2PEPF000055DB.mail.protection.outlook.com (10.167.245.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.3 via Frontend Transport; Wed, 13 May 2026 18:29:18 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 13 May 2026 13:29:17 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 13 May 2026 13:29:15 -0500 From: Radhey Shyam Pandey To: , CC: , , , Radhey Shyam Pandey Subject: [PATCH 1/3] usb: typec: tipd: add error message for vendor ID read failure Date: Wed, 13 May 2026 23:58:48 +0530 Message-ID: <20260513182850.165349-2-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.44.4 In-Reply-To: <20260513182850.165349-1-radhey.shyam.pandey@amd.com> References: <20260513182850.165349-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DB:EE_|IA1PR12MB6186:EE_ X-MS-Office365-Filtering-Correlation-Id: 3729c0dd-ee76-4db3-c4e0-08deb11d8b3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700016|11063799003|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: vqvsuC1uB9hzb0B01q3HtasZ4uJ9AjCKk2O+U95cKImPvVaKgtk3obVM2dDKiW3myvypYdx1vApbsuqAPRdGH3RTwWxN7j68ayC+yBxHH8IMhMi8Ra13D52SPr+DaNL3w1BGX9EaQ1zC+7lsv3hy2CeRN/6KdKXBF96X73mtWxKwAYDCeM2OvlrjTXnQA4Eaz6R4uoSqMbeI2lJc9NSnlyQgnC4I0aICdsa0Xkdr0XFkpUvoeDtcEdWGjaRXAKM2sKryWZ2zCVfUDPLB6BNnpwQ3Gz5C/brKt8TZ87VOv62Yl7UpNJfXnWQN9CXGmhLLAWMpo6OwRdh6lcsROZ962bGCR4zEHotAIF64Ergu3sGAwErOoCrQ0qO8iFu+GdOU9nwik8jG0mb29oimrzcaxQHTABLI69TBbeUwWyP7SLWYCuCVaEEg8OMnE3xfnXR2HwWStHhs1lN3/d9Qb/rUSN+/zTodHfVFlqioRNBAyFe0p3fvClfeFI+f3VeNgYeOyfhRSS1hHjcGKM2O3dGVVAlqx4TqRbhLW9gMSs87nmSSXmDRQpKKgR/bg0MGw7YGPrNa081TVQagTg7bg14BZXebKvUIytpbnPPr8HtheVHh2vR3wOdcuOSYpihLrYicKbKMjApTc5QUVgl3HSUN6LuF+3UXm1S2OabN2NSIvO8yS5RV+ubb5OIcCUVLm8QcAAbPApfdPoTQRbgucrhOrDOvAs9nfeSIB4FaaGsS5rw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700016)(11063799003)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: x89HGGd/6ZdwbJ1R1tOwJUPFy80hrrMbpFN2AAT26uIhspIBsvi7004NKF9LcQlDqPVuNLNa4LSbonyqjQ20nEll/15de2ig7k2RxMhkAbcZOQwGb6K5cyu/vUbaC/f9EQLsXcJjZQnLkP3J3v4vUuglvpx3FMtOOQmiVnhVcrTeEKDmaT806HZ5eYd85D31Ojl4/3fH+l29Rdu4GCPdUR6ZI68cjqp1bkIYAaiX/HTFYdpzchDNZkxuNSjaXkzRn+fhHpyGsD0heAbhQ+PKf8W2vUltOxhA75mDSNrpWFCnFxoVMtK7bKsCEL6okJOav7pu19cD0AK+flqYbm0MZmMIVKTsbiF9YYQew/Alv3BwZwdEcnnCjgLOnhqSq00m7N7G8mBDhWoQ0Dp1TSpZok1w/cSJea6FEyBhBUzqbkQ6OGG17y0hieNZq514SdVm X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2026 18:29:18.0793 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3729c0dd-ee76-4db3-c4e0-08deb11d8b3a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DB.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6186 Content-Type: text/plain; charset="utf-8" Log when the vendor ID read fails or returns zero, including the I2C error code and register value, to ease probe diagnostics. Signed-off-by: Radhey Shyam Pandey --- drivers/usb/typec/tipd/core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 43faec794b95..b282366b5326 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -1744,7 +1744,7 @@ static int tps6598x_probe(struct i2c_client *client) struct tps6598x *tps; struct fwnode_handle *fwnode; u32 status; - u32 vid; + u32 vid =3D 0; int ret; =20 data =3D i2c_get_match_data(client); @@ -1772,8 +1772,11 @@ static int tps6598x_probe(struct i2c_client *client) =20 if (!device_is_compatible(tps->dev, "ti,tps25750")) { ret =3D tps6598x_read32(tps, TPS_REG_VID, &vid); - if (ret < 0 || !vid) + if (ret < 0 || !vid) { + dev_err(tps->dev, "failed to read vendor ID: %d, vid: %#x\n", + ret, vid); return -ENODEV; + } } =20 /* --=20 2.44.4 From nobody Fri Jun 12 17:18:48 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010057.outbound.protection.outlook.com [52.101.201.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2713E3A785E; Wed, 13 May 2026 18:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696972; cv=fail; b=tL27dg3vU9cLYiy08EICzp1ZqMPF91NGHtaK7SsIIrXuJeJTjF10eJKfwbD/l26ELxJsG4FUcJZ9QaH+2kan8NYfs/scFBmttfosoyWzvyTbq5YvOU840vCxIZ8c1hlsUZhXoIvDx5Uiq8js7kDtl4t10Vw5gTctlo7GCMHDK1Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696972; c=relaxed/simple; bh=pyeQAHnHShMRITgMtTu1hhkl/8NlKiMW0ovkLrkPfjM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VwDYAinyG1Ly1xDfzlZvhomzoJD7Xia8fvGdvxGfOm2WdAYtTEEXUyeL3iCNfaEfKeYKEjkGqOBW6f6+lKEpqyJZj5wkpgLfbGDgYjVMSm67J0I5bSRAnayb0cp90Ev9RpWUyzVszO3do7NYEdnkpkxvoZ7mMb5DZK2d0g5j5IY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=jOdJvx8d; arc=fail smtp.client-ip=52.101.201.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="jOdJvx8d" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EhQ++VLBruKmjE88FdTdvydzixEFaln4XU+V0ZZXxQYeuDd/i8vW7jPc6j1UIMvaQDTjkFJrpLj7sGdBWjbe43A2ChqJIt8Xx24ScGG16AtLFdWBfHJKgRUt4cfKFercYXvH5jUfXKXyGJzmQ54333zvZ9GVZqMMUrJZfeK86SXSnxtbmtwPlDo40PWLBgzWsUYNCDCtHmDhWTXZ4FG9K01bDqiM5WxF936jxJzV4gs3q9DPgeUV/m1mdwlRTErYLUck6qPeDAkip5ybxxHF3XmLI6NWzggI54iPF/oKhf0mcqDSxpJj8oqiYafwUINOYmWccemORVtcvrOf8GIKVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/I5JWDjDI771x0kQ3TS+BlM5AqKff8F/6kGCB0QA+g8=; b=uSxIATITw5Iw+kyjn2hMPq6ibXClmcwwjw8wilwt6VRixCuTa8Xan7GZ/Pr01STbeAe1iqA7peOMbv+AuCoC6USHqQ4kR99aqrROY3AD8Y8O0mf36OxJnRTi+IDdEhPq0v0cKe6z0ujMlqNEclixN9KOoQqn8fzZGIq3Ga8qj0JuiqTxJibN/iw5E3UeXexgo/0IxgRw/HXzpxLdIWYbDjgI7KqrdoeQCkR+fB5lFHTKGF4aFuSHv3JxK2eXjcQ9u/wM+50QjCqs/PylVlzXuKXC8O/hl4UFVsWVEvEUslnvbmi1qjsZcUuvYvi1vEfYtOHyejC5ntWSQOyccn0deQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/I5JWDjDI771x0kQ3TS+BlM5AqKff8F/6kGCB0QA+g8=; b=jOdJvx8dVZd2BoNBOUX9oHMsj5q1an4D747TMRAFXNRTKEajXD71YXLObHNL0vC6bhcvA7YJ5y7NaX14E4UR5a1+iGq91+3Gr/y/T6gnFnGrVhcyOo+DdyG1nelrt4al/Z4KHMxenJ2niIbKvFIE60ebCrIkRNxOfwgpFfFGUTY= Received: from SJ0PR05CA0169.namprd05.prod.outlook.com (2603:10b6:a03:339::24) by DS7PR12MB8250.namprd12.prod.outlook.com (2603:10b6:8:db::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9913.11; Wed, 13 May 2026 18:29:27 +0000 Received: from SJ5PEPF000001F6.namprd05.prod.outlook.com (2603:10b6:a03:339:cafe::5f) by SJ0PR05CA0169.outlook.office365.com (2603:10b6:a03:339::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.17 via Frontend Transport; Wed, 13 May 2026 18:29:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ5PEPF000001F6.mail.protection.outlook.com (10.167.242.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Wed, 13 May 2026 18:29:25 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 13 May 2026 13:29:20 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 13 May 2026 13:29:19 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 13 May 2026 13:29:17 -0500 From: Radhey Shyam Pandey To: , CC: , , , Radhey Shyam Pandey Subject: [PATCH 2/3] usb: typec: tipd: demote missing IRQ log to info for polling mode Date: Wed, 13 May 2026 23:58:49 +0530 Message-ID: <20260513182850.165349-3-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.44.4 In-Reply-To: <20260513182850.165349-1-radhey.shyam.pandey@amd.com> References: <20260513182850.165349-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F6:EE_|DS7PR12MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: dca58361-4390-4c2c-8604-08deb11d8fe8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700016|18002099003|56012099003|22082099003|11063799003; X-Microsoft-Antispam-Message-Info: 4cQ63cp6ZpTKU7FzG2SPCXr38XCEIJBRklWScag8OdBoTdHmzwAw8odlECk0UpWaswrVploUwNCiGjbZ7EY3qFmA24Q2UgEEdP18a5XIVnC+YpPZww9jw5o8aKpIxquzslEQxFeRXAGQdWeCZ62xEEqiVl+F7JowOF7g4zgnxTRr18UzHGD0oUen2J1sVUMlkZNKdzov98ZjWo9n8yi8v5YNKPlgnZi4JjwgWLGPztwMLwEXGEpvVDcPy5ExdqTCACoyW+FDfFhebgvi8Sp18vkAQZ2zcoPMwjcUEA8iBq9D00NaeN/naWdrxg4q41+H/Jmam8aloklc1ndZ0lAfYTr+23FRP4aputWWmsvFjp9/QZQYuxTgzqfIP5iMLXwGigwFKoD8j5Ao9VZ+nwzLEFKZUxPr0punMubctLAsY1zQiQNNDBNxeV3OmUqL2jvfS/fqSBYqjB7CApB8kxMYTInQT85qfp7vNUMbDdulUfmdGUfCq847ZtyWerXJT/F7bqKWthsWE3UUm78RmCnS0qkMGMBCT3b4HTsNmAwckPwd7pY+pEMnUz4QImppSoaa6qGXCk4SIotNJdzrcm3h3i7549j7zYT+f3/FPRTJobTE3rnJ/9FBh5Uxdj7tv+2BSOQm5fCZJwARV6uf8UMlmbcaq7KIwSdl59onTnYgDWJNH8j16w8KrhYuCGpQ52Cv54bk3kzFaubP62xirkxIiYhCyz2qY2joeOJ39dI4Gio= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700016)(18002099003)(56012099003)(22082099003)(11063799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: I3TFmr5wKUlUyOA4DJAuOPQCIKXgC/yY+fRxW5CwO/2hMxWtkP2/INhdlV5fNvjz8qh50UqwlgUGBTQAHEJZvS7NOzK2buiddiN8MVoZ1WMVBapmtTCYkdl/wvf0bkXqLrdgKqpWELZDilOlAZV3FyyjRENCLk6FghVY+ocT23TlZvTVWtL3UZI9nYTVzPxEGIFa9yXvuVKIbJyy7AZLcRlCEIniVuiLAYTxi6s0xm3VYXdp+4zCNTzNugs/nvONMC4EUxZfnlGZzox3dsP0mlz0sjHYY7+RVbQjVXm3vW/gTFoShYGOeq8e+57Nq7N+YCgebF0GWauakd6qBUplsnD16CKaP5JrvcYW1cruNqIF3/IRvT+hMijcUtCMuFI+P7T5OYZd/VGFsbsFvNYu0mR0VW0I/FXBBiwOlwfK0e6VFWV5GclyXWjEK88vwJn0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2026 18:29:25.8384 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dca58361-4390-4c2c-8604-08deb11d8fe8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8250 Content-Type: text/plain; charset="utf-8" Operating without an interrupt line and using the driver's polling path is valid. Log at info level instead of warning. Signed-off-by: Radhey Shyam Pandey --- drivers/usb/typec/tipd/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index b282366b5326..fcd56bcffab8 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -1853,7 +1853,7 @@ static int tps6598x_probe(struct i2c_client *client) IRQF_SHARED | IRQF_ONESHOT, dev_name(&client->dev), tps); } else { - dev_warn(tps->dev, "Unable to find the interrupt, switching to polling\n= "); + dev_info(tps->dev, "no IRQ specified, using polling mode\n"); INIT_DELAYED_WORK(&tps->wq_poll, tps6598x_poll_work); queue_delayed_work(system_power_efficient_wq, &tps->wq_poll, msecs_to_jiffies(POLL_INTERVAL)); --=20 2.44.4 From nobody Fri Jun 12 17:18:48 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010034.outbound.protection.outlook.com [52.101.61.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 717A43AA9E8; Wed, 13 May 2026 18:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696974; cv=fail; b=cmuZ95wPKI0BPB7RO5uQQp19GgycDWBW5u6HgAu+oBupDqWt8C8jhyUh0V0wS7puc6pzfcsQMuHjcRaK82VIZ5JEdMo1jglof9sSeRMellV2AdMb7zJwEL38AzkWOfiLSxxcEQBW3b3WPox/f6VVLW97uHUmbIaeeH3tQaFxNKU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696974; c=relaxed/simple; bh=mZTpFFgJjVteRqI9GYzdDUeK0X7UkHSk91dBnAktjg8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tpuoKdLCFMx1+8VwZLn1dDh5CUztr7AR3AwvL8bZ1Yspz2dO4TTEgBbvKDzZabOoQxRXpf9+t4QOep+heT9dWT7FJGOkSRM1wLGZsRkly5lHVcW7KLC/g1PQjHDIQC974WZ7tm7YW5IRzZUVB4NB/SG+F/eqBmeViwL51ofZKEc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Wy9NE6y2; arc=fail smtp.client-ip=52.101.61.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Wy9NE6y2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Up34CaMwKiuv7rADTzfEZgQfRyKLuNq8d0YkewaBi3QptaEhHUaONav6nAOxNZUXCqOHBEFTPFCJbgIjIsZJEqPmxgVGvcmR9jrkpKiYIiJvVl6HaS0Cw9jURn7fSrHvaAjU5E3zz19coXKFd1LU1yszpmn3mW2SHcR75wDghRo4qIjMu6XlZoSSGy2amQwo/IKVV/qFKhAVVJrkD/9BSpoXaCW/AK1U+2j+X9TdN6FauG+MjbIU8nZKrMVUJcLy4PzUeypSQcc2lRHiEUwMBdyunjIi0jifDXfwp6ueIkyIeIf5hcmtGDSv76/4VptU68JhzKdyEB+vEi9hjnKg4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U2M11bkXL+frXa3j3KZ5qvhwz/o6ftyc8foFVFoRB7U=; b=cwrl82DSQumGAJsBujaNfkjFmrfPGXc0F2J9P7T7IDA9kFl0HmTjfbiC6irMLi1kePBSBqqu2mcvbfR9wK9zersTEsvlkrkq6Dh3mNSSlN57R17a9XeEomsRrsv2nf91uWkVTSRhCM61jVnWiO8E1hie/4h3B5ntVOre67iUIeDLIlqOd2YRaSJUbAHNlsqsEHZ/xj0GVliMAl1OnlN2TtnAtTY8jSyc81aXaM7Y+ldKTkZpq/pb/+oct5kh0ye9yeyOnk3WX5reOnlzM0OeJpa+91rhDjURLKn9AOYkHw3ZBExni9J8PyhC1oPKNyJpjAXvIUftv1oorK25GWicwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U2M11bkXL+frXa3j3KZ5qvhwz/o6ftyc8foFVFoRB7U=; b=Wy9NE6y2+vgbe3MyPypep9i4d+mOSxevXgje4H2llBQYOFuGepbGeCwsuB5EbablnBCehyVZkjTbZOPgiJdfKuAIewQXbrMeI63dKywppOrLduKHQ1hlXYR79evapSdmGTrxZBCKKu8rUj9qmr0gSAw5dyISBIvpjcZaWMnFHMc= Received: from SJ0PR05CA0166.namprd05.prod.outlook.com (2603:10b6:a03:339::21) by MN2PR12MB4376.namprd12.prod.outlook.com (2603:10b6:208:26c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9913.11; Wed, 13 May 2026 18:29:27 +0000 Received: from SJ5PEPF000001F6.namprd05.prod.outlook.com (2603:10b6:a03:339:cafe::75) by SJ0PR05CA0166.outlook.office365.com (2603:10b6:a03:339::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.18 via Frontend Transport; Wed, 13 May 2026 18:29:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ5PEPF000001F6.mail.protection.outlook.com (10.167.242.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Wed, 13 May 2026 18:29:27 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 13 May 2026 13:29:22 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 13 May 2026 13:29:21 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 13 May 2026 13:29:19 -0500 From: Radhey Shyam Pandey To: , CC: , , , Radhey Shyam Pandey Subject: [PATCH 3/3] usb: typec: tipd: name TPS_REG_POWER_STATUS field masks Date: Wed, 13 May 2026 23:58:50 +0530 Message-ID: <20260513182850.165349-4-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.44.4 In-Reply-To: <20260513182850.165349-1-radhey.shyam.pandey@amd.com> References: <20260513182850.165349-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F6:EE_|MN2PR12MB4376:EE_ X-MS-Office365-Filtering-Correlation-Id: e0dfea8d-7481-460f-89ea-08deb11d9103 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700016|18002099003|56012099003|22082099003|11063799003; X-Microsoft-Antispam-Message-Info: +EZXHpLaJXKJK6F2XR9hgjTx69KMvRS4IlYZgLCJMvG+brGyJA70o1e69DY2xneqrOVeyyEAKvzd4lEu2yzG4lZnYpPmjhe8u3m+rrKHmCEl99rIXzdBbxPWhLMsLERGJ6V9lDc7Eyven/nqArPdN3mpHG9GNuQJ3yraaUfHk5kncdqE7bAVgYf89W+dplOITSjMuHIbK9zkwCU1fmVGU16AbuReNvECsdTq2NKkc2kU80YzMHeXOhwVYBX96rNehd3JFY4TLCpgi+8aM1xpOuO8VH9FzRT1RshKjqkO0NrB8j8Ny5m++Pz1KRzHtPiU7eOseSxAh1Q/tGh51dYCSTDaunXry02NXgX1OACRrWu0p+/zF6e3Xw/G6vkR7+/gGDhfaLNSLIbt6KvYUFnksiljlK+lDgsPbv0FRYaMzXXdyfUHSZYbPjjIPpP0G2nOSgfqGUtJMXFxBS7roXTN3b1t39KF86Nfpdu0lZx35SzF/km8XyqMR9tj2rsiLJF17BkUm/XQw25qmXpBbW8t8kV+mTovdH7FP09Pn4sc94WuTspSk6O7ieXeZMrJKkU4locXDB46vX5OB+kWHtIpSwViCm+BWyq5dZ+CfZXSS4s6iY0dqFo4ObnADzXMv8OwfeCCnpwo/Pk0gyvr8zdoQbEdiHBSNJWTrUP8EQbemMWOBqH8+H6OdoTd45rk6709DyEHAjIrrWGJiCzFpH35+3bGujRcXddRKHEsli7EAtk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700016)(18002099003)(56012099003)(22082099003)(11063799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: p/iE/xgEGh4kYIY8AbZj2n2e0O6DTKjB+Dz81jXMaSQhAEYIbQCxndnMvZ7mVtfqIdrVwrdgrdAByeVN45vx6bUyftOIMk8N/RCE6zLLMJAQlh1pJm6ogw8FylTZMuBLAlX8aiSvC7I/nszJ2yKDT5X7FgczbXB2WZ4oDDmbVDIpttHzUfssMwRRRCVadn6aJnpmw72ZM/rO6iPIMYobtLuG1eDY53n2Xj1o9U+bBg1pQeK/g72DOUJwP/AgEuLP9WInnErGKjcWbCDgpMcfogc7seMMCRxPNwUt6n03UWdhQqR6JtDElBwlpdeP9iddTZOgvRbe38S4EA4jkP/h+9USp38iqwFhPCMTcTy3TXnsUSBfwlIym1cNocdm+tqMa//YXgiUxJpBzorLdZJiiKh2a0SoGGeUjC8TpWjTJ16JqGf62iPrjvzLKCXLr0f5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2026 18:29:27.6929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0dfea8d-7481-460f-89ea-08deb11d9103 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4376 Content-Type: text/plain; charset="utf-8" Define named masks for Power Status fields (connection and source/sink) and reuse them consistently for both field extraction and value construction. This avoids raw bit usage, keeps the definitions aligned. No functional change. Signed-off-by: Radhey Shyam Pandey Reviewed-by: Heikki Krogerus --- drivers/usb/typec/tipd/tps6598x.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/tipd/tps6598x.h b/drivers/usb/typec/tipd/tps= 6598x.h index 03edbb77bbd6..d4140f4da5bb 100644 --- a/drivers/usb/typec/tipd/tps6598x.h +++ b/drivers/usb/typec/tipd/tps6598x.h @@ -142,9 +142,13 @@ #define TPS_SYSTEM_POWER_STATE_S4 0x04 #define TPS_SYSTEM_POWER_STATE_S5 0x05 =20 -/* TPS_REG_POWER_STATUS bits */ -#define TPS_POWER_STATUS_CONNECTION(x) TPS_FIELD_GET(BIT(0), (x)) -#define TPS_POWER_STATUS_SOURCESINK(x) TPS_FIELD_GET(BIT(1), (x)) +/* TPS_REG_POWER_STATUS bits (masks shared by TPS_FIELD_GET accessors and = FIELD_PREP) */ +#define TPS_POWER_STATUS_CONNECTION_MASK BIT(0) +#define TPS_POWER_STATUS_SOURCESINK_MASK BIT(1) +#define TPS_POWER_STATUS_CONNECTION(x) \ + TPS_FIELD_GET(TPS_POWER_STATUS_CONNECTION_MASK, (x)) +#define TPS_POWER_STATUS_SOURCESINK(x) \ + TPS_FIELD_GET(TPS_POWER_STATUS_SOURCESINK_MASK, (x)) #define TPS_POWER_STATUS_BC12_DET(x) TPS_FIELD_GET(BIT(2), (x)) =20 #define TPS_POWER_STATUS_TYPEC_CURRENT_MASK GENMASK(3, 2) --=20 2.44.4