From nobody Fri Jun 12 18:39:01 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91CE83D1A81 for ; Wed, 13 May 2026 11:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778673202; cv=none; b=UpMglsmcbmHYL+mRioSuSxJEni31b53ssnUPdUPv8SRfNJHSYQLibfQsYbw4bsmwgefMUYHbq1YrNjW5LC6xTaAO7XDVjhMUFtLz2cObFD2bhd5L3Ea4aNoCoROqHY8bEC9L3DPdMFGkaBjAPB/Eunl2pbkYqZHuG+2oCr4z+PY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778673202; c=relaxed/simple; bh=t64FkIjt8YPPd0Kv+ZYgqe/PVj+DMiY4kKfszshbsso=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b35voBIK9jxDb88dJugsHcab/WpqFKWtlm5dHYW2zRlKXTfesYDwmXjUgC6VAIYZAGtNkmXEREMvAtqenvCb9tsBF2xlmeia3CS8j4n9qlHDryf64WQDv73DudT5rTYXBgEDEowp8Vy5/EkK2XmKubkF8eOF9dBw41wTRXfqMPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PPnVuhjB; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PPnVuhjB" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-459bf19e87bso1939360f8f.1 for ; Wed, 13 May 2026 04:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778673198; x=1779277998; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e4+4FKRbGi0weZRueGf69BctThyZfUOKTtJTR9Y3Oog=; b=PPnVuhjBgziUQ5Ye2/2J7RQGT0zy11UyD4dEiWn0jaNngTGtcHoEQE660H7YWWSHCU gfyBo+ElX9LFonQzuHG3WDb/e5clvc9fh4IdUcF/XnXk+u9PIL1jd7NN7ZAGp+j9XtED RqzKNEnJZcCYgweQVAN/xCTBwUEGa8pLTYBj0qc2DvYQOcKqCbujCEpHipMc2I9m6ayx JQrK3+v8Pg1SHJjDasrr+Y70kcx7BonCL8ZtHRTybXik5efuGgjXN3NxBO/EOYEY5WeJ LCi2/1KKsUiVQ6cRSbMSY0M17p4pJP9/sMU8RtA+VjxKK1FdruWIdfuwv7rhN3oBKYXo oLWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778673198; x=1779277998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e4+4FKRbGi0weZRueGf69BctThyZfUOKTtJTR9Y3Oog=; b=hHRbPBtKLgx7KDOHqoMZ26Mp6LRp8LHoeeYYcIpUlGmWr2XFnOqiYTwc/MfvnLYzpg L3UQF+ik0LxEr9EIIm9yNEbUhDmDY2pg+aYuhsNC+J+I63zLbSLhADG/hi0iLM9HNa9B +EyCUWtG/7vbvByzLi8nZ+WsxIsZKWwrc6NGxw1+Nrti+SREsjNVPqtdXqGwtySctP2K f8v+mmJxep0DKmANyJtc8e3n7YRiOX9ILRT0B8Nu/rUONiZI27BHqru8XjPBrsWLuOgg bZJg8FBsqLJUUi23acIHi4/rzCLuPfDr8Fm/ciMqfWngG349J48Xy9YVxA/S7CbhhjRT fcEw== X-Forwarded-Encrypted: i=1; AFNElJ/rIQZC3O8yLk3JqcI49QGE6aZIYkqcLyZVq1EYrcZkG4UXqiyvY2vqyma2zKxqlewFICo1AiLcwlSQlJk=@vger.kernel.org X-Gm-Message-State: AOJu0YzSgysfvUevsB4998sj0jpPupBMPS3p5Dc0RYBYNM/iSMrKXuA9 AmwWvwGijlNdDIhHDzBQHKxKc3wj/1tmSOVY9rBgLvm5IGsYgf0u0m5b X-Gm-Gg: Acq92OGMrZ43x1bHBc2jelx7c7FDRNK+U9s9sZVLitXeMFQwSZxds3dxgzegQihLY9N r0y1VACB80gOzegmJJCkj4wcTPA57zsOE8QLzS3d1OZ5oHBz5kLvywC6OGgWvRO9+QCxvxNesQn QPzZgQUPjy+7Cvpq6y5nCwoxSu53R0yJSOW4601F1JS3SlTy9aeIcwBdoeHdnwqFEv2wW+tvNI6 DA38y50tVNKtT+irvxtGHuJGbk/G49lcvUrM5izaNdYMtPJ9C6LrGA2u2I7LURXf2bH/tGMuX6N FZftJ2EH4AQy2P7XXkBXTS5OXvwo17YWuAfJYT5ctc3bXpf1RnAPcH+ikL7E0addlk72kO3oVIo Sq0+niwHO+XeA1ah05szfU2hLa5Mm6l4AKJOJzd0WHh1On/wZht6aunaB+rRiMLbAp3+m0OUnIe V/klfeDQZuYuuo/H9cGEvaZNiX9lkSQh7PCovQcfYexTk6TWZjmfv7CpJ8yjAGJTIYlo5/BItyn x8Bsm7LOnaIQSvGd6zLUCJfa9YAsac9iqu0mw== X-Received: by 2002:a05:6000:1847:b0:441:2aee:d561 with SMTP id ffacd0b85a97d-45c59cd2d7amr4822718f8f.28.1778673198018; Wed, 13 May 2026 04:53:18 -0700 (PDT) Received: from iku.Home ([2a06:5906:61b:2d00:3e5f:9005:e5d2:460e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548ec6aea4sm46402603f8f.10.2026.05.13.04.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 04:53:17 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Linus Walleij Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 1/2] pinctrl: renesas: rzt2h: Remove unused variable 'j' Date: Wed, 13 May 2026 12:53:11 +0100 Message-ID: <20260513115312.1574367-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260513115312.1574367-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260513115312.1574367-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Variable 'j' in rzt2h_pinctrl_register() is incremented during pin descriptor initialization but never used afterwards. Remove the unused variable and the associated dead code. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven --- drivers/pinctrl/renesas/pinctrl-rzt2h.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rzt2h.c b/drivers/pinctrl/rene= sas/pinctrl-rzt2h.c index 4ba11a83b604..4b790fa72b49 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzt2h.c +++ b/drivers/pinctrl/renesas/pinctrl-rzt2h.c @@ -1140,7 +1140,7 @@ static int rzt2h_pinctrl_register(struct rzt2h_pinctr= l *pctrl) struct pinctrl_desc *desc =3D &pctrl->desc; struct device *dev =3D pctrl->dev; struct pinctrl_pin_desc *pins; - unsigned int i, j; + unsigned int i; int ret; =20 desc->name =3D DRV_NAME; @@ -1157,11 +1157,9 @@ static int rzt2h_pinctrl_register(struct rzt2h_pinct= rl *pctrl) pctrl->pins =3D pins; desc->pins =3D pins; =20 - for (i =3D 0, j =3D 0; i < pctrl->data->n_port_pins; i++) { + for (i =3D 0; i < pctrl->data->n_port_pins; i++) { pins[i].number =3D i; pins[i].name =3D rzt2h_gpio_names[i]; - if (i && !(i % RZT2H_PINS_PER_PORT)) - j++; } =20 ret =3D devm_pinctrl_register_and_init(dev, desc, pctrl, &pctrl->pctl); --=20 2.54.0 From nobody Fri Jun 12 18:39:01 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38EB33FFAA4 for ; Wed, 13 May 2026 11:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778673201; cv=none; b=cUpXFnK7nhMb8XX0YDhyVSVPJFa65XB9xum5rK3s42PWGg9KDuNjtaj64LDngJntNJ4qzqpTD6wqbPV+paaeduR1lb83l8+zoeVJZ9i1dcu3bwVio4Id44W6x9qma3R4Z1Do+s/cGheTleTq9zxjBletN2LWr5v94mV3ovuocvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778673201; c=relaxed/simple; bh=wd7K+rVMSTZERWCQyiRXKMRy+tlsG+IybU2O7dvOLz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HxuwwdTaUbf2BDIfIdfB/lA5A/GzB2Gy5pGufheJ7DYz6MHnVAO0XfQuImzsil/uw1qUwZTjo747954hmIqqKkL4DNK4VRmDF2xDiGlW0VQp/fBseO2BJ087GPUUXvH3nHfULWAr8rezbOOR2RnJSXCoy0ExuCyDhrIIuDURv7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sacaO8BL; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sacaO8BL" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-44e5624c053so3745215f8f.2 for ; Wed, 13 May 2026 04:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778673199; x=1779277999; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0epLdr6Sz9bYkE7idxtlbU5atEv15BhKtp2tZA62k9s=; b=sacaO8BLnL2OKTW6tnv3yx9+A3z58+26xN6bjTXmSXwfuLRD88W8KS52u6+sJz6fkO P+ftIi4oORBkiJEZEEDF7JzYEqhx11N0z6gvx+wEydbKOw3VToJiUGMoBvmj4o0/Wknx KbwAwL370PysVgDRks1N30PgKU+QYcPOzweWDHMk6kCHgwfLrK2V0heXynqS1JhaIoK0 eyWeKVqGkzrp+Zg+ld3lvALoDADiBMqnhcmOy4OSy5TOUlw4lPJcEuNOH5ZPIVIp3mE3 8r9wjnT5YoQymqsEokYq8MwyKF77Oa0YKPImPg06rJNO9Ov4vqaqHz8Mrc5MKoqhShDW Y4CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778673199; x=1779277999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0epLdr6Sz9bYkE7idxtlbU5atEv15BhKtp2tZA62k9s=; b=qsaoB8irMbF2syiiDJl6TpOCZcdExHqqt8QHk8yAnfDty/y3Y/w+/qq/Q/AtGtrLBM W259NdxqX1y3Wgdmu2pg/ZsGQWmUN56bm85lHTpF3Cb77JXLwtyM0aeeNUWPdXh9gSXs ScO+UciRo9faUspUFCltbu8QgSfyT21idl4eOMoQ0/l0V0LKWFv9JCrFsWzgpb3BEM6u E5y75FZKa2D/bnn4RVAMZ3OBKU/+tKbanRToQoe8aISsYb2JjCBblg0SfoYpAw6SAV+5 4RHdp01tuuU+9Jtqn0sjdf5LULcS1zzkrZxGp4HyHZRMDDE/Gn+jJTgb/oY7JD0Wbizb Z+Pg== X-Forwarded-Encrypted: i=1; AFNElJ+iCgCIJrXSQ5aYTumi8DdgxEW53xNisPR0xn1qjhYFERqOm55NxJ4NEEuC5WM9+XQeS8A8UjjXiWumgJI=@vger.kernel.org X-Gm-Message-State: AOJu0YwFh0166crRPqtRGLPDCkDHV5pAQjOm2sGilFB8TZSVTMsLPIYe GREBw6SQNYNST9gJld6HyOEA9lGXCUFldEdM5Vz3lBXn5v5eQePUhOpRO3pOl3TVc9M= X-Gm-Gg: Acq92OEQQH29lYjnpvZYxyfbNr5Cem7zivLN0FBPE7DfzFMoQ+gZE0aAlDDr1kmpsu6 dzM0jhvuyAVUGXeuUwJfBygTJY7h+s03UHP+QzhVqmT+amX6cKbP0hU5YTNeqmQX2cQAGb05Qca TQYivF12UcHx2Nmxyfr2VGmFCfX9UTWrOSBVDx5K69EeCbsPBUuWbrjG2AtExL2To+2AlaCjur1 0yr6kCxLceWO26WxaqPsMvIUBU4N4hpxhjdkT6wJiBGAueb5cqHCQJqU0uuDJ2pKLFjqJA5S7gp NGuMdGd135lf74mmGN1T4S+FjVM5Oc9dzBY77JeGsqZpDahDVBT6Hgcn9lU5b/QmVZTEsEWp/Dv LhPclcIK4ToRiHozTR0kzExBi3iZI6pClK+rY7hkCfuizZQDaedcW4fmqi7VOco5HXl3dSEBTc1 GC8oQXuJhd4n0GtO6eBobt3OIlF7ht+utWKOIBFjWbEM7KYCbqNkzoif5eARhsLxD9g1RMWRxBr nMU2MpC7HYqGZoI0rzNfJMQUKG/eiaNmA7KEA== X-Received: by 2002:a05:6000:1a8a:b0:452:c246:ab6a with SMTP id ffacd0b85a97d-45c79f29761mr4062284f8f.26.1778673198667; Wed, 13 May 2026 04:53:18 -0700 (PDT) Received: from iku.Home ([2a06:5906:61b:2d00:3e5f:9005:e5d2:460e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548ec6aea4sm46402603f8f.10.2026.05.13.04.53.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 04:53:18 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Linus Walleij Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 2/2] pinctrl: renesas: rzt2h: Skip PFC mode configuration if already set Date: Wed, 13 May 2026 12:53:12 +0100 Message-ID: <20260513115312.1574367-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260513115312.1574367-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260513115312.1574367-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar In rzt2h_pinctrl_set_pfc_mode(), read the PMC and PFC registers upfront and skip the pin function configuration if the pin is already in peripheral mode with the desired function. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven --- drivers/pinctrl/renesas/pinctrl-rzt2h.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rzt2h.c b/drivers/pinctrl/rene= sas/pinctrl-rzt2h.c index 4b790fa72b49..3945c891248b 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzt2h.c +++ b/drivers/pinctrl/renesas/pinctrl-rzt2h.c @@ -188,8 +188,18 @@ static void rzt2h_pinctrl_set_pfc_mode(struct rzt2h_pi= nctrl *pctrl, { u64 reg64; u16 reg16; + u8 pmc; =20 guard(raw_spinlock_irqsave)(&pctrl->lock); + reg64 =3D rzt2h_pinctrl_readq(pctrl, port, PFC(port)); + pmc =3D rzt2h_pinctrl_readb(pctrl, port, PMC(port)); + /* Check if pin is already configured to the desired function */ + if (pmc & BIT(pin)) { + u8 current_func =3D field_get(PFC_PIN_MASK(pin), reg64); + + if (current_func =3D=3D func) + return; + } =20 /* Set pin to 'Non-use (Hi-Z input protection)' */ reg16 =3D rzt2h_pinctrl_readw(pctrl, port, PM(port)); @@ -200,7 +210,6 @@ static void rzt2h_pinctrl_set_pfc_mode(struct rzt2h_pin= ctrl *pctrl, rzt2h_pinctrl_set_gpio_en(pctrl, port, pin, true); =20 /* Select Pin function mode with PFC register */ - reg64 =3D rzt2h_pinctrl_readq(pctrl, port, PFC(port)); reg64 &=3D ~PFC_PIN_MASK(pin); rzt2h_pinctrl_writeq(pctrl, port, reg64 | ((u64)func << (pin * 8)), PFC(p= ort)); =20 --=20 2.54.0