From nobody Fri Jun 12 18:54:09 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E163B27C3 for ; Wed, 13 May 2026 05:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651809; cv=none; b=CjnTcHOTiAXnDgSLkggC/22TvwvqPlNo1EouVd9mWhufXLxh9nGgJOT80+MwOCMmIM8P7DsUUgqUBhG3YNNtgVzIk8Xul89orUs2WNBupvYBTN/Kh+3NDbBFp832+QlbQlGySFLKSv1J5ih5l2NYQuf0v05jfR1A0gLtFdCJGqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651809; c=relaxed/simple; bh=YoneJ14NuJ2KGDyxsoP31mSMcon3m5xuAOTGJJPt2kY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tvDJWJUTDGxaCp0Ch6nCSele/tgFWRbiTkBo6ZV39uigRyWU2wxKzALv0ognAbyOorIWjSKsbQA9MRRhHvo//Mh7hdGoM6F3lO2cgsTap+V78Wi/KWJGJZIx3bc19t+xZnLf6xPb/493mjGRFqI7bp3jKeZllz674DU7lKtf0BU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mo2eQ8a8; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mo2eQ8a8" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36627a0ea23so2549894a91.0 for ; Tue, 12 May 2026 22:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778651806; x=1779256606; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ra8FK+IjnzcQJElh4Bz008lPaSmGodsKw8/Zi9VAbNE=; b=Mo2eQ8a8s7Jsbw0gt3miP4XT3sYMHkOSzDUSqtDB9X1BMyH9HOeW8a30u8oqo0+USp kxv+SyMAgoUq7st2imtV+jkXxgnNDTwzLL5J8za6U0VKleOPtEIxtgaHOxCYwmVDfXaN x/mVh18q/RgqJLfL6hyeofaPxWIkyuOFd/FNlnHBZGRdxP9SBXfXW+VOgemudWudClIM wjDdw2M9KYRsaVNgQHtcRsjNFjYeUFJ9SG97FR6YuxrjFgl1dhMjBjLVRhC+Rvr3RwA1 o7+PchGetUlqQlJCNMVL+hmcAQJiB+OGN/rVx96uDmSYdAw4fiexNWcPKxe2n+jd4tp2 pWyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778651806; x=1779256606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ra8FK+IjnzcQJElh4Bz008lPaSmGodsKw8/Zi9VAbNE=; b=faK+WS2T07Yg2hfCM5XCBebv6GwmVk7m5WlDt72RyNdM3goHZMx3lhLSmc8Jrn5Kda xhU5Ndd8VLtdv6/pynY2jk4W+T/SlC0Eq8xnrM9Cej+WLw31mf3yepC2+waH+TQdG4EF el+azpGTLg57e5GR5GlenJ7TrOz6rp/TsfWeJFQvLITexWtt7XS/HmZJneWKnZ6GwGRd njz6Nlx4enx4ePwu7Xah58uCGrHIGxZZvouNTloIH0GBIQX8rJBDSnGtIc1kOLRykXsa ZSkhV0uuhEABHFz1AC4ea+DZX2TPksvLQ+yF09trL0WWwbi9XgqE3D8X+kdlwRDefzGm BGmQ== X-Forwarded-Encrypted: i=1; AFNElJ++DWtF6BNMkD6NfAN3Br+WDUlAfgkOd+weTGFT6HuxmcRjbOk2AJ5ljvMMOnoFf1XTYWiRVrlHHRIcRMs=@vger.kernel.org X-Gm-Message-State: AOJu0YwGq9IbYW3PB2aQo94jOMxk25lBZ1Ore+8AG0qRjr6oxZJXrJ3m hH73KuQMrE/sh0k15xyCqFZUsYFyBx4RHMJZdNhJe2z7Taw6mIC1JBoV X-Gm-Gg: Acq92OFY+VfcDwGj90W9WMpAC3SdfMt9WrGQcHBqcwvaJ7sx9HnDHC4RQ1y1xJaxS6g 7g6u+elTmMASCjO/Vu+opEklSfPczn9hGdw7IIefYqFLyE7OYbsYuYnJffI4cuPhsDhJTxSPyWv K3EXeaF795BC5djZ9+O+e1++G7kGOqaDjCpaCJceAJviif1UAhUo0FWw0eYcenNdJARMvPHzrPe LuI63C8aOXaAb3bUPXP/2BaG2oET4veGAI07bc7uqva2Df0s68kEL5XvvQ9Jm97QKJwnmlQyc96 mHa13qRd9+N60dl0OVrppezPTLZvW8pgMw3ylgVFQE/eOX/OAb6hQVwGi2g4BzyNtlvSUDlUibE FlPH9/3W8bkcCO34YIzikXffZFJOB6Qhw7jwxXE0hx6RoSAr73pDhFgbUrixZQki2ZGgBuxP5Of YxF1JCHX8vMTO6kX2FWSKWyKeVD6kBlX8zuRtIZZb70lNEPyhYGoOFp4D+WJkGRNLzm9rKD36TM l3H0U5EhGnL X-Received: by 2002:a17:90b:1d4e:b0:368:2289:42cc with SMTP id 98e67ed59e1d1-368f4092542mr2283215a91.24.1778651806092; Tue, 12 May 2026 22:56:46 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-368ee32822asm1785492a91.12.2026.05.12.22.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 22:56:45 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v2 1/3] clk: nuvoton: ma35d1: fix ignored div_u64 return values in PLL freq calculation Date: Wed, 13 May 2026 13:56:24 +0800 Message-ID: <20260513055626.1070533-2-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260513055626.1070533-1-a0987203069@gmail.com> References: <20260513055626.1070533-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" div_u64() does not modify its argument in place; the return value must be assigned. Both ma35d1_calc_smic_pll_freq() and ma35d1_calc_pll_freq() called div_u64() and discarded the result, leaving pll_freq holding the undivided product and thus returning a frequency orders of magnitude too high. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock contr= oller") Signed-off-by: Joey Lu Reviewed-by: Brian Masney --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk= -ma35d1-pll.c index 4620acfe47e8..bfedd45bd04b 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -92,7 +92,7 @@ static unsigned long ma35d1_calc_smic_pll_freq(u32 pll0_c= tl0, p =3D FIELD_GET(SPLL0_CTL0_OUTDIV, pll0_ctl0); outdiv =3D 1 << p; pll_freq =3D (u64)parent_rate * n; - div_u64(pll_freq, m * outdiv); + pll_freq =3D div_u64(pll_freq, m * outdiv); return pll_freq; } =20 @@ -110,7 +110,7 @@ static unsigned long ma35d1_calc_pll_freq(u8 mode, u32 = *reg_ctl, unsigned long p =20 if (mode =3D=3D PLL_MODE_INT) { pll_freq =3D (u64)parent_rate * n; - div_u64(pll_freq, m * p); + pll_freq =3D div_u64(pll_freq, m * p); } else { x =3D FIELD_GET(PLL_CTL1_FRAC, reg_ctl[1]); /* 2 decimal places floating to integer (ex. 1.23 to 123) */ --=20 2.43.0 From nobody Fri Jun 12 18:54:09 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 014073B38B0 for ; Wed, 13 May 2026 05:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651813; cv=none; b=JtRpUycZcjgmgpV5INGEI1GiW3wgIDPxFiYhPDBhmjjwJh2DvDwKQHXo69bklPeMgjsOKBBEXKF+V6o0bSggRBmMNKVaawF/0nIpcrC+qTE+nlWLleau33CEFNa8MyN4cHHbVdzV/0M06HRncQ9PWPOU9kQ23nbyPx1C66w0d2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651813; c=relaxed/simple; bh=iwshQxBJRKng2AeZeJRg2jhjyadmBg+GsEws2R7KPQY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F0kZZPw8VVMcGUHKYlFaY0UyxMsSl2LGjACdfGYXYb7xul+WVwaw1L9LWyM6ynBUk7DOEWURPBkLucWX0swgtqzbr72Yii6oAb46s2Rwt1k85G/S2P/OK7EIU8tCIfJ7ia0O9q9AXfmbLRPiAgKcPLToOLKyNu6yOfBSr42WSLY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EV6Urh1A; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EV6Urh1A" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3660daea6a5so3445854a91.1 for ; Tue, 12 May 2026 22:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778651808; x=1779256608; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/LoS/AHTeCtpWKc6PkMtF6EkZQfXCl5pc+5m7F4o70U=; b=EV6Urh1Av4mx+pUBLNBkWjvqaY+1QN3SUzlODlGacThToGGsuyo8fFCWUL6TM3Z//Y iJTbq4Q2gApo2YLt91itnfy+2/kDwXed9WYG3LqIRBoo9XU1QgN3p2Bbz5OEfmo+Fk6A umc3Lh4mt7uQul4TfKmf4nJbgtM7wZcpsEk+G6+yCL6xfObWWxF/Jjey01B9zsenqSt4 OZjoPGP8ZR8zYYlbYWL8BZrKiCbrtI1uWq9FNYhBzk4GEtj4BlrBXcPeue7xJ5FbiZx+ ThVue8TlkRXDsLIUDJDBkgGBYVi6tjYOzV81oOlUbxiBL1S2GIIyYgiUgxOgfGiJSGxo y2BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778651808; x=1779256608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/LoS/AHTeCtpWKc6PkMtF6EkZQfXCl5pc+5m7F4o70U=; b=EnELiIo8lrXLwWsKmkZwk12K3/swMUjmHclABSckQYEEkW+vaM6TkiGuFbQZstWXXY YGMViGF08ZHJp5C+bRDSIkHe3Jast0KCs85urxEv7K8Ugrl7EAcM5VRjArEYs/yOI+eu bGB7tn+BV0x3jkmgeoY8A4p5nM9jmcegF22uQB+9szhvHjtQSsCHKcR93Rz0ZegjAs5W kfePzwURwWabNLLKP+vWpejsO8c3xQ07mAeMtKCl7p8wyC5MvnEa9D1cJIyndkEwyPc6 UujfgQJ8pqO8+A1ARJk/NnyYWF0esxU68N+yDUGEaQQ73cqOO2k3iNb+TKb7VBG4pvuG KYSw== X-Forwarded-Encrypted: i=1; AFNElJ8vlt/NailFXKR0cePUBmf0lL4MUEdMkElfmqrUgWv4sGHj8dSAhGOT0vgQIyhBm8GbqslnZ+pokS599rs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx70MShWAa3uf2BS+7/1fWXTjVVTYxePQynaDFb6z3g9PQwTk0D QnqLoFSITjv12ksHtSSzSYY5GFSq9zluLbfmYLk2bzHitsb1q+FOwmE/ X-Gm-Gg: Acq92OFgfgd+wKaEWGP5WuH0NmQCOs+OXf00oqe0WYoZQ3BPf43an0EfCcby77wOZRa 0qkL/u0IaYcqBy1wpoo3rNakV10yUx4K3pP9VHtyqT143Fjj8ryRhDOCmTD+6bk8FfL6YAWegF4 J4h9NUc/so4+kxmO+fFPAT6fnUYu42JQOtCAmnJJUsKg9loQ7y2i4HIGX+391qaf5NUdohKw0rU +3fbxdG62/VETRRbdqo5GEHip780vZO1Q2tJpcxcz2TG9CK4pCxHoSRJsjHcM5q+ew4ttNG/jag mJPpnhmA07X2SrJMVWOvLU1IYEUnd5YNsgn6YNoB/SvDjbpOuRv8FZIhGcJQRI0S3/WRYrM7DVt NgZDs94lJxihzZvxQ0Ih4ag+dlmJjb9k+R5FEJnCgTicoABKFoTZwHn4w6m0QoZIRBYOUj4sStJ iO+lY8Ie/+uCgjU11G8GxdSu9eBV6SXagnqZ8juv3659GPT0+Z8g16JII/sZKmPXqzyO2cB1ltC kTOqPLQxO1OI/4UmcIr+sA= X-Received: by 2002:a17:90b:5688:b0:356:22ef:57ba with SMTP id 98e67ed59e1d1-368f781c7b9mr1480053a91.7.1778651808190; Tue, 12 May 2026 22:56:48 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-368ee32822asm1785492a91.12.2026.05.12.22.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 22:56:47 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v2 2/3] clk: nuvoton: ma35d1: fix PLL_CTL1_FRAC bit field width and fractional calc Date: Wed, 13 May 2026 13:56:25 +0800 Message-ID: <20260513055626.1070533-3-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260513055626.1070533-1-a0987203069@gmail.com> References: <20260513055626.1070533-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" PLL_CTL1_FRAC was defined as GENMASK(31, 24), covering only 8 bits. The hardware fractional field occupies bits [31:8] (24 bits), so the mask must be GENMASK(31, 8). The previous fractional-mode calculation used FIELD_MAX(PLL_CTL1_FRAC) as the denominator to obtain 2 decimal places. With the corrected 24-bit mask the old divisor is wrong; replace the arithmetic with a proper 24-bit fixed-point rounding to 3 decimal places: n_frac =3D n * 1000 + (x * 1000 + 500) >> 24 The +500 term provides round-to-nearest before the right shift. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock contr= oller") Signed-off-by: Joey Lu --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk= -ma35d1-pll.c index bfedd45bd04b..7e6b30d20c01 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -48,7 +48,7 @@ #define PLL_CTL1_PD BIT(0) #define PLL_CTL1_BP BIT(1) #define PLL_CTL1_OUTDIV GENMASK(6, 4) -#define PLL_CTL1_FRAC GENMASK(31, 24) +#define PLL_CTL1_FRAC GENMASK(31, 8) #define PLL_CTL2_SLOPE GENMASK(23, 0) =20 #define INDIV_MIN 1 @@ -113,9 +113,9 @@ static unsigned long ma35d1_calc_pll_freq(u8 mode, u32 = *reg_ctl, unsigned long p pll_freq =3D div_u64(pll_freq, m * p); } else { x =3D FIELD_GET(PLL_CTL1_FRAC, reg_ctl[1]); - /* 2 decimal places floating to integer (ex. 1.23 to 123) */ - n =3D n * 100 + ((x * 100) / FIELD_MAX(PLL_CTL1_FRAC)); - pll_freq =3D div_u64(parent_rate * n, 100 * m * p); + /* x is 24-bit fractional part, convert to 3 decimal digits */ + n =3D n * 1000 + (u32)(((u64)x * 1000 + 500) >> 24); + pll_freq =3D div_u64((u64)parent_rate * n, 1000 * m * p); } return pll_freq; } --=20 2.43.0 From nobody Fri Jun 12 18:54:09 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD60C3B27F1 for ; Wed, 13 May 2026 05:56:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651814; cv=none; b=MF488cS/yVPcAFxshObEtR/lThpwQcDbi6gEjYhs7NtyEGZlnXlBqBF8ZQ4bMw5zkhm+2L50NtIQpSoGu4NuCtEbq4AAWGJm4HRhyH0nRFTVvtnBimKu8IZmay2xk5n4I2jg841/KX4n4q9tLNyxfHLDri0AMQXXVzuBLqX639U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778651814; c=relaxed/simple; bh=YMtucbXIteMIObBrm6ZdzFaVCfRFseNhK8oZ7Xxy9f4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qq0WZLPdZWAlgQE+ZjK9kloUZe25r9tqzoJYr+C2qxYv3JJIX442ye4xRa4ej7EQhmW/x30dcnvFxS40IQs3t150pXjm3qdeSh0VPowwLwaCRmvFQZb8y8uNw3bnC4P9SIqwhkqO4GEfIB1ACrZAxn+2HqDhnvh3uCH4Z4BFixc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BmrLiY/R; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BmrLiY/R" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-367cbac9cb1so4128307a91.3 for ; Tue, 12 May 2026 22:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778651810; x=1779256610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E6lsTS2bThXFNqKtA/Z8FkqMfRb5iPzxNdnamFjvzQg=; b=BmrLiY/Rnn3dzVZHQVnWfVu4+rQmuDkz1EE/4QsYu6VAOEPprgf3co23sHDA2YGbnh GaWnONLAMOnqujbjOjhxlsMmlC7BBuIhuwa97b5CPDGzGsfs2ZYtStZaDGc/nt86uXeg /0Xr4YOOwDfNdAKWuB0q1+1I5MsqgWU89QduZbE/CiCJDFnlK9MtUEwC5dWb2/nLcFPq SR1hhbl569zCoAjxfy430yIDrQ1CoGlV6UTgMysSFPK7aAab5fPu5DtI0ivxOJuy2kuC v8EJyOsIxNtQXO6U6RC3NOdAz6a0HUmKYhykvLvZ2MM2b1kL/2+WnuIeoOqkGwUowzVw rjzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778651810; x=1779256610; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=E6lsTS2bThXFNqKtA/Z8FkqMfRb5iPzxNdnamFjvzQg=; b=B9I+dTP06E7qVmYHv1DliRHIo1IwW4apjzldwAf2biGI1vPI6JzvZkYEBJzA3fSyMe /shMgqBtqja73UdBtW4sbULIjznb3ye3U3PqR5zxqQ0crBozAGychiB5UXbM3WWxYuap gqf2C0mf6+hVr66W6zT466XuhXBo+V99T51Kb+nGxirr97LaJ4QwK/pKJC7ytHtyMCDP akfnwRTybYB8Tzs5LuA6mi38XW1MphgtIz9IHQdlO0lYvpEROLYk6JNdBlyhUsCWZ9H9 oxFUGsXDHR1df8E+M7OMah8pS40nOA1zaBtEYy+gGGjgc6WX8Y9rYwK+fZPM7Wp/9NOm i4Yg== X-Forwarded-Encrypted: i=1; AFNElJ/TrGLKxQ7GElZ1Ue9csK2StRwupMBJpvY1pHT+GM03iIISMwK86ehpLLSGnK3/Y1BV4ZoGkBaw08Vte0k=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1TWVKaG/1xHs2TvtfdZfqZ3kMaGBgvKnxjtJV0jH1lzBYww2l paR1TX41043Jq1zJha5aIEfV5omU8ri0pxgNaKZSJGq7rpIpgrYVtvTSUWRgfw== X-Gm-Gg: Acq92OGC80hG6pr+AJBpvMd0OxBOWVVrKA6i+Po082wG5rDPflu1aLELARO22+JNi0e EXqbbbeHQx4cAWLWqOMBBe5N6nZ1lnAC4LkCtWHYSW/GSIs0lVakZ3liIKxVXSyFAdSKaE1ZFXw UQEC7NyihTHsBXCT9az0uoM+8/vLD29awOyEL/VP7oJN1WcHzbnt9auM68DKMZSnKOWUNFEkZ+H HMwRgMCeQ4jhvXbdbJ0E6OVTTiTtfmfoM7bDPgU8ZvGtP3v+BuS6uN2oarfKBffb7M9iEF4yMYP dOAZgfqM1sPulQbzv1cG7KeDPUK/n2iP+mlU2FlG9L9CchWDR5fUeYj/SPLkjw5ZiLG0suOBLqe mZbzcoa49Pp7XYuFh0nDjQ7RV7rfyDCiDlWs4SvMT6TujTMQMrHp1DRe1xGcbE6Ai0UhK7EvYZl Ap4yYTOFHaOekny/0t73W4gp36slM2j7r/rYBwF741HmoM3kn2ydhL67NDHew0dD+36c4AiuIS3 yk1Mdd5vz7Q X-Received: by 2002:a17:90b:524f:b0:366:469d:98ec with SMTP id 98e67ed59e1d1-368f799454bmr1558490a91.13.1778651810384; Tue, 12 May 2026 22:56:50 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-368ee32822asm1785492a91.12.2026.05.12.22.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 22:56:50 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v2 3/3] clk: nuvoton: ma35d1: fix ma35d1_clk_pll_determine_rate logic Date: Wed, 13 May 2026 13:56:26 +0800 Message-ID: <20260513055626.1070533-4-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260513055626.1070533-1-a0987203069@gmail.com> References: <20260513055626.1070533-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ma35d1_clk_pll_determine_rate() called ma35d1_pll_find_closest() unconditionally before the switch statement, and then every case branch overwrote pll_freq by reading the current hardware registers. For CAPLL and DDRPLL this means find_closest() ran unnecessarily (and incorrectly, since those PLLs are read-only) and its result was silently discarded. Fix by moving the find_closest() call inside the APLL/EPLL/VPLL branch where it belongs. Group CAPLL and DDRPLL together as read-only PLLs that simply report their current rate; handle them with an explicit if/else to keep the CAPLL (SMIC design) and DDRPLL (standard design) paths distinct. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock contr= oller") Signed-off-by: Joey Lu --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk= -ma35d1-pll.c index 7e6b30d20c01..314b81e7727c 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -255,32 +255,32 @@ static int ma35d1_clk_pll_determine_rate(struct clk_h= w *hw, if (req->best_parent_rate < PLL_FREF_MIN_FREQ || req->best_parent_rate > = PLL_FREF_MAX_FREQ) return -EINVAL; =20 - ret =3D ma35d1_pll_find_closest(pll, req->rate, req->best_parent_rate, - reg_ctl, &pll_freq); - if (ret < 0) - return ret; - switch (pll->id) { case CAPLL: + case DDRPLL: + /* Read-only PLLs: return current rate */ reg_ctl[0] =3D readl_relaxed(pll->ctl0_base); - pll_freq =3D ma35d1_calc_smic_pll_freq(reg_ctl[0], req->best_parent_rate= ); + if (pll->id =3D=3D CAPLL) { + pll_freq =3D ma35d1_calc_smic_pll_freq(reg_ctl[0], req->best_parent_rat= e); + } else { + reg_ctl[1] =3D readl_relaxed(pll->ctl1_base); + pll_freq =3D ma35d1_calc_pll_freq(pll->mode, reg_ctl, req->best_parent_= rate); + } req->rate =3D pll_freq; - return 0; - case DDRPLL: case APLL: case EPLL: case VPLL: - reg_ctl[0] =3D readl_relaxed(pll->ctl0_base); - reg_ctl[1] =3D readl_relaxed(pll->ctl1_base); - pll_freq =3D ma35d1_calc_pll_freq(pll->mode, reg_ctl, req->best_parent_r= ate); + /* Configurable PLLs: find closest achievable rate */ + ret =3D ma35d1_pll_find_closest(pll, req->rate, req->best_parent_rate, + reg_ctl, &pll_freq); + if (ret < 0) + return ret; req->rate =3D pll_freq; - return 0; } =20 req->rate =3D 0; - return 0; } =20 --=20 2.43.0