From nobody Fri Jun 12 19:48:36 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A4D037F753 for ; Wed, 13 May 2026 01:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778635987; cv=none; b=FTCK31oD5lVsN7tkuuNFSYY3zbmK6VkvTmDq9nXZrNiEL34YyMuIHnX2Sei1da/y1rNTKiW0vhLphKdJwZ7pASQ8Km2n6kinsEYh7lzHPs8xgTLjZ+FILzA1ri39dbJRWslEIlh7awrnvWkWLjGBoToZAaOzaj2sOvkvaWN3O9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778635987; c=relaxed/simple; bh=eyAUz1s3eo4gcawWBadiNGT5QH1Paem+sgDmcWO3pn0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=RgBbrthBUFldL70XrKAdocrbiq8BjlORutDO+AdPMg3EdhQ9GlbdTQ1+pdnqN7SzmufrNyB4lvJ199lZ3gX6Sozc/UTdUqUYsKWQ/T1gBpa7oA3xpVizNhpMOinHUFu9cQGjCxSitAG3yyb+tluFYY9jDegbKTvNptUr9F3b3Dg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DdLE/04v; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aPYLzjWH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DdLE/04v"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aPYLzjWH" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64D09Ekv2981606 for ; Wed, 13 May 2026 01:33:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=6KRwB08wa5LSCOrHplBli9 13U01qsOZ1SqPoeDdqIUU=; b=DdLE/04vl++QTQmxFZnHQQnpgEiEHiXQTgaJRy yR71UhjSrVdyGKwNiFsQcP9kSkvAYFk0bW6Q/NjyzXoGM1Ak6nX9dswGwtBQ+kq6 88fb7jiA6RVko8jTn9li8pz8V5fghJ76SAW14zZr7wSdK8MHbBWjn0j2bj1We5cD QD/rfge6eNgv82lXufESBzTzqZZ1XiXo6RJaTapSh5zQzl6JUqCzyKzem6k9nKPw 1Q+4/r++LuGIeuQUm+BtD+ukdHWYycsTSECFcpleRVUoaeHCWYzSv57MOw4m3m11 OLQYIHmv6MN2pSzRsf+xTgU+cIpMlhsv+hYIybwLE+iNC5aw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e463dj5af-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 01:33:02 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-837cc5bc6deso4285629b3a.3 for ; Tue, 12 May 2026 18:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778635981; x=1779240781; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=6KRwB08wa5LSCOrHplBli913U01qsOZ1SqPoeDdqIUU=; b=aPYLzjWHMDem7yMSrzCGbI1mAse6JW4I931BJM30h8hCaV3sf8PGs4vhajWH9/k5ND MuJQ4B/U7hcmQEHt5zGo1n78hR9Zn69jUELP3tJJnqa+0NzLhzT3QauChhqboUEjOEav 21la83Nsv8vlCIJUsXInAtWu/Xoycf4KRVbrlw6m+CHqd0UPHf7O/u/AixHbgTa5aNYd oZvyjLIIuPnTHWP5xFUXyWFD+CWbFPxJa0EuAeqvCyMqfGK7DcB8rCGiKSNI5/E2uikb kNDBcdC9E8tWa76uEET1ZEZXhAuSNCYeAtD0Tms8Cxha/vVeGrDpf6mwpm7wbTeoOVy0 d/pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778635981; x=1779240781; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6KRwB08wa5LSCOrHplBli913U01qsOZ1SqPoeDdqIUU=; b=Syn8sda8P6feqT2Z5JRbkCykIb6iKmFI6RARtNrJ5erFkGe3t3W0mv5eljZ3sMstKH TZz1BbH/9YKsifGcatC9aKBnuMC17tmzZOUj73D7bjK70xArdAuiYo8AG/T07SiEq2xw iOq0RjaM8FqCvW6/ptyy7InxwEbjHiHb/tTO9LZtWd61JGR87HI1ubFVHdRHpFkUjB6A MmbvEe0F64XyG/5mO+1mdX0F+ZUTsICayRwzb29z9S0pfRhKhoU44eHmIG7aCsdScuxU te7B94cjUOXgb1Qi2RmH+a7DAefMyNBKTf/PUrXQTlIQ+PXAzeOEzQm1KA6MeVeijNDN z3Wg== X-Forwarded-Encrypted: i=1; AFNElJ9mzbOFIlt/8uZ+PQRNduZWW4br4FGDmlJxqC0uzrt4udzuAIIr7hQnTb5ZkdlJDelf2nYSfMTpPbivxCU=@vger.kernel.org X-Gm-Message-State: AOJu0YzM5AQiZn9T7Dq1qOvVMV7xpw3GngEdHbcT4OWxPGnnId0Lvv7Q HrW7hejs7c6pUAHIAygBAmBgotp3lHciAQxhFOycWNsM4Q5PvnCdFmWHNx9leKMUUvTKXhm2URC ah0gfHis4KZ/8ibFb6rNGlqotX+K39rTCIOOgHYVEi5xdaea1c6o1TL3SGOogk72vFHQ= X-Gm-Gg: Acq92OHD0URZ8uxut4PaMrMh1oOi+v0Zns4UXyujiKccjD6kjKM1A6HZG8+WioUQyXW 5lQzROZwmLOMvW8zGf7Uo5U3XQiaS08xz8fWDCAx3l71ORb4r11cNCNG5tCfJ3U1ysceWw61vRl EiPkmyMB5E3TlAybO67V0mVmox6MgkS12Dsai9gtESU81ztn0d4JQPMpZRuhlIT5QuOWy4dxUvm lBIShvwderLEz4kM1pdT4QhcOc7qhEeEMdnAfIkXBQ6uSdE9L0jXEMzDX6lxeUsnI8pnCtg+0do IQxmANfgT8kwDQbE4syD3ChoHLkmH4mBLT3dMWLufa8cE4lc5+SKihcXUT/3X4eAosDRBRntVrN cGe3DB8O1/g24efgDHIRRmtsVkzFLstFMOZLtIQn1h/OQbQ3E+LhXuFnp2i4vmXKwgvgS45u3N/ 2MdpyT06mM X-Received: by 2002:a05:6a00:420c:b0:835:405a:7e6d with SMTP id d2e1a72fcca58-83f041e9eddmr1109660b3a.21.1778635981485; Tue, 12 May 2026 18:33:01 -0700 (PDT) X-Received: by 2002:a05:6a00:420c:b0:835:405a:7e6d with SMTP id d2e1a72fcca58-83f041e9eddmr1109626b3a.21.1778635980998; Tue, 12 May 2026 18:33:00 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839683a088fsm24755895b3a.58.2026.05.12.18.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 18:33:00 -0700 (PDT) From: Jie Gan Date: Wed, 13 May 2026 09:32:43 +0800 Subject: [PATCH] coresight: fix resource leaks on path build failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260513-fix-memory-leak-issue-v1-1-49822d7bc7d4@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIALvUA2oC/x2MSwqDQBAFryK9TsM4HxdeRbKY6Ets/DKNIUHm7 g4uC6rqJEUSKLXVSQlfUdnWAvWjon6M6wcsQ2GyxjYm1I7f8uMFy5b+PCNOLKoH2Dj/8tEH2wR QafeEIt7f7pnzBUgjC/pnAAAA To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Alexander Shishkin , Mathieu Poirier , Tingwei Zhang , Greg Kroah-Hartman Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778635977; l=2366; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=eyAUz1s3eo4gcawWBadiNGT5QH1Paem+sgDmcWO3pn0=; b=S43pJJWKnshVyblz4uBIzxJEY37DHzyhcNQdEubzZFyUjTbySJF0sQshDClqkaa2p699hC8d9 vPhsrptMnhcB9SvNm7m/mo7Q5Z9v7Tt98jFrM+M9M8dPO+CTONPRdjd X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-GUID: 8vfFrCqezNOdizHKz3DktrF4RFCnyUkd X-Proofpoint-ORIG-GUID: 8vfFrCqezNOdizHKz3DktrF4RFCnyUkd X-Authority-Analysis: v=2.4 cv=aLTAb79m c=1 sm=1 tr=0 ts=6a03d4ce cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=JWgtPBJkhr62ReCL0bsA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDAxMiBTYWx0ZWRfX1TG0ySWuK0tw 7iDl0DRliv+Y7mSEEqIaDLRik0j8iIDxSUQYERuhz7IrZ/hAx+wNYlbL1rURBeeZ6tAEwc6RaLt fOWhLpDN/7HOSC2L2xqg+UTDj2DH4HyFFYmQhD4S0sDI/X+hx5yhd9jN/LAIhpzGv6l5VFyoTVc 6aU/6oxgMRz+tPUelRXyJUMtYu6jdqHiibezog55RkqFGL0FFSkOLJX//C8izzvhf0zrU3w+EKJ f9A3tIWE+iG0w74niFAeIsiscoZloa7kSt5p0HXS7AtEYmDfXlJaP73ySqkNnLSzRfrN1ICfDwK a19joIXMjzLbUQsQepyzYIkjzaxYVZpiUJgH28Z35heEJ4NIkzMp83a6UNi68NoEti29fH53yZV pF9fCS5e2WNfEryPf/ST57FB0I+NPiG5Ph3jSfrRJ0U3FxzcaNK/lcgZBEJrOjWarsutvufJcMe CdR9o7gzvaMQGc7MVtA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_05,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130012 Two related leaks when _coresight_build_path() encounters an error after coresight_grab_device() has already incremented the pm_runtime, module, and device references for a node: 1. In _coresight_build_path(), if kzalloc_obj() for the path node fails after coresight_grab_device() succeeds, coresight_drop_device() was never called, permanently leaking all three references. 2. In coresight_build_path(), on failure the partial path was freed with kfree(path) instead of coresight_release_path(path). kfree() only frees the coresight_path struct itself; it does not iterate path_list to call coresight_drop_device() and kfree() for each coresight_node already added by deeper recursive calls, leaking both the pm_runtime, module, and device references and the node memory for every element on the partial path. Fix both by adding coresight_drop_device() in the OOM unwind of _coresight_build_path(), and replacing kfree(path) with coresight_release_path(path) in coresight_build_path(). Fixes: 32b0707a4182 ("coresight: Add try_get_module() in coresight_grab_dev= ice()") Fixes: b3e94405941e ("coresight: associating path with session rather than = tracer") Signed-off-by: Jie Gan Reviewed-by: James Clark --- drivers/hwtracing/coresight/coresight-core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtraci= ng/coresight/coresight-core.c index 46f247f73cf6..c1354ea8e11d 100644 --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -825,8 +825,10 @@ static int _coresight_build_path(struct coresight_devi= ce *csdev, return ret; =20 node =3D kzalloc_obj(struct coresight_node); - if (!node) + if (!node) { + coresight_drop_device(csdev); return -ENOMEM; + } =20 node->csdev =3D csdev; list_add(&node->link, &path->path_list); @@ -851,7 +853,7 @@ struct coresight_path *coresight_build_path(struct core= sight_device *source, =20 rc =3D _coresight_build_path(source, source, sink, path); if (rc) { - kfree(path); + coresight_release_path(path); return ERR_PTR(rc); } =20 --- base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83 change-id: 20260513-fix-memory-leak-issue-034b4a45265e Best regards, --=20 Jie Gan