From nobody Fri Jun 12 20:19:42 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA1ED3ABD91 for ; Tue, 12 May 2026 20:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778616748; cv=none; b=ECaQXDKymKn/u+J8VdNoHTEMNNyZa/tcMQHV3cOC95LUpNDXFxDXdCAd+48ARetHCMqp8MA+b0ngdo9Tll5UOS9WPuA/idBe1pLsqtyi5uumsgJ1k+ATU47Lgxpd8lQ/zjbdb6NCiV3WZWf5BCh7u5bEqgz7baVFSQtS0w/ZsVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778616748; c=relaxed/simple; bh=HHhg2hoL7//TkwvoJEz8hezfEMP5OMKKOP5cqLRFNs0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UvuZUzBtHxauImFfD7q3hWjaZvUdRbDyHjqSTh5AV0PdX6bunokOTIfBbYRSn53CXYiSrajTqBiWEvISihq7aiggJInnYiJjkTZ/4A0tWT6C07yrnVA95LcCrX0AjXmBH9JdhHVGt6yPnBk9BVqlABxDTKg0FJCxTBgwQV+8FF8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Xf/On7lo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ONB+bgxX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Xf/On7lo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ONB+bgxX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778616745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Cayd8zbVawoYaZdVzFtXrH2LL1XTq+yqD6VwGGwDvs=; b=Xf/On7loPAopXPXOu08lS++lqDVcDxmZRuJlqicL3rz1KZck0+avX6cqGeMIXH1waQBmVC 3/s6tajnSHtU9oifjFk+SMWOpHPuSuChHYiNpVlEbucdapiK43uyoxrtoZLNGaDxf++alF 78lb/IGcVfnlOnK+WzHAFZQbcNZfzq8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-W2rFkWXPO2Sw2fHWThQBxg-1; Tue, 12 May 2026 16:12:24 -0400 X-MC-Unique: W2rFkWXPO2Sw2fHWThQBxg-1 X-Mimecast-MFC-AGG-ID: W2rFkWXPO2Sw2fHWThQBxg_1778616743 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48e5df7e6ecso36912025e9.1 for ; Tue, 12 May 2026 13:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778616742; x=1779221542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Cayd8zbVawoYaZdVzFtXrH2LL1XTq+yqD6VwGGwDvs=; b=ONB+bgxX8xwtMsr6W6IZDTjYhjJXQ8/sGxzFcVTqr8JQ5umycfkPudAm56vRGUsbA8 JloxBeTsEcZMkRCZ/FFaWv6IwzUxVVH7JVOPa2pNa3lLSqH2eeUeJYI0hQwXfTTNOXWn 4C47jIO5ZsnvBRTSd4PlUa4CVtmx03JJDBxLWh/hj4BhzPp9ru6i285ll8sg7A/AnF9t cYS307UoGyRByHPSzumDzcZYRJIAeYhjeaJMpeMue5xDjAHSF/ndCbmfCHX65hjYKwQ2 YxphXgbenqRR0lIjmc5o2MSAysPEff5Eiv49NTC/kJITOOhRERgx/UlALwX9irZeO6OM ge+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778616742; x=1779221542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1Cayd8zbVawoYaZdVzFtXrH2LL1XTq+yqD6VwGGwDvs=; b=V9bls3Ga/FKhrhSywgjO9wrRt96fpxHUhoXcCxRZnR+s5+p0WAF+rLfibl0jjQYmSB 2yWRqiaSJg7q+pMXEcIpG/cJUb99zGxVHP67A3vLUZxWMClaBBdZBT20R55N/oZLIUFD k3s4fQsxju2G+ckW4nsdY7+6PibcEVrvUdS+X4mBzN+R5NEmDSk91boiyRIEMsMoBzG5 umN5MMgxZbgtqhh4pojoy6AT/xSZG2wKaBTral9i5DOdsmbxrU+hzKiRiBtkvbV1jNYr KLAnKuyqP2ZoV1EDHxIGNxEdHOOBgihvZqHIB+NLCqhHmMGZYxKDWm9ZaDVKK9NJbqkW nusA== X-Gm-Message-State: AOJu0YxowLTpU4P7DZwcXJgHxXCoV3Dre4W0pcELoQXpZpEGq/eVuzU6 A9lZnIcjF2OINAGCOQGpL1Mu2i4ysef4UMVy/1JoXvfvvJ6ywcloDWyv2KitMxcGcr567PYJFVr S5XieN1yJj8ISnyvd/vM1Y2lsgAPidj+Ak4h8F8DeNtk9JpiZGDPX7GNf2gNpPJchwItzzVLLB8 JIVp5d4E14ztB0iMnCQ5WrSSzszrBItRZRxiC5QMH6dr0IEIkT6w== X-Gm-Gg: Acq92OHSaOcV5P54CH5uj3r2ElxhhGy2/uRVINPg4KKAIPnMrRC+ELNh+cpK0h4L5Hb ntOSXqQ8m/JXJHhCElzgAaEIxmisTX7PrpZ5Lr1tpikoQE0vwwvA/7HcQ8IAK8p+JQl+hhFizkP aqY5lvtt9D/LXsvSCAV1LDsgSnxQ8xBMCS7qcqsfGzmHRJuKhA0722sDCoXt73vTRZdKNe7DGA0 c6vYlUh3hMjYDBgz0i/ATqMX4vB7ASa8Gw4vO98i6vUb5BRBY5r9i8rvP8uyGQcUIfxBg5IjrCU kCJx2g1ftyNH4VRARbUnCTESDKVsqp7FJ4lgrcHXv8OeKK03ahVQyx/9jQZxdR4RjqNH7F0LIBv sfNHH3pmR2nqapnBwufnTSU6igtTfZU5H+yJM4wNguvui939JBcqePLmV0j4DjWUwpZZEOQeSP6 Q38syinhyNJ7rTEJQBV/JD9UYQHH75 X-Received: by 2002:a05:600c:4fc9:b0:48a:52d4:888c with SMTP id 5b1f17b1804b1-48fc9a029a2mr4635775e9.3.1778616741950; Tue, 12 May 2026 13:12:21 -0700 (PDT) X-Received: by 2002:a05:600c:4fc9:b0:48a:52d4:888c with SMTP id 5b1f17b1804b1-48fc9a029a2mr4635555e9.3.1778616741369; Tue, 12 May 2026 13:12:21 -0700 (PDT) Received: from [192.168.10.48] ([176.206.106.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548e4bbebdsm38633856f8f.5.2026.05.12.13.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 13:12:20 -0700 (PDT) From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Sean Christopherson Cc: yosry@kernel.org, Maxim Levitsky , David Kaplan Subject: [PATCH v2] KVM: nSVM: Never use L0's PAUSE loop exiting while L2 is running Date: Tue, 12 May 2026 22:12:19 +0200 Message-ID: <20260512201219.3021354-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260508213321.373309-1-seanjc@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On 5/8/26 23:33, Sean Christopherson wrote: > Never use L0's (KVM's) PAUSE loop exiting controls while L2 is running, > and instead always configure vmcb02 according to L1's exact capabilities > and desires. Queued, thanks. While I didn't go as far as splitting in two commits, I did apply a more or less cosmetic tweak to the WARNs. Calling grow_ple_window/shrink_ple_window with PLE disabled is harmless but also makes little sense. This can be represented by a WARN that does not have an early return. The WARN condition is obviously false for shrink_ple_window and a little less obviously so for grow_ple_window, but in case any other callers are added it can be useful to have it as a heads up. Paolo diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index ac21f402c1ca..e02a38da5296 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -913,12 +913,15 @@ static void grow_ple_window(struct kvm_vcpu *vcpu) struct vmcb_control_area *control =3D &svm->vmcb->control; int old =3D control->pause_filter_count; + /* Adjusting pause_filter_count makes no sense if PLE is disabled. */ + WARN_ON_ONCE(kvm_pause_in_guest(vcpu->kvm)); + /* * While running L2, KVM should intercept PAUSE if and only if L1 wants * to intercept PAUSE, and L1's intercept should take priority, i.e. * KVM should never handle a PAUSE intercept from L2. */ - if (WARN_ON_ONCE(is_guest_mode(vcpu) || kvm_pause_in_guest(vcpu->kvm))) + if (WARN_ON_ONCE(is_guest_mode(vcpu))) return; control->pause_filter_count =3D __grow_ple_window(old, (1/2) Stage this hunk [y,n,q,a,d,k,K,j,J,g,/,s,e,p,P,?]? y @@ -939,6 +942,9 @@ static void shrink_ple_window(struct kvm_vcpu *vcpu) struct vmcb_control_area *control =3D &svm->vmcb->control; int old =3D control->pause_filter_count; + /* Adjusting pause_filter_count makes no sense if PLE is disabled. */ + WARN_ON_ONCE(kvm_pause_in_guest(vcpu->kvm)); + if (is_guest_mode(vcpu)) return;