From nobody Fri Jun 12 20:21:40 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B02A385D6A for ; Tue, 12 May 2026 17:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605684; cv=none; b=UGU4YKiHhC2WeQ+jcBpS0ctxGwrDz/DNJV0xXJQwzb1fU9eh7n9hnZbsXJYHx6exZ2rqCsQqm2goo8ZBqj1+AdGopV9rOM+O7N/TvQD+4G6TkboXSnlBQ+JlH8QQKgQ9buQ7OuT8s8iiAtHYHcaYs4UY8sA9uM2BVRapvhJomWU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605684; c=relaxed/simple; bh=W0teZJlfYAQLaXLTsjiehVqqunElU0WQyO/dNPhaS6I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NgtVVT2LwfKiDUwIu+Q9BiLdZjfIwGsBc5+OQQyYARlsP9OgZXHBN9ooz/b/Gq8+qXBko6lAj0BR9i0BXWsTtLlbu9KnqUnmJh1YaGhScl0kShnSNfbzstRJwqEXXIsccfkKIAxnZQ99LylXsHjbHm5+9evdLfzc0W96X6RbYiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L49IjXOX; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L49IjXOX" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2bab2548e8bso27320965ad.0 for ; Tue, 12 May 2026 10:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778605683; x=1779210483; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QYrM1ugjRPgLhpplO4rHGDHi2VlP1UNGf3qR/QOW+Dc=; b=L49IjXOXzujHBhOS1lvhfOlW6TuVaDWimWnUSJDvnZrG0L7Xrg3RpprNJR+PuZ33iB ZsL6Igm7CNb8G4liCfAlQMY25lS0fPSK1UwiOey5/3q9rBzsSzCX2W6q+8DkoUNjp442 5IZXH+WmDt7edxmhxDh08ftw1C5oAiM76kI/CGWW9zvMll38yLnnzGO7tE4utMx7dqk+ +WuT2/LE4rT/vAOZ782gdOGBk2WWb2gXwnF218viOUNchXT6722hmzCVROka2NGg5Lyj 09oanr34ivNQ8UM1TKhuoVssi3424+BHpX64V31qfHuY7PiYIVpdU8QJZPdoncS/l8zF Kf/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778605683; x=1779210483; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QYrM1ugjRPgLhpplO4rHGDHi2VlP1UNGf3qR/QOW+Dc=; b=XE/EgII1cHyUpMsOzTYsAjnpwwbouwVpKEvDQrognHl2BGhLUHvhzXXjb7Q7ucr2jh 09nFB36cEWkpHMJNplnXKiOuLiTBFhff6CjwXqdbHHZFdzN3JBoH6euk4uNZoAQqTFeN NbiddS/Ujc+oI2kP138gOxgoTU2UkHGsaa1vlMjvhFcaYwMoT6+VPEO/FSrCCKb3WB6D QzDxeBgjegi6jIRUpCXj7Y8tTaXufS9HuYdRW8aSkgxyc2vUXMiBMSIMKV/JnWg+o2wv YugsKH5rE0A8eLnmfv7QBSu5IQHwSFD6MBcQ/fIiaS/WvDdPM9mSNqyiPOoHpwr37Jtu mMSg== X-Forwarded-Encrypted: i=1; AFNElJ8lpkIDtbF02YlBHzloBNMqYAEpctQ66Veixu2ObDPnWn9zW3+4AW9NTK36ZMbU3AtATvzfQd5NEBJSRnQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwPC5ovwXREI6kGu+xT1Tq2wrr2Ib9ZTfuoje+ydUqtNiJ0jhtm YIl1Ymhj2QgQ2dnZZNOtb6PNk/SWpH9vsDtDwibFKsu5YPbYIP2aipRn X-Gm-Gg: Acq92OHcqLQndkqfsCyW+awYiNVAY1SCpfrh3COS15PY25CeR8bP8nKduaFIwlKOCD2 hw6RclUfT/3xDlQf6hdbTN+8eTyar2JXxk9BxQHMV/bH+u0gXjKeNZDOcgnTyDH8MHObxKcFlN7 0rR9yE+EQ3i/BlE8xS9PefO4uunCvpg0C//puztEy0VDrR7OPIbynEdijHL0XrZvMrbG3yXiwhY QaFohy+LQ+b8lyspPfoZhb4Q+WgPmUw1YtWTYtVG3SK/EoJ9bsm8i165cl9v5wI/hNiFYK7EM9Q 9+M5DdnNrnjfOkCK7/c/52DALO21m83ktyIukbVtFYLrlO8wT3hzfZ/AYmLcFr6uMquBAlU+V59 HqzK4ywz6EfNokHBdFqDLrHqqt+LdJHGgmXoEySsDjuy2W38ruxF+WwEjKzm/YjQVfXW8fH1sL8 obpfrQLvOdIVyrh7fxE7vAEsk= X-Received: by 2002:a17:903:1a2c:b0:2b4:6470:760d with SMTP id d9443c01a7336-2ba78f473a2mr318062185ad.14.1778605682482; Tue, 12 May 2026 10:08:02 -0700 (PDT) Received: from lgs.. ([101.36.111.22]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e847d0sm136146275ad.62.2026.05.12.10.08.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 10:08:02 -0700 (PDT) From: Guangshuo Li To: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] scsi: fc: Release rport device with put_device() on add failure Date: Wed, 13 May 2026 01:07:34 +0800 Message-ID: <20260512170734.811837-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fc_remote_port_create() calls device_initialize() for the embedded rport device before calling device_add(). Once initialized, the object must be released through the device core. The device_add() failure path currently calls put_device(dev->parent) and kfree(rport) directly. This bypasses put_device(dev), the registered .release callback, and the kobject/device cleanup associated with the initial reference taken by device_initialize(). Use put_device(dev) instead. fc_rport_dev_release() will release the parent reference and free the rport container. This issue was found by a static analysis tool I am developing. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Guangshuo Li --- drivers/scsi/scsi_transport_fc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport= _fc.c index dce95e361daf..4a757cbc7139 100644 --- a/drivers/scsi/scsi_transport_fc.c +++ b/drivers/scsi/scsi_transport_fc.c @@ -3180,8 +3180,7 @@ fc_remote_port_create(struct Scsi_Host *shost, int ch= annel, list_del(&rport->peers); scsi_host_put(shost); /* for fc_host->rport list */ spin_unlock_irqrestore(shost->host_lock, flags); - put_device(dev->parent); - kfree(rport); + put_device(dev); return NULL; } =20 --=20 2.43.0