From nobody Fri Jun 12 20:19:42 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010004.outbound.protection.outlook.com [52.101.61.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 891123DB966 for ; Tue, 12 May 2026 17:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605601; cv=fail; b=aXPi80Krj7jNqjmiwK5e2DkWu4DpwQsbyC3IClJHpoBXJtBIp9TPQY4t46ZuTcEb08AXu2QcagbViHYrK2SdbbrW8nDYOm2umH3qHhfziCaYvhvZJu6E8oxNgLO0xKmGF6hgDzc1VBQTh52+bA5RoUFKet7zFldcMN+3t5kst0Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605601; c=relaxed/simple; bh=bq4fvVl2QujN9KrWZlG5EsC/LXuJdHPr8gs/QeNksSU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d1eqD3SFmKgJQeyVkxzMrm4fCP35GTfoO9P7Q6K0yHmdfnQWSnOtJw9oGFyhkTXJp02+PjE9W2aqI5fG7wCQ1E+BWvHArfofWLJXVnr2S4J4zF9/+qb+BQkB2qSqCVUFn3HJRXYtNShU5sC0IVNP3Ukikcse/v26cAOvWtDzvgI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ZZy2WV/R; arc=fail smtp.client-ip=52.101.61.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ZZy2WV/R" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NSUROgF76UWMEy4VmqSUH/YHDm1LB9wN77kxlv/M2DElfWrPRrRAiufFlahevGiQzcorJy7sdSB6w7z7l8u52e749DnwvxKutbz1IvldtIw0n89ChdrVMqPFN70Xsfj2RUTU5sVwG7YLoM1BtLQUrSbNwOpEDQJGaQ5dh4AOcRZBwDZzlbN/DFYfp0WjkR11jRv/xCHWFnRmjxkSS+DeXyktjFmzETiG3wk0jgIV4fdQcFsbl/A28u954BcrqpepcCm8AC59AWKSBu36MZBeHYZTefEsy5ZER5fbjEv90qVVQ7BlLcWnR8ALznDaTk4vICE7aMQijU4tYw17u3l5xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FuMEJ8NoalMPL9vSmmqa3VuEtqPHEB8hMNAAYPiHX6w=; b=bqCrOwPnBFSdujgsdM0VeCrfLEFxW3PrOa667DduMU+dv2tISiEhpFvUlkKeQKn4HzX43R5rBhDmn98+N/FAv0yX6Bw25YS+5FLIwOmDFvRHIs4jAFTADcsI9IvHI7Yq50O1HVE6vqawyS4+SGBPrvHiROkHMMxvKWBC5WVhCZZrfvymZ9qbVGsFfJoDk1MJKbyzHGaxu336IxfoGspB5EU9eQO8DknL4ULSBQ84JUPNPkqWqoIU65mzhLE6fDn9WkRoF23kC6DbeB9CFEyLOftWo3n5pq2VIdo2rFZIeCBp3XcYtbD8Av3jnII8uRqDoZMCtF4BFjzqsqM32LhG6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=oss.qualcomm.com smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FuMEJ8NoalMPL9vSmmqa3VuEtqPHEB8hMNAAYPiHX6w=; b=ZZy2WV/R8h+fpuWEQ/8Rfjti6xMIChOeQOIDYXSY7LX/13C2qCrEmYRFDWejJp2cS05fySldvyya7Q+KVCIO0nMFjxqBfvafa+GH0/+q4gDxJj0uiWWMpX1fPRnehX2fcq9STZ7KwmuTAs8gfLe6h/eyDr1c+Ct8aecrHd2Y0Eo= Received: from DM6PR11CA0008.namprd11.prod.outlook.com (2603:10b6:5:190::21) by CH0PR10MB4970.namprd10.prod.outlook.com (2603:10b6:610:dd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9913.11; Tue, 12 May 2026 17:06:33 +0000 Received: from DS3PEPF0000C37B.namprd04.prod.outlook.com (2603:10b6:5:190:cafe::66) by DM6PR11CA0008.outlook.office365.com (2603:10b6:5:190::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9913.11 via Frontend Transport; Tue, 12 May 2026 17:06:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by DS3PEPF0000C37B.mail.protection.outlook.com (10.167.23.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Tue, 12 May 2026 17:06:31 +0000 Received: from DFLE212.ent.ti.com (10.64.6.70) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from DFLE201.ent.ti.com (10.64.6.59) by DFLE212.ent.ti.com (10.64.6.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE201.ent.ti.com (10.64.6.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:25 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6PCt2235126; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , , Krzysztof Kozlowski Subject: [PATCH V2 01/11] soc: ti: knav_qmss: Remove remaining redundant ENOMEM printks Date: Tue, 12 May 2026 12:06:13 -0500 Message-ID: <20260512170623.3174416-2-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37B:EE_|CH0PR10MB4970:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ea8e72e-6e7a-481f-6f7e-08deb048d074 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|1800799024|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: MIvjRCx7e2FGmLvbvyPCsZU4Pb+teWS/ifOtW0bJJZ+FUn6yhZXd/XetQ+SPnEkqjAQdKIbGNAV2+p03zpaIcYj3l997avYaVSSPOGUH3Gp/rDDsn4RZ9Utf3Uw1tqRu6nYPX6fyBmHQ2BvyY9u6Ixe1R4ahOCxJhlIL+r3DosBHivMVyvwZzIlJedCNqM1LuDmxNpg/kP8pp/3S9EXJPjYUrq1AAa+/caiIdK9/hROe6jw1xI91QKsMKT3rcsSYpxl/l6GArcD01uDl1MgU2Qf2HR35w0IaqvE1ghDEFNE4vaPVgEmZotMgTuFWQ2GFC+CIW9jyLp/Y9pujelJVnfCu0E30gNUZT0QCxjzeR2hlmfdccQ74h2CL2p+NrQxz/SrjWNUZ+e72WgwN6nxUyy138ud0UDZIk5onTjkP+3s36kzPrtflKFK8jwHKXnxYsX6DMEPB7i8PAcc0g6IzcAR+iOFuZOkApCKRKxHDzhxbA+AlhbSe3I/0vGiOxmoep9h79+26mV5YjYbe6jSVW4/GIx79M/AnkzFN0W5tx7MqVheqhoASXrysIN85Qt0QGs4d5RY+FsBE8G7rPbr7Iufh4geNy+YLioPwqJKlNNhXFkJv8iLDD/A6Oji9Fqb4X7nIk38LiaxBqMuejY9eia0I0tEcKmXuX6y97CWMQ1w8DwAyZ4yxibvjn60yJ2Gghc7sGN3/qNyHaVEZ4hV4LMuwT2VFThArdEUluSJTQjU= X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qll2zW7QhJ6qV8GMSXyM739/+yo9q9CAmVx4sxxb+cK4s1nRt1oij8ZCV+BxJ8khF9X1QafedxkGsjjf2ma3wQ+xX3ZTvX6JlElj6yT4XD0v7Wtj5kOEveVm4MAjPfDRe23OJZmcqWDloWfeAPo8Nj48K9aht7MRTsFcUYvMHdL+8gFWEHAfxQEPON0V1GROR5gQQUIAbHV0aVff+yvXOWZ2KN67NOvm9/iXdmttu+bjy3D6KcR6DWRRO7fuRlyoFF78P0FcJ2AFxjVxKkGtsT+UGAKCea5bUJjJuUZcrB3kcG8jqJbxexo/4o0bxTuNiGKKdzObuxX4DNjVqD8YOLbe3akvu7Q+NP2tSc/W7n7Z22q8vos5GwLv/AldsAsneEPdncAIRUu6c5Esn1cYHoBCme2X0Ss20IymsNzwPTStEfYigD7nmDGHKExzO1U2 X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:31.3661 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ea8e72e-6e7a-481f-6f7e-08deb048d074 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4970 Content-Type: text/plain; charset="utf-8" Commit 168d2fb78055 ("soc: ti: knav_qmss: Remove ENOMEM printks") removed redundant dev_err() calls after allocation failures in knav_queue_setup_regions, knav_queue_init_qmgrs and knav_queue_init_pdsps, but missed three further instances in knav_pool_create, knav_queue_setup_region and knav_setup_queue_range. Remove the missed instances. Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Cc: Krzysztof Kozlowski Changes since V1: - None. V1: https://lore.kernel.org/all/20260508153211.3688277-2-nm@ti.com/ drivers/soc/ti/knav_qmss_queue.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index 86d7a9c9ae01..e87a42734f25 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -769,10 +769,8 @@ void *knav_pool_create(const char *name, return ERR_PTR(-ENODEV); =20 pool =3D devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL); - if (!pool) { - dev_err(kdev->dev, "out of memory allocating pool\n"); + if (!pool) return ERR_PTR(-ENOMEM); - } =20 for_each_region(kdev, reg_itr) { if (reg_itr->id !=3D region_id) @@ -1025,10 +1023,8 @@ static void knav_queue_setup_region(struct knav_devi= ce *kdev, region->dma_end =3D region->dma_start + size; =20 pool =3D devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL); - if (!pool) { - dev_err(kdev->dev, "out of memory allocating dummy pool\n"); + if (!pool) goto fail; - } pool->num_desc =3D 0; pool->region_offset =3D region->num_desc; list_add(&pool->region_inst, ®ion->pools); @@ -1211,10 +1207,8 @@ static int knav_setup_queue_range(struct knav_device= *kdev, int ret, i; =20 range =3D devm_kzalloc(dev, sizeof(*range), GFP_KERNEL); - if (!range) { - dev_err(dev, "out of memory allocating range\n"); + if (!range) return -ENOMEM; - } =20 range->kdev =3D kdev; range->name =3D knav_queue_find_name(node); --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013012.outbound.protection.outlook.com [40.93.196.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EBF53DB97D for ; Tue, 12 May 2026 17:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605602; cv=fail; b=IfREn58yfqHxESZ/eHBjE6lR3CWt0qsHDZVDGNSwETTXduTT6f6FSRXwfkNvqhAlvBxi69AfDkL0G+1xE3oCzBtqlASCdu2lTfcpgFvisLQqYdXBziqUIvisk5FzRUTaFjvGNH/mJKpeWIocmd+s+USPolLzR/WSmbUd5Y0p9XQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605602; c=relaxed/simple; bh=vlbGDuiAogVJ3Cx/MEzYoRAKtnG3aA/UZgOHHx//60k=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DypM8qYxKLN0tq2O7B6jsBF+2puMkRuKSM+SuWSZsrlH5dHjwiJ8Xb8pV8hqOKyjmD3xcMaRWS3l0jf+x2T8TlykbXmtPwzkFZTRAoJJ4SJHP+HneGcN8SWUAY5unjVs7vD6M/qxk+Wo/TT6Tzb01KrLPFL7pq02o98zEiJLY+k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Doyx4+1F; arc=fail smtp.client-ip=40.93.196.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Doyx4+1F" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PHrvUKpVXW2dvM2se58YaY9Zs48tEd7lOiUmM3khBLtbfhD8MGv+DEmm6BlGFAiOqyMhGSqh6zy2Q8o5IwQdx+pp5Z9sCMv9Y06RND1HBPwl9RNNB3N5e5T0zuCmzQj5p6IR/QGQNRgqYbdSnF7sV020ioIlp0M2EFyJW52QFiPuv+jI+3SO62tovOabdMdmawCLABCnEoj6rqRkOAxC6WbP9y7kMwI/3k9jUb1LTyHB0HY09CJTUGXUQyz8wBThRVvh2evpAGpGgQl2fU8VBvJc7+OFIO7gYbdowI5CBmW8VDj8W9VVuYesCT2+K6m0G7W07vZd/J+SsY+O2HEBJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/J48EmcW4dR7PFqmMTDx2x42LKcChtmSoqG3QTqLIJ4=; b=N43CUtyAiEWa8QqDy004S2YszrSPCZXLjyIYdgh95Inu1qzX12fcA16+1j2e+Y/ZFT7bTaD4ivpkTrMBk+iHXJ97HSK15xtk3WmdDWw2mCfIBqScxgkgNlo1KmFyvyiNaKx4JRJJfhu2uczQzQE+c0xei6LP3UC09BCJIqG53EQqJzxZTpjQqzlUlXNTWxcDbfFhc1ixP0Ubf3HFhVnfuj4PR8sMuuRY6obnczwZThQMu+kZlcpKH0w4UK0M2xEOBFEXx/xRAUtH/9QYuKOVslGt7+rUQYBtqhBXvfDDxL3nvLWX2dFkjEtIbHh2NqJQOtY+aD+SxXM04vwA/zI1Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/J48EmcW4dR7PFqmMTDx2x42LKcChtmSoqG3QTqLIJ4=; b=Doyx4+1FAr4hCY1kN3p+qdsKAorDttFOJHXWCNPES+rrMDxjx37eC3Fs9rux+DsCLlKv0/V+8OfnWFnccWAMRhDRg+aDjeIDLCjuohC11uKm/3EFch2qkRzA4TTauXBkO0bisRLwNHOp8rgsush05krU4MbfY+RUMXxK/3yAlPI= Received: from SJ0PR05CA0157.namprd05.prod.outlook.com (2603:10b6:a03:339::12) by DM4PR10MB6886.namprd10.prod.outlook.com (2603:10b6:8:102::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9913.11; Tue, 12 May 2026 17:06:34 +0000 Received: from SJ1PEPF00001CE5.namprd03.prod.outlook.com (2603:10b6:a03:339:cafe::6e) by SJ0PR05CA0157.outlook.office365.com (2603:10b6:a03:339::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.15 via Frontend Transport; Tue, 12 May 2026 17:06:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by SJ1PEPF00001CE5.mail.protection.outlook.com (10.167.242.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Tue, 12 May 2026 17:06:33 +0000 Received: from DFLE208.ent.ti.com (10.64.6.66) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from DFLE208.ent.ti.com (10.64.6.66) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:25 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6Pni1887817; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , Subject: [PATCH V2 02/11] soc: ti: knav_qmss: Rename global kdev to knav_qdev to fix -Wshadow Date: Tue, 12 May 2026 12:06:14 -0500 Message-ID: <20260512170623.3174416-3-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE5:EE_|DM4PR10MB6886:EE_ X-MS-Office365-Filtering-Correlation-Id: 89231c87-23a0-45f3-ad7b-08deb048d17f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|1800799024|376014|56012099003|18002099003|22082099003|3023799003; X-Microsoft-Antispam-Message-Info: p1OdQsLGFia5ljN4YIW1ae6z1p3VFeKevkGpPbgX/evOHqkcKhlz7DSS1qR80SUP/3kUW4cseo4edDGtDgMitbBFgRjZe+82qKpOvcKz9XE4BXFxrXzQQLjrGsCtBUM5xkqiDcRwxc+LijsOJeij9WuHg5LPmwgauASa61rI0hnES/SMDUzJ+2w95cRlM4Zi2EwEjCcIyotN+HGebvDOfsP6h0D0ikgOv7kFDjoAV60wZ2qcXl5XOGaeIvdZi3vrg7epb9px6H1noGtnMjUil+VvMXt+rDCpJ/fpelXJNl/rx9CLk+Ya4iP60xqIIXkPnr1auulAT2IeeazbVnGkSS5s5hIMzNMVjLOzJDx5zy+w4yQjlbxeFo2jYr1y94BIFpWawZoG5B1SkhRBJvgngMisC8UuPjwvNaB+rS6oB9cFu4jSYs5xgRAZ+xksKNRiNc5Q9Asv0+eGqS+y4lsVDGlCO5Cz8TuVPKscI0lwktwvRfoXuOb5k5DLttIzWzhm7CwlSRr0YuKdLxDzWL9rXQpD60h4rtc4zFwTb4HUKk9T4tPwPa9ViwzA+rCRElxPoJK9Ya6EUO66g57zJc6Jp+N+H9nZYJ2jM2WmulBP9TIfbi+h5sXIeBWwA7A3TNAp0xLo6wGhdlFq0IVnTg/7x73+L1UBm0P75MhNr3MCWaQRDozKyIlCdZcicHEcbGOP8ahg2dWud6hft6iOVPdXhO2JRagW69vGfDDNijQTdXo= X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(1800799024)(376014)(56012099003)(18002099003)(22082099003)(3023799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6JX/Gko1CHXXcDmO4OLnqaHpbcGG/+OXuG8ktAW224N/kegQ0z0lsfwP+x4Snfd7z27pf6dKlJ2yeNw7X9gJMt6+J32juPsFiFDku7HuI3sHfs6U2V0vKZT7vhfw3Fql7foXsLWM1GRgaiUdX2M3K9imV23nhojby1C+Un8kew4YH+xHiHguSk7C49IDVaaKP6/t97/qoZE1U4Q28nNI1sdWz90UJj7YCTb2mzyHqWnI0FeVpElLKcVycZ+0p1xto1JES5wOQndpTnpcddNxGvkXXDabh6nlurEkHQ5X6CUqlCYd2XWJMAdKcQPVcqS7qXuN0Yyos6p1wSkUhoLBJhUiUckTiUBwVO9QsqEw7vwPNZFLCYLSr9h4bOw1CVb0ya/ERHMfSoszc35a/XhoG/iBkyeoQFfc2TP5Qopn91kmhn7S9LPkqDf3Ymw5+r5z X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:33.0754 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89231c87-23a0-45f3-ad7b-08deb048d17f X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6886 Content-Type: text/plain; charset="utf-8" Building with W=3D2 (clang, LLVM=3D1) produces 22 -Wshadow warnings in knav_qmss_queue.c because the file-scoped singleton 'kdev' is shadowed by a parameter of the same name in 21 internal functions and one local variable, e.g.: knav_qmss_queue.c:194:49: warning: declaration shadows a variable in the global scope [-Wshadow] 194 | knav_queue_match_id_to_inst(struct knav_device *kdev, unsigned id) Rename the global singleton from kdev to knav_qdev rather than renaming all ~21 function parameters, as this requires fewer changes and leaves function signatures, struct field accesses, and header macros in knav_qmss.h untouched. Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - None. V1: https://lore.kernel.org/all/20260508153211.3688277-3-nm@ti.com/ drivers/soc/ti/knav_qmss_queue.c | 94 ++++++++++++++++---------------- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index e87a42734f25..2c103bb6edef 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -25,7 +25,7 @@ =20 #include "knav_qmss.h" =20 -static struct knav_device *kdev; +static struct knav_device *knav_qdev; static DEFINE_MUTEX(knav_dev_lock); #define knav_dev_lock_held() \ lockdep_is_held(&knav_dev_lock) @@ -205,10 +205,10 @@ knav_queue_match_id_to_inst(struct knav_device *kdev,= unsigned id) =20 static inline struct knav_queue_inst *knav_queue_find_by_id(int id) { - if (kdev->base_id <=3D id && - kdev->base_id + kdev->num_queues > id) { - id -=3D kdev->base_id; - return knav_queue_match_id_to_inst(kdev, id); + if (knav_qdev->base_id <=3D id && + knav_qdev->base_id + knav_qdev->num_queues > id) { + id -=3D knav_qdev->base_id; + return knav_queue_match_id_to_inst(knav_qdev, id); } return NULL; } @@ -296,7 +296,7 @@ static struct knav_queue *knav_queue_open_by_type(const= char *name, =20 mutex_lock(&knav_dev_lock); =20 - for_each_instance(idx, inst, kdev) { + for_each_instance(idx, inst, knav_qdev) { if (knav_queue_is_reserved(inst)) continue; if (!knav_queue_match_type(inst, type)) @@ -469,9 +469,9 @@ static int knav_queue_debug_show(struct seq_file *s, vo= id *v) =20 mutex_lock(&knav_dev_lock); seq_printf(s, "%s: %u-%u\n", - dev_name(kdev->dev), kdev->base_id, - kdev->base_id + kdev->num_queues - 1); - for_each_instance(idx, inst, kdev) + dev_name(knav_qdev->dev), knav_qdev->base_id, + knav_qdev->base_id + knav_qdev->num_queues - 1); + for_each_instance(idx, inst, knav_qdev) knav_queue_debug_show_instance(s, inst); mutex_unlock(&knav_dev_lock); =20 @@ -762,17 +762,17 @@ void *knav_pool_create(const char *name, unsigned last_offset; int ret; =20 - if (!kdev) + if (!knav_qdev) return ERR_PTR(-EPROBE_DEFER); =20 - if (!kdev->dev) + if (!knav_qdev->dev) return ERR_PTR(-ENODEV); =20 - pool =3D devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL); + pool =3D devm_kzalloc(knav_qdev->dev, sizeof(*pool), GFP_KERNEL); if (!pool) return ERR_PTR(-ENOMEM); =20 - for_each_region(kdev, reg_itr) { + for_each_region(knav_qdev, reg_itr) { if (reg_itr->id !=3D region_id) continue; region =3D reg_itr; @@ -780,14 +780,14 @@ void *knav_pool_create(const char *name, } =20 if (!region) { - dev_err(kdev->dev, "region-id(%d) not found\n", region_id); + dev_err(knav_qdev->dev, "region-id(%d) not found\n", region_id); ret =3D -EINVAL; goto err; } =20 pool->queue =3D knav_queue_open(name, KNAV_QUEUE_GP, 0); if (IS_ERR(pool->queue)) { - dev_err(kdev->dev, + dev_err(knav_qdev->dev, "failed to open queue for pool(%s), error %ld\n", name, PTR_ERR(pool->queue)); ret =3D PTR_ERR(pool->queue); @@ -795,13 +795,13 @@ void *knav_pool_create(const char *name, } =20 pool->name =3D kstrndup(name, KNAV_NAME_SIZE - 1, GFP_KERNEL); - pool->kdev =3D kdev; - pool->dev =3D kdev->dev; + pool->kdev =3D knav_qdev; + pool->dev =3D knav_qdev->dev; =20 mutex_lock(&knav_dev_lock); =20 if (num_desc > (region->num_desc - region->used_desc)) { - dev_err(kdev->dev, "out of descs in region(%d) for pool(%s)\n", + dev_err(knav_qdev->dev, "out of descs in region(%d) for pool(%s)\n", region_id, name); ret =3D -ENOMEM; goto err_unlock; @@ -827,10 +827,10 @@ void *knav_pool_create(const char *name, pool->num_desc =3D num_desc; pool->region_offset =3D last_offset; region->used_desc +=3D num_desc; - list_add_tail(&pool->list, &kdev->pools); + list_add_tail(&pool->list, &knav_qdev->pools); list_add_tail(&pool->region_inst, node); } else { - dev_err(kdev->dev, "pool(%s) create failed: fragmented desc pool in regi= on(%d)\n", + dev_err(knav_qdev->dev, "pool(%s) create failed: fragmented desc pool in= region(%d)\n", name, region_id); ret =3D -ENOMEM; goto err_unlock; @@ -844,7 +844,7 @@ void *knav_pool_create(const char *name, mutex_unlock(&knav_dev_lock); err: kfree(pool->name); - devm_kfree(kdev->dev, pool); + devm_kfree(knav_qdev->dev, pool); return ERR_PTR(ret); } EXPORT_SYMBOL_GPL(knav_pool_create); @@ -872,7 +872,7 @@ void knav_pool_destroy(void *ph) =20 mutex_unlock(&knav_dev_lock); kfree(pool->name); - devm_kfree(kdev->dev, pool); + devm_kfree(knav_qdev->dev, pool); } EXPORT_SYMBOL_GPL(knav_pool_destroy); =20 @@ -1683,7 +1683,7 @@ static inline struct knav_qmgr_info *knav_find_qmgr(u= nsigned id) { struct knav_qmgr_info *qmgr; =20 - for_each_qmgr(kdev, qmgr) { + for_each_qmgr(knav_qdev, qmgr) { if ((id >=3D qmgr->start_queue) && (id < qmgr->start_queue + qmgr->num_queues)) return qmgr; @@ -1775,22 +1775,22 @@ static int knav_queue_probe(struct platform_device = *pdev) return -ENODEV; } =20 - kdev =3D devm_kzalloc(dev, sizeof(struct knav_device), GFP_KERNEL); - if (!kdev) { + knav_qdev =3D devm_kzalloc(dev, sizeof(struct knav_device), GFP_KERNEL); + if (!knav_qdev) { dev_err(dev, "memory allocation failed\n"); return -ENOMEM; } =20 if (device_get_match_data(dev)) - kdev->version =3D QMSS_66AK2G; + knav_qdev->version =3D QMSS_66AK2G; =20 - platform_set_drvdata(pdev, kdev); - kdev->dev =3D dev; - INIT_LIST_HEAD(&kdev->queue_ranges); - INIT_LIST_HEAD(&kdev->qmgrs); - INIT_LIST_HEAD(&kdev->pools); - INIT_LIST_HEAD(&kdev->regions); - INIT_LIST_HEAD(&kdev->pdsps); + platform_set_drvdata(pdev, knav_qdev); + knav_qdev->dev =3D dev; + INIT_LIST_HEAD(&knav_qdev->queue_ranges); + INIT_LIST_HEAD(&knav_qdev->qmgrs); + INIT_LIST_HEAD(&knav_qdev->pools); + INIT_LIST_HEAD(&knav_qdev->regions); + INIT_LIST_HEAD(&knav_qdev->pdsps); =20 pm_runtime_enable(&pdev->dev); ret =3D pm_runtime_resume_and_get(&pdev->dev); @@ -1805,31 +1805,31 @@ static int knav_queue_probe(struct platform_device = *pdev) ret =3D -ENODEV; goto err; } - kdev->base_id =3D temp[0]; - kdev->num_queues =3D temp[1]; + knav_qdev->base_id =3D temp[0]; + knav_qdev->num_queues =3D temp[1]; =20 /* Initialize queue managers using device tree configuration */ - ret =3D knav_queue_init_qmgrs(kdev, node); + ret =3D knav_queue_init_qmgrs(knav_qdev, node); if (ret) goto err; =20 /* get pdsp configuration values from device tree */ - ret =3D knav_queue_setup_pdsps(kdev, node); + ret =3D knav_queue_setup_pdsps(knav_qdev, node); if (ret) goto err; =20 /* get usable queue range values from device tree */ - ret =3D knav_setup_queue_pools(kdev, node); + ret =3D knav_setup_queue_pools(knav_qdev, node); if (ret) goto err; =20 - ret =3D knav_get_link_ram(kdev, "linkram0", &kdev->link_rams[0]); + ret =3D knav_get_link_ram(knav_qdev, "linkram0", &knav_qdev->link_rams[0]= ); if (ret) { - dev_err(kdev->dev, "could not setup linking ram\n"); + dev_err(knav_qdev->dev, "could not setup linking ram\n"); goto err; } =20 - ret =3D knav_get_link_ram(kdev, "linkram1", &kdev->link_rams[1]); + ret =3D knav_get_link_ram(knav_qdev, "linkram1", &knav_qdev->link_rams[1]= ); if (ret) { /* * nothing really, we have one linking ram already, so we just @@ -1837,15 +1837,15 @@ static int knav_queue_probe(struct platform_device = *pdev) */ } =20 - ret =3D knav_queue_setup_link_ram(kdev); + ret =3D knav_queue_setup_link_ram(knav_qdev); if (ret) goto err; =20 - ret =3D knav_queue_setup_regions(kdev, node); + ret =3D knav_queue_setup_regions(knav_qdev, node); if (ret) goto err; =20 - ret =3D knav_queue_init_queues(kdev); + ret =3D knav_queue_init_queues(knav_qdev); if (ret < 0) { dev_err(dev, "hwqueue initialization failed\n"); goto err; @@ -1857,9 +1857,9 @@ static int knav_queue_probe(struct platform_device *p= dev) return 0; =20 err: - knav_queue_stop_pdsps(kdev); - knav_queue_free_regions(kdev); - knav_free_queue_ranges(kdev); + knav_queue_stop_pdsps(knav_qdev); + knav_queue_free_regions(knav_qdev); + knav_free_queue_ranges(knav_qdev); pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); return ret; --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011045.outbound.protection.outlook.com [40.107.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB3313DB988 for ; Tue, 12 May 2026 17:06:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605599; cv=fail; b=JyjSs3S2eM3pRlNufLvQLFwrPeOSTM7AC1Bwp4Rs9hCvBH6ezQPbP5dZm01K4S8ElI6DQix3xaYYfSuCx93MTqFQjuWmVR+EG1S47lv+DgrQ57wC794Jbil2prEynpx/V4AHUYip+pzsr/Bf3faZgfMYkUuMxpjpoZ+SWKXqoWI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605599; c=relaxed/simple; bh=unkx76aTh07Lwq8JwpYielYI1CXzlSVBc/VAvMrAUR0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K6xdzdnZBejtt5neSy+kfBMcurBtlUbmd5HYgYGb1kVTsPT9YFaI4MKd197RMQVjciyBMHV94lN5sa8whr3ycr2xxZ01WZUB9xwTPHW32dHWZQ0uxa8mzavRSlCmMQra0t8PIPpSn+Mt/OnA9HC3K44lW32mWwYWYZAKT6rK0qU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=kgP0DEne; arc=fail smtp.client-ip=40.107.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="kgP0DEne" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R6gY6RKo9rIk/xpsLkrS4TbOTs8OMeSpMqHmyE0ugSWBmWX9+SjmvyzhH+JHENj8H7a4TU6FXHlm3ovfkzDNF2VgWY6Z9sOZ00KEJX5J6QdBMZUKSTQvuloNowYfga/RFF7lyuZAby7A2hgjkjHGY2OOE6F6XnFVw6YdMfRk5Daj3aklMikRZbgL+sDvZNMRpJL074DSsmHDoe6QJ007fS7FEsXOufsV7lWcpBVgperbdL7Id6Rn64zIhk63kIm9QySrNgTuM4o6HFj1s325PiI7MHcXiznbcrX5kCuOXGWLzRYyXr3TTqIdz5gQKR8iP8ae8ncv/dVCZXaPsLmcXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ME4FtsGHKYZtRaIgUY5JetrUtilxFCYnQ85JSYG/qqc=; b=KNmWAgiDC+nG2/B+ho4yiWLQQeNKrRbN34HZTxUajOsT+W2Nixc02JY7Se1Lm2mb7ND4g1jiDxHJMt02eiYqJCVkI+GAewNswtKRZ1DYanZhR7cY8BrnggPP0CHarxQa/L1ZfMiDBOrkQYcEQKbhb7f0qsUilj+cuHm8D6SVN3236Qlm/4G0gOnV83AW2GvCXETo8Spi5x/yGWtaY3pCau5PoQbYPHK3vt6ukzmi0rsZignRdCQzQaxeuiKRaM2AUWRmjsgq0eMtUtssgnMEfBMlx0ebtyc8YaNMLy3BVC/Id4zhTMasb94KCONsVnl6NJXNLH9rBATEqlhvwMhdEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ME4FtsGHKYZtRaIgUY5JetrUtilxFCYnQ85JSYG/qqc=; b=kgP0DEne9WJPtNIAry/O/3X9WyhEbTCYZNNO81QBs6ypZKoSSuvFzoVdGKqncCZuI6WZLXubFGMlq6h5J5sQU8O5s4FesVvrSYRLWVJQlv34tWi8TtJNYkA8p+1OT+LIzbD6XG1oNYDioPWpbxGkpsEgKx20uyQZTyQNLmNUeFA= Received: from SJ0PR05CA0166.namprd05.prod.outlook.com (2603:10b6:a03:339::21) by DM6PR10MB4185.namprd10.prod.outlook.com (2603:10b6:5:217::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Tue, 12 May 2026 17:06:32 +0000 Received: from SJ1PEPF00001CE5.namprd03.prod.outlook.com (2603:10b6:a03:339:cafe::80) by SJ0PR05CA0166.outlook.office365.com (2603:10b6:a03:339::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.15 via Frontend Transport; Tue, 12 May 2026 17:06:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by SJ1PEPF00001CE5.mail.protection.outlook.com (10.167.242.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Tue, 12 May 2026 17:06:30 +0000 Received: from DFLE215.ent.ti.com (10.64.6.73) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from DFLE212.ent.ti.com (10.64.6.70) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE212.ent.ti.com (10.64.6.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:25 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6PkN2235132; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , Subject: [PATCH V2 03/11] soc: ti: knav_qmss: Inline lockdep condition in for_each_handle_rcu Date: Tue, 12 May 2026 12:06:15 -0500 Message-ID: <20260512170623.3174416-4-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE5:EE_|DM6PR10MB4185:EE_ X-MS-Office365-Filtering-Correlation-Id: 21a06159-bbe6-49ff-5365-08deb048cfd6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700016|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: L4kPQO6lCGSF9+WsOnfOgieTmMcFlDGN1fMSFYzX77d4w3pygc1lrPJfjdUOnFRsOENYHbKyixcpKRhxAabkH7+Lm7a3LqUT2Ss5VDxk8OwGV3wZTjZyrBLnymoUiM/ZOCp7oQn39WPj9FA0hKr6E2dyBu4qD0OJzmwFTHBVD1xphMmVOubswVt5WtyoiQe6VX60rDXWj2fPQK2z9QZl9lIHpcf1SVa8ypFmIaf4yLT7CbADJ6jBbIgquRD0BXtO/5JrAYXZwDhvHNsbDPT/mMYy2V+tG0/Vf7zeYdlNhFdu34uR3+N/9Oi2tVij3ln4ldFmjeAayxXW1WAaWmz15mFqpJp5Euz/+S0rhRKwNmb7iAxeqVKw0FOl1/SKxRQtcK94CGVtKEpYBw3RJY6p312UkGfI5aLmRZYrBBywQJ1s/OAh0d1VnQcBIuRtNGGdQDdoIHb6aqp5UcfKNoYgRMvfG9+ZnVG6gJfoRzNOhTYDF28ifgBPG9RWG5WZbGIS5kRG1KIMc71Fh6yGZx2yZoDkVbuGMSeD4pfXHUefUU9m8w9yxOIhfejz9vVdirdOVFkTmnXITW7oLbtBaru6rDrXl/uO0xU8qmvQB9lM5kPOXPNTQfk40ZJH4cAiCURCgjom183qr7QM6zY5yM+v0xAy2nUEagUn7D6C1qPSETZW0tj51aj7VbFUIToV6KammXupQWPUzUxkEd8HUzNoz8DAAXt5picdxtS5juNKy0I= X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Kg2vmuCMkquu22UDZ6bPwL1yjib7mze0g+1HO94s5ONr9+gBJJSFrINs/GSOBeJ08i0eZaBa5lOZ+ORL35n2ii6xIp1x6zucVv8f4krzy6VgG+e1+8HIqO6x8ITgQppEt+DZY8uyy+CkyhM40ysTNUH52CA5T9FeQifjYLfYDFSiCzmdh0hno/f3KbOfguuj/biKOEwC2P/J2IgckrvHTSKRaIM20AmUAXYcDeFPFKcOXI25C9LGyKBD5oOzhVaPK7ku5x5yVEL6j74oFUIFNGMRMpsk7aJkR3erET6xa4UXDO3ypsP19Oe6L48HxbkYhLz1mIQVfoaw2RB2ytk71awV2atyz7hkxvQ9H//E4lWlVkDMh7LjlqWOHGHuKELAswvgcsW5py0gFR2yNKvWQoHfQp+z9n7HU9pBtQMl0dg3QywQjHNDTVGI0mDy6IVY X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:30.2947 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21a06159-bbe6-49ff-5365-08deb048cfd6 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4185 Content-Type: text/plain; charset="utf-8" knav_dev_lock_held() is a single-use wrapper around lockdep_is_held(&knav_dev_lock), used only as the lockdep condition in for_each_handle_rcu. When CONFIG_PROVE_RCU_LIST is disabled, list_for_each_entry_rcu() elides the condition argument entirely, causing clang to report the macro as unused with W=3D2: knav_qmss_queue.c:30:9: warning: macro is not used [-Wunused-macros] 30 | #define knav_dev_lock_held() \ Remove the intermediate macro and open-code lockdep_is_held() directly in the for_each_handle_rcu definition. Reviewed-by: Andrew Davis Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - Picked up Andrew's Rby - Replaced CONFIG_LOCKDEP with CONFIG_PROVE_RCU_LIST in commit message. V1: https://lore.kernel.org/all/20260508153211.3688277-4-nm@ti.com/ drivers/soc/ti/knav_qmss_queue.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index 2c103bb6edef..f65658014b05 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -27,9 +27,6 @@ =20 static struct knav_device *knav_qdev; static DEFINE_MUTEX(knav_dev_lock); -#define knav_dev_lock_held() \ - lockdep_is_held(&knav_dev_lock) - /* Queue manager register indices in DTS */ #define KNAV_QUEUE_PEEK_REG_INDEX 0 #define KNAV_QUEUE_STATUS_REG_INDEX 1 @@ -58,7 +55,7 @@ static DEFINE_MUTEX(knav_dev_lock); =20 #define for_each_handle_rcu(qh, inst) \ list_for_each_entry_rcu(qh, &inst->handles, list, \ - knav_dev_lock_held()) + lockdep_is_held(&knav_dev_lock)) =20 #define for_each_instance(idx, inst, kdev) \ for (idx =3D 0, inst =3D kdev->instances; \ --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012028.outbound.protection.outlook.com [40.93.195.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8E313E172F for ; Tue, 12 May 2026 17:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605603; cv=fail; b=mDYoRzdkWXc3vaBkRNmp0wa/rq0xBCzSGd7omg0+oLF1+U+pbaScX9J0R7Ux9gtV+O1sELMyPCvMoWVKEhY2GPGSLLMlOEXatHZ0mmZ8A/ypM5lGNNa548COVL1P8iboLo+uzMLmDxIO8o0W7Kt+0P8/p5q45WHEJCuHGj+pFFc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605603; c=relaxed/simple; bh=vJwY8110wn5gR5cX5/Jj+WCQaJD/FHh2RmLF20aD/2c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lrxRYXCQDqByqKEmri1g27GEzFvprAB8T+EnP/afrjguMTIuRy2DxH3GU9e1cpnq5+qAcbxdcogD3L6shIPHgHEvyC9hNT+JWY+lKKZz4qQVULXcXWFuxWRMI3i2WBg950Cv16Bb7YLbQpeaohHH/hYO2dxcWQM4K5Y8RMlVPQA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=OOSvPWMZ; arc=fail smtp.client-ip=40.93.195.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="OOSvPWMZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EWaswd0UFInXzEvHqqDweInKtuPJADfgF38vo2ONBDrYor0F8RXyF538PUuShLkoorUrh3rHdo64zE1C4hno/pXkaEGcS4Xq867CkW9nDgr2/Frjnm3f9FOna7K5KMmQSA7oosHXjAEH8wu6orV1DwrDYkYaV6DK9HBk3nKpUiJYYNb7COz5/Mb7mPuL1ODRuQgSIuyTqnxCXay1a984GqDNbGLA1pTzi0P/i9J3901VTdo9yYKH70sZWceXyEkqR6AFti33FvFIOnOdvFq/bbdE4Ki+RjGk2ZN0lsPg7dQo1NhQwwZe3DAa3UdCYNjCTCkp/T/ac4iet0+M2xnCuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4kvCL89Ro3HL9rEfL+xQ3eBNuiik677mNHRJlZk6NJg=; b=Y2VshKek01qFwlMgT6G7DxvF2DU50E37ROAOv3h5dOK3XVkp2Id27Uy+vEe2SJ5AmGoeTaNeIeciNuwt9jbFnp4vOzocvQHwgbnvgQLY/NrhkeBg2qV2XDVdcT6a5Yv+EMqsC6UtrXi2NEwqjexVVxwlq2jkHhQYgXCGB4BqUUVfvZgLvF0vwB0ATMjxqz+bO7I+qEdcMRs2RcA/88menYLz25FzC0GXuxNJUtpf8d9vUikRTtYHuiAWoHqhP2YhXK21ULqPkKGXNvs4Bmcf7QwRfH5AUwpt3IJqDoQYK5GVLrFQuMisFqdnRi8bQ++v5Ai0z4pVf5RXZ7wzenmi6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=infradead.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4kvCL89Ro3HL9rEfL+xQ3eBNuiik677mNHRJlZk6NJg=; b=OOSvPWMZG7yYz2QOzQOJ6eamCop3UgbA4s4Appcp/0MgR1d6d5L2Dit4i28b0G8ySXCrMDnGm/7NjLCT/RHqPJcphEugqpq0VQYpKSiPncfLYzcmaGmc5IkO7WXyMQzI84RjgFB6EWt/IIoUYCzIvE34MYbNk+QC/g5/QgPCads= Received: from SJ0PR05CA0180.namprd05.prod.outlook.com (2603:10b6:a03:339::35) by SJ2PR10MB7810.namprd10.prod.outlook.com (2603:10b6:a03:578::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.22; Tue, 12 May 2026 17:06:36 +0000 Received: from SJ1PEPF00001CE5.namprd03.prod.outlook.com (2603:10b6:a03:339:cafe::b) by SJ0PR05CA0180.outlook.office365.com (2603:10b6:a03:339::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.17 via Frontend Transport; Tue, 12 May 2026 17:06:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by SJ1PEPF00001CE5.mail.protection.outlook.com (10.167.242.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Tue, 12 May 2026 17:06:35 +0000 Received: from DFLE215.ent.ti.com (10.64.6.73) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from DFLE205.ent.ti.com (10.64.6.63) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE205.ent.ti.com (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:25 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6PWJ1887820; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , , "Randy Dunlap" Subject: [PATCH V2 04/11] soc: ti: knav_qmss: Fix kernel-doc Return: tags Date: Tue, 12 May 2026 12:06:16 -0500 Message-ID: <20260512170623.3174416-5-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE5:EE_|SJ2PR10MB7810:EE_ X-MS-Office365-Filtering-Correlation-Id: ef8fe1a4-1268-43c8-6325-08deb048d2c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700016|22082099003|56012099003|18002099003|3023799003; X-Microsoft-Antispam-Message-Info: T9Pkg3/ISx72QP3JwDa5yLPbshWCQWBNvnJchK6YMBfoxGqh07VJ4ZVuLijBYOiDc8NlSmKOefsvYWCP/cbNI38CSQqvjg4wC95MH2Due8VPc7+MKuiq1T9sEaopAVfGtEtYQUs5TZkBAViEN38+p3/eC15RucV44scNQHeqr3aOf48eYk3/t1FlnOXbCW0sA7PJRVj7h/x6UILaC7q4+2xtrJmaBR/k9lVL5rKAdo2oMyv+/h1MQvYf5UXEqy2yyDwj3Q2ztqZnZiioRL6gypjwdlOyt+zyUL3ugPH6TSTaLc8W/VUGmjCxe43DnbLSyHyUBjedajhvYIVZ9N0jrPNmtseV+6gk0Lk4zclvmrfCVnhmek13iqK84iZToPKUKHPOyg/xnzOxHA0MEh/fKeJkAXO4tF3JvxS2toDu+Y5yeYF/lbGFeVu0aAgqZ0T9Ls3ri6QOcx6vJXStjpLSPF6uKwifTNJfN/4zznZSQi4cWugtWZyXIvDuHYsrpuCGmPPNSmq/VWVHh5grrE/8a1i4sGr5iHdF4nUgaXyQxRwcF+gZLJpeyv0KwR34n54o5WivHd+JWdvLelzbxQzAQJIiBnbK0BkWtR0QG8ba0dK253D9BK43e+mDsnUZpyzwyUilsVgxLONX4ZWN+z+DJjlUYYBOKMBa6Ft8Dw3HQ4ciHp2rBQ+xH8fhtVUPcVg5uW0jLMb1kR44qvWZNt2oyN37yDkLL5SBPjdiTIKfAT4= X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700016)(22082099003)(56012099003)(18002099003)(3023799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: upvp4CSPR+ntHjPZ3QMPaPx+BKDakYyZP51b4RxYQC5cljFZYIjIW/nzItLZ0LtiQTUs97AtsTNYU3DnJj6uR7nP22yOgldF63H68RTndZCBMoMps0KF2USIVPisbBeQeCdhrayNEpabcQ0/wii6An3jI5bhTswER6Gue65UHMPuOFmyvnKVusaqS+4gRgMHFYjjXBrM5fIyCSdN+fPVJvrMKMSpYmTNtutPIrLVDVCmysMTYeyKYHgQxcKCnTWgNESy5PY8g4YXFyMnSBItbT/AgJltcirM8Tn+2QOl+vEdpj3Pn7MdM5PfHhCrp6bhyFCM+bcLnig+UpK0u5FP8ZDTp7KpbnvnQ4SAky7a1s3nyQ8TjwHFDWGhswFm/Y4i21pn/4h1VxLIE/iNWE4WpEtbV3oD5CLoDTMd+W9Mi/obG5dgZO0gKq8yHOl8Bu7D X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:35.1796 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef8fe1a4-1268-43c8-6325-08deb048d2c0 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7810 Content-Type: text/plain; charset="utf-8" Fix functions that use inline 'Returns ...' instead of 'Return:' kernel-doc comments, producing warnings with W=3D2: knav_qmss_queue.c:524: No description found for return value of 'knav_queue_open' Acked-by: Randy Dunlap Tested-by: Randy Dunlap Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - Picked Randy's Tested and Acked. V1: https://lore.kernel.org/all/20260508153211.3688277-5-nm@ti.com/ drivers/soc/ti/knav_qmss_queue.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index f65658014b05..c3f85052002b 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -517,7 +517,7 @@ static int knav_queue_flush(struct knav_queue *qh) * Subsequent attempts to open a shared queue should * also have this flag. * - * Returns a handle to the open hardware queue if successful. Use IS_ERR() + * Return: handle to the open hardware queue on success. Use IS_ERR() * to check the returned value for error codes. */ void *knav_queue_open(const char *name, unsigned id, @@ -573,7 +573,7 @@ EXPORT_SYMBOL_GPL(knav_queue_close); * @cmd: - control commands * @arg: - command argument * - * Returns 0 on success, errno otherwise. + * Return: 0 on success, errno otherwise. */ int knav_queue_device_control(void *qhandle, enum knav_queue_ctrl_cmd cmd, unsigned long arg) @@ -625,7 +625,7 @@ EXPORT_SYMBOL_GPL(knav_queue_device_control); * @size: - size of data to push * @flags: - can be used to pass additional information * - * Returns 0 on success, errno otherwise. + * Return: 0 on success, errno otherwise. */ int knav_queue_push(void *qhandle, dma_addr_t dma, unsigned size, unsigned flags) @@ -646,7 +646,7 @@ EXPORT_SYMBOL_GPL(knav_queue_push); * @qhandle: - hardware queue handle * @size: - (optional) size of the data pop'ed. * - * Returns a DMA address on success, 0 on failure. + * Return: DMA address on success, 0 on failure. */ dma_addr_t knav_queue_pop(void *qhandle, unsigned *size) { @@ -747,8 +747,8 @@ EXPORT_SYMBOL_GPL(knav_pool_desc_dma_to_virt); * @region_id: - QMSS region id from which the descriptors are to be * allocated. * - * Returns a pool handle on success. - * Use IS_ERR_OR_NULL() to identify error values on return. + * Return: pool handle on success. Use IS_ERR_OR_NULL() to identify + * error values on return. */ void *knav_pool_create(const char *name, int num_desc, int region_id) @@ -878,7 +878,7 @@ EXPORT_SYMBOL_GPL(knav_pool_destroy); * knav_pool_desc_get() - Get a descriptor from the pool * @ph: - pool handle * - * Returns descriptor from the pool. + * Return: descriptor from the pool on success, error pointer otherwise. */ void *knav_pool_desc_get(void *ph) { @@ -917,7 +917,7 @@ EXPORT_SYMBOL_GPL(knav_pool_desc_put); * @dma: - DMA address return pointer * @dma_sz: - adjusted return pointer * - * Returns 0 on success, errno otherwise. + * Return: 0 on success, errno otherwise. */ int knav_pool_desc_map(void *ph, void *desc, unsigned size, dma_addr_t *dma, unsigned *dma_sz) @@ -942,7 +942,7 @@ EXPORT_SYMBOL_GPL(knav_pool_desc_map); * @dma: - DMA address of descriptor to unmap * @dma_sz: - size of descriptor to unmap * - * Returns descriptor address on success, Use IS_ERR_OR_NULL() to identify + * Return: descriptor address on success. Use IS_ERR_OR_NULL() to identify * error values on return. */ void *knav_pool_desc_unmap(void *ph, dma_addr_t dma, unsigned dma_sz) @@ -962,7 +962,8 @@ EXPORT_SYMBOL_GPL(knav_pool_desc_unmap); /** * knav_pool_count() - Get the number of descriptors in pool. * @ph: - pool handle - * Returns number of elements in the pool. + * + * Return: number of elements in the pool. */ int knav_pool_count(void *ph) { --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011066.outbound.protection.outlook.com [40.107.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ACDD3E073C for ; Tue, 12 May 2026 17:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605604; cv=fail; b=lHky3nNX4twfxiPe39AhVF+K+YV36ItvfbqGFq2oKkF/KoS5uB9sMW1W87eLOK2w6fLRlFjODJYIrtfXdVjLPM+D9Y0H+6HgfWiQ+1msPLJfCHq7AESRMjKPXXGILboEKa/wdP6OAGi9+hNAD4yysSY68KMeixPgLqKSlx+psqI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605604; c=relaxed/simple; bh=p1KhN0E3I0ZyDM+nheVfPEeK/s6eVMJ4xPwMIFzv2Qs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kDy48kc/gJpibiviRgLztzjOax1a6ImKSPjh9ECr9usq3AinKQCdkYU4VJAxRU/PZX1j7DqYEblz/Y0PZPA+DQT7ueZ/E34xCzhrYoSSCqU0IGlz1IboJl86aZxtgtyqIYM8LsDTFzpHYhjsjb4JfXETEzvLKVYvRToEaZAkFJw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=oHKBE+dH; arc=fail smtp.client-ip=40.107.208.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="oHKBE+dH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w/vX7KCThrtbyCJL4RdOrTmIvsFV0iHt7p2CSg98YggqyDwQ1fObBDt6mMW/1xxfdDga6jmaXGj9vgDBK4BdFtH0T/+JlzCI8RQYtgIwQVW7whPwKTb/OJ1WqVmM/8L4B5wab1PLPVFhl/u4ZnjagsHRvy+gsfk+3kOBKS3vVR+Yb/vYjHHmRQOD29/xu1QjU+XmveWfmbfyiitcNJ3GDxfiHJBRGDJkZMjm2ebIMAqlZqJFygySqdL9ziB8UOCodHMGZaMG1aBtIqN24WRTSDd2cclB90gJ7heSXjDr6+h/cvOQtoJ5S2xTz4LNt6wuE61XAP6wIAoP8YbZoxG4kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HajtVZmufe7MQp79ognmKMOCshMYmO3e6UNVc2nbHBE=; b=XBBy2nOxssSfhYCYAQhMi/Hps2zHDWCpJLJdDjda80Yh7A9JVnYpjxr+hbejYrGPJMK4I/Otyo6Mk3BocNhkET92p3MepgKog0dmFawic9G58ZV3hTkt8ALObwb4yFN9+0j/zCAheq9yZL2mnZuXAqWjLilptZKpDjnVc5IxeSqY2zxnHEMBGRd51eB8tfpKpOjr5Xlb4bwn321ksX+mN0qn2nGXu3zzWPVX0h84Z2d4p3XSJ9uMp9WkaRy6qQbCIGR0YVpXHC1paGjsZ7QcH2UkE/iFqReodV/SR+ScLCDwRLJ9EZxQ5B3NYTlfxjCmDZMhV/EEhhR80dVZFc1FHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HajtVZmufe7MQp79ognmKMOCshMYmO3e6UNVc2nbHBE=; b=oHKBE+dHX7zS6WYVmhS0TkmOgL0xlPJKqJ6FO1PeaVNLr4/DQqsgZ9DCnKBNKFQqeESg30FYhp2a856rL5zyWbtRq+mprqn6Nd6yVEDpwpHSjgwxnLxh9mqZ/3tAai02dlL1wUnH6qVjEm0mqTYSaXIzbcM0TIAFfFpj0uX9tjU= Received: from SJ0PR05CA0169.namprd05.prod.outlook.com (2603:10b6:a03:339::24) by IA3PR10MB8467.namprd10.prod.outlook.com (2603:10b6:208:582::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.22; Tue, 12 May 2026 17:06:39 +0000 Received: from SJ1PEPF00001CE5.namprd03.prod.outlook.com (2603:10b6:a03:339:cafe::2e) by SJ0PR05CA0169.outlook.office365.com (2603:10b6:a03:339::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.15 via Frontend Transport; Tue, 12 May 2026 17:06:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by SJ1PEPF00001CE5.mail.protection.outlook.com (10.167.242.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Tue, 12 May 2026 17:06:36 +0000 Received: from DFLE215.ent.ti.com (10.64.6.73) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:26 -0500 Received: from DFLE207.ent.ti.com (10.64.6.65) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:25 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6Pnl2235140; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , Subject: [PATCH V2 05/11] soc: ti: knav_qmss: Use %pe to print PTR_ERR() Date: Tue, 12 May 2026 12:06:17 -0500 Message-ID: <20260512170623.3174416-6-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE5:EE_|IA3PR10MB8467:EE_ X-MS-Office365-Filtering-Correlation-Id: 59e2877a-942c-424c-06e5-08deb048d3c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|82310400026|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: dLWqQHzYDb/djoHIG0/m3FRn6I4MfjwerrBgUAV/AHJbWlPulEIKVKjg4H3CNw4X8NpQWYr1Q/L3YshY+ZQSoOV2SwC5EUHxOWs+HlH+FCE3gtpOJRnLmxB+C0KkJJh+CG60Jw7mRSOJj8JxJza/ZOw8g1HqrXKhrh7Qq4FheimKt0LVIe1OqffjSr0LRPr/zCdfM6F8+DAQVoL4ET+t9TK6tb5/gyw2JwxjjFgNPxhLgpqSJhMPs0ebvdEG9Q9BABT6qAI9REV005CLKeCLJxOcG1YHYNZgBCA5A5VfU5J0UVXNzqqQ9JNOjalzD4peGXe8ZcLkpeHgzeZ7f2w04M6OtBV3NUfskeC8n03UeNvHMccFiSXyvqPdWC6eTx0YPFdnkJsPgPk0IDZ/RSwQX8mr0nyu9OzMYuwCJV0vlrVHEW4uMyVc2vYh8geUuEGiXtrKT7929Vbi7vrCCwpAb+2uLRmanUczJDKkMCsS5m0uAYBrH5wDoQqvEmiBhso74JZNPnWCpwuBIqWpRoZ+03mkTVIynYv//j6a6bPSHVRGhraV5rGfloGXrsnzPIKQ3ZFVetG6mdiJauDdVtE/AMm3qMzWrgDEa9rhqPDLFj1qu1LFlBv1iI5RxQLGK86AfCh0qBlh1X8y5/lNHr7XBcOQYQNWvzAXf5LjWCXd10Hsk6cHVLV+WoaUXFu1a20hvlwJ5VYINJdKhoGVdGXc0DN8y2iOiQjBlwXydYIuKoo= X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Zj39qdO29zynGMP/somNUWw21cMYIIl0GB/d10ax7bWBqkRirzVhlC9FJBiGA17L+xUcU9WWj3wmlne12/PSaklLUCOgbLdlCKFW8gUMeOBoABSIc4LJMnC18cFo5dEUGzua9qYb586pv8qEyhjHFdyHHxDmSWEI5emMF3czi6Mvqwa+WPxkDDEAkkX6wrj8wX8CdcLTAOsjTn748UgTZqnmrrEPmwkj6mn4WS0R1pP/jX44QeFDak7VyfgP/WGQoZ1PXT5n1hNUe+CjiVn0zUeT3Sv+xOFtOcxTnV/VTU9mHXYU3bgp1owaPKmQi6M3K0GEdEiSQ778QIJsyps9LlrbnfdwOQDnPsO7dUqcv217LEKotkxADNW4K6hez1pAHA2ea5NvgX9iPCaniNFX5jMWp9kKU67Evdi6fntApj0ynJg8VyZKlrKv7SZBXYtb X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:36.8783 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59e2877a-942c-424c-06e5-08deb048d3c3 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR10MB8467 Content-Type: text/plain; charset="utf-8" Coccinelle (scripts/coccinelle/misc/ptr_err_to_pe.cocci) flags the dev_err() call in knav_pool_create(): knav_qmss_queue.c:789:9-16: WARNING: Consider using %pe to print PTR_ERR() Replace the %ld / PTR_ERR() pair with %pe and pass the error pointer directly to also print the symbolic error name. Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - None. V1: https://lore.kernel.org/all/20260508153211.3688277-6-nm@ti.com/ drivers/soc/ti/knav_qmss_queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index c3f85052002b..50072e9dea37 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -785,8 +785,8 @@ void *knav_pool_create(const char *name, pool->queue =3D knav_queue_open(name, KNAV_QUEUE_GP, 0); if (IS_ERR(pool->queue)) { dev_err(knav_qdev->dev, - "failed to open queue for pool(%s), error %ld\n", - name, PTR_ERR(pool->queue)); + "failed to open queue for pool(%s), error %pe\n", + name, pool->queue); ret =3D PTR_ERR(pool->queue); goto err; } --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011025.outbound.protection.outlook.com [52.101.52.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDEE93D966A for ; Tue, 12 May 2026 17:06:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605594; cv=fail; b=jHj+4qfP+e2civxuKxqJstfinBLOf+kUzvF162Ti7pM+SNhzi+cS0cCqcpTHqZ25NldXqsUA1xYBl8/gwWn44/IRIPETGb4ou2k5E3YjaAQ1NQa99B+O40lOodHGPPHRv8vp8XR5C2ew9td50yBg+FVhMm51SguxZ4x/8wPWf0g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605594; c=relaxed/simple; bh=47ynvYiDHe5DwEIbbgZuF+w75fSu1dH925qbxC42TDA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jelvQPWmJyGf51GJ/iiSzJzUo4TUsAz9nuFXgIZ3z3auX7aGoBLFXCo1nZTfOu6A4Yjpx7HeTJup/nGhL3bgBclqHnJSbrqPXKnoSuO9UD9y7FecrcvGbcPGJgR9UHjpDYGKwcVwG0rvsL/zT4MWSHEUadv0wtW2rXWdiPWPatY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=QxDGc7i5; arc=fail smtp.client-ip=52.101.52.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="QxDGc7i5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Nr5LVXrhHK/hxFcJE7x/iTUFZl6PmDm78TdJ1rfCTmu8HWx15Czgzrkhp1GRV3TBNCHzqBOQZg1JiL+Wa8rHL7//Vx3/80BZ2MWunCuhdtGWH4MOVx+ep7hqBtfaLbxCbnGVBPO+uFBdXoZUVd8CrIl1YCtUP09HOZxBjyI8nKVOW+vYGvfUjwZpr+pxb/dN9jIhUfJqxO/YaWe+8IWzWTkwQ7Pkh8bpL8W/ZPVqBGgP3fUaOIntpJ6T+NcKKcSfOUronCEiAYp1kAaAqJk0+OD4Ja+20pfUHild/QTGEzwzNmuCqufFe/VHHRQwKWjyM5z6VIIPhfjWTkQpbosjEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tH1iSPUGcILJyJMLpmaUvCCX0dmGX7q3b3+fvsD9RQc=; b=JXMMJeEpKPIHsb0APAZoEOztdlWZQXg8oV/8o6edQv+SESXcaCLVTKB4LfXUg0tTedOytEyuLY33QMUAOrhr9COjwdFVWEum9xL0mmJvQwdpVLLKtaR93+YQbu1olSr5KnTnBQLBEv+x5AU5/uPkY9keAbxuwZ6DlGPndnezyQ5yyxipt1wYTBlohKNpgbvgL31C8KAHYp/l9h+pcytxIxQYLaprXpaCAlzuhdgmP/8O2OBUebTGYyoYffDCvQZVfBkNzBj08Tx3fFXafup1XuXI/wqtm5VL4ctdTgmo0/sTgtMEXsoNve1eAyMCp2SfW+eY2/LcXEVGaB+B0zLWkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tH1iSPUGcILJyJMLpmaUvCCX0dmGX7q3b3+fvsD9RQc=; b=QxDGc7i5Ag1W31QKeoFzSx7Gc/qWZcSVfwEmOW0Er191VF/zgSwLXtqoW1XyLWr2y12yjto+y9SPg069aKxtwIbZw8235log9hbjE+7WFG4iMwZkXsf6Q3V0UkF1Th4VnUhnbMZqcTPhMtiRUEwdoNtF/iCQtzVndayh9M68Lvc= Received: from PH7P220CA0005.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:326::22) by SA1PR10MB7789.namprd10.prod.outlook.com (2603:10b6:806:3ab::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Tue, 12 May 2026 17:06:29 +0000 Received: from SJ1PEPF000023D8.namprd21.prod.outlook.com (2603:10b6:510:326:cafe::6d) by PH7P220CA0005.outlook.office365.com (2603:10b6:510:326::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9913.11 via Frontend Transport; Tue, 12 May 2026 17:06:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ1PEPF000023D8.mail.protection.outlook.com (10.167.244.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.3 via Frontend Transport; Tue, 12 May 2026 17:06:28 +0000 Received: from DLEE215.ent.ti.com (157.170.170.118) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:26 -0500 Received: from DLEE201.ent.ti.com (157.170.170.76) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:25 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6PG12235143; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , Subject: [PATCH V2 06/11] soc: ti: knav_qmss: Fix __iomem annotations and __be32 type Date: Tue, 12 May 2026 12:06:18 -0500 Message-ID: <20260512170623.3174416-7-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D8:EE_|SA1PR10MB7789:EE_ X-MS-Office365-Filtering-Correlation-Id: 349b38a8-a93a-498c-5027-08deb048cef5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|1800799024|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: S6uyNvF/TbsjIBPcCCk9UOG5lAMqoFJ/ragGjN8Se/IW7F3J9CjTpA2IUEDB0Rh/5CfvfPwzY0iV7nnMFFjbhPy9URQi/eAevSZCNSCUKxwzfAUdGfGIcx/KkbE/pTJp1gBI1TXlBce4dO1tSwRJLjm1rYNeht3BGmmgTAsrahsOFnSIJCz8vqUSYDuXqzgFjO1ZT3dGRiuyq21HhxrphdVw94bUgEi0Lk1F16WEnXxM4926Z8LzK/i1OOyJ9ICt4ROHxi8N/eMlGbAgPzHXaKDBwacMNsUyZqy0RtCFw9O9u4hkyMAASSvg/42onBAaiMImBk38UGHyciK47ROIR/w/SYc+c+h6I9LYtOdOFgbWPDWWN4ps/cT93reFQwADRG36dlKyB6MsLBo1GWpX6Fdg598kb6M4j54+B+sX765r0gKxcJWI7p8Lu4fS2MHKx7bIq/PBw2kUuJyjH8L1Y0uLBQQVW1zhXPkS28VYpsY7uJWmdFhPVQeJtLd7AmaIpveTLNjF7OixLzzcBoVnCfguFhBPMjfAfEe3c9EtPD6FNALtvFTmwHBek2WNsRFeWSLjDGLi/Mf3QDUv4ngFZSs7Irk4JLrxR2WUtSBSbbQrx01Je0MuEeHmsOyDo/jZjX3O6HLHZGBbFh5uJ/tLBAkz2jFvK7b9+qRqR6pnVhG4M3ZsFlOMKAab/RU0JL9slsdiNDlJaVp/1tLCTYz3yGsxW5zRWMTB8ZIEBzeLPB8= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(1800799024)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: em9eGbX3XOAA+8Mo6XPPicUnjC78wszM0rS9XSR6qgbuP7VEdQbA9GwjZZB1IaAMpNBhSyLmwc0QZTU1oOw+Jk6mYAeTbebN1oQ+cVJN3YsSo2rUYp73Bw6zpxcqQXU+UlC0DSJxEy7zz+Rwn0rjczKWn5MNypw6aTWhW3GpxpXSy41u2qwDnzHvghl3fXvhfL/S25eGewhhVK8cy4Fc1Yq4z1Cihk5xLR/ce0HByTMKW1T7AvonrK/lcVbSJfBJBIF7QtAM8pXWXQz3rBupkXDOETCyS0Xi43iT/RyA7CK/Wg4ONOcoLEOkvy415oHdiesO7oMPviZOz269RyRpBa0uQdgsZWDWuY1MaXi50Kb9ArwpDJYqEn4fpWNlPMS/GNyy21opBtfSzTX52QfUmI34qirEM2VjBeFzSEKMtd0vFr0uibTs8tfxSMBQOMTT X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:28.8209 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 349b38a8-a93a-498c-5027-08deb048cef5 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D8.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7789 Content-Type: text/plain; charset="utf-8" Fix several address-space and type annotation issues reported by sparse: - Change pdsp->command from 'void __iomem *' to 'u32 __iomem *' to match the other union members (acc_command, qos_command); adjust the offset in knav_queue_load_pdsp() from +0x18 to +0x6 to preserve the 24-byte offset. - Fix knav_queue_pdsp_wait() declaration: correct the parameter annotation from 'u32 * __iomem' (pointer-in-iomem-space) to 'u32 __iomem *' (pointer-to-iomem); use 'unsigned int' for the timeout parameter instead of bare 'unsigned'; fix the continuation- line alignment. - Use IOMEM_ERR_PTR() in knav_queue_map_reg() instead of ERR_PTR() when returning an error as void __iomem *. - Annotate the firmware data array as 'const __be32 *' instead of 'u32 *', as be32_to_cpu() requires __be32 input. Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - pdsp->command from 'void __iomem *' to 'u32 __iomem *' based on Andrew's suggestion (it is a more accurate representation anyways). - Fix ups in commit message V1: https://lore.kernel.org/all/20260508153211.3688277-7-nm@ti.com/ drivers/soc/ti/knav_qmss.h | 2 +- drivers/soc/ti/knav_qmss_queue.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/soc/ti/knav_qmss.h b/drivers/soc/ti/knav_qmss.h index 9325e8ce2e25..037dc1b36645 100644 --- a/drivers/soc/ti/knav_qmss.h +++ b/drivers/soc/ti/knav_qmss.h @@ -123,7 +123,7 @@ struct knav_pdsp_info { const char *name; struct knav_reg_pdsp_regs __iomem *regs; union { - void __iomem *command; + u32 __iomem *command; struct knav_reg_acc_command __iomem *acc_command; u32 __iomem *qos_command; }; diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index 50072e9dea37..a747a08115d3 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -477,8 +477,8 @@ static int knav_queue_debug_show(struct seq_file *s, vo= id *v) =20 DEFINE_SHOW_ATTRIBUTE(knav_queue_debug); =20 -static inline int knav_queue_pdsp_wait(u32 * __iomem addr, unsigned timeou= t, - u32 flags) +static inline int knav_queue_pdsp_wait(u32 __iomem *addr, unsigned int tim= eout, + u32 flags) { unsigned long end; u32 val =3D 0; @@ -1368,7 +1368,7 @@ static void __iomem *knav_queue_map_reg(struct knav_d= evice *kdev, if (ret) { dev_err(kdev->dev, "Can't translate of node(%pOFn) address for index(%d)= \n", node, index); - return ERR_PTR(ret); + return IOMEM_ERR_PTR(ret); } =20 regs =3D devm_ioremap_resource(kdev->dev, &res); @@ -1556,7 +1556,7 @@ static int knav_queue_load_pdsp(struct knav_device *k= dev, int i, ret, fwlen; const struct firmware *fw; bool found =3D false; - u32 *fwdata; + const __be32 *fwdata; =20 for (i =3D 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) { if (knav_acc_firmwares[i]) { @@ -1578,9 +1578,9 @@ static int knav_queue_load_pdsp(struct knav_device *k= dev, dev_info(kdev->dev, "firmware file %s downloaded for PDSP\n", knav_acc_firmwares[i]); =20 - writel_relaxed(pdsp->id + 1, pdsp->command + 0x18); + writel_relaxed(pdsp->id + 1, pdsp->command + 0x6); /* download the firmware */ - fwdata =3D (u32 *)fw->data; + fwdata =3D (const __be32 *)fw->data; fwlen =3D (fw->size + sizeof(u32) - 1) / sizeof(u32); for (i =3D 0; i < fwlen; i++) writel_relaxed(be32_to_cpu(fwdata[i]), pdsp->iram + i); --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011016.outbound.protection.outlook.com [40.107.208.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C08D3DB967 for ; Tue, 12 May 2026 17:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605598; cv=fail; b=ofx/R34JD3x2C3MRkYAyTkbNmj+A3igzJlTTtXYThBmq3PO+C6Fd17jnH60g4nl4QsucQuhnurAE2cFa6pa2NJJ2jiBxjOQoChvBLpv00zU2DFF86zA8Qf8f+odXHQp+5cJwlc76flckkPXMRrYu3qu4nQJ3ppAd679GoLIKiEE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605598; c=relaxed/simple; bh=4ppRk+dfI5YsIQDgkcwiTig3xOVA9i2Cwh6FEU52jpo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Oggw9DQ7VWiLYu8zFMNKeVY38ZNNyZOmrvChLGWo851D8dKVm9E+uQ6UKJxz8gj5xw6cCQU/16aPbJjpkNQBYx8Ar1ylFLkXYw0b0s+e9KfDtOXPJJni8WjJX6WWFq6qOUlrWgRsOqzZEVMaPAKMaBPTJTiS8hFRFrroLGpF8uU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=B9nmDYQJ; arc=fail smtp.client-ip=40.107.208.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="B9nmDYQJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r7bK0Aw/iTGEJzN457MFehP5oGy4rKFojBWjEisj10Kx0AGXrNP4+XGWU91KX5SZnTopbJc6k00dzy4t5fuWqBkf3zCFHNL9OIlAKgYMRloPhe95dT6bOoKU3MTwl3uvt4FISqcKUVTZtjX2qrqOZC0vzdvgylJddfTnDoDCb6TPVCWUNPq/s5y9h/Cs5Roj0+su3sbRv+kb58f2c3MDb/d7orFcchLsaygZ2g7IWcgaB5gjKhGChNSZsLTmhOO8/+XW98S+AwN3qwQzxq1HGPvsj/GCCQ+y+C/IRmmSieY+G6WDB2s3AKnhhgQEz+GHifCoM7Z0DPrnDX7hipf/+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WTE9sENCyrA+FQ3/aF1GiuwlmmKh+HsAjVQHsUOsWFo=; b=OTZByqY3fxvbIhIgJhgeYJW5kGJDfZlZqqPpdHO6IfPwpMLMXmcLHQ1Z+qoEsXNUZO0f64QnkYlMOyTdWNPvmM1KilJ6iPJGB4Jvy8EVqHLZBrKOeSUjLh6YKDt/OvyrOdfIQeWKEAVbdQc/tUVmj3TI9xVq+FSAGM93/mqGum7UnWY4cCHWl2Ip1rTox8tEAGImZicXPlxUnqlWVTRnSSFpsyI9G6JroDP+GWlVU7s60SK8URJxPAeA24X+U2rn58OE90L6YHB19gDVL1O+c3Zen8nNVaabsfISOEQLyTe/AZupMusEbK2VbVk/DfUkXFkDLYjgKy2VopIRmaFiXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=infradead.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WTE9sENCyrA+FQ3/aF1GiuwlmmKh+HsAjVQHsUOsWFo=; b=B9nmDYQJ7fZf4YEP5MfBEJSHg3DS0adfyr1gGwM1bHU3BZbHdIrC3LR0yVuNCohRdTxS3HbbX1+AIvrhfZOuQ1pNJpqt42abxTve0hbzzQhPNOBBZgSvt2lNsZU1z03/e5Y4/8sjdntpsZnq3G2OLRFM44L04clgav5r3uphC+Q= Received: from PH7P220CA0029.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:326::21) by DS4PPF0316BCB78.namprd10.prod.outlook.com (2603:10b6:f:fc00::d04) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Tue, 12 May 2026 17:06:28 +0000 Received: from SJ1PEPF000023D8.namprd21.prod.outlook.com (2603:10b6:510:326:cafe::8) by PH7P220CA0029.outlook.office365.com (2603:10b6:510:326::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.23 via Frontend Transport; Tue, 12 May 2026 17:06:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ1PEPF000023D8.mail.protection.outlook.com (10.167.244.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.3 via Frontend Transport; Tue, 12 May 2026 17:06:26 +0000 Received: from DLEE208.ent.ti.com (157.170.170.97) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:26 -0500 Received: from DLEE201.ent.ti.com (157.170.170.76) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:25 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6PBc1887826; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , , "Randy Dunlap" Subject: [PATCH V2 07/11] soc: ti: knav_qmss_acc: Fix kernel-doc Return: tag Date: Tue, 12 May 2026 12:06:19 -0500 Message-ID: <20260512170623.3174416-8-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D8:EE_|DS4PPF0316BCB78:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f7f28fd-4c22-4221-54aa-08deb048cd6a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|376014|82310400026|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: n4SWjYhobuS40c/4C0A4zM9Cuu9uIi7lQ1w7U68+38amtAmxZ+zGRS+Sr/ajpnoG/tv03g5aMX3hD2t1n68TftBApjDz2rK/UpYbj/14VSWI27e7LPrDUcXw2MJ7HXe1WcF55FrnU82smqrQQiq+xxOCx78XVmndvvAoeHlyuWVf6vaHAdc3ESY3jU7jecgXIbi0voUM8sTLMbqdvcIUx/JT3Pd/kB8ndfX3IYrXc6orALObxe+MmQhUuGeHTKIUTDH1qVZKYs9QeEQiHNYjaFHG0yzxWft87hcbbKsYBkOP4tKoe5j/F1zGO81SMt6z26f3lVfgKrZxs4LW5S7P0nqb3C4F5s44l6a/xeztBfyOMwNrkVTkDtn1uZf/fUN5GLUUWF2Aq951RKE4BXsHfAQnaY+HZ6/IUFif94d9vfZ0ERD3MVlE1vr9EmXFjyVYfZkbsurW59jWRhl8fln+/pbqmvuQ+w9v/Fzt2610rXjh4UagCflZn/w5p76w3nwYb8vpV5ld6pgfaZNgBkv9G65F8lngjPtVP+AyJIX0eLD5LnYOFaY4MmtuN+/bw7MIxqlCqOH+QhSUfx6zjoC92d+teoxYBIttwQGcsLoX1WdhUt5sCXlDvlyCphupCjGqVdF3c3lBzm01kyye6MRwEuDtX/Zrxi0Haa2eU6kw0a9pWDQuu/id/BrtWwMSDZGsTzkBKtp1BpyVVrWamTc/J7vwV1o+rq2StOKRc244+5M= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(376014)(82310400026)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: A0lVh85W8H7veW78vCvbm8lF7QedOTN6QBy1cX/DEdn3AR2atkV0UgyOaghErpHhXvZzQkageaK69sDJwBdGFsc4fSSYKzGfc63tgwuQNcWFR9hsQF3HBW8Yai3AdGtrafybPECyKz1L+C8p7hPfR+Dz2xZny8ioRZ57fqCvOrXDs5YGbPWAmd7Wsv7Gm3wyG/isvsdAp9gVXQDzmAt+sO/x7vV0xaH+kxGfK0Q5S8DPp2JP9pNbCabhQgsNID2u6fcs+1Tj7EsTppF4OZSA54+5IW4V58MjoJX+Y/AUc9NliHkMRHts56YBEzD0Vq2ncY+aFfN3hzU8m25aodxOLJdUV1PfbKXYDRqi1UqWIr15nqeO2tkozlIFzYOtUqnRcrlUqizCN4Y3/JrAGuH4iRKKqGNNaYMNSoj9Hz04oKcbcx9qIIVxPIVe2SSGzhML X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:26.2326 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f7f28fd-4c22-4221-54aa-08deb048cd6a X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D8.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPF0316BCB78 Content-Type: text/plain; charset="utf-8" Fix knav_init_acc_range() use of 'Return ...' instead of 'Return:' kernel-doc comment, which produces a warning with W=3D2: knav_qmss_acc.c:473: No description found for return value of 'knav_init_acc_range' Acked-by: Randy Dunlap Tested-by: Randy Dunlap Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - Picked Randy's Tested and Acked. V1: https://lore.kernel.org/all/20260508153211.3688277-8-nm@ti.com/ drivers/soc/ti/knav_qmss_acc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/knav_qmss_acc.c b/drivers/soc/ti/knav_qmss_acc.c index 269b4e75ae40..1f8b5acdd462 100644 --- a/drivers/soc/ti/knav_qmss_acc.c +++ b/drivers/soc/ti/knav_qmss_acc.c @@ -466,7 +466,7 @@ static const struct knav_range_ops knav_acc_range_ops = =3D { * @node: device node * @range: qmms range information * - * Return 0 on success or error + * Return: 0 on success, errno otherwise. */ int knav_init_acc_range(struct knav_device *kdev, struct device_node *node, --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013069.outbound.protection.outlook.com [40.93.201.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 836783DB961 for ; Tue, 12 May 2026 17:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605600; cv=fail; b=nH5x0UI7YZMiDw9LF2jGeXTtgqJA+yzH+f+ShuF9u7/T1/WLpLqUerNj5v4wXENvNb8FUCda52vfvTUPCkzlVGvMQ72XnLRM2O/Vk3UW8Y8q/+zt12hiPDa+cztPyF0wt/5BJR9LH0yAuxOQgM5UeQsjUUwfAbvn15JPe1uEPtk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605600; c=relaxed/simple; bh=HKe3SRb63QQvaP+itg+ycNSsFp9fDOewHTvSdI8bM9I=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ioNoXUuZEjd1poELMzdqCPp93MoDX1uPgPD+9g1CESJ8K6Giih848va5Li4difDMFiKJmQZz4n7193WfN/se/iLdOkT7SXwpP/AM3uXJWPJXyFRAvV0OneGapYJoF5uAHe0YXDCRt4/a2CVhiUEmxPIzaXPjJl27NT7I0JNq+2c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=RHL/Ebcu; arc=fail smtp.client-ip=40.93.201.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RHL/Ebcu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wvlpoMZH2dZXxsudbVIzv0TqdLkSDQdIa8Kr+I8afjCrZo/Vyi7Hd/2c/W5CFs4B3ZUp37OJWaSc00HzGT4TjYRHQMmidMP/mip6ST6rHQmQSXo9bW7OLLkf2YQTmCVT2gl7hMjqXyUyRWQA6nIIZ795CO5VETv8jDoggfArHLOPVQqy4r7Sxih3Qaj67mkSiSdVjqZi+vEFDb5FHFS5HLJFWW6NY689B5BB2WFtInfSKhUoEBvQ5+ZfAe0/RUxR0wlB9ipXFnDgm0kZ6TFrgXw0aluH7NCkwOBeqi7CrlbMWq9muEL2hrljwmvSPT040ve7ybA2DseXyrkdYyYGrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ijNufQmCQt8SkkedI37cRQEUYPBTRkUDlDPggvgPxis=; b=VO1lfM11UjkViAc9+ldb1U4pEY8n6Dy6+7Hbw9Qo/vjWeD813lOrACv9KLaAPPyZ9FO7sUTbzb20b87t8fpGmX544cDtqUpFoDbhOSdfMs/0C8UpC6SRtyFO5kbqaxA9dTutesWqaGqHY3KZTfNIbpDXPfDoImobWIiBTQwEcog4IyPYRsMlH7Cd1znL4RcTrzMkpuX3oZM135Py3USm+Ea0AuLmeeHgrHK2Op4Zi2GKPRIfF+Wgk0wI5cESw2XF2TPxwYhSa++9LBaZcVswFaV6VNF432zrddWDl49ZFZFQBW5RWrQv9udoHCo10g+DvHthhUJFMRtzz9DMJhul9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ijNufQmCQt8SkkedI37cRQEUYPBTRkUDlDPggvgPxis=; b=RHL/EbcuMbIgkwjzVK+/nHPaDuVjTubUPnSK9oJHCphl4YRg0MQykRjEiCd08QhWgqpswjOcXLUrzXo+d19A1IjhwR58fVZDhrbA/EKWy3pQ2Aa7kxP+0mvqx8tjvWWXCf+mgLqP3aZ1MebofcIP/Dzbw0PX7/6yBYVfmB3bKjo= Received: from PH7P220CA0007.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:326::13) by CYYPR10MB7607.namprd10.prod.outlook.com (2603:10b6:930:bf::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Tue, 12 May 2026 17:06:31 +0000 Received: from SJ1PEPF000023D8.namprd21.prod.outlook.com (2603:10b6:510:326:cafe::f8) by PH7P220CA0007.outlook.office365.com (2603:10b6:510:326::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9913.11 via Frontend Transport; Tue, 12 May 2026 17:06:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ1PEPF000023D8.mail.protection.outlook.com (10.167.244.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.3 via Frontend Transport; Tue, 12 May 2026 17:06:29 +0000 Received: from DLEE215.ent.ti.com (157.170.170.118) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:26 -0500 Received: from DLEE215.ent.ti.com (157.170.170.118) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:25 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6PrK1887829; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , Subject: [PATCH V2 08/11] soc: ti: knav_dma: Remove unused DMA_PRIO_MASK macro Date: Tue, 12 May 2026 12:06:20 -0500 Message-ID: <20260512170623.3174416-9-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D8:EE_|CYYPR10MB7607:EE_ X-MS-Office365-Filtering-Correlation-Id: ad0c540b-9311-4def-3748-08deb048cf5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: Th15bhSouKqzrtm8yqxoO73f7Yg12rEI7tnqXlXSXZrVfZJN2QmAGVobhMNwk311BiE1rW+1L4yRrONB901nRsp4GxC4R58V8FwLoG1fFaJ4tiAEtUm7m8MLhPwpeeKHZMGT+LtyF193HYokyVfwsUYIYtFbknq+fvvZ4nUpDOMU4dtdHx7PpTBme/y7HSS2OL7i581/yOufVyXGUxq2nkvWmq5ojpj15kPaAXq3E6ZUqvLFxiVeLDcYxIUBw4Byls5VFGYxT/VVxAVNyKROIXnE9t//MlzrGRQpFrQLxOnG5HqCEk42w2kKtaikgj1l46RDAXTy0TxoVcw3sp0HodVlJqYtGe8pO/FhGnXBqk91GPN+ghuV6I0sqJc1uIgEMevsXpTXuFwUkYxl5AirnhwfuI4TMbHkaq1pfqkZiJYZa6OOfT2qNclYc3Qu0ZhmN9iXJabj7QR02rZjn8AS6Ta9NK6PUkaCpwnA2xrjyxBNqZq0FP3YVEy+2SFChp8TIkknc1sAAWnklllYeUnxNKv8KuGNFRi3EjSJ7H40KCfdGKDbx24pa9gG8lbhluuFpthMhOYn+7WPaKwTh+PUEP9hIsFIWocOmzV0IL/mIWQ9ZFHP+WMYbFq2ICqHwyyYSb1nuCYdubFR2204OL1yDDLNAkwMlSHPqW0MZ6FJWSHUhiq7DI/CjJagDZEl06I/e11+hS+xwTUvj2/qzTfBeYlkwKFaEf7ASq8CHxHfkOw= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: k9Ilc9zKRx7fnRNwr5RiIkDj63KvUjkaJPtlMRW55mCEDB1OWyiCPMArfKdX7Lzta0gKswo2ek3tfK5ozkH/dRoYRphwSDV/vF3A3TwVUKda5D5N+xzrcIlW7n8t+r+Y3u3Ss+YhLYxuajXulnn/3BICB8vJK2i28FP8ix+ATyLGV4lozFQDGC809Njsov9NM7PSTajbvtZJMDY4X2ANM5M5y/btwGmbpIJ/Oi4UP1KMD+T2hh4rtog/1knGyxDn24oBbh+8vfqpKEl1dRrHT2rkf0FYoiN3ikyejTYHt8boCWB7j5r6V+YpUO8ENS2IHPQVgEkB6+PtAOKZX3mI/H9nbUmmvuEutjaphY6/Xkx5QVvT3lPmmZkvTWIBDqjeljVu5V8gTsqfVy6A5uLLpw3B5GeKvVMZp5VGI6LB2QA0pQ0TkMrpNhbFrmwa8fwO X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:29.5100 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad0c540b-9311-4def-3748-08deb048cf5e X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D8.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR10MB7607 Content-Type: text/plain; charset="utf-8" DMA_PRIO_MASK (GENMASK(3, 0)) is defined alongside the other priority macros but is never referenced in the code. tx_priority and rx_priority are only ever assigned DMA_PRIO_DEFAULT (0) and are never sourced from device tree or user-controlled input, so no out-of-range value is possible. W=3D2 builds report: knav_dma.c:32:9: warning: macro is not used [-Wunused-macros] 32 | #define DMA_PRIO_MASK GENMASK(3, 0) Remove the dead macro. Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - None. V1: https://lore.kernel.org/all/20260508153211.3688277-9-nm@ti.com/ drivers/soc/ti/knav_dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index e5f5e3142fc4..462d181ca564 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -29,7 +29,6 @@ #define DMA_TX_FILT_EINFO BIT(30) #define DMA_TX_PRIO_SHIFT 0 #define DMA_RX_PRIO_SHIFT 16 -#define DMA_PRIO_MASK GENMASK(3, 0) #define DMA_PRIO_DEFAULT 0 #define DMA_RX_TIMEOUT_DEFAULT 17500 /* cycles */ #define DMA_RX_TIMEOUT_MASK GENMASK(16, 0) --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010053.outbound.protection.outlook.com [52.101.85.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FCC4385D64 for ; Tue, 12 May 2026 17:06:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605613; cv=fail; b=sRCKneHDdc1lO/GETKMd3gi5XT4lQ/RcLshmYWysA2YnJTy/NgTQFqJ6cwG4iFRxwGSYJ6zjCy0TmWD57aq6MuyLf2dD8N4GnfNfIOQfqgqNjTr+tdxncsmYnPGXPFhI1e5kf9Rl8ZDnuXid3nukW2z5YfgYVQqB+lmLdhe86jY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605613; c=relaxed/simple; bh=HnviruEkUItcs+2Zk5Rnp1NSIVSgRwH0RZjOUMrr0Mc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WaKjj71IGnAfpI52DJ8YjfCPd3AzZFXfAW1KcLqWYB4cCrZ9uas9sFmQyMBd7zTbeLMp56NqXK44rdyHxRz6MKmpyt6Yf5R5eyB0ShDqoxpqVB5tzP0iD3c5icvShv1ys15/wa0pajHMvztOFNWCKXI3FnwcPxDYV10+lpleLsY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Kihdy9Pj; arc=fail smtp.client-ip=52.101.85.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Kihdy9Pj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cvYVFLuWBt5wS3x3ez7Z239DFfjzfiA+yOSbJqwFShQwUZ4kmHmkk0mtyLG8tH8RMTgi/gOrJpfeZi2LGp/xxq/mmHwm8f1/bgCDgYvA7ZzT8s5DDZsSVMqkA1R6ojka3X/h09V3Sz3DmDREpwpoLJrGjGZ88TmYcwa8G55ETPx9j/Add8n/VS6t78amHS1JvyeaiG47+iBW3XdSofsEm3+C2vObnLQqCAC3NowZ/Dkj5KB0d/49QoapeXJbrEE1BQ2LfQnTw+xc7/yoaFXyqpe/IBdNzhfuj5nuljesmvkoLALq2NcFYYSWgfCvw0BLXFEKOyQ36tXCyhGjwd637A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VRF6UMbD7gHAfz+mfsh04yBmU5UhdpxMGElasyMA54g=; b=jtEUwlj0RjMKkVrr1QVxxwKdcSvNN4GeA5+miBlM0y4DoJlM1kCx3NzjSE0CZKXYuwqN1yaVW85gh+vmRnHJ+960WkhdtHmRxbXueGf0arCYw4Qn07wXVoog5b+HUaet6kl6NUDwUAy/2J4jQyn/WvH8vCSemTa+0Lp8WJf8ccrA9e06fhzBokctU7tRo7oYgSvZZydKMf2YwaCsBBWYP3fIJAqkhv4sIn9VWJ0HBGL/LuLC+4r1gb+Iwqds8Jkpbn/SQ2uNPILtXh072YEYevmLRSHQ7PKiaODmUkMZsr0dn448jvjxpCotq6neA3XbT6pRqTxlij2+tjMM4MxNnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VRF6UMbD7gHAfz+mfsh04yBmU5UhdpxMGElasyMA54g=; b=Kihdy9Pj/TdVJtis0X1c8cP6C+8UQf9107ctjHLDAjDZwzguGF+iM18IK9pCYuXlHTZFRwNQE+eI3J7ciVQnCHqjzAw/nTIoBDncVsshxIWAzorHDkP0tIhzZgVC37Fe5Ovfv8KxyogtOGSiiwqlPLUFBFr+B2phBXVg9s6fkVE= Received: from SJ0PR05CA0151.namprd05.prod.outlook.com (2603:10b6:a03:339::6) by SA1PR10MB7813.namprd10.prod.outlook.com (2603:10b6:806:3a9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Tue, 12 May 2026 17:06:47 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:339:cafe::2b) by SJ0PR05CA0151.outlook.office365.com (2603:10b6:a03:339::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.16 via Frontend Transport; Tue, 12 May 2026 17:06:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Tue, 12 May 2026 17:06:44 +0000 Received: from DFLE212.ent.ti.com (10.64.6.70) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:26 -0500 Received: from DFLE207.ent.ti.com (10.64.6.65) by DFLE212.ent.ti.com (10.64.6.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:25 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:25 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6P092235147; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , Subject: [PATCH V2 09/11] soc: ti: knav_dma: Remove dead check on unsigned args.args[0] Date: Tue, 12 May 2026 12:06:21 -0500 Message-ID: <20260512170623.3174416-10-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|SA1PR10MB7813:EE_ X-MS-Office365-Filtering-Correlation-Id: 9df8f611-87bd-4e89-6b7d-08deb048d89d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700016|1800799024|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: vXS5t0wgYLxIdd3oK2ucTmZ4QqBKhywAmXs5JXpCppGnZBlOP+EU2gUVwSNm05zXcvnoUmYlSi9L7urO9mUKEusJPLZy8YPqnyw5L1HjRNM+RLGbJE7ZQgat/Z6xF+aL/7Lzvlga9H0VF/ewpzKTYwHU/x24O14ylfWIcCvCEvUYeUkORcXqs7kYi0a6fw7Tm/9TR72nI4UVT+1tl2QZTTo4jRCHgOjEqaEryJqrdGBNbUiME/MWD8eKra6aaNKGG6Z81AAp8RIIZkzxuVifGtz9hnm5G4v17fbgDcn+cQJNU4OtgweKfPjTsZlXGRQxnaDbKPUotgVHZDYmjOkTxu0mpany4LZQtT4vgYKOJBh26ZlQ3TxPd9UvG9s6+CGstzIw31clXvDH5NG5mAcyTPzRGO7ldQT0aLkgozYcEx7vvZZWgGDFP6XfV7jbm2yeMhagNn/jQlQ30KazsTfTwh1O14r/7XhlNNTIxLJeqLKP4MaYVU8fttvcpz5vHO21asasVN1345SQ7w7vU4UGFysuQ5hqtlhB9CWWGyHYN+zoB5/Bh+kkGzDkiTf1pdF+8nzm5JFF2YoAE3SMWKCUdIP+j69deSUjKNoZdQ/lmo3BHoIMltXbT7zNtY9NaBZC0NvEHuXaSrT7hE6msw8AHjnaWynGfuqhr73zA4/GlcQI2Xbtog+HBJbqbU3KBXGr8UDRH0ChjOJfpIF6skG5KQuTpcp6R9TD1GUS62wUH0Q= X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700016)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wNekB6HiRjdpeZ3g+3Lb97EuCOEKziC06MZttCLQ5SpMgayWl5wSikv7WwUP2vJkxWFAEJRsdM8oY7eI9ZkUoYyM/f6IpQHfUOyvWcDJpi6BunpVClybvHDd23TXdaPUYfThNsbud+BKQerAjaF9BDfRktPojJRXvaqEBiaLSvbkBAZ/WYOFeWImnRfD96RKiB+O1AVS9jkoGrc52l5MOfRfanuzXOi1owcdbL0JzLBZN38GDNI5LKNJXYVkDvE+eqkiar26yLmbtvTbYar1JkcAxUdqGoQ3eGkaedTYbU+Hb2uvFCZumLYBM1HISPRsEyT3/aQCX1Ya1K1DYb3WJFf27Ldd1x98ODccs8H70fAGZTUrBclh1OkwaOWuoaANIXZv9GkowjwheKLHbWwY6TE4cvj2nOsHcWFxXGU+0QkTWObXwlqVHSO59fnJ6Dt5 X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:44.9977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9df8f611-87bd-4e89-6b7d-08deb048d89d X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7813 Content-Type: text/plain; charset="utf-8" smatch warns: knav_dma.c:390 of_channel_match_helper() warn: unsigned 'args.args[0]' is never less than zero. of_phandle_args.args[] is uint32_t, so the 'args.args[0] < 0' check is always false. of_parse_phandle_with_fixed_args() already handles errors by returning a non-zero code, which is checked immediately above. Remove the dead check. Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - None. V1: https://lore.kernel.org/all/20260508153211.3688277-10-nm@ti.com/ drivers/soc/ti/knav_dma.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 462d181ca564..7ba6fd58e9ce 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -387,11 +387,6 @@ static int of_channel_match_helper(struct device_node = *np, const char *name, return -ENODEV; } =20 - if (args.args[0] < 0) { - dev_err(kdev->dev, "Missing args for %s\n", name); - return -ENODEV; - } - return args.args[0]; } =20 --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011051.outbound.protection.outlook.com [40.93.194.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F6DF3DB981 for ; Tue, 12 May 2026 17:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605602; cv=fail; b=E3AAZRinSeoOpXOrbZa3sLIhwugBIoP6HBBiup/MgB7la7hU6NcY0FFPEU5IPIGDZUsxokItaqVBsKx0mHkUlE7mCuqUS0TdSb5PexAD19jfe7+sSlnUEu6RXk7IinkouYPHXvBiMQQ5AN6HzXVxN80DGjZjO1tj/4AcJ1GxvS4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605602; c=relaxed/simple; bh=8oBT9ru77nfFNJvvE1mnDqfDdxL7FdodWO+1F5lHnWA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A8JZqj6TUN1AA34uUTl4YlF4M3AB9xIlhoWXuxHK93CpBYgOqGMnAqSr+ldR2vf/MhKVIDFsgHpYS6Q+pem2uNISZANUoPoUiebFF6QVFXTxIWQ2tHWtZ4eOxKw3jbM7YVWgGuVGOUVCkhITen+lf5FwFLLFSk1W2xAXgdk2hco= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=mThZOG76; arc=fail smtp.client-ip=40.93.194.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="mThZOG76" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hum4rDECzP+MPQFKkugGU3aaHvDncaUqzjoqJNtOQWx37kNAUg12tt+GXo5wSqYW/sGyObP5pLo0wF6dinS8ttnv6pPQSJcpuWEDs4qjRtV5ILiVLmXDoefC1HTp3OM7wTADihOJmBOYMKxHMvxQ5gX098jQBiLzIVce5jYQ+R93wplMtRKiGNrphloJqCCi/D/iJ4nnVvyeQm1qCtF4ft7B+5gKVZgZD5GEGZigywW6k3FYkA+DlhxTzf+Wkk/yp1QY9uC6RxLR/BT0uV+f5Tl1flKJYMTw4WGjBxp7+Fk/4g0Q2kRmcREy3ggVBwNC8tYAc1Odm1M70kq1y2zDDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U8Cdh62XnSNYe/v034X8EwhHXD47DBfQv0nZEjZFl/0=; b=HX3IWeTwMBfo2yXbtBC/ttmqUMpnaUjxHbSXtSNMouBzS/dXiRCKve5JDOwB12BeL9kVlOIsCwDAqfbwTFAXHGk3Q1aVmIQMi4dIG7MqfRcmxd35ueIc5v4RnkubEOTer7TJ5JEW9BhBsn4rjzc7irP+WZX95OVCUZ4nd/peev/UcnRQBXmu60pLmyepG1A/AQRCEiUwRXdqpAcj2J5jS6KTGMwDYlXWEKAB3WCC21hH+m4y+bjNTvFi2AhH20QxWE2jURxUKpDQQKvD0WBGxy//srE5Zf8i2+fnDmgYk15kQsDZ9DMGC0t1ACVZNDMo+/JOa+FIK/KCjqeFO4V7Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U8Cdh62XnSNYe/v034X8EwhHXD47DBfQv0nZEjZFl/0=; b=mThZOG762vN3L7YdnRx6JWGcTPfEBCN5OhcAw46Wd+by0fktMPbbYYtXLkhXa2wdQTLPS8D3CAg2Vn4oCWUGj8JOGkuLMIfbKPF3t9t3QBVLNhuEkZYfB0LjkrFNtB9dhhwINawRLjnFcIYzHcyRFOfA++vz5Kvh/ewkZvOT1Kk= Received: from DM6PR11CA0011.namprd11.prod.outlook.com (2603:10b6:5:190::24) by DM4PR10MB6816.namprd10.prod.outlook.com (2603:10b6:8:108::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Tue, 12 May 2026 17:06:34 +0000 Received: from DS3PEPF0000C37B.namprd04.prod.outlook.com (2603:10b6:5:190:cafe::f5) by DM6PR11CA0011.outlook.office365.com (2603:10b6:5:190::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9913.12 via Frontend Transport; Tue, 12 May 2026 17:06:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by DS3PEPF0000C37B.mail.protection.outlook.com (10.167.23.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Tue, 12 May 2026 17:06:33 +0000 Received: from DFLE215.ent.ti.com (10.64.6.73) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:26 -0500 Received: from DFLE205.ent.ti.com (10.64.6.63) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:26 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE205.ent.ti.com (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:26 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6P7Q2235150; Tue, 12 May 2026 12:06:25 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , Subject: [PATCH V2 10/11] soc: ti: knav_dma: Use IOMEM_ERR_PTR() in pktdma_get_regs() Date: Tue, 12 May 2026 12:06:22 -0500 Message-ID: <20260512170623.3174416-11-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37B:EE_|DM4PR10MB6816:EE_ X-MS-Office365-Filtering-Correlation-Id: 17f0e7dc-e582-4111-6f24-08deb048d1ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700016|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: eGctHrYGMcFFIW5YQWMBrSj4CTfWwGzvBpKRFR7yuYbZElX9wyrjpnQKwEEshAOApjrmm35kS2bEP+63FXj+vXUuzMo2pDFKDJy/gR9qrVslZCsBV5SmkhkA2zST9gNY9O2THln5PEHA8vFFdnJvU7maMYFvcDlGUF3/30vB2gqaXZCGXlGmR61RV7hBIO4ghX0kM7SfxfU64aWwsGWV8cLl4JtHLVC1wp4m8h01zNnGkr1sMnbJ7tiWRGwdMoyf4hLCOo9AhPgkwfI4QQkJmEoJi55Kl6vnvQUZISv2s8izfjbO2J83Una7m6sv/MfMYeAxfR51I+CINmGho3nzI42e9ri+q3u4c9YrIvcNBl0ZJOuXwkjq4jFo0jf0iTp8J2Mq4sEJ4QAVIeSrXJv8lF7/MUkXFcLDcdhaiAw/uNL09WqlujYyzK5rhv0+TUTGzX0gwUrSvFut9Ph2AWzUYOMeNt16gvKIBwoPhomeM9JHFAeZ2fHQg7P+ceXeOL0Gqn/1SyyhMdW8v6Fsbcj2L+g4DGgAj++ZW98AFtMKPypsS5uN5jfUHM6vvvtlnzkm+9S6E0b61obFIodnLEi8Az7efONK0/kpBxObUERpezLP8AUIM7ki/hY0exc5OBkpGrjVGrKvgsUj6FwRs6Pmz/g3rojJ3XjlppePbwqvODdg2k4lpjxGrIbJXkcYuAmNiJeyxq3j3bBjDGbxVtfLhAL6zWIYtiHPmNM6dvyQOg8= X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JGwAeYhXiP2MQ9pe78ac0Ezleu2GsuyKhVi9dGLfMU+q70+vhCTXPQ1vkvkMeSddlnbw38UOkr5H1nlijVTp8GSk+BBeJEFFt5+pb0i3IcgZrpFugbPAQWWtuz7oBhzhLt7epYW0RzCI3abgmwohM3gM6Gv8JiJDdLUKhj1DcnMZ53Je6bwKU7vU2ZqWGjA3foOkIbJRSHYzpzInOBx08T539gQkg0VVLdiXYMX6QukPfLQZU6Q5oObgCX3SGwBXq0D9v2PiG0nZ5vfnVAIA5GXBqyojJuaTECXWyXchDa7VBYEnDjsxhUnmaixTxfaw1SZRKrZKKXM90FGrS+mB9yjOsGedFi8CjaRWF3IodCA14aS1BFUwxRwVtVzd5nNns3sDFP1G2w17yLN0LQsGj2d/VrKX4oFEgGgNVuOKuvrn3BMu46b/NUI2WWcMrEAV X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:33.4249 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17f0e7dc-e582-4111-6f24-08deb048d1ae X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6816 Content-Type: text/plain; charset="utf-8" pktdma_get_regs() returns a void __iomem * but uses ERR_PTR() on the error path, causing sparse to warn about an address space mismatch. Replace ERR_PTR() with IOMEM_ERR_PTR() to resolve the warning cleanly. Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - None. V1: https://lore.kernel.org/all/20260508153211.3688277-11-nm@ti.com/ drivers/soc/ti/knav_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 7ba6fd58e9ce..96df3982e47b 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -520,7 +520,7 @@ static void __iomem *pktdma_get_regs(struct knav_dma_de= vice *dma, if (ret) { dev_err(dev, "Can't translate of node(%pOFn) address for index(%d)\n", node, index); - return ERR_PTR(ret); + return IOMEM_ERR_PTR(ret); } =20 regs =3D devm_ioremap_resource(kdev->dev, &res); --=20 2.47.0 From nobody Fri Jun 12 20:19:42 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012050.outbound.protection.outlook.com [40.93.195.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A5133DB983 for ; Tue, 12 May 2026 17:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605602; cv=fail; b=KYjDLV7yvA9i2wI2SQQSXvoXl2XyTFfyOSuTqHAoGWtTIHGFNhZPI9wfBc47PCbhDwBx1rZvTuBanMo5HWDboBB3ZZlCctybcM+Oir9bouHysVV91Lskqq2wetX6A2rJnjtfhy79BCwq0Y4iXNwEdhWbUFUBRxuLUt0d5L+d9UY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778605602; c=relaxed/simple; bh=g3ErIfCEMYpexfjsem0V5hgjS29MYu7dYdOjIDAuT+w=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eXEbtmd0sXmmTZnBV/IITWoSY6ybTQfwYwpFoRcsZxkCx9kVQ+yriu3M+Wlwd9qwj66BelvbDy9dOTUQYKfStPoE2EJqsgMFaHrI7Ujz7bPu1Iz4Z7hX1dyS9YR6D0RgBs7NPJhE5inzYjWyXtjmsufp0hh18yTXXFZmfaGB07M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=KVZnO0Ox; arc=fail smtp.client-ip=40.93.195.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KVZnO0Ox" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S0VWhyvsm7xBjXP8SmlNf0sK6simpmbniBWjd1L+XYoB+GaupkquViT6xYfIqGvbVHMz6CNNl4AI7lQBfzJJMowDD8UTx9T4F/cgym2WNYncEod8S5P3lhA7WpEIViW4pkJD1OHVidaggrfBPPOMMRPAVjBXL5bYJcjC4/mlkpixKFx85nPzC4cO35oY2f1xNrVN5e6bk5HvMU4qKrNMctLsqedfZ0DuRzTmQvHp70Q0b6/ctnbhTkurPPXyUJvwL6QheLaL9dd+fEYe51aGD6kH72aDBM9FrLop4am99LbvsnmdEc+p4kFQbgGQ9iy+kckBs+ovAHBMzWHdQmwZmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rPg6qH4/S3jLwlwSseoHr7Ert6I777rtwCJZ38+hbj4=; b=RMAKGD1W7Gb6wIjiLQyd2nyiHhq1CCoL1zPd8WLUrN7z5wqNAr/iVtiSrz4zfkml9C4G5cLiEJhCOkIyHEHp9eOdcdUS18+QA9EVwoTv2QOLFV5K7MlkRaa6sYXppzYZ89BMZDYnT/j+Lgrp8QtdqG9k9VRPv2jSRUje26kG+uxmzcKxfkHbeX0F4/Bx+YV6GCiJW2lN2fdIEhupfygnuo/Yr3hzBl+rruqXWtTAfLLf6T7C0hkvc7cEbV0cgFzTysfskySW1UmzZUFleQfPiy5LTWmgpUaM1K7Ap9jGQb1OGSDLQan4bE5r1jTyE2CGk5JE5ruQBFl4Yv3FZZOnzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPg6qH4/S3jLwlwSseoHr7Ert6I777rtwCJZ38+hbj4=; b=KVZnO0OxxwoGvfgGUH/P+RN//NXKZ/bVvoPFhMXep6CLL6TrKKBuQdISAjKI4XLbL3mxAwVztRLmTH4tusYLvDZL5RqSKuCQB9gT5etRrVPncmHDbFZwF6w/VnbLDVHguduj/biL3VWvPz7ahfu6UG5Fh52KHX+MAahbonZ3h4U= Received: from DM6PR11CA0007.namprd11.prod.outlook.com (2603:10b6:5:190::20) by BLAPR10MB4962.namprd10.prod.outlook.com (2603:10b6:208:327::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9913.11; Tue, 12 May 2026 17:06:36 +0000 Received: from DS3PEPF0000C37B.namprd04.prod.outlook.com (2603:10b6:5:190:cafe::f4) by DM6PR11CA0007.outlook.office365.com (2603:10b6:5:190::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9913.11 via Frontend Transport; Tue, 12 May 2026 17:06:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by DS3PEPF0000C37B.mail.protection.outlook.com (10.167.23.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Tue, 12 May 2026 17:06:35 +0000 Received: from DFLE208.ent.ti.com (10.64.6.66) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:26 -0500 Received: from DFLE208.ent.ti.com (10.64.6.66) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 12 May 2026 12:06:26 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 12 May 2026 12:06:26 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 64CH6QYK2235153; Tue, 12 May 2026 12:06:26 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar CC: , Nishanth Menon , , , Subject: [PATCH V2 11/11] soc: ti: k3-ringacc: Use str_enabled_disabled() helper Date: Tue, 12 May 2026 12:06:23 -0500 Message-ID: <20260512170623.3174416-12-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260512170623.3174416-1-nm@ti.com> References: <20260512170623.3174416-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37B:EE_|BLAPR10MB4962:EE_ X-MS-Office365-Filtering-Correlation-Id: 15ec5c37-281b-4e04-4baa-08deb048d2b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700016|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: A6CfGTaoJZpcRLZoVYqrL0DnlH69t6Ty4PC/hf6aqq4KU0r05JADDHeBnY9Mm2icLYKyPOfhM9xMRSHqYKhnBswT57ghk9jBglR9PSX9fEC0W1tVIhyN/lOhdrobZ9dXK++fCoNvA4SQLqUWpKu4SWaE91IT1dRzN2UZzJrIgZDGSSPOAZrDp/cPPXKplhd/yenOcGJX6q68Gh40TVyHHEHL7S1BuqZrQclrelzuPJa7iUESMgKqNAtri/bZ7c+d7LMOYljatRAdkOiheDBrhhIpn570NscDFzVNE9MYeFuL7bjERmJB0AM2gNqsD+ngexXOtojvtaXkTQQdW7fs87rfssUC4KjvDVxlh6SBsS0hYEtvHqUl8o7C+roLcYbHHC8gyM14EdCqoy0SsKtBAQGPXDTA5d3kQtnCM7lKMYf93XwpN/122gJr0ubEFVQPqT4ltjg7hftObWhVm/FI/gwWBm/Vr0/BhKOedNhqbCDIxsO5WrjZqbK5q5NidC2wyeGRSpyhGwjkyN5l5B0x1T1wjiULBK7SQsAQW/OuTRGjgXKZ7wEFKKgXzQhLdQUQ1EiEChrxVGdXmD1va8EzcwdWw3QS2sgEcvxT9m885/Lrtdm0GEC2Reb6nPWLa7dOrTZoNcpl662Jjqsca09X9IbiRq6gMMhpwxnWOcpPnwuc6CL7QzHhvEi1JcMShJrxUyYJd97OEmOHbtgsWnVOM3DatAaqSJYPu8845sNxWvU= X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700016)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8QFMzHDbl4RV6VWHENS+xrz4VkqRhODDz+1NPPTQVAe1PEO1AaImKzGeCEPgS96hjdJV1IwR5JEjg9iSHy3A2Cm2MfgOxtC6KS6+fBrhPSN8HqLK76m7YnUXgHH7694dc3BcQBtXrgU4o4fT25C/qygmf4lSimSR8Dvfin2QMBItLgupxqVCyeXHScUdeQjqWu9FDxPZgHozdOBpAboaMGtoe4F4k1jrT1KBru8C3OUpmyEsoXfHb3cJAiT5tPC0ldbJL83FAcTcBRaFKpoU5NhB/FnkrZ1wzVN7evF9wXipB0M06HvjRIl8JzvE4xitGBGYv03M0WHrs8gRC2oqOaOlmsITvXQFgdq1lnd6NqMcWivTGJpfdLURz1B+XEnVyF8avw3K2LVlNaT1kiImL56k4QcZ7ZwZE7XpFes7bAxZgfGUJa8Q3WRQZ5C1B6ie X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2026 17:06:35.1075 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15ec5c37-281b-4e04-4baa-08deb048d2b0 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4962 Content-Type: text/plain; charset="utf-8" Coccinelle (scripts/coccinelle/api/string_choices.cocci) flags an opportunity to replace the open-coded ternary expression in the probe dev_info() call: k3-ringacc.c:1439:3-32: opportunity for str_enabled_disabled(ringacc->dma_ring_reset_quirk) Replace the ternary with str_enabled_disabled() and add the required include for . Signed-off-by: Nishanth Menon Reviewed-by: Hari Prasath Gujulan Elango Reviewed-by: Sai Sree Kartheek Adivi --- Changes since V1: - None. V1: https://lore.kernel.org/all/20260508153211.3688277-12-nm@ti.com/ drivers/soc/ti/k3-ringacc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c index 7602b8a909b0..ec4207d98dca 100644 --- a/drivers/soc/ti/k3-ringacc.c +++ b/drivers/soc/ti/k3-ringacc.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -1436,7 +1437,7 @@ static int k3_ringacc_init(struct platform_device *pd= ev, ringacc->rm_gp_range->desc[0].num, ringacc->tisci_dev_id); dev_info(dev, "dma-ring-reset-quirk: %s\n", - ringacc->dma_ring_reset_quirk ? "enabled" : "disabled"); + str_enabled_disabled(ringacc->dma_ring_reset_quirk)); dev_info(dev, "RA Proxy rev. %08x, num_proxies:%u\n", readl(&ringacc->proxy_gcfg->revision), ringacc->num_proxies); =20 --=20 2.47.0