From nobody Fri Jun 12 21:38:21 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 055C1213E89 for ; Tue, 12 May 2026 11:54:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778586860; cv=none; b=aOWH38EPtFLDKEVUJfJAlKxdZYqQ2eqQr2XZnOUmE3vaNSncAZ5Sbz6GqxSaGmllGFIxhRkg6R8XoqEjHzPFujHXiaerTrzbRfkZ/8MCBGV6I9Y+alUnS1zCchMD4qtwAvkzyfHy+c4D0qe7vSdLC+sPkageEg00DW054S8ZXAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778586860; c=relaxed/simple; bh=cPk27FXn4CGdw8FCe68S6Kx8/B7mqwBxITiGjlK7s0I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=s82iCxXWlOggG16lHVu97+Flvk8yd41BrL5TViiT0IYXZ7GKz+HpFPWpuRh+KIy23FdiJYN6DpQORDXP+k2rPSbXc9WRQeR8eN4NPma9cUDMc62mpdJSvb4+jGOr5LSaMn8X/CLCKyidgEVEHzwetybykIyA9HL2S7Qs3PBwZk4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ImSwc/b/; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ImSwc/b/" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-83d5bbef760so1808631b3a.1 for ; Tue, 12 May 2026 04:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778586858; x=1779191658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sCS5kxhR7Cm3oMoDevPVakfoh0CYRbkvsBGfjRAt+qc=; b=ImSwc/b/zhsKO0rxunO1jfFlXkfFd0HmbKkiaJaii/kFEeI86epDm6WC6ok10uzzq8 cIBO84gjn1uPCTi1ijJ/ME/5Aaq3zuK1k4Yx4zAHW1DtD4na9FWTwe7IaeFJDs/iuJGD 7p9OQLNI43WkTBjxiXZdr1kkxrF+Us54C/Sy2MtX0Mlsn4I8mm0qTzBQFQFiT5qobV5J U7FIWCiEatiTGfR+qA4oDiPA8jh3mibc/j911yNcSmTBBssOGhrIT7p/svNURg1cT7H6 LYyA9IkGwVTqWrj0JW4J8wgjEyKwKqDT0e1H9SI4Qu1KZ9HgiDFihygjEfbmjIvrYk1T l9jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778586858; x=1779191658; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sCS5kxhR7Cm3oMoDevPVakfoh0CYRbkvsBGfjRAt+qc=; b=CEKTQw7894TeWk3hVFbo7PG63er4HNJacKbrjlS48H7bWcUeYhMnKxPLG7/F6JbtUe So/StROfpB0lPfjZTb8I/9iP6lFuCS99b/PMoJ4syZ3s06/OvwS3PXhNpj2/b1mAU3tw Sj80MB5sV2+5CDsdiig/+EReS/9FlnSqLJrjCMVB4ZySNfOCzYLYVWWknZkN3Tk1Nt7j ruO31e40l+U1wzZ9vUbX5UoHJ+vZ51Ch73lWltSBDsyltGJM9414cdBZ0bF1fmAtVUsp tlG3OjtcYKz6zfT12+aPa1ehHg0D8qid+ZSHgjkRWtUgjALQi1LcY4Xe7cs+EP5jLP8M yK3w== X-Forwarded-Encrypted: i=1; AFNElJ/4kht29gd+EWDJWHWPhgcxF6j2ISUctIBxTO4YCw5Ppjz1z4WUPHPgIK/TaZCqJEQdM1Fk2sKQ+SFyqFU=@vger.kernel.org X-Gm-Message-State: AOJu0YzgpCO+uDymYzVuVT+7kHZUunPvyphbm0T76kRfzRh/7hnPpyZR +4/U/HlrwJj2L5W3mZLAj/WzLeAKxUYQWyUiWmhUm7TQGD5Gp4VdPBMy X-Gm-Gg: Acq92OFNgwaZMgxQkE2v0IJfnQkLgKjlNxlXZBxEXY6RFDlBX1Cquvd0mh+AXsa3z4d /TUnzMduw96YCax9Rx8w2CIaoPQkM2BXHA7yiI8l/jhLJspL03wbpStJs1qz1KYbA81T/4w11R5 vqRuo4Nl0l9hBvfq75PlBC/VX6JI1D9VIiVp6B24aKt0x+a9RIUSuvQ9XA+s9kHOLq0+1Hq6yw0 5tljyVQfgqtOiqDTlsIT1XcvUYTgFUjvhJoP7f5g6D7vaWvTrqkkKdu69dGH6mOGVuKbtiW9HSX 1tfvpSdMZvX+MQzCBViFee/OV0QrsPHAxAqmpF/qwBR9kLc3qnpNT+R7vn7ylnwcl9pZwjpbdi5 l6Vykeq7QRBL3mPBhC+CaYbZkJQPOLqDG1NGKsFz9fS/HWVMlD++ZCgrVmNAo75jma5UPKLn+cV +jdBnm9U8SjTY+SsLN2xj4+2dxDgZ+MA== X-Received: by 2002:a05:6a00:10c8:b0:82c:66f2:1226 with SMTP id d2e1a72fcca58-83a5dc6024amr27786375b3a.38.1778586858132; Tue, 12 May 2026 04:54:18 -0700 (PDT) Received: from localhost ([103.74.250.37]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83967dbcf16sm27178571b3a.40.2026.05.12.04.54.17 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 May 2026 04:54:17 -0700 (PDT) From: "Jiazi Li (transsion)" To: Petr Pavlu , Sami Tolvanen , Daniel Gomez , Thorsten Blum Cc: "Jiazi Li (transsion)" , linux-kernel@vger.kernel.org Subject: [PATCH] params: Remove redundant perm check in add_sysfs_param Date: Tue, 12 May 2026 19:53:06 +0800 Message-ID: <20260512115309.7512-1-jqqlijiazi@gmail.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are two place where this function is called: 1. module_param_sysfs_setup //there is a check in this func ->add_sysfs_param 2. param_sysfs_builtin //there is a check in this func ->kernel_add_sysfs_param ->add_sysfs_param So remove redundant perm check in add_sysfs_param. Signed-off-by: Jiazi Li (transsion) --- kernel/params.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/params.c b/kernel/params.c index 74d620bc2521..a6b81fda4214 100644 --- a/kernel/params.c +++ b/kernel/params.c @@ -628,9 +628,6 @@ static __init_or_module int add_sysfs_param(struct modu= le_kobject *mk, struct attribute **new_attrs; unsigned int i; =20 - /* We don't bother calling this with invisible parameters. */ - BUG_ON(!kp->perm); - if (!mk->mp) { /* First allocation. */ mk->mp =3D kzalloc_obj(*mk->mp); --=20 2.49.0