From nobody Fri Jun 12 21:40:32 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C43AC357CEF for ; Tue, 12 May 2026 10:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778582044; cv=none; b=abvw2Jjo7DHR5ZHzDOGCHCsaqF6I4nOIbFzosQU4rgpsLMw8r1SowzRdYA6ewjEzLsXRZM6c7whGszq/VWIgru5+18k7MCUp/1zVXXBeyTJsYhjBlNOOVr6b1/jsHt1tM5ToOS6hAVBth7UkOGI6uu5R5ggm1DxQikybBU0K7rc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778582044; c=relaxed/simple; bh=46xjUdMKQocrxJlc5+IRfEvfu9q7FwYQ3DXrDmQIn8I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AsQaH2OEQAbwEEcYQ5x/TbdOkMLoUlIv+9SysGW90NPnQTswlBZiUNN6be4nQL4viDo6OdC90mZuFkrb0DgIXQKYfZ4rhyHpGRRfCV33AqRsyZ7s9C528IwiwbJyRHz5mb6hFoOHCMA8HQ5Jo+Cjg/vgUF76nHhGsixtiha5Adk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Y99L9Yl8; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Y99L9Yl8" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ba928852a5so35205165ad.1 for ; Tue, 12 May 2026 03:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1778582041; x=1779186841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XuGkJpO8zbwPjFwZbzuJaMrl051lxnUzmCTtle9Ojzg=; b=Y99L9Yl81dk6FQjAYshJkFcJ/hLaIve+5OiO7Hbca8YGc+RcD+s4fAbA//aMpLZJLv QycOA8oApxaMRzmID9HNpWlNILxZbe4q/+JVm03MvtLD3P/+/mzJDgbXhGYhn02em4Fr x/ms93+Qb9m+np/kZGNFUW8FSlRtErEZ3S3C0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778582041; x=1779186841; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XuGkJpO8zbwPjFwZbzuJaMrl051lxnUzmCTtle9Ojzg=; b=SN4cRPwgYzx9sQzymNR3xs0lv1zgJ2PjIuFiXClbe2eJnaq2ldW58z1V0dGCpYjjMQ omJWcybL30KVymbtsBKAvIvEzzMJMnLJKU46LEvIvqNgct7zGfFtzFJlMr0lAzHJfODx jUfJtQ6sY86PRiSWgEC5/Ha9QrW/lptkqkMv8/spUFyH+zRpBaCtf4LwgBdpU9TSNLk4 Py3JG6u6szYP8PUvAvAHzDEs47aOEaheaIKX8SIu/vLsUuxf/srSYg+5lrS0y8OO6noV HcSnfBlvY/nBBEuz3ljKqYvPdDLY1elp/6XyLc+WXX0Yht3Ag9oFMn0GM16iKfyJYBoq VOtw== X-Forwarded-Encrypted: i=1; AFNElJ9d9RR80C9A2ljPkxuUerZFk67iHoR3FzVsNllA9fSGHXDyLYWVJU04rgKfhLf6rAhpi4LWtViIUyVZvBE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh813w3YqlgIs4HdtCF4qI8skBwT9YnAz4/6eI60Q0U/Mx1Spv iSLNoPzvIfScGCEv4ZhHfQ2Z53q5W/b1fhWsCLkVPpwgVOjnVQZHMTVQ4s4Nww8Apg== X-Gm-Gg: Acq92OFg+n6tUys2t2RQ/0oGxvxDe2E5h5wBKhVFdomzwNTNZ6ihh+QPefKA9Ro2wGt KE9NIFHT3bdeUpvdM/5fSvtWJwjxsyLqGcoLyd1JgOAVn7ktRrBeJhOnHlobs1EimLOjSelYd5O /DrpnH4+OoHTmcEgJE7nUQ+Tg4U3WHVxTDvqYRC7/YjYxTUz7XxF3vTDtyG/9K0AfJtW6/3gGRT 4JW3kxvy3PwpYdUCQet/b04hFe04Ppsi+/1RG603qz1ngOq75MOkcRNufvu/g25+r6vPjfP96r5 v/2tjgLpCXdsGMUfyIbEmxX+Z55H3UCanhpUysSUCUGDt7GsNcJXe17OUvRB/ltbSV24ggl5QQa BIfFBrQ+4/Y36XfOem3IlfzMay4QzWvweQMMZvkNq1eCI5BMfCO5o/3tVT6DQpb6fhiOEjWeicz ZjuypHjIWfkcPdKeYFjzpnFGkT6Tv+w6pp5v4DiYL9eokUczImsL4ZQVxERtxmVjDResXD7UVnb 1qzzcqbwAz1M6YArP+xtUOMo6gmxA== X-Received: by 2002:a17:902:f650:b0:2bd:1905:e8b7 with SMTP id d9443c01a7336-2bd1905e9ccmr1997075ad.13.1778582041152; Tue, 12 May 2026 03:34:01 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:6606:2bd2:159a:55e3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1eafa62sm141597605ad.74.2026.05.12.03.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 03:34:00 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley Cc: Chen-Yu Tsai , devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH] PCI: mediatek-gen3: fix incorrectly skipped pwrctrl error message Date: Tue, 12 May 2026 18:33:45 +0800 Message-ID: <20260512103347.1751080-1-wenst@chromium.org> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When pwrctrl integration was added, the error message for when pci_pwrctrl_create_devices() fails was incorrectly put after the error goto statement, causing it to be skipped. Move the goto statement after the dev_err_probe() call so that the error message actually gets printed (or saved if probe is deferred). Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/adjNaKB5KGpl6qIp@stanley.mountain/ Fixes: 1a152e21940a ("PCI: mediatek-gen3: Integrate new pwrctrl API") Signed-off-by: Chen-Yu Tsai Reviewed-by: Hans Zhang <18255117159@163.com> --- drivers/pci/controller/pcie-mediatek-gen3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/cont= roller/pcie-mediatek-gen3.c index 6f0ae946d501..ef64778bbf8b 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -1221,8 +1221,8 @@ static int mtk_pcie_probe(struct platform_device *pde= v) =20 err =3D pci_pwrctrl_create_devices(pcie->dev); if (err) { - goto err_tear_down_irq; dev_err_probe(dev, err, "failed to create pwrctrl devices\n"); + goto err_tear_down_irq; } =20 err =3D mtk_pcie_setup(pcie); --=20 2.54.0.563.g4f69b47b94-goog