From nobody Tue May 26 04:52:32 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8885477989 for ; Tue, 12 May 2026 06:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778566425; cv=none; b=culNeSEV70GfB3PQq9FKmHpGLsWabgQ85VD7GspLYvZEsNVkVQoxpepickKxa2uIvihger2Ez8iSiW9JN/Qz+CXGnc7n4MurJo8itABALN7AuBuGZmwTdF7MGa9nUqhKH2Mn4wx/rooKyf1F0ZloUFopnudqcqN2jSZIWYjnel0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778566425; c=relaxed/simple; bh=nhlgkVfDWgn+TRcBARa7NMZ79rHyudShi2Dvyt2IBC8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K+FWMWmaftsd9cz833kb1OyNm9j7SG7oqta1IWItl6zzo+BdFVNClfAuayW58LCNSt+eNuIU14qEosT21M4E/VM6ElkGr0Twu5TQ82kOP4LcmRo6pN8ZsqZXUbmgOnRcbBb1yboIJOT86dziODLOqsh/FYcRBaetvE33anmTsuY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H7e8O3pt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PBxZAsME; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H7e8O3pt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PBxZAsME" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64C5eJ2l2573994 for ; Tue, 12 May 2026 06:13:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wVKsegk5yrtLSMKIfMnOH6O9mKt5aoYLnvSKHe6uEls=; b=H7e8O3ptyCiRYvnz CHWpfvPUSZi4MbtHWTJRZ2OTdMgTLwIuyn4gNLtGGwsdK0wkX1eJ85HKURz8o2Lk K/+q55vCdZB0yTR0T7RXfbQcn3SJChxmTuS7zL1AuUByAc8CvmLEWQCf9AJdu3V8 8I9kxpQ5y646P3xydkOdMi0dG29H0kdaAIi+V7ynfCJjc1soMtQe7hDi9VB7Y5s6 JV7Ag3O6jyo+/yMByzWm8cHbjzOo+82kDNy66aTZ3CJBGSoYfwFmGnU7HCK/VgSX tTG3Y6iLARQFivAkpyGHTO8x7FJh6x6T6E35+efp5c40aTCYW57wudV/4NMjVJ9+ ilFAkQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e3nv29rq1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 12 May 2026 06:13:23 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-365e70c39d0so6635161a91.0 for ; Mon, 11 May 2026 23:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778566402; x=1779171202; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wVKsegk5yrtLSMKIfMnOH6O9mKt5aoYLnvSKHe6uEls=; b=PBxZAsME2TdfefAVv57aNMOOOgQDfXo54v3PtG73h866yERZgxInHrd9XJLSlQc45k VT1pi3oAYOLAznRP01oajlK52Zil5mbXRA2fXEcbQ+WcpY2eNxE/DKljXfLjB4Pka2Vk rDR3X0WJcNW21K0xXAxdVOfOljTZEZIekIvVVnfJ9IqrVqb7vv25iOic1N3IWS4CIrGf AK+VQJLpx6tN+Q0+xrwFcWY8Rc0iQVq3SwYpU84i4G8BNTnd84gUGIPyt9nKFF00BaiY hfdQr+evhBzX4Zjg2ndT3bJjybP542wSbktPmq10wdaU3b2tAqM/paVqi2uYpT9xq9Mn ApKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778566402; x=1779171202; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wVKsegk5yrtLSMKIfMnOH6O9mKt5aoYLnvSKHe6uEls=; b=ICX0jo6boIJnzcVh+jiUK0OGKm8ehZ4H9o/LF4y81l6x2gWteRlMem73a9aSAyAlHp K9AJgDnnKiR8LQfMNxwFuhJlgZc6zW3V68OVOYbikWTJbHVu5ET0nKSS7yKfujacfttc j4pn9JjGhnzlRbtL7XcdE7uHuXTLHWt9M09wVlQR8lN8xjUg3DmHgK0Wt4jpzqzp2lLY pD+qeGH8PexoNXM0L6qPcqmCPz1/e4F1YfBftZizbjFIQ4fHnvZee0auvfFXCzofXZWX vrS+femZ1BXYHwdtbS7oNuqtdFZJ7O2j5YGcId1j6jWuHoX8ov8yCx+8wnmA5tskmt82 PJDA== X-Gm-Message-State: AOJu0YzgprSdKHbEsd6KfVGTJH4amoJ+uTc4KrbjThGjhYfh3+we35ob 49YaPV5IG7AUs4Hjb8QVBpV5ZaPDiC2FPBLMqivZL2Luwqjwn2CVAXva7MrjzaX9SIUgMzYuxJ6 Iz+0723cVjjkumjnQ9ic+GuGDx1tnz8ufXGSaQq+/KUS1OMWJCFPD9D58v4BdYOavHp0= X-Gm-Gg: Acq92OHJxxeYPgfjKsi8M53eIa1taZkoxNHC/C1i0T9V+seJvCnpOlHOH+s7C4C0iaq KyTDIb0aeqNGl1PydC7E6RFdhLX50CBCuKAW7/7kJLl8AT5rg+DJh2Xack0XpFSPf5HHkkFx5se 6EQsmpjEn7eI4YiPTafAToVGyOw0mjqYt7/aMiD7IwIW4BLeEbI39YnH4GtntCBcAN09nG4gr4X XUja2MxPZr0TX26YBv/Nx9LYgBh31mhV5kh5pQ4E4RDiVjy6zv38h/HjbWV9VvxB7szMCs/loh2 aYlc7Om8zGD8REWsG6KQHyTTLNaT+u32ech8Cn8vWn3KuxNYP08rZl1ODzmxWwhg4dInNd3tD1K JBKxcNXylqp4TIXy26DgYdq30Ks6VmdP7eKYGlwjHS6km1WcNuenvldM= X-Received: by 2002:a17:90a:38c5:b0:367:c442:3f24 with SMTP id 98e67ed59e1d1-367c442412fmr8907709a91.19.1778566402262; Mon, 11 May 2026 23:13:22 -0700 (PDT) X-Received: by 2002:a17:90a:38c5:b0:367:c442:3f24 with SMTP id 98e67ed59e1d1-367c442412fmr8907668a91.19.1778566401523; Mon, 11 May 2026 23:13:21 -0700 (PDT) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-368b00d2131sm842518a91.1.2026.05.11.23.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 23:13:21 -0700 (PDT) From: Praveen Talari Date: Tue, 12 May 2026 11:42:52 +0530 Subject: [PATCH v2 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260512-add-tracepoints-for-qcom-geni-spi-v2-1-3b184068ecf9@oss.qualcomm.com> References: <20260512-add-tracepoints-for-qcom-geni-spi-v2-0-3b184068ecf9@oss.qualcomm.com> In-Reply-To: <20260512-add-tracepoints-for-qcom-geni-spi-v2-0-3b184068ecf9@oss.qualcomm.com> To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, Praveen Talari X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778566392; l=4051; i=praveen.talari@oss.qualcomm.com; s=20251114; h=from:subject:message-id; bh=nhlgkVfDWgn+TRcBARa7NMZ79rHyudShi2Dvyt2IBC8=; b=I3gkvz/NlpoT0yJ+STIDXSejHUNnROwikLsZy6Lbj+6h+xssUg9KupkfdlUmyGUc9Dq0HFrAT pyVvYnkdu7CA83BdwtT78TLjGAEYppDcULnJASYHAZm5txpikDA0dVL X-Developer-Key: i=praveen.talari@oss.qualcomm.com; a=ed25519; pk=NGK/88fjyHXgfhIKwag7+uIytOmyOypvZ/hDFaYPEss= X-Authority-Analysis: v=2.4 cv=IsAutr/g c=1 sm=1 tr=0 ts=6a02c503 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=uI40SpaImk96dJ2R2O8A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: f0M_NlbBCCfKaKkdk8npdTpanICc3fuo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEyMDA1OCBTYWx0ZWRfX4Rvc7k8SXCBE UWbZONoXPFKOEo6PGVldwtITkZGUCZR56rfUBlT9TwbxnWzxtjfui8gyffrZRgFAjih1XRjpWYB H1LMIISpxXzLLKUqru+SqGLGsoI2MoAFmTxUOVllQbYLNZ692+uwrsHjQwxIT+siEVFbpWjgTs9 7AdS4TTG19Qys0Dz0PXJXzzsfGCcrsGJY+GfI3JCxsVn7pp+Rl/ZJ9Dde20oVSSuerB/qns+Hze mPo3w2y7FoOGB3elst21HaLrR2UEnFsqOv7qMYA1uWXrApGBI9cptLzGWs1YFBmcde7eBMjhjzf +1N6+F6poGcmHwXPJT/rS8oj1gH7ZbrGFTjzjtHERnvPqpfmIvjBwV8vNkK7w4uBbgHljT8vlEF vjfk6spf+AM1pplZxBoy49xcbZfzt1sBc+x8+LVaBItQgsTPFrRwsaAiCpcsbKP0NurKXBPW1VO 9FWKQuiHi3peTmOZnkg== X-Proofpoint-ORIG-GUID: f0M_NlbBCCfKaKkdk8npdTpanICc3fuo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_05,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605120058 Add tracepoint support to the Qualcomm GENI SPI driver to provide runtime visibility into driver behavior without requiring invasive debug patches. The trace events cover clock and FIFO parameter configuration, transfer metadata, interrupt status to be making it easier to diagnose communication issues in the field.. Signed-off-by: Praveen Talari Reviewed-by: Konrad Dybcio --- v1->v2: - Removed TX/RX data tracepoints. - Updated commit text. --- include/trace/events/qcom_geni_spi.h | 103 +++++++++++++++++++++++++++++++= ++++ 1 file changed, 103 insertions(+) diff --git a/include/trace/events/qcom_geni_spi.h b/include/trace/events/qc= om_geni_spi.h new file mode 100644 index 000000000000..5f39dab47e4e --- /dev/null +++ b/include/trace/events/qcom_geni_spi.h @@ -0,0 +1,103 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM qcom_geni_spi + +#if !defined(_TRACE_QCOM_GENI_SPI_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_QCOM_GENI_SPI_H + +#include + +TRACE_EVENT(geni_spi_fifo_params, + TP_PROTO(struct device *dev, u8 cs, u32 mode, + u32 mode_changed, bool cs_changed), + TP_ARGS(dev, cs, mode, mode_changed, cs_changed), + + TP_STRUCT__entry(__string(name, dev_name(dev)) + __field(u8, cs) + __field(u32, mode) + __field(u32, mode_changed) + __field(bool, cs_changed) + ), + + TP_fast_assign(__assign_str(name); + __entry->cs =3D cs; + __entry->mode =3D mode; + __entry->mode_changed =3D mode_changed; + __entry->cs_changed =3D cs_changed; + ), + + TP_printk("%s: cs=3D%u mode=3D0x%08x mode_changed=3D0x%08x cs_changed= =3D%d", + __get_str(name), __entry->cs, __entry->mode, + __entry->mode_changed, __entry->cs_changed) +); + +TRACE_EVENT(geni_spi_clk_cfg, + TP_PROTO(struct device *dev, unsigned long req_hz, + unsigned long sclk_hz, unsigned int clk_idx, + unsigned int clk_div, unsigned int bpw), + TP_ARGS(dev, req_hz, sclk_hz, clk_idx, clk_div, bpw), + + TP_STRUCT__entry(__string(name, dev_name(dev)) + __field(unsigned long, req_hz) + __field(unsigned long, sclk_hz) + __field(unsigned int, clk_idx) + __field(unsigned int, clk_div) + __field(unsigned int, bpw) + ), + + TP_fast_assign(__assign_str(name); + __entry->req_hz =3D req_hz; + __entry->sclk_hz =3D sclk_hz; + __entry->clk_idx =3D clk_idx; + __entry->clk_div =3D clk_div; + __entry->bpw =3D bpw; + ), + + TP_printk("%s: req_hz=3D%lu sclk_hz=3D%lu clk_idx=3D%u clk_div=3D%u b= pw=3D%u", + __get_str(name), __entry->req_hz, __entry->sclk_hz, + __entry->clk_idx, __entry->clk_div, __entry->bpw) +); + +TRACE_EVENT(geni_spi_transfer, + TP_PROTO(struct device *dev, unsigned int len, u32 m_cmd), + TP_ARGS(dev, len, m_cmd), + + TP_STRUCT__entry(__string(name, dev_name(dev)) + __field(unsigned int, len) + __field(u32, m_cmd) + ), + + TP_fast_assign(__assign_str(name); + __entry->len =3D len; + __entry->m_cmd =3D m_cmd; + ), + + TP_printk("%s: len=3D%u m_cmd=3D0x%08x", + __get_str(name), __entry->len, __entry->m_cmd) +); + +TRACE_EVENT(geni_spi_irq, + TP_PROTO(struct device *dev, u32 m_irq, u32 dma_tx, u32 dma_rx), + TP_ARGS(dev, m_irq, dma_tx, dma_rx), + + TP_STRUCT__entry(__string(name, dev_name(dev)) + __field(u32, m_irq) + __field(u32, dma_tx) + __field(u32, dma_rx) + ), + + TP_fast_assign(__assign_str(name); + __entry->m_irq =3D m_irq; + __entry->dma_tx =3D dma_tx; + __entry->dma_rx =3D dma_rx; + ), + + TP_printk("%s: m_irq=3D0x%08x dma_tx=3D0x%08x dma_rx=3D0x%08x", + __get_str(name), __entry->m_irq, __entry->dma_tx, + __entry->dma_rx) +); + +#endif /* _TRACE_QCOM_GENI_SPI_H */ + +/* This part must be outside protection */ +#include --=20 2.34.1 From nobody Tue May 26 04:52:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C3F246AEF4 for ; Tue, 12 May 2026 06:13:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778566429; cv=none; b=fkaj3NGpeBnUvoMN0xiklP4/EsGM3eCAE2Ri/ilzwtVWPi9biIThx4R0ldmelsUXa5ZyiR9iWzRYnhU0u7UYRt79GJUFgkjor4O16kMGEuCeASSxRCGesQEpRi+TWKTbe3kcQA9E55qeIezGot03N97OYF4tzUHe/g8gvr3vYrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778566429; c=relaxed/simple; bh=TyvIvNFT+CvopkY3GIXo2HJiH8nquYeN4rxT+/Zw/aE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V99oA3e8e7sn5AjuT++ucmmd/w3W4nZg2+1h+qJMFe2hsgBMfAdetp8ZvivINuYOhgqGcVR/4zUhIb+6eEZtvgPyG4dB3Akfz02LvKUP96zBZuS3NW4TAP7/z+OwtIIjAJUBjnntI8Nc1g8BSiBcMFjTebEyD5z8AsSMDlRVYxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KjVt9612; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W3fwOnIp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KjVt9612"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W3fwOnIp" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64C54Nwp2994872 for ; Tue, 12 May 2026 06:13:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IpoQWTuq0pCUojlwtQJQ/ytOD4k0BhTtMwmEYgzCGto=; b=KjVt9612g66u07ty klEjeh04BO2/hkslJXOokYx9rPtT/Ax1L8xAYwedBTONUpdjhuVJi+k21+D/PBhd 0wMPWRlEJBK2l7BeST7juGBVhrLCabGJVR02Ev8zoiCc+0KHEKdhMT2FYOQbpNja pYH0mtXgb9QgTDG5BOKMAjcuL37LKDkiAOntw6XV7ct0wQE6QvKq16oz/NjzUA4k A35bPyAkOnLb/Fhb0RY/uaC/0LvOTVTju8tGjMPfSBgfFaTYIqJrzjE6wvKwoKEj AOwHVE/ncFrQ9lY5Frd9bw/DZ874fnNJ76/LfNnkw9Ipk6F61eRCLmpS9xyzH1gU fQKeFA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e3nv0sry3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 12 May 2026 06:13:27 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-368ac44b26dso731281a91.2 for ; Mon, 11 May 2026 23:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778566407; x=1779171207; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IpoQWTuq0pCUojlwtQJQ/ytOD4k0BhTtMwmEYgzCGto=; b=W3fwOnIpyhj2TbxeezS88ZBSSUkcAVY5SucDc3w1/f9kLiSztIoZCQ8yoAUme9JAX5 0NZNk0jHEqvw/A9xlm54Eq97xAE7oBQPk73z6Tz5cBV2i86dEaYb5B/dl2QGAvvnd+c0 kFQt1/t6A+MJGIpawkT+SVM9hiYoVnLqx1DuCCSRJHEju44UBGBc7lLg3j2eckqLBq01 yKfOwVQRQToekAYHCmVIP2PH6CdGKeD+DWw1YQj74mnAO0F/PRprBZ31CtiHGD5bqTov KTPoJ5xUzWN0AhoiEZ3BorIVeLlPAasZ8szYMIBEiBAEoGyAX7bjM0Xf7wOdR75GPDMr KURw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778566407; x=1779171207; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IpoQWTuq0pCUojlwtQJQ/ytOD4k0BhTtMwmEYgzCGto=; b=GKiiHD8KmcrYMJByW+ELlh3uBV1gKy/GdmiFi3i0gaWSs81u+mMwrZMCMTZj3ph/tM DL3H9wzSxE18fxow00Nd3CscQh82RNW8hTEau0WUUmEBuNlA76H2mXTuc7YwjTzwInFk /FWwmTEXOdAqBZ9vwoRHtzXCWJXpOHtYpKjG2rdNq5tLH5nj5viHh4jRCIRSfOtbjH/5 +U3HbkHSpF7UgpSbirGK0y3pf6YGqSdo51RUOgCuwHW4qQ76GmR2m4klGD/Fz9xkGZmO XHvqzvMMhel64xIv5O6HxuQ9z6so+2xFVFx+lXc0E2rtlr2+SN0JWTKG3drPv0xpQCeW MNxg== X-Gm-Message-State: AOJu0YzYvqFGntjIeKdm4H9QxXKcPt+18l8vG8cpVXwRLQerNIkPqkLG oX+MImm/198gG6gfRo8zhxICOZynzThaWup/gxWMJ6dzhE+8ZeyEzqkRsuVDBqKNmDRy8kg3lbQ 09aTC0/j8SuN+m+7pof3Kpy5hCxi1G6e+CCUaah5vRFyr01SYML76pN3LTrZQPc8nNBM= X-Gm-Gg: Acq92OHNaRCIkKULj9B2kogpcYnruunE6nyQfiJg1JEFKgMACGPXSgA+zvxqlhgj9hO ORRFACVyY5hYFp9N6VvffS6hgi05g4clqRAxbkrVhJ2xDYCeRbtLbD9LbVhm8IzmKoEM0aZrA8q MOWaSFn2UVxzoUw5DEaNSxtTLvC3ofYmXNIBzGyqFiBzRZPPnoSnm2fwjVV74NhI+Xe4i36s0/H olnvJPNCc2gTmpQRQ9Xj/U2L7gYiaS02P64LH+LONiOvgx6ArEhNPPaAUBT7o3hQJMrznBiNVlG s/0x6beWzvr3wrDF5YapgnEESvyfb0m7jl+VW8QzZU1dXzYGBRNGd/1GrSWuoOLT+mnoXc8/lt0 rd38b40gpp/mHOwTQbc/tetL+lWikHJurl7ZhxbatsPSrilZUsqTRgWg= X-Received: by 2002:a17:90b:1cc4:b0:368:b4a5:c4dd with SMTP id 98e67ed59e1d1-368b4a5c615mr1966395a91.2.1778566406667; Mon, 11 May 2026 23:13:26 -0700 (PDT) X-Received: by 2002:a17:90b:1cc4:b0:368:b4a5:c4dd with SMTP id 98e67ed59e1d1-368b4a5c615mr1966342a91.2.1778566406104; Mon, 11 May 2026 23:13:26 -0700 (PDT) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-368b00d2131sm842518a91.1.2026.05.11.23.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 23:13:25 -0700 (PDT) From: Praveen Talari Date: Tue, 12 May 2026 11:42:53 +0530 Subject: [PATCH v2 2/2] spi: qcom-geni: Add trace events for Qualcomm GENI SPI driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260512-add-tracepoints-for-qcom-geni-spi-v2-2-3b184068ecf9@oss.qualcomm.com> References: <20260512-add-tracepoints-for-qcom-geni-spi-v2-0-3b184068ecf9@oss.qualcomm.com> In-Reply-To: <20260512-add-tracepoints-for-qcom-geni-spi-v2-0-3b184068ecf9@oss.qualcomm.com> To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, Praveen Talari X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778566392; l=3916; i=praveen.talari@oss.qualcomm.com; s=20251114; h=from:subject:message-id; bh=TyvIvNFT+CvopkY3GIXo2HJiH8nquYeN4rxT+/Zw/aE=; b=iV92GtYb71Z6+FDs2w5XX5o/tN0LMR/wMDMF7MRIpaGSUeKEeiSc+rZj6FLZUmpktYCaobjDu bTpvDoheAcxAk/KHaMsFpghjdxKap4H+4CvwDlojaCzNE1QzOFrZHq4 X-Developer-Key: i=praveen.talari@oss.qualcomm.com; a=ed25519; pk=NGK/88fjyHXgfhIKwag7+uIytOmyOypvZ/hDFaYPEss= X-Authority-Analysis: v=2.4 cv=PN0/P/qC c=1 sm=1 tr=0 ts=6a02c507 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=NVsub6H0E-3clS5m2s8A:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: BDDvnZ1GT5DAXTmjTOLzgyVvMX6S7ye- X-Proofpoint-ORIG-GUID: BDDvnZ1GT5DAXTmjTOLzgyVvMX6S7ye- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEyMDA1OCBTYWx0ZWRfX0tJMRCSWWm4S CsbO5j0Br6y0SUg+6sankOhGmE7pmNFOZFBGm7QQv2Id2egdEc8qetxGvZfFXD6p8AuLpfxbInL iqZC4lRONi+nT6fCvYow68yyLhSWGWd+KjJgsw20mZENw7x0pJ/D0/hnZZ6yDqrzFCh33vjKbn4 Q1um/AktIEfxiSyvrVt7k7LJmw6DC5XZUE+gR36gtRT6QXH1FKmONPG2yLV4+ciwsRsCHUIXPal 1J4+dVoAh6ozljzDB78uZG6wZ2WBLuTlBkwnDgCf/Y/3HGk0AtlkQ/BS6cMavbXNiL8Fr8CnhDz RL3xHAainX0WAxYbFI8iFBhIl0yJpUojqR91vNT8sLXituG0ktBL0mG9BqpFX7t3e2P+KaDOpNl Pnq0gqEeJFuLsx5HXqroBu+zFXtL5g2F/Oc92Kw3OkSirO0xexgczX48hs/ZJwl6LYL+uCU1P1n LNh2emIshbyfj/Y7rNA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_05,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 clxscore=1015 spamscore=0 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605120058 Add tracepoints to the Qualcomm GENI (Generic Interface) SPI driver. These trace events enable runtime debugging and performance analysis of SPI operations. The trace events capture SPI clock configuration, FIFO parameters, transfer details, interrupt status. Usage examples: Enable all SPI traces: echo 1 > /sys/kernel/tracing/events/spi/enable echo 1 > /sys/kernel/debug/tracing/events/qcom_geni_spi/enable cat /sys/kernel/debug/tracing/trace_pipe Example trace output: 1003.956560: spi_message_submit: spi16.0 000000001b20b93c 1003.956642: spi_controller_busy: spi16 1003.956643: spi_message_start: spi16.0 000000001b20b93c 1003.956646: geni_spi_fifo_params: 888000.spi: cs=3D0 mode=3D0x00000020 mode_changed=3D0x00000007 cs_changed=3D0 1003.956647: spi_set_cs: spi16.0 activate 1003.956648: spi_transfer_start: spi16.0 00000000ea1cf8b6 len=3D16 tx=3D[4c-80-e4-ca-68-4d-95-aa-ee-99-ae-d7-69-e9-5f-39] rx=3D[00-00-00-00-00-00-00-00-00-00-00-00-00-00-00-00] 1003.956653: geni_spi_clk_cfg: 888000.spi: req_hz=3D20000000 sclk_hz=3D100000000 clk_idx=3D5 clk_div=3D5 bpw=3D8 1003.956691: geni_spi_transfer: 888000.spi: len=3D16 m_cmd=3D0x00000003 1003.956708: geni_spi_irq: 888000.spi: m_irq=3D0x08000081 dma_tx=3D0x00000000 dma_rx=3D0x00000000 1003.956717: spi_transfer_stop: spi16.0 00000000ea1cf8b6 len=3D16 tx=3D[4c-80-e4-ca-68-4d-95-aa-ee-99-ae-d7-69-e9-5f-39] rx=3D[4c-80-e4-ca-68-4d-95-aa-ee-99-ae-d7-69-e9-5f-39] 1003.956717: spi_set_cs: spi16.0 deactivate 1003.956718: spi_message_done: spi16.0 000000001b20b93c len=3D16/16 Signed-off-by: Praveen Talari Reviewed-by: Konrad Dybcio --- v1->v2: - Removed tx/rx data capture since spi core had already support. - Updated commit text. --- drivers/spi/spi-geni-qcom.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index d5fb0edc8e0c..164c6c0b9544 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -1,6 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2017-2018, The Linux foundation. All rights reserved. =20 +#define CREATE_TRACE_POINTS +#include + #include #include #include @@ -332,6 +335,9 @@ static int geni_spi_set_clock_and_bw(struct spi_geni_ma= ster *mas, writel(clk_sel, se->base + SE_GENI_CLK_SEL); writel(m_clk_cfg, se->base + GENI_SER_M_CLK_CFG); =20 + trace_geni_spi_clk_cfg(mas->dev, clk_hz, mas->cur_sclk_hz, idx, div, + mas->cur_bits_per_word); + /* Set BW quota for CPU as driver supports FIFO mode only. */ se->icc_paths[CPU_TO_GENI].avg_bw =3D Bps_to_icc(mas->cur_speed_hz); ret =3D geni_icc_set_bw(se); @@ -366,6 +372,9 @@ static int setup_fifo_params(struct spi_device *spi_slv, if ((mode_changed & SPI_CS_HIGH) || (cs_changed && (spi_slv->mode & SPI_C= S_HIGH))) writel((spi_slv->mode & SPI_CS_HIGH) ? BIT(chipselect) : 0, se->base + S= E_SPI_DEMUX_OUTPUT_INV); =20 + trace_geni_spi_fifo_params(mas->dev, chipselect, spi_slv->mode, + mode_changed, cs_changed); + return 0; } =20 @@ -861,6 +870,8 @@ static int setup_se_xfer(struct spi_transfer *xfer, spin_lock_irq(&mas->lock); geni_se_setup_m_cmd(se, m_cmd, m_params); =20 + trace_geni_spi_transfer(mas->dev, len, m_cmd); + if (mas->cur_xfer_mode =3D=3D GENI_SE_DMA) { if (m_cmd & SPI_RX_ONLY) geni_se_rx_init_dma(se, sg_dma_address(xfer->rx_sg.sgl), @@ -915,6 +926,8 @@ static irqreturn_t geni_spi_isr(int irq, void *data) if (!m_irq && !dma_tx_status && !dma_rx_status) return IRQ_NONE; =20 + trace_geni_spi_irq(mas->dev, m_irq, dma_tx_status, dma_rx_status); + if (m_irq & (M_CMD_OVERRUN_EN | M_ILLEGAL_CMD_EN | M_CMD_FAILURE_EN | M_RX_FIFO_RD_ERR_EN | M_RX_FIFO_WR_ERR_EN | M_TX_FIFO_RD_ERR_EN | M_TX_FIFO_WR_ERR_EN)) --=20 2.34.1