From nobody Sat Jun 13 01:48:49 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013049.outbound.protection.outlook.com [40.93.196.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF2F547B429; Mon, 11 May 2026 16:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517189; cv=fail; b=lvpAqzjGcSSWXy1eGc1Vu5PlbK6N1YPn3HKre5tuJ7Fv4b6KBm/ZmQn5/jIpgLDFLmtJ8y64MRnOcJ2GaSOjWHD/aU5AjODwXVCXSZFs4OMKedNRgSKoDyK+hOv/YUZ18ZazSD4rFPGbtwBWGllFck+3L4iiFJTvNZWaS3XWVMQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517189; c=relaxed/simple; bh=EqwMtV4cwH/I5F9YPgMoG9pTP5/zsFcC5Z6kwpRT5wE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cYclu/M1vgfvMd3KH6ah0X7DV9kxO3bhIKB7T+MD3cdHaPuikKeCiG4gf0wqzAES1pnuTZl5oUiZbZNbckVDQCFunKYqgPnfldGHBYsmNeAkEUzCVmFLCZtEGO94qRcK5uaBbAyHEbjj8GOPhg+WAlgi4HlnDZfjX9kGqdcHu8c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=O+QRZRqx; arc=fail smtp.client-ip=40.93.196.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="O+QRZRqx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EcqNiG+CMMHU3rfXwH2iG1wF7FFzwJeet4gRlCaN8xgKp01HypAoiWCO7KuahpsvlJtAbKvE1x+eli8THa6ICC+rjcvjptXk+FWNfDOjtHLS1h36FvA13J1dnZ9ycGjFGqysM0JDYQhd7qArzsMxoPwPcC5R0G3eSlL/xIhVesWo6+L23YVzUeW7jr1ULmfZ0nxqWrYg5ctBYxJMPBtho58d9Kb5wc2yM5BMEIiRM6DPe4A5jfaL11V8E5ypJZkYVuYpCBX7Jk5WM44uH5mijNO69Wt0FV+9YUB2ae4/xYpKojTzNAamXbGeTcUPmJl9EkbQDaodX3qnDJWDLaLk1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vau+agOGPE/0eA03S+pf3NTi4uwetT8K5GjSz2ATBzU=; b=UU5c2FY/Ejn2JU+yhnh7EnKN2VNu+Zuki2lW1UAmjicg+iIWv7ZBG1irH48Ik9upvJ7mABSq1I8Bd759PTtRnJkjlNfLp+T/y99ZryiFm06mZqBUJ88wX+J+PXCK6ETuja0+PJRMyD2yKhwuXA/OBMRWqhmB3RfQ3g5we4pYUeaPhUvmnjujqaZsOFFlq2Ii222dsaahsEboLJ+xVgLuUWiwq2HvPBKIo7Sa1fOAp1ZYFaZNXR1mY2bpiK9dzHIYPqkb69q0quRTbh3KnomLUkaahJhkfre7fUVHEnK4N/ZU3Pc9EuFb6deV9mS+MYA67/oJrhn6OJBy3emCoJnyag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ideasonboard.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vau+agOGPE/0eA03S+pf3NTi4uwetT8K5GjSz2ATBzU=; b=O+QRZRqxTeQHjsC8Bs0kd2O4VYqF3i/5eoAAD8upSNgA7wZdqimN02Wbz0N+tCTWOUVSaP+MKcIDEuivlBF2eOKMLxfRwz07dDkAMZ9SxWIVvPg4xY1xZDKEiPaFtG2MFL0GJ23rwqHMPJKP7/wO1JgpPmH56BKIuFZWIS9vdpM= Received: from BL1PR13CA0005.namprd13.prod.outlook.com (2603:10b6:208:256::10) by CH3PR12MB8236.namprd12.prod.outlook.com (2603:10b6:610:121::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Mon, 11 May 2026 16:33:03 +0000 Received: from BL6PEPF0002256F.namprd02.prod.outlook.com (2603:10b6:208:256:cafe::ac) by BL1PR13CA0005.outlook.office365.com (2603:10b6:208:256::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.15 via Frontend Transport; Mon, 11 May 2026 16:33:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL6PEPF0002256F.mail.protection.outlook.com (10.167.249.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Mon, 11 May 2026 16:33:03 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 11 May 2026 11:32:37 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 11 May 2026 09:32:08 -0700 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 11 May 2026 11:32:05 -0500 From: Radhey Shyam Pandey To: , , , CC: , , , , Nava kishore Manne , , Radhey Shyam Pandey Subject: [PATCH 1/3] phy: zynqmp: fix L0_TM_DISABLE_SCRAMBLE_ENCODER mask Date: Mon, 11 May 2026 22:01:33 +0530 Message-ID: <20260511163135.2924642-2-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.44.4 In-Reply-To: <20260511163135.2924642-1-radhey.shyam.pandey@amd.com> References: <20260511163135.2924642-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256F:EE_|CH3PR12MB8236:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bbbc1c6-15b3-405a-706f-08deaf7af8f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700016|1800799024|10086099003|11063799003|3023799003|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: XPw2zVkwUVMKtgBfckbzflHLKynmKjMKa8VzuSR1lJgSmatERSBITI1MCKpY+f7BqwhYkIkVnJRPJCPFk097WiQ/B7UsNyEdOt7oROF/mqOuG/pKBUcMRC2kS6WgS0VSvEGQ3nKgIRORQ4c5ZtJF/ow1SeA06dnVK1yfnHCEoXhybOYStHC2SNpD6PKuq/VI4IUfnlrGHAB1FRQlgC7vx7Fe8khaMqb0n5kZnKZV6My2brTeXpaLH6b/R08TUfQrWsh92MzyaLxP15ALTJPRUKuLQUMCxQzZlfBEeUt81gjcoQFgwANJg7e6cd0N6yHGxFAGEYGHBs4nR0plWkoua5c8nCT5uEzl5uyAQn7s2qsHqjyrXXB/HtjL7aEE+8Vw0W1x5uF2DWV2uoqfuGCprugYZ5VXcwE0BsJEsSbILaSN11693y0jwX2nRP0JFheLS1I9hfaUBXaVyPQpsRWOYqQmNtp6bjyez+o/ZuSECYPoqQBQ9F5lFm5khkfuhheV9dPVEW/JmERaXIjClVI9dyt64mgHAG+nh+TtmmvWgFx7nx+hIVNfAiPSZC/0+Nm+dRRe/e9PIYNR5fUpxkupcIro7TtkMype6emJ+WYJ2T7NZjRCLMFCFRUeDnVEKKbyNWfY/67BuI1cXkyP3bZ5Br9pdbH1/sRl5XqUaIWYEJ5/AQ/KPFTjbHxv130ykZPeu+1MY68txjaO9A/Q/T6oJeCnenpHYqodHkMtzib7rcc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700016)(1800799024)(10086099003)(11063799003)(3023799003)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uEr1rmZkZ52ImDjSzuhD+HAQKuE/Iu1TNEHX5mEwXV+JY+ibHT0gkWer41dx9MuDBFgszNJH3icLT5kcqgloL5vlhskRRvUns/Fyp0pnHsXfVcg9HPV5EZOqUEgczFF7KbfbETrPUSjlL9Ebsy45572I0/piWLk+NuJaxXQAaPxXPrpfIqOE0QqnpWOdB1cHifR3n1jkq6Fjg2JLImBN93H/WOkPtcy6b2fpl3OyDN4fkJKbx6m+b/19K4bj/1vMN2V7g+uJos/S5G3APU0F8whWBznCmVu48894KAtJx0J6SYuOM2ZbaVK0DhZ/OjxVrme6gifjckqJf/MvUyPHIKFuj9DfRPRM5kWhzej1ELhc5BGRAFfKnG01oBMlXHbD+XRJZeyB5LuuhT0sr70u90u2ciYYewvyp671JoArlkQ21abob4shOK9Cwwz6f9O5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2026 16:33:03.0185 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bbbc1c6-15b3-405a-706f-08deaf7af8f1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8236 Content-Type: text/plain; charset="utf-8" From: Nava kishore Manne The L0_TX_DIG_61 register bit 2 is a reserved read-only field. The previous mask value 0x0f incorrectly included bit 2, causing unintended writes to a reserved bit on every scrambler bypass operation. Correct the mask to (BIT(3) | GENMASK(1, 0)) to cover only the valid scramble bypass control bits. Fixes: 4a33bea00314 ("phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gig= abit Transceiver") Cc: stable@vger.kernel.org Signed-off-by: Nava kishore Manne Signed-off-by: Radhey Shyam Pandey --- drivers/phy/xilinx/phy-zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqm= p.c index fe6b4925d166..c037d7c13d48 100644 --- a/drivers/phy/xilinx/phy-zynqmp.c +++ b/drivers/phy/xilinx/phy-zynqmp.c @@ -53,7 +53,7 @@ #define L0_TM_DIG_6 0x106c #define L0_TM_DIS_DESCRAMBLE_DECODER 0x0f #define L0_TX_DIG_61 0x00f4 -#define L0_TM_DISABLE_SCRAMBLE_ENCODER 0x0f +#define L0_TM_DISABLE_SCRAMBLE_ENCODER (BIT(3) | GENMASK(1, 0)) =20 /* PLL Test Mode register parameters */ #define L0_TM_PLL_DIG_37 0x2094 --=20 2.44.4 From nobody Sat Jun 13 01:48:49 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010016.outbound.protection.outlook.com [52.101.46.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C62A842EED9; Mon, 11 May 2026 16:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517172; cv=fail; b=F7j3mDVZ/TPALxTMsT08OCfSYUSgis+8dNaRdqoJU7jJaKlqkiopWvhgdOm7EzWMydQj8bM9QRs103P7rhJD3gFzj3d/e7Rp/Fq1kljNsIvgx+bfZ/+pOs4DyRtaxVWimc33KiLGvF2hrofg3e9SwgwoSQlmWkhDPohTKXdkPwI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517172; c=relaxed/simple; bh=wZKZX54XoyMIF3um1+BkJRMFSh3oRUemRf0dwpg422w=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jEat8wi9tUoWB6lBf6tAtav8pb6+aq8fXgsMwnpoWF7YyCXrbWj8UT1pnwFj3/Vzwxnuqy00uxksIvRzdaVSwV2+U2jEAv4pLyhpsfzxAH5CUW61OvOqp9Cscz+0nz9EMO//k6rR2quNaMaJJfdI5YI8c55r6+ZbsOuqWENiM7U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=bp4kmF4I; arc=fail smtp.client-ip=52.101.46.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="bp4kmF4I" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gxloN8TWolRaI6pQe/jT6DKzudvbRVi2wdXeehS2bamjPKIb+/47lVHLWFggl02myOPiWIa/HtKr0CSS2NsiN8zk7uz+dT868+EuEnsQmMxZDYvar4sxHNlwNse/LxZZNhHoJKCjJnHfT6J7wPV4oyQdFpy/Ek/5QEdO6lf+vB0RprxCfBnjc24cdSb+2suBHiqWhoHQQO2QqF4uq1zNqwG+Jnr5sgfIRVSIKUAyv7UQU56pNyqBuEJf8kLrMFq84oterVkiXU8ay9Hql7Rj4gjkUMcD6GyAfc1Ss1lYPgBhLdN9ASt2YH3H7ayMXPlZ/IzK7KHtTn9x3g8F4LSXIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lsiAOzaQ74kaxjx+Uq0MGP8ePYcDdh1dNRqbJGdqF3c=; b=f3woYEQ5J72TFuDj7rNhge9CfZngwO29FtpM9SkIc3kEsV46hRtSIYxL58LS9odX9zquxUq4DfVp6tH2ekc2cv9HzeFMXn3K1drEWsbQ0gDHnjSTtuLPnyvgjaQE3p9K5nNgyZRPrpM72wI64OntlLyKykJSovo/kFpgm3379hy5SWUg5WkzbOrAiCEMJLgwrE1xLewT7tqGs2IZ0OgUX4QftdfHsmTtCfPf7iVVwPNNFyj33yPJ2yMssSqGzJcnXleOg73otO1wtGyZFZGRL1EubKwlmmGbBqlyhto9nAWLOsKDleRglDrtviPlHfyMhmHw3xosfyxfpeVHINcw5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ideasonboard.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lsiAOzaQ74kaxjx+Uq0MGP8ePYcDdh1dNRqbJGdqF3c=; b=bp4kmF4I9GZuFHODyYPjsD9+5oDV9BVB8atf1RHAIQsOdktBWXK6WvIbggdZ5NZe0ELljttdCQ4sLQTejcpM4aHnFrAxUNGUW2iM61Ie0e/adwzuTtUu391owB7yl2U/0l++8ZrCpcVsc7Ei2aqwkJZq/H2AMMScCxe8QixmyMo= Received: from DS7PR05CA0040.namprd05.prod.outlook.com (2603:10b6:8:2f::33) by IA1PR12MB9529.namprd12.prod.outlook.com (2603:10b6:208:592::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Mon, 11 May 2026 16:32:44 +0000 Received: from DS2PEPF00003443.namprd04.prod.outlook.com (2603:10b6:8:2f:cafe::26) by DS7PR05CA0040.outlook.office365.com (2603:10b6:8:2f::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.15 via Frontend Transport; Mon, 11 May 2026 16:32:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by DS2PEPF00003443.mail.protection.outlook.com (10.167.17.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Mon, 11 May 2026 16:32:44 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 11 May 2026 11:32:24 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 11 May 2026 11:32:21 -0500 From: Radhey Shyam Pandey To: , , , CC: , , , , Nava kishore Manne , , Radhey Shyam Pandey Subject: [PATCH 2/3] phy: zynqmp: use read-modify-write for SERDES scrambler bypass Date: Mon, 11 May 2026 22:01:34 +0530 Message-ID: <20260511163135.2924642-3-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.44.4 In-Reply-To: <20260511163135.2924642-1-radhey.shyam.pandey@amd.com> References: <20260511163135.2924642-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003443:EE_|IA1PR12MB9529:EE_ X-MS-Office365-Filtering-Correlation-Id: a14f4037-ff35-4eb8-83e4-08deaf7aedbf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700016|82310400026|18002099003|3023799003|11063799003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: 2506spoD3JHM9JRCVmKD8vDr7FUCxFKXh1+i4gSYygIh3YaRvnTYDVCi2aMbYmJHDhhFHo/QL6KnTNRvy+aQMlHDRgpz36+1w1LzedWLhjDYpCLYcyqKXgxlAsb5vPpl7AEirufTuGGbpPzlQC3ytWYfHovfRGLVjnNjrmVkjcr3HO9bLR+08zkRFZOHRO+o0n6dcdCUx9LtR2QD4XLa+kdVaFwW4xCUx6LfiHQK6Uqx9an4BFPHHfcppLwNaenPLiWYACXqlMmGta2gfV27DGiJqVUyEb0scAnJeTbL/Jb0UlyDZpx4K5HmQkIYpl5mZ5m+tJCHICLs19R8HVnwGyCyT8dHP+GmAjUSVixn4S/SY5Gkw8rdzUp64O1cLCJ+cRdD8v4gTmiC6Hyb8jxA3cf5RNngzDFgCUlju2u/BXdPo4EnxS6eAwMk6D72jI8sDzMWUwRpdioCjNQ4IknIq3qNWIj9R5SUGwtK5679ZevOyXbBJfh8xFEnOta6yPLsoMuwOT1Euy/5EzxP2NJYMVBmIc6UoScRmzP6ZVpk+UQahuCi0xteYDI8hpl6AYLeILKidHjvcnR0H/2pDzddaCbrwL6qbEVcfod+pqnMqPpKEAMwqklJLEvNuqOHRWklaiT5Sxfokw55ey/To2eKwFFggA0DPx6ISr7ikMIrfTQ2KK92Sz9N1t3ivfRGWNfLYxUkUX83qD2fJ85OfP+Sds5zfkfVTE1DI8CMOWILH5U= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700016)(82310400026)(18002099003)(3023799003)(11063799003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4LvkrVA/+2t8WZk6P/JefUVcDo4ft3B2y82O7bOTXzfPiT76NdeLK95XGVusDjAhBSPBcyVAIBa77XZMpDWp7KHNdBSsM46F9hfuvxpi8SU0RbtiFT7tIiQajK72sDABkpfyT/WLskfAW/ZVU/MWb8HSUxcwrRwogcOZtn8GNXIBJcPlvEp9B0j2aQPOzWjYI47+hq4UC8OU8tv2cVQpxSxTnhksdb4yReT0p68dUB1zqfc88NmK8rUXavgqa/agGm4g+GOpY/pt0jOizrqx6TWo99dIzL9tUUv7Vzn545Lls5hYjN8L0XlEb/709vcnDaGfzzo7Qf76wTZAUKDEyjXViyEi+iyh4ZulwmMfn6Zqp9U5rDYN6kNAnXeddyj15blwGtntk4m2f63M6g8/UEcH/fT74+Pa2VXL9pGFLwpGUIt5U73f6lyVpa57HpXJ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2026 16:32:44.2001 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a14f4037-ff35-4eb8-83e4-08deaf7aedbf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003443.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB9529 Content-Type: text/plain; charset="utf-8" From: Nava kishore Manne xpsgtr_bypass_scrambler_8b10b() used xpsgtr_write_phy() which performs a full register write, silently clearing any bits beyond the intended bypass control fields. Switch to xpsgtr_clr_set_phy() with clr=3Dmask, set=3Dmask to set only the bypass bits while preserving the remaining bits in each register. Fixes: 4a33bea00314 ("phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gig= abit Transceiver") Cc: stable@vger.kernel.org Signed-off-by: Nava kishore Manne Signed-off-by: Radhey Shyam Pandey --- drivers/phy/xilinx/phy-zynqmp.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqm= p.c index c037d7c13d48..6c56c4df8523 100644 --- a/drivers/phy/xilinx/phy-zynqmp.c +++ b/drivers/phy/xilinx/phy-zynqmp.c @@ -505,8 +505,12 @@ static void xpsgtr_lane_set_protocol(struct xpsgtr_phy= *gtr_phy) /* Bypass (de)scrambler and 8b/10b decoder and encoder. */ static void xpsgtr_bypass_scrambler_8b10b(struct xpsgtr_phy *gtr_phy) { - xpsgtr_write_phy(gtr_phy, L0_TM_DIG_6, L0_TM_DIS_DESCRAMBLE_DECODER); - xpsgtr_write_phy(gtr_phy, L0_TX_DIG_61, L0_TM_DISABLE_SCRAMBLE_ENCODER); + xpsgtr_clr_set_phy(gtr_phy, L0_TM_DIG_6, + L0_TM_DIS_DESCRAMBLE_DECODER, + L0_TM_DIS_DESCRAMBLE_DECODER); + xpsgtr_clr_set_phy(gtr_phy, L0_TX_DIG_61, + L0_TM_DISABLE_SCRAMBLE_ENCODER, + L0_TM_DISABLE_SCRAMBLE_ENCODER); } =20 /* DP-specific initialization. */ --=20 2.44.4 From nobody Sat Jun 13 01:48:49 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011025.outbound.protection.outlook.com [52.101.57.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F40AA43635D; Mon, 11 May 2026 16:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517180; cv=fail; b=M6oHJ18wksP1Vp0vuQJMikybtXhPcMGSOOGfND5hua3KTEv7SIMGljtV60aj8SBHgk5bYkF3rDefebGNgHMRQU7kXMTgNk0sD1S/tclfaNiwWwGXLImuOlrJZtUd3LTZnWN8aHIos4mbcKjc3L6+lWlWC4LZkqap4dHHQ6CbHvw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517180; c=relaxed/simple; bh=4S1z0aOnous20LKvRAI3NSz2fzKHRIEZszNFg8H05Vo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AHTYjL8uAI+x+TtcQSIHO18GBB27XKo+uyvlpxK/GMmqxD4o6Ze/MotEEfzxkVvTsoBY3QinzFnOEyatTEEQHXF/pnzeQHYU0O7ytI0DtRdGqhgSSU8UzArNBm0gh/OcMzND6If201N3Y6GIuhylvpn7gE6WBqsKheQWbiVLXkI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=bU7jpOHq; arc=fail smtp.client-ip=52.101.57.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="bU7jpOHq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L/Kz8WW1lEdyIEOOExm+aBBz2xRhfthrKn5ioKV3qlHcN1P2HSuhfjvQaOXZXbZHK4FferXuRSk/xKeqRm9qz+yHC9XVUWksdxPQC3bG3WWjELd+R4STg1jsMr0B3DDIaB4k3oQwriiEenPXsAxpNQAFTTYW7TMpbOXOTgLv1/RXapPezABphgjH/kL8rFuS0EKziQjYYabarvbuocvFctnyHZ/jqIP7a9qbmYtcy7RANm0k8OaDhXT7+m0Dj1SKy4gfgkSKgANpkxEgIQqgjkE5n+xVi2TfjZ8wyNdtHIASJKSEZWjB2Jo6m4x1svb2kVaYoBqcKhvG8NBqn1CE7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JTBdThVFEpNHi2dU+mAd4gM1WT8C3kXv+HJ2zJ9hpyU=; b=qqyDqk/dbB6Uawcy0tF/4KKJ5A8oYtMAlCPtZffKuC1Jph4kSN+3VTNrt34K/iKUFo0H1gu2K2NREYWu2aH0UeBbA0KQOrqZxE1dFfu82WYJZ+eWAqv8o6lkBZU+q1tQl5THh0MoNz2r7xCAK4sssbFHZKCCBH4Zz+rY8FLso/e4BxAi77+XWGxd6caELGN3r226k6UnDbXpOiHNYG5zS0uor+7zN+4eXFVCF68hrewBGFFiruyvbq8Y9w4c6NRxdXiRop2h+CA7PtzMrhWhwVhEGFAK6NgdcaxxbqMWoGKhEG5VGwWlOcEgrFh4r5PGis3qUOwnfC91B0tTGBBDmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ideasonboard.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JTBdThVFEpNHi2dU+mAd4gM1WT8C3kXv+HJ2zJ9hpyU=; b=bU7jpOHqlth+ZMeKUGjpdlX2XGBFAKyQByXbjZDVizNSWryf8JRwhhBB0VxRlNL6EE9W+SJ1ULsykdSYDKAE/nrb/e0BfcOzqP1jUMRrBRcRZCbdjnkIot7vqrF3whbX+mbPwEGF0yQcWHjCxhFJeyRA2aJMRgwhICvi7u3osGY= Received: from BL1PR13CA0010.namprd13.prod.outlook.com (2603:10b6:208:256::15) by MN2PR12MB4334.namprd12.prod.outlook.com (2603:10b6:208:1d1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Mon, 11 May 2026 16:32:52 +0000 Received: from BL6PEPF0002256F.namprd02.prod.outlook.com (2603:10b6:208:256:cafe::ad) by BL1PR13CA0010.outlook.office365.com (2603:10b6:208:256::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.15 via Frontend Transport; Mon, 11 May 2026 16:32:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL6PEPF0002256F.mail.protection.outlook.com (10.167.249.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Mon, 11 May 2026 16:32:52 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 11 May 2026 11:32:27 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 11 May 2026 11:32:24 -0500 From: Radhey Shyam Pandey To: , , , CC: , , , , Nava kishore Manne , , Radhey Shyam Pandey Subject: [PATCH 3/3] phy: zynqmp: keep SERDES scrambler and 8b/10b enabled for USB Date: Mon, 11 May 2026 22:01:35 +0530 Message-ID: <20260511163135.2924642-4-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.44.4 In-Reply-To: <20260511163135.2924642-1-radhey.shyam.pandey@amd.com> References: <20260511163135.2924642-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256F:EE_|MN2PR12MB4334:EE_ X-MS-Office365-Filtering-Correlation-Id: 512d3fbb-8984-42a7-7e7e-08deaf7af2e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700016|1800799024|18002099003|22082099003|11063799003|56012099003|3023799003; X-Microsoft-Antispam-Message-Info: 4049EorZND+0+1JCmB5nO8Rq+nJD8DpDgBNUsAtGbPTe9YacBrGJczMH2upUvGJih8SBZNoyToaDEFFGGWAO/B5Cs8oxyqQbdkfF+zusd77BNVePhmH+bJhbg4eTjE4esf/8JfQRGKnly8hOmCfpx2TfG6qVM02JFQ5HKp3VrNyp4trcL/GtOYiRtfvSAGgcQZwxO7J/oIbobAoE/g07XjObsqyAKEcsD2PyKOq9XKy+syUQaRPXvejJIhOR54+kVbqhQemnCf68VNSTPdmzcCh/PM38TSDSMbbsDI1+oIGH5L3qOgP60uqoeaYJ4Lk9rj19zE+fjT414BaUiMYMaekFsGM+ggSkOHEF7siWScI95Fxx8j3cxSpEpe4GtE2SSzqsw+Ne4AUoo/kmKsTv9fKTN/dFkU9k0zPIrmu+ixe7axps5cVyPaAO53fsAAtU7V33t9N0ahd71nHCprTq0FVIQ0gHlYmM1t3Re+ZMEVuH5cpzXsDoVp8MNPUxcUOEyagpnKzy4KsC1rsjXVUtQ5bsLErCtlZ4vjFBnoTmxP9AHjQIwQ8X9LYHjzpZQwE5SKfRqJOZ4AeAW4eFzUOLNs95vNY0O+CIHCsZnsRhlH7kRVw6Ot9Z6IAKjUPX/kiSGvChivvfPGXVGk4mwRrk1l+hAf0TVGWUcTo/bTBzTpqPUbd+iup1P3vsVLJhEo7lbBoAO4RIka3thR+WWSCIwgJ5nqz+n3jXuC0rGlws1eQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700016)(1800799024)(18002099003)(22082099003)(11063799003)(56012099003)(3023799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /KlCj3WsU7w9EgVVg3K61imYNjRnMrOWh4OgnndL+6GOCtxSxTNbxzNtvwN3RaJRIIUlSKs2ddWLsFTdSmxsnKD1+jGlRRuPz7xR6d6bb082WBw9vAequWW6ez3Y4iRnOQOAiL1pp65CiOmgPIVBUmHv7Nge6JhWPPV75ITxiusXFGUkeGKuwiBwVTNiz1g/qSP1/a2BgoTaiHPPxvajn/lUXTppkKX93G4oruGdxILfHuMyw9EPATBC8a2IN0N7oWjK+82NQQQ9dscxja2upZSFu1XIEv6mVlUsjKKZkLh5iS6YUB5PaIQEsaH0XyvUkXEIXCO11M7bLTNK2UOHYNYHDYKkG/C5YfhkNVgzQHBzEeKmv8qMXQnLRvOdH1CixqUZ08rCFCDOm5nn/zVUu28PTqtyO8zZDJNv3KAfW4i5Xr+wQMlBNKILkkVeNApW X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2026 16:32:52.8516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 512d3fbb-8984-42a7-7e7e-08deaf7af2e0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4334 Content-Type: text/plain; charset="utf-8" From: Nava kishore Manne USB Gen1 requires scrambling and 8b/10b encoding to be performed in the physical layer. Do not bypass PHY-side scrambler or encoder/decoder for USB operation, as mandated by the USB 3.x specification. Scrambler and 8b/10b bypass remain restricted to SATA and SGMII modes, where encoding is handled in the controller. Fixes: 4a33bea00314 ("phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gig= abit Transceiver") Cc: stable@vger.kernel.org Signed-off-by: Nava kishore Manne Signed-off-by: Radhey Shyam Pandey --- drivers/phy/xilinx/phy-zynqmp.c | 39 ++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqm= p.c index 6c56c4df8523..087fe402e4e2 100644 --- a/drivers/phy/xilinx/phy-zynqmp.c +++ b/drivers/phy/xilinx/phy-zynqmp.c @@ -502,15 +502,30 @@ static void xpsgtr_lane_set_protocol(struct xpsgtr_ph= y *gtr_phy) } } =20 -/* Bypass (de)scrambler and 8b/10b decoder and encoder. */ -static void xpsgtr_bypass_scrambler_8b10b(struct xpsgtr_phy *gtr_phy) +/** + * xpsgtr_bypass_scrambler_8b10b - Configure scrambler/encoder behavior + * @gtr_phy: pointer to lane context + * @bypass: true to enable scrambler/encoder bypass (SATA/SGMII), + * false to disable scrambler/encoder bypass (USB3) + * + * Uses RMW to preserve reserved and unrelated register fields. + */ +static void xpsgtr_bypass_scrambler_8b10b(struct xpsgtr_phy *gtr_phy, + bool bypass) { - xpsgtr_clr_set_phy(gtr_phy, L0_TM_DIG_6, - L0_TM_DIS_DESCRAMBLE_DECODER, - L0_TM_DIS_DESCRAMBLE_DECODER); - xpsgtr_clr_set_phy(gtr_phy, L0_TX_DIG_61, - L0_TM_DISABLE_SCRAMBLE_ENCODER, - L0_TM_DISABLE_SCRAMBLE_ENCODER); + if (bypass) { + xpsgtr_clr_set_phy(gtr_phy, L0_TM_DIG_6, + L0_TM_DIS_DESCRAMBLE_DECODER, + L0_TM_DIS_DESCRAMBLE_DECODER); + xpsgtr_clr_set_phy(gtr_phy, L0_TX_DIG_61, + L0_TM_DISABLE_SCRAMBLE_ENCODER, + L0_TM_DISABLE_SCRAMBLE_ENCODER); + } else { + xpsgtr_clr_set_phy(gtr_phy, L0_TM_DIG_6, + L0_TM_DIS_DESCRAMBLE_DECODER, 0); + xpsgtr_clr_set_phy(gtr_phy, L0_TX_DIG_61, + L0_TM_DISABLE_SCRAMBLE_ENCODER, 0); + } } =20 /* DP-specific initialization. */ @@ -531,7 +546,7 @@ static void xpsgtr_phy_init_sata(struct xpsgtr_phy *gtr= _phy) { struct xpsgtr_dev *gtr_dev =3D gtr_phy->dev; =20 - xpsgtr_bypass_scrambler_8b10b(gtr_phy); + xpsgtr_bypass_scrambler_8b10b(gtr_phy, true); =20 writel(gtr_phy->lane, gtr_dev->siou + SATA_CONTROL_OFFSET); } @@ -547,7 +562,7 @@ static void xpsgtr_phy_init_sgmii(struct xpsgtr_phy *gt= r_phy) xpsgtr_clr_set(gtr_dev, TX_PROT_BUS_WIDTH, mask, val); xpsgtr_clr_set(gtr_dev, RX_PROT_BUS_WIDTH, mask, val); =20 - xpsgtr_bypass_scrambler_8b10b(gtr_phy); + xpsgtr_bypass_scrambler_8b10b(gtr_phy, true); } =20 /* Configure TX de-emphasis and margining for DP. */ @@ -707,6 +722,10 @@ static int xpsgtr_phy_init(struct phy *phy) case ICM_PROTOCOL_SGMII: xpsgtr_phy_init_sgmii(gtr_phy); break; + + case ICM_PROTOCOL_USB: + xpsgtr_bypass_scrambler_8b10b(gtr_phy, false); + break; } =20 out: --=20 2.44.4