From nobody Sat Jun 13 01:22:37 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012000.outbound.protection.outlook.com [40.93.195.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0CB943CECD; Mon, 11 May 2026 16:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778515732; cv=fail; b=Dlh/AoMsvdLYKIXiDS9VoktkMnJ86z3SFWTDbW4hf+NqLi+afebNmaHdabqO3+uQWMWfVEa+/lC12Z+NC2ALaXlqSoRx5uvJDQX82tH0XOYNpdRJIJ1uAo4scrLe+Mm1nGvyGiDyk9ruJ72pizNzQvqtch2wMnNGiUzXi9qcMeA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778515732; c=relaxed/simple; bh=5A/iTGh7DjUS5p8cUKMGjtOfQE0zj5VlcJfSgUi4sas=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QgoS6TqEnlrQ8dz0vjXGxsrV4/KgFh7dF3m+C7F9tUC+mzcCD/Gyar+Zcg7q+PlcdwCIHvWBW9zV43Olclfd44x9CiwTLutClR81TMKuaKX74J9RIgA9mnlNS6GEmqgefTF73BnrJRFzAy44B5CTfIZsWMW20zM47kR8UJc1hBU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=JU5poEU6; arc=fail smtp.client-ip=40.93.195.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="JU5poEU6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jAdYmx4+g0mud8qsaEgKQLxyrEIVeYPYL5VnJVRg+qMZu+DEizLETQOB8DuCk5uQvyBufApU9lV52HP2vYMPnEhU/FRxrXo7Px5qtilKZS0DQ2iR7pnWjC9akssSVO0WDykLc0OymOeXWMJgPNT1J2gwRP//fO7/IQVuhbfihVsow042VytL4YqIfPyx2yOJDcJXlrzYatTzIjSy61qWN6o4RkWC8XdDv/5AhF681eeO7tFzmEsyF+g83PUwdg/Bu1LfP71zsld8pCAXyPC3oLH6gJu33xn/pRNLSluxPP8DMX6HwrMBeStQI/3nLXMCja3vkCN7R1k/UNXw8LxA/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x6bvowfY22m8biTaw0TdOcjMJUVZ14CmEpwh1B7yrxM=; b=oUBbkTKwyPhYKWwjcgxbakdHwOa2o83v04b+W2r9BHwG0w4qpN3qYidukiE8eoKjnA6ByVskESqv2ZDti3wo0pIX/kGcZmP6YxC/M/tzYrWvFHMKFkbK5G+Bpeepqc6bmw6gax/aXqU97h2irMyrrb6HcMF221Di++iptanqDmgSRIncYYaAXygpiW0yB8sH9mvA3/tJw4G8Kgii3mlK2rPlvpD9rTAn4+4ILVo8aedOVGbXn3Zhcc+uPxaMeKwaBVXBntSCGBGTJpKMcYzRkdbWNuUPH7xwKUvDLcrWpDa/MwEokdX02PKWxga+2PAZ3kWMrucatx0MlCygGdw3FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=synopsys.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x6bvowfY22m8biTaw0TdOcjMJUVZ14CmEpwh1B7yrxM=; b=JU5poEU6bVKejaIhtRnfwaE83nNwYoHtloQQdgoLS4I0Bjp/dIaD2A5aShBCYJFTd9aL1503kXq5zSizdlN7NjlgcmWbtyax1eIlDWfwAyDm4oUb6ucTlcv0U+o6Kvj5nsAgtpdpGL50pNVF98r1ynDJnamPfdKeID4ZbZsCBUY= Received: from BN0PR08CA0030.namprd08.prod.outlook.com (2603:10b6:408:142::9) by MN2PR12MB4255.namprd12.prod.outlook.com (2603:10b6:208:198::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.23; Mon, 11 May 2026 16:08:45 +0000 Received: from BN2PEPF000055E0.namprd21.prod.outlook.com (2603:10b6:408:142:cafe::99) by BN0PR08CA0030.outlook.office365.com (2603:10b6:408:142::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.23 via Frontend Transport; Mon, 11 May 2026 16:08:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN2PEPF000055E0.mail.protection.outlook.com (10.167.245.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.3 via Frontend Transport; Mon, 11 May 2026 16:08:44 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 11 May 2026 11:08:40 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 11 May 2026 11:08:38 -0500 From: Radhey Shyam Pandey To: , , , CC: , , , , Radhey Shyam Pandey Subject: [PATCH 1/3] usb: dwc3: xilinx: fix missing space before closing comment delimiter Date: Mon, 11 May 2026 21:38:12 +0530 Message-ID: <20260511160814.2904882-2-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.44.4 In-Reply-To: <20260511160814.2904882-1-radhey.shyam.pandey@amd.com> References: <20260511160814.2904882-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055E0:EE_|MN2PR12MB4255:EE_ X-MS-Office365-Filtering-Correlation-Id: dfc6bda0-733d-4397-fdb6-08deaf7793be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|82310400026|22082099003|18002099003|56012099003|11063799003; X-Microsoft-Antispam-Message-Info: w5Vn/JJPhBJlhv2J7GZ8WgfSk8isRgbfalRtI0dyjqHkA0u+reifWmJKuZb9YkQTE60jL0H03qM7+n00kaTp7+utSyWKFzpnEuS/WtG2FOxY4X8gjiwV1wIMHr05QD7QZlHOLVWzypRgpy8f9gbPZS1oiLJpqSmu68ruNhy8wfi6U/ahJGGFKderStRy2D9vSlefTIGc37IMTkPBGMHoPiPUa8t2vq8lnNE3FUJMdVJ+iapvH8ADx8PVmjUcD1L9yeblNt+4lTB8Qzf79kGh1ESWweQmLlmHX5QM6BMHlPSpG1N6ywXEWDtigFLk2s32p/jpBv5cJA/fAbSpVRF4fGsM5MoKT0P+VpWicFV22ZFPN2c8xKa1Q75CrrMhOElzweoaFducMktZrEMP1Dv8rCSDPhQka7ptNeUKIRB75MfZav4lJvZxqlD1t+1r1HzWFKAo2BkG2yuTtkvUtVecTi9WknTUkuj1hnXGW8aqCKvd/Qz6QxtEMUskzjvk2/IGfd4AhoOYAecJNfps4PDOL5DJSYMro7mevnw3+YppbCER/ZmWY+ICN8IHm3aT18Y2J1ADG7ZEULACLpxJkDgaOzHhQpb7FVedgf+WX3aHKgvzp0R3uCi9FpPZbv3j48pIe2JZeAD42zV8IgU0K0ztTo/x7h/FjMCyr61Jj/sBNAgTaUlDr2GLj2W6g0Nj4InICAq1jHWmR8bwaW4hV07klfAhOgMFjvR8bUtNJY2UK+M= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(22082099003)(18002099003)(56012099003)(11063799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6qE4DsYPArEoPk70DAsre9eWXy7QHkKtgBZLG4Lrs85puVhz1EgBH6LVgQL5C+SzFp7glZq9OFQMpxnuQP8tN6vdIBkK7fvAvBmj8e4+hB188EGshWr7MUHWYkH1oe3hGMPCt5MawNnYsRF1nWcugtuFWaBxO1rO8UQcWxO1yRU0xoef/0m3SgAOcE2cP7vnBFSNa/I5aaOx2mwxOXuJF7vWUr4B7aI9MM+llkj3GchSWtRZZt4x5dGVs6d89y5jb17p/g3DbbF0EGSdZduzLlLJHWT95y8wn27oqBT0tSmmUJ6JdlRJG/KOaLk8zS7vZMxECYn1+KHkeiWv+E4RhZaQ9OHzExa+7OIVExdZ+JQBToHWS4hNAKI2zmjmVSfcDhQND5FfnFx1uqyb6GoWQ4AVxc5bJA9y2EJ8XWGLnfxi8E8FhNH/R9qbHwy7TPP4 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2026 16:08:44.7504 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dfc6bda0-733d-4397-fdb6-08deaf7793be X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055E0.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4255 Content-Type: text/plain; charset="utf-8" Add missing space before '*/' in an inline comment to follow the kernel coding style. Signed-off-by: Radhey Shyam Pandey Acked-by: Thinh Nguyen --- drivers/usb/dwc3/dwc3-xilinx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c index f41b0da5e89d..a3c7dc258c7d 100644 --- a/drivers/usb/dwc3/dwc3-xilinx.c +++ b/drivers/usb/dwc3/dwc3-xilinx.c @@ -196,7 +196,7 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *priv= _data) } =20 if (priv_data->usb3_phy) { - /* Set PIPE Power Present signal in FPD Power Present Register*/ + /* Set PIPE Power Present signal in FPD Power Present Register */ writel(FPD_POWER_PRSNT_OPTION, priv_data->regs + XLNX_USB_FPD_POWER_PRSN= T); /* Set the PIPE Clock Select bit in FPD PIPE Clock register */ writel(PIPE_CLK_SELECT, priv_data->regs + XLNX_USB_FPD_PIPE_CLK); --=20 2.44.4 From nobody Sat Jun 13 01:22:37 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012000.outbound.protection.outlook.com [52.101.43.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C39F843D4F6; Mon, 11 May 2026 16:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778515736; cv=fail; b=PfYPzeuU1+o9PwZgC40hxnSh6hnvY3sTK1h0ZSG5PdzivL5AOScZBWM6e8c2it+EVS1InyyIhxXac+79UJ8Fl/3M5eCm/poOtJ/w37YKl8bxkh6tAqaNgNF0t3lNx5d0c46TOKp9DYaJ/3T22o3BOrMjrTrGUTuW2UGuns8UmX4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778515736; c=relaxed/simple; bh=ch53UbtXbsKKOii4zXfD34Pjr2c8GMibdOaEoAoAlsQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BI5L534H+z/gjBGa5gLcL/7dP9T4QNe2+73X4KWcatQcNH5iAfYJ4eu7Yp6rdFql4X8lnyxpGJaiEZmFEgY6mGf+XvA2BflT7vi0Jg3b2veiFEEOZvyLBJ77wsj7mh+t8eRoTIBLjQbuc6HjtxJgda6voBdu0VooynZcwMT4qMs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=oE2jRyHW; arc=fail smtp.client-ip=52.101.43.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="oE2jRyHW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lz02Cpasl3xq9hSQRsEU9d0hax/+HUPO0wom+9McUTbItH69zB8yG9Up6jA/82Q3uGGIcUMWxaV3ZpM9i9DEbFAlgxIFbNbvcm1/sYRu6Xpbf1oiuzTJPItGqzfhzFmwVu2mJ3m9wPOUpI2pZhnNsBLNvL/gpyMf7Y9AvrRD1HGeXQK6JCnCkjJwmfakeUWLj/tHQXbSNqBiLp42WpU3oK8oB8XS5qwGhgMIAoeuvofedCS+zkXcNaLvEdWEU8O8MOX8bl9atAr7DZQ+5DhTfc0hlZ9UdfAFMwSdcdOVAhYe5rMfiyBhI6asmRcl0NTtgNKvORfOWmwN7duI3X6cxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KL6DZ+mhLRzjaNmcT42pTRNqIAAAh3F0VY/d9uQMcWY=; b=q0UpaMkGP6EaRA7lCkfVadoe6xUxe8m5vSvu9g0qfSwm6Y1MjL6FlpnXYaoxW0wJkYpojPEtPB3rV28GL1kKM/keWFXimG+SUGstWCzsDf/2LmztmMK3MHYytCS4svSIDkT53uPqnC+5ya98ZbWd7lEmfMr/5DZYcOKV/Imop3g1c2JwOhNj1sP5tAR4i2ahrtT6yK2hyDMrR7rV5uIAsjrKhqDYGCWzNQzl7Xo9XzXbpnhgeu5qOw5PJUFi6pGjmMMXI+dWinKoLVwM2th4wmr3DsW/2kPQfULEqDfYcssBQsF8wvK0pxrkq2o5w0aOLznHEL2hsjZwqXJJ+z8cyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=synopsys.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KL6DZ+mhLRzjaNmcT42pTRNqIAAAh3F0VY/d9uQMcWY=; b=oE2jRyHWlaPbCkst2RGrcY4qye4H+DlfS3/FCFS+OjmM9oYsjAzHIWFfkHsyqohoQDrfUOr5rFnGX/E0O5XODVrY4JyYs3Dg3tvXnRSGOVN7HF/MLzR0aJAcxJByH2Wzsl58588CDEOEPCWdotEg+S1pQzSfQcJb9EkjLOq4Il8= Received: from SA9PR13CA0155.namprd13.prod.outlook.com (2603:10b6:806:28::10) by DS7PR12MB9527.namprd12.prod.outlook.com (2603:10b6:8:251::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Mon, 11 May 2026 16:08:52 +0000 Received: from SA2PEPF00003AE4.namprd02.prod.outlook.com (2603:10b6:806:28:cafe::ab) by SA9PR13CA0155.outlook.office365.com (2603:10b6:806:28::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.15 via Frontend Transport; Mon, 11 May 2026 16:08:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SA2PEPF00003AE4.mail.protection.outlook.com (10.167.248.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.13 via Frontend Transport; Mon, 11 May 2026 16:08:51 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 11 May 2026 11:08:43 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 11 May 2026 11:08:41 -0500 From: Radhey Shyam Pandey To: , , , CC: , , , , Radhey Shyam Pandey Subject: [PATCH 2/3] usb: dwc3: xilinx: use reset_control_reset() in versal init Date: Mon, 11 May 2026 21:38:13 +0530 Message-ID: <20260511160814.2904882-3-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.44.4 In-Reply-To: <20260511160814.2904882-1-radhey.shyam.pandey@amd.com> References: <20260511160814.2904882-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003AE4:EE_|DS7PR12MB9527:EE_ X-MS-Office365-Filtering-Correlation-Id: 14f318bd-cbeb-4720-f71d-08deaf7797ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|376014|11063799003|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 8UC34AYWLGZUyh0MQaEfD1Na582uyQRXi9tD/n8SddJBKcGzjf+qwXr8BG8qB1kfXDahpJFUx6iOfaZo6HUYWuwrptpKleChLUYlh4XKcBRl3H72LUf5sVo0enGRvVuNKGc5m3ZvSjWbJP2rzru6QBDLpwmNuoU0oJgJ3ppJMTDCANmEIKohk7ctPeEMVv6Xx83MC4Yv0h7ZDPLIGMHTz/73Oa8ikOWoz3JeFcUn7kEy28eM2p/4vLOjcV6y6uvOY87/0N+laC2wxEw0np02Hmkcb7Arl329efE7VQyiNyZD/I83RqY32f4kLRq86ey1EMDZplVSDnwErDqHd7GJPGO1aayrtZLkWNdbOQX2RCSpLC4N4T4mf8MyUhaiGi8UT4ve5Nb7Y3DWJCKw1U6CXn7qp2vT2QUigLAZ1V92m97ZPAx8XJJ2hSKKxcDm+MG01drMpJmOeeLk3RT087QXAhQ9vXBIILCsM6Jwir23Wf/K7DDqx/Qicdz0uF8bW0RdNGwMaqFW8oAWztoynHfF1sLgOfCvsz10tmOERX7nWoFzZbvO9MW6Rpl3Se2rVrMwuzFwgB3u/U+Pa7/9xm7pgKIbIL/jSoZkAs6CG10YuBR6nizBJ11gkhAPkGskVOs/GzkvEs3R4NxQA9nf/pdLMpz/7rJIgRrzAm1mXsjPXS16oQcQVsear+hGnRGQHLJrwaMxKWX746mbcVRzHf7aD2jwlU2OQIWqPyHw0c9F6bc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014)(11063799003)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4qdNHZ1VqdJuWoWqk/kYoH0PPbYVMJ8sVZEt0AkhBM0fLMowBM69BH/U/YPHsC+EfxF9H3bZD94aO5mRUEWgMr0iw2vXee/9lPQaYuOij0Qxu8n3rkmd767/TXlsJDxlobosX693/a3926my1D1Uc9bAnNQnl+kNnMv9co11/YrxPSuMoYhqilSGys2EuM/bX2noqm/Zwwr8FDBC3Ini7ihLVLLXASRqtv3iMmbUhdT9WxYoDEx+gjusdSZgsG5K7qT0azmAW75bC2AT1N8Oj9z0qVbshOLuPjppWcEg8CbCAkNye94WHEOkHKttVpBy3JXWFKt4dxmXTyfgOX/poWs/YtyWWE7s16uSZ+LjpVxUzk7XaQBmKS/GtVzkHYi17I3Dd5UCW1KuMfubVutkeelUmaTna4JsJbxujjSA13ZaRQqexmbu6MBB6EBYYgEy X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2026 16:08:51.7799 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14f318bd-cbeb-4720-f71d-08deaf7797ee X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003AE4.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9527 Content-Type: text/plain; charset="utf-8" Replace separate reset_control_assert() and reset_control_deassert() calls with reset_control_reset(), which pulses the reset in one step. Report failures with dev_err_probe() and a single message. No functional change. Signed-off-by: Radhey Shyam Pandey --- drivers/usb/dwc3/dwc3-xilinx.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c index a3c7dc258c7d..94458b3da1a0 100644 --- a/drivers/usb/dwc3/dwc3-xilinx.c +++ b/drivers/usb/dwc3/dwc3-xilinx.c @@ -98,18 +98,10 @@ static int dwc3_xlnx_init_versal(struct dwc3_xlnx *priv= _data) =20 dwc3_xlnx_mask_phy_rst(priv_data, false); =20 - /* Assert and De-assert reset */ - ret =3D reset_control_assert(crst); - if (ret < 0) { - dev_err_probe(dev, ret, "failed to assert Reset\n"); - return ret; - } - - ret =3D reset_control_deassert(crst); - if (ret < 0) { - dev_err_probe(dev, ret, "failed to De-assert Reset\n"); - return ret; - } + /* assert and deassert reset */ + ret =3D reset_control_reset(crst); + if (ret) + return dev_err_probe(dev, ret, "failed to assert and deassert reset\n"); =20 dwc3_xlnx_mask_phy_rst(priv_data, true); dwc3_xlnx_set_coherency(priv_data, XLNX_USB2_TRAFFIC_ROUTE_CONFIG); --=20 2.44.4 From nobody Sat Jun 13 01:22:37 2026 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011030.outbound.protection.outlook.com [52.101.62.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E12243DA53; Mon, 11 May 2026 16:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.30 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778515741; cv=fail; b=PcxDPRlnTi/TFWrDrTTrERRB518ZpOH08LVbAS9sNiaTX8LSZ6lTMb8zrXMBMVTLwSNi46Cs/CxA83BQKVPRCmbpEysHPHsB2fm0uQzWKtfKT9KZc6ipJlflhowPdIxZ1d5Lamqb/h4T2fuRy7v6b6FKpNl8blij8bIbhGGz44Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778515741; c=relaxed/simple; bh=OO2s0NXFTywGOCRlvnC1hhDjFFCvcwKO07Dd2DexLKM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YgGkI/5dMKBYOL5DZegGNfRhduYrwGyau1dLbwktXMOw+8gzLAWhBbeIzliO99yZveLnOWVGq5wkAsPUl0kroBSsft3MWrnOl+8SRsEJBOiJRVeMkq5aC4Gkpol9Em4uRuLZ0gL/IGfw+E+j3zsKdBIDICpFe/QjL0aRBWmpgfM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ri5SD8pf; arc=fail smtp.client-ip=52.101.62.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ri5SD8pf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KtIaTvMKhS6R4tsqzI2g528i6zQJK7irSqWXrY7f9N11FotOv7RAvMSkqIGFYaeeACwdQ9/mIrWbbpkEJFGgHYgKFEKxFhhwWkFWRDfiL7+hP/tPErnWR+/LO1N6qf9PzYTrckSNgr0lg7KRrX8kz5mjnFctUjrL7HZ0zWhg79vqLGWVIscr4xy83PdF5fz1g7vST1vb10k+jk7GfJJkh+DD6E7pm3LxEBioSTSFIKo9kntVVO9M3FY4LtPCiCeQ3b7OcIev4fQmpsifBtb1u02IgUxwwe2mWrCU+dG94JxWCPkQ74tBpKpOPIKcOOfsK0TUK+3J1MGLCOWI5OIyrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cG35ACqT/FVNtqcO7uTsy9EdWEZOE5AWOCoQmz6mPM8=; b=ZFpn8YcdPT2VAfK+X6l62y9Qhppg4/U5aZeYuG4hp8ht0r36TT+JT6uF7g7evXRQtPrcZRZaZLcRWiBFV38KkL+zK823HI+rSqp51RoZ49g2LmEuQqiI6maYNk7DwmN7Ir25h5ttyok9XUuSiYoiICCDvnT2+q0OV1Z+jVoxugcHP61/FGPTuJPRCTZWUSjcEZO8+9SA1bxrEle/lmfAIUKzuZZ7uMGlcvwrDKin4a3WCXzQ98xx3q7mwcjJoMR90H5yoy0x1DTD2TsAVQVRQjHlwhEANXRdFJsev6Zq7lN09BXA9lDANjVmEjh/u3si2tC8rXkWG2ThoHZHJbv/fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=synopsys.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cG35ACqT/FVNtqcO7uTsy9EdWEZOE5AWOCoQmz6mPM8=; b=ri5SD8pfJBWNIyMWGqpYPHlISWFofqOCCx4hbXZ9FvEd1rIkGtPuoXq1LUeNdO5dahM94/yduToVY8il4+S1LkgZ9TSjJiyPlB3V2fZh3OixpakAOqCg1FqP7mnbyCB6Pv6l5VpXRjftDmaRjS5Rcru75nqBkjxtIRnricdUV54= Received: from BN9P221CA0005.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::28) by SJ5PPFE4FC9FAB3.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::9a7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Mon, 11 May 2026 16:08:54 +0000 Received: from BN2PEPF000055DF.namprd21.prod.outlook.com (2603:10b6:408:10a:cafe::21) by BN9P221CA0005.outlook.office365.com (2603:10b6:408:10a::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.23 via Frontend Transport; Mon, 11 May 2026 16:08:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN2PEPF000055DF.mail.protection.outlook.com (10.167.245.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.3 via Frontend Transport; Mon, 11 May 2026 16:08:51 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 11 May 2026 11:08:47 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 11 May 2026 09:08:46 -0700 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 11 May 2026 11:08:44 -0500 From: Radhey Shyam Pandey To: , , , CC: , , , , Radhey Shyam Pandey , Subject: [PATCH 3/3] usb: dwc3: xilinx: fix error handling in zynqmp init error paths Date: Mon, 11 May 2026 21:38:14 +0530 Message-ID: <20260511160814.2904882-4-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.44.4 In-Reply-To: <20260511160814.2904882-1-radhey.shyam.pandey@amd.com> References: <20260511160814.2904882-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DF:EE_|SJ5PPFE4FC9FAB3:EE_ X-MS-Office365-Filtering-Correlation-Id: bd34c352-25e0-4a8c-c825-08deaf7797a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|1800799024|82310400026|22082099003|11063799003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: 58Ja7m4y3fq4HuxufNK0tOOqLyk0w1n1jbszYLb2BPVWnJb3PM8i92Vzqjm7pSRIBJ1h1F9f6tf17FhvqW9ee/1BaKPB+6l3mDfO0g2+bStoJgGH/G0GOsVfOV8DSCmIhPWH88FYA54mRyBOkyXmDupHKafENxRiv/iIbto20m3gH9t86YdcEhN/ubffu9p/A6M5rLX/8MIpgByI4Vu9DKDYSXaE4PHnt1RhB3R4CJZ6fMiP1P4cNGEpgAUcfTZzDOLmJCLDoWfZm7AiWB+ooti5bRtkaKQjaF/zjursgRrfdcbc8MubgeVFmXbLb+/cFiTnWfuozw2xYUS3zCTO1K4+YwaX2Bn9iBnXCdRiKQqa7seOLLkFvLCES9/Vm2cRM8yGtb3fLH8iYK+ApxY3433OZSlqdmCI0X7RIqLpaB5VzGYlbnijdE1MZeSHLFTolCeAWchD5czM87M+VUnZnfwxyHVI+QLfWMsV4iNTL1HNdPtHkkbbKISxrZW3oEBzxfgpJpcoXIA7m7lS5cpYV291Xxq3CvqJkXZ/5+gMiMXToxHdEmh4m/+cky82QD98lZi7d5Exuj6Gc7fTs62pZwQMiInRl5UoZ8C3NRZlgXSq4JbDk5KLkY42U8I7GKHeM+7zATyp5wP4GWGPfXJKSvdHNUMRMbZQFEFTRaMthK01pCmkF/n6An1e9MC8xMvIq1IQWMh9pGYUbL3w/3FeFtqt/57T6/kMnDFc35jlIzk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(1800799024)(82310400026)(22082099003)(11063799003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kk2KipnSM441Jp4SkLTMjHOVZ99z5RXRXH6rnbGyYYiN8WExQAKzKKJhJ5sQDQpo0yyo6TkQpowHNvd8HGVaDBcC7rYMOJHXo6rTEiL3d+ouD9Pw1q80QmxZhdQupuFELzqTMcUSwJqBds1ikftxhQbBy+oC4sdu8pbbMFSh9JYsu7LhOaG4JxlC9qC6He06Cxw+4Q6Z6XsvMQb0Y2xb53NJ9jm+fNC7SMYjfSNbvJMyEqrcRzDAhXiJaqLEAFb90IrymTZfXWcrbnssmBiXY1n9Zgs8tvKlqrloBqbPjHbtcP1kQ88+GrwpwnaSMLx/rULrYFpk3pgPWQTlbY8ia1dOACnnaAAcok7iQtHxVNX+VyZtJABRFioaM/GD6HjT0ruU3TPlPb3Kl32DTqUu1yeafMzJLZY1yZBCnk5K1aaZSw/za+4cN+1YHkXw9gdS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2026 16:08:51.2629 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd34c352-25e0-4a8c-c825-08deaf7797a0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DF.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPFE4FC9FAB3 Content-Type: text/plain; charset="utf-8" Fix error handling and resource cleanup i.e remove invalid phy_exit() after failed phy_init(), route failures through proper cleanup paths and return 0 explicitly on success. Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms") Cc: stable@vger.kernel.org Signed-off-by: Radhey Shyam Pandey Acked-by: Thinh Nguyen --- drivers/usb/dwc3/dwc3-xilinx.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c index 94458b3da1a0..b832505e1b04 100644 --- a/drivers/usb/dwc3/dwc3-xilinx.c +++ b/drivers/usb/dwc3/dwc3-xilinx.c @@ -176,15 +176,13 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *pr= iv_data) } =20 ret =3D phy_init(priv_data->usb3_phy); - if (ret < 0) { - phy_exit(priv_data->usb3_phy); + if (ret < 0) goto err; - } =20 ret =3D reset_control_deassert(apbrst); if (ret < 0) { dev_err(dev, "Failed to release APB reset\n"); - goto err; + goto err_phy_exit; } =20 if (priv_data->usb3_phy) { @@ -200,26 +198,24 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *pr= iv_data) ret =3D reset_control_deassert(crst); if (ret < 0) { dev_err(dev, "Failed to release core reset\n"); - goto err; + goto err_phy_exit; } =20 ret =3D reset_control_deassert(hibrst); if (ret < 0) { dev_err(dev, "Failed to release hibernation reset\n"); - goto err; + goto err_phy_exit; } =20 ret =3D phy_power_on(priv_data->usb3_phy); - if (ret < 0) { - phy_exit(priv_data->usb3_phy); - goto err; - } + if (ret < 0) + goto err_phy_exit; =20 /* ulpi reset via gpio-modepin or gpio-framework driver */ reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(reset_gpio)) { - return dev_err_probe(dev, PTR_ERR(reset_gpio), - "Failed to request reset GPIO\n"); + ret =3D PTR_ERR(reset_gpio); + goto err_phy_power_off; } =20 if (reset_gpio) { @@ -229,6 +225,13 @@ static int dwc3_xlnx_init_zynqmp(struct dwc3_xlnx *pri= v_data) } =20 dwc3_xlnx_set_coherency(priv_data, XLNX_USB_TRAFFIC_ROUTE_CONFIG); + + return 0; + +err_phy_power_off: + phy_power_off(priv_data->usb3_phy); +err_phy_exit: + phy_exit(priv_data->usb3_phy); err: return ret; } --=20 2.44.4