From nobody Sat Jun 13 03:30:24 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92D5D3B9DA0 for ; Mon, 11 May 2026 08:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778487992; cv=none; b=Tz4h3a11OJquzXnCJ2gES0Y+aoT/68wwsDgz23kzz8+fkrU/66mZ7AI0VixVfTvaKcC3/O69yqV270KXtZ+aYRKUwea0UOoyyQ0nvV8Zd9UixYQ19nZ/xqKYsyoQsIGXbVhuQILW635FO03fOR5lpPBDyg1lSSK8Ob8XzZ+zPSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778487992; c=relaxed/simple; bh=PZd1rOdk1doX7S37IoF3Qx4tSAyYcCh1+fi+JfEvjUA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sE/YkFJ5Zvg4P0a+QtwaaQfvzQA2/d+Y8P/ntV5C2RA/pvVP76gOul8TidlrYuIFWzb+9gEqgst3oI0Rf+F1yGuqhdgeQBIs/4MbXkQUqs8pRUz0zmYFRXlBVO/WLHujkJSeI5mDtwKN3Zua4/AObWwOR4T1SCt0cLQsMdGnbxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dPbIws78; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RfZ3EbSB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dPbIws78"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RfZ3EbSB" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64B7GxtJ619380 for ; Mon, 11 May 2026 08:26:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=s50l1Fr0E/xgiAzqjNMO/C5poeW9+LNooqy NsR41WQI=; b=dPbIws789bBPh8fkjmlKbNpXe/uU9Xh9AGh6udKON2TaR7DuDeJ ERMuxYgZwviO/4z9CrxXQufuAtJF0h7pf8YlgNwSVBSLRsMYhBaaxYmoFKI+sSxy X5PDeMALsLw0IVxvTjop2ivC639Y9fRh/525ggogstLdrwDbcNImy5DvbUY3Uo2h k8kWY9MAzsk8NktHPJcw4d0JTUpfcfgQiw4jsnjE4/NlzIEUrI+8ObjyFZSo9GMG D9hkTVOzodXeiAGiAC2Ihe+0AW5jD9eZbm4cSKfnkE2VPyqVKJZVrre0o/PUOccX Pau3ax1KV3TnaAfNYtJQ/WimPryFsk01/Gw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e2dksubyx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 11 May 2026 08:26:17 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50b220c72bbso66961091cf.1 for ; Mon, 11 May 2026 01:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778487977; x=1779092777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=s50l1Fr0E/xgiAzqjNMO/C5poeW9+LNooqyNsR41WQI=; b=RfZ3EbSBsK9WUcqa7DLZf0LI0XPKoHF7fKbaJzr08h+SIwxAnQtG3XeQTRQ/pYs8yz 0nLrUkokAt7aBM6NMUxXKvxwEatB/Vxbq+ohJAylmfFoRoKgfZVoaBf5VkE9XmTw//cj 3yKucsdCFCGJ3S3Sh01t2kSJxzIxhPowiPhYr9ooJ4L7ebChem0b3JLuDSYNS4FM5Vjo 8G0rR3He/d7DeayXcbgiQbaHkz7+wnzOuXbo01tS1ZEPD3mcQnd1bHJJwCkGs7NpwIMP 7eA7VDURK6CcBCQ9ogg2JFShNB+RUDDq583Y0wCd/tqQih90tRbomzjvwbShRhtFv+wi iKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778487977; x=1779092777; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s50l1Fr0E/xgiAzqjNMO/C5poeW9+LNooqyNsR41WQI=; b=c96Y1+Dfx06n8Jlzq6tiGAXRlNp9Xei9eH4ddBLuv0ORl9y5EEVKuuLLXHYJRuxvlj 5xo4HaOqlDA6n8Yxipm3060+fWt/ffyD2R/YBEPAgcs+hf7d02FfE/4mnQlX7cfwyFib FkZTUB5AgRj2OdgDyRHgyBsqRY0nCRlYtT5DWXrmzz2WquGUbZus0+0vMNhm03eAWNLp tJVz56rnJl2fD5Sex6ZCjMNWVWP/VPK1gb27BbC/750bxAYuPX2d63u+eqaENAmtflER tmHXw3AF8NFsw4H9d67aRws+ej9iBRZv6x02vWZfzoJCngbY9Mihf+SL5Dg/DkAiR7cz psAA== X-Forwarded-Encrypted: i=1; AFNElJ99pyw+kMMhOr8voaanjOuIQTrj8u9Ck6y+jDFAGuwEUSgmW+OV3qg8o+21wX5q2ZfGM+LVgpZ7yAEFy8c=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf/F9zJXqw0Y3c8+0kZM5WS5Ai8DTEXiQcSMicSj9q0rkFXI8h OgTM+t9+bbw+tcsTenT719cQ01r2FAkT0arvPHALZp2MPcO3st4Fu3/95I3r53oDEpAAFvqUQzS JGubySQZ0ZzgDQePT6MYl51+DlOTCP5lMNx3YUVNwrX/u3wdqk3WhtpQ/rDAp6t2qb84= X-Gm-Gg: Acq92OHLfYxasN9bud7fmI2W6llnsPg06/LUyFb/hiFXZ+1AAgULPTu/z2EPREBG/t0 BNKFEArn/f/im//zXC1Zco4A7JZnepjYaRBHkrEngqhKYNIFQ0XPn/JFL3s4nfs/huCAQ3TLLt5 ko7If0WTScnssZH4zPkXJdbwWSwZnCgS3PkW098H4PLEIihYijoEoMRcBusrZMMdLid6ioDK/NM tsWR52ls5zGpfHcgsFnDwfa/8qUIfe2806E0i1xZOZcj/SBvxgKPhX6N7T++2RU/6wf0yc4tbbA mZr96mMJfAhKsjA+jDSaMr1jq1lmaeaF25twSvrIA/NfKKk13sUY3D0R8OwUBU+hj7xMvmIkLtM 5Tczg6cXT9VtI3gqi9cDgJmSG2rFJf9FhsZu1GSVf6hgCE/MlLQ== X-Received: by 2002:a05:622a:4a8e:b0:50f:dd9f:1223 with SMTP id d75a77b69052e-514621e0040mr348676281cf.44.1778487977008; Mon, 11 May 2026 01:26:17 -0700 (PDT) X-Received: by 2002:a05:622a:4a8e:b0:50f:dd9f:1223 with SMTP id d75a77b69052e-514621e0040mr348675991cf.44.1778487976592; Mon, 11 May 2026 01:26:16 -0700 (PDT) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:63bd:c2f9:cedb:aa32]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e80ca2666sm88767225e9.10.2026.05.11.01.26.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 01:26:15 -0700 (PDT) From: Bartosz Golaszewski To: David Heidelberg , Jakub Kicinski , Ian Ray , Carl Lee , Bartosz Golaszewski , Sasha Levin , brgl@kernel.org Cc: oe-linux-nfc@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] Revert "nfc: nxp-nci: remove interrupt trigger type" Date: Mon, 11 May 2026 10:26:11 +0200 Message-ID: <20260511082611.12721-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: fiALp6X--gor38A7oDNOkCSrKrgaOMeM X-Authority-Analysis: v=2.4 cv=d93FDxjE c=1 sm=1 tr=0 ts=6a0192aa cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=zd2uoN0lAAAA:8 a=EUspDBNiAAAA:8 a=hc3HNdYz4iiQibQtTDAA:9 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: fiALp6X--gor38A7oDNOkCSrKrgaOMeM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTExMDA5MiBTYWx0ZWRfX/TltYkBUCK7S 7VKb6kcjGpKYv/xE5Nv+fSmr/xARDXAbKchmFeEz+lE3OUJpp+2sqqykB/Nw2cXjBuqep/Y8eJ2 iHfZk/E6Jgd0BITzlCUKze9ENseaFaUJVwMyjW4gIcZBDflVZjZxo/B6DHjiSh+VPppWhxICWM9 1ZianNy7MF2AlG0Pu7hdxSFsVIEGstx0x2IQl0WAE6cfva1ApMeFk7BxcAapWj7jhmNdYEu084V SZntex3bcPC24zV8L+haCCbbtWe84V/oVL1lfuG17qQF2MPqd44911JO9SyWmlCDNOZtb0pssst TIm02qq2liU7n8xYDoGjXCMCD6QbHhL0zMJYVTWtzNcM3+ac+zwWjityYaLHk70aWPoH/jRVucY slxai8zCBsl0NJoF0JK8A1pxonbjp8RpQlTU7qFi4WnkC8KNef++DSVxUBEg8IrVen0qtEoVWwW iwtXMBMNBmrEbOpNeMw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605110092 Content-Type: text/plain; charset="utf-8" This commit causes an infinite interrupt storm on Lenovo T14s (at least the AMD Ryzen 7 variant) which requires blacklisting of this driver. Neither firmware updates nor the proposed solution[1] seem to help. This reverts the change due to an unfixed regression. The problem is present since v6.19.6 stable kernel. [1] https://lore.kernel.org/all/20260311-nfc-nxp-nci-i2c-restore-irq-trigge= r-fallback-v1-1-9e20714411d7@amd.com/ Cc: stable@vger.kernel.org # v6.19, v7.0 Fixes: 941270962861 ("nfc: nxp-nci: remove interrupt trigger type") Signed-off-by: Bartosz Golaszewski --- drivers/nfc/nxp-nci/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c index b3d34433bd14..e99e1f381028 100644 --- a/drivers/nfc/nxp-nci/i2c.c +++ b/drivers/nfc/nxp-nci/i2c.c @@ -305,7 +305,7 @@ static int nxp_nci_i2c_probe(struct i2c_client *client) =20 r =3D request_threaded_irq(client->irq, NULL, nxp_nci_i2c_irq_thread_fn, - IRQF_ONESHOT, + IRQF_TRIGGER_RISING | IRQF_ONESHOT, NXP_NCI_I2C_DRIVER_NAME, phy); if (r < 0) nfc_err(&client->dev, "Unable to register IRQ handler\n"); --=20 2.47.3