From nobody Sat Jun 13 03:33:17 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959572236FD for ; Mon, 11 May 2026 06:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778482691; cv=none; b=GItqrXgtmHQP6JaS8movmmYzRPUB6ydyK4lJOOhyeoZ+qnilsZPj6/5OFQDdontPjOsI0En/58uYsiPCVFcrqEjZkUbg0z8Iwe40Azy2XRWUzL6a7/2agM5QucsFxIIYzsnCdM6VdRxclDlb8AUqg0s0sn+ynobZ2CyEnZMcZSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778482691; c=relaxed/simple; bh=pAfSR+l7wN17yt/DIe6cWy36lj4IM5O/wJ/9Kftnl3k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tvSevnhf0iwG1ZyoOKMO4PUnrcs8jd8fmcj2ez7vbdtZBuadmXykadNJHXj6J8oaeTDKz8XLXtjFyFovhI/eiPLb7RRs9sNMqV1Tvs/4rMsL2Nh7G4h2nfAmnVjiAZJXAHUcae9n8Z/fqMTtX0EHzScqnMKjaY74e0/+S0Ml3cI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=G7KiyDDv; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="G7KiyDDv" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82fbdd60b64so2958762b3a.3 for ; Sun, 10 May 2026 23:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778482690; x=1779087490; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4r0tJ9SsE9hnxxU34JfGu26fGcFCd7TwYQ/xqlalG2M=; b=G7KiyDDvFxCeMsvIKgsRcZ3MWZGAgIQBAq88EdM4FjOgvB3sDcSwxxeGufqcCGbWqn xpT6DLitSSDzXvMACVQLMTeahy6IlbaCoK55KvzdWd/UDZKSkEMA3qcxjPaPAVJmlVuk OznuusblkBXTd85G/XU4syUwUAaay9ZjpRyM9k5v9kZp75mTaqWAXBxv0fAVEZhvtCNw p6jaX/cwH8bdWu+2Vjnfw1m9d8ArX8D7cIHNp0F0fGWy1kiRE0veMoUb2R4v8sPAXiCH CLCvD9JxYhOIx2Hy4JdGeQlbdRVg8RiJiutZjQSFgoXTpVim6NezMzK1uRxjRmkAOc8i 9ejQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778482690; x=1779087490; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4r0tJ9SsE9hnxxU34JfGu26fGcFCd7TwYQ/xqlalG2M=; b=J10FpPew8Nm2nCf6o8suHTaeRonlM43kn3Hpeq8uLe1XtRl81eNXYugNtWN5BJJgDs yBoL7vhO7jiRAJlFhQHRO3DNM3A5F7gWE6zk+aoAUlJ81BgJh/kVq+Xuozr2yEm1Y9QH H4mzcPyj+Rh91CiGISuO6PBPqufh68k5xhVnWMIztvIPXTaRdOOQkhjcL9QVrL4H9qqM 6dMsJFUOn1Z986Vth8JcensfCFIzou+AFlsfrm8NZAGVYCC9paGGTQFhnG3QrL54eI5m I74va+YOpMr0njGAJ61CbXONXglOPY97wHe1E4yuR9O7NtFSrg449sRqOXr9E6yMahDP XpqQ== X-Forwarded-Encrypted: i=1; AFNElJ/7Nrx6fP3iNqaJjHEZsuIZun6EItO9A3khO4cSeOpa2/wqi6slozKkiwiG4gZVJuenXqoTWGzrD8lrIvY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8/JOkgMyQDMuZM2+sVOB57aUHbO9w8a6xeetOFQBovZ/xUK/D Cu2vo5iJa63uNOfMR42s8tll44+gVFQW9BtyrRucZXSFZE/8C+WIgTaOsYp0mpBF9U71DCfo868 5LDd9IT4= X-Gm-Gg: Acq92OEeEd9GbahVB0Ove8v5h810D/b95y51VS9ZQMgmc/QX0QCgmQBvkdoRXvFXssK nKVduUu1pI5KslONhrCxRcKzzWKqIfqTMlzwsY5jBOpMaUhl/BLpek9cjVF1pLBvppAH1CKv/Ur O3RIwS1SgB1KgGjfs92AfQDaEE47BDOFZeTQk5hCp5cPuZyYonZ3yNBcbMdRd4qpzAFdnZy5g5w lKDepz+d9o8t4kqYkwLFMzrTN6e0qJcra0ChY+BS6XN22NmUeKeU9rNBwu8mPppyME3OwyN6iNq gicpg5R5IEoCDY2Dbc4pV0USVkP/jZ/BwzkbB0M8g3MTrsodDlGLww1tmVRezapoHajr+8F/ojX RTixBxY7HJbnTj63GWDFGGLmzGk/Jx+x5CIXz1UIdGb1BOixGctW21t0VUO6QCkHJyRTN5GLY7m gMILbZGl4WRsWSZ9+8ZsSudtLmMz+/IMeYFYS11vOXp2aNEf2QrBp8uUUtinZdpIkSKdn5st/Wo lGCNMYUeTjleiITcd1HTZSJbH5I1X9TahDG6sunVs7vM7W7SGdewOBhUg== X-Received: by 2002:a05:6a00:2d24:b0:81f:31c3:2e34 with SMTP id d2e1a72fcca58-83e3afd78f8mr8387020b3a.25.1778482689898; Sun, 10 May 2026 23:58:09 -0700 (PDT) Received: from localhost.localdomain ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-839679c861esm23913907b3a.30.2026.05.10.23.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 23:58:09 -0700 (PDT) From: Abdun Nihaal To: ajay.kathat@microchip.com Cc: Abdun Nihaal , claudiu.beznea@tuxon.dev, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, marex@denx.de, stable@vger.kernel.org Subject: [PATCH] wifi: wilc1000: Fix memory leak in wilc_wlan_firmware_download() Date: Mon, 11 May 2026 12:27:57 +0530 Message-ID: <20260511065759.37713-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for dma_buffer is not freed in the error path following the acquire_bus() call. Fix that by jumping to the error unwind path which frees the dma_buffer. Fixes: 1241c5650ff7 ("wifi: wilc1000: Fill in missing error handling") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/net/wireless/microchip/wilc1000/wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/w= ireless/microchip/wilc1000/wlan.c index 3fa8592eb250..4b116fe6f9ea 100644 --- a/drivers/net/wireless/microchip/wilc1000/wlan.c +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c @@ -1265,7 +1265,7 @@ int wilc_wlan_firmware_download(struct wilc *wilc, co= nst u8 *buffer, =20 ret =3D acquire_bus(wilc, WILC_BUS_ACQUIRE_AND_WAKEUP); if (ret) - return ret; + goto fail; =20 wilc->hif_func->hif_read_reg(wilc, WILC_GLB_RESET_0, ®); reg &=3D ~BIT(10); --=20 2.43.0