From nobody Sat Jun 13 03:31:16 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E05791CD2C for ; Mon, 11 May 2026 04:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778473729; cv=none; b=j4vjPmRNs9efw1RxETJ8Xjy7/wsLpF7qJy8atxq5VIInSjGB/54y8J+lH1LDueP/EWjaDzBS314HCMvpOFRLocSz4s7kxHnMMrr9A0LuJFChajNPxihUwZ20lFebjxOa49Wsf/H6RxqqLDGp0JZNpm+Ezeun707FPeyC9Wxrbzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778473729; c=relaxed/simple; bh=ANYTj5FKK8fZ407SEAKLB8j5DfQii61HUCj0j8WodM0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cvitKMVyiy2+ZwzOaUwYcEOF7RRvgxdFDaw9InHG1YHUFB3jXn+nsX4DJtSodNKVcaMf6AdkN567jMyvVEiFBEdySaSGA6xoz9WBjyVzgY2jbYP48Gt4ExflNW8gnGebR2iBkkc8nRDCut/zC6821qxIeyQJ8W65Wo6m+bNBuFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nJrff5Qr; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nJrff5Qr" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2baef9f5ecdso19566725ad.1 for ; Sun, 10 May 2026 21:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778473726; x=1779078526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OGc1sHXGI9jk1rFS6hqXBE05iQZt/kMXUpe8P2KJtOE=; b=nJrff5QraQMjlzEFRP26OmN9jNrrHCfwqY2gJJ7I+zqdWxoMtZpFiPFtmBEbM1vN9U byEP+09tcinqMsd+TXNOBMqBQlPqKQvY0z/WOw9vKBJ0ZtFmgmaiTaKQ2LctwjtR3izp fkBykP+NBH0VdBJjmk8xdcyZlfPqfBSvgxHqj/pC5nLQWorxK4ayb+Pe+fya5sll9NZs hDJAP5P+Y4UqmLD0BlDzhhbYSmpTaYW9CDC63qR0ROe7YM79wFCpAxyq15PPfIqT871w 6VWvHivs5R96vkdYuh0TXK6N3QpXRd9btOudk/N83b1JsXfQNyf3T98XHLF1dPPny5LX LMqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778473726; x=1779078526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OGc1sHXGI9jk1rFS6hqXBE05iQZt/kMXUpe8P2KJtOE=; b=hBI0iItdHIa2k5fjdfIQRYhq90DPP/frOme/5PI5KlZJV7MXFCtiaI2SP8rLBhvfLI NlwACrXzapHbgLHX7NLxNmJmBFYbLe+HNvP0UTRYk1QZrXQFcZtNA/IGk7UlJsG/pS+7 vrKVHQVsRhyRamy2wK+8lXesq+0d4YJ6QORxJmmN8CQHjOy7tYo4CYfnTFbCMPOEFiRN tLLHrYRhqsiZM/jleUWEfRluuXb0mLHRxiX7QY0ZcffYmzCuk+wUJR8U3NncEKbstsPl jjxC4B+JB4za6EoGxrDF9eA5RlXu6Fl4Y6kgh+PY0bDzr6tzRM3oL2EsUwLCy9UQeYLA SrlQ== X-Forwarded-Encrypted: i=1; AFNElJ+3qeK91W17aJ4/16+O4YOFDkoySzogFVI35i+MJs6V7bYJAZt5+09Wu45U3X/zBAkZg30TUx1xuAiux7Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwL1myEAfmQfnGx5wy85l1/k9puPCsfoIncSLWhGzVu+/bEBz6Q N3ZinTds5YFAeFs9hb5hWOfc8Ycc9/WAWYrUAIj6AVss9bB2kCa/D9In X-Gm-Gg: Acq92OEb93tv8QehNvzoHyc4yEc08IuZAGFyi5z/zeg9TyFn3vIdl/0VK3QxW+dMTdU A6KIbwW2o8P5g9IQhrKVLLI2Ao5139phh3BBddVYF1nHdfNWRi7b+1PMnJHCEoH4dQDayN4huNq laIxTR1HmkZDO+yumFQ7IJKnXJAorR6g3itSVa06nWg5EdW1IH5BpNpNkHoQBq78+53Rbn15pZG jScFrKN7wwh6rRnXsS6BSIeA2EyOnuIsJsSbba/W4/nhbFLw0xRkHiFeyqPOk3ndRXV5SDDmTgM GfvIpKUbWAuDzIJSfAXPF/iJ0IaSMNDbYcVd3IZaBLZYAFbvMqHFX1MqTkkOeHNgQpqWKM/1J7s wpDxUWvfG38/PSk2frUiu2qDzO5vdsfq27mEX28DFTz5ewsfVwbsqwwfTNkbe7dFFV9IFHC9ySC +DMKumLrK6iK9YigXTWjVSPVn0hFXIwlu4Fvoc5R+Hobj0tq7Os9BgD6p/LrlA2g== X-Received: by 2002:a17:903:1aae:b0:2b7:88f9:9c3d with SMTP id d9443c01a7336-2bc7a9a0d0emr87611055ad.12.1778473726160; Sun, 10 May 2026 21:28:46 -0700 (PDT) Received: from localhost.localdomain ([115.110.225.242]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d27062sm88740375ad.3.2026.05.10.21.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 21:28:45 -0700 (PDT) From: Shitalkumar Gandhi X-Google-Original-From: Shitalkumar Gandhi To: ajay.kathat@microchip.com, claudiu.beznea@tuxon.dev Cc: kvalo@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shitalkumar Gandhi Subject: [PATCH v2 v2] wifi: wilc1000: fix dma_buffer leak on bus acquire failure Date: Mon, 11 May 2026 09:57:32 +0530 Message-Id: <20260511042732.998311-1-shitalkumar.gandhi@cambiumnetworks.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260510112520.977360-1-shitalkumar.gandhi@cambiumnetworks.com> References: <20260510112520.977360-1-shitalkumar.gandhi@cambiumnetworks.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" wilc_wlan_firmware_download() allocates dma_buffer with kmalloc() at the top of the function and uses a 'fail:' label to free it via kfree(dma_buffer) on error. All later error paths correctly use 'goto fail' to route through this cleanup. However, the early failure path after the first acquire_bus() call uses a bare 'return ret;', which leaks dma_buffer whenever the bus acquire fails. Replace the early return with goto fail so the existing cleanup path runs. Found via a custom Coccinelle semantic patch hunting for kmalloc'd locals leaked on early-return error paths in driver firmware-download code. Fixes: 1241c5650ff7 ("wifi: wilc1000: Fill in missing error handling") Signed-off-by: Shitalkumar Gandhi Reviewed-by: Simon Horman --- Changes since v1: - Corrected From: and Signed-off-by: to author's real identity (Shitalkumar Gandhi ). v1 was sent with incorrect author attribution due to a local git config mistake. No code changes. drivers/net/wireless/microchip/wilc1000/wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/w= ireless/microchip/wilc1000/wlan.c index 3fa8592eb250..4b116fe6f9ea 100644 --- a/drivers/net/wireless/microchip/wilc1000/wlan.c +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c @@ -1265,7 +1265,7 @@ int wilc_wlan_firmware_download(struct wilc *wilc, co= nst u8 *buffer, =20 ret =3D acquire_bus(wilc, WILC_BUS_ACQUIRE_AND_WAKEUP); if (ret) - return ret; + goto fail; =20 wilc->hif_func->hif_read_reg(wilc, WILC_GLB_RESET_0, ®); reg &=3D ~BIT(10); --=20 2.25.1