From nobody Sat Jun 13 04:19:34 2026 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E0C52F8E8A for ; Mon, 11 May 2026 02:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778466716; cv=none; b=HCxn7oHh3+2bB4g345Azfmm0OcdtWzGh4CP9CSQ0JGZXcCBvKCasXtvHpM1wY2Tcdr1hfkTSD4K5WWWwwBygR7nWJ/bLqxHAE2/d14Xj/7geA1681CML/xsY482Q4XnT8dbfiKgVL4xPPkm3wWA8GwLn01We82zlkN+N8qfNlAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778466716; c=relaxed/simple; bh=vb7R1yQybfDBF115WukukZkLEfPQzU4PLJn5yOLJdYU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=mCpegGS9bYEe8+01UUQ1UdYfFz0pNIana0X99kOwgs0hR7dIFQ32uyfYOO+1pM3XDug/PGEQc3B+Jksv7R8F4bb0GesRDKjbjiyNhtUHXV5mShr98uFXyd+ijOmJAGaXKnQ3y/RHaxM3rsj8c/I240fwLIcMO/JF5m3dth8+XfQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gek1HqPh; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gek1HqPh" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-1330d6bb78dso162189c88.1 for ; Sun, 10 May 2026 19:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778466714; x=1779071514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e5dJJxDTuelTtKgmCQMBBHtFYQaNXdMMZt2BZbSIE3c=; b=gek1HqPheBOB9bFcCYRT9YExeVgA3PcLN+ymVQGaoqun8SBGLEaqQ1os1UyKGmZixI /q/lWYiP2SZjPzOidRs2eW/rB/8thuFx80O5sm+tBTo1z2/IKD8EH55LZO9zWXvASwvI 7mtdQooPMcyLJyBc96sHdKrCj+eZ5zTR2p7cAl3mlgtoMx7qFpKk2/3S2QbfYDZmSRmB 27TjeYP2gWxe7orTSZWwtBwkeQZobtT4BWINazuq6qFdDfhaCawe+cWA0+EVLYswqR8b rbdBGW9yojMsFgQ6IU5Zpqy/QxdO93sr9M/a0hROF2jFIEu+WnyA5s3HHRhZnZHAafph 9c2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778466714; x=1779071514; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e5dJJxDTuelTtKgmCQMBBHtFYQaNXdMMZt2BZbSIE3c=; b=VHBNYft37qy2ZinN3pkOAvfrOK8yLM1eipaqA/QEVkUgLq5BlyfNTXGMpT1DvXeGk7 gloU+9TlU/M40mNOUAJASjlMXUGQ6P1ej4mh+c8JU4UIs2k/rEdLChzGy/DgcF3cfgVr HK7yhevR1Z2vv2TYrGHu7B9F97ObT1AN8T90nA+9g/yM/15xi4+su1zVLxBqBtMBok9v 692oJzm/oF2ZKCa8h0HbAa+9WsIHnmRh1FD5sctWKJjqfDSzNbfg3SNgmIp26RJEMb40 KBMzPKFnt9E5Q/gYKAavCmuRNdXqLU84p+J+iI2OgqvsR1b5CYPHvbqdujgE4NOTjbkz DgTQ== X-Forwarded-Encrypted: i=1; AFNElJ80y4dw+LTZpCld+TMpDV55DQy993kC6y10BqfPvZImbMunMagLgmFhmKsem3NAccJLbvJW+uUpHseQ2FY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxw7bbsd8QmjWw5mr8JJsnka45bL0lAou6JMEmuDAMlWsBCE+QK MO9ZSmY+KcZClfjw9WRHbtl5HY86hVbvvKoYXUcR3nf1Nw7tBOOP5DKN X-Gm-Gg: Acq92OGAmIFOKdSUi4oXHJVOjYXVJN9kBvVRG9Q6ku9lMe6RCtNAgZc8eEUzxiaPEMr VmZsD/he+KqtER9kZuN40ocE238WW/gAelqzLDFPnIB7ghaCtCn/oKrAjk7mGoUKgOrMmcEJJuv d51PCHV1WMy/TARmIP6lFXrpX14GU0C5q6kTu8Xab4+TvyzqMvxMSHz2RzFzQQiwECcg3IMjmHs a4AAjKj+dli1KclRJc/gwjlShxKvugw0mmnz9pJBEMhcM0CD5UfuUMA8E2UYar8hyapRRUt4G1D sMYM9k6rpFkMQM9pS5utQDUhDndwj7sYzZnoDpEICYN8ObNbeWE0yo9TmI+BIMV4Bf9Jjde4tXR jj6KopyD0ovKMmu7nouzuhAwe+qAIOUzg5AJMT0Kr06L7dVCSPzCqBaYWq01G3t5qoecWtWKiPE lEUwzhe4fDcW7w84QbiDmPB3nlG+dLqwmSzNRfK/3Hk+fSvUCsj6P6THg= X-Received: by 2002:a05:7022:672a:b0:128:bae0:e043 with SMTP id a92af1059eb24-1318eb4a66bmr10666104c88.31.1778466713575; Sun, 10 May 2026 19:31:53 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1327821fd00sm15597932c88.8.2026.05.10.19.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 19:31:52 -0700 (PDT) From: Hungyu Lin To: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, m32285159@gmail.com, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v3] staging: iio: addac: adt7316: document SPI interface switching sequence Date: Mon, 11 May 2026 02:31:27 +0000 Message-Id: <20260511023127.86113-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The device powers up in I2C mode. Switching to SPI mode requires sending a sequence of SPI writes as described in the datasheet. During this sequence, the device may still be in I2C mode, so SPI transactions may not be recognized and can fail. Such errors are expected and are ignored. Add a comment to clarify this behavior. Datasheet: https://www.analog.com/en/products/adt7316.html Signed-off-by: Hungyu Lin Reviewed-by: Andy Shevchenko Reviewed-by: Maxwell Doose --- Changes in v3: - Add Datasheet tag - Use datasheet name in code comment Changes in v2: - Add datasheet reference - Add TL;DR note drivers/staging/iio/addac/adt7316-spi.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316-spi.c b/drivers/staging/iio/= addac/adt7316-spi.c index f91325d11394..bd92dcddfd91 100644 --- a/drivers/staging/iio/addac/adt7316-spi.c +++ b/drivers/staging/iio/addac/adt7316-spi.c @@ -106,7 +106,17 @@ static int adt7316_spi_probe(struct spi_device *spi_de= v) return -EINVAL; } =20 - /* switch from default I2C protocol to SPI protocol */ + /* + * The device powers up in I2C mode. Switching to SPI mode + * requires sending a sequence of SPI writes as described in + * the datasheet "ADT7316/ADT7317/ADT7318", Rev. B. + * + * During this sequence, the device may still be in I2C mode, + * so SPI transactions may not be recognized and can fail. + * Such errors are expected and are ignored. + * + * TL;DR: Do not change this! + */ adt7316_spi_write(spi_dev, 0, 0); adt7316_spi_write(spi_dev, 0, 0); adt7316_spi_write(spi_dev, 0, 0); --=20 2.34.1