From nobody Sat Jun 13 03:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628103C2775 for ; Mon, 11 May 2026 09:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490300; cv=none; b=VoCF6cm55FfVvtt2oxg0ir3010krGzOwhlM2CKdfXMpsfkVfbavdjsbWKm0akuWDyZJ/EdGsVAn2wDGgOJDFlxxmiGTx8IvdZoJby8p2t8WmjDv7+f4MhJI7wIrUvFlFlVze/e2Hkaggxw9csN/PiasXPZtm5TEkJInpF0shrDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490300; c=relaxed/simple; bh=s5CHPCOeaIw4uL7SeiGJembHNoKvcPqiUkoddyuNeIk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=clLzgODSJD7JKjlei+ANB72XanBbTLuEMPmbTs9o25lslU66z5GdLno2xF8G0lk6K/Q/8wERWctRTDiMJV1vMDm96PqLGKjIQN1/QiVU/MUzrCvMkI6MhGx+HubSNXjcy3PSNiKrMZEyQf8Gn9ThkpGFXg+FZsQ88sg2nQR/+Po= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D/DkiYd7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eowPMFGy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D/DkiYd7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eowPMFGy" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64B4Gl4r652807 for ; Mon, 11 May 2026 09:04:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=CjaVJjBu7KFUWLsssWAqdg /1GILppArgSj3Gd6utzJg=; b=D/DkiYd7i3qPwsm1GhdsUGexLWW1x7RK1S/aQ1 GkTb7KNlaL6R3/Zp5U6JXacWAryVHChB8gdHxtZdWaP3YQRseJj+5hgEW5ikdinw Y7izW3dV40oAEXKQUgu6Tkw36e2enBf6qQYBga268ZLKDny+aMGk4QvJqjrp4O3K dBd4wSpP7ym4aT/Ro1RXnZ9kENwvwFquev2g5zvXQ+Yzngb/VwL97fPzfPgp6ocL IFijFb866KzZ4AtrEdv9WO1fdiIrFz7MYV7WnD8mfufeRgBmKS+vcepF+2ulg8UA tQWx08PplBq0af3kQ13YTyvGUTnz4Rxern/MB+q3NIgn9wWw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e37xu8ye1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 11 May 2026 09:04:58 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82fa7c6699fso5219758b3a.1 for ; Mon, 11 May 2026 02:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778490297; x=1779095097; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=CjaVJjBu7KFUWLsssWAqdg/1GILppArgSj3Gd6utzJg=; b=eowPMFGy2HWtoV2W6sTKrteG5TRCIaTUg2gFCzwg0EwBbyGftq1G1H4V8LOQ6biMh0 SAMbGpKwgeMn4QqEPN8EXdhmAhG/+YOH2LpJyjltYMPZ16HxMCfPV0L4KJz7RdoJZXe4 DiWQG3vAgqcQnvb8M32w9IsQuNSXchy9krmN1YA91b0iADqYaPpLfl9BAhrgW/+S7/jf pCazqVSfDvi/p9Z9BpBSpQe6T4u8+QcQUL8Eo7WEN8YuUOPRkECI+AV+kacIE01D5Ofi CXYbaLT8B93h0LYL+q5h977iM6Yzw2kYItl7YjaYeXlfnWuCR01L0tARpQ+GTNdWBoEc n0WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778490297; x=1779095097; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CjaVJjBu7KFUWLsssWAqdg/1GILppArgSj3Gd6utzJg=; b=sXbfGQ+laVSw8csxc+4pm4kYxdxcAs7obUvgR2/VIH7inebcV/cMb+dU6lSnHGaoXV JSjAagkuax6x6/WBZTkUrChMzqtXVDA1CQWHg4RtaihuNDabTJdOSqPZDMbV4u9H0YSA 4hFJOnena7HHXqp3AhrZpj7oNyHhrjKrukISI1anUjez16VZO0xjesGLzeThKQq5DXcj zm4y5DW1mzv3WeP6DptO8fv5y8Kc1AkLTP0ZCWbOH1BbJMoz+nZPPgm+JHGkiBXcT4hi h+X/spk9JTy6nRFqytO1cyfKc5sO1kgcd6HRl3XsomOIcEoDUlQ9iilgRzCCkxSLip4K yHrw== X-Forwarded-Encrypted: i=1; AFNElJ+0GH9PYMXtuqYhJEZOgA/hPbbJFyNPDigacOvkcye9bLk2max9K0sloooiwxNAISXHASIdXwvjx48u+Rw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1dIfEymp8v9wq9g1juhcuVaYy6UllZUcH6WFlCkotMcgq+yxg AgLEDDMgFKUm5FC3vxjmWmKLYDZYayw/LgYjKE1YlJJJ8zojG4k87J1noAJmqJ+yRlJHhv/uze3 m855s7NbikX+8wOATdXb4rVMsl6AZJIsW9sbTT0e9CecBIAxA+Ygf/dONc9rnRJn4e/UmAVUzgL 4x0g== X-Gm-Gg: Acq92OEB7F3B9EKiHcxwXOVzUPds87JBz61tv5NRVKsubCQ8nvZs109se3w++QQcL+S eSR2IpEIAl2HoR4ww8LEkjnlVlpE4bWlX9F/xXBUlMnOqrhxDmIcqi686cBRvrRyeFa0evUH9SD Pr+49dnfp9xLXON5Z0Vov4y+28GVpzCt7Su2Tybv8I63EZ2J2PyOcu0Lu1Efz8RzMV7AGYKd5zu GGroDQIZQA5JNBBHT/+tR9qAWG7oCVuvpqL+Aw7hyigMSI1VLy3vYhqWZS+G+H5QhThBUjrpUh+ Qq2WzKQUrILDuOYpCixbyS0FqQDwLknrxwxuaOa4ULwyvUaM9YZufHDpr9R1awhdNga2JMdeqdY /u37weaeMfWn5ZpbjHxUlqzOA6syYr2pg6t7v/9kucbE39QnXEoBVW8p1JS/3ezHTYOwc7GELiG qhri7fScmu X-Received: by 2002:a05:6a00:1891:b0:837:e9cc:d458 with SMTP id d2e1a72fcca58-83e39150f1amr8719916b3a.10.1778490297154; Mon, 11 May 2026 02:04:57 -0700 (PDT) X-Received: by 2002:a05:6a00:1891:b0:837:e9cc:d458 with SMTP id d2e1a72fcca58-83e39150f1amr8719883b3a.10.1778490296627; Mon, 11 May 2026 02:04:56 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839682aba01sm19667198b3a.55.2026.05.11.02.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 02:04:56 -0700 (PDT) From: Jie Gan Date: Mon, 11 May 2026 17:04:44 +0800 Subject: [PATCH] coresight: fix source not disabled on idr_alloc_u32 failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260511-fix-coresight-sysfs-enable-issue-v1-1-1b3829748171@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAKybAWoC/x2N0QqDMBAEf0XuuQcmoqC/Uvpg7EUPJJZsK0rw3 z36OLCzUwiSVUBDVSjLrtAtGbhHRdMypllY38bka9/VrXMc9eBpywKdly/jRARLGsNqS+An3Lu 2aaLvYh8C2c0nizn/xPN1XTcxDOmocgAAAA== To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jie Gan , Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778490293; l=1687; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=s5CHPCOeaIw4uL7SeiGJembHNoKvcPqiUkoddyuNeIk=; b=a1ONIgl7O1deFEf05FCRd0MCnROVutvKZRhBz2/3uwA2jAOxPFKog96WOhHNr8qQRX/RJffkI cn6Tt9B2vPBAu4yA/HbBDC/p6pFfU4eq84dScJget/QKM2DxB0diWFa X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Authority-Analysis: v=2.4 cv=EcL4hvmC c=1 sm=1 tr=0 ts=6a019bba cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=OBlOg_wwQlZU_9RpgcIA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTExMDA5OSBTYWx0ZWRfX5mNPtA0T1Dlq d2+6GRAgE3OFXHqbQdhlVPNdcEinCeEXIVrTqs9sNCB0V8NZ5EvVL3puQk8JSxrW3d6WABSl1S9 h00qkyZDH5WqL/5lkkEKOgeMq0arxJJeL70VV+lTQbsGALGOPlIOhvZkfP+0BpWJV5ysbbQ2jtc uUMbBfUW+P2ERSA3D5aHeS6413qPhriApgeeS7GUGox3UbZrWH/Y1aCLG+5U7T3apcrHBViSpU4 hPFMkbZdJ/MVo6G1kIK3Vl1Z6v6rwBnxtWXhLkc3Dr+e6EtiDyCwJ7ysLqHGn/vi0iefq+xEyDG J11Xv+Rc++/NtnBHoSle0KZ+mF2iicWQXYgSRV649uFInSRHQIMMXwqTtgJvqeEHQ5Tcoq0h9ze rojoaZh42oOjgT2ONIUqEcKtZeQOQ4uhZ1kj6Edlf/LXpSulDn6ulCZAlMW0Sw6/yxfa26iiSyL NkaZLPktpbS5tEe3QQw== X-Proofpoint-ORIG-GUID: BVrKqSohB9pWQpNkKnwcukWsCEY4gtFf X-Proofpoint-GUID: BVrKqSohB9pWQpNkKnwcukWsCEY4gtFf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605110099 In coresight_enable_sysfs(), for non-CPU sources (SOFTWARE, TPDM, OTHERS), the source device is enabled via coresight_enable_source_sysfs() before idr_alloc_u32() maps the path. If idr_alloc_u32() fails, the original code jumped directly to err_source, which only calls coresight_disable_path() and coresight_release_path(). The source device was left enabled with an incremented refcnt but no path tracked for it, leaving the device in an inconsistent state. Disable the source before jumping to err_source so the enable and path operations are fully unwound. Fixes: 1f5149c7751c ("coresight: Move all sysfs code to sysfs file") Signed-off-by: Jie Gan --- Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-sysfs.c b/drivers/hwtrac= ing/coresight/coresight-sysfs.c index d2a6ed8bcc74..a5c08fab97a1 100644 --- a/drivers/hwtracing/coresight/coresight-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-sysfs.c @@ -244,8 +244,10 @@ int coresight_enable_sysfs(struct coresight_device *cs= dev) */ hash =3D hashlen_hash(hashlen_string(NULL, dev_name(&csdev->dev))); ret =3D idr_alloc_u32(&path_idr, path, &hash, hash, GFP_KERNEL); - if (ret) + if (ret) { + coresight_disable_source_sysfs(csdev, NULL); goto err_source; + } break; default: /* We can't be here */ --- base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83 change-id: 20260511-fix-coresight-sysfs-enable-issue-91533f26f9bb Best regards, --=20 Jie Gan