From nobody Sat Jun 13 03:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0C2A3C872B for ; Mon, 11 May 2026 08:36:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778488584; cv=none; b=d1LGco/hoW8sgUqJJfBTkZsTGYVLg9AsomOMgEDEi3bKBjRXDYOZ6LVJoufy3otaSksLAplqjUy3g5a9trJLdIo2x9s0Y1h5NJHn2KU2dy//p2ZNQJWYDU17wKSalmLFhvWjkXG6Uo+8noX7kBTHAoB+bYSYxwKCG8LrGX8Tmgk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778488584; c=relaxed/simple; bh=G95APcyEFp0/5bJXcgSBrF6MgJZerwq0+fxABSPj5n4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=DaG1xxEy3nhBrZ6s+TvrZw5H9YEh612+++4L9iTG88DsFcGAKaWmdGbyxaMKuSmbsWWmY2fQwSHACxBXMSivJ+nmqfIH0mnH2eezwcB3IFN1t/KA9wACuZe2Qb4d1H5p7Qd82wFuWc66gT3dQmuF3aKW2rsF0f0pteXNdUvcaiA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pPRnR3co; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BeRodaxe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pPRnR3co"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BeRodaxe" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64B7AEIm1258762 for ; Mon, 11 May 2026 08:36:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=8CFeAPjvnNUNUQRjkTC0u2 CkdRKw65Q2AJD3I3iWzcw=; b=pPRnR3co7WesETzFc/iUoJbLRSfNmPQs8aIxOG 86kZKoj6UKlt8LS5V4EXK0VHcbLdPJBNPTaJzeke2pZFe/kO+08xrCRLeO3bWbyC S5tt9wdyDMFpfdMao4dHrklmSC2c1Dn0Jf7FrxWVo1Nhkm/8e6YVkWmmDtG2fr9g 8KIMhmqGGPhG46vNbTku9lJVh44OwaYGJN2hO3nTF2m+yxbt5mo5DcopNMsmq3zZ zJyVsoySbiklgR0w7g88UPvxgBOcdLcP1o1Ih8/CqsL6mnjloyFWjtBYzcINA00X Nc1KQfX6LuECsREyPGgid1THSe8vejawRZIWm1CEcd9jxoiQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e3ag20a2k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 11 May 2026 08:36:14 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8eabf08affaso717830085a.1 for ; Mon, 11 May 2026 01:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778488573; x=1779093373; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=8CFeAPjvnNUNUQRjkTC0u2CkdRKw65Q2AJD3I3iWzcw=; b=BeRodaxeFuGUoGRqXeT8TS5kPyueQ9TzNQDb2pFqFBBwmq4P3l5oUrkQMpi4kxluU1 SbT1VxiILWIc6I6leTXGBVyNBhI6TAOQXINE94KIwuuUg1efn1sqdO91NqLVJ1EkZGGn HthH5ZyDVfDajq2NtQypmtYAncHBPTbjDYW6NxKeoDDbSuOxZnZzwZUyINSGbqFRxRkT 5CGjfUekbmH7ATSi06SPaO6AKDZOqPif1nhzynv/Pd86oCQf45wExAYqGAxVUXmxuP4I UOqV1qsHwQRiM6c0rK0NM2vgIg+rUzcbBwzoLbbWG18ACGme/5FcDr4nsZWY9L9AVNNG QhQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778488573; x=1779093373; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8CFeAPjvnNUNUQRjkTC0u2CkdRKw65Q2AJD3I3iWzcw=; b=T3NGfnI3A+sP6vNncrn3Zw41GY5Pry3Ep0CoswZEmVRISSOrGTy9Yi23g7Kw3sA892 UMky+AQexm/Xwy0U3QjBpH7YBI5A+/lvM3TgvftW7IIKU+0DJjNhl1cRdLbfQCD+tbIy /kyqjH0jHkJnTbqCwcSWUhjk/5BdcUwLi3sCEN3628hl33oR9Tp657990C9KyRG7mdvN bIyAC9Uqj79Wu3eG4gHXbLGeMAzejJaWIheEHdjXfdu6m6k3w/k2Blb3P/C80wAUPQAn EyN/KgaRIHuzgC8zcHZenosqXOxJDw9EL6SjMnfggvUC8YK0xKa6adJLo14auCBvXswd bk/A== X-Forwarded-Encrypted: i=1; AFNElJ/80SBN1ctINYKLRNRb0hmbhScjPK5mjm9jsyJZRVK6+n7YJolnanQcH+LLebQIUGrBdVxFK6uSTft+5nE=@vger.kernel.org X-Gm-Message-State: AOJu0YxQX4jJz5RJ2VByhaN8zVfw4GJBui/91qMqfxX4DhstwgKHUQKw n+PLSZUWgGdrOk1r64yPkTr4hVCtEyxznwDI1ofajPPi7ApitWPld16jn5CjJSto8CSar/fHrcS ylI3E52HWgR5NeszrYQxBIfJD3Odz6/EMf+BLcDp1pxS8PINivECm3vA0AyvSrT8fR1A= X-Gm-Gg: Acq92OGQrIOLZ+IW3+NC11UENapaP0qjFHVDE0sNn4kYRPscDXlIlP7zggL7U1Lbx03 /j9SXgXcFbYhfJ64XbT3Vk1LXC7C2yvs5QNf4TIHG+TtDS44kPYquRs8WyW2WW9G+Xh508JoBwR 21mYiNIKk/nl8vmEjv6H3hruMZA307ryTKzcM6ZnPOSKgVFVHYzk79/UEYbfURDrv0blg92rold MtNiTyaQDI2dqeWj3AsH1QoelQXwyE8mYZam5QU2QXDAFqHJdf5UXeOdRWr+S/rsn6SsCXUj/YG SVcGacUnV7hB8Mp6bONHFIcXitGsPmXimPPVSqc2Is8faafYTo9o4Ius5cl8qelsLJGOwoaGmFI W8gi8RJV8A2jKeE2Cla0r0kbN+We9zttgAmpzjalV+BzqEeVDEMg8IZwCt1fKjdLFxKQ5eNzlUT PXe1C4PYs= X-Received: by 2002:a05:620a:414e:b0:8cd:d872:c2c9 with SMTP id af79cd13be357-904d6cd5d09mr3515026385a.50.1778488573456; Mon, 11 May 2026 01:36:13 -0700 (PDT) X-Received: by 2002:a05:620a:414e:b0:8cd:d872:c2c9 with SMTP id af79cd13be357-904d6cd5d09mr3515023785a.50.1778488572998; Mon, 11 May 2026 01:36:12 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-907b8f96cfdsm1033134485a.15.2026.05.11.01.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 01:36:12 -0700 (PDT) From: Yongxing Mou Date: Mon, 11 May 2026 16:36:03 +0800 Subject: [PATCH] drm/msm/dp: Skip push_idle in atomic_disable if display is not powered on Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260511-edp_suspend-v1-1-128555968d7c@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAPKUAWoC/yXMywqDMBCF4VeRWTcwk9RUfZUixWQmbRZemmgpi O/eUJffgfPvkCVFydBVOyT5xBznqYAuFfjXMD1FRS4GjdpiTaSEl0fe8iITK5RrzUiE1hgojyV JiN9/7d6fTvLeSnQ9R3BDFuXncYxrV0nbsCZPN3RIzBKMtQG1cS74YJ2hGtswNAb64/gBnKnkP qkAAAA= X-Change-ID: 20260511-edp_suspend-0e45d0110633 To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Sankeerth Billakanti , Vinod Polimera , Douglas Anderson Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778488568; l=1630; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=G95APcyEFp0/5bJXcgSBrF6MgJZerwq0+fxABSPj5n4=; b=0PsT5i264kqig8JC8UFwbXDdRx0p/GuaCxwrgySL2KQGz4npCalLRT7tI+3sx5kk4QEDumKJR 9OygBOxD7DiBSW8ZwnBqWAMom/GJAP1EcCI0NFPQoyrAFG1QVS4N0MU X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-ORIG-GUID: C-HJwocYpt-8z-rrTigHHSsqeL3mycz7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTExMDA5NCBTYWx0ZWRfXw9pk0oLvPoCD oaLfeO+GRvcMSOydA0mdezU++bT1VJLLHey3oybLuXX14++adyD8jPmP/X6rnOpvDfXmWaxF7SN +v6PN30VYjFuEXrqfhPImxxpqXipPGdvksCRW/rfql1hE+NYbFrzfADafi1ePKVPp4+fnuwvFS8 cicIm+gpIzSEJKgxv5Osu5rl6ALjkLoa4bZ6K4ysX66qPAq7QZ6XhyX6EiV0dyAxnGqezxeeZJo R2NnKlpVJ01X+HjMcXJbfBuwdG4BQOTZOfDr9NH2Jzm6f4AoOMNfCflc/yqEHp9RP7H1Z/OVB/M Lakc00gDn7lObKCI+yERTkIaP+37zcObF7FeNfE9MWG0SCelCNxjXP+JKa0/eBsrXIul+a5mlzh ZMy9Z1XC79lJwV0bFMeu9kIyDTMkD3CgACshmgIx8mTtcuIgZvuHr2bDMHW8bQ8GVP9ee0zaXX3 S4WzchmBPrgcrYrwvpw== X-Proofpoint-GUID: C-HJwocYpt-8z-rrTigHHSsqeL3mycz7 X-Authority-Analysis: v=2.4 cv=NODlPU6g c=1 sm=1 tr=0 ts=6a0194fe cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=aJ8XEeGOS4McOtPK9YYA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605110094 On eDP interfaces with no panel connected, panel-simple-dp-aux fails to read DPCD over AUX during probe, leaving hpd_state at ST_DISCONNECTED. msm_dp_bridge_atomic_enable() exits early as a result, so msm_dp_display_enable() is never called and power_on remains false with link clocks never enabled. During system suspend, drm_atomic_helper_suspend() still invokes atomic_disable() for all registered bridges. The resulting write to REG_DP_STATE_CTRL against an unpowered controller triggers a NoC slave error, causing a fatal crash. Guard push_idle with a power_on check to skip the register access when the display was never enabled. Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 1b3cbf4016ef..51b60eb9c2df 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1660,6 +1660,13 @@ void msm_dp_bridge_atomic_disable(struct drm_bridge = *drm_bridge, =20 msm_dp_display =3D container_of(dp, struct msm_dp_display_private, msm_dp= _display); =20 + /* + * push_idle accesses link registers which require link clocks to be on. + * Skip if the display was never powered on (e.g. eDP with no panel). + */ + if (!dp->power_on) + return; + msm_dp_ctrl_push_idle(msm_dp_display->ctrl); } =20 --- base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83 change-id: 20260511-edp_suspend-0e45d0110633 Best regards, --=20 Yongxing Mou