From nobody Sat Jun 13 06:05:27 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 393D021D590 for ; Sat, 9 May 2026 19:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778356605; cv=none; b=LeBkrVIrJRx6tNcPiv6ZbsiCtmzRzVxJjntXOo6+3G05vYDewyqfUafzhIp7WHDODPRRPiq0s1nSzyJ4Xw3YZ5LHGAuFiV5s4xwjwDktRe6UEtYMDya48qauLP8hSmtdNyR/CJcZ3wuDnrLCj3/h7wWtz+MPSyHOk6I191vGs1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778356605; c=relaxed/simple; bh=gukTiYkhf6zgRkiqI/M4+UporFH8ysDTdKdLcASqpXs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RZh2UrWHPFqXWtVSEwJCHpQvOdgO4prhFGupdy/QYKrYOOIRhCtpOu+6OK2WjhGdOvLWK1tG7DmJgEBeJPNN9L1E409qNirCHUqYClX9haWoEDoPFGGlBSmKLDhlzkhuRQ1H8dIq5+XhJWDc7c8HZcid5NVeKVXnLE/C5V+vQwg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JjXcB36C; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JjXcB36C" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-44c350a5b87so1856117f8f.3 for ; Sat, 09 May 2026 12:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778356603; x=1778961403; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=nKiaZuFuBrfeYgzxGRMsLy+An4o+pYh57uREy1jun3c=; b=JjXcB36CNB9x4PM1jCIlOA9TT90XzcxIrY2Q+BFNBeiWPVnKNJOIDpt5OZp2aRYoVl iLm9iFKFa9zC4QN9QzmtrqWkGoWgiyptMdyF93oBeazyV2yqJ72w+xpkGGn3OQBbLJKb Q/j0PcaelxmJC0o2uCbZMq0VQBeML4/PCgBRTwQKYUo/aKISKTZhTZZJgbbRY56NOzAh CADf7kSzGyVVZPpxn/FYLCHD+YNXRwuczez8nI2ISwwmEs6p4g0OVlmTSSC9SNKy2zeT 9vlHVUBNJOmmn7jS7uK5HXBVpbrzmmZ2bUX490VGcuCjR25N99i2CfSMZNlMJboEqvY1 kjCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778356603; x=1778961403; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nKiaZuFuBrfeYgzxGRMsLy+An4o+pYh57uREy1jun3c=; b=DhzdkOJwlZ+VMBJ7x75viMcnrr+r4RuqYu7tf/Jy4D7avPc8BLLIJGp0Z+k4i8Wqrf VBaF8rlyhJvtJLXJLfXmqF1HoK+RRa1TEsHqWOUV0ibNAI+rJ3n/F5k0cA7wXIlIdSXV zmGcQy/D2wfDSsf6X4BRy90r2y/eHSSBxjAdZTZsyS5tef08b+XJPChpCDEOl6e8kgUg djG1lRhkNU+NuLr5l0CWXQ4EUP4b5KSQipKz2+rhth+MnLOV5vj7dokmmaGr0R2wtmyR 1Btj1Z6rn/VWy7D4V0qOIPEfPAT7rqUcUqVNYhH33phOcXep9FRq1nmDdp3AJgPMMjbw xtBw== X-Forwarded-Encrypted: i=1; AFNElJ/un82NNRSitj1IMlrGm7gMu5C4bq79KflJjwIgqG/5dDnIAJYO0NGTRFj+Y0WReaU5Lc/wn/MpcL7SsLI=@vger.kernel.org X-Gm-Message-State: AOJu0YxEJJgvnI6CuJz454XBy2BVRAG4JSg3FQYpx2KpvidJDH/ovhGX fbVmAXf818ttJZG/pr0x6xwnKISSI7b/GieGZdd3hxTNS9Ztpthmh4RZ X-Gm-Gg: Acq92OE+XhImbPi6WcKIS2s3xTu0ZBTrHjB/bebmqBu/JRQ0MdGU4ullnlaMhSF4i12 EXs2bDKGCcuF1Z581glvC/ihf4HNqhkx76XKqZUzQxOp+nvsP3zAyZMqBo1YP4MQ7ajKkcGRtEf HfmiNgxxSEs9xOAY3iyOUdC+vM5ihRHJhCnDfJ8ArIdQ4XEPmM1CeZlG5B784xCmP+PE+nRfh/p vr72rytJc0OjcO3RkEaAbRjNPfF5Q3DqCJYndFKZe2xCv91rKeAOWGI+a7KZz6jUxupgMAhZe8l path3TePxtLAVszKcFmoXdK81pMyau3OZH8vI1SCBU+GsZTSjA4IMbVDM45wgCxmAI/1VoTp6Tf VsZ399g8n+vdgjLyM7xGA3N18T+7X3Uot6jMNxSCaBSP9FQqH9PJBQMbpq5yUGMt+2YrF3O71Jp 4+7qT8OWWD6JjOkLB6qfIp77X408r+ogyXsSzthguBKNleAUvuNNZ9jAE= X-Received: by 2002:a05:6000:26c9:b0:44b:cb31:b767 with SMTP id ffacd0b85a97d-4515d2e6d77mr28428138f8f.36.1778356602489; Sat, 09 May 2026 12:56:42 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-454919c13c9sm13904793f8f.27.2026.05.09.12.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 12:56:42 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, jniethe5@gmail.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH v2] powerpc: fix dead default for GUEST_STATE_BUFFER_TEST Date: Sat, 9 May 2026 20:56:34 +0100 Message-ID: <20260509195634.1134277-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The GUEST_STATE_BUFFER_TEST config option should default to KUNIT_ALL_TESTS so that if all tests are enabled then it is included, but currently the 'default KUNIT_ALL_TESTS' statement is shadowed by 'def_tristate n', meaning that this second default statement is currently dead code. It looks to me like the commit 6ccbbc33f06a ("KVM: PPC: Add helper library for Guest State Buffers") intended to set the default to KUNIT_ALL_TESTS, but mistakenly missed the def_tristate. This dead code was found by kconfirm, a static analysis tool for Kconfig. Signed-off-by: Julian Braha --- v2: remove Fixes tag Link to v1: https://lore.kernel.org/all/20260405161545.161006-1-julianbraha= @gmail.com/ --- arch/powerpc/Kconfig.debug | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug index f15e5920080b..e8718bc13eeb 100644 --- a/arch/powerpc/Kconfig.debug +++ b/arch/powerpc/Kconfig.debug @@ -83,11 +83,10 @@ config MSI_BITMAP_SELFTEST depends on DEBUG_KERNEL =20 config GUEST_STATE_BUFFER_TEST - def_tristate n + def_tristate KUNIT_ALL_TESTS prompt "Enable Guest State Buffer unit tests" depends on KUNIT depends on KVM_BOOK3S_HV_POSSIBLE - default KUNIT_ALL_TESTS help The Guest State Buffer is a data format specified in the PAPR. It is by hcalls to communicate the state of L2 guests between --=20 2.53.0