From nobody Fri Jun 12 14:17:42 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66BAA33A718 for ; Sat, 9 May 2026 19:50:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778356260; cv=none; b=NI/oSDWDYXe1hbb54jNqgpGf4T8U1rXFRa1rIKFUsLH+7rjFpFIbhEfoj9oraSzSyPGjJcK7AxfLpdKvvb0stbG5ATY2z13e3Dh40zQrqT9WL4m0zhR0KMyO9ePIWjzQeFff4zJd9iGMOCtlIC3U9FTsl7qUnVqWWYT3QfZpEnI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778356260; c=relaxed/simple; bh=o1EjnzHyZhODTZ415VxWwjtvAsnecvgFKbsv2m0Dmc0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZWwbXysloSpD4DPaEC7FRPdPTzvOZCkJ0FZyanCBcjzB/szZxFeLt9feDoYnD6x8pyyT5XpWEw0xxgOXRUsohKNSrtRHN5niRew/7a1E1on/rCaj6Aof/dK1geqxCZK5svHbNs+lYtOCGlOMoD3z2xTxHbTTEW00JM2507rqdPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ehZEBHjJ; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ehZEBHjJ" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so33465875e9.0 for ; Sat, 09 May 2026 12:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778356258; x=1778961058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=iILYjv1QSXJF3m9JtN3x0yqcia4a4+vFdY5mp7r7BZ4=; b=ehZEBHjJ71m0usptJoUjv/FdcwrJiR5wcO1QZztxi71WyyQBSZ4Eqq8fS5nq9rG/pj AjvOXLmIkFBDisTUiC0ZG16gaY+8Necyi+k1898HtXYXarbCMBo410egvWrCCveq01Pm sFDykKDzblQVp9YuPDFhP3bHmSUzZsOLgLa14YjUE8jYALMRpsKoCbPPRVMgZz/nMidz rH68J7x1l2jC4R8hTJ914QFlWPKEpNz4TDF6bkO/azOVRvejAirXR2MBYbtJ1IhYSJyk uoYkVm/AUabR7lV8tDjLVgDGaIno4ep/gC4egX7O4IXjGoDM3tF7n8d7MhieIVvNBY0y R5Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778356258; x=1778961058; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iILYjv1QSXJF3m9JtN3x0yqcia4a4+vFdY5mp7r7BZ4=; b=nuIl4TvYuI551zqDxtv/slFqvE+zKRjmvhM250Db+QP0JUR5Xv4GTQO1bbqdJfOO2M 6s6aQsN9V0O7fmh96r7F3tPd3jCaUIquTLNAKKFBJE5NYToKPuPxVPVnik2+iymjkznm iE7wDsjiHvlHkV7uT/Eip+Ob64uJtXgpwKP/cHqoRCI6k+oMaEenbEkRMgTo3sDLv7s1 4SLxYdisuN51B6dfPwW553pA/0Ruz9cOAJmkG2gytIWL/SAdQj21vjMNR7K4wnsSTeBG 5vaWV7iEmFv+7Mrz9SocwiUix5fG4otK/mQ18z67ghqrbmhovdD7pPNWRE/Wff3rvGTg FMUQ== X-Forwarded-Encrypted: i=1; AFNElJ+viHOGy6GCd0jMiqrCu9HQOkKANA7mf2aFeSfJEEwM8IVSQQVSKEw0O/PkY60MNDnaHE2lLEGoLsncet4=@vger.kernel.org X-Gm-Message-State: AOJu0YwrTtrf0BeuVDTTGD1nair1ScGHY7QDirkKPAVtZuWMcVzh6dcv czF89sKI4FDj75TouO6rRl6ekFK8rn5VHFxdhNKqAk7b7E8c9tn9il1pvqWTwK97n+bSa7rz X-Gm-Gg: Acq92OFrQ5sfXTN75hBgz99/3Gb32HAjIFMvdzYFNKRrSKB8UID2VxAQDUToJ1G0tEN d/WhtFl9rs9rWs8x8ERdDDEQU63fbZFReV9MAs4J/S8NMqp+Mm1H1A8lwy3RVCPwNzCBMKfruJc d/IUDEfnHqBMMPqOfgQ8Lm80xXjlxsS39Qb16ijST+OMXSyZrWLcmEIgkN9CO5bfov71casPJXd ZbBLOJIJ0b/GNIY7Ez5sa6gF5jMIqd835P/gW07ZtnM/43jMy9xpYr3wcYLSmYK2de9/cMN6rP9 kVGROUqOejmCZw6TZMOMkan8cci7gV2brZvPTArWICLeYc3HGQ/SvZ4y2zcKEa9COt++hHPpWt2 FXS/zCaqs5nCvvWgN6idbGN2xwDYhhxR37/dvPKAPAPIGiw9DDdhXdvJLGcgHyIrbPBf8Kh1jW0 n4XpGtKU+HjWCre47OGFh4ywxxsgrGx6lr3nEs+beBf3QNlqErrERM7bY= X-Received: by 2002:a05:600c:3e05:b0:488:9ed3:1492 with SMTP id 5b1f17b1804b1-48e51f2a997mr309114625e9.10.1778356257580; Sat, 09 May 2026 12:50:57 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548eb75c29sm13958076f8f.9.2026.05.09.12.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 12:50:57 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: agordeev@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com, iii@linux.ibm.com Cc: meted@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, akpm@linux-foundation.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH v2] s390: fix dead defaults for S390_MODULES_SANITY_TEST and S390_UNWIND_SELFTEST Date: Sat, 9 May 2026 20:50:43 +0100 Message-ID: <20260509195043.1133169-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These config options currently have unconditional defaults of 'n' from the def_tristate statement, which shadow the later default of 'KUNIT_ALL_TESTS', causing it to be dead code. It looks to me like the commit 25d36a85c61b ("s390/test_unwind: convert to = KUnit") added the KUNIT_ALL_TESTS default to S390_UNWIND_SELFTEST, but mistakenly didn't remove the previous 'n' default. Then, the later commit 90c5318795ee ("s390/module: test loading modules wit= h a lot of relocations") copied the Kconfig layout from S390_UNWIND_SELFTEST when adding the S390_MODULES_SANITY_TEST config option, without noticing the existing mista= ke. This dead code was found by kconfirm, a static analysis tool for Kconfig. Signed-off-by: Julian Braha --- v2: remove Fixes tags Link to v1: https://lore.kernel.org/all/20260414215651.151228-1-julianbraha= @gmail.com/ --- arch/s390/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index ecbcbb781e40..4bd1023a45a3 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -999,9 +999,8 @@ config S390_MODULES_SANITY_TEST_HELPERS menu "Selftests" =20 config S390_UNWIND_SELFTEST - def_tristate n + def_tristate KUNIT_ALL_TESTS depends on KUNIT - default KUNIT_ALL_TESTS prompt "Test unwind functions" help This option enables s390 specific stack unwinder testing kernel @@ -1023,9 +1022,8 @@ config S390_KPROBES_SANITY_TEST Say N if you are unsure. =20 config S390_MODULES_SANITY_TEST - def_tristate n + def_tristate KUNIT_ALL_TESTS depends on KUNIT && m - default KUNIT_ALL_TESTS prompt "Enable s390 specific modules tests" select S390_MODULES_SANITY_TEST_HELPERS help --=20 2.53.0