From nobody Sat Jun 13 06:00:18 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0B1A348883 for ; Sat, 9 May 2026 14:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336559; cv=none; b=RX/BmmGcjDR7HXYQ8d4vcN0Fo75MZLPZ9j2qn3Fw0U0Nt0lliHHqEBJwlPqXtPcu0FKAFGeD6y3GyZaa4rUmBvTahqo0/WmXYTLJjN0Mo6jBPYs+3jZrs4gDKWdPDSmvIxVBeeUYFvvlKenBqCPhcdpjx65RytQdXpEH/JC0wwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336559; c=relaxed/simple; bh=Is77detragqtoD9J1EJ55/9pKE36jnstRpS4hdnKrYA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KquG4NJpB9y1U/e5TrXkAevLVF4anU21l37Y6FE5uFYbZZ/Ky0hmpsnTGlQeGGb+eqVkVB8pZRJ3cTfmFK+wXxsvOQe9CcxkI0r9HOATwpNKgwVlqO2XeKt1J5fxAS+ll/iY30B3prGAlbB+Z3JQqenOG57gJrHFJW8YN6hzdPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N1tp/vI8; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N1tp/vI8" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-44c350a5b87so1769081f8f.3 for ; Sat, 09 May 2026 07:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778336556; x=1778941356; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/tUYnfT7OoYNSnANZCAI0KuF7oC4DPgTc2FTMQNskm0=; b=N1tp/vI8TuA0u/ZbBqEeukS6RBNQw/0wJLsqoqdvgQIuJF/XXhRZA+A4YzjhfEieO/ Gru3plEIjtVeN9HZo3n7d5TiJo0XvRpgFPcS2e58utY5GMjA0PDtME0HBgsUQHskm4Wx tHoLEWO0nOpvJETuSsVMEryGB90XpCQdlc/XFlS2eDGrXPB+uk2iC3xtV3GSVmEnn8Ol /au0pzdS8tEnpGIGyolY2XQWOj+DNkkBk+uJIesTpU2DX7by9SoEWpKUxi2m1IBdgWE5 H04u1D/oHyGtGrt+wMo4Q5Q/EsyGZd9Mv4Qqaw1gs4giagz8jGJBermgkeSL17yF384T g/3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778336556; x=1778941356; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/tUYnfT7OoYNSnANZCAI0KuF7oC4DPgTc2FTMQNskm0=; b=tVWNxX1CCqk+tWAxmKWixpEUEfgrQWCAgyOd+LamGhotSjvJWDZrqrLbgFe5KoECZl pOnE/hmEhhywEfR6QgbXlNJpZwGOobyuOfAb3h9g0qpyUoegM5VjxbkNfVSPtzhyKuez 9HvjPHIAGD3GB4UvIG+ZwqQlSUT0OrvVOC5J4LTLz1acdOYdHBtvLGLoYMUrOMO9olEQ f3+UzOrQt5IZa1SnwE0moB83YPGtBi9iIxSuwtUuudxWMl6O3SJROs2UYk3RdV7CNKkt VmziCcB/veV/MwfY6KyQ0CFJeogWOTs0ua2JRGG9RcjHAnvB201d7UPiqEyjoeXvld00 UwmA== X-Forwarded-Encrypted: i=1; AFNElJ+cIkwu3NIDkNZ20oTOU3zZvpVv+mxGgIIEXBXECGcOTNepsBV/KO2J3OAYm0ZKm394KkFnJHmX7fYxCWg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm4mSHrALwrbN19zvM/CsvXMcac2L8m6k0mYFqXHS/n6YeQlvj OX/x1fjmruYuw+gSvgOUIdMjzoYaxcTgiyOGYcaQsxk3TRNxAFGUVohg X-Gm-Gg: Acq92OHgHb55WP3aD4J8rnAeHbwrd88FLkDpuLwVSkGt7vUGOIx13d9jkKoJ4EFrfWo Q5I5uYaOXZpVcP/dHjuEE6Qb+oNICcLqO3rkzO4vY0MvRBbaxBd5M5y18xAvkxnx+lz3f2PGkgf tsxUXoQBXI9W7TZLt4K9wmK701QfrkXy8zWDdGbtb9wgHZZwmpdlBu3ofIr/ipWRRQrW0vaqPZv 2Q8ojLSuph7vkt6TcryUKcDnrDhdzb0Vu97Fy2o6J7hlEtIloliD2uIWoTmliwpnM/j06HXnI/D 5YAX1VKnIY8QbZU1cdlmpPtI1+Cz5KlGoGEzm3yInyqwaCOYRGx87jMpXqI35iJGi4pF315+8ju DxMt0Z8X7f6kQL6cSR/n/qYvkDXpzWAy18s8AIW8d9hxyOcNlIEF3BqFTykdgKyRZiN34ec+5UL c982mXdaGJHzR4pqfxWuAXtEg3n65JZc2LqNidnCTvh2bGJAoX/dGMCkEedLtEn3+eywaf X-Received: by 2002:a05:6000:2c0c:b0:43d:7e11:1b72 with SMTP id ffacd0b85a97d-4515a6c32dfmr26267242f8f.9.1778336555910; Sat, 09 May 2026 07:22:35 -0700 (PDT) Received: from DB-07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45492271510sm15127763f8f.37.2026.05.09.07.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 07:22:35 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v3 1/5] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Date: Sat, 9 May 2026 15:20:39 +0100 Message-ID: <20260509142047.30302-2-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260509142047.30302-1-0rayn.dev@gmail.com> References: <20260509142047.30302-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The AD5504 output range (0-30V or 0-60V) is determined by the R_SEL pin. Use standard output-range-microvolt and range-sel-gpios properties to describe the hardware configuration of the R_SEL pin. Ensure mutual exclusivity using the not/required logic. Additionally, add missing vlogic-supply, clr-gpios, ldac-gpios and datasheet links, and provide a complete usage example. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> Acked-by: Conor Dooley --- .../bindings/iio/dac/adi,ad5504.yaml | 39 ++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml b/Do= cumentation/devicetree/bindings/iio/dac/adi,ad5504.yaml index 9c2c038683b4..e0123dceaa33 100644 --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml @@ -10,8 +10,10 @@ maintainers: - Lars-Peter Clausen - Jonathan Cameron =20 -description: +description: | High voltage (up to 60V) DACs with temperature sensor alarm function + https://www.analog.com/media/en/technical-documentation/data-sheets/ad55= 04.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad55= 01.pdf =20 properties: compatible: @@ -27,6 +29,29 @@ properties: maxItems: 1 =20 vcc-supply: true + vlogic-supply: true + + output-range-microvolt: + description: | + Specify the channel output full scale range. The R_SEL pin + determines if the range is 0-30V or 0-60V. + items: + - const: 0 + - enum: [30000000, 60000000] + default: [0, 60000000] + + range-sel-gpios: + description: + GPIO connected to the R_SEL pin to select the output voltage range. + maxItems: 1 + + clr-gpios: + description: GPIO that controls the /CLR pin (active low). + maxItems: 1 + + ldac-gpios: + description: GPIO that controls the /LDAC pin (active low). + maxItems: 1 =20 additionalProperties: false =20 @@ -34,9 +59,17 @@ required: - compatible - reg =20 +allOf: + - not: + required: + - range-sel-gpios + - output-range-microvolt + examples: - | #include + #include + spi { #address-cells =3D <1>; #size-cells =3D <0>; @@ -45,6 +78,10 @@ examples: compatible =3D "adi,ad5504"; vcc-supply =3D <&dac_vcc>; interrupts =3D <55 IRQ_TYPE_EDGE_FALLING>; + + output-range-microvolt =3D <0 60000000>; + clr-gpios =3D <&gpio 4 GPIO_ACTIVE_LOW>; + ldac-gpios =3D <&gpio 5 GPIO_ACTIVE_LOW>; }; }; ... --=20 2.47.3 From nobody Sat Jun 13 06:00:18 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 166AD3932E1 for ; Sat, 9 May 2026 14:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336560; cv=none; b=rwtWO4Aep0d+xxxerwpHXJpa60ao2ShNFb8KAaFmM3ZeWLf7mgi39u2+nvMZbAoTqiv0bi3rOEF+8QVzpnqgq6VxndZwr0mqCqkFCPhuuw4eFO0sK7JRa3x1zXWV6A8uy76x1ebHwBbVR1w8pfff5q1SotKUNC/ToZEf+/Oat9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336560; c=relaxed/simple; bh=E2/2xrDLF01RqPtbbjfr1THrdhR5njO+Hn8BI2MmETM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RspvdJYAReBajZ5/qebzfR/H5IxMUkfhxztBUIFdXf8ftfvoCToLlAxPYAFxChvZ2DkCl+q7/UtMp6qiGOCFGBu+IfCDBy/nLSQi9fMVjidBMrV1PySdikrxfczPDn30nrX03/SAUnd+40QaOFLX+ffQsq1lh6dwz3U99BoqeU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BftjpNvt; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BftjpNvt" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488a8ca4aadso25500235e9.3 for ; Sat, 09 May 2026 07:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778336557; x=1778941357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xIWO8QWny+6F2s+uW0e9ZWzfRgApaENsGndfZ/2xHlI=; b=BftjpNvtV+xYxdx0znm9Q/Omfk66ETiEmge/rNURZi83pOnQjEPjmoYp5amHk8JpDi ZdyLfkY5UKie1qxLCDaJ+qfF8qMGO6K7zP7uC+gJm32hccO11922AyzBiwcUgMyYA4Wq H+ucHXuPlwr0Wwob6vOIas9MmrQb0lQlc4FBILnwOlivN2BwG/IC4plFjcJkXvCgi89F 07OHXXH5eMuqfLUzFcharQWrIJ8ar31DiU3jaBZ/kYFZWck7lb48oTCqpnglToWVhxyC oNB1SKDz9ynn3MOtp2zBvUYp75XtKHji1Z1SiI/F3QhTZLTRem6fc4Tsy5ghVNELuoXX NkoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778336557; x=1778941357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xIWO8QWny+6F2s+uW0e9ZWzfRgApaENsGndfZ/2xHlI=; b=Vl3DaBs8koKmHAbZn4V5OJuf+twM7xfzDiSme90uGAuzGvVGZh3D583HvUX4Gr1SJp RFK8Uq2M4h8yyjy9Uven4mJOnca8jmKLdnEsXZjESJFICUkzTefECSoyvzA0wFuSW49v lUCz/8h21Yj4cbh3FlP3SN2mFMijXwVnjzpoaNJXV570cwZV5ubDpNNGiFXDWEKr7Qis w0qGtRI7InTzKNipvUBDcQGMwslHvDP67NcoKKbX8pDZdUro9AM8k3o4TDr5di09OHe4 3zCbmIn++VUaPu3zQAwYJvSzDPJntJVzg84MrgW1pTPuNeZD7ip5upehIlgob8vQPa8A /Svw== X-Forwarded-Encrypted: i=1; AFNElJ8mrFRZEqYTxU69RF7v/fm9bdeVtfewVNe+dAm2RLXWWUFEfjYq55hQNxtMyJ0VukqhNb7Cv7npwq2NWU0=@vger.kernel.org X-Gm-Message-State: AOJu0YzjK+zkZQAV57S295UBRYCGW4xxR5PkUBDxNc7uw9PTPvfEGRaY ZxtZcOaWQggm9H2Fh8BLUwhsTQ+MCysT5KnNlpZ06Hv4RWzYaZ0/4vQs X-Gm-Gg: Acq92OHKUquN2BcMUvysekOqk5tcjfIT/4fN84cjSmlO9M1x2oQTMdVq/K8X907WZRi NqGHYmhPO72ECvKMBVkGvkEtUFUnfELGXaNyLLsBR80Vk4N2FxSPk+9lyaKMNNTt06BOGpTBfzQ XvVPUgYOWu5N3uhqefKx8CoO0XRyYXlyTc5WI3sIXIKBCuLRqaPHiobd4avQZfL7sl3ZshmfTas GjmZLV+BO/dzqHvMs4WfDBFQ84vey1Q05KJvFFyPeIvE2Y0zxsQ0qHb3qkrTig/ZxJw4Kk4Qzac Lokpl55+58qCbxttpqugUot+deIz94yqHz616kfB0bCQ3Zesh1deq+aroLvsFxZiLgwY6AdraBS c7b+/CmyMIrzoXnIk2r9tFX0Bnjsn+DhLkiTVluI+FIS+JlYNMGSGi1zL0kW3QE+1A853euPKKR LBVsL1xxgsmDe68SzohQ8qu7j/tQ/3LXVohkFr8spqhVCOX3NqawGmHaQlEQ== X-Received: by 2002:a05:600c:c094:b0:488:b14f:b8ed with SMTP id 5b1f17b1804b1-48e51dd89ffmr199033075e9.0.1778336557435; Sat, 09 May 2026 07:22:37 -0700 (PDT) Received: from DB-07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45492271510sm15127763f8f.37.2026.05.09.07.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 07:22:37 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v3 2/5] iio: dac: ad5504: sort headers alphabetically Date: Sat, 9 May 2026 15:20:40 +0100 Message-ID: <20260509142047.30302-3-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260509142047.30302-1-0rayn.dev@gmail.com> References: <20260509142047.30302-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rearrange the include headers in alphabetical order to follow the standard kernel coding style. This is a preparatory cleanup with no functional changes. Reviewed-by: Andy Shevchenko Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 355bcb6a8ba0..03ce37e2c616 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -5,21 +5,21 @@ * Copyright 2011 Analog Devices Inc. */ =20 -#include -#include +#include #include +#include +#include #include -#include +#include +#include #include +#include #include -#include -#include -#include =20 +#include +#include #include #include -#include -#include =20 #define AD5504_RES_MASK GENMASK(11, 0) #define AD5504_CMD_READ BIT(15) --=20 2.47.3 From nobody Sat Jun 13 06:00:18 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D229397E81 for ; Sat, 9 May 2026 14:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336562; cv=none; b=ku75d+M+4ckfyL1wUAKeBmKfAb1N/ZsQssdrBRdYKW5zhxTWQ0pWtTknZRQ2OSan9EGt5S47FII0/TWbJqopYHVbMLh9c2wt9mmnfZbxRVFPgrBEfYnhK8TmR97yYUfFTePD2JACVjJeJ5De5RmrDrQvMN41nOQs0+7y7N+TCig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336562; c=relaxed/simple; bh=JA4MiRw1MJjH7bNhnR6shbkdzsy4pqluHZpVAh1DmGU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iJRjPvMbLlOG/2LU7VHWUx9Rs5bahVmBl1TgBwJY0OpJtuD7nTzAnLMSSUi8zf0+e6ci4PLSmhZWS7LoIk1zElFYG437snXY8BnDjzV96CjFCszmrNKpnNGil7F/Uv2q2XlhH4bENu3/XTjSd4RXtCAfZa6H4Ho5e0m5mrD/Spk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fs2zXbnr; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fs2zXbnr" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so32845765e9.0 for ; Sat, 09 May 2026 07:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778336559; x=1778941359; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CPxOp9tFICZjOEYxN5qhdPtWLZ//6o03lBo1ImPhBvM=; b=Fs2zXbnrXEupnp3kNKMMac5wcRK9kpaPy2PtRKyUANqwxGSV0xpbamWXR8EHIyxBQJ jdUhbzccODLp44ygjv79flBbB6H54rWGskR9F86j1mFFuFT+V6gP6c8Kq3sCzbsFeZuR lrTeglJA779NLo6KvqU0L+k8v7r09VbQkRCqs/8DHAnpTOzY1IXKRBhUAYKpYpfYy9Qr i+azntup870D3OBQ/jmwg7btXQZm0RnIE25Hp2ygSvd64eVIXVF+MnMuh3egT24hIiWe x8k5R6puf/YBQ5y+wgx+Qk8IfTQwgnRCq05BOFS6MGV5vWxpRqG58uAIAJ4tz9hhXAdl I53Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778336559; x=1778941359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CPxOp9tFICZjOEYxN5qhdPtWLZ//6o03lBo1ImPhBvM=; b=D4d87SH4wyUyFy3DbYbYZZ7wBV/5ItbXTCy0WGcQKnPgIHI5iXpSY5jWbo0pXhwp7o 7yjxSBpIiNz2eIij9Ijzviz2iDWEVQBW9soZjqH/Od5VtSiTCOxDRWdxRZp+9ijVSAdj PVsS35HQNl/vbzKXdMo0UqwsbN90Oh4DieL8LhfiUoCfjQ4HCXqOJV6Y+GrXLN6fFKlk cqUnVECkfrDr1CnTuRwrb/mzwJiB48t33LQKPV25HWZ7gc67CoHu5aCEzH1OwM5vCDTE Z99ndJTSKcYP8mWQNgIdRTfDCXPnhX65aRJs1VeC7OVG3uqeXcGKokmdIuCiNJAFETYB vJeA== X-Forwarded-Encrypted: i=1; AFNElJ+j6x5IqRgyF3qhVyjx9vTdpXQKvocp/THqyXG3RjWQCuBm+EcloMpLMC42jem8JbuP3q5eobeDi+vKSRQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt4OGnM/+7mXiomEp2hcGHh4rbhPo/cQkTHlj/2rggjrQfaY+V jwvBwFxTEQcM2MvoGCfI4a2mhnriyHbFtqRq373oH7qy5kcRun9pZynI X-Gm-Gg: Acq92OFjgrtr3hM5MkixK0TTos6i3ZZPnZuD6K45N++G7F9MbugVRr918c00R3ydiFf E7M4VQ00W5Fa6l0WFK+l4Eh6fX938p5OlxYxWu+fqDEhcwsb7Fw2Izw/LwWepz+9LZJBvXxgCFQ Lf96LvxLDzeODe5eYcYuXi8+02K01UL3pSWz/bgHgwU/RRd5CGl/6uBVyJDxGy+7zTuIkbN6Wiu cJ/HExVBSnGJpayytoHOK7/+fZshfz17DXL+0+V2ZgibjWq3dUNRsk2n7VubFr8319kWmn6iyrs OnuYuLvYK+IkJSL2vJNeVQolyeZeS6IxstgnUBFDyNHH8nPkehrT+gdhYCOSs8z18HroJ17oAyO ygmOf0Hh/5SdaVm+NrOUAgQ6IUDNx5g99y/m3pveag0RbQoAFuTpxE1fTTovL35PwIMnyuNewWZ ukgbVt/MeI+Hu1lL9NLvHoBuIcfHNwCCra2TuAhkp1Fz82G510WWc0btlbGy9IU/xHv3Df X-Received: by 2002:a05:600c:3586:b0:487:21c7:2885 with SMTP id 5b1f17b1804b1-48e706acf6fmr45737035e9.5.1778336559002; Sat, 09 May 2026 07:22:39 -0700 (PDT) Received: from DB-07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45492271510sm15127763f8f.37.2026.05.09.07.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 07:22:38 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v3 3/5] iio: dac: ad5504: Align headers with IWYU principle Date: Sat, 9 May 2026 15:20:41 +0100 Message-ID: <20260509142047.30302-4-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260509142047.30302-1-0rayn.dev@gmail.com> References: <20260509142047.30302-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update the header inclusions to follow the IWYU principle and ensure they are sorted alphabetically: - Remove , , and as they are unused. The driver relies on devm_ managed allocations, so slab is not required. - Replace with as only the BIT() and GENMASK() macros are used. - Add for struct spi_device_id. - Add and for error codes and data types. - Add for cpu_to_be16(). - Add for ARRAY_SIZE(). - Add for string to integer conversions. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 03ce37e2c616..57e6eeed26ef 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -5,16 +5,19 @@ * Copyright 2011 Analog Devices Inc. */ =20 -#include +#include +#include +#include #include -#include +#include #include -#include +#include +#include #include #include -#include #include #include +#include =20 #include #include --=20 2.47.3 From nobody Sat Jun 13 06:00:18 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E90F39A049 for ; Sat, 9 May 2026 14:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336563; cv=none; b=kLpoNszH0Uh6UJqwmTPMsI8UMW9zFP7QjkUxlbbIzNG+/MgE6pqeq81qOMDsAcl/CxWPVKuf4xSyaj1xwD6GUBY8GVvlp4i+lJvEKpHaL0F3CitEpcN5O3HhR/CrL4ha8fljS8URofvsbJufJSeXYZmG5OQq4W7u5VEWDlfbKxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336563; c=relaxed/simple; bh=5041B97lUMY1NweE62U8zsBcR/adbKbv4T2M7YYYW6E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UN2MH3bSxZ8A3z5rENrtqYlVCkgGLf1PKjovKpWJ58RefoGZf8Qqbfw+I25FyZPiPYXiovn9zWKB4F8SgpG9EKJLRwUwOU74aQnXNrv9TpEoH7RS5QqXN4d3J28LLxjgMhI3NmQfw0eciJiGlwkLxh8kCo3xhPUUs1m8J0hiv6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T6vVYxRI; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T6vVYxRI" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-44c4cc7c1cfso2307368f8f.0 for ; Sat, 09 May 2026 07:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778336560; x=1778941360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R4zpzlxVkYdL6pM1JU7oOah1Khvqrfh/u/pFhf5YJ9o=; b=T6vVYxRIPZONQzb82XboHZmB0XDa36OnTXbvUwmK1D9eKBKXMdEOrGV41vm9WDVhoz uhk8JG0cvaoamXgv86KzvoI++oklP79HHD110rNUCmMwy2BmfjyHP112rEyZIp2y9EA1 9VVcm/jX3JiAr8ljkBPMRTKi59X9xEaNQnp5Sl7h6DSIbf0jQT46P6nzdlVDTFxggPFe qvp88lZOkL7zziin3eZ+Pr55muh2AdDzMp4v6CNbZ0GkzOfZGSWzw34L5EXxjfrLGxiY ah3vTPNXT5Mvy+X0zvm21MkWz5FsOnnZG20m3D4kROn6Pp/XVzTV+Ejn5GE0SDtQNHlg TwTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778336560; x=1778941360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R4zpzlxVkYdL6pM1JU7oOah1Khvqrfh/u/pFhf5YJ9o=; b=i94ijrW5cpLZG52OBy5IU4mJpFDg6ck7N3rIBtmN+KGrQhVpQgvj4dTo7twTZ6xJSl wxPbNXJ9FpE9AkdUvAe9A8oayJ68YNK2LfWDBoTDOsGVYXxZtcomPWg5RHI8OJ1+6mWf KJRhGqDTyctrP9JranrhnttloIQfpi1MZSm/lIgCiX20ZQEM6YUvuqiCoEsEDE99UoZp HjcyQu+Vc+/+hed4HHuOzskfAqqUOwr93O/6P976DGA78fndnIW2Tf4buj00Xw3cIIRi 3bewS2hnY+XoOiCCaIFSWUZsICxvFuTmgQJSTIhPvNaJhHPXwMzusr1nOiVXFzWnhsVa jQSQ== X-Forwarded-Encrypted: i=1; AFNElJ9SKU7Dvh49Qi5lJgG4uHfTdPS0CkDueC++sKDiBpTxlAtVd6J1+Vxwnf1T+f6e0skisFpF/7CmR3EPDwo=@vger.kernel.org X-Gm-Message-State: AOJu0YwFJ2/z24KMpOjSvF507COsTbpBxznVH0fDEdN8k4WjpLbXBZwl X5KWn8+Cmb1tlwScCoA6aatU+PBgvD+k2TTgjFdnyaJWHZFanPL9xMaj X-Gm-Gg: Acq92OEBnPMbrKCVWo+7DEjS8KPspQaqkRmul8JhOzqDybS0XeGPNS0bkm/9L6eER1m WbxCOdf6crw8QJCR9To31SH0NOFGRYXq8RFenzArWPHldWetFYxq18Aqc1kp9jiXWunrkuZJYag q2WJfsgRlFDvywH2CDn8Hwt1U0Hq1GQ031zI74RmcY2XPBhr14Q2ZUn5AIrtrh+4oEXj1/sU00I BouxVC+kk8VVtUMd2vUI3oZcmpbEe0mybxhQrUtCtbM3DUUX8T2icWY0FdP7EifKC/YlAzQSi83 onAFlc1+VyDzWZTMYU9ouUJMkZIfPAWW7SnbSCcQugT/Tkgi1u4Amer1W5LIi3l959J2sJK6QCQ D0kSocAi+DaF2ciOeYPLFLO/pWyexlgl9BIxtWmf+f7yo206SIKP4D2eZqKWNUnPo5Qidzz64zP 0WWLjbVvHDlLzueTJoSAcHm91oOnOa65lbafSy42m1TrvQGzFrhfwOOcHQLg== X-Received: by 2002:a05:6000:2386:b0:43d:1cec:4767 with SMTP id ffacd0b85a97d-4515d9a02c4mr28221085f8f.36.1778336560387; Sat, 09 May 2026 07:22:40 -0700 (PDT) Received: from DB-07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45492271510sm15127763f8f.37.2026.05.09.07.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 07:22:40 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v3 4/5] iio: dac: ad5504: introduce local dev pointer Date: Sat, 9 May 2026 15:20:42 +0100 Message-ID: <20260509142047.30302-5-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260509142047.30302-1-0rayn.dev@gmail.com> References: <20260509142047.30302-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace &spi->dev with a local dev pointer to shorten lines, fix alignment, and improve overall readability in the probe function. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 57e6eeed26ef..9e95da6e49d6 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -273,25 +273,26 @@ static const struct iio_chan_spec ad5504_channels[] = =3D { =20 static int ad5504_probe(struct spi_device *spi) { - const struct ad5504_platform_data *pdata =3D dev_get_platdata(&spi->dev); + struct device *dev =3D &spi->dev; + const struct ad5504_platform_data *pdata =3D dev_get_platdata(dev); struct iio_dev *indio_dev; struct ad5504_state *st; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 st =3D iio_priv(indio_dev); =20 - ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "vcc"); + ret =3D devm_regulator_get_enable_read_voltage(dev, "vcc"); if (ret < 0 && ret !=3D -ENODEV) return ret; if (ret =3D=3D -ENODEV) { if (pdata->vref_mv) st->vref_mv =3D pdata->vref_mv; else - dev_warn(&spi->dev, "reference voltage unspecified\n"); + dev_warn(dev, "reference voltage unspecified\n"); } else { st->vref_mv =3D ret / 1000; } @@ -307,17 +308,17 @@ static int ad5504_probe(struct spi_device *spi) indio_dev->modes =3D INDIO_DIRECT_MODE; =20 if (spi->irq) { - ret =3D devm_request_threaded_irq(&spi->dev, spi->irq, - NULL, - &ad5504_event_handler, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - spi_get_device_id(st->spi)->name, - indio_dev); + ret =3D devm_request_threaded_irq(dev, spi->irq, + NULL, + &ad5504_event_handler, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + spi_get_device_id(st->spi)->name, + indio_dev); if (ret) return ret; } =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad5504_id[] =3D { --=20 2.47.3 From nobody Sat Jun 13 06:00:18 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B03399349 for ; Sat, 9 May 2026 14:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336565; cv=none; b=BuycPLURa2hUV6FWv/VNgMBaagR+Q5aU/842C++bonF5NTpad3zR3O65bwg6dyrUwC0YF3jbreD4l+Z+r54O4NsIHNovyrHsMLl8kTfZAIC554SRfv7onjIya/l7nVpfoOB+/45VQ1Unyj1ebx2I7bAsBl2yrkqPaadPU7D79UA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778336565; c=relaxed/simple; bh=bHsamKdNXaMj15lw5nYewmcYz2vhqiWqJ58ZKCBpukk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l6FUkhk+9gJoDyGMyBtUUKcTPd61gdiSowGxg+Ykosl6vpYnEDYaS7vKEPF+R++EDPoE3QZb8rR4PmA/olwl3d55iLpgmWwDLhdSqASfsto6svIfDJ3QU5ArVGhHBtA7Fn7vvpR3Z1wdHq89NWqS8TbjaAZiXUw+JLcyY3Ne9HU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F/nJE/AS; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F/nJE/AS" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43d75312379so2521809f8f.1 for ; Sat, 09 May 2026 07:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778336562; x=1778941362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FsAbPVJ/lQzgpp89tG6qinhr/xePS1xjYRlJbLcWEiY=; b=F/nJE/ASpW9Re5tQUy87kr26Tq0gozG6ug1aC962tijgRq4cXaPcDNDb1PcIQyj6v9 xZ09yt/oQJNA1u8h5Bz54XCCdJvdSlapfe8Pd0Z/vjsKwTga0s7jVyY1FLLPe4QozSwg xqV0wDOcp6u6PwhO6Y5WvY+++jhJqsY1J26fYcaJUsG/2NP35wmxRos/j7nZ4wPG8W1Z g9826T4L/SsXRvWUALLEvrMnFVwGyDTLVGTCQh+b1NIpALM3TsxnNDIafK0gP4+gNgmt sc7v39FigwcMIoQIPL/XYhKek2D1njxPxTK6jFav7Hb9kExjf8X2kun4oK6nD5Aze+cf rxrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778336562; x=1778941362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FsAbPVJ/lQzgpp89tG6qinhr/xePS1xjYRlJbLcWEiY=; b=tLgnp/Il1kdaXWeyut+wcG3YKv2VIPrQD0JXy4+JITWV7U3zhOW+oDzgvbWvlduJjN M6+GUehFUDnSUmo0eAdH5WI55psswTpR5AXDsGm24jBsFP+W/7TtlVB+QBCu6qcqrjJk UkdF9qfLZrRPXgoAu3HRz7vFSvgpOfQ/XgO55WgRO8ee/+vfb3JOObPEZPOeUO2RMz7Z 61CUF58W3/scpPiBgihtNWOF+dvm9MhJVpcgBMu+Ggqctc0Zzec6orzueMQCKCXYdkuW eqhlaQJDrwXufxN+U3Kz4ynhYTcPgo+Hz7/Tq6xuR+B2PL/Tm6U4ZxTG2yW3NZwKM38j RIrA== X-Forwarded-Encrypted: i=1; AFNElJ9LRBrzp7UVq9bvxNnDHE92OQS+AOUBxiaN55faosEJJC9Cbw6bfGZPEiTINNdfO3QSZeriU3e92CY6nF0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4dem4zwrw3U/DoJOtYMDEZ5IZ4vZDrWy1jzgCIo6F40bLRAyF 90CAywfPDPWmQADWYjnAyeEotGWezzqWolyb4r0VOLAgYYX7KI7VjrKV X-Gm-Gg: Acq92OFt3Mj/N+Wn3J53Hj5WnIrW2WqytX2f1uvj07w0pbAU2neQhnZSa5F4ZlJPxN7 8zCbEuANtLyIPU+f33F06hDte1BddMRTF+xRCDjMqY4rXmkUnHcLl+6Z5JSHC7g/YzWxgzuhWtR i03LG3o2L/p81ZvsOAMBfu10VGxARLL4fQS1hlw31AfI7TgKJfQQMt7beNZ25gcxCky8xph5MrX vSrpmJcgLG1OePuCLA6AjTA2WmL6d+QebRTkDj5y2GXf0QPyJ/PYIk2OQF5k7a+Cd1PY3VmSAvu zYJaygNNiKnI3SnBslEVCn+jDEAwjz8VMvQNuMGvq3sfF2BIfhg+GuRH/bp24Sz1/lH5ahPSpCK foYZdNjIvhYnSjJ/qQ9V+uWqFpHR8k7K08utv8gKvqCwTgkHyCYBweoVLmVbbZLq1yXmNeiWIpp NyClT3wAIho4mKKZILKOPwqIC+zpuAWEyQ/63n38FnYbq9xATEyhc26jZ3yQ== X-Received: by 2002:adf:fa0c:0:b0:451:b3ca:674f with SMTP id ffacd0b85a97d-452e78b3e99mr13844456f8f.1.1778336561766; Sat, 09 May 2026 07:22:41 -0700 (PDT) Received: from DB-07.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45492271510sm15127763f8f.37.2026.05.09.07.22.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 07:22:41 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v3 5/5] iio: dac: ad5504: fix scale via output-range-microvolt Date: Sat, 9 May 2026 15:20:43 +0100 Message-ID: <20260509142047.30302-6-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260509142047.30302-1-0rayn.dev@gmail.com> References: <20260509142047.30302-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The AD5504 full-scale range is hardware-determined by the R_SEL pin, not the VCC supply voltage. Fix the scaling logic by reading the standard 'output-range-microvolt' property from the device tree instead of querying the VCC regulator or relying on legacy platform data (pdata). As a result of this transition: - The 'vcc' regulator is now only enabled, not read. - Legacy pdata support is removed, as it is no longer required for fallback voltage calculations. - Strict array bounds checking is added for the DT property. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 9e95da6e49d6..040f580b8282 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -14,10 +14,12 @@ #include #include #include +#include #include #include #include #include +#include =20 #include #include @@ -274,9 +276,9 @@ static const struct iio_chan_spec ad5504_channels[] =3D= { static int ad5504_probe(struct spi_device *spi) { struct device *dev =3D &spi->dev; - const struct ad5504_platform_data *pdata =3D dev_get_platdata(dev); struct iio_dev *indio_dev; struct ad5504_state *st; + u32 range[2]; int ret; =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); @@ -285,16 +287,19 @@ static int ad5504_probe(struct spi_device *spi) =20 st =3D iio_priv(indio_dev); =20 - ret =3D devm_regulator_get_enable_read_voltage(dev, "vcc"); - if (ret < 0 && ret !=3D -ENODEV) + ret =3D devm_regulator_get_enable(dev, "vcc"); + if (ret && ret !=3D -ENODEV) return ret; - if (ret =3D=3D -ENODEV) { - if (pdata->vref_mv) - st->vref_mv =3D pdata->vref_mv; - else - dev_warn(dev, "reference voltage unspecified\n"); - } else { - st->vref_mv =3D ret / 1000; + + st->vref_mv =3D 60 * MILLI; + ret =3D device_property_read_u32_array(dev, "output-range-microvolt", + range, ARRAY_SIZE(range)); + if (!ret) { + if (range[0] !=3D 0 || (range[1] !=3D 30 * MICRO && range[1] !=3D 60 * M= ICRO)) + return -EINVAL; + + if (range[1] =3D=3D 30 * MICRO) + st->vref_mv =3D 30 * MILLI; } =20 st->spi =3D spi; --=20 2.47.3