From nobody Fri Jun 12 14:18:25 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3975637CD52; Sat, 9 May 2026 07:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778312457; cv=none; b=Q3Jo1KvzNoIS2H+KzBurXVRlDObgUXa8MagdRZO0Xo9LycETgVhIDQUftDbj4jmjh2XxvBr2/eYfSXj+ZXYtFdh3bIeRGTovFaprVrEgtYFew0SM4FL16hVXSCSeQTbj36nQYmqhXJEDJqeMurghGnX6lLzfHLQxg8h0BaFsEu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778312457; c=relaxed/simple; bh=EGoyfTRmViYp8W+B2y2IxIoEBI7ARsu2cY8c37BHKv0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gyl3H+RW87qfCs3Rsgla56W56x1tHJ3+5WMbZt4vufvBoAF1IaGXaeMFEajuTvZfvxcnxM3OXJxTD6UCEtaS5wFtbxluc8vhPxiSpPjY1uW5T/bGsqrgL/kPeEXwOeHgETlwkrUv/X5AJo3L6IIVsytZc0n/bW5rpjP7p09fqBo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from yzs (unknown [115.199.218.204]) by APP-01 (Coremail) with SMTP id qwCowAD3mmb65P5pU+yvDw--.35245S2; Sat, 09 May 2026 15:40:42 +0800 (CST) From: Zishun Yi To: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: alex@ghiti.fr, atish.patra@linux.dev, Zishun Yi , stable@vger.kernel.org Subject: [PATCH v2] riscv: cacheinfo: Fix node reference leak in populate_cache_leaves Date: Sat, 9 May 2026 15:40:40 +0800 Message-ID: <20260509074040.1747800-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowAD3mmb65P5pU+yvDw--.35245S2 X-Coremail-Antispam: 1UD129KBjvJXoW7JrW5KF1rKw4xKr4rGFy5XFb_yoW8Jr4Upr WjkrZIyFyrur4xGa4IyrZ7u3yIqasxWrsxC3Z7C3WUZwsxXry5XwnYq34YqrnYqFWrurWF vr15Gw4Ivwn8A3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkG14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWU tVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14 v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkG c2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUZYFZUUU UU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCRECA2n+2gklYAAAsY Content-Type: text/plain; charset="utf-8" Currently, the while loop drops the reference to prev in each iteration. If the loop terminates early due to a break, the final of_node_put(np) correctly drops the reference to the current node. However, if the loop terminates naturally because np =3D=3D NULL, calling of_node_put(np) is a no-op. This leaves the last valid node stored in prev without its reference dropped, resulting in a node reference leak. Fix this by changing the final `of_node_put(np)` to `of_node_put(prev)`. Fixes: 94f9bf118f1e ("RISC-V: Fix of_node_* refcount") Cc: stable@vger.kernel.org Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Zishun Yi --- Changes in v2: - Added 'Assisted-by' tag. arch/riscv/kernel/cacheinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c index 26b085dbdd07..6c9a1ef2d45a 100644 --- a/arch/riscv/kernel/cacheinfo.c +++ b/arch/riscv/kernel/cacheinfo.c @@ -133,7 +133,7 @@ int populate_cache_leaves(unsigned int cpu) ci_leaf_init(this_leaf++, CACHE_TYPE_DATA, level); levels =3D level; } - of_node_put(np); + of_node_put(prev); =20 return 0; } --=20 2.51.2