From nobody Sat Jun 13 07:50:37 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AECA3FB7DB for ; Fri, 8 May 2026 20:41:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778272878; cv=none; b=t+gjop0PCL1ILlHdvBfn9UDtsgALBptga9NQJu7Pwo/yP4vkoTgXeDoAonZk1IOno9nc6dGXBJc74xRZNnjt8Aq62dMeIwxA8OWKjrxN96HE77zLsBrEuExoAE6fflNIhAtSLTyUOq+PGCGo4BC9vdAVjw/nFQYlnoexC2zLuoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778272878; c=relaxed/simple; bh=ZejcGvjNoKJ+168GlcWC60GUVbQug+g6EFKGYGUZ9uE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IIFlbleocjF33p8PgE2uw7XPNApakre6Qix4Az9idT00vYhdciXmWtii0QnWpsXyc4YPBboaWR0p1WYws5XNnQ1SDesz3PO92yYAij3qUVU6+FEFwJfZFYaYP22HDPvdHoQMLjQUZcX/g/P+b89etw9NkoNzfrziK2fdPSqqZkQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b4Cwu+5s; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b4Cwu+5s" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-8367df48711so1140893b3a.1 for ; Fri, 08 May 2026 13:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778272877; x=1778877677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cgBGn+2rXtyyJsqVkmH06WkJeLCLcvohOXBffi3wbRY=; b=b4Cwu+5seMU+6TS4m+9h2M/NGcwipL8SZXvUOUalFde8hVIJAW/h+FnJHouzm0KbYj nWyMLashDG1EiGFz8bOh+oNalV7Kdqo1+Pzmfh7+vJxGG1ZH7K98y+yOa6buc74hxjnL JsgHagkHjW7io+HtovBVzJvEvM9nBnBUkP0oS5dcrrl7rGEbEcJ4vE/qDTyyRzBJp6nq tNpOyZOUy+2G9nOH5zN9uJcOtoMF7b2omC3b3Gum+6mitedN1TQ0tkgOlW8ZjuGMh4mp wLJOeLW2Xsuqv9y3mLv3sFU3rqwfNDa2KgALTbyp82/JtnbgY21CZArLEQeI/tJDRBIE 9Rvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778272877; x=1778877677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cgBGn+2rXtyyJsqVkmH06WkJeLCLcvohOXBffi3wbRY=; b=O7xAfu86+KtscL6i22XgoosznfF0cJTbTANHbVz7VhEywxFgjPRFNXP8E6b7N3To79 7E/uCcXNFsRqYJ5dLSdsmny76Cky2Z230AEUz6UeGBcxC2EeEJ6Ykysc5l8ExjSM96eX Sr2OhE4M4UnmR/gQBu7k40k5dYoiSeVxMjJbBimZaRJY4feuHvVeSbRHzQFXsAWLGPvT UfRoYCoriLgQb9bLG65CwfoYtxesniaZggjCGNwNZGIb6P0TcgYYEf0fpT19VW30HZOB T3PndM/OcdyCgZwJhXhUjBA+smWBTKX65b+abAqyVGdiNR94MZXHQiZ1Hul/pDVWDe0L Zg0Q== X-Forwarded-Encrypted: i=1; AFNElJ+Wu4v1TjBrMHvDPqeAf92eughIv1Rop+Apn83gJ0nPBLAOnd94Ubz6E+tYKAHTq9NPnKPHs1zXmJrOJ+0=@vger.kernel.org X-Gm-Message-State: AOJu0YzQhbK6hW35v3xrCwiUJb25ZNlX6bZYcB/cvGWZ0lTu01uC3bGo dBOlFuQ2uQtT3KCTpv0UKDSYHVp3X/Ct4Zu0LhNLnDdKab3ziJFRx51D/DsQy6A2 X-Gm-Gg: AeBDiesJIUhIJHoCKxrtWJEwKOpLMwCEe5/Zl0Ub40aC3Ljt86dZB3W5Ol2Cf9k7tL6 rvJRfNqwIy+SmKLbkGNyJVZfkuYAEdxgTE+B6Uu0exmqkDjSs379dCy4AsB+68iNmxNeQdUo17l WjUBW7/vACtCMzwjp7I1mKwFTSo02iJ2uQtmfIESy2AQVksG4/MSkhO54n2O7KrBkiagrUimTQU aYAwnnGcN/lOvaKqzAhOH4SF9yxPWUMvWM2H5ynpWchl04eqVitMJW5VhbPmt6N4OpAn4Xi0V/g a5INY3Sw/doJUtSY19Q5iSObIL2gvujsgM2hMi+r5SkkmvqWHT5yI0Y9bZSmMIjGupfZETEo9x2 fqtX64KmOJp9JT+gRChDgo3eroTC+dO3Ig/fmMY0gqMFkqFR9tjNUJEUz6mIGstfVzyTdCmfP0R KVlFDIbKr0B6UgScD0 X-Received: by 2002:a05:6a00:1248:b0:82c:d9d0:f482 with SMTP id d2e1a72fcca58-83a5e34c689mr14306022b3a.46.1778272876601; Fri, 08 May 2026 13:41:16 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:72::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965646254sm13661955b3a.10.2026.05.08.13.41.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 13:41:16 -0700 (PDT) From: Stanislav Fomichev X-Google-Original-From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, donald.hunter@gmail.com, horms@kernel.org, sdf@fomichev.me, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/2] tools/ynl: add missing uapi header deps in Makefile.deps Date: Fri, 8 May 2026 13:41:13 -0700 Message-ID: <20260508204114.205896-2-sdf@fomichev.me> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260508204114.205896-1-sdf@fomichev.me> References: <20260508204114.205896-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ethtool.h includes linux/typelimits.h which is a relatively new header not yet shipped in most distro kernel-header packages. Without the explicit entry, the build silently falls through to -idirafter. dev_energymodel.h is a new YNL family whose uapi header is not in system paths at all and was missing a CFLAGS entry entirely. Signed-off-by: Stanislav Fomichev --- tools/net/ynl/Makefile.deps | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps index 08205f9fc525..cc53b2f21c44 100644 --- a/tools/net/ynl/Makefile.deps +++ b/tools/net/ynl/Makefile.deps @@ -15,9 +15,11 @@ UAPI_PATH:=3D../../../../include/uapi/ get_hdr_inc=3D-D$(1) -include $(UAPI_PATH)/linux/$(2) get_hdr_inc2=3D-D$(1) -D$(2) -include $(UAPI_PATH)/linux/$(3) =20 +CFLAGS_dev-energymodel:=3D$(call get_hdr_inc,_LINUX_DEV_ENERGYMODEL_H,dev_= energymodel.h) CFLAGS_devlink:=3D$(call get_hdr_inc,_LINUX_DEVLINK_H_,devlink.h) CFLAGS_dpll:=3D$(call get_hdr_inc,_LINUX_DPLL_H,dpll.h) -CFLAGS_ethtool:=3D$(call get_hdr_inc,_LINUX_ETHTOOL_H,ethtool.h) \ +CFLAGS_ethtool:=3D$(call get_hdr_inc,_LINUX_TYPELIMITS_H,typelimits.h) \ + $(call get_hdr_inc,_LINUX_ETHTOOL_H,ethtool.h) \ $(call get_hdr_inc,_LINUX_ETHTOOL_NETLINK_H_,ethtool_netlink.h) \ $(call get_hdr_inc,_LINUX_ETHTOOL_NETLINK_GENERATED_H,ethtool_netlink_gen= erated.h) CFLAGS_handshake:=3D$(call get_hdr_inc,_LINUX_HANDSHAKE_H,handshake.h) --=20 2.53.0-Meta From nobody Sat Jun 13 07:50:37 2026 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E93B42188F for ; Fri, 8 May 2026 20:41:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778272880; cv=none; b=PmFhYSHsqaY3B0PODzrYSXVEFY9KKEUE0imVB12bQAInias6BRkYTleG3B5TujFGLc4/+mnSIxXKPpFB2l1lyY1M+tj6mLniU1UwAghv3awOq+ZJvKtU7ywIbQ9as0A4zOUTZ90yvlLJsDnBCCOz3pqQi038nGtlvwFoZNRs720= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778272880; c=relaxed/simple; bh=Rudsp3CgAchrH3IB/N7e9+zgOiTPsW8hmwduNNiQft4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ea3LZouvb60bGdkZkpSyx9JzBVj6PGBbZ96WUSxZyvXNYeCtyg+Wh4nzobZ+9bafBOYB3f2erFUNmbUecknPrBBoU7RQhCdZZq9cjdZF8Dv6c9AaD1ZokPxFyv4ebLS7jbgawYSz8bpdcCAb+eBwePr6QzwRZ0Xe3AEnzE7bR/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qvt1fY/b; arc=none smtp.client-ip=209.85.215.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qvt1fY/b" Received: by mail-pg1-f196.google.com with SMTP id 41be03b00d2f7-c8095d7d75bso1070417a12.1 for ; Fri, 08 May 2026 13:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778272878; x=1778877678; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0wca3zx/WnWoLrmOvHZAPyXYy9sROruOyKA5iNfJEY8=; b=Qvt1fY/bt3u+bi3DNlKNx/hTJoqiipJquW/0oOysZuGIfL7eD1qIu1+KeN5qGgV8F/ 8mdwwwmzWbZP3yYPTdu74JiIIMAT8PIR6WHfPACRyzS5EfIOGu4iIhYWpZ1M/lIcqms2 gKZN/OhynE6ciRt8Lp0kTgsTed/rEr85Dkp/ZpRXZombmPhVkr4j8FtaEpdOr19HcaJq 9sebBte65fb9QGvgIavgv1NDkG8Mo4ulLaQ2HjWKu1LT2T1tCGdBMvj4qXqzrgZM3hcO uUQSQIaV5LarV1+Ohkmvhf7yw0pHtr2k7Ay+0IMW1AQbHuNw4KfB9udtZLd2LTjM9kjm 1l5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778272878; x=1778877678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0wca3zx/WnWoLrmOvHZAPyXYy9sROruOyKA5iNfJEY8=; b=kkwHJ2Uf375Nld5F+cTZUJcArnWnKYAOEat6241kXFau03y8KCKfsF6Dd9wmjrAAE4 szrLlMT+ub8FAO9kjSy3vl0XHVsA3bk9zOubaEONN78gRZK6Kk6mpAV509CCDn7GDAn1 n9dMfbBFF8bhPTSjiQO5kLKT0vedX+NjKAUcj2KtttU5wgP5JrR1P/LRAqseZy6cQZc/ BUyfR8hbDpR7l3VQ9ERH7Ic7bX3IBoLBT6puPfm4zZSiAjWpvu9FgGtGzBOWC6fKcD4t 90JNwr62hlft9xQjmRDYMi/HiQlnjw0avgFoBcYPqnCL3/ElZm8MwFc5rW0aUlXgG3ED CTXA== X-Forwarded-Encrypted: i=1; AFNElJ/un4wGhvGrvLVqr7S5bUTTGV9Wk60TdNyNRMWOhtNyBvBi1EkBFV8wInkLE+VGaO02Bs6Oa+s81vPJ+pU=@vger.kernel.org X-Gm-Message-State: AOJu0YzD0NOA57FNGSmMSsw1KD4lzJqd8IbYF3CBzz0on1pxsJ26bAzt qtQLNzNYC6zc8W2+wsw2POr3oELE5oAC+6gpiqZ058/NAQB1KeQIPXhe X-Gm-Gg: AeBDieuaCFwYrhQsGr95s6Cun9bMwgOOEn1kCaFmNHzzm2sMKcli8tav4XJko7yxRQp cV7EPa+s1QE4vW6flZhIdZAhxdnkXDUJ6c4Rgp0IBSjbwMXsDtVVs9D/Wf+DJOcTppc2PdmWXyy qrkLm2wOFDJTwytBEr/HAa0z8bkFW4ETemiLCEIHPzpa4n00Oh/pu7twb/FEhFDo3zwrb2SpwFV oPrYuzXMdbyj7aETkHGg97JOTkuUnKzVRzMWvNZuOi+eh/OoeDU+O6q136MxWAbdeuFB3rtZMBb 6+WwDzIWG8DRrpgq8vLrUxXM+CD/IgMVDiCbPlrvB7Pcva0PIA9rVvfLPw9ipU1OTv0ZUaqvWAM nh+YyguiSS+UuLJEgibSYCPZuYqGivts5x5i+CN2BAEw0hH/B79OnavQM7Ps7JG00r2CssvD6Tr IIQ6iAG5TAARK4ETCl X-Received: by 2002:a05:6a20:3949:b0:398:4bf2:4285 with SMTP id adf61e73a8af0-3aa5a49f218mr15966769637.16.1778272877749; Fri, 08 May 2026 13:41:17 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:71::]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c826772742bsm2764471a12.29.2026.05.08.13.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 13:41:17 -0700 (PDT) From: Stanislav Fomichev X-Google-Original-From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, donald.hunter@gmail.com, horms@kernel.org, sdf@fomichev.me, linux-kernel@vger.kernel.org Subject: [PATCH net-next 2/2] tools/ynl: add check-deps target to verify Makefile.deps completeness Date: Fri, 8 May 2026 13:41:14 -0700 Message-ID: <20260508204114.205896-3-sdf@fomichev.me> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260508204114.205896-1-sdf@fomichev.me> References: <20260508204114.205896-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add two make rules that detect missing entries in Makefile.deps: check-existing-deps-: for families that already have CFLAGS, parse each force-included header for #include directives and verify that every included uapi header is either already listed in CFLAGS or findable by the compiler without -idirafter. check-new-deps-: for families without CFLAGS, check whether their default uapi header (linux/.h) exists in the kernel tree but is not findable by the compiler -- meaning it needs a new CFLAGS entry. (this is slop but I added extensive comments on how it works) Signed-off-by: Stanislav Fomichev --- tools/net/ynl/Makefile.deps | 35 ++++++++++++++++++++++++++++++++ tools/net/ynl/generated/Makefile | 6 +++++- 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps index cc53b2f21c44..f2c24097a2c8 100644 --- a/tools/net/ynl/Makefile.deps +++ b/tools/net/ynl/Makefile.deps @@ -52,3 +52,38 @@ CFLAGS_tc:=3D $(call get_hdr_inc,__LINUX_RTNETLINK_H,rtn= etlink.h) \ $(call get_hdr_inc,_TC_TUNNEL_KEY_H,tc_act/tc_tunnel_key.h) CFLAGS_tcp_metrics:=3D$(call get_hdr_inc,_LINUX_TCP_METRICS_H,tcp_metrics.= h) CFLAGS_wireguard:=3D$(call get_hdr_inc2,_LINUX_WIREGUARD_H,_WG_UAPI_WIREGU= ARD_H,wireguard.h) + +# For families that already have CFLAGS, verify that every #include in +# their force-included headers is accounted for. +# +# How it works: +# 1. Extract -include paths from CFLAGS_ (grep + sed) +# 2. Parse each header for #include <...> directives (sed) +# 3. Skip if the included file is not a uapi header (test against UAPI= _PATH) +# 4. Skip if it is already listed in CFLAGS_ (grep) +# 5. Skip if the compiler can find it without help (try $(CC)) +# 6. Otherwise error -- the header needs to be added +check-existing-deps-%: + @for inc in $$(sed -n 's/.*#include <\([^>]*\)>.*/\1/p' \ + $$(echo "$(CFLAGS_$*)" | grep -o '\-include [^ ]*' | sed 's/-include //'= )); do \ + test -f $(UAPI_PATH)/$$inc || continue; \ + echo "$(CFLAGS_$*)" | grep -qF "$$inc" && continue; \ + echo "#include <$$inc>" | $(CC) -x c -fsyntax-only - 2>/dev/null && con= tinue; \ + echo "ERROR: $* missing $$inc"; exit 1; \ + done; true + +# For families without CFLAGS, check whether their default uapi header +# (linux/.h) exists in the kernel tree but is not findable by +# the compiler -- meaning it needs a new CFLAGS entry. +# +# How it works (short-circuit chain, all four must fail to error): +# 1. Skip if CFLAGS_ is already defined (test -n) +# 2. Skip if the default uapi header does not exist (test -f) +# 3. Skip if the compiler can find it without help (try $(CC)) +# 4. Otherwise error -- a new CFLAGS entry is needed +check-new-deps-%: + @test -n "$(CFLAGS_$*)" \ + || ! test -f $(UAPI_PATH)/linux/$(subst -,_,$*).h \ + || echo "#include " | \ + $(CC) -x c -fsyntax-only - 2>/dev/null \ + || { echo "ERROR: $* needs CFLAGS entry for linux/$(subst -,_,$*).h"; e= xit 1; } diff --git a/tools/net/ynl/generated/Makefile b/tools/net/ynl/generated/Mak= efile index 86e1e4a959a7..0f1d2c70b6a5 100644 --- a/tools/net/ynl/generated/Makefile +++ b/tools/net/ynl/generated/Makefile @@ -83,5 +83,9 @@ install-rsts: $(RSTS) =20 install: install-headers install-rsts install-specs =20 -.PHONY: all clean distclean regen install install-headers install-rsts ins= tall-specs +check-deps: $(patsubst %,check-existing-deps-%,$(GENS)) \ + $(patsubst %,check-new-deps-%,$(GENS)) + @echo "All Makefile.deps OK" + +.PHONY: all clean distclean regen install install-headers install-rsts ins= tall-specs check-deps .DEFAULT_GOAL: all --=20 2.53.0-Meta