From nobody Sat Jun 13 07:47:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF77033E35B for ; Fri, 8 May 2026 18:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778263520; cv=none; b=j7VV5atpUUMy7JX//i/sp7IlBAkfV7/G8mnUtCdxZH3+xOSH69dmDUCvEWJJ4Pf/n2uY/f7tXo6NXSptEx7jgnWLK7WtMl5Km8TiutbgiBYUq1ikWanJrgcgLz68pQFQfYAZpbO0igFssy2JOC2dzT3ISzTvUEEGqwzjg8Aitus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778263520; c=relaxed/simple; bh=WJMyJmFToCbOVevY9ROtxcr/yEE9VOSjtfkcdMdIwqA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lnHZkXcP+ThAws1G9LLgDWmV0M3ix+1YJLlM4DqeRq38uNnIeEouCcN12s1lTasjh6gEyuUBZOlyNhEff1lNvgIvnmAbdIy/zwkZ6xuxxYb7Xp+i8BJfRT7Tm82YRwU4bCCmR/S0OO+yJuBzEwlwjsTiTGPJfsK6qXr9NJCsalU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Or5oiUFP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JwSeZXwf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Or5oiUFP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JwSeZXwf" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 648G47gp1093543 for ; Fri, 8 May 2026 18:05:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=foT19rAZbY0 Twn6/HYfBI6H3u3CDBMnzAzd7AHzLdZk=; b=Or5oiUFP4Ip5C/ITJbpjHN50ZBr j3JKGkMv28vXYAGXhTWlYK4/tWytyzSB5wBg+CiaD2AZ3hZLbgU9bR9TiFxQKmsx Pu38ZQhCfkOLAZnaE5jPvOqkP8XuUm20/Y46QaGCmEYgcRTmgLHeIVOXybarS9mr ZGC+BcFPC2m1CE9n2KKiCg6m5Sa47pLSkNdgqcEHKT4KhBBm4pJhfCrbI3RSogxN TYYdeuqAFiv1PgnYkghGVacB0JKDLkBmgN+fv7qHIdV76eOQDn30eCEigPaCRJ0A zqjPR2qlxQHhPN9o3JYEu+f7OZZdiPfmeT2rD7ci15S2flET1iMf27EW60w== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1k1d0evu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 18:05:18 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-6312af70ad0so1897110137.1 for ; Fri, 08 May 2026 11:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778263517; x=1778868317; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=foT19rAZbY0Twn6/HYfBI6H3u3CDBMnzAzd7AHzLdZk=; b=JwSeZXwf7tcFT8cQRmKHUvGfIeK1jhnQr6vGsnil4I1Ryoph/VzMuQYuc4BrB/5Ee3 WKQ8oQQ4PIbkQzX5WROZgO4PvgC6p/kNp0JO6cWee3rax4VWpqX3YTbRZ2QuhJKoyvaD Z07SA58tyKhggwmYorctYDy6+ntANGF4AAS+v9kR648oBGDmKQRMsEBY+jy9vpirEiDK wKQh0FSmlRHkPo7J4uEc/viC+dKYQm1kFFU5NXiwpTZ7TScp1UfT7wU/7Nn4jYhjsQnr OKiK4Km352IGWXrV+4NVC4/glmwYTq6iebVsEyHUHceI2pSm1esvL/SARpEIrEi4j6LT 0Oqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778263517; x=1778868317; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=foT19rAZbY0Twn6/HYfBI6H3u3CDBMnzAzd7AHzLdZk=; b=DevpicPs0wEq0+La3ZlHk4HitdYBpmnYYWZAwmJZL0syif6k6fRydXGtc1eRCjO7RE bGTtvLwt8FN2qOjKZhmaVohkZFCjOp49VeXZLZ9M418OxWdpubSfM8T4Z05xo2RPsQVa oUluveG4SOBtlF6g5bMqPsKpUriF8wJA2q2+9pCHQThznN7ROPppP/SEyyvcln6Ik21Y Hr15yc5Xil2RBindYugDz2e2Jkmrvfo7IvWUpJ+9UPY8khkTaIPoQrpClYixZFUh9Z5j y9XRsgPufQTq+jYS3Ge9mThEKpIi66MfaKf5KwSGN5u/c71AQIhBvaG4szoqkRQchp1N 5fHQ== X-Forwarded-Encrypted: i=1; AFNElJ9FQk818HqIseDKmiRAMBVWdjRuLn1fIDK/VhmXlHpCDQi4AnF9Cd8Or2kKnAug5gf5NXZkTCZ1aUpxR0Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7lfJwY0mp7i+bGd5ncqKxFj//yplSaldgKZc3EaCCHrnzMkFv XrQLEMYrZ9qvS8pbcxOyBNUAuEPZ1mr0eSFvTh0Ook4P4ot2HSsTPtXV3kXDYCrUpTLxWHPfKDH zR/zqBdb4SWaRCIcWUuiPxM/tpWmcfPERAW4LLXR/gUVZMHmwwiqneQGqYxrKWJdSGmM= X-Gm-Gg: Acq92OFCvo533/2L0i/AFddGokY2KG7E0yKSPkaUDWo0In9SXqqK4j/KRTg8qZh8YxB SrKfNuZ3U1eZtc8rOJo++Da3NC7gV82OsudwAdg5V0oH9I4T1nUcgUJzA9NghFpZeQvkxbnjCAH LoR3QnRIp7JzxjF/Q+6F5wAHKQLmNTFEXsR/gA8zEMA5/0dvB9DwmrmuWBM8s+wN+JzvY6+MKX8 3H8T4JbEThWEI1FhUPicRbbqVPRlU4oWkvqq++Iwol12X9irgLZV31zYk881TD0T36h84vJCVoi yU8VUcyAH834sof/lrMljow9QQJCIZkEMFJyGXtQMLPQBZVLmu530kd4Qkmy0xbW57ZM1ep9Kew clcujsXgYghq4yrX+hcDVZTY2h77wWPrmhbPqrGxKe7IUUDtLzw== X-Received: by 2002:a05:6102:6884:b0:602:ba51:5235 with SMTP id ada2fe7eead31-630f90ab0aamr8742435137.29.1778263517448; Fri, 08 May 2026 11:05:17 -0700 (PDT) X-Received: by 2002:a05:6102:6884:b0:602:ba51:5235 with SMTP id ada2fe7eead31-630f90ab0aamr8742377137.29.1778263517019; Fri, 08 May 2026 11:05:17 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:cda6:5a1c:b564:d3ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6dd32afasm11654825e9.5.2026.05.08.11.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 11:05:16 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@oss.qualcomm.com, lukasz.luba@arm.com, rafael@kernel.org Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] thermal/core: Add dedicated release callback for cooling devices Date: Fri, 8 May 2026 20:05:08 +0200 Message-ID: <20260508180511.1306659-2-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508180511.1306659-1-daniel.lezcano@oss.qualcomm.com> References: <20260508180511.1306659-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDE4MCBTYWx0ZWRfX8byeB3jKtcJI rkjX6GbCAJRIr6VYdqMiVjP+dDpA+bU6tgY4eZNM9owbZSOzPLKyrPMw8j4kLPHd3nAVW85V+uY PdKBfuq874HMRSaSHmCzjH+mIVsQL4caMk6kOckBq2tM8m/jAEMtsZ8bqmseoc/Q3x+GbxYEyt4 hJ1NQORIb5kx4rlfd9/Nm64VJ2wyj6eY6RfdkZjJUMIbW+g0LNvBPHQPYcxc4UyHyyCNduxIdjQ 0wgR8iyJ00n/cxprgw5rcdHO9e6ouvFa2J9YTI/pAHVi3bg/5AzdmHRTkPh64XDg1HEj/+MnJXZ yZmOw0r7TxgZMo+zlBqn53KuYfKyPBqIBmXpD4hpDgo3Zyu+o6XGe/ReqqLdq5DXbxCMgtGxRdP iSgqM0LRI2ic5MGgfyTQKt/w0u17xZPQnA3hgJtnj8Lg3zQrRUKoqvkIHhrs8/hZxM4rWOtjQFW 69YHi6xfXxVXLRKPAwQ== X-Authority-Analysis: v=2.4 cv=GLU41ONK c=1 sm=1 tr=0 ts=69fe25de cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=qPbDZLIEKKa8xmaCxtMA:9 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-ORIG-GUID: -t0TaT2Dkv66C8zUnF-fAZSzgv_MDSE6 X-Proofpoint-GUID: -t0TaT2Dkv66C8zUnF-fAZSzgv_MDSE6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080180 Content-Type: text/plain; charset="utf-8" The thermal class release callback currently handles both thermal zones and cooling devices by checking the device name prefix. Move the cooling device cleanup to a dedicated struct device release callback. This avoids relying on device names to select the release path and keeps the cooling device lifetime handling local to the cooling device object. Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/thermal/thermal_core.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index 2f4e2dc46b8f..cf5d4a9c11fe 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -952,7 +952,6 @@ static void thermal_unbind_cdev_from_trip(struct therma= l_zone_device *tz, static void thermal_release(struct device *dev) { struct thermal_zone_device *tz; - struct thermal_cooling_device *cdev; =20 if (!strncmp(dev_name(dev), "thermal_zone", sizeof("thermal_zone") - 1)) { @@ -962,13 +961,6 @@ static void thermal_release(struct device *dev) ida_destroy(&tz->ida); mutex_destroy(&tz->lock); complete(&tz->removal); - } else if (!strncmp(dev_name(dev), "cooling_device", - sizeof("cooling_device") - 1)) { - cdev =3D to_cooling_device(dev); - thermal_cooling_device_destroy_sysfs(cdev); - kfree_const(cdev->type); - ida_free(&thermal_cdev_ida, cdev->id); - kfree(cdev); } } =20 @@ -1040,6 +1032,16 @@ static void thermal_cooling_device_init_complete(str= uct thermal_cooling_device * thermal_zone_cdev_bind(tz, cdev); } =20 +static void thermal_cdev_release(struct device *dev) +{ + struct thermal_cooling_device *cdev =3D to_cooling_device(dev); + + thermal_cooling_device_destroy_sysfs(cdev); + kfree_const(cdev->type); + ida_free(&thermal_cdev_ida, cdev->id); + kfree(cdev); +} + /** * __thermal_cooling_device_register() - register a new thermal cooling de= vice * @np: a pointer to a device tree node. @@ -1093,6 +1095,7 @@ __thermal_cooling_device_register(struct device_node = *np, cdev->ops =3D ops; cdev->updated =3D false; cdev->device.class =3D &thermal_class; + cdev->device.release =3D thermal_cdev_release; cdev->devdata =3D devdata; =20 ret =3D cdev->ops->get_max_state(cdev, &cdev->max_state); --=20 2.43.0 From nobody Sat Jun 13 07:47:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48C0F34FF78 for ; Fri, 8 May 2026 18:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778263521; cv=none; b=qU/UdzKC7umdWJtXiNrOauNwZgMYADwk4QjAYT4u9tkpk+76wEJ19rl6w/70RBppIlhCDiZW8nhhYy64xWUCKnA+jvthpch6ccQeH7x9Y7uIahgAnfx9F1NrGzlsj6cEoJ7Mmu8hW1OZbsOfioX6pZ3qXMeZ1wFbpAja+eLh30g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778263521; c=relaxed/simple; bh=zrGzrYkPdY7YMJuo7N4SHYemZtOQAa2dtQkSWaMsWQM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pMR/5SGbLPSlO1CEhtutPsn12Ug+vjs6OMXTN4A2+FxybzdxVGJ2y6CnSaKSeIXOrzfEJe03q+oeYCblGKXp3So5Rf0BojinqAHAa/0rqV94wJwpL3XExx6GlGQb1AXK4udFi7DDmKQQiRArGXMWgdZZOGkluD8qjlj/kyL4eaw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TSwM5HUP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dhBsWCTN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TSwM5HUP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dhBsWCTN" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 648G4BwH1093603 for ; Fri, 8 May 2026 18:05:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=1hHCHNh9vUV dYOKHBom2l0BFmQ2i374kNIpIcv8mpZU=; b=TSwM5HUPDYMwjBpyM7wXFsUvSoI 0biTfbnRW11KIJfWYRXVvpHyzso9MhJxEo3DE0zC0PGsM6NgiA99XnTUT52S3MRg ugdLDjgh5Zdc7TDMU/0Pdmd7aGRy+of/wfx/ZmoJ9s+9R+h6rnafQPbLa1loW689 GuJ39xfVxDfLBW99TN5BsCcjguMJEUeC2fBvKpV4SlNU08wx1l3p5qm9jHQdwjWw iaaIKzLuj8fmIRVT1ProrxZJu+dLVolqYuIPwavlEvkAa/5s2ZcUoqC8jSVR5bUD e/YvRkNHjlakoevUUMqH67XWzjV1jFE71o9vFot5i7pxMmC2kpTOPldXyPw== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1k1d0evx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 18:05:19 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-611af0d600bso1564568137.2 for ; Fri, 08 May 2026 11:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778263518; x=1778868318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1hHCHNh9vUVdYOKHBom2l0BFmQ2i374kNIpIcv8mpZU=; b=dhBsWCTN4VUJ4jkvIflF3L5F088NAKu0uBiFAcaVWmqogAiXMdJIumDGjzwbo4k5ud mU9+ztXEkJE8ADO2dcfRpe0I3PrefW2G6KjeOGtbMys32SGzbmi1gcDt2SOzKoragF1C cb80H0T6pKmEs1Vj2YVLSIF0ky0HLMNvYJ6BwQ0mdvcIhpKU4x0JocIoAmvDMkFWoW1K KwDD5R5CXvQSbIxPfFGJTY/Kz1tiU+t49gCn9RIPQq69bu4SzqmQ5w5SbmpZm9BWKkfo XzZZXbMk4gB+B71QQiFzd4mDvofeVzJN6TBLUyWE7rTQyvl/NPy3bsJpZA0soB20zasL 4LNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778263518; x=1778868318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1hHCHNh9vUVdYOKHBom2l0BFmQ2i374kNIpIcv8mpZU=; b=mxUQbR6cjjH41reYUXGWCtgN2vI+emFIe7pb8f8qpOmDJA3ycCQeNzhGbaXJMK+aJ/ 3du7Qen6gnDvI6MKev4BzW2MPK8rdDwp+5AFy2wf41ktK0Ix2yGIKrwfWOaOG1+RsmM0 2wm/kPz2BLtpZq6JNO5tWBwLzJhixkvt8qmfPspIngvlddUBfyB8YiHJiLCYhB9LDK9b e0C+wfWFbm45Fc04xY9yvrQAankVTqboPYvLAcuK+sdpBbdmS4DJ5uFmKW1J9DRAc6WN rHvORKmoAnJGTVYFBy32oYi+arCehjvG7BC9qi4qzpzboByvzZ04KUWAFUAmTOPXM5Cu suCA== X-Forwarded-Encrypted: i=1; AFNElJ/JgZYpAX8/R3k829JXyV5mvwuUFgr6XhJLzJLXpKknVyLcvgziuNyHMyN1l8oBlEJT+LUtP5+Yt/pybOo=@vger.kernel.org X-Gm-Message-State: AOJu0Yys0dFZxP3FQ7+HtzK+mRmriazr6FvYtPGBnwk3wmIe8meMDY8t y1+iu33peqTeApFlU8nnyMq9BZA90P2ZO6/5foSemnKIdH/eApEleCzKra288ORd0SXLbRnG5jq fWMwi3F6dYI7ebkNEGdrpgBpaB9yqg4Cc3JHwsHxwchABXg6PWv8H4l2MCqQuI/tUU+I= X-Gm-Gg: Acq92OGQlKo+xg7ovgPHvdQYd/PViVv0hLbJ/CRJanRLAf2eO1NS+xJBb9rAZQ/fK5f g3FlnH1OAgqjZuR859h6nojsqUSN/H8DMNuX65RRUrrEeNwKcFmUSthzMWHua56NwQq9ZaNeBV4 gm2Lf4EDvY8cSHzS9bdf2W46SoGAbDe8ZDjaZqvrrYuZyD9G8LvSKffFYbEmKJc3BE2lvJee5fT rgxGZmK3Sc6Psd1lW2BU+1p55zVVG3CSZ2GgFGsgoZ90/b6bkwJxSZtQ1MtOug0NCqUXFGqM6k2 O6JEmDfWBZ993FxITKfMBf8/lIeyvGFDfLUhvToPazYGS444vGgnyjoiUFAi+UtH3aYtctGA5P+ 9dUYpsQbkluCsI54Cfh2T/LbD+a53yJbBf+SMkYRZUgLT6c20HQ== X-Received: by 2002:a05:6102:5813:b0:62f:357a:329a with SMTP id ada2fe7eead31-630f8c3229bmr7109944137.0.1778263518580; Fri, 08 May 2026 11:05:18 -0700 (PDT) X-Received: by 2002:a05:6102:5813:b0:62f:357a:329a with SMTP id ada2fe7eead31-630f8c3229bmr7109898137.0.1778263518134; Fri, 08 May 2026 11:05:18 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:cda6:5a1c:b564:d3ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6dd32afasm11654825e9.5.2026.05.08.11.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 11:05:17 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@oss.qualcomm.com, lukasz.luba@arm.com, rafael@kernel.org Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] thermal/core: Add dedicated release callback for thermal zones Date: Fri, 8 May 2026 20:05:09 +0200 Message-ID: <20260508180511.1306659-3-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508180511.1306659-1-daniel.lezcano@oss.qualcomm.com> References: <20260508180511.1306659-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDE4MCBTYWx0ZWRfX/mhCIg032SW5 OmsC7969nRP0kgQZ4tGEevfNiFqp8zBB0jtO2nP3B1cJ3ErUxaddIwtLPh24Ht3g6qYacfQOUp+ SEh8okK/UreWCZPUqzUyufvwSLVQ3eo78GG4jYmQ0QtlgGCAm91ei9TMY1YxW7powXimoqESlYS bnnqWkvnrI0ustrjj6oOY35Z2+nsZiIulVUZQ80/My8lan2z79nmqbFaCa2N4kbzqySaX/P30gE 37sn/t5WHOWvpwckQB2BqESXXJxPIrHdLoMtz4V8ZnOrIFCEOufdOFT84lFW6FrDGpNkLrycJ9k YXTX53sqjj46BshuZzfcEvEwwz5Ufcre3gTjTbJ4tbzRUyac0j0LXbDdyMBTKc8z75fBREL+6Ft XddARGw+gwPFeUHm01upTgM18RFOS+M8da5R21BoySLiL2fGb2Q7xmdhOBXa1vJ0mMNDOdMKhWI QsCiKPGbSa/dGPqg8BQ== X-Authority-Analysis: v=2.4 cv=GLU41ONK c=1 sm=1 tr=0 ts=69fe25df cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=fxX41ZqujnG29gMSCLkA:9 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-ORIG-GUID: vdaQWYkGUBwrMyd5Ps1NXrAxpb1rzNzP X-Proofpoint-GUID: vdaQWYkGUBwrMyd5Ps1NXrAxpb1rzNzP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080180 Content-Type: text/plain; charset="utf-8" The thermal class release callback currently handles thermal zone cleanup by checking the device name prefix. Move the thermal zone cleanup to a dedicated struct device release callback. This avoids relying on device names to select the release path and keeps the thermal zone lifetime handling local to the thermal zone object. Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/thermal/thermal_core.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index cf5d4a9c11fe..a79fc4cdb078 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -949,24 +949,8 @@ static void thermal_unbind_cdev_from_trip(struct therm= al_zone_device *tz, kfree(pos); } =20 -static void thermal_release(struct device *dev) -{ - struct thermal_zone_device *tz; - - if (!strncmp(dev_name(dev), "thermal_zone", - sizeof("thermal_zone") - 1)) { - tz =3D to_thermal_zone(dev); - thermal_zone_destroy_device_groups(tz); - thermal_set_governor(tz, NULL); - ida_destroy(&tz->ida); - mutex_destroy(&tz->lock); - complete(&tz->removal); - } -} - static const struct class thermal_class =3D { .name =3D "thermal", - .dev_release =3D thermal_release, }; static bool thermal_class_unavailable __ro_after_init =3D true; =20 @@ -1473,6 +1457,17 @@ static void thermal_zone_init_complete(struct therma= l_zone_device *tz) __thermal_zone_device_update(tz, THERMAL_EVENT_UNSPECIFIED); } =20 +static void thermal_zone_device_release(struct device *dev) +{ + struct thermal_zone_device *tz =3D to_thermal_zone(dev); + + thermal_zone_destroy_device_groups(tz); + thermal_set_governor(tz, NULL); + ida_destroy(&tz->ida); + mutex_destroy(&tz->lock); + complete(&tz->removal); +} + /** * thermal_zone_device_register_with_trips() - register a new thermal zone= device * @type: the thermal zone device type @@ -1580,6 +1575,7 @@ thermal_zone_device_register_with_trips(const char *t= ype, tz->ops.critical =3D thermal_zone_device_critical; =20 tz->device.class =3D &thermal_class; + tz->device.release =3D thermal_zone_device_release; tz->devdata =3D devdata; tz->num_trips =3D num_trips; for_each_trip_desc(tz, td) { --=20 2.43.0 From nobody Sat Jun 13 07:47:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A231370D4D for ; Fri, 8 May 2026 18:05:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778263523; cv=none; b=a4XdxR+NqrgJM2lsYJlUnrZOSmpg4DhlcVm6lFzS+Up8hwaHmGyE9DFOQqNEe0g6EGmWX7oMbOPi75+FkBfDzm6t5S16iv1nSSFMBxO+7bqvMyGeYTOt65eVOfODHMppblldNDZfHnZn/Tu/6Tk/zgv5Sf4uHX1QjwMZy/k3Bw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778263523; c=relaxed/simple; bh=Llpuo7ptAkoG1U7XPGvqcjBxPcBuKxYKyRljn2+GScw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PsrO/OhQl6dm6CnrjyUnGj51kwIJ2takTQD0djOBIv1vY8QrE02Jftagdhm3uXdyNYgx7JcsQJrPQRo5jiZg8LlQxKhC6usqVAqpeSnAYJD6i5AU2Oaanj2mDJP6Lgrt4mYM+7nF2XImUIMigJPEvCWWOjICMwZWrYa0r88g3AU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NW0DDFRN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iwBUmDVU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NW0DDFRN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iwBUmDVU" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 648HU5sW2515481 for ; Fri, 8 May 2026 18:05:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=bwHWFphaJiJ LzQOfhxubcUS0JiF4OejVKSh/+aqeLSo=; b=NW0DDFRN1gJ1PWlk3nP7HBsE6/q XPYTnKWjZrrPpCZ9ii6+uJS74SSFiJWR+IzjcaIi8j6wJqRdvPpwM+yA82TevPtx otCZehqoqiKjm8/Bw5QgNnRKAIUAwZuHpmndou8OqMtZtLgti+c/XLeH7BUoS1bl oZfOSye9pZYqC02vmxR2jvvNLmpFsRYKmXdwAOOHg/Qghl4OHT2CMpE0fTWl7Dtf qRdoEtkfhWFtNhv7BxXuDbeh0AGjWRUTS+UJy27JXC6DyJIYZZIDpdqaIqE9xDbs PoHYHoVd9mShFjmwcmgNZBe+pMrE078eIah/XmIDiRPY7zghjvtOJk6as8Q== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1m9nr4de-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 18:05:20 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-62eae604ac8so1359894137.1 for ; Fri, 08 May 2026 11:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778263520; x=1778868320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bwHWFphaJiJLzQOfhxubcUS0JiF4OejVKSh/+aqeLSo=; b=iwBUmDVU9z+8ZUwq15rSw7iEejG8A5+Mk1clsPMlxNPMus68u4gG3PByUSrgwAekvK E9/kn3lE9Y+N2TGAqO5+Z6KkgaUSINMW9d6CqgLCvHJvZwIlo5pKn5jUICEGT+szY0uP MLVP+mLe6EoDAfQFhADdiAo+vPu8eFz4aBIjCMgkjIaddNz3GZuy5fgOkNEN6DuQm0Oa rqM/JRphKOuM50kF55Z5aOx9Rz8GzkESLdmQfwps/+/TfBpVdSuV1r9/OkwV7fTpixtj SuSXykoT3mzKdSOGb8Qpcw21Bx3JDzTNkxm77GzMRYCn9kK/f1jBRN1/hqLOsBMoXZuj 12hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778263520; x=1778868320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bwHWFphaJiJLzQOfhxubcUS0JiF4OejVKSh/+aqeLSo=; b=RTCcSN47N++4qJ+iEZjSOz5J1XfFJWzvx1K9ZLIX9s8MFMi2RWQMvzMoXSHZ6zguBC J6VWvgLshG/lrDz5HBB/hgtjER0wfoxz7RqVo9DvZL1uXX5Hw4GZ5Z7jqhtDHmEwdPk3 qUJ6n1OILrXu37VHp2LF354zkOSKHwAnbY74hq3BZ5T2UGWNIdr+jkBgUGR4jEHjZrLU 9upFwF1o43Xl3DWrskPdYZAmLv/8sVMkSyTbAzBMHo147/npFQYbzN8Jw2Jy5L8gwR9q VCuMtL18PmMMaBqsN+6QyQaTQsPmfCcjaYndqOe3/nqMepcULQutNhEu0m9qUbSNK8G2 YxnA== X-Forwarded-Encrypted: i=1; AFNElJ/RlKXmeSvx9PZtsAfL9csCRus5L+ahwundtVbYBYJzbr/TASuUY/3HedNC6Jiw1/Vrb7+YgvqS4T7NtAo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzk8eyyfJDmehUEQFI3ZedtCgZySQM3AdrZRd/V9eK9504wVfdC /9GFktoVlJuMZIKmaqFPRX5S7gEEMYCZmq8T3WLtrqgoPicaVijAsKuYwMSq06KFMNpa0O0u+aW Zpx45jkqw4gkkhKJKDa2PYOOvK6UjDK7x+CJESdRu+XnMcbzYcmNg3qmfG/NkXTSDDr4= X-Gm-Gg: Acq92OFHzv58rSr2BL50UpskpZpXKHkmTf0xgbbAdzzzpvwajsgQoh2QfgVMEBDaBfX NTWwx9Tw96/RzYLTOe8R/4Fp0kwCR2/3HOZqgyAkEMGpu1Sp+iD/vUAwC5CVs5GdBJcwnJf0jkd Hxlsqolho641NachRq/i35+74mFKjV19QriOh7VssraPRbJOJYIapDRqbcOYJTyt+lAIdSUKHpu 8VaKabiJ4WPMjwJp5BK+5PT9CoMMjR/wULUJMnjt9sv6l4zYUV42uRso2WUd3lcZsa/tUwsH7TT 7dLBVS+uea6MOIW8jROQFEtsOZeuO5LnstGFqt/cvv7HdRTGj1Y+HMMpmnxBxK34nHPi9C6peIO 9xWt5F3FJDL0uMygeSQSPugRAL2tweXXh5Z2Dhx6Bv2HgwzZRS8dqMYboeFjj X-Received: by 2002:a05:6102:dd0:b0:622:702c:fd3f with SMTP id ada2fe7eead31-6313eb02d16mr1824531137.21.1778263519749; Fri, 08 May 2026 11:05:19 -0700 (PDT) X-Received: by 2002:a05:6102:dd0:b0:622:702c:fd3f with SMTP id ada2fe7eead31-6313eb02d16mr1824481137.21.1778263519303; Fri, 08 May 2026 11:05:19 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:cda6:5a1c:b564:d3ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6dd32afasm11654825e9.5.2026.05.08.11.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 11:05:18 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@oss.qualcomm.com, lukasz.luba@arm.com, rafael@kernel.org Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] thermal/core: Allocate the thermal class dynamically Date: Fri, 8 May 2026 20:05:10 +0200 Message-ID: <20260508180511.1306659-4-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508180511.1306659-1-daniel.lezcano@oss.qualcomm.com> References: <20260508180511.1306659-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=DaEnbPtW c=1 sm=1 tr=0 ts=69fe25e0 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=_90HsjT7k80V3hT8LC8A:9 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-GUID: aN8j6F4AGDSAnpqtiZxfnHOTEDdH_8qa X-Proofpoint-ORIG-GUID: aN8j6F4AGDSAnpqtiZxfnHOTEDdH_8qa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDE4MCBTYWx0ZWRfX06KmLevD1jGi Cg2f2Q6wcPhBbt10ug2vOLv9Gg4myQAcmAdL90vb0X6He8utxnI/MevcHsz4CCZJK5TsAm+d5UR FpdKyRvnxjjiUFGqRGIMa94fwg3loTBO3U3QJOvsULN6KLGlxqSyKZIszryUjcmk5e0CELZ0T5i 3P1JWvZFzqnx4xlD4uUYupA1wROuZ3t3iwJjv1BPm298wtLHpGBkQLnlphX1+kHcWkAMXZnH+1O 6M6jcCl1nzFBRQTD5fJdnqVkN6Aol/nEaOEaEEMP1FOv42ruJvtn8USvQgBBHU9v3NyYySGihPe sZKrA1/+fhVgjDBDRV5ElLHQC89WdJkWi/WV8ZF0qTG6WmySW28SxImW13AQyniiVfvJ+VrxksA fnsxYtnVWJYJAxoXumLpl5g/old2SxXldK755XCf2VtvNrFXCqnxgL6TPiQtqBJpattvyKwsXdK NXaODophBqfgZdb4uwQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080180 Content-Type: text/plain; charset="utf-8" Use class_create() instead of a statically allocated struct class. This allows the thermal class to be managed through a dynamically allocated class object and avoids keeping a static class instance around. Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/thermal/thermal_core.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index a79fc4cdb078..748ab76823a3 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -949,9 +949,7 @@ static void thermal_unbind_cdev_from_trip(struct therma= l_zone_device *tz, kfree(pos); } =20 -static const struct class thermal_class =3D { - .name =3D "thermal", -}; +static struct class *thermal_class; static bool thermal_class_unavailable __ro_after_init =3D true; =20 static inline @@ -1078,7 +1076,7 @@ __thermal_cooling_device_register(struct device_node = *np, cdev->np =3D np; cdev->ops =3D ops; cdev->updated =3D false; - cdev->device.class =3D &thermal_class; + cdev->device.class =3D thermal_class; cdev->device.release =3D thermal_cdev_release; cdev->devdata =3D devdata; =20 @@ -1574,7 +1572,7 @@ thermal_zone_device_register_with_trips(const char *t= ype, if (!tz->ops.critical) tz->ops.critical =3D thermal_zone_device_critical; =20 - tz->device.class =3D &thermal_class; + tz->device.class =3D thermal_class; tz->device.release =3D thermal_zone_device_release; tz->devdata =3D devdata; tz->num_trips =3D num_trips; @@ -1898,15 +1896,18 @@ static int __init thermal_init(void) if (result) goto destroy_workqueue; =20 - result =3D class_register(&thermal_class); - if (result) + thermal_class =3D class_create("thermal"); + if (IS_ERR(thermal_class)) { + result =3D PTR_ERR(thermal_class); goto unregister_governors; + } =20 thermal_class_unavailable =3D false; =20 return 0; =20 unregister_governors: + thermal_class =3D NULL; thermal_unregister_governors(); destroy_workqueue: destroy_workqueue(thermal_wq); --=20 2.43.0 From nobody Sat Jun 13 07:47:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C07B6374E45 for ; Fri, 8 May 2026 18:05:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778263525; cv=none; b=Q7tVUqH0A8I5+haZxn6C6MFwByuQCj+D11ETI9OAi3CWeKFHt3igvdVOqtyDVD2c3tQLswOaTQsGxbbrDrOwj8/CfLYKRQZY8ZATg62B3XOf8Mcv3CY2STr2x9vYAjV0L+O3MV/chJ+LRP+JZCDsOGKHkLD0yI4PCNRJatj2KPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778263525; c=relaxed/simple; bh=kAMQAL6wkuF+CX8MvwA7YeSoJb0iZkveDB5XcPOzhng=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RXKjk/+HAxZsEulD6vQ6RJJWh//N0Wx3I1IA1J42qAHQXm623zJ5CyVJ3ZUIAFmfZYoAUbj84hAmTVI95l1puoPgZqNNZ5FLNT2thjzAJ0P3EvivpM7MN8vF+V3wWtyyLnLyCSwQrnIENazGJMPn68tJe2TSP94xKpvd2V2F77Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NdNxme8Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f+NFJ31o; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NdNxme8Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f+NFJ31o" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 648GTlu9145316 for ; Fri, 8 May 2026 18:05:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=lhCBH35y9J/ zYddDzCgtrQotABln3FGxqD0H8+Q4LkA=; b=NdNxme8QVfziCHoIttBzSYFQezL eLcQA0qv9Y6wFYLM82gnUgicuqj8SCsvzLlzNUTfkZei6cDI6BZm46jnK/7/aJnd ORbLzGtMoCiCLK0n7aVG41nf9/089R62JQ2prZfwMghqah3z7Y2QGbT4PgS91hhP bs93JAl+37NR+4mqBvj0Od8XQwLgXan3Sz+QbvcEOAnYy2qIP4+RyIY2UI8ssOOq GXjgS9AVz/CsvLr9COBOaz0kT5O/fqrad1LixqZ/VSzcf4LYR6tiQEGvi199kJ9f KqBfPB/5JdiRDGmOgx2dbZ+bx4b7Bm0LrcOOw5xHwl3gJfsmLhlxomwmmiQ== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1kdc0b1r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 18:05:22 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-62846961f0bso2931712137.0 for ; Fri, 08 May 2026 11:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778263521; x=1778868321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lhCBH35y9J/zYddDzCgtrQotABln3FGxqD0H8+Q4LkA=; b=f+NFJ31oMX02pc0tFLdjhR7HzX8DklZOWG+Ky/4DTNyq+b0jHPeoquS//xnd6u25xf yeRG3b8/AW8eOZoTfJ7Eh7wwvGf8RhjVcYMPiF3NlXmSZwSdxtLzaIWoZ9oHig1FGbSP /zA8NePSL9Bw0kApUVygxd2VYS3X014axDqSbzhlWgy6QAyZZpbq5wagmAaOPct1avCm M5eTAe+MR5B26JEPadpsjv4ydfV9RD6lK/dq5F7H8G2t21xT+dgSKgn+h57GCU008o2L g4pmszI6lgA/VZ3HG4AF77FfYmzmQKmreTXvOUa/sqZTCeNOb/cIcY988OznLAsZr/29 VMwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778263521; x=1778868321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lhCBH35y9J/zYddDzCgtrQotABln3FGxqD0H8+Q4LkA=; b=Lo2Y1vG76ApzG8dW9TQQJZZcnTLWa+mnEeqeX32Ept/1krzZ1Ni1hwp7v46i1aIvPK cZqJjtu2HU08E9HFdgNIImtBeQO47V3k+ng/NKV1zMzjYzMNucSesMXXvRUDUjeGbKPk IRTn/bdOaP3mOPcacAQ6qVo5YU7wMmCkeIYhbb48Cm5OCxXnuKVDPw+USxfvGATRyCQs Uea7ZDvoDQ054y2FZcG/72xH4Oa+OVTzn9/lGQTEi2EBZzUuFQ5wZm9+8leH2EXbWghp /Da6Mc2x27IjZ8vGHmYMJFcBjv4/+ERKkPfv7x7yw1mhnvaWfCLMqEV5O3QJXlSFHPC+ GS/w== X-Forwarded-Encrypted: i=1; AFNElJ8n/x2BkilxC2NZJX9g3pg572cs/AzGY9zemLzTHpC7CM/S5bc9rQA2t2PGySSmskzDQPlgEoZhHgTksYk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4yBsBeqa8CYJTiCJ2sDd8+iqyBV+taN9gGVJMoE+e05RgHZBj Ce6WnwsQXHwqgEObJzEq7+mXdL49UwgPsWhiePBiDToLr++6JqsmgIV9H0/AE/RNRBmSJt8J+Cv rOeXEX7zL4xp9NxzhAzeSYtRoVWglvR7I8nasGErkl8sH2SH/0+BUmKufRgv4jEt2xpVFY0/t8P gXxQ== X-Gm-Gg: Acq92OFeeh/uHIG/pCye+8dyzg1oxfgUJNhdMVNcg6avovXqVOYqlDKedzTiuOihmH0 2w9wAEyJIVjv9WQkWWpWynoSi16RI7WufzF06VUvjzB1sGU7NdWI8vGxvtP47wiPu5lPOjA/RxM SgjXYz/gQXhEigBzuU2hLrCHG2LGHVa7cFJ0eyKVASUr0FXUQLNBkmsxrTx+jijGPOQr9D8YKr8 cIkav6vH2/AQQ22BkoOSc/jE/jmBzlJqVmiPMZvncQUz42xN9mWbNG3rrcqz72YQc7/pKAYVuQ+ FJ64/u0bBWOC1aX/XDGAJ+gqLRtuAtC4CkFZypvQPjwN2VotZD54Rte+D10laOnP5R8opoKOG/8 JqK4R0sHc7liIN0Co36x1Os0tSRJpmriOzsJYIcQOYWAboB51cQ== X-Received: by 2002:a67:e70b:0:b0:631:8665:350e with SMTP id ada2fe7eead31-63186654a0dmr534045137.30.1778263521009; Fri, 08 May 2026 11:05:21 -0700 (PDT) X-Received: by 2002:a67:e70b:0:b0:631:8665:350e with SMTP id ada2fe7eead31-63186654a0dmr533985137.30.1778263520466; Fri, 08 May 2026 11:05:20 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:cda6:5a1c:b564:d3ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6dd32afasm11654825e9.5.2026.05.08.11.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 11:05:19 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@oss.qualcomm.com, lukasz.luba@arm.com, rafael@kernel.org Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] thermal/core: Use the thermal class pointer as init guard Date: Fri, 8 May 2026 20:05:11 +0200 Message-ID: <20260508180511.1306659-5-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508180511.1306659-1-daniel.lezcano@oss.qualcomm.com> References: <20260508180511.1306659-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDE4MCBTYWx0ZWRfX9corRj1ggT8l MdEVX3M7ORxu4iiJ9y9tQUjiWzybKOGuSBdyZE5N/wya9uWxSgX47YBNs2gfHvKA0tQTNP0vMMQ FATVfbfcuYwGKxrABxPt1F4Up6IDVV6Hh+pTRkLUECJdRI11anfKhv7vvwkSN/k+qivIQvtncOv GOeCz1EwfAushDTgTgQcu2+G0sKB1LJsRLZ2Jul2SdTsRryv0UDd6efgPrDO6aRJiF0uqNpkHfb e8P1DYufcQjgVe4TsWfxv8DyBrzL5UFEpgEREgjHj4K/bQ63J8wcORNVfPbbFk60oRG4Wjwb/9D Y/44K/oxoKsrOVeuVlxDRewDUEQkl/JLSb52ElxOgjiib+VVpRLCK0lePc7V4jRuWaxwj8huWkG gRS8XYNe7TgBkzamc4y9X4f8YFQLAHV+mN7eKpwKgJFWRzbIz22rfRXGG/PE4+K1S/cu7HitNP0 UFG+osXXK0XhouIQ8wQ== X-Authority-Analysis: v=2.4 cv=RZOgzVtv c=1 sm=1 tr=0 ts=69fe25e2 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=2kgeJGiveZr2WTZnyR8A:9 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-GUID: o4baTmt3CFeT5rHxfDBphP-SRcxHCLJf X-Proofpoint-ORIG-GUID: o4baTmt3CFeT5rHxfDBphP-SRcxHCLJf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080180 Content-Type: text/plain; charset="utf-8" The thermal class is now dynamically allocated and stored as a pointer. Use the thermal_class pointer itself to check whether the thermal class has been created instead of keeping a separate thermal_class_unavailable flag. Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/thermal/thermal_core.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index 748ab76823a3..81f6bbaded65 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -950,7 +950,6 @@ static void thermal_unbind_cdev_from_trip(struct therma= l_zone_device *tz, } =20 static struct class *thermal_class; -static bool thermal_class_unavailable __ro_after_init =3D true; =20 static inline void print_bind_err_msg(struct thermal_zone_device *tz, @@ -1053,7 +1052,7 @@ __thermal_cooling_device_register(struct device_node = *np, !ops->set_cur_state) return ERR_PTR(-EINVAL); =20 - if (thermal_class_unavailable) + if (!thermal_class) return ERR_PTR(-ENODEV); =20 cdev =3D kzalloc_obj(*cdev); @@ -1536,7 +1535,7 @@ thermal_zone_device_register_with_trips(const char *t= ype, if (polling_delay && passive_delay > polling_delay) return ERR_PTR(-EINVAL); =20 - if (thermal_class_unavailable) + if (!thermal_class) return ERR_PTR(-ENODEV); =20 tz =3D kzalloc_flex(*tz, trips, num_trips); @@ -1834,7 +1833,7 @@ static void __thermal_pm_prepare(void) =20 void thermal_pm_prepare(void) { - if (thermal_class_unavailable) + if (!thermal_class) return; =20 __thermal_pm_prepare(); @@ -1865,7 +1864,7 @@ void thermal_pm_complete(void) { struct thermal_zone_device *tz; =20 - if (thermal_class_unavailable) + if (!thermal_class) return; =20 guard(mutex)(&thermal_list_lock); @@ -1902,8 +1901,6 @@ static int __init thermal_init(void) goto unregister_governors; } =20 - thermal_class_unavailable =3D false; - return 0; =20 unregister_governors: --=20 2.43.0