From nobody Sat Jun 13 08:03:30 2026 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B94223FFAC1 for ; Fri, 8 May 2026 16:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778257743; cv=none; b=R5t1TbkCoJY3B6WBDNIRdnl4YS2mnZKt7d4AVv9hw9dj5cb1vKj8bpxTx/8cE/4OBZb8S9j2zJyZslRRPrsxtuZnnPsx9Ro0hpzGL76CniISytGNgfO1dUqAkhUhPCj8c6f8Qp69nKSeG5TyVpe9vU0m4bM/s4b3zxkpKBdUJsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778257743; c=relaxed/simple; bh=fslODnGrP34cw1XXzt3gj2b4W4Kt6vCsqj4iE3sazao=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=JFWX3vYQJm/Lffs7ml/fktucvo8dOnBhLixgBJxb14605om2TxCG9hg1xpQMQ2SFZCsjm8DktT3WlNrPkHxgsGqXlnOA6gFzGoydImu1C0raXcrhzXqZNiLT+Qgaum9+047dSe7TSbLBbR0wrVoiaxA+luIvgXMoadg/I1D2Mis= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BJWNlxPI; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BJWNlxPI" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8b7105dfb35so20945116d6.3 for ; Fri, 08 May 2026 09:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778257739; x=1778862539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VJ1nt1raVmWGZpEel8fILUUX9Nl0Zn9ZJYTC5Z/rJck=; b=BJWNlxPIRI5pP5hqILaTzifN1Nu38hO6o5pFySLnw46sRBfOPXEVZsp/MFNundrZ2+ PO9/eJ4w++XM5qhDgqhWiepENTCqOwwWOgzPfPSjCvFk44XUP61yLQ53ijAtUXipvpzS yoGNfbhaWA2+c5PSb/6v1qwR6pVlJ7prjfNHA+AQTBgqcPWox4QhhJ4fxogBLGOJ5Y22 4kHfg9ocrNPZAdRHQ3J0I87SuQ5ggth6XUBpEJyXXNt0G1EeirODhs9d0pRFwgaWFLap qXH3fP5yUWh7O96mVdpO2JTzwGZrmKYVaHV8yReCwMcWkdwtRSbhydBiZs56zykWrmrK C1vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778257739; x=1778862539; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VJ1nt1raVmWGZpEel8fILUUX9Nl0Zn9ZJYTC5Z/rJck=; b=aYWOWrbi30Yq7hyEIvTZiA5bvkkbzYbjkx+FojHxHfLzhAU3uO6PbORKC4ubp7S2y8 U3CEsXpVtHepRhpyI1WI6jT/TvEk6YwKG9Qd7hVezkrZMpZ4wMHJ5dZfoJ5lofaiUIDj ieYbp2aME2JY7t6purkUR+uGLknd0SVIjv0BPB1AiPtk0/wTEgQAbmiu+JHY3AlEdxI0 8geqlpybXixMkDoenWDAeoddt8sg7EoWumROHa/54u5Abqrufyjo6cU7AVkiRBQVkmRv UYoaEY42WJYv3yPUSgv2SYPo9L6HDrr+YsjREegtdR6GD2nIGav2SuOTnTFzYYsRwlqO UKtw== X-Forwarded-Encrypted: i=1; AFNElJ/GwJ6hkbh9gtFqhwaf9qBdWKlYwJ8RPN4U39dIz54DYmDA/ir2iI1ro2jwxt1AuzN0JiZyMjHpLpK02NM=@vger.kernel.org X-Gm-Message-State: AOJu0YwyT6IYMnCJ3ZoOdPCYwj4UfPmdIy88/JxKIS0MB+JUYxX1H5ER nTPsjn7tnu6SJHH06+WycFU3EPNKlwB9SmWDYy0n+hXe68HucnQ61tSA X-Gm-Gg: Acq92OHRHTK1P4mnkLH04UyW/t+SAQdrVkeNMkk6cPMGD8O0dJRbpM3IxQgFBX1RhJM aeiii2p7sUn0xXj3p3Dsw9oYp2LN0/Jc9ObI2PGDO9b8m7BFzqKIX4k0Aub//yGku3egmsSLlZh f+0tb+Mj54roEbp0Y9fRxrP8+d1cJ5INYj9sKlLJ7LprB6yL4K/gd8zdAtOjb7IO5yO0cnPJ16f Zd2xZ25LxHf9iFBLVtNnjMiUVQoLrxmk+KNiPYpom872LGO1G0ydmVbDyhVsGdIe5adDNsfDt7i WLCtat/TvRx1er0o6aK1r57f4ZLWNebYL2Nj37UxY+AItJLZGVbfFqmg9575mlVI4D+xiIpl4/B /5mAxYRzRijdsej9AdvDj0rNWeqj5f3Md8cmjKsrNYLXn4NLXh32OQJdQBGG2+VZ6YFcpO6Z15A 0ypHTCE+O+udUzKAVBi1qPB6e6dHQ8odyBV5UX9llhDCjErZW02x14J1d9gd/cKJ9NMAOUU9qcm 9n+9aWrryRgH/FyGrGfbFKiuphl8XyEpXkzZw6BUhU= X-Received: by 2002:a05:6214:3f81:b0:89c:a2b2:8d44 with SMTP id 6a1803df08f44-8bc451770demr211625746d6.39.1778257738686; Fri, 08 May 2026 09:28:58 -0700 (PDT) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8bf3b0c4db9sm21343796d6.4.2026.05.08.09.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 09:28:58 -0700 (PDT) From: Ziyi Guo X-Google-Original-From: Ziyi Guo To: maciej.falkowski@linux.intel.com, karol.wachowski@linux.intel.com Cc: ogabbay@kernel.org, sumit.semwal@linaro.org, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Ziyi Guo Subject: [PATCH] accel/ivpu: Reject PRIME export of userptr BOs Date: Fri, 8 May 2026 16:28:56 +0000 Message-Id: <20260508162856.1131843-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Userptr BOs wrap pinned user pages in a private dma-buf solely for internal use by the NPU driver. Allowing userspace to re-export such a BO via DRM_IOCTL_PRIME_HANDLE_TO_FD would expose those pages to other drivers through an interface that was never intended to be shared. Override the driver's prime_handle_to_fd callback to detect dma-bufs backed by ivpu_gem_userptr_dmabuf_ops and reject the export with -EINVAL. Signed-off-by: Ziyi Guo --- drivers/accel/ivpu/ivpu_drv.c | 1 + drivers/accel/ivpu/ivpu_gem.c | 28 +++++++++++++++++++++++++++ drivers/accel/ivpu/ivpu_gem.h | 3 +++ drivers/accel/ivpu/ivpu_gem_userptr.c | 5 +++++ 4 files changed, 37 insertions(+) diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c index 2801378e3e19..086d4c769b33 100644 --- a/drivers/accel/ivpu/ivpu_drv.c +++ b/drivers/accel/ivpu/ivpu_drv.c @@ -545,6 +545,7 @@ static const struct drm_driver driver =3D { =20 .gem_create_object =3D ivpu_gem_create_object, .gem_prime_import =3D ivpu_gem_prime_import, + .prime_handle_to_fd =3D ivpu_gem_prime_handle_to_fd, =20 .ioctls =3D ivpu_drm_ioctls, .num_ioctls =3D ARRAY_SIZE(ivpu_drm_ioctls), diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c index 4f2005a8d496..82079f372b39 100644 --- a/drivers/accel/ivpu/ivpu_gem.c +++ b/drivers/accel/ivpu/ivpu_gem.c @@ -12,6 +12,7 @@ #include #include #include +#include #include =20 #include "ivpu_drv.h" @@ -249,6 +250,33 @@ struct drm_gem_object *ivpu_gem_prime_import(struct dr= m_device *dev, return ERR_PTR(ret); } =20 +int ivpu_gem_prime_handle_to_fd(struct drm_device *dev, struct drm_file *f= ile_priv, + u32 handle, u32 flags, int *prime_fd) +{ + struct ivpu_device *vdev =3D to_ivpu_device(dev); + struct dma_buf *dmabuf; + int fd; + + dmabuf =3D drm_gem_prime_handle_to_dmabuf(dev, file_priv, handle, flags); + if (IS_ERR(dmabuf)) + return PTR_ERR(dmabuf); + + if (ivpu_gem_is_userptr_dma_buf(dmabuf)) { + ivpu_dbg(vdev, IOCTL, "Exporting userptr BO is not allowed\n"); + dma_buf_put(dmabuf); + return -EINVAL; + } + + fd =3D dma_buf_fd(dmabuf, flags); + if (fd < 0) { + dma_buf_put(dmabuf); + return fd; + } + + *prime_fd =3D fd; + return 0; +} + static struct ivpu_bo *ivpu_bo_alloc(struct ivpu_device *vdev, u64 size, u= 32 flags) { struct drm_gem_shmem_object *shmem; diff --git a/drivers/accel/ivpu/ivpu_gem.h b/drivers/accel/ivpu/ivpu_gem.h index 0c3350f22b55..bfd15ce02354 100644 --- a/drivers/accel/ivpu/ivpu_gem.h +++ b/drivers/accel/ivpu/ivpu_gem.h @@ -29,6 +29,9 @@ void ivpu_bo_unbind_all_bos_from_context(struct ivpu_devi= ce *vdev, struct ivpu_m =20 struct drm_gem_object *ivpu_gem_create_object(struct drm_device *dev, size= _t size); struct drm_gem_object *ivpu_gem_prime_import(struct drm_device *dev, struc= t dma_buf *dma_buf); +int ivpu_gem_prime_handle_to_fd(struct drm_device *dev, struct drm_file *f= ile_priv, + u32 handle, u32 flags, int *prime_fd); +bool ivpu_gem_is_userptr_dma_buf(struct dma_buf *dma_buf); struct ivpu_bo *ivpu_bo_create(struct ivpu_device *vdev, struct ivpu_mmu_c= ontext *ctx, struct ivpu_addr_range *range, u64 size, u32 flags); struct ivpu_bo *ivpu_bo_create_runtime(struct ivpu_device *vdev, u64 addr,= u64 size, u32 flags); diff --git a/drivers/accel/ivpu/ivpu_gem_userptr.c b/drivers/accel/ivpu/ivp= u_gem_userptr.c index 7cbf3a4cdc73..45eabea5961e 100644 --- a/drivers/accel/ivpu/ivpu_gem_userptr.c +++ b/drivers/accel/ivpu/ivpu_gem_userptr.c @@ -61,6 +61,11 @@ static const struct dma_buf_ops ivpu_gem_userptr_dmabuf_= ops =3D { .release =3D ivpu_gem_userptr_dmabuf_release, }; =20 +bool ivpu_gem_is_userptr_dma_buf(struct dma_buf *dma_buf) +{ + return dma_buf->ops =3D=3D &ivpu_gem_userptr_dmabuf_ops; +} + static struct dma_buf * ivpu_create_userptr_dmabuf(struct ivpu_device *vdev, void __user *user_ptr, size_t size, uint32_t flags) --=20 2.34.1