From nobody Sat Jun 13 07:49:26 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010035.outbound.protection.outlook.com [52.101.61.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 332B13FB042 for ; Fri, 8 May 2026 15:32:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254368; cv=fail; b=aAGQ/fUvpPehdGBlwXWu7rvAvO+1Dl2gkzA2sJPCJsVwW3tMr+m4jdoRw3e6VUCiHh8C5iLn8xiFTEdrGu3Mk06sERFxW4oMKl981tfJStzCWIQLRf5cpCoriwOxp9HQqKMuQhyAfIHE+rxBDevFOYGrNQSI+xuxTAUEut/8Ggk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254368; c=relaxed/simple; bh=hoc1SCZUNgw7Ksn61qaTGBZClVngAy/n+u7lp3gR6iA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YnPr3YEMi/A18GsXqiKcTrlBpwrgyi8ZwXBtVDvYVa4jHNrm4wdEwgqR+RTUWk+a7alx8smBN8m1EfgDBaqv1DuCAeN8ONg3zJsfXeC/yoBtFdqp2MxLRtwwIQr2WVsXQqwUCoTNVrcT4H3Lx1pVqnX2Q37nKTXSrQUUdvgYjOo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=twKtc2r3; arc=fail smtp.client-ip=52.101.61.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="twKtc2r3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HBfj75qrDfSLPc/hGeKE1ohb3airz9Y4LU57QuO/XQwLnYFmKNgFCCAYuSLX8rhk2FVH8O2G1Gzsq8UOHXchCcCVXNKUgWSDYDACP9w9sm/iwiZG4zlEsfHSpLm6WCmqMZ699Oy7as95h8TbFuibLhgSPqMRnESK2BZ/TzorqfsYTekiArDoZrEuZeM0Js/+DmbM6EniY6RVRrk5gzLLdieSBSohquYwUkmwwPxXJYVq/KS+kBVg/ZAyI75K1UvaK2EL1bdTDZFyCzCa+U7FSFXW/5Psi3THjObY8UjNtftrt4H/JmczIXD8QPo4QY6+q18BUdxlvReZ1UXQKMVhxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WR7sVFz7wcSJyHRRMEky8mBk9xvmVoc0G8AZswQt50s=; b=pUo0FpRTtvpic6r6Ih57YHwbMvRsx3WDZS9bI36Cmal5bVgOujcXqkw8+gqoL5e+4WMJgIHh9/ZVZICD1mUC3orIwnvRlRqfJGeE8T7FcJw/qZ9/z275XxPNGhrNsI4GK9aBbqykS+hHhjUIvcKTUk+i6MXFbNIz/2nJP7oGJjz9Z7cn3hBXSIayuNKsD+4JKm4/HnzGWsM/55DLBWhAmx0L9R6s/vRoymNkQhXmZwLVISNzDotDpioUKq1XQDxHPMqoWMbPQX5FJ1WErVFQ58aW5T37YipWwIeBfkuao1xmUPecYvqZjcgASEruSKSl3d/dl/djBBoIo3tDoT6u+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=oss.qualcomm.com smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WR7sVFz7wcSJyHRRMEky8mBk9xvmVoc0G8AZswQt50s=; b=twKtc2r3yfRaA1IqKiO5LHtIhUEtbwj5MVxuZthOQ0WOyb3bBq13G4lN2t+90qXPWEbA1+cVbOolB+Sy+wlMQMVPGJ8bWSlptzW1LXznsOcaHafFNi0FIXRW/+eVahADgcZAsOPWIRjPKE4N4Ho61GmIZK3jV3rIH2ny+29oZKA= Received: from CY5PR13CA0030.namprd13.prod.outlook.com (2603:10b6:930::18) by IA3PR10MB8539.namprd10.prod.outlook.com (2603:10b6:208:580::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.16; Fri, 8 May 2026 15:32:44 +0000 Received: from CH2PEPF00000146.namprd02.prod.outlook.com (2603:10b6:930:0:cafe::76) by CY5PR13CA0030.outlook.office365.com (2603:10b6:930::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.25.12 via Frontend Transport; Fri, 8 May 2026 15:32:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by CH2PEPF00000146.mail.protection.outlook.com (10.167.244.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 15:32:42 +0000 Received: from DFLE215.ent.ti.com (10.64.6.73) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from DFLE202.ent.ti.com (10.64.6.60) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE202.ent.ti.com (10.64.6.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:14 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWEwF1647264; Fri, 8 May 2026 10:32:14 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , , Krzysztof Kozlowski Subject: [PATCH 01/11] soc: ti: knav_qmss: Remove remaining redundant ENOMEM printks Date: Fri, 8 May 2026 10:32:01 -0500 Message-ID: <20260508153211.3688277-2-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000146:EE_|IA3PR10MB8539:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b24a8ce-fcf6-4ce3-da93-08dead170bd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|376014|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: kpTq1wK+jjxEkxFzgNEwFs/amjODtjj4PAcyTDdrctRLVMdqxxknoHWK8Xmnq8TTVDEa9IfK14ut2f+zbbqH8VHuRFe2QOvhbMkOaLO++Jca2f92NVeG1iSTWKYD51H1mjcmBRPku1inqKkRXLQotxq4XBrs2OF+ZgCTPACM7mWnqme5y1DuP8DbbIzmZd8DqQNf8T1dlFFh+imKn+uK+eqjt4QyxEutz6hRICZ+pzYhtWWnBIXoAhydNJnokXdDmN00RvIKm5K7vst0jKlvcJgHFk/4pM4+yhTpfEHvtb7CGQ8A2yWg2U3EAHwq2RiIIgIX4QGrtaCDrtdZTpL7u/xJL55YoWA0WgsW4wZkjqfTuBYutyIiR8LrpJN7Ddia7Fz71KcoLOwuteXQkGzWWsdqPOLBF/wVi8tebdwBhjhG7Obt8T0zqWs+6n2JPijzwFh3G8EgcTlt76mgWbD22QWAfpgL8B1pWVp41TYWls8e2MbgvLOnjBkF6pY9z62VLzKNjE7XUhiCm5MRLCMbMLUJgtio2Wq6i4yavXv9gCkN/+eOPzg+eixOiukYSB9u+Q8QUoktiAx4kRtsOscukmARYDOZaULsVTmpSnyG8eexquPomAMKcbzORauFb7esM9lEqU/ZsST2/DY1xff/dj7WeyuOzBDN0GfQw6RbLymWQFz4sjmvQkQ+8n7KEGYz5Yq8yeWgQT8R8t/y1Mqjs6R/4cx0TEbsgDQcHcwswU4= X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(376014)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0TkGafpfY7Zc0yNk5GUtK0Voyi/behLp1kBj2GS7zM8P5oveezGDL1499lzyUQ6Qhtnad7Ap1kyfY56bAqdnVpfEU/p19b6gliGOb+ny3C/jlmkNTcq0HyIS3YVgJtG9KDXJfjX1Q0kVgiQHfmHEQZMaRyKIEL8w0mu30LyWh1yAIxg78fJ+bHzNefv5nMANFEkkexniKG0y06GaH/QoqvbotmX3CcRANjHkEHKCwFn3kB+80+CkC0zL0fNMZVrQ64vzneJUaYpKdtV6iwzsA6uzXkrcxvBYrTO778DPATHknf6k8zhBvBMp0ADprFVmW85jD9FqUKtdSLKPXIamYoIdS7U2FkTRp4MUvY2Xz4nNrWmNM1Gora46eZbReGClsEFvIgzZOs53k+Xb/nCUeY6/INNjlFw1cMzi6QfzlYfNr5TT6Abafb9JzBLNrpRZ X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:42.6434 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8b24a8ce-fcf6-4ce3-da93-08dead170bd2 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000146.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR10MB8539 Content-Type: text/plain; charset="utf-8" Commit 168d2fb78055 ("soc: ti: knav_qmss: Remove ENOMEM printks") removed redundant dev_err() calls after allocation failures in knav_queue_setup_regions, knav_queue_init_qmgrs and knav_queue_init_pdsps, but missed three further instances in knav_pool_create, knav_queue_setup_region and knav_setup_queue_range. Remove the missed instances. Signed-off-by: Nishanth Menon --- Cc: Krzysztof Kozlowski drivers/soc/ti/knav_qmss_queue.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index 86d7a9c9ae01..e87a42734f25 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -769,10 +769,8 @@ void *knav_pool_create(const char *name, return ERR_PTR(-ENODEV); =20 pool =3D devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL); - if (!pool) { - dev_err(kdev->dev, "out of memory allocating pool\n"); + if (!pool) return ERR_PTR(-ENOMEM); - } =20 for_each_region(kdev, reg_itr) { if (reg_itr->id !=3D region_id) @@ -1025,10 +1023,8 @@ static void knav_queue_setup_region(struct knav_devi= ce *kdev, region->dma_end =3D region->dma_start + size; =20 pool =3D devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL); - if (!pool) { - dev_err(kdev->dev, "out of memory allocating dummy pool\n"); + if (!pool) goto fail; - } pool->num_desc =3D 0; pool->region_offset =3D region->num_desc; list_add(&pool->region_inst, ®ion->pools); @@ -1211,10 +1207,8 @@ static int knav_setup_queue_range(struct knav_device= *kdev, int ret, i; =20 range =3D devm_kzalloc(dev, sizeof(*range), GFP_KERNEL); - if (!range) { - dev_err(dev, "out of memory allocating range\n"); + if (!range) return -ENOMEM; - } =20 range->kdev =3D kdev; range->name =3D knav_queue_find_name(node); --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013012.outbound.protection.outlook.com [40.93.201.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D44D32E62D9 for ; Fri, 8 May 2026 15:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254342; cv=fail; b=icw5s260YnCtwHrOUJ2zq7FB8jqBEkc8ivr6nFMfrlfvleMOZCXBANL0KqCJ855HIVDV4LQbl5uKotQMHW6ZdX6uA/P6NKpxkI7J4NwZ8IU3ruyWgY24Jph6JgE5VUB5tN59nBI23PiEMAkHnIGJM5wzg/Xt/kHOJWOvGAIEgTo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254342; c=relaxed/simple; bh=E0U2nsALdW3y04wLKV6JVH/r9njBAisRhACo9Cf8rDk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WmjjRVOuOixdSETOqipmEqcA1z42tVp72XsDfiTvGPpByf6tfzP3kmbLEPpmpbNB66TCoDb7seYgX0C3f61+pUpvUVGaMcAP4HuWaipebuMqqrcdHBqRKlsbzPNJblzcwM1ocrH7yDGJwgW1/6Alds5D6o4F5TsI6JIy7RqrVTw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=nZh/L1/7; arc=fail smtp.client-ip=40.93.201.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="nZh/L1/7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OxZm1PiCLOqWbAZ/mhc0BH9m0NZTdi5XvdJlRRuhF9ZPrR9OJHfyfcwvMGFywOykdWZV2543XbQcYhYOKglGEc3obb+MguaLgLGiDV6Kdvw0TmqmTl/PrahOqYiZxfidL1TO6e5rtc3Lfw5ZkYWZ62/5ANGvdTBSc/NG2d13bwl9Ov9H/H5HZslHtk2/cV4UgregHqZm6VgwGK4tD94aAQEUmmwNdtU9QE/hX7m3GqyUrs1X8eoRJA/eCLXcAnlYROzsdbUMmp+4/a6nTiYt6xvDZDZpR1ejZDqVD1Nf9R/Zefc/irupSYtS9zue4iWRup6XpzR331EWAjg69ObjBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IcU+keYZIui8HaY30EPbxflixrP7R0G3/3FnmiMflKc=; b=uJ8ULtzRh1yrs0gZyZGpjPrvVuDKPvR7hnW71jpl3/a9s8tzNvTeWodCUWhKsHobsVmvkUSS5GRLyxH3skz2oFX4oAq70Ox9VPyN1xYeWmScAzrAVUpYHorP83YtRhR0ZZhu13jYV2AQlsFq9Q/qyeoQkRKaHapZVmGIc14qOyluIjYeisKuzNnxlqrHRe/WrTSD2WWzkr0sx9WCfnn41uOz+ckX3eGrdfVONDRLUaau+R4SGAaHRF1VfgvgGc248U54GK8fZlnvIukoHt9n5UeKWIa0AOYHBvUr6kLwmLYgH48uNeEENU+R4mGH67EEs71rL6fAqYt1XrJShkggsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IcU+keYZIui8HaY30EPbxflixrP7R0G3/3FnmiMflKc=; b=nZh/L1/7tIpKY7DrBSOxe0wqcGR15FM3X7ozJUC/BnJ3m9BfHxoAcQS5fDuN/+d2++BGppePdLJfc4Nksm8Z7J/cHKx92op+TqDYsHRUfWjwZQxlEpAtsHd8QrKcT8f0skKDoYnVKSWYkHJ1TvasjwRZufLQqyPM/GCfBbPohm0= Received: from PH0PR07CA0108.namprd07.prod.outlook.com (2603:10b6:510:4::23) by IA1PR10MB6759.namprd10.prod.outlook.com (2603:10b6:208:42d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 15:32:18 +0000 Received: from MW1PEPF00016159.namprd21.prod.outlook.com (2603:10b6:510:4:cafe::17) by PH0PR07CA0108.outlook.office365.com (2603:10b6:510:4::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.19 via Frontend Transport; Fri, 8 May 2026 15:32:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by MW1PEPF00016159.mail.protection.outlook.com (10.167.249.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.1 via Frontend Transport; Fri, 8 May 2026 15:32:18 +0000 Received: from DLEE211.ent.ti.com (157.170.170.113) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from DLEE202.ent.ti.com (157.170.170.77) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:14 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWEdK1961975; Fri, 8 May 2026 10:32:14 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , Subject: [PATCH 02/11] soc: ti: knav_qmss: Rename global kdev to knav_qdev to fix -Wshadow Date: Fri, 8 May 2026 10:32:02 -0500 Message-ID: <20260508153211.3688277-3-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016159:EE_|IA1PR10MB6759:EE_ X-MS-Office365-Filtering-Correlation-Id: 45f9587a-d224-46b4-55ca-08dead16fd41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700016|1800799024|3023799003|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: MzB0ybDcGJopo2W/gaU3jualz8at6Ig3Xy17diWvYcV2djigHuz5Q+Q7ueBdaG51638KFCk3eHuUDWARnxNpUvKPzPdYofB318VAQ83Av1GsmK6rFt/B4Nak0EQfs10i3T5EROqpONC2LHvUGyTGNk7HJOl915AwWxroseq9cjVUBGtLueepmxzuzzP683yRFMVmcDl2d12x/UsqdJp8E3ojxcL0WQ0Gd3yuekHq0sJ54w7CcxbUxojQoHT1uPGx8jIyTrTLI0PyfYO+oHx8Y8EVqirhMijPHvbjKErgAyQgJH8Su1GV1FvY5xiI6FVFzBR7WMxDFqaksm8CFXVqdJxVbmpSTgy7tF9JkRoJq78L41Mqq3nfM7F12uzdN8VN9vQoP7eKlBaDbZYve3IUz25y4uGmR0qwnMuCQxgMnslkwIo0jqtp1k1/Y1m9q9jDTjwoOVBKrZRmWPPFMyTVuFh+7bgnS8XlrzoH3hnxhQ4hZnIByakSgsz1gqx6HHjCuiPLxnxZOeO2N4bTCK0F45UvdAZUxsHxnbW1SpDEew5lFOS5Drvwe0eFHGuJkf+ORyvjS5pQ3AsBzeDEGOiIQRX0QrKcvGw2ea3O2odTJhWmd4etdzw2t0yd8P6RmLzUD9tu1+GdKcCwY3Vy0DMZt4AFivK3J35sdGmWDyCo7qZy5Vw5dDZ7D4BW4wDxpvhOXlaPcPitepq/BUQ7M4GU3cpUpoypZPu2cOTxkL82jPg= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700016)(1800799024)(3023799003)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7HRJhOaLKXgUbBVfWYye8C7Li6r1QIBb1MsZkHfwOl0aLCvgIrmB6dbgoKyfC48CuIo+YVkHLKdybkYUdJeaXK9xYD7aCxEDtWxfeahVMQYvxjBPUUgEcmPBm8icW6nK90Y1wxXICUnrPSbs8JYRc9vb1yP7xhOSpkGPZuC89ktLrPfWrY9FfEhWlvSg021rXZqrylmKxNnrFR/5qVG23NJss6wMaWRVBkCoojLYjU8bG+uu8Gc9Q9irXKIqLomCHOGmEIELLC+1FEMuCo/p8HztSZFokGucNqN7bbhy2Cdahj0igajnO8xH/2b0SDM6/COJlyPwA1kCYindsWz9osRCJMhVB5byRsoOANw2KlRaVrdohNfDHjIHATcSMSYY/CaR0yWh1R3wYAvsZyo6RQT7aYfsvo9lmSVeiDnSpItsuq4WqPvIF8RCQTednG/H X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:18.1647 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45f9587a-d224-46b4-55ca-08dead16fd41 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MW1PEPF00016159.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6759 Content-Type: text/plain; charset="utf-8" Building with W=3D2 (clang, LLVM=3D1) produces 22 -Wshadow warnings in knav_qmss_queue.c because the file-scoped singleton 'kdev' is shadowed by a parameter of the same name in 21 internal functions and one local variable, e.g.: knav_qmss_queue.c:194:49: warning: declaration shadows a variable in the global scope [-Wshadow] 194 | knav_queue_match_id_to_inst(struct knav_device *kdev, unsigned id) Rename the global singleton from kdev to knav_qdev rather than renaming all ~21 function parameters, as this requires fewer changes and leaves function signatures, struct field accesses, and header macros in knav_qmss.h untouched. Signed-off-by: Nishanth Menon --- drivers/soc/ti/knav_qmss_queue.c | 94 ++++++++++++++++---------------- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index e87a42734f25..2c103bb6edef 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -25,7 +25,7 @@ =20 #include "knav_qmss.h" =20 -static struct knav_device *kdev; +static struct knav_device *knav_qdev; static DEFINE_MUTEX(knav_dev_lock); #define knav_dev_lock_held() \ lockdep_is_held(&knav_dev_lock) @@ -205,10 +205,10 @@ knav_queue_match_id_to_inst(struct knav_device *kdev,= unsigned id) =20 static inline struct knav_queue_inst *knav_queue_find_by_id(int id) { - if (kdev->base_id <=3D id && - kdev->base_id + kdev->num_queues > id) { - id -=3D kdev->base_id; - return knav_queue_match_id_to_inst(kdev, id); + if (knav_qdev->base_id <=3D id && + knav_qdev->base_id + knav_qdev->num_queues > id) { + id -=3D knav_qdev->base_id; + return knav_queue_match_id_to_inst(knav_qdev, id); } return NULL; } @@ -296,7 +296,7 @@ static struct knav_queue *knav_queue_open_by_type(const= char *name, =20 mutex_lock(&knav_dev_lock); =20 - for_each_instance(idx, inst, kdev) { + for_each_instance(idx, inst, knav_qdev) { if (knav_queue_is_reserved(inst)) continue; if (!knav_queue_match_type(inst, type)) @@ -469,9 +469,9 @@ static int knav_queue_debug_show(struct seq_file *s, vo= id *v) =20 mutex_lock(&knav_dev_lock); seq_printf(s, "%s: %u-%u\n", - dev_name(kdev->dev), kdev->base_id, - kdev->base_id + kdev->num_queues - 1); - for_each_instance(idx, inst, kdev) + dev_name(knav_qdev->dev), knav_qdev->base_id, + knav_qdev->base_id + knav_qdev->num_queues - 1); + for_each_instance(idx, inst, knav_qdev) knav_queue_debug_show_instance(s, inst); mutex_unlock(&knav_dev_lock); =20 @@ -762,17 +762,17 @@ void *knav_pool_create(const char *name, unsigned last_offset; int ret; =20 - if (!kdev) + if (!knav_qdev) return ERR_PTR(-EPROBE_DEFER); =20 - if (!kdev->dev) + if (!knav_qdev->dev) return ERR_PTR(-ENODEV); =20 - pool =3D devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL); + pool =3D devm_kzalloc(knav_qdev->dev, sizeof(*pool), GFP_KERNEL); if (!pool) return ERR_PTR(-ENOMEM); =20 - for_each_region(kdev, reg_itr) { + for_each_region(knav_qdev, reg_itr) { if (reg_itr->id !=3D region_id) continue; region =3D reg_itr; @@ -780,14 +780,14 @@ void *knav_pool_create(const char *name, } =20 if (!region) { - dev_err(kdev->dev, "region-id(%d) not found\n", region_id); + dev_err(knav_qdev->dev, "region-id(%d) not found\n", region_id); ret =3D -EINVAL; goto err; } =20 pool->queue =3D knav_queue_open(name, KNAV_QUEUE_GP, 0); if (IS_ERR(pool->queue)) { - dev_err(kdev->dev, + dev_err(knav_qdev->dev, "failed to open queue for pool(%s), error %ld\n", name, PTR_ERR(pool->queue)); ret =3D PTR_ERR(pool->queue); @@ -795,13 +795,13 @@ void *knav_pool_create(const char *name, } =20 pool->name =3D kstrndup(name, KNAV_NAME_SIZE - 1, GFP_KERNEL); - pool->kdev =3D kdev; - pool->dev =3D kdev->dev; + pool->kdev =3D knav_qdev; + pool->dev =3D knav_qdev->dev; =20 mutex_lock(&knav_dev_lock); =20 if (num_desc > (region->num_desc - region->used_desc)) { - dev_err(kdev->dev, "out of descs in region(%d) for pool(%s)\n", + dev_err(knav_qdev->dev, "out of descs in region(%d) for pool(%s)\n", region_id, name); ret =3D -ENOMEM; goto err_unlock; @@ -827,10 +827,10 @@ void *knav_pool_create(const char *name, pool->num_desc =3D num_desc; pool->region_offset =3D last_offset; region->used_desc +=3D num_desc; - list_add_tail(&pool->list, &kdev->pools); + list_add_tail(&pool->list, &knav_qdev->pools); list_add_tail(&pool->region_inst, node); } else { - dev_err(kdev->dev, "pool(%s) create failed: fragmented desc pool in regi= on(%d)\n", + dev_err(knav_qdev->dev, "pool(%s) create failed: fragmented desc pool in= region(%d)\n", name, region_id); ret =3D -ENOMEM; goto err_unlock; @@ -844,7 +844,7 @@ void *knav_pool_create(const char *name, mutex_unlock(&knav_dev_lock); err: kfree(pool->name); - devm_kfree(kdev->dev, pool); + devm_kfree(knav_qdev->dev, pool); return ERR_PTR(ret); } EXPORT_SYMBOL_GPL(knav_pool_create); @@ -872,7 +872,7 @@ void knav_pool_destroy(void *ph) =20 mutex_unlock(&knav_dev_lock); kfree(pool->name); - devm_kfree(kdev->dev, pool); + devm_kfree(knav_qdev->dev, pool); } EXPORT_SYMBOL_GPL(knav_pool_destroy); =20 @@ -1683,7 +1683,7 @@ static inline struct knav_qmgr_info *knav_find_qmgr(u= nsigned id) { struct knav_qmgr_info *qmgr; =20 - for_each_qmgr(kdev, qmgr) { + for_each_qmgr(knav_qdev, qmgr) { if ((id >=3D qmgr->start_queue) && (id < qmgr->start_queue + qmgr->num_queues)) return qmgr; @@ -1775,22 +1775,22 @@ static int knav_queue_probe(struct platform_device = *pdev) return -ENODEV; } =20 - kdev =3D devm_kzalloc(dev, sizeof(struct knav_device), GFP_KERNEL); - if (!kdev) { + knav_qdev =3D devm_kzalloc(dev, sizeof(struct knav_device), GFP_KERNEL); + if (!knav_qdev) { dev_err(dev, "memory allocation failed\n"); return -ENOMEM; } =20 if (device_get_match_data(dev)) - kdev->version =3D QMSS_66AK2G; + knav_qdev->version =3D QMSS_66AK2G; =20 - platform_set_drvdata(pdev, kdev); - kdev->dev =3D dev; - INIT_LIST_HEAD(&kdev->queue_ranges); - INIT_LIST_HEAD(&kdev->qmgrs); - INIT_LIST_HEAD(&kdev->pools); - INIT_LIST_HEAD(&kdev->regions); - INIT_LIST_HEAD(&kdev->pdsps); + platform_set_drvdata(pdev, knav_qdev); + knav_qdev->dev =3D dev; + INIT_LIST_HEAD(&knav_qdev->queue_ranges); + INIT_LIST_HEAD(&knav_qdev->qmgrs); + INIT_LIST_HEAD(&knav_qdev->pools); + INIT_LIST_HEAD(&knav_qdev->regions); + INIT_LIST_HEAD(&knav_qdev->pdsps); =20 pm_runtime_enable(&pdev->dev); ret =3D pm_runtime_resume_and_get(&pdev->dev); @@ -1805,31 +1805,31 @@ static int knav_queue_probe(struct platform_device = *pdev) ret =3D -ENODEV; goto err; } - kdev->base_id =3D temp[0]; - kdev->num_queues =3D temp[1]; + knav_qdev->base_id =3D temp[0]; + knav_qdev->num_queues =3D temp[1]; =20 /* Initialize queue managers using device tree configuration */ - ret =3D knav_queue_init_qmgrs(kdev, node); + ret =3D knav_queue_init_qmgrs(knav_qdev, node); if (ret) goto err; =20 /* get pdsp configuration values from device tree */ - ret =3D knav_queue_setup_pdsps(kdev, node); + ret =3D knav_queue_setup_pdsps(knav_qdev, node); if (ret) goto err; =20 /* get usable queue range values from device tree */ - ret =3D knav_setup_queue_pools(kdev, node); + ret =3D knav_setup_queue_pools(knav_qdev, node); if (ret) goto err; =20 - ret =3D knav_get_link_ram(kdev, "linkram0", &kdev->link_rams[0]); + ret =3D knav_get_link_ram(knav_qdev, "linkram0", &knav_qdev->link_rams[0]= ); if (ret) { - dev_err(kdev->dev, "could not setup linking ram\n"); + dev_err(knav_qdev->dev, "could not setup linking ram\n"); goto err; } =20 - ret =3D knav_get_link_ram(kdev, "linkram1", &kdev->link_rams[1]); + ret =3D knav_get_link_ram(knav_qdev, "linkram1", &knav_qdev->link_rams[1]= ); if (ret) { /* * nothing really, we have one linking ram already, so we just @@ -1837,15 +1837,15 @@ static int knav_queue_probe(struct platform_device = *pdev) */ } =20 - ret =3D knav_queue_setup_link_ram(kdev); + ret =3D knav_queue_setup_link_ram(knav_qdev); if (ret) goto err; =20 - ret =3D knav_queue_setup_regions(kdev, node); + ret =3D knav_queue_setup_regions(knav_qdev, node); if (ret) goto err; =20 - ret =3D knav_queue_init_queues(kdev); + ret =3D knav_queue_init_queues(knav_qdev); if (ret < 0) { dev_err(dev, "hwqueue initialization failed\n"); goto err; @@ -1857,9 +1857,9 @@ static int knav_queue_probe(struct platform_device *p= dev) return 0; =20 err: - knav_queue_stop_pdsps(kdev); - knav_queue_free_regions(kdev); - knav_free_queue_ranges(kdev); + knav_queue_stop_pdsps(knav_qdev); + knav_queue_free_regions(knav_qdev); + knav_free_queue_ranges(knav_qdev); pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); return ret; --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011010.outbound.protection.outlook.com [40.93.194.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE6B133F8B7 for ; Fri, 8 May 2026 15:32:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254346; cv=fail; b=Je5J/utLeEVjOovxotXMQseEjXrBB7S7KmUt7wr3dYr4fsamDvsE+uCUTgJ/pnAjRgE0XuhfIAvh+JIhq5oELQu98kKdmZcssSUrCVP0DVTwr8PnqjbZlcOpjp/d51+AcONimt0qM1990kAh70oCf/ubE0sp+qmIencNVeWNtgU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254346; c=relaxed/simple; bh=wB1cAEwt3zl9I15mjxw2GbpZlLh/GZRnqHV7uyQk6XU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l6gs6oO+h+YdHvBT5KK2lOcK56TkvrDtGaCmBoPA0hqm/BvJIGoRntLG/ZeIGtSEmGdQUn9+/byrr2XTMkyirAYCVr12JLgJ5W7T5GV4IPok8Kwac+6VjCniPK/ePekz8Lbt1wXo4YW/qrCxqrQDr3Th4fvYzPNtzl4ytL+nAaw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ZVEhDsHb; arc=fail smtp.client-ip=40.93.194.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ZVEhDsHb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l/Ucp/LhufeCy1aF+V5cuRPlgne9EDiA74PyJ8KDg7AGTzFrofcGFS/oBY4/HRfv7iwbH6Vs6PRT95t0Cdgxwu63c4JK7qO8YGmE8YuiXyAUz0Q29FkQ2j5f/4OQP5CL6enOMZuU139aas6/o5o45+a0ydxlAJXVe4FdqfNulArR4Jri2pegrtRhI84HaGvA3A6Mhe0btX+yfMeQlUqePiLUF89LtqOJbep98qd/KYtTGNfXMlQKaKiOG2vQKb3MmiIa81spzV6E2yp8rRvUFjg8OkNGg6sjCL0qdNTZsrdbkUZb9SK+MXpLiDfCYmcE9BNrccoEHWvkOucs1b2KLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MCoBY7Vg2ebbF/UP1l9bOG5TinWbL0YiTiEm14Rm55o=; b=IeTvwpVFpUncmgwhel82IEqQdh0Bgs8VY+rnx77NwFON5vV+/ux9DKW6Szbv3uFeHyZzQoDCgVEBr+LbJWjPCSP5w5u5tszT2fndLPNQQOp8yiK0Aq8trAsdf+VDCWAslXcJE7PIWwTn4/NHAwZ1j0UXb2MdIvhfsX46QuFRViwEVR/XmcigqbPeBOgrRXZM3VHLUM+wIH+A6WkUUOeg25zEs9gR6OrvBppdPio2gcvm3JdlieQViO6HkqPru6rhZzbbkaYc34a/8PRhMaSFR0EqSTClcomFhHADhW1jkQoN/hODXnqsmG3v7ReLLu4TaXnKYKkU58bsH7Iadb53ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MCoBY7Vg2ebbF/UP1l9bOG5TinWbL0YiTiEm14Rm55o=; b=ZVEhDsHbQcqkVCOpb8OiSso51pDb0xldr/WN1/OsmdaIHMjMSy8QGOYVXPXdB9qHqfC7XycjUWdIp7Y7tbjtkAWBQI95FKuN9hNi1mjSDuxIwVsTozv05hgXpTB+Fla97uzqsbQ7VZguFrmmIAS2+u0hLJ+mzQTHy/p12mada6Y= Received: from PH0PR07CA0115.namprd07.prod.outlook.com (2603:10b6:510:4::30) by SA2PR10MB4458.namprd10.prod.outlook.com (2603:10b6:806:f8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.20; Fri, 8 May 2026 15:32:17 +0000 Received: from MW1PEPF00016159.namprd21.prod.outlook.com (2603:10b6:510:4:cafe::d8) by PH0PR07CA0115.outlook.office365.com (2603:10b6:510:4::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.18 via Frontend Transport; Fri, 8 May 2026 15:32:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by MW1PEPF00016159.mail.protection.outlook.com (10.167.249.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.1 via Frontend Transport; Fri, 8 May 2026 15:32:17 +0000 Received: from DLEE210.ent.ti.com (157.170.170.112) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from DLEE200.ent.ti.com (157.170.170.75) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE200.ent.ti.com (157.170.170.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:14 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWEMD1961978; Fri, 8 May 2026 10:32:14 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , Subject: [PATCH 03/11] soc: ti: knav_qmss: Inline lockdep condition in for_each_handle_rcu Date: Fri, 8 May 2026 10:32:03 -0500 Message-ID: <20260508153211.3688277-4-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016159:EE_|SA2PR10MB4458:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bcd8c55-cd6a-433a-786b-08dead16fcaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700016|82310400026|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: OosTUbnJ8Vdo3nL8hXTBZdbuffAXz7YuUg7px9YkWgWGC13Xu9c4dCS5Bi2Ll52ptOEAjaWYOl8/2xLErStmchWtEsLOowSOSvKIT0alV5jB8p/bdJiGMDDB7+d5FAftfZpAJNVlN62kjX1n/JR6JAdIfgyQyq705rnmlIGByq7usiIRhMf68dIcHqVJVUlqWfN0I4ZBHzoNbJOx/nhjPHF9TT2NP2BEWcCqTladY0BxCLX1N9KPIeaI6Ki1qCWIRmRkBQL9kayOxR+ip250zxjgkpYeJaU0kiL17RDcigkDPVeAZJw1t7+MjgmIuCz0AjFBrNPp7UGy1U9jyRvyxgUWDBKKveomadbUS0QdXL+fat5Rxd50AEgv+D5cGw4U0ZWj0RZKMdW71rd1Hd/qMcG0HQoG+86jhrwRQgxble1bw4OqDSOEeESrGxNZoJRJP/Jrr2ZPS7AfxGCmJS6gfWU+25Pq5ckCwDI/Be+cj761COaJr7np2VK4ox+MqcCOfcDI/9cIzxnZVOjsasW5euOGWJ7wNrDzUzKxfkTKBRlcAgUPUoGVsLqRdGQwRLQUOHEN1rm2Umi/6kPzTTw2FdfLxM02fybMgGbA5X2rf7sczaXJwqWzgoOpMzmjkwsj2IXy3hx9/HFa9p4dOVTO3xTYCD/a7wsyp1RV2uWv50H/ro/pKFXgZP7oNTYVxBdSJraVeW24Hjp7nMwXhYOJ1if/GHCA/7F3xQfChslb2LI= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700016)(82310400026)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1C6RXErMyBFnuDwdL+6twbd9fzVHKzfDVVyd+5nVEr7IA+5vuBZwR8BSMcEuZqtbtdZ5TMy5Jk2KZy6kTL83WW85WRcYK8DhkQTIXKOF8177blIMRklIPIlAFEE/LXZ0ISUrI6EJ1on8gpot9bwRQFIKwT0b4A4JSzBS0GsIRWw6hxTD6tVn/lm3eZIiO7SLmUVNJ/BzOxsQqykBK2yXg8DEpH/rYlicmjI8HcA4IOXipJwhdUY0qnU2GVxwT9rXE6PX6BRSr9bbzjXJWkt43UEVaNhaH9ZdgG4ZMpL6w+BCyRMIurGqW5jbsnV+s91JKRDrl6lDA+RS1pVly48a2ZYDNdrOJJ32P/wtGJ+2FebZ64DZfzb8yf4uc7/1VqM7kEMGroWoNFV7n2hQJVotziPyzrpnfNWiAQR5Nm7MmIqpXuDEDK26DbRuiV2K5rs4 X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:17.1750 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1bcd8c55-cd6a-433a-786b-08dead16fcaa X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MW1PEPF00016159.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4458 Content-Type: text/plain; charset="utf-8" knav_dev_lock_held() is a single-use wrapper around lockdep_is_held(&knav_dev_lock), used only as the lockdep condition in for_each_handle_rcu. When CONFIG_LOCKDEP is disabled, list_for_each_entry_rcu() elides the condition argument entirely, causing clang to report the macro as unused with W=3D2: knav_qmss_queue.c:30:9: warning: macro is not used [-Wunused-macros] 30 | #define knav_dev_lock_held() \ Remove the intermediate macro and open-code lockdep_is_held() directly in the for_each_handle_rcu definition. Signed-off-by: Nishanth Menon Reviewed-by: Andrew Davis --- drivers/soc/ti/knav_qmss_queue.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index 2c103bb6edef..f65658014b05 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -27,9 +27,6 @@ =20 static struct knav_device *knav_qdev; static DEFINE_MUTEX(knav_dev_lock); -#define knav_dev_lock_held() \ - lockdep_is_held(&knav_dev_lock) - /* Queue manager register indices in DTS */ #define KNAV_QUEUE_PEEK_REG_INDEX 0 #define KNAV_QUEUE_STATUS_REG_INDEX 1 @@ -58,7 +55,7 @@ static DEFINE_MUTEX(knav_dev_lock); =20 #define for_each_handle_rcu(qh, inst) \ list_for_each_entry_rcu(qh, &inst->handles, list, \ - knav_dev_lock_held()) + lockdep_is_held(&knav_dev_lock)) =20 #define for_each_instance(idx, inst, kdev) \ for (idx =3D 0, inst =3D kdev->instances; \ --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011002.outbound.protection.outlook.com [52.101.62.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFB83F65E5 for ; Fri, 8 May 2026 15:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254365; cv=fail; b=ce3yJW8VzlQ1idlRkyKxWOECJWt8QoB6tPikBOASQZ0pXqFSh0/KVKjkLTWtgzYu83Pwnuc1EeKtoYCDXJ4GOi1RJEgQnNMAyrsO/TXrboDmD+lGMCNm6BtCF/rK2b50WvordERei4u7m3V7MaeZo4vJK8PsSBI9ha2HRPp3y3c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254365; c=relaxed/simple; bh=Uc4gjQ8xV1Ucl68L+6ZVKjd8esLfkCQ2UX0GUMnXLf4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rpOPYkBxoSHyhoYai6dLrjgDWgsMoMGeiw7e3FORJzpxUYEM8V2cx3bCX+XmW2gUF18qZh1OX3M0iIwSkTmiI548aivS2C+0K2HFMDT3kBgUnv6BdLZCLbEXT/7kQmIqgq0Lle8Zfu/UWdVwipco5NDZXlAsbbJA+FyBGdHcvC4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=PJSQX4D+; arc=fail smtp.client-ip=52.101.62.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="PJSQX4D+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Lsn6LdEw3VKG5FTaHqn3I+jFS39M2F3HDlChhoOXzPmCqtaY0NCaPTwusTR3PmbQ1hI7CnaXH1B3K31PAOyXgvf3Ufq+KrSbpzLNNTuVNVwSwmG25fEAgj21JVmGj4Ul2zGWG6++zKAzMTyNNazRDv70hBRucSU4UgJrYyKEV+Ks0LB2fNfLss0h+bWhpgWQgz9+Oj3BDDR3j7ziXh503ZUunosYS2rZIGpfnrTXeC6r0cdTmk3QOD5kXdEhK6Nc3SvumNzem6Wsz7JyDu1yOjqXS6+/W+/HVUG5bqoBb6pySexR0OMlXW6VEJkPLo7ZmInrK/REBKTYpI+KSAanrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mVDqSYfPSB4i8IsuYkEc8NZ4nMHnsvHXNYfVJR65Vpo=; b=pVXtlFKaCc9jqKIcCFBEpuaa1u9J8h3/rHQX/Le8ZxelWTlWcH3l+vVpA2XI3dCmbO1GalPaGvl6Ys++HIbxyWeDriJgGPST0EBRbBTAPILUui1Xb2ahNQ/0KAEP3kTVefmnQcW9F+/JAP00neny+8ptV2i9NYpt/VEFAh7SWIbtx0QPBFKooZEZSS8XpNmYY+IV0v9TCEZYtNymWDqQpIc3+URZKVdJopFM/Nf9QMEhPJsEKEIXqtq4MXwGdSkMd4nwsorEeMOreLUPSwLp5kEna8MqcOfuWZRAgoustlyhiWoPq5sRUDdltoY3RMJNhEE3n4REtlVn+5UPrWOJ3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=infradead.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mVDqSYfPSB4i8IsuYkEc8NZ4nMHnsvHXNYfVJR65Vpo=; b=PJSQX4D+Ga/L2R9wDxINBGT29W7yrcT/N+ezYNYSPioynsn0t4eJJNTv8NKEDgcBZHEFNAVccaRI+0t0qqMzdFUP5PjEor/7uhg38NW7lvM8Hw2kMUNIlX5BLs5GqvvjuIUNQKepMa4Rr7FrV33hH742/gP+fpU6GXt2qz3rCX8= Received: from BY1P220CA0013.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:59d::17) by MW4PR10MB6297.namprd10.prod.outlook.com (2603:10b6:303:1e1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.20; Fri, 8 May 2026 15:32:42 +0000 Received: from SJ5PEPF000001F0.namprd05.prod.outlook.com (2603:10b6:a03:59d:cafe::ce) by BY1P220CA0013.outlook.office365.com (2603:10b6:a03:59d::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.20 via Frontend Transport; Fri, 8 May 2026 15:32:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by SJ5PEPF000001F0.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 15:32:40 +0000 Received: from DFLE212.ent.ti.com (10.64.6.70) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from DFLE212.ent.ti.com (10.64.6.70) by DFLE212.ent.ti.com (10.64.6.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE212.ent.ti.com (10.64.6.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:14 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWEkL1961981; Fri, 8 May 2026 10:32:14 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , , Randy Dunlap Subject: [PATCH 04/11] soc: ti: knav_qmss: Fix kernel-doc Return: tags Date: Fri, 8 May 2026 10:32:04 -0500 Message-ID: <20260508153211.3688277-5-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F0:EE_|MW4PR10MB6297:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d71c908-4ab3-4931-7135-08dead170aad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|18002099003|22082099003|56012099003|3023799003; X-Microsoft-Antispam-Message-Info: YaDJV2PSv1nJhXBl2tfUDOjUpYOPLw/43fqSWzz24CToiimkey+s4xUcRl4UmYcnrxZNTcyf8jr6RwC5elyxUhhlxQSDJ+tgMMq1PfxAlg4ZbJJ/UofYdibjqSJvg09fc33WO+Jmgc4jOKNPoUR6w3CtqTInS3y5oG2BrjBvhTEA6BPbUjhC3bSFyoXrtNFRrIP9z3vGcTGi8DEnQY8B9RhF+SJ4+GVum1m6XqmdYYOR+WDEcmSTF+51mbKBi9WeA/S4sTkv+Yp3sYlJ+uk6xjYkYrLFmBORl3/ksxrdFeinaVrp5+0YOdKcUyQKii65tTTzPh4H5r0S8D19tTwofTyRHjmd3kwLmYM+/BEyU0RF9qMWjGjAs6W+2Q9ACjDQtPfnZ7h+F+kLu+IMmEX3IgQcWc97/oiBLIbr/KR5RncLLYIHyoscSLPeobyBIi3MAyErJFQUzpA5nm4PSsUB0XcZjXtXG8JxLgSTs57h7WfekRyRzPvBQe/T7Du2ffHYqDIVuJw4Vs3/J1gfuOCZCNDza2heZ0FP5BaJ8oRrn3WLX66aDWtWR7NDL/zj44JDA1xJp3jYZHGlwd2Spfzo/cu0U/B5mZ+C/pDxoLn9/yUeV+emWRoE6yVAhBl8o0x0+KOj48xD/BvT2j8AW5QI1TpOKeObWzn5DM4EljmY+dPF5jl84MbkhrQwlEow+9Jz59Mo4B1c9utaWPGHjVzcs0dlpN162q8AlO6mzrxf07I= X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(18002099003)(22082099003)(56012099003)(3023799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sFCOcJOIjXlUDiaR3CNoVlgIl+g5yE2MYeoMMSuRj+AGdhzCu1euDWtneIb0yHgt0wcBnKu1hhcRODvVspFQnVfuXPGFyYZ1SpC52n/byYUmeMn2DwobmcWpHMdnhG7soNJHvFDUw8RecyCF070gihAis40Y6kCQ1OnDrYJddIWXKBO/B4nMvl4pGQWIPc35PdllB92ah762PgcnSkUfnZbgu5tmkemWGO3EKR5LZ6R8BF8pt2qrMrMZYJZXSb3YqUxL7LTgGwrSIrg/AF3TPp0LuD1H02MbDbnfzTDn1fzy/MJPf1yYAfUujR8UyVEgal14YcOyP4NXDK+wpwRMiKXCsRKwxLVH94ju2NJUwlyFvpXpMGMqWsQQn8aWvzZ+6aSMZmRv8ELLmS+R5dJF7+sYS/SnL2pZEyWoGgZRdE9w8NyQbEITIxGqe7odZz3i X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:40.6928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d71c908-4ab3-4931-7135-08dead170aad X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6297 Content-Type: text/plain; charset="utf-8" Fix functions that use inline 'Returns ...' instead of 'Return:' kernel-doc comments, producing warnings with W=3D2: knav_qmss_queue.c:524: No description found for return value of 'knav_queue_open' Signed-off-by: Nishanth Menon Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- Cc: Randy Dunlap drivers/soc/ti/knav_qmss_queue.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index f65658014b05..c3f85052002b 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -517,7 +517,7 @@ static int knav_queue_flush(struct knav_queue *qh) * Subsequent attempts to open a shared queue should * also have this flag. * - * Returns a handle to the open hardware queue if successful. Use IS_ERR() + * Return: handle to the open hardware queue on success. Use IS_ERR() * to check the returned value for error codes. */ void *knav_queue_open(const char *name, unsigned id, @@ -573,7 +573,7 @@ EXPORT_SYMBOL_GPL(knav_queue_close); * @cmd: - control commands * @arg: - command argument * - * Returns 0 on success, errno otherwise. + * Return: 0 on success, errno otherwise. */ int knav_queue_device_control(void *qhandle, enum knav_queue_ctrl_cmd cmd, unsigned long arg) @@ -625,7 +625,7 @@ EXPORT_SYMBOL_GPL(knav_queue_device_control); * @size: - size of data to push * @flags: - can be used to pass additional information * - * Returns 0 on success, errno otherwise. + * Return: 0 on success, errno otherwise. */ int knav_queue_push(void *qhandle, dma_addr_t dma, unsigned size, unsigned flags) @@ -646,7 +646,7 @@ EXPORT_SYMBOL_GPL(knav_queue_push); * @qhandle: - hardware queue handle * @size: - (optional) size of the data pop'ed. * - * Returns a DMA address on success, 0 on failure. + * Return: DMA address on success, 0 on failure. */ dma_addr_t knav_queue_pop(void *qhandle, unsigned *size) { @@ -747,8 +747,8 @@ EXPORT_SYMBOL_GPL(knav_pool_desc_dma_to_virt); * @region_id: - QMSS region id from which the descriptors are to be * allocated. * - * Returns a pool handle on success. - * Use IS_ERR_OR_NULL() to identify error values on return. + * Return: pool handle on success. Use IS_ERR_OR_NULL() to identify + * error values on return. */ void *knav_pool_create(const char *name, int num_desc, int region_id) @@ -878,7 +878,7 @@ EXPORT_SYMBOL_GPL(knav_pool_destroy); * knav_pool_desc_get() - Get a descriptor from the pool * @ph: - pool handle * - * Returns descriptor from the pool. + * Return: descriptor from the pool on success, error pointer otherwise. */ void *knav_pool_desc_get(void *ph) { @@ -917,7 +917,7 @@ EXPORT_SYMBOL_GPL(knav_pool_desc_put); * @dma: - DMA address return pointer * @dma_sz: - adjusted return pointer * - * Returns 0 on success, errno otherwise. + * Return: 0 on success, errno otherwise. */ int knav_pool_desc_map(void *ph, void *desc, unsigned size, dma_addr_t *dma, unsigned *dma_sz) @@ -942,7 +942,7 @@ EXPORT_SYMBOL_GPL(knav_pool_desc_map); * @dma: - DMA address of descriptor to unmap * @dma_sz: - size of descriptor to unmap * - * Returns descriptor address on success, Use IS_ERR_OR_NULL() to identify + * Return: descriptor address on success. Use IS_ERR_OR_NULL() to identify * error values on return. */ void *knav_pool_desc_unmap(void *ph, dma_addr_t dma, unsigned dma_sz) @@ -962,7 +962,8 @@ EXPORT_SYMBOL_GPL(knav_pool_desc_unmap); /** * knav_pool_count() - Get the number of descriptors in pool. * @ph: - pool handle - * Returns number of elements in the pool. + * + * Return: number of elements in the pool. */ int knav_pool_count(void *ph) { --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011062.outbound.protection.outlook.com [52.101.52.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8922C36F426 for ; Fri, 8 May 2026 15:32:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254347; cv=fail; b=DpZqOX5UoxH+M+UOERxcdLB9BE84u01A6377glfP6KxM5tHlbYUIZqKvL3/wTFO46aURlhai96Wkv3izAkzesWA/33Orpomxe9mJB7X7uh1KnAF8zVnD+S/L6lf2JqPFhqauiAsSrtyUT3O6Jv/95oWF6j92BgJfBdpAJThR+5s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254347; c=relaxed/simple; bh=JiGGqPH2dt7oLGHILmrowKGD5m5ZZ3F6cLy46OpvWQk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GujXO6TqaanDDZEEw9V/RReRZfpcwD/xGX+qmOBET9ClId8+YzbGxI6RuYFP8JMGV3JJPtqxcqZ9FguOivVI5viNPzECIa08z4JEHCZ5zBtCG1iYywEfVMFcwQe1aqbHIluvenZn1GClnMr8hzxxF+ukYfUIoFmnu+75fixfquo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=mOnhk9Fv; arc=fail smtp.client-ip=52.101.52.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="mOnhk9Fv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YgtQIsiV0LCzHe0tS/TklBRM7uPBHqI/4vZ02rOnvahwhm2NUtH3K6s7NrQ1rmvYiusklvbdNmwWEYerZ+ihd8fqLNJzh13D3Qr9R87Darb5eXLPDic2fZCQpH/88z3lN9IcaS4tgctCd8PsLExN1f1US+PPT9FFHc8cjnxLtrrSTxaTsncGaUUtsR2p21uS02jAkMUh+NIrmlI7N0JlLOSBevHqZqCZ7aVeQE+XsI+478h66GeZwHEQ8a01sU3AVyD6tqe2jtgDxMdNvDXLh904aYuMGsGUS55DBCSKXmU+SxNVfMjJzVdmzZmYv8H5g0T0Ykue69cibnobrdkrpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CU2rYv9wmYiY3CqtTndbC82uSau77ljkX+GWRkucq3k=; b=tMK7rxPpawtui+inWMQozgvrGrWUnsrq/Cug4CWqkP4wboIFgHSTFmsZCTo3bjNwvSr8kKzOz5rMLzHzLFACKLVyBvMX6wsmS4SDLBqTK50nAboNyrTCQWf4OGTM5OgoqvyJJZCYbsYZjxqCxcacYkKS0qrYF97KidkwDxdvenb3SxE1LIq2Etxn5p7F91Ejllxfka5i17TteXxPY6DrVLfLDIH8DLShr7erYRHmwuNxW2soxR8STnOASQJZkHUNpMCpQK2VHyBf8oQUBddLlVH7wD4y1GXQeFZBMVhP4xV/p89QU8xAESvPnFqYGa/wkjs1YGZV6pTZxWl0BdX5+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CU2rYv9wmYiY3CqtTndbC82uSau77ljkX+GWRkucq3k=; b=mOnhk9Fvx9YlT7U7QL2km/O1LXMVO/86RhmJ/g4QhwopHPbEJk7o/voTNKY0lSwl1yqGFUIILlFrgvxr9fmlgyOsLvJKwf6wBFLSPadkadweI5GrVB8mw5qIBT/IyJuHx8k2sJQuq5OCoko1SoPt+6O7jUNHqgGx1q0Z7uP9p2o= Received: from PH0PR07CA0104.namprd07.prod.outlook.com (2603:10b6:510:4::19) by CH0PR10MB4985.namprd10.prod.outlook.com (2603:10b6:610:de::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 15:32:20 +0000 Received: from MW1PEPF00016159.namprd21.prod.outlook.com (2603:10b6:510:4:cafe::36) by PH0PR07CA0104.outlook.office365.com (2603:10b6:510:4::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.18 via Frontend Transport; Fri, 8 May 2026 15:32:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by MW1PEPF00016159.mail.protection.outlook.com (10.167.249.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.1 via Frontend Transport; Fri, 8 May 2026 15:32:19 +0000 Received: from DLEE212.ent.ti.com (157.170.170.114) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from DLEE207.ent.ti.com (157.170.170.95) by DLEE212.ent.ti.com (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:14 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWEL21647278; Fri, 8 May 2026 10:32:14 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , Subject: [PATCH 05/11] soc: ti: knav_qmss: Use %pe to print PTR_ERR() Date: Fri, 8 May 2026 10:32:05 -0500 Message-ID: <20260508153211.3688277-6-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016159:EE_|CH0PR10MB4985:EE_ X-MS-Office365-Filtering-Correlation-Id: e1ec3345-8fe3-4df3-ce97-08dead16fddc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|1800799024|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: ROBN7B/EY1R7eM2Iz01ewo1tlmqowmwS07K0EYHTll9DXU+KHsLCvtC67VcBDAsnaSOKnTZHta3Zz3evZ/ZQvb4zwOzy9/kHnnEZr3AxujXXi5jIaOGdAu4DE5//C6POlIl4x9D4ZaCm3HhKiqZBXtLEjcffs4ObxkmRR6VXxu1SSk3YqAy5Fg9M1WPY4PBxXt1NEa+Xcv0LQN4xvKUMvBt0+hrL0HryVFWU675BZ4eNL/pP77tS/gDyuVg+7otGtVasddxR/jymwOfiM3kV/Lp88rLSWUQVRcCpbtZYkZ7h4sMqypJAwMCrByGgkyjAFLEssIDdSypmIy4qFNn1WGO2xpBADQ2PW+znLEf8z0BNQHFjmsdXjRBNDIBJ/4u7Kf9Nhpa5XIJp+/F9I6JRCaxDF320EMrQQeWr1Phh41exKVMHm4AfYGTElkc/Q3ZqoUSr5T0KVSg0Hk3Czt/GTlv7WCswmXvQDYOpV+y5+fc/zVNVp/G2QN04ypR6VboOuTf1NMJ22eWQhleIIA1njVt+nyBFOqwB6m+prnvOuOTkmpwwaKDNx39F82asutELbyACXKeEMTF7aJYjyyQ8vN45ukwjzZfAAyt/EDy1y85vQGrC0NMwoRqv5K2zAD8zZ/Lfm4VQGppnxgecnCCwCMh5N179nGMV64tEvXwlOOSb+fmImpGuQjy78UfKRtBFC7AVY3YxIDt/c6UU+h68g49g5bcAN+e+FsgBR3pt/gM= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(1800799024)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: t9gmuqukEbodHUA4/NbpP0+lqFobMHKo5UoSmpLuVzX6x48dyplBR1tcN5uidsDBvO0qpykikSFAE2kbwADrf5BlyhnkdHN+j9QGgpwrj6wLUB+fDm8kbVv8M4UihtDEFLFk2tDGuYBipvKTCpbEINrbGhx1UBniOyTYBQpV5b7bPfDJ8hDDLvtob6+YDZXtqBV0Te8UGbY+9ADhclI8UHL93DKXKLNCkdVhDx4kcbQGRfs8HRDqFFvompRX0fZ5PG7Zbtvzv5F0yEpsJgZaENuGhrnDD6XRpFOQlW0Rc/1ASKbsmfoqMcjODwH9YchX0L2BgVI36ArZcFH29VnUwy4S390Q71ByZX3ixea+SBYcNt51rNxbMDVt9I4hVqDvlIzYMrbDTixjO0alLzJJSMv7E5JrYlen9N2kG0BDSnM20w2BKaHYkpo4/GyRqhxc X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:19.1866 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e1ec3345-8fe3-4df3-ce97-08dead16fddc X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MW1PEPF00016159.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4985 Content-Type: text/plain; charset="utf-8" Coccinelle (scripts/coccinelle/misc/ptr_err_to_pe.cocci) flags the dev_err() call in knav_pool_create(): knav_qmss_queue.c:789:9-16: WARNING: Consider using %pe to print PTR_ERR() Replace the %ld / PTR_ERR() pair with %pe and pass the error pointer directly to also print the symbolic error name. Signed-off-by: Nishanth Menon --- drivers/soc/ti/knav_qmss_queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index c3f85052002b..50072e9dea37 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -785,8 +785,8 @@ void *knav_pool_create(const char *name, pool->queue =3D knav_queue_open(name, KNAV_QUEUE_GP, 0); if (IS_ERR(pool->queue)) { dev_err(knav_qdev->dev, - "failed to open queue for pool(%s), error %ld\n", - name, PTR_ERR(pool->queue)); + "failed to open queue for pool(%s), error %pe\n", + name, pool->queue); ret =3D PTR_ERR(pool->queue); goto err; } --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011029.outbound.protection.outlook.com [40.107.208.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C981E2D0605 for ; Fri, 8 May 2026 15:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254367; cv=fail; b=Gq5FhmZX9lV05LPTCWwNe4LSLJTauG2cbPzyGdJw6usb76SktXL0e9nRO0+PdpTLIVEX9wcCcBnYK0OJvCqsoftfGZ/9X/KNbY/0lDb9xpFUUZznDvhANCtiJzUuuDWhnjWFjGbBFrVoEgcfQh28J1ymbJa5O+7Lg/Mb/UquIYM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254367; c=relaxed/simple; bh=phHi5wBxQrUNpMjBV/BwQ9P1Yju560q6wWwX74YEHEk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QvOar8Fd9git/ktB4Sjq30cyKMcdlWMvRBX7jOGieumICGqT+CzT4Jqavxdj4Ga0V4h3Z2/lLIlg4aP6WDWnQR75lPdxI/QsKTcuA+coJJEja+Z9Ku6ZpaDxYeyGFLbbpWSktaep2WzVKUizZZi+9tJjoWy+CXlQ6F9OsQItiBk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=I/mD2IBc; arc=fail smtp.client-ip=40.107.208.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="I/mD2IBc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fe6UKpNBjX7wu1dHe5nLNtjXsP4Cm1jS+6T7R/GEx6/K33LP6GPJTiMQf+K1/8Kw2joRAn1PeweUbCLI2vBRZpyO//wXViD3cSzwUadphx8FfsGmlx+CviLkDIMMuzFdRrYNU1IAyz4dcYZC24+u5nvlnCLUN3rhrcJkxbkQws264GiUByQkSRRvy7b5547+HiThfVYFVNBt+Dgb882+70D+junBU8Kz7AKKgWwfMU5/QAS4DP/Yl0rKjoa6PnUPyHxvK2e8yNAUA1rCiKzgYkI2EEAmHv1MO78DwVXaxqnU0WPk7Fxbz+wvSSmoXNCKoVB5w8V3oDqcx6M2CcBJcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LoMv+D7VWpR38dB0D5JTbuUZdPh1knyMVjnMT7rKW9U=; b=unDlEjDl5rfOClVnlDb35OBEcb3V7dz1Hl9uwyPFvWf/e2RyL7CnERFmaEaCTFJcmVZ4odqlcTLL92WicxPbqXatnTk0aytyI/53d00wj5d4VbK9aO07apQXWN9BRom5dVtf48avcj7c9iJ5y21KXUMCas9+CfPWAq8T4gN4T3uy5NZs01iUgc19bOhgvUJ5qkIHJojOm1jqKWfyTxCOpTEoCgaHqvohSPiDN/1msJU4FSPvEtX53K9p7qN5CbohN10Bw5KOw1+tPpUTVh+uVwdYU2ot/Csk7hyq+RVmDQP6ZEp5CPcKP3oko7VRBrqWJCpC7M/LUZDFaS+S2YTd6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LoMv+D7VWpR38dB0D5JTbuUZdPh1knyMVjnMT7rKW9U=; b=I/mD2IBc1kCMRFJaGPFH164AMj3azRjpWdNYQro51i9lwzXsBFCPHouN3kvPTxNad0TSGCPOACfjyw52diFzRQQPq0K9ciWXcIwb1A1IusiItgMZ5fhz+510aBks7aDfJmpP/p5Ty8KOp7jRN4oMHumbC6Qdz8CxaAX9RImM668= Received: from BY1P220CA0003.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:59d::10) by PH0PR10MB4614.namprd10.prod.outlook.com (2603:10b6:510:42::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 15:32:44 +0000 Received: from SJ5PEPF000001F0.namprd05.prod.outlook.com (2603:10b6:a03:59d:cafe::23) by BY1P220CA0003.outlook.office365.com (2603:10b6:a03:59d::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.20 via Frontend Transport; Fri, 8 May 2026 15:32:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by SJ5PEPF000001F0.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 15:32:42 +0000 Received: from DFLE213.ent.ti.com (10.64.6.71) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from DFLE208.ent.ti.com (10.64.6.66) by DFLE213.ent.ti.com (10.64.6.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:14 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWEDg1647287; Fri, 8 May 2026 10:32:14 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , Subject: [PATCH 06/11] soc: ti: knav_qmss: Fix __iomem annotations and __be32 type Date: Fri, 8 May 2026 10:32:06 -0500 Message-ID: <20260508153211.3688277-7-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F0:EE_|PH0PR10MB4614:EE_ X-MS-Office365-Filtering-Correlation-Id: 54b912e3-d98c-458a-cd50-08dead170bb6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700016|1800799024|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: P4PP+FvYFBjYM2zck8xqQY6wDvkzPzrge5UKGAO4Va7TO3m77t5rNKfpLBxOzLHyCdGK596Ht6KqJTaTZ04Y2l7GxJuuIjQulINwpuzv0L+EBAl5pEqaDazp49UquWF3Am5YXyarxIVHLP95RNOwmsJ83zsraeRLQ0ekYL2dCGz/a9d6VjLGM3j1asRXnwjw1q5R1QsSx7WlwQ7hDmmlvcimWJnuxxiY1C2k4JZR1BG/7CD/5pc1LPjgx+T/FYm91u1K5ge6KNBlpqSArT9K5lytn+bIGkXqt+5devHrljD2pAfvCpbKUXr3v6LERwq44NvKQy9ECcZNE33scLZIKM3+vN9Oe7wS1nY5NPzmcXK6KC97Dn6g05AOjQHRlt6GFAneYLFxnZ5s51QFv/4zlsKSqqPE9s9A/LMsNcCKGRkNMVogKI1bL0KR2HnGZvPGyd/ltAbI9MV7vrYWpjwE2RSeQeUDT8i6Rvx7bXHOryaSK+ouykFBa6SlLpR9BLhJi50JbPN0GNLOWUNTiIXyN9WG24pDX378XkpSfrUCDhe0jOa/mrq50y2/hKj1zV/EduWLq8sd8H+K1CKTEjn1/A3+splkj/8p7AQaW0I+I+RqzND6VTplQLDzqGKsp4gs4EjlDTqSqDmmTQvFIq5VmVmn77WxV0ffp4YH+COtvX5jnvjE26Oe1VA+SPprQZfIS8+6CO9B5azxdKKTw3CA3l1PzE9msjdvwqc5ZsM0Pks= X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700016)(1800799024)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: h9SPMzvsdoHIA91Tk3D1fwLI4PKEFyOHlf+8n3XKTVs6oiqZvQ5iQeSdgifk1LZUo7oojswDOo9Ndh+i0h0OmcnCB0yTvOL5+5MwrGOLKLQDRdD5kU9Qw+npA5tyqgozuutW3+43Y+veI9fD3/pfM+TPmoSoI+S7XJU1KuTOY336engrnTPY1l1D7uJzggi2kQFoTWkmm7vTSQwrgbUljVoYYTmGQcA04Eqj2fZnUDqLulnuJRGdZne+lsD42jBegc0XETCn9VtO0NDHwC92KBS8ntGWcYLZvyEPe0bXCrEgEnvRHPu4sqxD2WBp4P+ZMtqkMvPZ6qTC0Ej7a3bhwX8cRhNwr/SdMMmUS44IgwpbxDzNEQr5O3K+2BfJ+iFLBwFuY/EW7GxIx6s5cMc9yeqAdHPVtac314BDbnaBAV+O4BH4IBecKyD0UvWaMnqA X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:42.4220 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54b912e3-d98c-458a-cd50-08dead170bb6 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4614 Content-Type: text/plain; charset="utf-8" Fix several address-space and type annotation issues reported by sparse: - Fix knav_queue_pdsp_wait() declaration: correct the parameter annotation from 'u32 * __iomem' (pointer-in-iomem-space) to 'u32 __iomem *' (pointer-to-iomem); use 'unsigned int' for the timeout parameter instead of bare 'unsigned'; fix the continuation- line alignment. Cast the void __iomem * argument at the call site that passes pdsp->command. - Use IOMEM_ERR_PTR() in knav_queue_map_reg() instead of ERR_PTR() when returning an error as void __iomem * to avoid 'different address spaces' warnings. - Annotate the firmware data array as 'const __be32 *' instead of 'u32 *', as be32_to_cpu() requires __be32 input. Signed-off-by: Nishanth Menon --- drivers/soc/ti/knav_qmss_queue.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index 50072e9dea37..412b91344d20 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -477,8 +477,8 @@ static int knav_queue_debug_show(struct seq_file *s, vo= id *v) =20 DEFINE_SHOW_ATTRIBUTE(knav_queue_debug); =20 -static inline int knav_queue_pdsp_wait(u32 * __iomem addr, unsigned timeou= t, - u32 flags) +static inline int knav_queue_pdsp_wait(u32 __iomem *addr, unsigned int tim= eout, + u32 flags) { unsigned long end; u32 val =3D 0; @@ -1368,7 +1368,7 @@ static void __iomem *knav_queue_map_reg(struct knav_d= evice *kdev, if (ret) { dev_err(kdev->dev, "Can't translate of node(%pOFn) address for index(%d)= \n", node, index); - return ERR_PTR(ret); + return IOMEM_ERR_PTR(ret); } =20 regs =3D devm_ioremap_resource(kdev->dev, &res); @@ -1556,7 +1556,7 @@ static int knav_queue_load_pdsp(struct knav_device *k= dev, int i, ret, fwlen; const struct firmware *fw; bool found =3D false; - u32 *fwdata; + const __be32 *fwdata; =20 for (i =3D 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) { if (knav_acc_firmwares[i]) { @@ -1580,7 +1580,7 @@ static int knav_queue_load_pdsp(struct knav_device *k= dev, =20 writel_relaxed(pdsp->id + 1, pdsp->command + 0x18); /* download the firmware */ - fwdata =3D (u32 *)fw->data; + fwdata =3D (const __be32 *)fw->data; fwlen =3D (fw->size + sizeof(u32) - 1) / sizeof(u32); for (i =3D 0; i < fwlen; i++) writel_relaxed(be32_to_cpu(fwdata[i]), pdsp->iram + i); @@ -1610,7 +1610,7 @@ static int knav_queue_start_pdsp(struct knav_device *= kdev, writel_relaxed(val, &pdsp->regs->control); =20 /* wait for command register to clear */ - ret =3D knav_queue_pdsp_wait(pdsp->command, timeout, 0); + ret =3D knav_queue_pdsp_wait((u32 __iomem *)pdsp->command, timeout, 0); if (ret < 0) { dev_err(kdev->dev, "timed out on pdsp %s command register wait\n", --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010060.outbound.protection.outlook.com [52.101.56.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ABA53FBEC2 for ; Fri, 8 May 2026 15:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254354; cv=fail; b=SRH4GgMGcH7XJf2IYXxNIviHZ2FpISwVgT67BGeYThhwwUU+BfywTFQol9cf3P6+INvuuuNnSkuN0LK6kmvpD0fooenWzSJHwNGz6mDzKdE9TE4+hmtw5W7JgqWTGVEvkIc0yZyc4EBbCCi2jV/NRXjzvnESqmG3ljcCWUDs0hM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254354; c=relaxed/simple; bh=SlBWh7jqSrZV3CToGCjVvcT5qUFkC/RnAGS3wP1QqG0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WOYoLto8jCXQDhJ/Dd75S/W455kK0cL7f5lM8IvI08AmQ3g6Xk5lf6fa0eURg6j4vlqiFQXmeDPf7/RnxyJRH+HwihtoMF09DPNP0HRZeGWqqlvHNDKSPZlcdYXITX98fQSn8N6pTkEAWts36hlkCt+u6pIuAKlzBuHv59FZ+kw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=XfsZKp5P; arc=fail smtp.client-ip=52.101.56.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="XfsZKp5P" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qS08fEPjfg9XFHvO4sRlRSqeL3Y+xI+2KymNe/bC1C0G8yQ0KCrwrmMN+j3F3S/TvUIeh2KK5FEnBxmDeV/bYn9PP12UdK8cV5bGblNOhPTZXa+JO69S/g3XOM94iRLBxaOZH0/+Rr2zsjSbJ3xKLyJinKyFGM9Efb3KD8eHP6Uojqt/GuAwxAAKBBWKY2T21WRZNn9tvxDqnLpMuCWT6vtj5Qm1JD9ymBkAcMMIfgQv2kZRkhMVYA8aU65K5BWIJjetEuXvGA0iuZwPwqXA71o3HT3JGMYw7eGx13OUqdOKD4BqlYmUb3gwS4iz06dfEQaEO6AAZY+SjhndgsFduQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+9jPq2K5mFdJZnHFDyMJSYj6w2WQhF0zJ4tw1+YWWBc=; b=OIs182Z2msK4u6e1JfelPnlGtRuIvjghpGeSZ6hYvsfMW86zxV1Sftov7oU39DJfNLlB1hufWmzsGke00Td6of6JssaWNEUvdbwi59XJ5tZ2DzzYPlhdzp+EfLcPWybJdafRD+SxpJKEgsweUa2pS7y6o4BS9imrZuzByIPSFCieJS/dBhtIIdtwn39qRrwIoXKbanRf92W8nMbejSknhP//Z+MEaWmthXBgmSdQzHV5umwItP25NRbKGKp8urHaFQQXU7PvLouXbvksEEAsqCSyPgGcThHwvNcso8ZzWI7NAYaYAY2y5xauGTlC/ElgaaYh8REj1QBLq+SN7TOO+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=infradead.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9jPq2K5mFdJZnHFDyMJSYj6w2WQhF0zJ4tw1+YWWBc=; b=XfsZKp5P1efrwvk8yGWIeOmgPOMRtHAnAgqjbgGXK8WqsqVzLo9VrZcGAcK+S1vXcrogF2WTYi/CgDnTWN0mGf6EQN6Qoixpgs0C11U/1KLspe6xTmbm5ZlJIz88tgrEtM83Us22ZEeUoRCHP+Q6LtxFdqlHfhA2aqaRVA/UDGw= Received: from CY5PR20CA0028.namprd20.prod.outlook.com (2603:10b6:930:3::7) by IA1PR10MB7445.namprd10.prod.outlook.com (2603:10b6:208:449::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 15:32:23 +0000 Received: from CH3PEPF0000000A.namprd04.prod.outlook.com (2603:10b6:930:3:cafe::7e) by CY5PR20CA0028.outlook.office365.com (2603:10b6:930:3::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.19 via Frontend Transport; Fri, 8 May 2026 15:32:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CH3PEPF0000000A.mail.protection.outlook.com (10.167.244.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 15:32:22 +0000 Received: from DLEE211.ent.ti.com (157.170.170.113) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from DLEE205.ent.ti.com (157.170.170.85) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:14 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:14 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWEwG1647292; Fri, 8 May 2026 10:32:14 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , , Randy Dunlap Subject: [PATCH 07/11] soc: ti: knav_qmss_acc: Fix kernel-doc Return: tag Date: Fri, 8 May 2026 10:32:07 -0500 Message-ID: <20260508153211.3688277-8-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000A:EE_|IA1PR10MB7445:EE_ X-MS-Office365-Filtering-Correlation-Id: de19d905-57c0-4d31-4578-08dead16fff4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700016|1800799024|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: 7iMmc0GSQLl1XNlfmTzRFq1qk22dXqfT3duZPG1y3JVtoV9xnKPfTmhh81Tb5JZZVrlLt9wiONG0xXztXMI3wahu8CTuGPKS8h4VyXqPK9QtZthJGFIXVU/nzq/dVc0Fj72b/gpPLn9ecbR65VS0z/qNraqBr37DuLRRFMGHI12iuJRylOwmZYUvI7MqRJITbzppwm5wMVGmuLeoe5YIzU3z7rfRZO/OrsPVpp83hKXtokg2O/xcRzMZcIBHXuFP3XAd/OtDVh5VmjTb0i/G4+ul2F0PQyvqO+DlX692y0bKGO2gDAp6lz7fa607FuSHx9ys40TL1hlCKrjwSRDpKmIMxO8SEcCj+P2O/1lvguK0kGFIuMPg9MhoqoPdv79YqPUHbUu+ggTK63fVwTsHefzdNkcHFCy1StexZrOjJVxfzdCIsIwiwKWp/KfLlHjm99CORCDwobXZIj1SP/CjZVuS9tLmT9jTO8QxlEmLOUfKF9hyB5eJjvIVNo2dMWF54rBUM4rbiKstyA/zeSLz+ktHMQ7P/s0XsT1avj+EnyqtDq1/hxAFGWTeNSEd3NmFTRsfLBzOWcQWimVdwTGIMzZw17hF5llH4Ls0bFR9dyCgsD7RxUgIQpq/dicJKK1WjAui3xv6GiapA/aNMN7++tRCTUMGmP0eFof6hu5llOfjlO6voq43MQIwk/MSFKOMh5scj0RxTetdRgosL9DWNHyyxes9exw/M/gdGd0Eonk= X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700016)(1800799024)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sWVoPyWodz9HvAkqi8Jg50ndaLZ0xLuf6n0F/gmH/ephW1UYpfPNP3AVZg0p6r6oBh9qEG/0ntkuu+t8cpt/qAStjMaQXaKDIXXrhdF/Hr8wHjeS9YrfgIW4JFNyg03csLKf7pq9GfWa4jMXyY9q4xyaWNBpepxLVBnko2uVex/WYBFqeHoCf1cjy+4Dw1f3MGA+4v5Kd4SGrp09trbDk8L12225YX4XFTEsTDKAeg/WDVZAuh4+E5imVMuKNlBcfmtrbKJ/GZ/+LyhD1R8j6SY+fcUGeeNA+pv7OeWToKz1XTq+D3LFb5gjtS771JEQExkgaLpe2QVgUXE3a0/iMtzpXw/wA55TmvuWLQWewdAlfxC9ZyzLChtrjqJaNyWEQL6yZyXhEKkTdoQtd4q7rIaZDqhLaDjce4HmTNON8mf4A2yh0CTJKAR7h4P7MTwk X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:22.7280 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de19d905-57c0-4d31-4578-08dead16fff4 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7445 Content-Type: text/plain; charset="utf-8" Fix knav_init_acc_range() use of 'Return ...' instead of 'Return:' kernel-doc comment, which produces a warning with W=3D2: knav_qmss_acc.c:473: No description found for return value of 'knav_init_acc_range' Signed-off-by: Nishanth Menon Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- Cc: Randy Dunlap drivers/soc/ti/knav_qmss_acc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/knav_qmss_acc.c b/drivers/soc/ti/knav_qmss_acc.c index 269b4e75ae40..1f8b5acdd462 100644 --- a/drivers/soc/ti/knav_qmss_acc.c +++ b/drivers/soc/ti/knav_qmss_acc.c @@ -466,7 +466,7 @@ static const struct knav_range_ops knav_acc_range_ops = =3D { * @node: device node * @range: qmms range information * - * Return 0 on success or error + * Return: 0 on success, errno otherwise. */ int knav_init_acc_range(struct knav_device *kdev, struct device_node *node, --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011004.outbound.protection.outlook.com [52.101.52.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A7213F23D5 for ; Fri, 8 May 2026 15:32:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254349; cv=fail; b=nN00ZiqXBzpihFJXWB3gcy2i6V+SMcXMH8NEaG1+K5Fgv3YBJ/yH/Yxsf/he3CvMm5IYhdwekIO3gILWFRX6aAcpZRx5GBvSDtIG5A2CV3e7tOxIMLAKsMkn3PfMynF3boOudSkF+snMB8iz3SOvyt6A5l7riCdT4L+2zKbSDKA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254349; c=relaxed/simple; bh=Xh5wxUuuwxFQKAcCWogHJGMR711oRqw/XlFw8g8Tm68=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=B7e8kZD0mC4YSLkwN/j4Z8YIBx6XkalDsEO+po4/wCA0eoaNhIsSLG95ebQF+BnW+GHckK+71aHxySQbbkTed941YOSW6r8Bu+wLMsqL/fuk5bMLLoU672b9/xfZEEr1tTEiwIELQW94o6cOP5i0V1GRqPoTQ7ODoaEfqZB2K4Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=PA+k0mly; arc=fail smtp.client-ip=52.101.52.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="PA+k0mly" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cxEJ8jo8lOiDnbrb81OGQoxHgvtBgwge8GQRk2eZBGtVbjI4CdAMmYawnXMqP4XpULM19q5hoMeJ5NxikAVyjFuDa98vrSxKtXAwJtrvym9qYSVqaEjs7Ey59tW1u3mAQy9GHqP4g2VQW7iublRspRcceAHt0PP1i7/Fv3W1iPXTcSt9pSMaRxBr+MSL46Yd3NHKMzfOKHC5fQFOYSesM+bkcHha+JqTK28+fUI9ye+NpRz0nxNPDVHMd6LPQ5ZCjxaUHNpyCPrxG1qrj28c12lrqJU6O8Eh0Zzc5yMpdH4XRz76JKx4g5tK0RGbdfG45mxTliIV5DqKurd/AScZsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lU4QB+k7D6qRJr4JC+6lYifMN/b0DjIEQgOLF3/x2cg=; b=ua/qZ+SaEdhTWM+900TVKHOJKTnbH3XnzNEcnJ1H9oACBG/6u+XHOVScVg0Nu2fhLKtbt2cV4VZsTMeK+t6oHl5DKXCaRJii/srlfu3vBp4Firu9J6eVG1I1o8u2rCpRUq3YPjSb4RPbeRQeAXk1WSedLggtGAo7PUWHFSeMhxtKMtm9iwf7NR1lQkrPR0nF9z0sYmt9WJ4BFgeBgOhKasaPPadyjB6K5x52rQBCRPfnd3Ahaqs+fl2bdA4KHU75T/foEmxUq1KjcfbEPRCjSID1qzVTrau/gn5V5FXwhJAcErHQwrUHhQQOJZncvqwSeR+u5mbNYrhm5ixz9YPT2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lU4QB+k7D6qRJr4JC+6lYifMN/b0DjIEQgOLF3/x2cg=; b=PA+k0mly9GHM6mYjE0VqHcaxsmjswFSF7RVu5w5C+UC7JATiIsc3nVZlw3ZxvZUiceKuCdJkw2n3Vt3Kbj6WgGlIuGwOgQzfQhN1+wWF03Jd/lLbKEo/4vA+z4WtEBkQUjdsZlVLX6JDecoJ6TARSMBKEaSkg7kHX/e0+0ZTcuk= Received: from PH0PR07CA0103.namprd07.prod.outlook.com (2603:10b6:510:4::18) by SN4PR10MB5800.namprd10.prod.outlook.com (2603:10b6:806:20f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.20; Fri, 8 May 2026 15:32:21 +0000 Received: from MW1PEPF00016159.namprd21.prod.outlook.com (2603:10b6:510:4:cafe::71) by PH0PR07CA0103.outlook.office365.com (2603:10b6:510:4::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.18 via Frontend Transport; Fri, 8 May 2026 15:32:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by MW1PEPF00016159.mail.protection.outlook.com (10.167.249.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.1 via Frontend Transport; Fri, 8 May 2026 15:32:20 +0000 Received: from DLEE208.ent.ti.com (157.170.170.97) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from DLEE203.ent.ti.com (157.170.170.78) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE203.ent.ti.com (157.170.170.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:15 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWE081647298; Fri, 8 May 2026 10:32:14 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , Subject: [PATCH 08/11] soc: ti: knav_dma: Remove unused DMA_PRIO_MASK macro Date: Fri, 8 May 2026 10:32:08 -0500 Message-ID: <20260508153211.3688277-9-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016159:EE_|SN4PR10MB5800:EE_ X-MS-Office365-Filtering-Correlation-Id: b91df0ec-760e-4d65-dc46-08dead16fe9e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700016|1800799024|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: L7cA/UHODbUwystjZh0fBMw8pe9NbKqOMQJM0u/zdV+aMfwGz5usnzq5ISg3FSyp5Hp5r6DHqeBXjLIGxziW6iWRm0jN9qI7Z91RQCcHywQSi9+Vjc7P5/49ufqBSr1WX+VoyjLI6t7E8T9vJ0X9UCo187Vg+LxfQQeNn3SJsYZg5v2NvSnmCoYamfDQaev7NlmBxg33WoAoqbvLBUnyFSzOqQWVirzhr1/Zlo5QmhYD3vhtzDzr7UA3CKlWWvWo1KE4saBmUZ0Le5KWwbUkGHSH1xb/CKEQf+2y8kTi+emRWFlwx3KLJO/kfJwALAd9vkHoIpNDrKi59XQhZMSMO0fZFYWwnoHGKYlDXn9fDdK/c8KKOieTH9OTYqzbOLJtS/vC9soy0JRUGcVKqUFE4CY0EkQE4mQAXl7sK/GlF4lMnMWERQAtfDNDGXwbVJkcpszHrx4i9TIxueYHAMuMv9GC1pkK+2ediVvw/zhDssBqJAzxR2iqU+DFftd9TidPJX3I3JU2Xxs9F4PCFbbn3iv/QuVYzdAnkh+8bwM18HiUqeuG5SrmcBiuhdPxErmjUdpxorhs7hHtIeVnK5bY+y/VzpaB6L1hDyqOX5+Ksy1l44SwrlI3mH0EDlUuSUHhWMHyrrIBbeBUx+qaPvIrgBsgDWAwiqBtYKlqS53vqg2SvCLzZWfmzvwpYlIbOU4MkUNhtvKijvyR9jq84xacL2yr0yJkV+ROQvjHzWr+Mvw= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700016)(1800799024)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: f9KjjJKv8PzWBLyxaUR8/3yxd22iPw1hw/Ycy5j0ACZrkFsQ5IaAPYOej9GFJqymBOtYZKmUVp6AGECFnGf2X1Z2dYFgorWs/uBY8OZvaj2b+3uZD/WhJ5swSXvOa93HFVO5cJz/qiuWSNa/BeQNl/vM9Y+uCfUmZv97v6h0nlXIzH3X8COHc9Qiy9iBjyuqKEFTEPoWPTaDX/+hN1UmzIH0+2lWq/QpM/naWgjtHjFThfkyYdgUvKuOG8y3lHyQBI/GOTrXAXqUgU4+DzseqVfuFSPHKpVAHF+XvZ5cFas0Egyxj6rYPZHTgFOI1xzR/eGneLWdpyia3WEhbcPoDE7FGWceOnvpMtOujodmKxMKS4aWlp27jnXyFNWSYRN2Y7Twcn433vLESS8vsNQT8qOLpBHWPXPg2BePG2dL+iOzquQixPbN8wn+NNdmnBR6 X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:20.4522 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b91df0ec-760e-4d65-dc46-08dead16fe9e X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MW1PEPF00016159.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5800 Content-Type: text/plain; charset="utf-8" DMA_PRIO_MASK (GENMASK(3, 0)) is defined alongside the other priority macros but is never referenced in the code. tx_priority and rx_priority are only ever assigned DMA_PRIO_DEFAULT (0) and are never sourced from device tree or user-controlled input, so no out-of-range value is possible. W=3D2 builds report: knav_dma.c:32:9: warning: macro is not used [-Wunused-macros] 32 | #define DMA_PRIO_MASK GENMASK(3, 0) Remove the dead macro. Signed-off-by: Nishanth Menon --- drivers/soc/ti/knav_dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index e5f5e3142fc4..462d181ca564 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -29,7 +29,6 @@ #define DMA_TX_FILT_EINFO BIT(30) #define DMA_TX_PRIO_SHIFT 0 #define DMA_RX_PRIO_SHIFT 16 -#define DMA_PRIO_MASK GENMASK(3, 0) #define DMA_PRIO_DEFAULT 0 #define DMA_RX_TIMEOUT_DEFAULT 17500 /* cycles */ #define DMA_RX_TIMEOUT_MASK GENMASK(16, 0) --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010015.outbound.protection.outlook.com [52.101.85.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50A7133F8B7 for ; Fri, 8 May 2026 15:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254358; cv=fail; b=dCLzxMagdVJ8jD3uUYycXRQn8dcwpzfFxiitkgDv+V5DCLgYsgo4JbLjoUGtRfc9Vdgw+p2U83mndjqsoF5jQRyfuSNHHblMX5zDQN31psL3UDgBzfN2l6tF4uW+QGyFVtuI4hgLNtepX8AiASt/iIPKDqGD7NO3zrj8dOGuau0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254358; c=relaxed/simple; bh=K9IfVpQgo0JckYzJADwsJkFB/wHbN5b78iao5NPuL2Q=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=t/cYw7ES+iOdAHcAf+fhmDqnKtJpoYd2U5FFxQqYB0STpBmYXqmD74b1ed6bbqctEsS9iDHPYqZosgx6HDQ5ftTQL29DRRx2USAV73pnokj4BnQuxBTwgcfd10/TYC5ZNgOriBI3iRYyQvqyZ9d1ihH2z/qgG12Yv45Vu9mnmIc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=uENuNkhf; arc=fail smtp.client-ip=52.101.85.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="uENuNkhf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fLXILyVYwngw5eXqPErG+ds1R/T6yNIxNIFGDrmhhIPvtiV/gZI8/EztjEX+LCH0b9sWtEhK5yYFbhlKQGG+jzzYgAXcSJ4OV1yJOqrIJLNTd4EJFdPtMYHytBY5MYOTWa+VmmDZ6Iw+tG2qiIPRFMHm7wZBqBU/59WsSfRK6aC0WtVqLEljtAIj6EkPwlu/RPgAK+LI13vKkf89Iz/NxvQPEx2xoX3f/n8ZJ6k02w4XWdPm+qA83fN0wi3Yjk0eW1MIlH23sB81qkRpAai2b0kTEHgO8qbLVCPWw/XyHGpCeewz1issXUf0LHemRpfnB8jm7zFl8hXXhMN2/cJ9eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=83DMdZZrXbubodraG1MuTdXJuELcJZpN3b9+RE6+HLM=; b=PHGPiKOHvow3sRUJkAnvjmKxiWM9bx/IyiI0toa2w0y+RKwEx5WWrsiOASUjEoPOykwJr1y2UZ3azvwAUPAfTyHg+maX3oerzyZcpV+I9zEPGrut6jUnnijL7x0zz1zbitI9zXjciz2+DzsFrEKRz+CnbZEBqS5iPyZFz/Jv1ciZ8DSadYWU1Z8sKyj2SOGKdWPwIWav8VpeQMz+jmyZROCEJeIwZP+4Fg3LH+CGEFuSmuEaaMeMWi2PkAOWiyiPjS5nf4wemeBHFBN9S8lsg+cQsVLyZwBKoUilW2yOYciaX2jhbMGmNYCwwcP5GW0bGmvoG3ptckCb4RDwosXvDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=83DMdZZrXbubodraG1MuTdXJuELcJZpN3b9+RE6+HLM=; b=uENuNkhfIfdRqIX6V5IDMCgmgiMwt+tPG2Ii+HiIgn7MKyywmAb6jtO+AWqSByOnQsoctUgA2Q8UK2GgV5urhE3Vvzdj+inClJqtpcd4DDU38YvgKyXDkSKn9wjQ4iGNIKnisHJouZZR7ihf1slxVCMyOqIS8AhAalC9CxUcel0= Received: from CY5PR20CA0024.namprd20.prod.outlook.com (2603:10b6:930:3::25) by PH0PR10MB5871.namprd10.prod.outlook.com (2603:10b6:510:149::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Fri, 8 May 2026 15:32:29 +0000 Received: from CH3PEPF0000000A.namprd04.prod.outlook.com (2603:10b6:930:3:cafe::fa) by CY5PR20CA0024.outlook.office365.com (2603:10b6:930:3::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.19 via Frontend Transport; Fri, 8 May 2026 15:32:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CH3PEPF0000000A.mail.protection.outlook.com (10.167.244.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 15:32:28 +0000 Received: from DLEE210.ent.ti.com (157.170.170.112) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from DLEE213.ent.ti.com (157.170.170.116) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:15 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWFWF1961990; Fri, 8 May 2026 10:32:15 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , Subject: [PATCH 09/11] soc: ti: knav_dma: Remove dead check on unsigned args.args[0] Date: Fri, 8 May 2026 10:32:09 -0500 Message-ID: <20260508153211.3688277-10-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000A:EE_|PH0PR10MB5871:EE_ X-MS-Office365-Filtering-Correlation-Id: 8093fd6d-37a5-49c9-b579-08dead17038c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700016|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: y7wLVcbPC3B1lnltwpKRJYMH4sqZHS2yocDR6ywHy2S6zecOXhVJTHtar+VF+79AubiYRkDQeCj6TEkSWWN+3EGvdPwXX48oOjUe+vzu6BXumcGC3wQVVdmKoyJT0MZMxb5/QWDtsxb4EIGT0E3LeFXDZvzWewxZqXPeD7Y0VtbMOcUfG4WuBzf+hP2X3bi+uhhsa1xY2CFlRVXkejeY5zsxpjqdTnVNNmJbveqlyGQ0aKrg8tkC9tIBTEvdUTvvEJatngNbSUGukJYb5aA9W5d9riHLaUNOrx+GpgiRHCuarz0q/qti77MpeF2dtk/KlbO3W4Zj5GdVrYzjmrqgRiLHMFoXdFpZhAnw9ZDvPfTQ9u14zkoA2rYggOgx1jBhvq1obDUIWiRpbAcaPIJ6+hyNmTnl47Y+bupsJyWFlzPF4DH4RBfayV97I7SqiMn4vXv5Jj7LqelKPsoHOJZPK61lFwqGEbN9KmmTgMExzaTGxnoz3x2RNDNN8K0NNIwvDpJvbcEQxl3dgDRJ9C7xnTImKDR5EfdWkcFqixHtBZRwye3sXwy8EzLdcv8YUR7XITFncYMhKiAUFNkS5Ql2hc4XigBynGwZLWP58EbtNF7fsaPZWaKfbjK9iRw3XuxXCwqZ8RO2VKDEheXSr/bKzYWUxjnSEWh2T7e8ntmY3Do4N8ysLIKKqfJDCcEvyFhzdDNJLVsp/yDM99OgpDSsQVDbJDI9ztajnStJWSSMjQE= X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ud3ahpRE4WNlGxhQZn+t8roSiQQGFMHW2GUEzRt7tcC67ARjLkh0YQgvdwg+RmQGgY3rLRkj/dvzF5LsmgUAhrzLsLeVxWsYEZmzURKcWLCgfXkGTUytkcrzoViCXouqjGnC9+FpGPbeAQ1YpswiA/RMS96LH/eVGKZmRWlVVME686UccKqu9qgQv6AOOGFRKQQt1sh6oreVPp9V3N419yXXW16WL+Swc9uKyihZu+xIn9kdJ7tZug2QI5qc35N5V7Qtq3No7+N++R4fZuo61NtHAaQNjJUmgaFlfM+HKtdkAFPEPXywyLBtuE9kpavmYWUk7RF7F0MzdFIHNofRN8DJNjAph2rSVm83w7LNClOwRnhGzM+A7av1h9Q4ZoffwvGVYbuKF40nt0EKBELrlYG8CWoUq1gqauG/A/R/fkzplUk/9UpUnh1w8cs4rO+N X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:28.7539 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8093fd6d-37a5-49c9-b579-08dead17038c X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5871 Content-Type: text/plain; charset="utf-8" smatch warns: knav_dma.c:390 of_channel_match_helper() warn: unsigned 'args.args[0]' is never less than zero. of_phandle_args.args[] is uint32_t, so the 'args.args[0] < 0' check is always false. of_parse_phandle_with_fixed_args() already handles errors by returning a non-zero code, which is checked immediately above. Remove the dead check. Signed-off-by: Nishanth Menon --- drivers/soc/ti/knav_dma.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 462d181ca564..7ba6fd58e9ce 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -387,11 +387,6 @@ static int of_channel_match_helper(struct device_node = *np, const char *name, return -ENODEV; } =20 - if (args.args[0] < 0) { - dev_err(kdev->dev, "Missing args for %s\n", name); - return -ENODEV; - } - return args.args[0]; } =20 --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012011.outbound.protection.outlook.com [52.101.53.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E593636E460 for ; Fri, 8 May 2026 15:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254360; cv=fail; b=lxI9t2rvPHT1ZBc2u0bMxbcUd4pdnh4quahf30qGWUA7RXDYIIfBRC5vgoNxr7teSE2e5AVb59g8J4PfNMmGYlbYCivOBAvIsxU4nfgZ7Aj0JpHTV2xnTwoFNcagVchq3fLLY7ym1+S1uBdOZjDE1G7OST1oJdjzUIlnyHcGpw8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254360; c=relaxed/simple; bh=6JH70mpSr7k/9cadkKlq1CWrKV2TafpCYLxEKSHFtV4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s81hSBqyvYb1FHVrXUGWsrFYenbv+jr8Ivb7PCi+KLkIuJhctaZuSv0tZ1CkFIK+I1jFrGxcONDsUf257W/YaEvqt3Og5ptsweR7r0X3FP79bEZprJsgnpMm6LJbtBz/rmPhusBvQ1yN8mEEDG2xXJdLWH4XufN98u4oIC4LjWY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=reDLi/eg; arc=fail smtp.client-ip=52.101.53.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="reDLi/eg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MLhGIj7PQdJX56nArj39UV0zClRguUdS+v7rnSezsDUlZz1a0IYn5jO9FJmWxUqD/CjIErfRgdwjArFNJph9/iVU4URw9WoyhgDosaUL9zti8tQ5o03ngi/WnOq+LbnHu2Dav9oLcQQZr6KwN3RK/VqcrmFestnrUUnH/wMMzm/0vXh5dNxUL3eFL/eyYe8zRIddCBvCg7+cH8vc8NcNlwOk5gOO64f9DtXDhHcbW3UK7KSzQQatHQbRrMnw+LlhrEZjVv45u/qJff8wnElUK9s7cYMbYek8Jbmt2GjFzd+6qUJPb3ldtr3qqUUUAXoXIYVViKD/lqxo2nQxVxYnOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sZP2f6ns384/CTPs3rJBUR8AgOUEXy/Mn4YRV90FQO4=; b=v6l4tzzOBNEoswTlq6+wAmveoJdn7inXREGYaW1rO+1iN0iVWtjgxymCZyltWN7ISQotvoIDRnBN4Z3sdkm1DwtgMeu/x1XSgAVoNulwmte/+ysWU2Gi3FwlwD148Jwsb/zlXAHmgVkJd9OGb3RZ8xH6h1Fu6QOlGfWdT6C9B/y//A10qn5L3bbBE/UcNjbKMun+bM2M4qEZgNpPuTPBCuLHBosFqhQuymoPhINYF6s/tAEQ1TfI3vfj9ps0/Ewr3yjvg+VN8y9kku7DhCaUchnOf7uqLdBqRpE1xdgO7vVUkxxpooJZGxrsi6bZd1t2QA+EJGcj4WjGCBCQbou3PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sZP2f6ns384/CTPs3rJBUR8AgOUEXy/Mn4YRV90FQO4=; b=reDLi/egORR9zgeyXEO4nRD0GvVXF3RcTAAB+bCqcUOwC/oH73S1hfWyoq+dXY/O6qNeSdjguELVjd4geGVIwiSiBNgLFdbLKD74OafjMALOkyiahxIh23rGoS6c1eTaWoy2kyJsG0jC+o6kj8oVBrYgkZd87KZzLCUsuLbfGSg= Received: from CY5PR20CA0007.namprd20.prod.outlook.com (2603:10b6:930:3::26) by LV3PR10MB7746.namprd10.prod.outlook.com (2603:10b6:408:1bb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 15:32:30 +0000 Received: from CH3PEPF0000000A.namprd04.prod.outlook.com (2603:10b6:930:3:cafe::3) by CY5PR20CA0007.outlook.office365.com (2603:10b6:930:3::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.19 via Frontend Transport; Fri, 8 May 2026 15:32:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CH3PEPF0000000A.mail.protection.outlook.com (10.167.244.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 15:32:29 +0000 Received: from DLEE210.ent.ti.com (157.170.170.112) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from DLEE200.ent.ti.com (157.170.170.75) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE200.ent.ti.com (157.170.170.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:15 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWFud1961993; Fri, 8 May 2026 10:32:15 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , Subject: [PATCH 10/11] soc: ti: knav_dma: Use IOMEM_ERR_PTR() in pktdma_get_regs() Date: Fri, 8 May 2026 10:32:10 -0500 Message-ID: <20260508153211.3688277-11-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000A:EE_|LV3PR10MB7746:EE_ X-MS-Office365-Filtering-Correlation-Id: d3a7d57a-8d93-4a77-176e-08dead170431 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|1800799024|376014|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: aR/PWQcXxKqKB8oAUd3QMfzS7IMLGsr23TCv25LK5eByZTiW7Ab/iT0ooZ6C1dFyJFPbK3KjVuGCONSUIbVtJp7RH6F6ZIQMArzaJrTuSZWz9sGBoBH7b0gRKtEJPK47Xcyo179UNUzMoHgT8MjYujZNiYLfLKvhDIxqQAyuAd472hsS5mUdPN/DniuolwpZDrZOkU7EXT573Z8LsFLSsaVKT8z2KbOam2urg5bHps5kLGoJJpxcfZak2Y6qdaCatOepAF4eL+jwWXnB98/rdDi1ZtyPslal70gTlX0H0g2QBGm3AVpy8RtyPSR9+JeOGhPQPk9odsaRfgCO9K+Qbe4KWeDzojdUGy9qwMq1l4JULLEaIf2iDpRuDbuUPKAB7UsheduFzkNe13y3zVL4WlzttjHxQVLloXY33a/lgjY37kceskVBNIazHz5ap/Z+X4JsGsEgrnVV22CQhRoMlteqeBgfAMKjrPPM+uwfIHNlDBz75rVW3fIYPGyeWp9jwi9JUVwt0MktJmSNLStQJnxdlFGjbsnUwW0a0FVSc/1Bdr0BQgF/oGrqlbUSmmn6P+9XQT22rLG+TLj7WcE6tJJLJCYlW0/IVc34rOwljbQAoQZTAAJzasPymb2bMnszQRG/wRBKXvDjcG46Ap+Kc/mNNCNbuDPqE22vjY1hSmlk/rlbK82BNDRquJbgdyMBSebtqNLBMBAJ+Kj9gjE5LDbPTRkYnb3jeTJwuWJW1Gs= X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(1800799024)(376014)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HiGsc/1najEyWuJyAw+dqYWPt0m0HO/mO6nPpmLmwlhsHM6g/tvRuOhMGxH50HeGKXbBD508JWw9qH4+lSlB7icDDGepYG/XnwMngadW1Y70Pu+ZBvL6gwaPuwon37sUQDU2BGAarBPRawWItB9kCqT95eq2BLQm2qC88qQd3TC2cuJ3Iz9lL6ATw+zFdU2HQUi7V0VqEZBGVsl72VD3waTcLiiDUt9FsUpdjW9Mo32owPyFrF4LAS1FBRwc+u8cf4FKGlbEPmZoCwV1HPwVYG6CNLCLOeJz8NbxZxuXCWagm8fGZH1j5TQwGtD+xOzvFgrIGrp4fkLIXc8b7KniOWkW/n5lsjfAKVGqxfRa0BBhwe3u1rpnWI7BArQLhUCSTnMJ60Eo3MQdO0cwPJggDrNf1PvYk5Mnf5FVtLBZ9AupKv0SeyXIjQkm7U5Q4bN4 X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:29.8409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3a7d57a-8d93-4a77-176e-08dead170431 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7746 Content-Type: text/plain; charset="utf-8" pktdma_get_regs() returns a void __iomem * but uses ERR_PTR() on the error path, causing sparse to warn about an address space mismatch. Replace ERR_PTR() with IOMEM_ERR_PTR() to resolve the warning cleanly. Signed-off-by: Nishanth Menon --- drivers/soc/ti/knav_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 7ba6fd58e9ce..96df3982e47b 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -520,7 +520,7 @@ static void __iomem *pktdma_get_regs(struct knav_dma_de= vice *dma, if (ret) { dev_err(dev, "Can't translate of node(%pOFn) address for index(%d)\n", node, index); - return ERR_PTR(ret); + return IOMEM_ERR_PTR(ret); } =20 regs =3D devm_ioremap_resource(kdev->dev, &res); --=20 2.47.0 From nobody Sat Jun 13 07:49:26 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012034.outbound.protection.outlook.com [40.93.195.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F75C2E62B5 for ; Fri, 8 May 2026 15:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254354; cv=fail; b=dA3L9xdgkrw0pyZwX/O4T12dyp9NcxT649NRcDAVmZdZcqc0Vk7xS/ff/N9U4Cq8+e1GzrktGG6PofXiQi+7UP7f+I4TH7ZXDJ8oe0zDMovywrxBPSKmPnuxJo54aGCSkvPDoeguiYYcXHE82AeVwn2ZH6DEXN79VHvj6WTVC1I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254354; c=relaxed/simple; bh=qo1SFowyObldBmdziVi8cg7GS+qS+pD73suimoHmr8Y=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hJXM+Ev3nxSg9qx4VDz9Sr2dsAatRIl+VXwvbJAS5sApSbLHEKBKldejvyQIfGohBwBrUfdWdyKxPHHF/URdrFKay47x42IsbPssl36vYnNVW8MxGTumddpH178wfcgUz/R+pJ9xjqplL2DWMLK/GHAkTv8QPqSbBR4xz2hxNNk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=fGrWsuA3; arc=fail smtp.client-ip=40.93.195.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="fGrWsuA3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NFpWZj05wP2hsHko/BnuhS9hvLp4LIF6hM3B5ZRliY3arAngQQgra+77UwqBeCdJBgC44dAS2HWDg7zDMjlhKvhrVp9iZYY9T+ifegqPieJrdMUxy3qPuhFkSJTRWuTssib2eeO3D07sVSUB5/aI2/di6ZYJWnSZEKvwDGj550reRRlHN2/G8moQf4uCLKPMUrlbqfRqYgZ/NLXJSH1cuqpend9++F1Mw94aSHEEx0q1TpRqhdzBV659kHLjK2605IhcpglAQVC/kjLdM9Uyj0TzU06t/Df2uk+ailf121f1x7fGhk2ENrs5BK0xYQsVqk4Qc3UTvcHa8eZE3f5NJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KRvvHLFAv8WkD3F/k9Ia+f1bCEKqsQ4AkB7jp1bqlXc=; b=eOxPqfdyECgOwsOvhb5fXPJWoKa+98RzDInIJaTdh7plYkmDeFGP8tHD4SNdgAOsSdg4fEfH2LzbROtYs5mtxRJTIIz0dgFh0Oa3Tjcsr+XEgrGZPznUDxXuNl/E4rmcFCaH40uDUTet4h3XJc0CXTG+VYC5mnjN/p1gdvAcoP886Z03FMGerzuGiASX+PL+01Zr5bxW0I7xTM/UMgdVzmgLw2cRV22EGuyv0fOTIB1XFnx3aCliA276vqflYNHQdaELXoD8UvzrSTIRXk0pBiMESE8a3nDmpGLR4dlJa+qI75hRP3glw3tC4t52mIpq+PSzpMbuUoqsujy+Ng2zXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KRvvHLFAv8WkD3F/k9Ia+f1bCEKqsQ4AkB7jp1bqlXc=; b=fGrWsuA3cf/hcOC9hEDqXdni8dlxq4StFbMAedx04WmiO3ySnd49Z/TGR7Nxk9IoedpKSgFiDbqbI0b69pfDgyBEp9GQt+9KKsL4FJbtWrSemL1PMh5b69hXyNO9QCYyIV7eCjH8Ro6eNbhHf+6mFIaRYyY8p+aKoA51d275CTU= Received: from CY5PR20CA0028.namprd20.prod.outlook.com (2603:10b6:930:3::7) by IA0PR10MB7232.namprd10.prod.outlook.com (2603:10b6:208:406::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 15:32:31 +0000 Received: from CH3PEPF0000000A.namprd04.prod.outlook.com (2603:10b6:930:3:cafe::da) by CY5PR20CA0028.outlook.office365.com (2603:10b6:930:3::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.19 via Frontend Transport; Fri, 8 May 2026 15:32:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by CH3PEPF0000000A.mail.protection.outlook.com (10.167.244.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 15:32:30 +0000 Received: from DLEE215.ent.ti.com (157.170.170.118) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from DLEE215.ent.ti.com (157.170.170.118) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 8 May 2026 10:32:15 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 8 May 2026 10:32:15 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 648FWFWv1647305; Fri, 8 May 2026 10:32:15 -0500 From: Nishanth Menon To: Justin Stitt , Bill Wendling , Nick Desaulniers , Nathan Chancellor , Santosh Shilimkar , Nishanth Menon CC: , , Subject: [PATCH 11/11] soc: ti: k3-ringacc: Use str_enabled_disabled() helper Date: Fri, 8 May 2026 10:32:11 -0500 Message-ID: <20260508153211.3688277-12-nm@ti.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260508153211.3688277-1-nm@ti.com> References: <20260508153211.3688277-1-nm@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000A:EE_|IA0PR10MB7232:EE_ X-MS-Office365-Filtering-Correlation-Id: f5428267-90e2-43fa-bf2c-08dead1704de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|376014|82310400026|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: ZJQnDW4iuFT9FHl7PSomimx0MeCUSo+vEnp4F4F5kuJ+YrhfuFJ3f74iRN3D6A9UWm/o90a3YSqQviRMoKmKYtamoEw+LmHzeYmhKiH3dQhVSeboKr3UB+EtNm3WjO3wdDMMuBUa0kWUibKXiMJOZR9ym0ReVJXQKeDi5V14nGVUzcbR74WD0AK1JZEFWV/omfgZ/Okl/nfUkvJdY+gqzN/nGIykSH2lwnXM+s7Yry0TfI8928n8WCCEzRgSVQSEEDybAMBy6kUZ4W1/0HyCRRz7PMfuBCoTxUnzk0yp0V2PW2cmURf1VTsTZmS544VXyqCXHqFVW3h1yvY4GNSpjMj3jTUvfFDM/v0K64ZwE1fAm9IfGlTp8RccCKdvkJsauPY6sHJqNWzaiIDVj1EFqYDa0ybzaaIrE6ODsRza/dkuMK2zCHCcPrELlxYkGCjqmSPYYz9PDZWHV4bqsp9seU730T3r/8lomFtGIr1YGt2wS8mx/9nio6TdduLVg+y57LXYtElCUxgNNBzwYtlphOmh9tr8tDE95ZZBGF8SifRm7YvhdDsTmiSc6DozqaXAvxXUVxqFno9V7TybcUzO3JmHNYIOGT81C3Sh6AD18z35MuTsb4zatDe3H+UPUDBg+lq4EAy6Tz1WmQd1WXBYv+n8qT19Gzt4tRzdKKcEt1nX9mwavau+1g+GUFfc2i2eLx5ybQROD5zGCc5kPYhk0c6wdtyP6N9PzBnHACHRUp4= X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(376014)(82310400026)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bmhzCo3pcq1pkmxs4gFHajiwKAuMszU8xV9/vawDkWWexVATJSC7mlO4AdkQehcQe9+1qmCqvrOsCOqLKp8f3PwLXBzJaQtyAQSucYuadGH8tVSvDWJjJ3zgoXWROB73H+MR30ZCi/jfBdnlGsAXanLkEoAqN/G3qstusYHvECfKHhZAAqM/1aCsRiMKEl1FM/W72evLW6msJQ3K4xqLWbjek9HLWzSjg9qA5c7rr1N6oenDXEVq8au5qGgW7mA6WsZ7w5sPKCkNNKcqvQvBLc8SBK4j0g/nvKHpD7Ac0MC9l+gRs7q6jDGYberRibZbdNkaL7EBwnhMprWf8Lm6aWg9oQL/6szxxZye12GgZU9aMqqB8s/xhlDFwDGSeGnPhn4tM54TObhKX4Ui18TQ2vgsBJygLff4XtOToLxeZTwR01uDGB6eretFpGvstv4o X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 15:32:30.9836 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5428267-90e2-43fa-bf2c-08dead1704de X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7232 Content-Type: text/plain; charset="utf-8" Coccinelle (scripts/coccinelle/api/string_choices.cocci) flags an opportunity to replace the open-coded ternary expression in the probe dev_info() call: k3-ringacc.c:1439:3-32: opportunity for str_enabled_disabled(ringacc->dma_ring_reset_quirk) Replace the ternary with str_enabled_disabled() and add the required include for . Signed-off-by: Nishanth Menon --- drivers/soc/ti/k3-ringacc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c index 7602b8a909b0..ec4207d98dca 100644 --- a/drivers/soc/ti/k3-ringacc.c +++ b/drivers/soc/ti/k3-ringacc.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -1436,7 +1437,7 @@ static int k3_ringacc_init(struct platform_device *pd= ev, ringacc->rm_gp_range->desc[0].num, ringacc->tisci_dev_id); dev_info(dev, "dma-ring-reset-quirk: %s\n", - ringacc->dma_ring_reset_quirk ? "enabled" : "disabled"); + str_enabled_disabled(ringacc->dma_ring_reset_quirk)); dev_info(dev, "RA Proxy rev. %08x, num_proxies:%u\n", readl(&ringacc->proxy_gcfg->revision), ringacc->num_proxies); =20 --=20 2.47.0