From nobody Sat Jun 13 07:47:33 2026 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 033BC3FB7EF for ; Fri, 8 May 2026 15:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778253981; cv=none; b=Y+JD97VuAy6JTpDqUUW2UH1FDlMoCNTymnQCJONNr2GELqrGfyHMbGkUuCpCcJHiFvxMw+T+Zk7NGl09W1bO0ZCAsy8pp58VeJQhwB7nWU9HkBzTR5CmdNKDxeA2T+EvXLyFYj4u0HZEwlx5npTxH+I/Ba5THv5Ilompuzss9u8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778253981; c=relaxed/simple; bh=EoHemNj4QSlc7oh17Do0vLZXi/sFzhKmgdTFTFanNME=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i0MIJgnD2qzOaahGtfUC6EIonXdchjqlx8nL9qNooXYdohpReD3o0DP4qiEJMjKWO1HzlYEmTpar1DVkIT9ZHNfE/njLxfIvFMu8gr7qfIS5tg20el4Kp1fE6T3CFHjQot4hO1PQX13g/TdcncR/XpL79rLH5CFKB90SD1KPTro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O9LjUVpb; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O9LjUVpb" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2b4520f6b32so3985261eec.0 for ; Fri, 08 May 2026 08:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778253979; x=1778858779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wcF8JZ3hxoubiHdfz7A8sdhKoxTejC5I3xx0KcFawK4=; b=O9LjUVpbabvynlDQrujy0Uu9bsaKI6myljh60YblCbin/efVNKWIiE6jzbCjP2Qd1l V7AZgirWPTyBOp1v+BOU+m0QYs2kKKnYb5yik/lvh4DW0BbPbFytPc6aU0NpgJQSpdL4 k6MFCdfcryBmAhhYi05o5SrTZr+FF8H8vetSNRDFweUEYyqHu2uYOfQlO8fWnYHI+6dg R2GCNt+Kk1+hGSKe97bEHco50oa1rHxJL1l1NB4Fltv7Amnm8yKW7olbOWIedWuBDfEp 8gTMiR/hFl0/WpvBrR9XAOi4Mo1JGhkVGo+Ku/JP5FGUsp8AgmMIuLZ1wOnK232Taa3g vZmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778253979; x=1778858779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wcF8JZ3hxoubiHdfz7A8sdhKoxTejC5I3xx0KcFawK4=; b=Ip+FSL9oVd1mKhSTK274OcUBiX/ulo65WJXqKROPKh3l2BaiJmSjKHSKZ4Z1eUahPv gGZai5a+S4Tte0CSOMA9bq7HQrkwd7tHNRw2iz0qEOyBTZUyGVYQeoAmNfKC+CfmqqOz iKBkgM3aYRtyiOHOvmcVs8Kb0nmxFNGIoJe1AoNJoadYFr/RNqR8VErqOWiGhvKACbaT UZ0Z4UMWIKkPY9iQpqy2Ut6cjyI4waWgI7aUkF/0K8wvGSmyMVOrp1oFzpidwWxBWfjq b3+fcPMy2X5GQ0mtWYwj2BHBX8WmBl22RpYDsgdK2dQHtd5QxM5HU+2gA5wkwdz9K7no r+pQ== X-Forwarded-Encrypted: i=1; AFNElJ+LbBLdRMubsyYHen4uHecJMG6+kKqYaSXwRVLTIOXFRwpqEMrPRlaHCZARaWd3zlXC3dJBervT+WYiVHo=@vger.kernel.org X-Gm-Message-State: AOJu0YxAkTfvebHed4S1Z3knn4ImkmqRAfZMxhDg6kgjkhdJNejAII6S +FdUiEVe7n/qQVrAmqBsIEH7C8gkDD16QgLaS/dhkDyE7hVYEAbWbfdy X-Gm-Gg: Acq92OEDHtdufHPOrVmGtOCIO8QGb/RstQzi0NGqV1mHTL7rGtRTJTtYQ7EtZF0Qhx6 l+9xjL41ZhklrGSHpUfzIvtw+bQZSN+oiqJPC5D7q6jKZRusJ2k6InB6u68dx/abUvLAYeTX5Da RHJ27mv1Bb8jKq3YButrLpiASQkfRtOcqjNKaNBrEppomdYBNeArKKFTRZNaMS62aYFJlY+hpZo y6atK74Ms76ZEDL+4ARMkp0Mgn+Fa43rW1iUSaNK+lKI6/YbyZgVAB38hDRN7WdUcyWNRGHmQH2 ISm0b+t2A3ooFYTBc60uykt9rgDsJXLwx5mBf/bswu/KkNYDf/NHxFjRpb4t6Pj5pCvfnx9tgxV mLxnp5vNLBr3ZkMzjKP4BZfnR8qYIq2Qizi+6henb924abTf3PnD/L9H5MxNN3nWtu62UNrRDGk gBTN4Wu+YY6EgCblPmTsa3cwArzsnn8p9VUEtGseRPcONIqmQ= X-Received: by 2002:a05:7300:8608:b0:2ed:e14:e956 with SMTP id 5a478bee46e88-2f550e4b212mr5939964eec.32.1778253978989; Fri, 08 May 2026 08:26:18 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a53:11:5d6e:9aed:ce1b:4ae9]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d43b4sm2535486eec.11.2026.05.08.08.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 08:26:18 -0700 (PDT) From: Jun Yan To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vincent Knecht , Grant Feng , Andre Przywara , Manivannan Sadhasivam , Jesper Nilsson , Baruch Siach , Enric Balletbo i Serra , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Peter Rosin , Viresh Kumar , Paul Barker , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/5] dt-bindings: leds: issi,is31fl319x: Add description for the shutdown-gpios property Date: Fri, 8 May 2026 23:24:18 +0800 Message-ID: <20260508152435.21389-2-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260508152435.21389-1-jerrysteve1101@gmail.com> References: <20260508152435.21389-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IS31FL319X series features an SDB shutdown pin. Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset. Add description for the shutdown down (SDB) pin and fix the example device tree binding. Fixes: dbc801b472c1 ("dt-bindings: leds: Convert is31fl319x to dtschema") Signed-off-by: Jun Yan Reviewed-by: Rob Herring (Arm) --- .../devicetree/bindings/leds/issi,is31fl319x.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml b/= Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml index 906735acfbaf..ebf2bed51e7f 100644 --- a/Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml +++ b/Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml @@ -39,7 +39,12 @@ properties: =20 shutdown-gpios: maxItems: 1 - description: GPIO attached to the SDB pin.U+U+ + description: | + GPIO attached to the chip's SDB pin. + Driving this GPIO low places the chip into hardware shutdown mode + for power saving. All register contents are preserved and registers + are not reset during shutdown. The chip exits hardware shutdown mode + when the SDB pin is pulled high. =20 audio-gain-db: default: 0 @@ -174,7 +179,7 @@ examples: #address-cells =3D <1>; #size-cells =3D <0>; =20 - shutdown-gpios =3D <&gpio0 11 GPIO_ACTIVE_HIGH>; + shutdown-gpios =3D <&gpio0 11 GPIO_ACTIVE_LOW>; =20 led@1 { reg =3D <1>; --=20 2.54.0 From nobody Sat Jun 13 07:47:33 2026 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F44E3FCB20 for ; Fri, 8 May 2026 15:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778253997; cv=none; b=YmhvbUaalEIS053qH0+ObM/ZraGu1CVqm1Bi5M2iTY1denVAie9D0UdEbkTWDg9yIrvIFGM6lSpvFIKJ1/jpSsyKTuEng0+QjJ1tSYuvucOCDEZX00TR/Dm0Gbol/UO+CN5mkiUxODTlHH/mKrlxfqWIr8SDGf/VAO2KhoanhVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778253997; c=relaxed/simple; bh=8Qwf36rId+Ems/1eDwX4FkjrATBDA7Znl2SUcpy1ZKM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=klDrevk1V4YGGtYKXxznn2igEiDFRImuC+8NICY2ofzJ8abxdgGbGsT05eFsRvLjIplZOVny5Z0nhiI/XYd/E1M4FxkDuQl3QufQ+jOPJMViSlY6P7aZeQuLlFbIpa+F8gLn8C6TZzEScrxWxqIutoVHtQXLkQTqCncBQtJNrR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gQQf0al+; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gQQf0al+" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2f0d3e07e30so5527378eec.0 for ; Fri, 08 May 2026 08:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778253994; x=1778858794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R8eLQlhXdKYRqwLg4DykUyxCfZQPw4q7VqcTUbCsSV0=; b=gQQf0al+Ql9V8ivsZYRc9GP4KYBcCsvgTIgyDeuSEae7IsHOKlyQ4IfUc5Euslx4eJ WBSYsD6FzKaQWBfYutn6tqQRKqkYox/Te07X2cODbclAcIEHpixlOvB+Zl/pQR9m0kxV cExVgIaxzU1cqb15oWo5pvV7q5VbiYXn0GwpDg/Du5fcd9wDrMZXwFhrotsoPgg8X4se jJ6IfMRATVuYBUkaq/tp5d/QNeP8ySzZ/ixmLSm+aTvHL43WP5fw1OkB82KuIAuhUDfZ LffHzPkvMZNnx/9WegllhOxvECbIRV4kHXmEsly78Xs3AdlOYnYN0kCW9SGV6eTktOGD 8uBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778253994; x=1778858794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R8eLQlhXdKYRqwLg4DykUyxCfZQPw4q7VqcTUbCsSV0=; b=VkKFJexbBAX3CQUIHZ7wkIDyOYZ0szjEFUl+raT6LQrWDBqO1SoMeX/enNv9o8Ufiw lbcV+jJmKOUGtv0a5Bu+eL/7k+EHjyK41isG+bUU4G0xfgNWMSXvlGFidnAn1NtY15T5 IG5CH5SJpjYGpB652NN5xMnDowlfKmXEQy5PCbbG9hhxDZganDBshs6zY+dAUz7W90mr 43Pykz8uo9gVwB3EeihoWucF15aFFR/JSUADv6q/umCl0gjzCIK1UYa1p9IiZC6R9Zp8 vpfyvJ4PrEhJaa8HCIdlVaSvElpHWxXpJ7H21z700cCVqbVTXU2jPP33v+vVSEHY8JN4 K8lw== X-Forwarded-Encrypted: i=1; AFNElJ9zuKLSwYcu3lX+2+z/JlyKvsaNgzuIDvxTnkYoLSftWBXvX3v6S9EGTifYkYB/CXiXCnektk/Y4jUsbeI=@vger.kernel.org X-Gm-Message-State: AOJu0YzANY5p1wb10A3jlD2N8BBYCDFD0m8f8o7yNBqBAukWJSVLLgVx jv4OTQCXrLFRUiwD5T6gWsuV75dYKHtbCNgyGsE5SyPZj1V21tvb2OeG X-Gm-Gg: Acq92OEczWJa0cot59vBFbmx0w9dKUti1o5VeA5WweAuk8cYEMhrujXldTj7htQXSKL cnfdsfd+j4I41lXEH7+QTr/8NrG98olESksaofaCIObC54MHnuWOBNYfkcN/xkgF41GrDoGszhu tgKjx1D6Zm3qSV2X3uqd/FqX4A2NjNKprrvily36HIPS82rz0J49s2Ypjz/CK86hPsHnjbnM6jv Je7K6roGVUJmFs4AU6xtfD6PtV43GZ8+pQswaHH1105MXDaRxDqSTn927E3d9k+itJsjian0IBD uvqH/afzT8sY0ia4nRnYOECMudNR0XDv7xepTKVCCoIfWpCA5pun9h6orAt5qcQm0f7w3t+z1mE U96Pkn19toQymsliHRSmkpu6VB1STkXXLfSOTGdBYOjE65LrvezaCnhGh0ED1VLjxJgkDF+p3fR fVqrEDn9cx5BWycH1n9m7sx3Qs7hfjP7stTLSr0XtlGgQNh2Y= X-Received: by 2002:a05:7301:1014:b0:2f9:5c29:ffb6 with SMTP id 5a478bee46e88-2f95c2a01a1mr155628eec.13.1778253994365; Fri, 08 May 2026 08:26:34 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a53:11:5d6e:9aed:ce1b:4ae9]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d43b4sm2535486eec.11.2026.05.08.08.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 08:26:34 -0700 (PDT) From: Jun Yan To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vincent Knecht , Grant Feng , Andre Przywara , Baruch Siach , Romain Perier , Alexandre TORGUE , Peter Rosin , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Linus Walleij , Wei Xu , Paul Barker , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Date: Fri, 8 May 2026 23:24:19 +0800 Message-ID: <20260508152435.21389-3-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260508152435.21389-1-jerrysteve1101@gmail.com> References: <20260508152435.21389-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 1. Per IS31FL319x datasheet [1], the hardware shutdown pin (SDB) is active-low. Fix incorrect initial GPIO level to properly release the chip from shutdown state. 2. According to datasheet [1] definition: Shutdown mode can either be used as a means of reducing power consumption or generating a flashing display (repeatedly entering and leaving shutdown mode). During shutdown mode all registers retain their data. shutdown mode does NOT perform chip reset.A dedicated software reset is already implemented in driver by writing 0 to reset chip. Remove redundant unnecessary toggling of the shutdown GPIO. [1] https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf Fixes: dddb4e38c6ba ("leds: is31fl319x: Add shutdown pin and generate a 5ms= low pulse when startup") Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl319x.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c index e411cee06dab..c947f844c756 100644 --- a/drivers/leds/leds-is31fl319x.c +++ b/drivers/leds/leds-is31fl319x.c @@ -396,7 +396,7 @@ static int is31fl319x_parse_fw(struct device *dev, stru= ct is31fl319x_chip *is31) int count; int ret; =20 - is31->shutdown_gpio =3D devm_gpiod_get_optional(dev, "shutdown", GPIOD_OU= T_HIGH); + is31->shutdown_gpio =3D devm_gpiod_get_optional(dev, "shutdown", GPIOD_OU= T_LOW); if (IS_ERR(is31->shutdown_gpio)) return dev_err_probe(dev, PTR_ERR(is31->shutdown_gpio), "Failed to get shutdown gpio\n"); @@ -506,12 +506,6 @@ static int is31fl319x_probe(struct i2c_client *client) if (err) return err; =20 - if (is31->shutdown_gpio) { - gpiod_direction_output(is31->shutdown_gpio, 0); - mdelay(5); - gpiod_direction_output(is31->shutdown_gpio, 1); - } - is31->client =3D client; is31->regmap =3D devm_regmap_init_i2c(client, is31->cdef->is31fl319x_regm= ap_config); if (IS_ERR(is31->regmap)) --=20 2.54.0 From nobody Sat Jun 13 07:47:33 2026 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B27128B4E1 for ; Fri, 8 May 2026 15:26:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254011; cv=none; b=Y0VVX0bGLRThtv2BPwq8YfsY2/qZD2WJxYO6p6tcEdk71Dv1fwoed4nEAqA0StVPzUXkCF6X4F02h4veJKtxBrB9FsJur0WWUVVvJtEYjiC3juupoilN3h9iKfRDY3P10vfFsa9juvXtSFGakvqT4eAguztme++kJuuKlKDJi1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254011; c=relaxed/simple; bh=nyMTRWzeAj/fdIbJOO7agc/LqBuV7MsuCjx+Azz5FJg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sGN4bM5W2Bguv8S0D0284h0Nd9J4KPThYvOhqWgujm7w64/QKM4lVjRIlLvr898AHZoilyxkMVjL0rqqBITECCQHMCahitzZ9zM8cvML29xLayGpNtOjpZ5YOgC6pKWIzGbYggvohoRDwJx7Lj7IKmMtVsE7xiVGppXTZFVPhBQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lcRvfX1A; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lcRvfX1A" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2c15849aa2cso2750524eec.0 for ; Fri, 08 May 2026 08:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778254010; x=1778858810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pB2cQFjbuhjdNnTnLKqzrMd9wBQ0wQUJd1YqmbY53n8=; b=lcRvfX1A5X1S0tZJ4wvUuxYgmH1LM88BrmZXI3d5ldb8Ot7oYSi4GkV7xxR31bybER X8j9m8gGrafcQf7h97xZtcPE8Xal4hYHt4jWN1b73Q+aGUIPI/6HC21LxrFazKKfp3R1 PEwnS4qzC6Rabi5ud90zJ+1goU4pFoKg1tEL2Ua42x9RWOjAbTg7/J7OaCOY/DKoOmBG oXgc3+/xMSfwGQ38NlWZfCudoNxlytnl3A48kvNau6BkDijJrOMNT7bSzmqDx3S7GR4X RCn2cVZKXSOK0mIrPURyxWnKEWRdlg67v7xph/Cpd5XiBmz+0G7bNrQ49RhTpextZfTS QD0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778254010; x=1778858810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pB2cQFjbuhjdNnTnLKqzrMd9wBQ0wQUJd1YqmbY53n8=; b=c/GKC7oIxLlX9oUU9xDvv/7a4JMlKzIJIvqHG4K62dgdg4lOaYSQiPLRW0oJfI+NpH LUflBxQDnfZrc8B57qz9C4CsXmAyWhdQHoFuuUfEYiAo4+SAnOxbQJfXprdke9WgDh0T 10RT/nh36ed07yhUxXXNfBQscwX721K9zFYlAvO28sC47K2ZM5w5twPaHMy3+odXkxYH dqiULKam1g4x0qBu7cOW2///JIwWZqODLimZSvT/7N7Tm4ukuAyydppw2ODby0XdWSj1 SDPZvBgFPZnkwqofas3IdaoNfOBQb/IgQSGdKv4I58yQA3zkJ5Dl6BpH7YfRb1zl9Rm0 2EpA== X-Forwarded-Encrypted: i=1; AFNElJ+KqtNxytyRzMqLuc1ausTxtgdNoHL2pdmQ8ETXbrQckSd0koYTrWWtLk8ujxYsEGUmR8bbrFkqCf3Fwy8=@vger.kernel.org X-Gm-Message-State: AOJu0YxqiZKpqtBEcWc7ngJFcRG3M5XS1k4qxVyDm/kByfumOUKf6crj fOLF5e0zK+ZW28+GkaNZhOcIFkCY0Dpmmb5MODgDIFU1mCuhqwyEBYTN X-Gm-Gg: Acq92OElUYhWkjHDd/JtiH+m7g16A8/sxj6b8RXk+AWMbtHXUzkerVj2DQYPFX3m7Q3 9qqmi0FmemGfXbUhJ6XDbM03qtiq6NkiqZeFVURyotIeVUee9e3wkwZxitajLj7dPJ+cx9s0+lJ uKQNRlaVvo40PhdV9VJQgpx98CFDBUtoLLvU7eGn8Ut8lQwi/xVxzNdCgOF77NYAXT/Iq/bpIQw QSNN4y3BUDZi42BC+h7cOnxXoGXtUFTZBPiJ1MU9iJfSGMuThHvomjXj08OmmQPuH6FyVJ7Uh++ XKMy/WnQlxWpCetGGoxYipeKalVeZObWOc1DFRG/3wkCr9YXGthqXdwZsINbcUBWaPKOGKo45eM 70SvEQBdlvq+ifPz787H01hHSol7f7zuxV2Nz+7kRQqs54EjOjpBUNjDMVKHXWq22HzpiyY3JSe aIFjqDC2ayKFHN51J1lEZw30DG9cI744teyWx/ X-Received: by 2002:a05:693c:2c02:b0:2d1:d434:d022 with SMTP id 5a478bee46e88-2f544ce9df2mr5983287eec.0.1778254009639; Fri, 08 May 2026 08:26:49 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a53:11:5d6e:9aed:ce1b:4ae9]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d43b4sm2535486eec.11.2026.05.08.08.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 08:26:49 -0700 (PDT) From: Jun Yan To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vincent Knecht , Grant Feng , Andre Przywara , Heiko Stuebner , Romain Perier , Paul Barker , Patrice Chotard , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Jesper Nilsson , Peter Rosin , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/5] arm64: dts: qcom: msm8916-alcatel-idol347: Fix sn3190 shutdown GPIO polarity Date: Fri, 8 May 2026 23:24:20 +0800 Message-ID: <20260508152435.21389-4-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260508152435.21389-1-jerrysteve1101@gmail.com> References: <20260508152435.21389-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sn3190 shutdown pin is active-low [1]. Correct the GPIO flags from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware. [1] https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf Fixes: 1c8cc183d070 ("arm64: dts: qcom: msm8916-alcatel-idol347: add LED in= dicator") Signed-off-by: Jun Yan Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/ar= m64/boot/dts/qcom/msm8916-alcatel-idol347.dts index 2de8b6f9531b..6d51d6efcbac 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts @@ -197,7 +197,7 @@ &blsp_i2c6 { led-controller@68 { compatible =3D "si-en,sn3190"; reg =3D <0x68>; - shutdown-gpios =3D <&tlmm 89 GPIO_ACTIVE_HIGH>; + shutdown-gpios =3D <&tlmm 89 GPIO_ACTIVE_LOW>; pinctrl-names =3D "default"; pinctrl-0 =3D <&led_enable_default &led_shutdown_default>; #address-cells =3D <1>; --=20 2.54.0 From nobody Sat Jun 13 07:47:33 2026 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C99833F23D5 for ; Fri, 8 May 2026 15:27:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254029; cv=none; b=bPOGgBjB7zKMZ/I/AadGNuuNlItEPrZ8tTDMZbjJ+Ko/zSM/nbmQjnzXwc0DEK62QDC/WwX70Wg0rHMNuuK5IZg2X5xKL7UTcWBRZ2V/5bPscft9qlsTVjBM1Dkwg6av3Euy+Lm9DZ+xDeO49hh5G1yowS9nRPQiTsAWtenU2CY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254029; c=relaxed/simple; bh=IT9hKFqi+NXwIQxrrHDq16wfzGZE5aP5iqbwqhp+jw4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=diOC6JDAkG9PYbvRxibET0wQeNWfMqwRq0aIi0bCPLzo+nDEofHKyaP/g86zjTSynyN/LoGLqhA/O9b9C0keCPQZHgYPrlcgagPzX/+tKR6PbokrZG3kzk56tq5mNaMu0gj7g3jIgtpDzSerBIHPSWH6GTq7w5arvOzV3Tax6wk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aSCiwAGv; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aSCiwAGv" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2c156c4a9efso2871291eec.1 for ; Fri, 08 May 2026 08:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778254027; x=1778858827; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6AZLkoMPXwZ4+vxuE7rGxM/UFbOO9EmAVj39oI/ALNs=; b=aSCiwAGv6u2vwzpimVbC6qrU0JTFy36QrTPreFqDn4gI9iddgmvJn/zylyasiLEbc9 vGu2rndSZY3oRTEICiGC5V+xCm10wK5Guw5Fc0hC2kpJ/sqc8cSujcJyRTWZH4PwARMm WYIIfmFKTUgv8jNwsxHutZw1I6pROu/8N7cn8w7cUpt6cVXrgGnnOplacSLpCDqcOl0Z x6+/DGcU1QC2uUzcXrKAiHa4vHSBX9ZhYchh1Giq6A07KKjsYKJ4TAEe8Uvhi5fqOgNc PMG5E+DmHClTuQcvBjbRrK52UQN4EYZYQktG9Weapy1DrgZRq2Szy4ipzhVoZmWHoPfa CjiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778254027; x=1778858827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6AZLkoMPXwZ4+vxuE7rGxM/UFbOO9EmAVj39oI/ALNs=; b=Of4dHppqJfvfy6JUn6iUBIHfJ7OfeWkNQjarHHIy70922o+kE9O/TMDGnC6dFjn9N3 YNcFlpUIAVW1W4emHbF0djeTOyzKLhg94gvhEiLFjwaFcQmPqr50tv73w+p0idCJYnno B8VxrLcXnYBrjYZXGloEk+yxpKyDcvWX+lABBnXfGfQ8rqSskENHRf+Ykt1fDJYh0vDI +4rl1K9zUbPqSiZ3n18Mr6Si2x2prCbpRHJoNAmxDlB2ZdR8ut8E1JtyK5oPivl+Rnv2 8ysmJWDDZRSyX30aI31Fm2K7qthE7tkWl886ZNdru7/G3BU2oyTyK/hcF9YMjOTz5SCJ e6LA== X-Forwarded-Encrypted: i=1; AFNElJ8JCCVzva7hXlP4bM/9Q9yM5zWBNwVL7yhaI+XXVes23FJv9Vt9CbtPYrU6XuXld8l5vT/m7nTf3uifvPc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzee5rCQSgHvpLkcp9W8Mn0Qa++u5dHYPp3oE/xcfY5aaYXSn0G s7m56I2rRMbGPuiSuz0PDyIWlculnAB4WNM9n9KYXyEXA3QGdssrOYOT X-Gm-Gg: Acq92OFdARZVlOmt9DhbDA9WMOyFHLh4xz0a8unjlo6dDnI2EXHGzwDbKzztzfO1aXI mBEKbeBtqbCScTovwVWwJDHBfoUAGNtoGzBnv0kf/x/IWOlTEJiwVLMv1BOSTp2zJVveo8s+WWR YIQVxDtOMJwtCYILg6jg+gOYnZSU85VYJl2Yff9fG2ISLfzcBZUZ8lIqbPpp4N8v54JiOljOlio EIYKm+w3yFVBo6iQQgl2Ms0Y/KC6I04KZFhmF7Ol6C072CAZhS0Ld5rYqFs3W+yqu6+oYgnMdOl PndMTmkoPAwLM+qPcuxGpcVXUyM390UXWZ9eBKQVBPIr/d8PH5umjtK9p7NSdllIPl97cMknoek 0FB6YII9REclKfbTXYQZJOQCnIbcHH9UVHS3ARqhHiIJO8Rf5QDjgRo3eCeKa3+MIHknASdNp2u 8kHwiFYr5iYKbmshtILjWVqVxGv8zPLz4hPqxixUihfzKfY2Y= X-Received: by 2002:a05:7301:1014:b0:2f2:8857:180a with SMTP id 5a478bee46e88-2f54d69aff2mr5899190eec.7.1778254026776; Fri, 08 May 2026 08:27:06 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a53:11:5d6e:9aed:ce1b:4ae9]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d43b4sm2535486eec.11.2026.05.08.08.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 08:27:06 -0700 (PDT) From: Jun Yan To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vincent Knecht , Grant Feng , Andre Przywara , Florian Fainelli , Heiko Stuebner , Michal Simek , Wei Xu , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Alexandre TORGUE , Jisheng Zhang , Enric Balletbo i Serra , Romain Perier , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 shutdown GPIO polarity Date: Fri, 8 May 2026 23:24:21 +0800 Message-ID: <20260508152435.21389-5-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260508152435.21389-1-jerrysteve1101@gmail.com> References: <20260508152435.21389-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sn3193 shutdown pin is active-low[1]. Correct the GPIO flags from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware. [1] https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf Fixes: 724ba6751532 ("ARM: dts: Move .dts files to vendor sub-directories") Signed-off-by: Jun Yan Reviewed-by: Konrad Dybcio --- arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts b/arc= h/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts index 258bbbecd927..c528d42bade5 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts @@ -147,7 +147,7 @@ led-controller@68 { compatible =3D "si-en,sn3193"; reg =3D <0x68>; =20 - shutdown-gpios =3D <&tlmm 45 GPIO_ACTIVE_HIGH>; + shutdown-gpios =3D <&tlmm 45 GPIO_ACTIVE_LOW>; =20 #address-cells =3D <1>; #size-cells =3D <0>; --=20 2.54.0 From nobody Sat Jun 13 07:47:33 2026 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D5EA28B4E1 for ; Fri, 8 May 2026 15:27:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254043; cv=none; b=ajkHaHjU2jgZaD1NVhQUixjenasWAxC0yrkxJQXxjD2dr2y2hr2s1srJ2HEUX7ZVTnNh1PFzpmTpA1SpE4WpTEF91j8xDr8GceasucDL5XxvvMXpKFjKvz6sJGM+BIQrySxcLyW3SzaXo6ofySvTE5LHb1+mKlXuXHPlK5YBKHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254043; c=relaxed/simple; bh=ow2Pp8Yde2ialN0PVZ+ngSDDkSxMoIzeQ2w8Qc4ooeg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZW5LFxoAeddeqPMB5M/bCwxYBf2/qyO+l4GQ2ROUcV23IWxW7p/UIJLqopytvEU7+p1Wk2xAYUcBj7GSipeAEsuWGNTv3KtgMCvOs23/5NL5ww5ksvYDqrTdziUhorxexndkoB7vs2R4ZIO7du35Jks4szZ2CWlRSdg2piZ8anw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tDkIVrsn; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tDkIVrsn" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-2ef2a1cc06dso437161eec.0 for ; Fri, 08 May 2026 08:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778254041; x=1778858841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IY5VpH1QCqNL+Hxqm+EMdHN3zeBtEzU6Oz9nJybwNNI=; b=tDkIVrsnhlC7EorEIlVCrt2Bj1tvrpK9AYiS8oRhGDKhQf264ZOJdcMy5paepFISve tUaYCn33hCGyi6kVf+A43yljTjDAXyRx99lijdNFavSpKu4ThITeNK0Ixz7oTv0ENsRG nU2V1iWdZh6k7mMaTVCsELW0rI5x3eei1Nu5haQkaLHDUahKGdWL5tkLudoGOQ00LMPd k/OxJLUgd9hubSTILqi4Q4Li11fpRaanKGr2Ldlbup5MeV8r1Z5x0sHKgjE88pk3nFE/ FXJ+AZmbwXywIolQNeEguHq75lxwW2fg+FW7xIj33yGhuo+7W7Di4jNXyoGmCuRO8+gu +Etg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778254041; x=1778858841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IY5VpH1QCqNL+Hxqm+EMdHN3zeBtEzU6Oz9nJybwNNI=; b=B9vSC/WThg5k1V1Zg9PqGigVRTOByTMAv98Gnh4WhI1Ukap1IuKH3e1fqglNqOMr6m Pyz5mEWk6+0mDc+mrFcK2bSGTp8CKtNb1a+a4gWAGxQpDoYU16t8GtQ3w+lS/Kxz2CQP FE8lt/24IiJHg2eBOIli/0O4WtO1WL9ruCYq0zxP2Nox/gakt+K1UNk6pGiEaw5iCv4d 1Ag4csOMtTpIgNJibEFJ+953uvyeWYb/d5XJjlaQUOog1wTk0Au3sVGB2j4EAFaZ60H3 RHbJe5g7+oac0tvWDRo4K0HjxM/n9p+7AG/rpmjMDOaobLb5+Fz9mTJfDnzjSv7tw286 /vcQ== X-Forwarded-Encrypted: i=1; AFNElJ9sKXJuTVA3g7O+HNC/4FymG128g+4UYiL4PO3x12MFrns0ZE1tqsd2HQoWnxCVm6FmyLqDQYvqFVVkRXY=@vger.kernel.org X-Gm-Message-State: AOJu0YzkBdXlZ4ol0kMngzX46LyvplpOqAL0zevCSjmHJ9OFmv+Jj/bb N0BSuYLrexyh1/5znLSGPsLjFv1KAYmdrkvoaZHCTMs8DwWA/jm9dH7W X-Gm-Gg: Acq92OE+xo2in1ZXNfAmqjCGufxp0toasVAPBt6dljRcxhc1HWic98+UHY4/757QS5p 1ihXz+FtUef9gx+6edbW9P/DOz+oK48M1EDRNikr+NVC7LaPcJL/TDo4LUI2iYyyKpUrlfie3aL tQ+g7FVZqbi/k5aLkUnt9+ET533mTkUQyqZncpuMJi1A3PlU5sio0sKL/5KY3R9jSljkYOtDl6d Y0ipvRjXXOrt+5VR8WOOmQv7oXkgV8qPcjWh95XoUmPIL0WGAn6NDqHWqBVdC7vjHKczSG9w7NL hyglDHtGtn3sV3NZ//4ql1A9Ugxl39IIJsoDkh4R5BrL/DIa3T4VjfHgEIgAk0ynJdwrQpAYehT 9SCSXN3VdnG4kTlloIej4ypxIAGcA7e+zL+97xSNTXGeTqN+IXD+1q0aRUZ3QZfJNCo36XXuZzq CoK1axSN9aam2UVsujEwyWtHdNsE6r7YrfMEvFbsC3cFBJTwM= X-Received: by 2002:a05:7300:434f:b0:2d1:299f:521a with SMTP id 5a478bee46e88-2f54a38cc95mr7218915eec.26.1778254041341; Fri, 08 May 2026 08:27:21 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a53:11:5d6e:9aed:ce1b:4ae9]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d43b4sm2535486eec.11.2026.05.08.08.27.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 08:27:21 -0700 (PDT) From: Jun Yan To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vincent Knecht , Grant Feng , Andre Przywara , Jisheng Zhang , Heiko Stuebner , Jesper Nilsson , Sudeep Holla , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Shawn Guo , Florian Fainelli , Patrice Chotard , Tony Lindgren , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/5] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 shutdown GPIO polarity Date: Fri, 8 May 2026 23:24:22 +0800 Message-ID: <20260508152435.21389-6-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260508152435.21389-1-jerrysteve1101@gmail.com> References: <20260508152435.21389-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The is31fl3199 shutdown pin is active-low [1]. Correct the GPIO flags from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware. [1] https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf Fixes: 737929191283 ("arm64: dts: marvell: add Globalscale MOCHAbin") Signed-off-by: Jun Yan --- arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts b/arch/ar= m64/boot/dts/marvell/armada-7040-mochabin.dts index 6bdc4f1e6939..cf690a85cc2a 100644 --- a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts +++ b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts @@ -236,7 +236,7 @@ leds@64 { #size-cells =3D <0>; pinctrl-names =3D "default"; pinctrl-0 =3D <&is31_sdb_pins>; - shutdown-gpios =3D <&cp0_gpio1 30 GPIO_ACTIVE_HIGH>; + shutdown-gpios =3D <&cp0_gpio1 30 GPIO_ACTIVE_LOW>; reg =3D <0x64>; =20 led1_red: led@1 { --=20 2.54.0