From nobody Sat Jun 13 09:25:11 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43B3433D515 for ; Fri, 8 May 2026 09:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778232161; cv=none; b=oj5LS3r8FaDEO8KH+//usGxqyK2WN3X9BxSwc3KD7MVurE+8yY+S8JgZARHghPEHyeL9UAWMoDIQnvT37QiAAlYEx8t4TTqlCtedwg2bzWZiRUVqK9deW+RIqEmsnB7twTbj6GX7FCTESXbjflgAW79UtJLcaR0geqPgRVEiwuE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778232161; c=relaxed/simple; bh=hv2NETYo2I9M7dPx7h5jpVQA4n0c3N4NMGvDoMF7Bpo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gsaDQS8Btb3g5bNSO2RFkb23qlGMRcHR5TUl28iDPcl786/GqFKIDJjgcLYCSQpbpLeNykj/V9gzplLrtcagw3EVpqtKTttmqP1giEp7F/GK6UuR3U7Xj0ltWLu2ASrBIX2Xj7fuWRKq7aE6sgthIM/CXOc4TgaI7Ryy8QBeJxg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=HMPT7Qxz; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="HMPT7Qxz" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ba928852a5so11976985ad.1 for ; Fri, 08 May 2026 02:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778232160; x=1778836960; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5KU2uqSMH44pMMKukBSajP4+Sg2CY7L09ZEK1/3akP0=; b=HMPT7Qxz3fXRbL/x3JxZfTXZODe2gMQyYM2NHMlUUvY9wdFVOoDLYsR5ivcF5z8yU7 s5ucTc6RSI2LkNmi2q8N4D9qlNM+jjcqC8rzULMioBkmeicu/xkmUNkvIxACHFyet0q3 UlgwFLdSc/AkFqXh7LUtIDVhw7PTZzposzVX2SomGfU45jFAfuTpnTDUTWK3E/sEoibJ yZjRejiy0IUIpv4cN+LGkUUaLQUWuy0Rkl8FUg7u2WgXriahiPSOze8/drqQIY0rd61n r5XD6f853YFo9iOxLMWDMwZZdwRs7Rg/d3bgL7gpG/fD3pRsWNktElV1QN1wQlSj8KkC Kzog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778232160; x=1778836960; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5KU2uqSMH44pMMKukBSajP4+Sg2CY7L09ZEK1/3akP0=; b=d2toy/O2i4ho5S3iEDuXKuqsaQ+4NCl5LcUWMHNyWRrM67TJIqw1x/ChMP3p6W42Ha oF0SVRFkXn/7tLEZHUE6tVY3Tja5Of9PN/u3IwthCw1cgoXzLBY9ODHDcsQQJ6uX79Xq Kltd6McmjOgkQXvFdbI4rLOAy1RFAcdszJ/lGhEAP80KqIngywIBShCq4BOq9VljW1cd 5EtQs4/kR2H119riYwVjOV127su1GWQ5p7LPnFPEQYTNT8h3MWrpedDaOaNmh133Cl2+ YVFh6TMf1en+9dxgSdCpF+6kbpATisvQQzuX4ozctOBDQPMLQysghrtCJI3MIYjYR+hU 2/Xg== X-Forwarded-Encrypted: i=1; AFNElJ/KJ+zJZ5+sAt2uFgoWc8Kq2m27aD9/l5OgVnYtHHYRWcudwC20fZimrf54iI2e6dgAdKX1jj1JhuWnSF0=@vger.kernel.org X-Gm-Message-State: AOJu0YzhvBQXU5ZcEualdx3839bNf9tY0Z6HmEQOYHNHTUT3u47l66ve 8Sh9k37NeXUffRv1qJ8s7FHUYrb2LCuWJDBgCWz4devFwA/WztK94JxjHoW9wBne1rc= X-Gm-Gg: Acq92OGtuc06MXV1JN+k+4lnTvKO4I7h9ao3AGSjkUT7VCXkSZlqEg4zB0E+OXI9bD2 v35qvUzJVgkvR+WgLeurzjTRk0IqaoZztYNxkM90w+KrzJGN/xkwCHpuF/yw3Gim+uMLgkw+isg 4X8DI2LWZLR4Vbf0q0ub7QK0KiIQlEPtq5AAPXBm/EpoJDzW3xB68DTMWr3Kzbv4Th5vtrrtkTg ovuw9XnNdUbCI1D+ZkW/MLM8eFllpXT6mUeAKCL0L0ZKCeT0euK3dQI1SNm2OmRY5jYAw+uK8bC 3H7ZR3CDDG38pHzyn3OSkhfEDxvha4TPg+yLvtTAQINxDMg67ZDjd7ciXCqD972Tfpa5ecKlrwA B+spc8A2JHJ5wnEt5Z76q2klqB2uIecxIMQr4+M9QVgmMGgk1dNCKG6M2X4SEFfShybf/vBNzot k0eTbiEb+00cw9wOf05qI+ZYz5is+eLBJcYd1AyK66wz98mkxRqnEZnHGybBohIdE9Xvn8ibp6H LuewEOb27MCeBltkke3v8huhvRoEQ7BYbn4wLGM+nRkarh2D2qrKYp3yQ== X-Received: by 2002:a17:903:947:b0:2b2:5857:583e with SMTP id d9443c01a7336-2ba798bb607mr118453155ad.31.1778232159686; Fri, 08 May 2026 02:22:39 -0700 (PDT) Received: from localhost.localdomain ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2baf1e36c65sm15107615ad.40.2026.05.08.02.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 02:22:39 -0700 (PDT) From: Abdun Nihaal To: loic.poulain@oss.qualcomm.com Cc: Abdun Nihaal , ryazanov.s.a@gmail.com, johannes@sipsolutions.net, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, m.chetan.kumar@intel.com, stable@vger.kernel.org Subject: [PATCH net] net: wwan: iosm: fix potential memory leaks in ipc_imem_init() Date: Fri, 8 May 2026 14:51:39 +0530 Message-ID: <20260508092141.82495-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated in ipc_protocol_init() is not freed on the error paths that follow in ipc_imem_init(). Fix that by calling the corresponding release function ipc_protocol_deinit() in the error path. Fixes: 3670970dd8c6 ("net: iosm: shared memory IPC interface") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/net/wwan/iosm/iosm_ipc_imem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wwan/iosm/iosm_ipc_imem.c b/drivers/net/wwan/iosm/= iosm_ipc_imem.c index 1b7bc7d63a2e..f4edb277efd9 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_imem.c +++ b/drivers/net/wwan/iosm/iosm_ipc_imem.c @@ -1422,6 +1422,7 @@ struct iosm_imem *ipc_imem_init(struct iosm_pcie *pci= e, unsigned int device_id, hrtimer_cancel(&ipc_imem->fast_update_timer); hrtimer_cancel(&ipc_imem->tdupdate_timer); hrtimer_cancel(&ipc_imem->startup_timer); + ipc_protocol_deinit(ipc_imem->ipc_protocol); protocol_init_fail: cancel_work_sync(&ipc_imem->run_state_worker); ipc_task_deinit(ipc_imem->ipc_task); --=20 2.43.0