From nobody Sat Jun 13 09:24:53 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ECC6386423 for ; Fri, 8 May 2026 09:04:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778231050; cv=none; b=FYDEhl6WH61fDD+2nrKxdzl1qjtfIQPOpyi/X3MhL6wI7OFpswUg26V/tHZ0rJnhRBGRcII8PguB985HjnmJ9B+ZvUOgo5YhwZ82/GV79Poqp/0UteWUmjoeoeNRZtLXzK8wCST8Nqs23RRF+pJgpo1wDnBW6RpjwTBBmfjzmSg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778231050; c=relaxed/simple; bh=zajsfd6Zx0r+0jFiouMsfLQHH3EpQd4NklNufX7L6ZA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Af8HMuIaTYujon7+Sc/0a4kDoneFDng0AwYk/MATUj5OADPUdpWB+FGOR2jVcLivlMgluP67F5UFsEv3B3iNnLhN7uSUJ3cNVNp+b7fxuz6epBHQvIjBTynmw40EDQUPEnvKplete7eGJvCl+QNJ6GjDDcDMNpxditufXjIKbg4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=Pszw1Oin; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="Pszw1Oin" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so16247795ad.2 for ; Fri, 08 May 2026 02:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1778231049; x=1778835849; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jPkAvC6+8Qgyj82iA24dzkSdXJ8Nbp5ATROfqKNJE9U=; b=Pszw1OinQ0er7PYgofMfkf4am8zuXx1++Oev4YtaGiBDa7/88b1uVNgDpiaaLBGRqN kX31CHkjgsp14yf41FkqW6oSAGn1jqF0fkSxU9pbWAGpbaOWnuQ8G4EASJH6EsuqvV7r q4HMr6Kx6hMCYvDcaS2u2rBPwcZM3SgPSrGowi+uLa7c9DXpsd/K6pKO1TOZUbUGgL66 ZK8M9O2daVshz//FLRV/xfhcIPpzzwD6VturmItMo8DblVPjzHtFkg/GVD/dKHXPzAzc yN94zVXvZ1nQDFyB9+InG3YTYix1XynlV40rislw6/8LJhb8sDJmOIBPZQIzrGTADuqM jhhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778231049; x=1778835849; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jPkAvC6+8Qgyj82iA24dzkSdXJ8Nbp5ATROfqKNJE9U=; b=gXIuacbMhFIl8WIpG7wDMTAJJFh5qcUr/aCRLaBeOYyhZuCtgCFqlLP/oypXdNpEuS NL2pNIm+/R6UP40PANmD+yRkX5EavvMOtC4g5OnAW2BmbnNpnrc2hvxM5HPAs7gfHnq4 JlOYq7QlR4XYxop6O0tnMk0QJDjUXHW5TUpLCNpWZcH5Lyvg9raB5x07mPddTDn0Ullt dc76tg4kSP6yKlhGZxQiij4ojW9mDp2yRlVVG4cuMeCSWtWCE9N3sJswk2ijBthKDDEF 98mhoRf4dJ4hIupkInoftLNKyIgJw9YVn9vFLXBIv+H82RhRsbQ0tc4LRvx22wIQ7TRt /Edg== X-Forwarded-Encrypted: i=1; AFNElJ/Z4h4BKkrNGt3dOjgIAyOTGZ1cBuIQCjL+ssbcGZvgury+adLiCf9X3prC5BIOk5yfs2XSIVjRcf50EWA=@vger.kernel.org X-Gm-Message-State: AOJu0YxByJDtusscAC8/4afNd+CS4xv/X76LjeDn9LtGeCfHPge6BhVK YrKZ8zVNB2g5g9X29HbquR70Jm+HntAqBa+iihkGWbCNKxxGCn5ZbaMWASPmzZHjwDAUKsDOycH z/iqzzWo= X-Gm-Gg: Acq92OHhV3D4jCuFixszUESGQTXbxDpgWlEd2es4E4WoHuJOE1S2DSn+IXysQ404FXL y2nJfHJA3xW5oJUG7qne22Nvme2HbTjnU1QTGEMArsd3txauN0DMZydhVLzcTc587umPC2Is+5x MUreQi4tHVlCmEE0R/ibY9bjYoIDmugirQ81jeHXlBS9y4OUGlG6vrzTDXtCwuXmFMY8x71qkVf vkWCA65O+JJdVU3yRwM8BN8OrqVW+dndjPCWhC3Is47Kn/H526ynklpdOgZ+A17D/M9VTiUz5px ucC4Nves4AuxaSvWZ6urzkC8Y2RWhEVO5EFTnlfxD1bAFU9qSljikeSMkMbjZDzKtspYOO21QY8 U9/7yUejECtomCK/aRgvw7fRyLhzhIc5BDjPAMQ4kKbKL2jDmA4cQxVA3D+MbjpOylWkWQMTTqB sWxcsMjymNkPjOP16Kpw8KsK9zOZmuD0dmL5MxP5N/MH8Z1qHjLl0Yzq0RGDjfnCvVJcxfoxnIp Vh3s/Sut3lrSbUIAduyNK3tDua0TF3ikruAroM2jkWdc6OTs10PFzMY2A== X-Received: by 2002:a17:903:350d:b0:2b0:6f21:8289 with SMTP id d9443c01a7336-2ba79c2232amr113703265ad.25.1778231048621; Fri, 08 May 2026 02:04:08 -0700 (PDT) Received: from localhost.localdomain ([103.158.43.41]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2baf1e3571dsm14056585ad.42.2026.05.08.02.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 02:04:07 -0700 (PDT) From: Abdun Nihaal To: atenart@kernel.org Cc: Abdun Nihaal , herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, pvanleeuwen@insidesecure.com Subject: [PATCH] crypto: safexcel - Fix potential memory leak in safexcel_pci_probe() Date: Fri, 8 May 2026 14:33:45 +0530 Message-ID: <20260508090347.74176-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for priv in safexcel_pci_probe() is not freed in the error paths, as well as in the PCI remove function. Fix this by using device managed allocation. Fixes: 625f269a5a7a ("crypto: inside-secure - add support for PCI based FPG= A development board") Signed-off-by: Abdun Nihaal Reviewed-by: Antoine Tenart --- Compile tested only. Issue found using static analysis. drivers/crypto/inside-secure/safexcel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/insid= e-secure/safexcel.c index fb4936e7afa2..2bd8641a07b3 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -1893,7 +1893,7 @@ static int safexcel_pci_probe(struct pci_dev *pdev, ent->vendor, ent->device, ent->subvendor, ent->subdevice, ent->driver_data); =20 - priv =3D kzalloc_obj(*priv); + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; =20 --=20 2.43.0