From nobody Sat Jun 13 10:15:27 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012001.outbound.protection.outlook.com [52.101.53.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 196B61B6527; Fri, 8 May 2026 05:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217510; cv=fail; b=HuYj+jbijBuL+x7o3l+akyqRUBMlf2jGTbnLoUDugMtERPflGLnZAinR0J8VABWcJ8foDnZqeZOCffkJ1q2/vdEyziupHL30TbjNXmdrumWtlZm8P8d0gOXznUeHv4GEH7O0Px4/FRBqpZKrmsCo582eMyafK1CsHJPISZFdPE8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217510; c=relaxed/simple; bh=y300o+0eqPhW+1VS0aC5cATaTRaQUbTQLPt9jhqM8zs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ktGr0Wra5D1aDU6jvuJQ6N89LPYM/PwiwB77gF3bVj+6w4fQkcJd6pmIDy0X9Rlfm7nQUm5KbshMrsGia/cmzr/RlG31L7mZbxhH4TvAUwp2u4YP0UtW8TbpK0d4GH3+1agRXzZEMCtBBuRaBUlj7N1f1oph1Tl8jMZq+uKYLq4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=kBF7DR4O; arc=fail smtp.client-ip=52.101.53.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="kBF7DR4O" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bSvQ+A03yq5p0Vl40jG/DzjdZgh0AwMPqXdzOBF2W7nPpgMN4wqo79wI4nnBzYTRq+JzKTu4aBM4/HE+rl1D+WudyUZs4PHHC7Jww+MeFOdzEksMmVfVAkGO6toDNRHANUui6g9pGDCaVCBWWHY1mZ9Bp9OCYHei8MdlRdyWfAuEPzP7AbbRpTutminwMmpFj4iRkmn9yJ40LpD1akw37zHLpZ6Dj93GwMnS5J2Ify78xpUQDfFUCsIxn7tpGFdXxEEB+/mRoszRBcAu4iCZunZkiYo3xfKVi9ufeWnjeOOI5+5tlo7X1Prf0ekqTCS1jKHBuOhSKYbAlgWvXL5D9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XCYZozA+TK1+YqmiNmn9axd4zB8Da1snPn/M6pTLtH4=; b=SOPEvfQztoLgDKPIvjZq82Bw4I3gra9xAWloJz6lMtVOjHBakPlllAGRKVai+Rph+o3M53zQvS8HaOsmJlIZwSLtWhQ5IC7wFSheT/W2v7ZaYGnIFeF+z15uPANdMkn8Seenwh7ub4tvm1owhDwZgUAWzRv6K0uPYrAZ5Lo8CIch1IzSh3rJF4phvqXSRVaD9Y3YwA3uvyruYJTcmcKCwSLHm364ZIfgOP8KSBQ8bVdiGSK7Chw9A4+FvZerbJHYv3I3idLBz8BMdK/Yr2mXzhDLS/z+aya6bj16SUyTVOG/+lTd/Ffjxatg+yAACqV66wdIKOliF2RxeicAcwOZ7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XCYZozA+TK1+YqmiNmn9axd4zB8Da1snPn/M6pTLtH4=; b=kBF7DR4OF4Ju22IgiqOnD7KupdcYniLg7XT9RmXsX9cNJ+OMt602HTw0QRUu67nG7JuiQQ2P8hFZWV8AySrI7efh5xMCDb9zf2EpCTvdhKtco/C+74kA2jQ3wy/f/HkSH1ri1HX34sBn3LQSfOoshXr5eWc/k8Sf85f6NcNgt7o= Received: from CH2PR05CA0013.namprd05.prod.outlook.com (2603:10b6:610::26) by IA1PR12MB8079.namprd12.prod.outlook.com (2603:10b6:208:3fb::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Fri, 8 May 2026 05:18:24 +0000 Received: from CH3PEPF00000010.namprd04.prod.outlook.com (2603:10b6:610:0:cafe::5a) by CH2PR05CA0013.outlook.office365.com (2603:10b6:610::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9913.7 via Frontend Transport; Fri, 8 May 2026 05:18:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000010.mail.protection.outlook.com (10.167.244.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 05:18:24 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 8 May 2026 00:18:20 -0500 From: K Prateek Nayak To: Mario Limonciello , Huang Rui , "Rafael J. Wysocki" , Viresh Kumar , , CC: Perry Yuan , K Prateek Nayak Subject: [PATCH 1/6] cpufreq/amd-pstate: Grab "amd_pstate_driver_lock" when toggling dynamic_epp Date: Fri, 8 May 2026 05:17:43 +0000 Message-ID: <20260508051748.10484-2-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508051748.10484-1-kprateek.nayak@amd.com> References: <20260508051748.10484-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000010:EE_|IA1PR12MB8079:EE_ X-MS-Office365-Filtering-Correlation-Id: f798be31-c605-4831-dac4-08deacc13a6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700016|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: m348JwaG5h1lvJ/7rd0zaT9H07IJCmKhQT7kdi2JipUlI0Yk+a7YQGRERiDTSepJ3CO/iYEjlCJ9MxsIfUaXq53Yzx+Wnu1pHoMLxqY47y3V76VBEyP8e5r4D1qDf9NnLKddREQyenMTcGxOlFYPVbtRV0e5/61HqcpuM90K7cHoIuoWnjriAQ2lxY7B/7p9Kw1xlCHERQt/xze4fF/0uQEqISXiE/K7SPamfp4clhD2s1w3FpW4e8RLKCOs9YZ0pLRcWQ1JnTO+gwaw1yaqDOmpFqjTR1ijyJs4nXVbaR4NAtkTKTp2PqQWF6bSHnrpqU4l1ut+IyohIKLG4+eckDvaxR/b4nQ6oaZbwk9PnbNhqF3izxTp5JRA7NTuE2ovhE2qOsWVkjFSdoeiN8+pjduzh5xLU/A8KWj6R2H9h+TJT2afGV1tkYJWr8ygBPDsXoP4dMN7JmxtGLboNfxGAd/Kb4yXGa7ST+XXk2xc6vyfy8IdQL2IXKMj2Y0fsa0f9sd38EH685qFFqgHrBfkwFdTheyqzMEyowf/3+/eo+m0DeKhdhBFLs8hfKNwcOJs+gw3zmuiBwjLpjBNxWJlzff91ALsc31vgI1qnByRxnlSMr4016D6hdvRrs0EWkWUQ0O8+o+Fi8ZsLnjHDHvAXwQAtOkZf7t6p+usOXuIUwmIV50UOQFM0Q16O64LSTBktM32BmRMppFX4CkJOOtCRzoO6apiFYLMpmqIDd33Xco= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qZCeRQnggdLBbPYRqCP0A+g8kA2RhhFUW5bseySExsLG+QLIiFzq20aCPOL6QNJMUWi2xbxQyXGaIOXSjrxkJ9CglmV6FUE4Op3C5ATzH/htkv1PomwvQTrim4hwIrl69r/Rj39NGaqS6gSKKE6gxjeBx5Bh3p4rkPtiOYwFL24+L7b32HCWYIwbCbpmQI7p7lxieSy064DW7b8pzkB44immEerkaW1+a5CxahWs18XdYVrByGTTwlAAzBGhlLWq56RoUUnqZ846u9j6aR4GeEZ7cVBVbYOuyG2730tenfj13ikoim9+0Pm0hESPWDp6RbMjkBM/hbr3uEDkl+gqHTH0jwTtGwOSIEbDaEI21ZIEFG4/h0MizJtpFWCX7YvqeWQE2GgsQhrt8QhP9ANu6+c9aH91kVdtD4/Gq8mF36iZgAY8Zsbs6LeSxo8mHXWr X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 05:18:24.1448 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f798be31-c605-4831-dac4-08deacc13a6b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000010.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8079 Content-Type: text/plain; charset="utf-8" Concurrently changing driver mode and dynamic_epp with: echo passive > /sys/devices/system/cpu/amd_pstate/status& echo disable > /sys/devices/system/cpu/amd_pstate/dynamic_epp& hits the WARN_ON_ONCE() in static_key_disable_cpuslocked() and hangs the system since both sysfs writes are trying to do amd_pstate_change_driver_mode() without any synchronization. Grab the "amd_pstate_driver_lock" mutex when modifying "dynamic_epp" to prevent the two paths from racing with each other. Add a lockdep assertion for "amd_pstate_driver_lock" in amd_pstate_change_driver_mode() to formalize the dependency. Since "cppc_mode" is stable under "amd_pstate_driver_lock", only reload the driver when in "AMD_PSTATE_ACTIVE" mode and reject all writes when in passive or guided mode, or if the driver is not loaded, since only active mode operates on EPP. Fixes: e30ca6dd5345 ("cpufreq/amd-pstate: Add dynamic energy performance pr= eference") Reviewed-by: Mario Limonciello Signed-off-by: K Prateek Nayak --- drivers/cpufreq/amd-pstate.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 453084c67327f..5e2d28c73294d 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1707,6 +1707,8 @@ static int amd_pstate_change_driver_mode(int mode) { int ret; =20 + lockdep_assert_held(&amd_pstate_driver_lock); + ret =3D amd_pstate_unregister_driver(0); if (ret) return ret; @@ -1821,6 +1823,13 @@ static ssize_t dynamic_epp_store(struct device *a, s= truct device_attribute *b, if (ret) return ret; =20 + guard(mutex)(&amd_pstate_driver_lock); + + if (cppc_state !=3D AMD_PSTATE_ACTIVE) { + pr_debug("dynamic_epp can only be toggled in active mode\n"); + return -EINVAL; + } + if (dynamic_epp =3D=3D enabled) return -EINVAL; =20 --=20 2.34.1 From nobody Sat Jun 13 10:15:27 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010060.outbound.protection.outlook.com [40.93.198.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 655D72750E6; Fri, 8 May 2026 05:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217526; cv=fail; b=a8o4QT9izNri3WegZZJP1YEskte7SYTAL6hSq+fUBZBCxyINY3RXXVgUEK3guuga3zKdT95d48cfhNCX03AgvmOCc7yBc2PlFTXJOKlZUVpJjE7Ge/wj5KUYAWAp+04toOo3QLSUoqMZn7Zzgjwhj4To7mbhYs8lKmuPJSydh/w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217526; c=relaxed/simple; bh=ypoI1an7l7zqWvdnA/EKlnGWJUNvc+om8GX6CEDxfVE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NBuajfHITBatTPCJIDgFMpLkIfjl3elCzvHI6NQuBTtCvuFHVKzP8SJ4oMAaOtE1IknujGWC8tdOSpUug5aU1UN1N0S8xlkjEi+onJjH+r9QpSztGJPGYKlUNJ4WelFo9es/I3QjIndd2BUvkHVkIYUyIPXs3yJpgV+Ao/Jbss8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=JM9jGnD0; arc=fail smtp.client-ip=40.93.198.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="JM9jGnD0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wk98911TpfOPg4ukzeuyfqzOSpNUrA9vYSWGlMjMiNVTf4A/UVB9paKZm9JS9rCTMP/zWvobJFAnSoMk6jmlf3etnaLjRcsprWPegJpE50VbLeJTvHR6cFmwIakYQnUI9FhpOVgWYi5H/4MAfUz6w6VtVzinBNxKhJrZBQ06UTJAaNLurieSWi08bsMvQWNvEZSW6TLfTLOR/ab1/oXOqTnmWwrC2Z4i9Zb7Zvq8ejsLlRWh0FxS+v3KMsCvuZiC0p3Eo6/rkOMDEZ0JtNYEjDYqP0BCd2fhrvkaTto1Sidmf3QQgo95kBZXfEQi29Bygazd9ruHIxMExLiWBr4XBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iS30NqUeJkgpMIq2Tfz9buWechDzrqa7doXl7DjUd7U=; b=QLG0zJ7vB16oHLfsNeBrONe7cAxp4BNJdQinTAsTxsHwq4vEzAxZPBoOm/8lYWunFvCiTNLiJee8hzIAqSLqAGwmpB33rtqwXJ8YYocdxvIz22IDKx71Bw6wwkCRdGL3vYcYBM4EmoVMdBdqGaDwGoIatssR/8gFmrpOilQ6puINCsRzuZsC/9ScSxOnV3r+/zJfJf85JK3jrFAZXePKmTP0KNVUVRmRTuhS0M1n7pnyzco4AsVxoMLhLbsKm2OJ3eDRYXGLisJe/WdPaCnGZiDlZkfaG19F6jWaWyByCJlxjp/lqCA/u6EfaXIi7n+V450Joz8vAPJnusdjOEzDSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iS30NqUeJkgpMIq2Tfz9buWechDzrqa7doXl7DjUd7U=; b=JM9jGnD0RsEXrR3Vhu8y3GRvKQOw12UzyI9+bBEiW6+EBwjSGxzi0vupUcgkkM8WNrVnJfJWsbOHqZ5wHmnUcm02wJYQOfMrTTitHW9ydSiJWVd2XD5+HQEoOF4NSzmj4xxcdqVb/+a7dxzER5+NeFPcNM3neK67MDr0z3lJZ4E= Received: from CY5PR14CA0003.namprd14.prod.outlook.com (2603:10b6:930:2::19) by LV2PR12MB5941.namprd12.prod.outlook.com (2603:10b6:408:172::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 05:18:40 +0000 Received: from CH3PEPF00000009.namprd04.prod.outlook.com (2603:10b6:930:2:cafe::7c) by CY5PR14CA0003.outlook.office365.com (2603:10b6:930:2::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.18 via Frontend Transport; Fri, 8 May 2026 05:18:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000009.mail.protection.outlook.com (10.167.244.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 05:18:39 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 8 May 2026 00:18:36 -0500 From: K Prateek Nayak To: Mario Limonciello , Huang Rui , "Rafael J. Wysocki" , Viresh Kumar , , CC: Perry Yuan , K Prateek Nayak Subject: [PATCH 2/6] cpufreq/amd-pstate: Return -ENOMEM on failure to allocate profile_name Date: Fri, 8 May 2026 05:17:44 +0000 Message-ID: <20260508051748.10484-3-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508051748.10484-1-kprateek.nayak@amd.com> References: <20260508051748.10484-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000009:EE_|LV2PR12MB5941:EE_ X-MS-Office365-Filtering-Correlation-Id: 42bd3ba0-3981-4770-026e-08deacc14395 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700016|82310400026|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 5T21xXabEtB0OwNWv2XEAobSasUYzC9nxHYnGmvqv9XiKH1IZWJ29cUzFgOT6YWP76NdqlV5hiwkZUuPt7WDtPbTVZc3erbT1sRIW3LhD2ANAJWWHiwYqe6p8Ez7AfvvtcoHjQJqGYvONVhpAYFtk69HYBOdvxhqLg0PehDgo7Bl0EL9ZxDMo8I0tqYhIoFhnCkXuA1Qjpb7k9fQl1h61BsHikEOtkwSXkYTx0vvA+FIoBSNHzd9vSedtwf5ub0IF/Eqp1yW/wZHrYMNNFbVAp/aW8FOO59gid3RrFklDqsQS5LX7jHJ8WJbUzxUzPSV63B6ONca0RDdAeMUdW7T5mdzT46ProoPjyzP6aD0XQTS2sUtcrnG/XzksDg5xqzFcQLjLEy4x6/qNs+EEW9Hu57CxHPQPzEQ9XqSDKKt37C45bohnQVyVOPtUxZtojy5FODxW2dVIjFzHbec2nfBElcjnpeg/WxK8BgoOkORqhvEkj7zqCuN7RQBvKbZPe6Yig3STP3rT+N42t3CkTtg+W+vJJo9RRTybNsxH9ndyj608mC04o1H+Vky+XSMykgH9r7A/Hc6NC+655taDRc3DZQMy9H8dH+L3uAd0WHPqlS9ORPREgsQJ3NoKW3+ax8aHV1E9aJLznRXO1JIQw8lM6Zn1PKh9/uDfpAEMPf6iPHyUOFRYRomhp5M2LYtMuGUcESCtugdOJ9Bd6WwqEGfnkwHvdx0xH+Q76mDKKB9Lc8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700016)(82310400026)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PXq8bzl7cWPpcrqP9eaxkcFG36IdcOqhzYVSezWv5vfm/NjZOnDtoZezVZixbuigQoPbdo2ho6kisY4+MxkhY7v6jSQunvlRoUBGZSaPict1WCzgUGUPfyZeOCe3zSAnYxbKQI5MxqQQYHlakPjmxkBpV8UN/URGEooK9c31JVYNHKynIM8PoK8fAPvS98WC8VtM1qt112v6X6BkmlYrsU/j2sfHPAG+oOKrjcWILuzWum/4cob1VuVvMpx47l7Ji8VKaZbJ33lQCxsJzEY+3pgyaIb72tVnEsS6CfwYt72HBMNaS3CCtCuPX2GAI9UbTIvLQyNIuB013wMuQdhPZOI1BjrXmsS/LDglrNp83apPA5c1yjd2AdndHMZEzWfwyijhhd348mIt1Wmve80PIF21boEcidQBaZ0TpMwqNdkTQ7MWknaR646j9eKoaA2O X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 05:18:39.5398 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42bd3ba0-3981-4770-026e-08deacc14395 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000009.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5941 Content-Type: text/plain; charset="utf-8" Failure to allocate profile name will return -EINVAL from platform_profile_register() while in fact, it is a failure to allocate memory for the profile_name string. Return -ENOMEM when kasprintf() fails to allocate profile_name string. Fixes: e30ca6dd5345 ("cpufreq/amd-pstate: Add dynamic energy performance pr= eference") Reviewed-by: Mario Limonciello Signed-off-by: K Prateek Nayak --- drivers/cpufreq/amd-pstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 5e2d28c73294d..72514be2f30fb 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1291,6 +1291,8 @@ static int amd_pstate_set_dynamic_epp(struct cpufreq_= policy *policy) return ret; =20 cpudata->profile_name =3D kasprintf(GFP_KERNEL, "amd-pstate-epp-cpu%d", c= pudata->cpu); + if (!cpudata->profile_name) + return -ENOMEM; =20 cpudata->ppdev =3D platform_profile_register(get_cpu_device(policy->cpu), cpudata->profile_name, --=20 2.34.1 From nobody Sat Jun 13 10:15:27 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013027.outbound.protection.outlook.com [40.107.201.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D20AA33C195; Fri, 8 May 2026 05:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.27 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217541; cv=fail; b=LDLGMTEaFkWcBQoqJaQaOdAAVQtI/5UaVFoUEtMX+jIgjZ4nCdcMf0ulETyjbuD+USaFz2CIjjfvrX84zxOHMdQ1aZuayHjhc8OxrLqqyo0CGYmoNFa9hY7TXllfigh2JIPDlnbHfbtYIqii467s2www/v8/zFV/B75NO9AhNqY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217541; c=relaxed/simple; bh=4zqdQXHMWijf5u+2l2HJs0Hs5p+Cn2ZUwql1mhZbHRo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E3z3jWQ+81eKw7uzz9wZrXyQiAYXgCNQm+UACoLUJ3LxzGa/JPVzpyRKkw4KPNabC8cuFFUbooqGdWvnqXxrqGNu+hZmqd9r02VnPujUh2kJwMRN4XqFPj3HpjK+v9cIKA3NBr8hxRvpdrf6QXt362wVUUbqAbQKS2PHG4ZGTlI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fkJbvYwu; arc=fail smtp.client-ip=40.107.201.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fkJbvYwu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ann/bGnrkhrmgI4/A0JORnLHHxeLRN/KHhzC/9hmlAbH9WZLdKW2nwjuox+E7Wp7XpUICwb8mJBtxOrcCuorMv/daaTAVSLbQjutgsRRyWbxzs5i1ietmv3TWTn7DLmU6UlpQxFB9twP7Ho2gCeLq2yUzzKk6gLZ6j76YKAM3qM0OAoahdcGGPqgq47BwT5WfmW/+mlTlBI7naU9EntelGb0gjSvyV+ux9stN3A4bW5HOWmnSxKOQ0mOjgLVuz7i7Yqd+DnhHf+1WxSUuWlFOJYLz/uRtFtZI5JXE3aoyu65GmfepCrA46f5qHiqcUKwDM77V50vDiYOvnJ35mkHbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pqpYsqAS6dPcuJ9s11SwEkE8/O5Gs/3V1Wc8SIFwEGI=; b=xdqYvH6i5RRZ9KSwBo5DDyVrH36A3d07lJHXrabZz0MR1yNNz0dMRezCXmdSpLGI1nYSzBCOwd6vGc0g+TosXG3/ZFu2P9kyE6XzMERrNEQE3JVmkf/+KHuNwDXyjhsOpbS1r0X8mvFu6ht3MmMd49DDW+DvSVJb/OS+eRiN3hpiZW5k3h4+vNHZer7DGCD5K7qCU4QKl2swUWTwVh+1tdHgTeccDPKunrLvBGW4dVgmImk5hpCSPp1aj/CGsQMXIHgZQhssIDXWDw9AhSMysXlZXBGdkE0nWvVE6LYino9nr0zO5EKOgGXaKgm4VNzCFLHjytzFSnlTwiyZK0Rj0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pqpYsqAS6dPcuJ9s11SwEkE8/O5Gs/3V1Wc8SIFwEGI=; b=fkJbvYwuniaDGLEV8VuWOSYfq+ICdF6NuiFI4DeU6mrsp2YIqRJXId+0yMPC9PGWAwejgPEl0KI3iA2yJ/zhJn3APwFZEI+K87aCgM/4LBB8MTTGIkEUSf/TkdF+ngTOV0K1XNFCDXIfYzFhwhLDNYAhvpudYO5QVhk/P1WsrYU= Received: from CYZPR20CA0020.namprd20.prod.outlook.com (2603:10b6:930:a2::25) by SJ2PR12MB9163.namprd12.prod.outlook.com (2603:10b6:a03:559::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.16; Fri, 8 May 2026 05:18:55 +0000 Received: from CH3PEPF0000000E.namprd04.prod.outlook.com (2603:10b6:930:a2:cafe::97) by CYZPR20CA0020.outlook.office365.com (2603:10b6:930:a2::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.19 via Frontend Transport; Fri, 8 May 2026 05:18:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF0000000E.mail.protection.outlook.com (10.167.244.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 05:18:55 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 8 May 2026 00:18:52 -0500 From: K Prateek Nayak To: Mario Limonciello , Huang Rui , "Rafael J. Wysocki" , Viresh Kumar , , CC: Perry Yuan , K Prateek Nayak Subject: [PATCH 3/6] cpufreq/amd-pstate: Allow writes to dynamic_epp when state isn't modified Date: Fri, 8 May 2026 05:17:45 +0000 Message-ID: <20260508051748.10484-4-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508051748.10484-1-kprateek.nayak@amd.com> References: <20260508051748.10484-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000E:EE_|SJ2PR12MB9163:EE_ X-MS-Office365-Filtering-Correlation-Id: d05ffd4b-0b28-4264-87b8-08deacc14d18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: QnEwygY590gLeXLjRPvMJSJ9nwx/hVwpQcPPXReRHyd/aNoD2JQnvYYYpbD+EsYtgv/I793FZtraoevdIdFsgbyTfGrxvxHeb9FIq4SJw3YxOPWjvqCL8cNw34YfqO7VwF9dAYupHbMO+Wt17IjtZwOXldzypDROFDHKPQNAcUPs7xn6utD05mO4rigAsxqhbTGbziLV7Sp3stSQ2ZLWa5cIJF1M4N0H41HEtrySBBAdxSrtXzFz5Rhas7/HVrE/vr9wz/SNs/dA+N/2aovNxy2/UBH+ZATaA0e1g8qrxe8bHyDywFhAp4/DiVFkNFga4rMoSR90hIhNUfkEqvBCdPAfirDDPLWGMLiD57kzVCVi/0dYirZgioeyPPnMXetPTE73Aaal4/1dtrkZpFSn+bX//lhxzDffQXYm6Vlf7eZ7/NvYxvngjKaEESr7iFsZ1oABpEuvfg0gcft7oT+xHb5fore0OqKb7/AEXat3aLYGfTDFBUtUZvtfYgeTLt/QGl2eZHMJBmgGpVzTWiCVJsULRhrOTSTWuUcugfSRcLsfyouXHZot1XzZXA2nvJnH6/O/tfJP04v9xMJWH+nInaARsyPjgFjlfVitR7dJZG41+TaAq694qwOj3l/jQjF4Z/dJEP0ZIgGSpiQ7/p6CIl5hFXIjqlyLEea7GcjrVlZrd547+cek2yTxMrYwLVd28xBgQLCh/kLVfw6QZXhJ7kjVI2wCLkBMRbgu+gK3tMI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: t0dljC6UZXG8kroon9U/PkKOJa360xZNYeiQW7QtPE+xwvxSstKDLhYmW+NcEuohL/KWvhAWsgj5htjamN18n5TZqnez++UKhnQwjQnpk5mf3wlrkuPZ3J/XYX5MQeASGwMFueVVboNRtDihdjEqi8JKTAtb/NluYRqEZF4rqgapK5J3kbuWZ1+t7BFy0MRoZNe5jyO+ajAISOs9G48vO2s2zD/LuKabYTQc77CCYBhgg6TK9xxERyIDqRgMyERefnpNwSqbBPV4jUJtXpqhQVfwyoJtbcGAI0x0tSk/Y7I5JehpDBUW1Ys6HgsGhNe6bQJcrXu0VpHbDqNRWboXGdmmvsjGjp0jkJeZs/jZiZ+l/bvwqkklFHn557cMgqAt/su+lwDtgS+JFmhZrYhkPQaTvfzzobmmRcutP35L5EtlWCoQ2/F2FSC3MGjZwr5j X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 05:18:55.4779 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d05ffd4b-0b28-4264-87b8-08deacc14d18 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9163 Content-Type: text/plain; charset="utf-8" Writing the current "dynamic_epp" state to sysfs fails with -EINVAL even though the desired result was achieved. Allow writes to "dynamic_epp" that does not modify the state. Fixes: e30ca6dd5345 ("cpufreq/amd-pstate: Add dynamic energy performance pr= eference") Reviewed-by: Mario Limonciello Signed-off-by: K Prateek Nayak --- drivers/cpufreq/amd-pstate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 72514be2f30fb..462ddad7bc79e 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1832,8 +1832,9 @@ static ssize_t dynamic_epp_store(struct device *a, st= ruct device_attribute *b, return -EINVAL; } =20 + /* Nothing to do */ if (dynamic_epp =3D=3D enabled) - return -EINVAL; + return count; =20 /* reinitialize with desired dynamic EPP value */ dynamic_epp =3D enabled; --=20 2.34.1 From nobody Sat Jun 13 10:15:27 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012041.outbound.protection.outlook.com [52.101.53.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62B4B2A1B2; Fri, 8 May 2026 05:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217557; cv=fail; b=L/XntW6L4suW7EP2WkQ19WC37BP2NqZ/z0ldYvbL3tcQ+G6s5oCaR4Sy5KdRlbwgOUYQcsbdt9oXCGKFC/9+nwWme2Q7DKdp0Ex797kTHDwe/Q+RAB1NQbP9MCIxzKIs+lbtfVOlfi1MU2jzF9WcrModrXSZ46D2UZRNPlTSQO8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217557; c=relaxed/simple; bh=IfWYOPhF13KCaXy4W5U0JpRIZbruzfoDR1ZpIk4O0is=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TsjtpiF5oMQi6u2wVB9Tla+T3Y0AG0IHntF84GKpnkgy6vtc7eW6lJLrAXQHXxZ2a1+9QLPgGw7YopbKeaKXIxjkdFjv2yz26gyi8XEP3rKtr0lByYI2olS68B2Ay05uFGVJ9Cfumml0iP0ld4jwC3/qntkau0KmVbUBEmHQ+6I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=4N7DZBG6; arc=fail smtp.client-ip=52.101.53.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="4N7DZBG6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I7UwKQh7zr8aK8AFXdKJHPoc5ZKBmVhJeCQ2p2LCMgVMzFA5Rkh0LtdnIUpRCD4nW2Q5EVnjk2nB/fhnMbThcAS72QpO1fHQ8mX0iMhC4WHNrYesZ22NnDrzqU1fGLEZOnMxetqzq9xzgsO3AflYlAkpdxh/q9NFCy/r+AlDt1UNlJel5h9BiJdf6Qrjo8acnDElmieK+nG5nAeeHjXihofoxPtQOq34SNqf+ZwW7iQ6siih23OGDucoFPU6wsDU316+lxpXcamxeR07xE9v1UD8Ae+0VpSDFMBtVOlO9gXKj52PGWbhepgoxdsxZdc0AGqGtuoVnBnVRwGE41AD5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A2mqTcCkeYQmBOsqdj1tN6LmOO9HAi4Tt8DDBCTRPxU=; b=eKDR/1xAV/NsRQpGaLlxpi+cuhnvliDoMG9qdWLwg9YZ4Ikj8qdyzlEGhYFEVaNBCbC9AaNNl/tuYEy4V9DsVASyGFF6nB8ws24CVNNLAgCDh4IFNTgR/a6g0X2lqgHIC1Au9vmyJSHzSeYZ+A67Qth45cxtyqZRVIylX10CgZat+TRhNSEf/1emlczUBmfX9+ShykLshFv729A4NXNFI8vV4RBLvHSja2lInHtXyqpDIEiRcB88qmwrQWe+1atye31RbfAMu+KNHZkdS6wr8k0OKb+yfficTzKFbbDFNQyGF+eq5FC7bBr7292cqXM5YilLYDQih1VF7IB6ZaPm3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2mqTcCkeYQmBOsqdj1tN6LmOO9HAi4Tt8DDBCTRPxU=; b=4N7DZBG6I8MMPzpYau/QAMP6iTF2KLEg6U0wPViqx0o83qDa96lBrBDc6EoM8hm/xZpZolskcRuLKhzKA62MfAlboiMMu6jMYXAzfbc7XfH4UReX83muJK8BN+0Jm6V1jerOmRyjBUfdKY62Q3T2iglWYi12OxH6bcbFWP2EuhI= Received: from CH5PR03CA0004.namprd03.prod.outlook.com (2603:10b6:610:1f1::6) by BY5PR12MB4244.namprd12.prod.outlook.com (2603:10b6:a03:204::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.19; Fri, 8 May 2026 05:19:11 +0000 Received: from CH3PEPF0000000D.namprd04.prod.outlook.com (2603:10b6:610:1f1:cafe::69) by CH5PR03CA0004.outlook.office365.com (2603:10b6:610:1f1::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.19 via Frontend Transport; Fri, 8 May 2026 05:19:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF0000000D.mail.protection.outlook.com (10.167.244.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 05:19:11 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 8 May 2026 00:19:08 -0500 From: K Prateek Nayak To: Mario Limonciello , Huang Rui , "Rafael J. Wysocki" , Viresh Kumar , , CC: Perry Yuan , K Prateek Nayak Subject: [PATCH 4/6] cpufreq/amd-pstate: Reorder notifier unregistration and floor perf reset Date: Fri, 8 May 2026 05:17:46 +0000 Message-ID: <20260508051748.10484-5-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508051748.10484-1-kprateek.nayak@amd.com> References: <20260508051748.10484-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000D:EE_|BY5PR12MB4244:EE_ X-MS-Office365-Filtering-Correlation-Id: 494ca1d3-6988-4f46-26b7-08deacc1569c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|376014|1800799024|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: Vnp5tM5iWOm8c9B0ydNMGpPI3IdpdtatodKqozhtDIXB0T9MTsmIc1KT2tEmTHJ7KfyO1OyAh0NRyuaA7yYpmzH9BQXPx/uijnVg5RkUrSjkG0ykKPAlYoTR2VrtCMDGEghPg5gcpq8NVpDmBUUyQj1SlpGPJmX3LU+mP2xvb/jgcR6VV0BhjOOguAZSd//SruWzfv5Za8T43vBywSnua1RyNKhI++j4EgUSC0vuQdn/amZwbg8WxZOQe86pftIihqYmtA2Qran7juDt4gvCxvDtMG17d6UpIaCNewE5JaOPsx8mKNq5XuycFc5PLiU2SC6MlR0W6jZyiArsASaV5AAJ9GpgOfqu5KdmLPTJx7os9/wp7eCFA3WyelNEqKjBK6VFXtaNBbPemVEJWYZGaMXjSRPgFMQ1TMn7O4tDZOT26Cee0v5cQ9mBmGK26AP2g8r6eJ3ORZFDDc9ctEuWHmYr0UbqEAF832ddUrmM1Iw2BaQ+FjvThPr5uB1iC1zvfYKfm9WdKHtW8+rluagbNUqov+zu4AW3uL3J/x07rcEq4vFktZrY0XASWsP01G2XuyohxbXiWWnhSQaubL5yJmofN4YC3qzaWcMsnOAMmALjxX8nuJLf5xOsd9YudjjMC/11spwjityYyavFBaXsSU5G9s1AxdoGwlbkvayHyDRixuZiwBkmMUwZKnzU6tdE/O7bXUCtJlGUFHxZtaEyulBUlmclHupPk5BtzfTThnE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(376014)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xW8lMhPxETE83AzWM9wr1dMUX1EQiDxBklYP7gyeDhmIn7A7OboGmjL4ywY3BV6BMDsX+Rxhk9roXZCX3FxzBebelNKoL2cAZXHtMVZnjKr4fTqf+U8g1CMNn3M0nO3x6ZeXCroVv4emrgNYunSajxRaP8uE8xD2AKmOA1TmfBWkx8jaeri8hdh24fOsxSr7g1i8vBZg/5aUwvJoNkbJ3eJ/wWRMcqjuVDBEVkrcI6EUhJfx0za6bqbURlyMk/3F4ik5IpN9Xw4ouN0cg1V5lHBwWpAvd8gfjSmtgext+qXGTdBto9UbGyr5zx9mgjrSBPoJXFsf+nrDzSNhulvWVdRsGfYkNv6g3ZLso7E+XBzlHpqnm7ayFhVCLG8OasOC/vYGIbb6YDFS8PG1QvTFr+En5n/+eTfnfDUq+z5JDOmfvdq9oLSQUnvmtOHvCYzc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 05:19:11.4391 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 494ca1d3-6988-4f46-26b7-08deacc1569c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4244 Content-Type: text/plain; charset="utf-8" An active power supply notifier can race with amd_pstate_epp_cpu_exit() trying to reset the floor perf and can overwrite the floor perf set in MSR_AMD_CPPC_REQ. Unregister the notifier before setting the floor perf to prevent the rare race. Fixes: e30ca6dd5345 ("cpufreq/amd-pstate: Add dynamic energy performance pr= eference") Reviewed-by: Mario Limonciello Signed-off-by: K Prateek Nayak --- drivers/cpufreq/amd-pstate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 462ddad7bc79e..175925762a93c 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1982,12 +1982,13 @@ static void amd_pstate_epp_cpu_exit(struct cpufreq_= policy *policy) if (cpudata) { union perf_cached perf =3D READ_ONCE(cpudata->perf); =20 + if (cpudata->dynamic_epp) + amd_pstate_clear_dynamic_epp(policy); + /* Reset CPPC_REQ MSR to the BIOS value */ amd_pstate_update_perf(policy, perf.bios_min_perf, 0U, 0U, 0U, false); amd_pstate_set_floor_perf(policy, cpudata->bios_floor_perf); =20 - if (cpudata->dynamic_epp) - amd_pstate_clear_dynamic_epp(policy); kfree(cpudata); policy->driver_data =3D NULL; } --=20 2.34.1 From nobody Sat Jun 13 10:15:27 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011054.outbound.protection.outlook.com [52.101.57.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 355A33264F2; Fri, 8 May 2026 05:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217573; cv=fail; b=KG7c3xT2OJrEpwqwef0ODgX4gNFjTgAEnWQ1CsRQGUxzbzJh/LMzFS2C0M0MhMIN6fJlaww2IS+piWrFQNhP0AL5lAshHsWMWsOpZRapToS8oA79LrNHf2tS6Tf/HpqwL8Oot06WXAfeStG0TNDSRqYW2nStrVeIupFnzX6eCtg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217573; c=relaxed/simple; bh=4dxRSuQK05T4suWPQbAfTI/j3pJJ/pPYbOQ15DK00bQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FQqTzyRQ+9dzAFH0yc1cxgSOWLS37EbDPkdvDgGk7OCgUmnVvQrqp5srKyrCP2JxzqeBsRPcJRL0wSevHrMg+qhYAk56B8GY2IacZHJ8DX7TChwYVauEpSNmzVM4dW7bz8CwcgXJljEVZAhIU/eNyMEkQEhn+TYkQmJeKxEq7OE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=olyLZfun; arc=fail smtp.client-ip=52.101.57.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="olyLZfun" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wb4bSVXcg5TLpXsDGZk8Az++3CpYO86t7sF63lB5BI72P/YLxmwWb7OZszG2gTwFfb54QGlzWNRFB28uEtiqscwk0iPi9XS3EYS6ONLpS1Y1m39/bVql9P7uOCsCjycSnb3z9FZJ/KNyD9aYOqUZ0u+C/h06XPF4ciNokfAsLvWr7VrrGC/46Hs1ALMHq9aMuML3aWJN+bRIzI2nQuIj1U5VzHpp/R8BeX6lqXLmiGuLguHyCQYFjo9sYygemEJbmGG92AEP7Nt5BWSuxYMibLxHLYwzFKgbZ9kUzVmzMF7KLliGM6zA5lyUjLTBPWrkTUy8y0Hre8CttV6BJdZUVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0jOU7Yvynf67M5csXD4P91qfZXsJldoJf6vW0JAWLjM=; b=OtJhKhMkljyCuc70HlG/V+1mcXetrjxdR6ccI8Iq0AIJfQdGTAdwRzhNwOywsHG1FRBWXhAPSGo5VkWra9KVZHWUMyJpw4y9djY4Nroo57weeFVDFQd2rkC7L09bjGxmPmM3I9vehrjlzZHMMYpjEXc+c68jF7WKSyCtg5kVDKsQ+BABHdjf6q7QEaKfe/IJKqj0iGE9tU6PD1krrHvnW0F4u0BO6V3UzxB7Pna4NuQBDhZSGyC3xw+FdK1d8+Go9+a67OnJEyf1+qUg5DbVMS/vJwLRqLMTQp3AQ+Es0oSqxbH9W885q3Tc20zlRV45XdIS+KVJ0nZAY5Hj+7na7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0jOU7Yvynf67M5csXD4P91qfZXsJldoJf6vW0JAWLjM=; b=olyLZfunG6yel0dusprzdOLHc0zl218JzmQrAsd5xXsUGq6Vdspcq8rDd8HEQCVSyfxTD7JGIQqbSOJyaI+3pbDMcq8Vlh6wN3M2ev623+C3MLsO3jzxUV85Fb2yxzset2coKMfmzx82YBKhwji3LUeIeFp1+tVAlrlKbEwxWBY= Received: from CY5PR14CA0009.namprd14.prod.outlook.com (2603:10b6:930:2::31) by SJ5PPF3487F9737.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::990) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Fri, 8 May 2026 05:19:27 +0000 Received: from CH3PEPF00000009.namprd04.prod.outlook.com (2603:10b6:930:2:cafe::65) by CY5PR14CA0009.outlook.office365.com (2603:10b6:930:2::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.18 via Frontend Transport; Fri, 8 May 2026 05:19:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000009.mail.protection.outlook.com (10.167.244.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 05:19:27 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 8 May 2026 00:19:24 -0500 From: K Prateek Nayak To: Mario Limonciello , Huang Rui , "Rafael J. Wysocki" , Viresh Kumar , , CC: Perry Yuan , K Prateek Nayak Subject: [PATCH 5/6] cpufreq/amd-pstate: Use "epp_default_dc" as default when dynamic_epp is disabled Date: Fri, 8 May 2026 05:17:47 +0000 Message-ID: <20260508051748.10484-6-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508051748.10484-1-kprateek.nayak@amd.com> References: <20260508051748.10484-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000009:EE_|SJ5PPF3487F9737:EE_ X-MS-Office365-Filtering-Correlation-Id: 649cc8ed-0ca3-42ba-2921-08deacc1600b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700016|82310400026|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: uAnWDqfGCzUy325VyHzKNKLynLbQ+E00wESGE/MnUfCUMRPreq05R4xES//R4/Xw8MONSILk/+94o1F/bbs4+WjOKoj2RlFfTYh0g0IYuuS2V59rzarnrQD2HKr+V13+mIzkAmDhtNAw6hEQ9ONkZWIpopMD6E41oCrwl71W2eKNii/JY6tjtwhIorBItDNzp28ABKB/LByH0WO5h61JY/IN4T1PPp99Hmfic1bA3+g4WV2jmwvLdWho5D57fGRN2CCgK3Gxw47mjOmwDKCkJx8EOLfv485avOq76mYJjCpWdNrE2rJuvfSs2svjCQVMMvTG6rfq9fR09YQtODNJUrxCsKHUhDu2N2BWJwL4csFQvDaTkQaDhENqIO+tdzvEblIbkZl5IkfY0fibm/JKQrFkKAbGGgp6ZTcKWyUF2iHWsRcXBHhgY8oBVpRkJIh+QUIRdSLSGlkk2Lihh2r7bdDBQJlXiHMD/7BD1z+2MVLv8eYl3aHmPeDksAytX00Vhq9asR3LfLl+sOz4N5uAhJ/yryRZShy2XomybUnqAd212imIbDn7oNjyrxwCb2vcdcmNoulcDR4AutyIPsywK0pt/nxrlJgVZ92F1MecrNNN7Lu77sRvUXP+Zcih8fIqusMrpPe2ePKeYajfTPAsdI65ybMC4ssUy4bp4FlArYZ8FuiIMLKZtsI5EQwqTTWmOnY40tjoReYB9Pz7SXw7nob3juKvR8uaeTG3oWVYXog= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700016)(82310400026)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NiEEJFWSrgbNj7J7gtRZfXEwzGeJ9x6UhhgNrLpw9q+iriksVLCms6PY1UswQBcS6cmbTUKxbBHFz+8bxsnG6+41z7Y+VUbnuzAd0ytOGO30X8SGqnqWRInUAuFh5ptZ1S2AySSe+xQbhTcTonEhPC7pTZqeRJg6dhz2TGT7FtV4Dki7cYK00nDkQnkAWKWoW73woHD80aPaEMr2NkcKJfpg6dSkROavaF+YAxvA4oC/VSDhRbUutX3EJAIxDDyhcBPZGl8gg6pStvQghngxnBbCiudoC18zKv24QAMchBXEUQvmm6mUmAQ9SI3ZUrDtR/3ih2xCokQKYJ3NNLSnbTjjUKhRav/FELlvYu6MTri/f0iFTMYopjrUHsQK7wS53suJy/ovpeQnwfAiqmnkGu2m2A8MJmmuYNdiAZyKxqgv7grn6gkdBZ+01uhCtPp3 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 05:19:27.2658 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 649cc8ed-0ca3-42ba-2921-08deacc1600b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000009.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF3487F9737 Content-Type: text/plain; charset="utf-8" If "dynamic_epp" is disabled, the driver initialization and the default EPP selection from sysfs currently sets the EPP based on the power supply state of the system at that time but there is no power supply callbacks registered to toggle it when the power supply state changes. This can lead to faster battery drain on platforms that start off while being plugged to the wall but later move to battery power since the EPP stays at AMD_CPPC_EPP_PERFORMANCE. Use "epp_default_dc" as the default EPP selection when dynamic_epp is disabled, restoring older behavior. On servers, this defaults to AMD_CPPC_EPP_PERFORMANCE and on other platforms, it defaults to AMD_CPPC_EPP_BALANCE_PERFORMANCE. Fixes: e30ca6dd5345 ("cpufreq/amd-pstate: Add dynamic energy performance pr= eference") Reviewed-by: Mario Limonciello Signed-off-by: K Prateek Nayak --- drivers/cpufreq/amd-pstate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 175925762a93c..9eb9c3f4e809a 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1429,7 +1429,7 @@ ssize_t store_energy_performance_preference(struct cp= ufreq_policy *policy, if (ret) epp =3D epp_values[ret]; else - epp =3D amd_pstate_get_balanced_epp(policy); + epp =3D cpudata->epp_default_dc; } =20 if (cpudata->policy =3D=3D CPUFREQ_POLICY_PERFORMANCE) { @@ -1954,7 +1954,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_pol= icy *policy) if (dynamic_epp) ret =3D amd_pstate_set_dynamic_epp(policy); else - ret =3D amd_pstate_set_epp(policy, amd_pstate_get_balanced_epp(policy)); + ret =3D amd_pstate_set_epp(policy, cpudata->epp_default_dc); if (ret) goto free_cpudata1; =20 --=20 2.34.1 From nobody Sat Jun 13 10:15:27 2026 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011068.outbound.protection.outlook.com [52.101.62.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CA0633C183; Fri, 8 May 2026 05:19:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217590; cv=fail; b=OkHreki5cpxikLVe05e3k8Kqzy/IQ9XI9yghz0RPxbzLUrMDNtt8zF0g9yuFzwF6QYXpBiArCKJWhVCNIqr+QXvOjVLgZrF0menUqerhPaBTR+prM5zx2HF24Xh2DpEbdB9M7jbl6VnoEAripd1tlFfNnhTAhdsO/dKHxKydosw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778217590; c=relaxed/simple; bh=dJIqznGqM+gnMXuVyyzrX7QS0qb+/J4ly8x3ec1JWKY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LbmeBDyqPbhv8ej2Ke7MBJd3ZvgVhUzWFG3jBq/ZdWyJJAVMNt25WwfJSWi4apnn7x/zD2hSA6Lm5eOzr600Sj1ZTSelPppgvJoNLQaQ7Cx5CmrgiyZiBoEV7sD88mlz7a4+5T+o9vDXmCeDIqx+rid5oOE8DAMdvVJDxXbhZ2c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=JRXgB++K; arc=fail smtp.client-ip=52.101.62.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="JRXgB++K" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WM0qR5p1BuSmreT75iVn+V+BPERucpvak6JC2xldnkCxWoHQczyiNlVKeMUydw8WBLIJQwfzOpJqwKj/aO8HL+b9wd5L2QHR301ZkSUoXiHzPi7H2/PhzD8vV8CWPn0XrWoxfZAsOqjt2UoSRSCT30jTqs8aLwy0eVhh0M2GtD8zMOlio7E7WmRLq4//GShPJ+jt+0ybWk9QpDbGooTBVHfZPYR20Je6nBKsjJBE2AqvUc/DeBL+T9n8jBP+UxxvGKv6ygEU8hwNpt+Bavn63W60x00PhHW9ISz3oomBDpKME2zNqiar6k9KPKjBGizPhoCaODSIcWjnj/ZQa7SVSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9DNirSYPs3x1/vkTRnXBI7ucNRIpJXmG4BdUNqHklds=; b=qc6G4SCziBtR7EaPchrDeHglHN0IlPf7fQRxhBJLDP4v6ydMHvMozz1l73SKXM5lc6079m0ZI1Oz5G49gGaDE2xBpKcslCeLzWoQLgX2WCdOTdENxoa09A0Dm9GlIrTWyFcma4yvXQ/FW97J8PFVuh3uCaz8CWKrs7t9wAt6wCgEkEu/mWFgM3yhdwGvG2dcjZZYveSn6IXYKyg1CJk0sI50jVL/7/YxlEtF9ujUGZFPo2Xt5/hEGigBLqK1etpuYKaRIrgyecwIXubTSqG0KbcmBoP6snZh1nh9uB5kN0dj7zB1kHLNROLepog9ENruF0zYExtzmg2QZIHHV4Dxjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9DNirSYPs3x1/vkTRnXBI7ucNRIpJXmG4BdUNqHklds=; b=JRXgB++K6UFGAeC2nlFsfvY5Y6UUnrc6enHg5/v2YEFlYAYXcmdJ/FzI3pBLP609+Xpbv+ZPBDkqsxjuAlNJGfCCrLjuX8e9vVq1gDkfTZU+EGnDwK8IxSy505gJMxLCGwPaHxK2z6D3aJrKI5qVYKc/Cdp1Il9HYkK/dN9RSd4= Received: from CH2PR05CA0006.namprd05.prod.outlook.com (2603:10b6:610::19) by CY8PR12MB7585.namprd12.prod.outlook.com (2603:10b6:930:98::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.18; Fri, 8 May 2026 05:19:44 +0000 Received: from CH3PEPF00000010.namprd04.prod.outlook.com (2603:10b6:610:0:cafe::aa) by CH2PR05CA0006.outlook.office365.com (2603:10b6:610::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9913.7 via Frontend Transport; Fri, 8 May 2026 05:19:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000010.mail.protection.outlook.com (10.167.244.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Fri, 8 May 2026 05:19:44 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 8 May 2026 00:19:40 -0500 From: K Prateek Nayak To: Mario Limonciello , Huang Rui , "Rafael J. Wysocki" , Viresh Kumar , , CC: Perry Yuan , K Prateek Nayak , Kalpana Shetty Subject: [PATCH 6/6] cpufreq/amd-pstate-ut: Drop policy reference before driver switch Date: Fri, 8 May 2026 05:17:48 +0000 Message-ID: <20260508051748.10484-7-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508051748.10484-1-kprateek.nayak@amd.com> References: <20260508051748.10484-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000010:EE_|CY8PR12MB7585:EE_ X-MS-Office365-Filtering-Correlation-Id: 503d21f9-59e4-4f98-1fda-08deacc16a05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|376014|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: q5u40o56zzNH3shddhYASpfRUr6cMvhWCABx0es3l7yz5ku8vf+NPiIH3JQ1C0oAcUvGDuib9AyxeqvY6yWBxQSmApiPlfIQCrCNPrS9qe5rXCgMM9+GssvolWAtelw82ZkUcY2aYDQNNMIX7Djcnr+soM6LHws4m+7RmI9OTZTpDNaU+WsDSX1ldc3TiNBKjHz/L8D7jTskTxMd0VUr2GmIMvb7FomFoPwecuY3rVZl57mR0skZWXEjqFB5Gl/PbTNbCKTGR7/v5h62M9lZ206OfQCoKW9R/bDghFRfy6PVVErA9q55l0qKYgCOa7nde0TYrg6JmaM9sKBZe+tEKkTxw9YdkMWSw8fm8hYMczIg0b88RVduT66WcQ0qL6bECTwxdngcQ9vXNX3wNmaJc3G6I5cHPpBJRxzpDk/n9u8Qp3fOQznmpdgafbz6WrsuvHVu7RMBdz56VM2G1c/mAtZDxlhzQwLwq5BZ79avWN+CLImFsOhONCZ8E5wbHXoxUWw1ikqv6z+f6ctRu0QH1dR5DTcuPd/yNi/8kG3OpB2zhIE9SiYLQ3HqktnESEi1elPIUgdwtKkzDYUWz5IcCdU7TjaCffa5bbJwbSu2apOwhY1ce3jakyju0QxCTJtfMr+fkD92HvWi7BdaxobH1HPfpg6JaZ8EEgXEjIamCYG9WfbjFg6WMA/yNEXzwyeo+TWp6hIUS5XvTt5y2apMxSnUAFT82w5KE2f7F7iqX4g= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(376014)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3tQ++UxKrTPIJOtO9J5S/E9SF1HVz7tcZt8cAyqvJfjgpwdPUI+2yruLO9enEdYs53zOfBFRS4EMWnE4fjcVDF0Ci8JnQFXLIPleDutsnc10yZIIlMICsoP75OH/7RntlG8mx/3YIkYiz2qsUVjlMUgmBf6ZqBnO+BzX/P36Rnc2fFYHjTQa/6kZo+EBpVd6QjZmtQsyOEOTW0tadP+hBEJ/DkBydJIuevHTaY070LxScrLDDw/L3SfL0dkcyYBCevDQot2lYYMqv3KGalnHPOoH3XvQH+fUwCRJMfQpqRfAC7Ic8eMnQ6mNUoiTx7GqLaYskSAsO75rR7IXATiRGbBZP9dQZoC+IDyKuefMRKA+qO1aKHkG3IBnqrkDIvAAyA8/m7rQ6Q67JogPgfvQQzBMuj8RL11il5fEPCugBZH+w8fSJmGRZkFLKiGwlFZR X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2026 05:19:44.0300 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 503d21f9-59e4-4f98-1fda-08deacc16a05 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000010.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7585 Content-Type: text/plain; charset="utf-8" Recent changes to the EPP unit test tries to perform a driver switch with a cpufreq_policy reference held when the driver is loaded into anything but the active mode which leads to a circular dependency and the unit test hanging indefinitely. Drop the reference before driver switch and grab it back once the driver mode is stabilized for the test. The EPP writes are only possible with CPUFREQ_POLICY_POWERSAVE policy. Temporarily switch the cpudata->policy (while holding the write end of the policy->rwsem) to CPUFREQ_POLICY_POWERSAVE and restore the original policy once tests are done. To ensure the final EPP is correct in case the driver started with CPUFREQ_POLICY_PERFORMANCE, EPP performance is tested last. The __free() based cleanup for cpufreq_policy is lost in the process. Reported-by: Kalpana Shetty Fixes: 7e173bc310d2b ("cpufreq/amd-pstate-ut: Add a unit test for raw EPP") Reviewed-by: Mario Limonciello Signed-off-by: K Prateek Nayak --- drivers/cpufreq/amd-pstate-ut.c | 36 ++++++++++++++++++++++++++------- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-u= t.c index aa8a464fab47a..13a23dac477d1 100644 --- a/drivers/cpufreq/amd-pstate-ut.c +++ b/drivers/cpufreq/amd-pstate-ut.c @@ -274,20 +274,21 @@ static int amd_pstate_set_mode(enum amd_pstate_mode m= ode) =20 static int amd_pstate_ut_epp(u32 index) { - struct cpufreq_policy *policy __free(put_cpufreq_policy) =3D NULL; - char *buf __free(cleanup_page) =3D NULL; static const char * const epp_strings[] =3D { - "performance", - "balance_performance", - "balance_power", "power", + "balance_power", + "balance_performance", + "performance", }; - struct amd_cpudata *cpudata; + char *buf __free(cleanup_page) =3D NULL; + struct cpufreq_policy *policy =3D NULL; enum amd_pstate_mode orig_mode; + struct amd_cpudata *cpudata; + unsigned long orig_policy; bool orig_dynamic_epp; int ret, cpu =3D 0; - int i; u16 epp; + int i; =20 policy =3D cpufreq_cpu_get(cpu); if (!policy) @@ -297,6 +298,10 @@ static int amd_pstate_ut_epp(u32 index) orig_mode =3D amd_pstate_get_status(); orig_dynamic_epp =3D cpudata->dynamic_epp; =20 + /* Drop reference before potential driver change. */ + cpufreq_cpu_put(policy); + policy =3D NULL; + /* disable dynamic EPP before running test */ if (cpudata->dynamic_epp) { pr_debug("Dynamic EPP is enabled, disabling it\n"); @@ -311,6 +316,17 @@ static int amd_pstate_ut_epp(u32 index) if (ret) goto out; =20 + policy =3D cpufreq_cpu_get(cpu); + if (!policy) { + ret =3D -ENODEV; + goto out; + } + + down_write(&policy->rwsem); + cpudata =3D policy->driver_data; + orig_policy =3D cpudata->policy; + cpudata->policy =3D CPUFREQ_POLICY_POWERSAVE; + for (epp =3D 0; epp <=3D U8_MAX; epp++) { u8 val; =20 @@ -358,6 +374,12 @@ static int amd_pstate_ut_epp(u32 index) ret =3D 0; =20 out: + if (policy) { + cpudata->policy =3D orig_policy; + up_write(&policy->rwsem); + cpufreq_cpu_put(policy); + } + if (orig_dynamic_epp) { int ret2; =20 --=20 2.34.1