From nobody Sat May 30 12:36:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17F4436AB7B for ; Fri, 8 May 2026 05:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778219178; cv=none; b=r377W8uNokKJ55B8p0M78TZjDsVBhLAF5/A48ImX51uaQBprL3h8qpjmg/7FCQ4bGiYAgz2BU3r9Unht5ol9ZTSqQ3jZe2mXyR4KjUyABmirLtHwU2HBAWv3xUUJQ9L6c9fjWEdMWDME3R7GUaC+b/qUGxMmg2nEfnAV1rWdH4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778219178; c=relaxed/simple; bh=tUI+fbM9hZlLRW7XpYtSlSf8sGpkz4jhK/VKV3GOiO0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=UK09ayFCclikpPpFf7y/+pha1N0TltJ2SN7LxFTZIlCzIBjqoTV7a0RRgX1nef4PdkruT6y9g1wWCiU13mV/9yOeegpci5WTbW7ERn6fs/VB8FXbti3jfL3LVS/1rz/fjjSjo816i1/LatnxGqzuNmLz5/TgpBfO5GWUhR214hU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jyE2222E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LsEAM3LX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jyE2222E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LsEAM3LX" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6484xB0B2532163 for ; Fri, 8 May 2026 05:45:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=RvST/I7tIUlGh9vWEp+EZm +Dpv+zO8gesAQ4YHqr+Kg=; b=jyE2222EXWlRJbH/emPHEZoVrhOal3NX/f0xtj xoR1+gNbE9HYiAiVjGi8SG+v+pBNFkpmRceSVdUNVx7kcs44d+d6Rf6s5l8MrB3y 1FeMWTdxZzF2KR7CZRGreOUhX2Yxmp9u+MAcZzSVFo9tCHADgIWdCA3sjnb/beH5 GP54Sml2hW9n8tfqQTHeIIX8OmvWs2zbNUs2vz5zRzgp/8eupKb3r2URq/lW55mh ryxChBP0wC6scBeT7bLAowDomIHNZv4gKJGIwXAGI48KvGHAltJuHARJGzkemx9L XZUQpOBJE5cfk4HVpOUVPNM1yz7i26mL65OzIOC9385RfFyA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e10m9suhh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 05:45:58 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8354503d9acso1898422b3a.1 for ; Thu, 07 May 2026 22:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778219158; x=1778823958; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=RvST/I7tIUlGh9vWEp+EZm+Dpv+zO8gesAQ4YHqr+Kg=; b=LsEAM3LXIOmliZ1OlNB/upZyLMok7Dkh1fqawF9Z8n2YRfWZ6hfbOB10zjLxN8MOqW 1ZSH9A4dyc77mvhJNfqfKyQ59ieC5AO1O/R4cT0fJn1y1h8txQf9k0XvRSVVGPxMCtg1 g6XxO3QFxmeyFETKe7xcWDjCja97k/B+Fj/3UVpn/9zUfAaU0Fr8/5XcEQF6KLcu7bW5 SdaDpAdGGnap48jg8o16gPW1ekbhLto2pMV6CWCKnDJBXzaDvdRfts4Gx9TCezuA2JGq r+m6681GrU2F7oz4PbKQdsoDqFoVpPcTZB03yENOET5Jj355on2z3F52Rkiax1csQPZf yhDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778219158; x=1778823958; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RvST/I7tIUlGh9vWEp+EZm+Dpv+zO8gesAQ4YHqr+Kg=; b=WavDMK6XAeAyKmZCIZdTENSAt7x3lrx6i1P/N/DsrwW4LVugMcV9AWK8pJqq+rSlkS FNavi9o1A7N0ShLQWJikcsuhcc/FWBU7TI8lzSOsBQ1bxArCXnNUq0rOPFvATX9ZELiQ FP8OHLSjDr7BgFka5rs9ZpU5s/8usOcEHKyKWAB7cmEXXYam+AUrigFUugFIAO54qMn/ 2Hx7WT/rFcu2/2kMgUhbV5FDown2DFNvSnVRk/sUJ9/DnNxd/Idd4qz3FkePDQn9FLWu WTMpMhcfodb3eO8PsF6XJhgQo/tFsRCK3WtDe9T5l6h4F0SRlQWr9ecGHq9hCLj7Glzd BXMA== X-Forwarded-Encrypted: i=1; AFNElJ/APBqZPuJA7A0MmdgGZm8ykLhHmyEZQHUtp2ZsOB22WhUPmFl4VMpd66ShNnKWau+3HLZh53uAsseCCAY=@vger.kernel.org X-Gm-Message-State: AOJu0YxhAdURacLqujrBteIhARAAJXifGx5Y4impQUH1Mnb7bFR5kWCM xRY36erEx2PA67N3/Nkp0hlAmDegMIDux5TaSubZtmmNRZjcj5keLH89hFZFJdifnFX/1jAGC4k fa9Cvrqf/vd5ikh6tTzQO6MZFw1WYarKQW07TGULcpKfXXS6QIaotaVt+NxJYxkLoExU= X-Gm-Gg: AeBDievDnEV4BQLfyD/KA3dYgvJ1DjJavs5jEthMSSDqO7qIvqcLFqmxJr4gUG5tl26 ZnsRPlFqYU9t2tuu+uTa2iPFymt3tDwr82iIe6+UUtTRBn7gqeISzdXNxfBpmUWmoHWqXhISqiq 88tcS2rwD2VtwW4GsrAfVjg/xxK0jxFHUHXJtB6jjxrx2HfbNoVImiscMV+wC8yVrzKde4rRJKs zKnjG6aQ/nv63d/wVLXuh5g+2IWpc8uhmREqQG1iWfMoA6YNwJdTcc+ewY6UrsK7XsxMbVFDiAK YXYH64c3frG3N6FpQV0mJZ4p4sNbMEQ99aby2F0jXALhX+S/NVy05H8TREQY2s0XY7bOZrgSwo6 gKF64TSoIP5atiJOE+NN6rxFIECEhlSBkDV+pxRy7yxmoBCZ1NLK26EpOu3gKrbPTGPcO6ZpiiB Qvex0wO5H/60+j/vso1Vo= X-Received: by 2002:a05:6a00:1d8c:b0:834:ea1a:4b25 with SMTP id d2e1a72fcca58-83a5c0c170bmr11144134b3a.12.1778219157431; Thu, 07 May 2026 22:45:57 -0700 (PDT) X-Received: by 2002:a05:6a00:1d8c:b0:834:ea1a:4b25 with SMTP id d2e1a72fcca58-83a5c0c170bmr11144110b3a.12.1778219156929; Thu, 07 May 2026 22:45:56 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965946543sm14235835b3a.16.2026.05.07.22.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 22:45:56 -0700 (PDT) From: Jie Gan Date: Fri, 08 May 2026 13:45:35 +0800 Subject: [PATCH] coresight: fix missing error code when trace ID is invalid Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260508-fix-trace-id-error-v1-1-5f11a5456fdf@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAIB4/WkC/x2MQQqAMAwEv1JyNlCLivgV8VBNqrlUSUUE6d+tH oednQcSq3CCwTygfEmSPRaoKwPL5uPKKFQYnHWdbW2PQW481S/fgKy6K9IciBrqg6MayvFQLtY fHaecXwLkFBNkAAAA To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778219153; l=2312; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=tUI+fbM9hZlLRW7XpYtSlSf8sGpkz4jhK/VKV3GOiO0=; b=vGjBAQ65b3wspSpaDxehkEDdbhSfgSShlYJk4UBDymHu9TjiwSq3gX/wqx4Tn3QwssV0pIEwD /lSca0bKjD1Al8KmgFd7TMc9TJS/7gR/7aFs/yq67QUyQaJhUGxsse+ X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-GUID: vyIV9qD0f1vFTP42xDQubYVtP2nIhYNt X-Authority-Analysis: v=2.4 cv=VP3tWdPX c=1 sm=1 tr=0 ts=69fd7896 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=f2pQIliOnLl42a33m6AA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDA1MyBTYWx0ZWRfXwM9fdt734ffq 8uH7m1lC1qzJa6sxBxUL4/WC6QWtyqu56GgP09c4qToy7Dfu+JKAuTpohYrm2RLFDUmO/oSP+nS YcTYIEOr4mCHJDftlXUgA3yRUk66hnrMK+po0JPb8iNH2YyR/++mq5BgZ6XSoiB0cpzuH3o6EEL jwRiGLGjGRE3lRiBA/xtsqN0NyY16GEetQPwTpFk8ZD7MRSuX6PRKvZMEaKZLiIVmzeJuJwwdN5 jWo5WjxZynbgq1hhPscQ1egBZUVtASH2XCg0Df1/TMppoENNtD2uYz3EjWsDbJVTmBefb/vPeey wJxgdbv+l3iVmuQMC+jmHsqYD7YjfLP1gjiDT/qpjxOnXraDWb5Y/itJf9cxaRb8mtY5cOhGln4 rMejNNRuy4M3yOxocbQV1RNtXy5F+yLS/xtf1HIqhiokY5+YQ0VwcRnTEkh24gkqoNRNJQ7Aw1l t1EIceoC2GYH4edNJhA== X-Proofpoint-ORIG-GUID: vyIV9qD0f1vFTP42xDQubYVtP2nIhYNt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 suspectscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080053 When coresight_path_assign_trace_id() fails to allocate a valid trace ID, the code jumps to err_path without setting ret to an error value. This causes coresight_enable_sysfs() to return 0 (success) to the caller even though no trace session was started. Set ret =3D -EINVAL before the goto so that callers receive a proper error code. Fixes: d87d76d823d1 ("Coresight: Allocate trace ID after building the path") Signed-off-by: Jie Gan Reviewed-by: James Clark Reviewed-by: Leo Yan --- drivers/hwtracing/coresight/coresight-sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-sysfs.c b/drivers/hwtrac= ing/coresight/coresight-sysfs.c index d2a6ed8bcc74..c9338c783540 100644 --- a/drivers/hwtracing/coresight/coresight-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-sysfs.c @@ -195,42 +195,44 @@ int coresight_enable_sysfs(struct coresight_device *c= sdev) */ if (subtype =3D=3D CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE) csdev->refcnt++; goto out; } =20 sink =3D coresight_find_activated_sysfs_sink(csdev); if (!sink) { ret =3D -EINVAL; goto out; } =20 path =3D coresight_build_path(csdev, sink); if (IS_ERR(path)) { pr_err("building path(s) failed\n"); ret =3D PTR_ERR(path); goto out; } =20 coresight_path_assign_trace_id(path, CS_MODE_SYSFS); - if (!IS_VALID_CS_TRACE_ID(path->trace_id)) + if (!IS_VALID_CS_TRACE_ID(path->trace_id)) { + ret =3D -EINVAL; goto err_path; + } =20 ret =3D coresight_enable_path(path, CS_MODE_SYSFS); if (ret) goto err_path; =20 ret =3D coresight_enable_source_sysfs(csdev, CS_MODE_SYSFS, path); if (ret) goto err_source; =20 switch (subtype) { case CORESIGHT_DEV_SUBTYPE_SOURCE_PROC: /* * When working from sysFS it is important to keep track * of the paths that were created so that they can be * undone in 'coresight_disable()'. Since there can only * be a single session per tracer (when working from sysFS) * a per-cpu variable will do just fine. */ cpu =3D source_ops(csdev)->cpu_id(csdev); per_cpu(tracer_path, cpu) =3D path; --- base-commit: 17c7841d09ee7d33557fd075562d9289b6018c90 change-id: 20260508-fix-trace-id-error-dbfdd4d8f2d1 Best regards, --=20 Jie Gan