From nobody Sat Jun 13 11:24:49 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DEE64508E0 for ; Thu, 7 May 2026 16:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778170220; cv=none; b=KkKG0CsHgnSXRxkwam62tW6gYH4UM5eIVYhl/MwsmZ4gNm7tQ3hJecaRTs6RKwfjMamFMPb8Ao9iOWrAI5DMqWY4cX9NfUQHqgbROPvcNxNngS997QcMbqDQmL7/GIdxeFvSFe/rSiSTKuPmMf//XuvHOhWJa7rf6GI6uLABLuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778170220; c=relaxed/simple; bh=pZLKugcNuIFz+TCCWdncQFh/3U8qnsDMYQHV/KwPCIU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=VzzVTfnT7WDe4pZjB3GrxIbIdlXBa7bzLjbVX5yXzjtBLR34xVKLGxR0I2Pji39TPESs/wIlqjnv+j7CwNw7yOtuV0vAB95lLfavCnw+wj1MHs6ICgNPCvpCaSFY99e82MjEjFFEi5fp6hmKdF7pQqLZBNaor9HxsQqp3ovpclI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=Vie/eGWx; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="Vie/eGWx" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-44da2de25f3so803623f8f.1 for ; Thu, 07 May 2026 09:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778170216; x=1778775016; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LQ3SQvBiRUwqrCcVCAbqsQm4u0JNgKs4uH+IAlcNiSM=; b=Vie/eGWxRkpOsLCY5nvQ7FxyOM2aoEfQg8tElMmNG39of2HnHtTNHBYCxWdesmjp/m 8a/Yw2xJ8G+F8EfhqhMICD03w6gWN9EvgQaD1wbtnywjWY1zC/a5zWxPCG3ITlTZ2HjF c1AqIx5eU1PNHmniE8vUe6FNs9yRa8ODv81Zr2Yi5QVoDYMughY6i9leLJnpCPuaQPO4 4ra2oHXsdEPhqhjSL01SFX5D+KnxKAq040ckWfLGaAROb8FCuLcXwMHbvkPTj3kkakcu YKf5CZOS2nKF2Qo6Okoaandc4aroPslxPGQNkIJAr2MIz2TU44wKFPry7ooXWoHH2tds 5W1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778170216; x=1778775016; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LQ3SQvBiRUwqrCcVCAbqsQm4u0JNgKs4uH+IAlcNiSM=; b=PnNQoYppSdSaunUSDRPFx6jcUQnMj8forrtreg5cyPnTGwceYAALt8kR9UvkpUBmAn xlWy2Hy40HqD2nnEd8yfQPyQuU75OrDgXI6bB9p7sQKYAGFmU7wwTRuH4LaxP3JdpUOv N405yTSDBIKJiNUo8qxp/I3wqJLgG4+vbIN+2a5n61XA7bUxJQsfRxdOf4zXothkGJGP wZ3o88OUqARhPk7qFJLra8eMDz3PAntsujWeig6sVgZmorYUuMqfc++Jd+IRyHIEYBGA KuH7JtjFVRIFS0bVDfIjZrjLG9hRHhiWbiCTBoy0605ZK/q7ewFZLxNRLIS/i8Yfdwzh 1aTA== X-Forwarded-Encrypted: i=1; AFNElJ8RBCGls0evNp7pFJgTEwe4pCJt5SI6ZSdZR+EtdOjzGFmyCevUGzvgoSQh2DtuFUpoo7EoamzWiH2SrA0=@vger.kernel.org X-Gm-Message-State: AOJu0YwCPrCo9LxrzRnNIGhmSs7XBVYKnGjChCtz8hYcPYzJahvu4Ct3 +pIWR5lG7n//7hyiy/nXnfdRGgceSQRaCJHwnvnGsnnCYw3yKE+ywjCfAa+EGgJuF1w= X-Gm-Gg: AeBDiescbnc6xOxpW8jErDYznnUiHVw9Q+sFQQRUb4THr4lp09ANHVk6X8aEo54wsnO KP3IesAdjI5rbelbsAprlhYOV+T8a1Hsc8v/W71iZ6rg+HiqXHNvO/YC/+603dV5gEhHNd/+fon tRiA+b3nJZgmJvtL9iWl+uffdjkugkC+peChwJGEaEZa+UwtLv1mgAQGYc5jPPoKB4ZilKL4OU7 eENQFr4kOhc0HTaJNzibwizWe8P7/DZ+h3v9RuNu4xmwzBwRNJTbGRNxOZsMDkcBaKxe9Vu82w1 t1wRbF0R2uWMv54Zl7rjwRRoHITU1LfB2lsy3wh6sxv121tGVSYreeIm21kdWrVteMz7ir8G1Fe MiKZvdG6Sn0z8emNsEOq/tWoLfVvf3hBbYizZPtnHgsuKkQzQTUuKRHTtBCd+zBq9l2p178Feqn hN6qAPz7NzgV2Gm3le2+GvRH31H2JQrvOTMiBD6J2lknqgekT2f6fWSBPa417OwsOXr13iqPO6x S+1nkxOH94PTOJOQLb+UJ5vqw== X-Received: by 2002:a05:600c:3b17:b0:483:8062:b2f with SMTP id 5b1f17b1804b1-48e51f18561mr134064005e9.6.1778170215581; Thu, 07 May 2026 09:10:15 -0700 (PDT) Received: from localhost (p200300f65f114e08e9fd60f450b139aa.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:e9fd:60f4:50b1:39aa]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48e538fb1a7sm233571675e9.9.2026.05.07.09.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 09:10:15 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH] mmc: via-sdmmc: Simplify initialisation of pci_device_id array Date: Thu, 7 May 2026 18:10:07 +0200 Message-ID: <20260507161008.3423977-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1592; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=pZLKugcNuIFz+TCCWdncQFh/3U8qnsDMYQHV/KwPCIU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBp/LlgxbXjFmnL1/KWaNoKK5E+38Q6jYt6xKLgQ vYmvxfN8YOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCafy5YAAKCRCPgPtYfRL+ Tp6HCACbUYVynyLfxWs/MZfoOhbxACQMGzroPNx+NcW/0ob480s2t1AV+j7xSCO5F7585WdU96u x4IZa0WG2l/8OhoYL2KbTOCVWMw1Sv8tNqZk5ehGpuU+u486QuYQLRrWReqiiI68hyb2KoO0pw+ 3IDiOAnwo1RM66o664I/jtiHna/K/iAoL9ueKymU8sN+hsbe0w58/HdTAk55lQbqaO7rGfo7qAT WizU/En/akR3KMg93A5LJp8iClCKBFvty6lZ0NKa7b92ASHk98ZmuWaWD74jO9VqH0jb6IBl2yD qVT7XToGGMGLIRIxrWTYeZBiQuQZ0U12ycF9gwPDw44TX4sH X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Instead of assigning the pci_device_id members using a list (which is hard to read as you need to look at the order of the members in that struct in parallel) use the PCI_VDEVICE() convenience macro to compact the initialisation while improving readability. Also drop trailing zeros that the compiler will care about then. The change doesn't introduce binary changes to the compiled driver, verified on both ARCH=3Dx86 and ARCH=3Darm64. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- Hello, this is a preparing change for making struct pci_device_id::driver_data an anonymous union (similar to https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre.c= om/). This requires named initializers for .driver_data. In this case the initialization can be dropped as the driver doesn't make use of .driver_data at all. Best regards Uwe drivers/mmc/host/via-sdmmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/via-sdmmc.c b/drivers/mmc/host/via-sdmmc.c index c628b3bbfd7a..8c049f8355cd 100644 --- a/drivers/mmc/host/via-sdmmc.c +++ b/drivers/mmc/host/via-sdmmc.c @@ -323,9 +323,8 @@ struct via_crdr_mmc_host { #define VIA_CMD_TIMEOUT_MS 1000 =20 static const struct pci_device_id via_ids[] =3D { - {PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_9530, - PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0,}, - {0,} + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_9530) }, + { } }; =20 MODULE_DEVICE_TABLE(pci, via_ids); base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3