From nobody Sat Jun 13 11:59:37 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7709344BCA8 for ; Thu, 7 May 2026 15:50:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778169044; cv=none; b=HgBo7UdRV8Y11g4v7J1555PYTxeFb+2pnu4WmX15Cp2rEEDDogNcAEEUAdh7bXcO7q+vmF3BXsZS4UyFJZeOZW7mKpL1xk9VAM2WCI0VXZAonHdmVnQFIr9L83GaCyLLDbb2sihcTFaJ3W7PgC4xhd6pNl/zYauIwwV88V3x0f0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778169044; c=relaxed/simple; bh=vqpQ7su2zaf1QViLtNg6a7uVZuUX77IifebVxWL4gak=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=c0uJSLjVZlBlZEdQnWvGYmVZre6LwNYaLpR7SkbwKnJxd/qthpl5TZVF2FpCBcGrncW17KBKMW5sDpfOUYppnnnFcBTEVOyafeZhoGT1GPx4b38TZWAp0PdpUznin74k+7/4IlD8Dt1k3t19NzhBzNOK6ASABuA86bSS+pv3YTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=LRK5pQn7; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="LRK5pQn7" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48d102471a4so10728225e9.2 for ; Thu, 07 May 2026 08:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778169037; x=1778773837; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WSQWnJQATh2EdBTdG2QpfFCiA1hZYD2zQB9kNoR/GdY=; b=LRK5pQn75EQBZZSE/rSKD+HkYyX1IfJjgMBbUoGSrjcFSSi69szH2SrPBsvzMDZTrH F+A85ZHIM/FGspFAWp2q+dW6gEr2oGHthGOFBYx/jhKfFXqellydbexJQlzvOOuY35AF cVEyRp5qaVxKs5SG/ZxM7y3S1hik4WmxN8szJLYhSiSCQ4T12Yp4aQx3qY+LjDvw5+gx CmFPGYuTMzi2zXlK/uSJ/hrS+Grto/yaNMvTxBZ89W7eUx5VFJt+bu0Yt782pr8NWVfy fAdwsnuN6Otm+vZRPn0IVQGPXYf5Ise3DkUqu08zXY1IbX0o+4VxWrJkNRetsite+0nr Ufsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778169037; x=1778773837; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WSQWnJQATh2EdBTdG2QpfFCiA1hZYD2zQB9kNoR/GdY=; b=nC3pgjH1yLKoa+SQ/GJXGkcNlg626TALfBVbWf4/TkY8IMIW+BO4WPZu0IXN4BBCeO TrmYFyvKydqkr6xVZvUTH14TAL2XAyUt1KqERmZAtbORYs4sD7SVsZE/i6W7yqH2/pc3 uSTWC1bS75p67/zkTMQT/m6xLUyQc3NIk3TzMqFRSQavmWJ8wzciyvk4XGoHvxSnyAwA xuu9Ft4mlbz/0tGp92j/5xXW7/jKSM3Nj0lWfxCPBmD9JkXneULBBylRA8dExFELnuRm 7cHM1ET6+rUDlT14ADY0Hr/f+ss4iCsx6txbD6qqXa+KR2YpO1/7eRcVfmSthiOGt81J 4Vuw== X-Forwarded-Encrypted: i=1; AFNElJ/O6vkJl7PvoWgLAQVzsuN0tagdsn5Ze+5pF9SzILTgdoowFHsySzuNl73/hHfiqQLtWgNAVFS8USlmD5M=@vger.kernel.org X-Gm-Message-State: AOJu0Yzxaz4SWhrbFC3EMA4/rXKnddgsFHJy5Vh2QX7rBxdPQF80tnDQ jl1t4mfZhCKkvHPo9gZiCEjGhzF6ukUZLEvXCztgQCqhK5VwCL54LEy13vvJiCNbg8w= X-Gm-Gg: AeBDiesMl5KgZJYZR/8nkfqbKQeI3SSe5vJcSLFF0HZeK/bo2N1GW4hhocuio+rL0k3 w70k2Ivy7ltTfe+ZadtthnZhal0uTWc3MFsf52PWWQ/HR4UYCr1GKrngMg+iFVjNeUOSLrLuRyS uiwhglzcQzd8avUtvYVFeGGFmk+NZXjivNu6u4FNNVrdGxujuitIIfj9ieZ5EKyYNmawhg8rzUX Bg4JNz4noxwRe7CQIgGQPfZBPJ102kIKGZG1ELwS8L8vrVAN4ttVw0IEIED82wNzRVAkSx8T+8y lzM9RU3juCh+FctRvTBi19cbQaEyPs5kIyq/JkA7lEwD80s6IhR9gj/Du73en6b/N7jVouIMHXS KPKplwZeZmRAPiC2ZLQJWe5TJ7gCEHOeGgqtNHL5LGydxaHirDRdXsqhL9Bljq1hNV2h5Ap9CTy p6x7lWKB2ggRZ5zkWtJL2t1ng/4sUwQ8q2QMQtB89Gr0tlmtcNWhZ+3hp6ol0+UdSlsNoJhemuR 6olb0Dkhz0= X-Received: by 2002:a05:600c:c096:b0:488:936a:6220 with SMTP id 5b1f17b1804b1-48e51f444ffmr99757635e9.21.1778169036846; Thu, 07 May 2026 08:50:36 -0700 (PDT) Received: from localhost (p200300f65f114e08e9fd60f450b139aa.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:e9fd:60f4:50b1:39aa]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48e5390f854sm127729635e9.14.2026.05.07.08.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 08:50:36 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH] platform/x86: pmc_atom: Use named initializer for pci_device_id array Date: Thu, 7 May 2026 17:50:25 +0200 Message-ID: <20260507155025.3186956-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1886; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=vqpQ7su2zaf1QViLtNg6a7uVZuUX77IifebVxWL4gak=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBp/LTBS7tu2nN0lLhkI7NzE9vj09j3kGt4J2qgd pbEohK734OJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCafy0wQAKCRCPgPtYfRL+ TqokB/0UlgLDi9WQDVfD3mdr8ZT5rC2bwyP7lV/ai+6ftk3hzCA49v0NHhu/m0sgEUC1Kk3anK5 UnZFdzeRAgtW7XkY0NSdud8SuQD2f9aIYEP0pcW1LqNGJVvIqq9miKxtTyQNuFS97WSPW2DwnuA 5WiZvqfdVP/uKTaAmfU6ynPFKSI2DZcL5zPOWeTR8rcAWI/bkqgMbTYEyyGJPWAIS99QndNGBxE LMoNcXbMDeDKRs9VVSgd0VHNypXHWfgbDjJXaYdE9M1+2+WyhzR3BPh9Vn59js70YMr+IRC7TUA Sshk+c9Ocl44olpXT86mc/5lre09S0KjJqcENC9E8+tBlD32 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable While being more verbose using a named initializer yields easier to understand code and doesn't rely on the two hidden zeros in the PCI_VDEVICE macro. This doesn't introduce any changes to the compiled result of the array, which was confirmed with an ARCH=3Dx86 build. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- Hello, while being a cleanup that can stand on its own this is also a preparation for making driver_data an anonymous union that requires that .driver_data is initialized by name and not by list order. The union allows to do - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_VLV_PMC), .driver_data =3D (kernel_ul= ong_t)&byt_data }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_VLV_PMC), .driver_data_ptr =3D &byt_d= ata }, and - const struct pmc_data *data =3D (struct pmc_data *)ent->driver_data; + const struct pmc_data *data =3D ent->driver_data_ptr; then. Best regards Uwe drivers/platform/x86/pmc_atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_ato= m.c index 48c2a0e59d18..046933f6d1b6 100644 --- a/drivers/platform/x86/pmc_atom.c +++ b/drivers/platform/x86/pmc_atom.c @@ -570,8 +570,8 @@ static int pmc_setup_dev(struct pci_dev *pdev, const st= ruct pci_device_id *ent) =20 /* Data for PCI driver interface used by pci_match_id() call below */ static const struct pci_device_id pmc_pci_ids[] =3D { - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_VLV_PMC), (kernel_ulong_t)&byt_data }, - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_CHT_PMC), (kernel_ulong_t)&cht_data }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_VLV_PMC), .driver_data =3D (kernel_ulo= ng_t)&byt_data }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_CHT_PMC), .driver_data =3D (kernel_ulo= ng_t)&cht_data }, {} }; =20 base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3