From nobody Sat Jun 13 11:26:24 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08F0F1A316E for ; Thu, 7 May 2026 15:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168458; cv=none; b=gysYRr0yJVbAGE92yXWwwdkchh1w10tw5Alc/CxOveTX/arTJevxD1bamr6DOQiwWrRdEd2RxYk/fyyL4Gd1bG+QUhDWoBdRqQxOCLNNqVsfCk/hr/174c9Z/r3YA0LqrMoVG3hSYwhQ7TTzwPc5FZQrqD6aVRgaviDGXkLsSuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168458; c=relaxed/simple; bh=ZOAG+PaTnbEuQvPV0cecL49HZOzEtUxCeU7U+X4WHVo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=JBtzGZ7t43rf9MG7SGCJ+fNanMBSzRAeWctUQmy+jvc3qg3Nui+/UW9+ce08Tq6MWX9tUJQgL6jvT3CqDfWQT37k6lAePa8JWu7EJxF6qat+Sp40g+c68u+obs5RmbfVDbxbJIOL6ZbQ/4xZTi5Kr4GXHc4gMs+W8sUv7/G6AbQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=H0264IeT; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="H0264IeT" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488a14c31eeso7304595e9.0 for ; Thu, 07 May 2026 08:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778168454; x=1778773254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AzOC01JPFJlLpj5sxX8zbJuw2PU0GK30zWxgfz5M1Y8=; b=H0264IeTRkGghaRjP+OWDRy/n4ur1JW1umrxs8xLKlgRUPiEsgru86VlavhJgsbW2I Rj1auE21isbaQwD9zRnq7jw5E7YTPbRPwZDt0HY0yOC1EokVDPGiF7zHsP3vtvyk6Hr4 Lyl8nzgZZ11XMadoqShAbLnzzUgMUW46yGrqHWr2blQroL6VyQiRITRDktWnDoFAMUVd sCisjYE3m09MexD1sCjgb1SQOeWBTOMmSz4SgK89Ft1t1uN+20saOo7FhKc5Bf68BodJ WFVsbxK7RnZvoZbeXWYdkUr6WLm8PFewoUZQB1Ym3qwn8d3ElmiXcciK7QfEo2O3CP6y ADhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168454; x=1778773254; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AzOC01JPFJlLpj5sxX8zbJuw2PU0GK30zWxgfz5M1Y8=; b=jw9sslv6qjpwjfCKf0Ovc6FWGq0uHwqPUC7Fr2QYV6u2//kUBFWk+7nn5He5wTEYxS qqo8giyVr+3sUCfdUmpNDFdWtxmpLGlBUZ2kypL17kltmp640Q9zLMl3TjeMOUFRjtxy mqgcSDy+tHXDWJac++glseQ3kIFOPZ8Dwj9rirmkiFVxJ8d4HVGt5nQFFM2f9C0UCAHQ ZKd0tNwh7QGbSlBf1UFBH+1o+YillqhLIqpqahUFM3twajiGHuuvx6ma0TvFjonChGmm 2g77+PU4nd2utdZc6/g5b+J6xpyZmTbDNEl2584ZUZKp5QX7Pycp+nZOka+9hSSrTd12 QiCw== X-Forwarded-Encrypted: i=1; AFNElJ+bVgTE7qu3DNZtRzp24q7/G5aQCEKX8MK9QJC6BFq7H7KFJzC7mxt0MqjLoWKC7kXi71MDyqLrtPByHj0=@vger.kernel.org X-Gm-Message-State: AOJu0YzMFmcHxqAXQVOlHFyyypy6inLMbEJRInf5PkD0y4eXeKV5C9wT LUjZRVPMX2SBokn4feZYmyTQ+BpkH381hT7VX48uPdp98aMMSIdiU0y2APaCcu+CfHw= X-Gm-Gg: AeBDietdlSEDSw6I8mg+vcasBy9m+ygLW5y82VaF9iuNbHGYdxKh13tRT6xBKAORuOd zS5GC43vTsAqzXYFrY/vXHTvjzmn3tUfAwIoEhfFs0z/7ppvjQWfH9sPx609eQq9GA8DFD5k7Ih 1igryvuJUQL14TNjvL1NCP9U5I0eB/5aMHxS+vnpo5kNZM0TUSQVQu3BK0dviM64nNE6ZfgNIZ8 ohOvSu6NC5ez7qOQrS+sFcUw3/njTQNtXdL8Tk6DmTOFcwmle61gKwzl0I62gU+Hh+hsgDFO+MP FoxyjDPQQKLBk+V2oHLv0kjQsJ30pwoZAwVcMkdAPhnTtNezpWzVgJug/IjGXiNl7A9Bn3SsNMx m5kTqew1YgkueRgCde9l7VleHXW1QXJj4tvQRPGkfuamjLu4RUDa/yw9H4T0W3sli6BS/gvQf/t rAVmF+ZS3ZxGo8e2/b0CXOyBvuUp0qSaTmCCq6EoD2B1VQMeYE/c2aPFr1fFBLh+IOhqPvtJ3vU SaYVhmIAO5JaTtPlw7jYiqiVg== X-Received: by 2002:a05:600c:3420:b0:48e:51f5:2764 with SMTP id 5b1f17b1804b1-48e51f52779mr87273125e9.27.1778168454258; Thu, 07 May 2026 08:40:54 -0700 (PDT) Received: from localhost (p200300f65f114e08e9fd60f450b139aa.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:e9fd:60f4:50b1:39aa]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-45055d381c8sm19900940f8f.33.2026.05.07.08.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 08:40:53 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Andy Shevchenko Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH] x86/platform/intel-mid: Use named initializer for pci_device_id array Date: Thu, 7 May 2026 17:40:43 +0200 Message-ID: <20260507154043.3113348-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2848; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=ZOAG+PaTnbEuQvPV0cecL49HZOzEtUxCeU7U+X4WHVo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBp/LJ712psFdccq67JjTxG8EX4oENyavEHHBbzD CJefmAYfpiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCafyyewAKCRCPgPtYfRL+ Thq6B/96t1EiPlteDvKEz/HOHlVVYZvAKYoD5+R3fZywu9XuXGobX4lQdEISnuh7+XibvBMaU93 fc+e2/GDGo69GPFIkSJnhJrCob31Uv3idWjobSsMjGVISZ1m0ElYfbHSmG8PI6mM/3+FNwaiS7S L6xmUQOGNdNrVR+hPTxrpm8kLMgF/MG6ImijICVXIvld2cxfzN5Ok32qyf4FDSuzq165cbQc1Vt CIk1PSWvIjvNV2bx8LofCJ0qP/zW27XCqR8dBWI23K45HuW1aZjQfyPD3HfxBENe0OotF6xEXLZ COIfYlAiBAfVRKx92+ff0KCuvmlXwg83Yy0SGJITLnCCszRD X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable While being more verbose using a named initializer yields easier to understand code and doesn't rely on the two hidden zeros in the PCI_VDEVICE macro. This doesn't introduce any changes to the compiled result of the array, which was confirmed with an ARCH=3Dx86 build. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- Hello, while being a cleanup that can stand on its own this is also a preparation for making driver_data an anonymous union that requires that .driver_data is initialized by name and not by list order. The union allows to make better use of the C type system and drops the need for casting which then let the compiler notice a missing const. The change to the driver will look as follows: diff --git a/arch/x86/platform/intel-mid/pwr.c b/arch/x86/platform/intel-m= id/pwr.c index 1739971478ff..f677d30b4342 100644 --- a/arch/x86/platform/intel-mid/pwr.c +++ b/arch/x86/platform/intel-mid/pwr.c @@ -347,7 +347,7 @@ struct mid_pwr_device_info { static int mid_pwr_probe(struct pci_dev *pdev, const struct pci_device_id= *id) { - struct mid_pwr_device_info *info =3D (void *)id->driver_data; + const struct mid_pwr_device_info *info =3D id->driver_data_ptr; struct device *dev =3D &pdev->dev; struct mid_pwr *pwr; int ret; @@ -471,8 +471,8 @@ static const struct mid_pwr_device_info tng_info =3D { /* This table should be in sync with the one in drivers/pci/pci-mid.c */ static const struct pci_device_id mid_pwr_pci_ids[] =3D { - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_PENWELL), .driver_data =3D (kernel_ul= ong_t)&pnw_info }, - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_TANGIER), .driver_data =3D (kernel_ul= ong_t)&tng_info }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_PENWELL), .driver_data_ptr =3D &pnw_i= nfo }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_TANGIER), .driver_data_ptr =3D &tng_i= nfo }, {} }; Best regards Uwe arch/x86/platform/intel-mid/pwr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/platform/intel-mid/pwr.c b/arch/x86/platform/intel-mi= d/pwr.c index cd7e0c71adde..1739971478ff 100644 --- a/arch/x86/platform/intel-mid/pwr.c +++ b/arch/x86/platform/intel-mid/pwr.c @@ -471,8 +471,8 @@ static const struct mid_pwr_device_info tng_info =3D { =20 /* This table should be in sync with the one in drivers/pci/pci-mid.c */ static const struct pci_device_id mid_pwr_pci_ids[] =3D { - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_PENWELL), (kernel_ulong_t)&pnw_info }, - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_TANGIER), (kernel_ulong_t)&tng_info }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_PENWELL), .driver_data =3D (kernel_ulo= ng_t)&pnw_info }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_TANGIER), .driver_data =3D (kernel_ulo= ng_t)&tng_info }, {} }; =20 base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3