From nobody Sat Jun 13 12:28:23 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E88C3FB7C7 for ; Thu, 7 May 2026 13:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778161583; cv=none; b=Tq+qhFb0a9N2tzX2IOcFLiNVt0o6kK4cl/KI94uE5K3BnyVgVtlrGIOMD+AlJPQ7k3WsccJzs9WHx4dJ3t6qS08HB382LpvzvTX/NR5f/hGuyALKXswzXxZpSnb4zteDjgLg728MJ5lQrwAfNxJh1+spvhCgl8IqVyRlzyF0SNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778161583; c=relaxed/simple; bh=+gXx26kToc5Qsn+X5xpx5KaXlfJuV83OpMJgOHZcMo4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KSoibWMAtfquDkKZVZR6CT/rBLbbyVWbqRt00hSFBuXxlg0yAF6o2WzzC/FFFKDx6qA6dnlNyh+FGuql+Wau2AY4280b0QdivAEt+OLRzcUBI3Be3nDw58FcHMjcGFzF7rDvyRVsZVnRkc8ZddniNyTUnNmmHH/zf8f5oZD9I0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FkgDFTUS; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FkgDFTUS" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-44509921fbcso469794f8f.3 for ; Thu, 07 May 2026 06:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778161580; x=1778766380; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pFgTexS82Aes4S2KA8waYF2yU7gR1eiSJ6BQPR26m30=; b=FkgDFTUS4VAHCzCXwoib/O1Ujqwk8hb+6wWrorAgdpGuo5UWKX8UPOMIXkH+ZxkweB 0DeyIPbEZeyiJtTGtHf2GUWIjan7Y7BLIntjZbwDCy4div7L6cDfeV2W4FI0yqxlDSrF dz0UmWufE4R6+Zduz2pSgYfjZT1I7PHu2Om6NJyaYHS6h1NIob+F1wt6JOhjMZDJZvXQ zVyD6xVAG2ehMU6Lw1te/8tMOqbDBO6nREtN8rmdlaGWpYd8CYRDzjDqszPiMpT25+nZ F2RIvu0xDnUkoelxBEMLWhtQUFQ+QU4VqmPRaga8fEuaf8QBdyYlBtsTmDWynzm7yF6g J0iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778161580; x=1778766380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pFgTexS82Aes4S2KA8waYF2yU7gR1eiSJ6BQPR26m30=; b=TpnvKN3Q92a/RrArkZKIeYku9R2JRGnqQ6FiWM2vV89Mgpc9U/v+qJzILRyUilRwAF hmO9/CIT6eaaChrWDmvxoPmVrkd1bxwWMmZ+l2tdD7GMGxZBk2QPt+e9CGm+NS0gZ0/n JKODBx1RONBB5Z8cR34KT0b48imBHA9KMQgNWcROjRukarRZLIxU+nwV9mmPTKHlDtNP HgyrR8ZpsDgH1qbA8tA38imKZo0ZywDabE3Mv0ZIMwhE0SHV5w3WmMFol7UrVc54c1ja dQMozK3C5tvAY9kf4jGgQXfP3iZRZcXIbLMjeB1wHiM8oE8u2vzl9cGRxVZ2bZNPoHOi H6VQ== X-Forwarded-Encrypted: i=1; AFNElJ81n0lD6cQiL4bzvXSpMYkPYh80i86O6z0JdYTkGWoe5RtWuaumuGmQm1f0GCyVxMDeoHwja8vCb90FhSE=@vger.kernel.org X-Gm-Message-State: AOJu0YxVs21S/vn9svScW0pboU48PCE0fcOBYl/TUyZlMrGXksSo9byO 988CrWwrmpstlsKJsKD8KXZeu8yqo5+GhoUWRD2trsZTUTnxsR3l8EK7 X-Gm-Gg: AeBDiev9IRwgp3cOn1Kx+6TOc+FU9D6C6ca0nbVWdmwb3UDB1G9/EQVcnR7NWdprzf+ U/2yZlY9F9QVss/Iveg+puDNsCLHQdKo7gSSNP6WBpNp59MGTYaCEr67z4Mg9KX80X8AHuTSuk7 +HO+6ZZmQQ4OYKk5Id1hrGLTNhia7nd6pGloOQ2dh++2xOO9RQLLyn++kiVChz21SPKqTCC48ZN P2RkvV+XXUf7LdepCmNsWV169LYIuQVrJ+wVaJfe2UgbQUkjzX6PPgx73YTMGG/UqR6ct0f4ya6 DJ6hcY7UJAJkALKz7RTobN+hQgiQnZS+Ui3eI55KULpxrAxyykn1yE0lO7KPZqGrVGNOHt9olz0 kWd6k6RaA4rUwOcSwndtpSKtjUYlGPFrGI2oDBqqxsHPXGFoPEKaSxpoPUatCTXACioas8IAUrM M33NCMbMezwsqzfNdEbc9h44E= X-Received: by 2002:a5d:54c9:0:b0:43d:73d4:b34 with SMTP id ffacd0b85a97d-4515b525080mr9703117f8f.16.1778161579065; Thu, 07 May 2026 06:46:19 -0700 (PDT) Received: from xeon ([188.163.112.56]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-450524833e1sm20701615f8f.2.2026.05.07.06.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:46:18 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Jonas=20Schw=C3=B6bel?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v4 1/2] dt-bindings: embedded-controller: Document Surface RT EC Date: Thu, 7 May 2026 16:46:06 +0300 Message-ID: <20260507134608.76222-2-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260507134608.76222-1-clamor95@gmail.com> References: <20260507134608.76222-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Document Embedded Controller used in Microsoft Surface RT tablets for monitoring battery properties and charger status. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Rob Herring (Arm) --- .../microsoft,surface-rt-ec.yaml | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/embedded-controller/m= icrosoft,surface-rt-ec.yaml diff --git a/Documentation/devicetree/bindings/embedded-controller/microsof= t,surface-rt-ec.yaml b/Documentation/devicetree/bindings/embedded-controlle= r/microsoft,surface-rt-ec.yaml new file mode 100644 index 000000000000..0fee574a3015 --- /dev/null +++ b/Documentation/devicetree/bindings/embedded-controller/microsoft,surfa= ce-rt-ec.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/embedded-controller/microsoft,surface-r= t-ec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microsoft Surface RT fuel gauge and charger EC + +maintainers: + - Jonas Schw=C3=B6bel + - Svyatoslav Ryhel + +description: + An Embedded Controller used in Microsoft Surface RT for monitoring + battery properties and charger status. + +allOf: + - $ref: /schemas/power/supply/power-supply.yaml# + +properties: + compatible: + const: microsoft,surface-rt-ec + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + maxItems: 1 + + monitored-battery: true + +required: + - compatible + - reg + - interrupts + - enable-gpios + +additionalProperties: false + +examples: + - | + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + embedded-controller@a { + compatible =3D "microsoft,surface-rt-ec"; + reg =3D <0x0a>; + + interrupt-parent =3D <&gpio>; + interrupts =3D <74 IRQ_TYPE_EDGE_RISING>; + + enable-gpios =3D <&gpio 88 GPIO_ACTIVE_HIGH>; + monitored-battery =3D <&battery>; + }; + }; +... --=20 2.51.0 From nobody Sat Jun 13 12:28:23 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 581933FB7E2 for ; Thu, 7 May 2026 13:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778161585; cv=none; b=Ww6fQdh+6jha/9ObalhZBPeE+u3ylgjjeWTrvgxVQPD6W6k6ohXNrxNUr6Re4SaJ7UaOo8wUI70aOLUi/nYDKmIuRtOBf9eIGsfHFZARtrZl2+qkAINiKB5gfeYjiIVry9G1oc0dh7wcapGwANhBtaR7mwFGxCy+RQQmKZiJgak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778161585; c=relaxed/simple; bh=WKPXbH5h2ybjOzoEHWip6SrvY2ABnzJ8hFR5GMG71uw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hP4Uz+U4KXjtfCILcG/ZtKZxfEjcYQXQ7To/7Qe707ByFpPjb0jyo4CAKrID2vVkXSbDHWNfQqgZv8zeXOWjC5v13XD7paM7wNcovx4aXU0ha5jNVZ9Ep6CfUY1V8K8WIpWvJl6l+Kh+Xp+6D7yGYAzJyotZDde4mMgNf9GmeCo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XkcLbesU; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XkcLbesU" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-448528f4e69so594992f8f.3 for ; Thu, 07 May 2026 06:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778161582; x=1778766382; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bNwuVHvFu1s7Mk8GKLERrP4YE5NdZti4xQ+xBZhJ0RM=; b=XkcLbesUnwo9v82LePnSXIrVw5UeoYgG4TI4clBtNF+IcOOH6IeoVO0xKwoLcYCkWZ gr9wwrRZEKK9/cY+J/kkJZej3x6xSGBQd5epZc652BsOfmQwL9NMzA4EIMq/Xuc39KZ2 0MuGzfS8/PTAVkSdhrpGhrCv9nuWDtTc7RKC8AFCCryPA813gDn6czu5twGjSmsBviXc fb9FYVyaw/SYDrCco5d67bs2MC/Ilids5cBfZR1ey5fV/yd9otFgtVlnRJPicHzCzIi8 gqmY1QHgzbTfktnWvE9fjiCMow3KJLAy9HHAyiiFt6kVSmRGi5+GZrhwAdEbFhj5izmG MR6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778161582; x=1778766382; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bNwuVHvFu1s7Mk8GKLERrP4YE5NdZti4xQ+xBZhJ0RM=; b=AFV1mIs+x+DzCqGAFyX6YSt3BAZI41uHt8p2HirwLy95EQjqmTPedXOfeKgKoXgCU2 2nCzFtq7eqmsE1NTzHgMI4kA9EuhO1mDFCVqGsHlv/B7m1nkox92Ek/7arSrGK+Iiemi XBvlSHbzGnxB+C33GUSfqGdIknvF3qQ354+6E7Hz982qj7MHtqVW0D81jKqOv3/X6v/A NOUFoJW0tOuiHl+hewEXHAqoz+h3VYRZ0zGAOV32vZ4D4PbXawaxVfsN6yumepsVHiFF yWT5Y9aaLTLL8sG/WtW0hV3l57p+wO4hDOjysBbeE9rdx0h3qRneqSn7LXuM2fVjUL+q SGeQ== X-Forwarded-Encrypted: i=1; AFNElJ9J8c0kLmsShmqpaL96aWJ89zLAQsBD6l9Z1I2/P2EDVW9uqP1OgJOKAP/0sA3051OVJZBc0QIArjCA2+s=@vger.kernel.org X-Gm-Message-State: AOJu0YxPnAOlEckeWt564/d4QNYaFAo7ieHjTjl+hUBextSivr6UvMxO cHKARmnTeA844JiALgLRFOZ6amtftiMkswrkc6Ut4Klwd1XHK7LzVCcW X-Gm-Gg: AeBDieuK7PcWbwkRe1S7Fu3WQSQLPA+IF1jfQsfUZeEZu+Ur6tDTnmKlRMd8suwRaSA ez9PxKwi0XHnPWu72tWwue5upnzKkQTLYwO11d+qLINuTGZasTILicpYBAxBU8c2AM2KtyrG7Sa v3I5GX9o8b1RG1YcqYYwmB6RbcaKZAmggee/Bv4kVKw5duVXo4uA4cWgE/lIuY3pD2P0Ieei5Ly BBIxgNYCAgPvLCBXNxGloBw76gNAMPhg9HGQiDNzyUAoAOyIGlAc0NZ44SEdq7ePY/EfPNoWoUN joxxfz+48MbcTNgGytfwLC4hbiTfS8VVFdfD1f2jjREBSeCdLnZ/1cdgWFXlxaMoWyyH9LTpd3/ +vK8rcW433+JsIEC+4AmJajJMh7D5VDAU952Aov7VO/5IQMB8NQEDw7wgoEeFlANCwITYmGC0Gl eXheSYXwRrCuVeHWTfgQs09uA= X-Received: by 2002:a05:6000:1366:b0:453:aad2:77a0 with SMTP id ffacd0b85a97d-453aad2783cmr1379837f8f.3.1778161581612; Thu, 07 May 2026 06:46:21 -0700 (PDT) Received: from xeon ([188.163.112.56]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-450524833e1sm20701615f8f.2.2026.05.07.06.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:46:19 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Jonas=20Schw=C3=B6bel?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v4 2/2] power: supply: Add support for Surface RT battery and charger Date: Thu, 7 May 2026 16:46:07 +0300 Message-ID: <20260507134608.76222-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260507134608.76222-1-clamor95@gmail.com> References: <20260507134608.76222-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Jonas Schw=C3=B6bel Add support for Embedded Controller found in the Microsoft Surface RT and used to monitor battery cell and charger input status and properties. Controller works both for UEFI and APX booting. [wmjb: added POWER_SUPPLY_PROP_CHARGE_NOW support] Signed-off-by: Jethro Bull Signed-off-by: Jonas Schw=C3=B6bel Signed-off-by: Svyatoslav Ryhel --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + drivers/power/supply/surface-rt-ec.c | 389 +++++++++++++++++++++++++++ 3 files changed, 401 insertions(+) create mode 100644 drivers/power/supply/surface-rt-ec.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 4d04de6586ae..13661d3d39b4 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -1168,6 +1168,17 @@ config BATTERY_UG3105 device is off or suspended, the functionality of this driver is limited to reporting capacity only. =20 +config BATTERY_CHARGER_SURFACE_RT + tristate "Battery & Charger driver for Microsoft Surface RT" + depends on I2C && GPIOLIB + help + UEFI/APX driver for the 1st-generation Microsoft Surface RT + battery. Driver supports reading battery properties and + charger status. + + This driver can also be built as a module. If so, the module + will be called surface-rt-ec. + config CHARGER_QCOM_SMB2 tristate "Qualcomm PMI8998 PMIC charger driver" depends on MFD_SPMI_PMIC diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 3959b974ec84..ebd3beef4c84 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -129,6 +129,7 @@ obj-$(CONFIG_RN5T618_POWER) +=3D rn5t618_power.o obj-$(CONFIG_BATTERY_ACER_A500) +=3D acer_a500_battery.o obj-$(CONFIG_BATTERY_SURFACE) +=3D surface_battery.o obj-$(CONFIG_CHARGER_SURFACE) +=3D surface_charger.o +obj-$(CONFIG_BATTERY_CHARGER_SURFACE_RT) +=3D surface-rt-ec.o obj-$(CONFIG_BATTERY_UG3105) +=3D ug3105_battery.o obj-$(CONFIG_CHARGER_QCOM_SMB2) +=3D qcom_smbx.o obj-$(CONFIG_FUEL_GAUGE_MM8013) +=3D mm8013.o diff --git a/drivers/power/supply/surface-rt-ec.c b/drivers/power/supply/su= rface-rt-ec.c new file mode 100644 index 000000000000..a728ae0db858 --- /dev/null +++ b/drivers/power/supply/surface-rt-ec.c @@ -0,0 +1,389 @@ +// SPDX-License-Identifier: GPL-2.0+ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* Register Addresses (B=3Dbyte; W=3Dword; S=3Dstring) */ +#define REGB_STATUS 0x02 +#define REGW_VOLTAGE_NOW 0x20 +#define REGW_CURRENT_NOW 0x24 +#define REGW_CAPACITY 0x28 +#define REGW_CHARGE_NOW 0x2a +#define REGW_CHARGE_FULL 0x2c +#define REGW_CYCLE_COUNT 0x3a +#define REGW_CHARGE_FULL_DESIGN 0x3c +#define REGW_VOLTAGE_MAX_DESIGN 0x3e +#define REGW_SERIAL_NUMBER 0x44 +#define REGS_MANUFACTURER 0x46 +#define REGS_MODEL_NAME 0x52 +#define REGS_TECHNOLOGY 0x5a +#define REGB_ONLINE 0x67 + +struct srt_ec_device { + struct i2c_client *client; + + struct power_supply *bat; + struct power_supply *psy; + + struct gpio_desc *enable_gpiod; + struct delayed_work poll_work; + + unsigned int technology; + unsigned int capacity; + + const char *serial; + char manufacturer[13]; + char model_name[10]; +}; + +static const enum power_supply_property srt_bat_power_supply_props[] =3D { + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_CHARGE_NOW, + POWER_SUPPLY_PROP_CHARGE_FULL, + POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN, + POWER_SUPPLY_PROP_CURRENT_NOW, + POWER_SUPPLY_PROP_CYCLE_COUNT, + POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_MODEL_NAME, + POWER_SUPPLY_PROP_ONLINE, + POWER_SUPPLY_PROP_PRESENT, + POWER_SUPPLY_PROP_SERIAL_NUMBER, + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_TECHNOLOGY, + POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN, + POWER_SUPPLY_PROP_VOLTAGE_NOW, +}; + +static const enum power_supply_property srt_psy_power_supply_props[] =3D { + POWER_SUPPLY_PROP_ONLINE, + POWER_SUPPLY_PROP_PRESENT, +}; + +static int srt_bat_get_value(struct i2c_client *client, int reg, int *val) +{ + int ret; + + switch (reg) { + case REGW_CHARGE_NOW: + case REGW_CHARGE_FULL_DESIGN: + case REGW_CHARGE_FULL: + case REGW_VOLTAGE_MAX_DESIGN: + case REGW_VOLTAGE_NOW: + ret =3D i2c_smbus_read_word_data(client, reg); + if (ret < 0) + return ret; + + *val =3D ret * 1000; + break; + + case REGW_CURRENT_NOW: + ret =3D i2c_smbus_read_word_data(client, reg); + if (ret < 0) + return ret; + + *val =3D (s16)ret * 1000; + break; + + case REGW_CAPACITY: + case REGW_CYCLE_COUNT: + ret =3D i2c_smbus_read_word_data(client, reg); + if (ret < 0) + return ret; + + *val =3D ret; + break; + + case REGB_STATUS: + ret =3D i2c_smbus_read_byte_data(client, reg); + if (ret < 0) + return ret; + + if (ret & BIT(0)) + *val =3D POWER_SUPPLY_STATUS_CHARGING; + else + *val =3D POWER_SUPPLY_STATUS_DISCHARGING; + break; + + case REGB_ONLINE: + ret =3D i2c_smbus_read_byte_data(client, reg); + if (ret < 0) + return ret; + + *val =3D (ret & BIT(1)) >> 1; + break; + + default: + return -EINVAL; + } + + return 0; +} + +static int srt_bat_power_supply_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct srt_ec_device *srt =3D power_supply_get_drvdata(psy); + struct i2c_client *client =3D srt->client; + int ret =3D 0; + + switch (psp) { + case POWER_SUPPLY_PROP_MANUFACTURER: + val->strval =3D srt->manufacturer; + break; + case POWER_SUPPLY_PROP_MODEL_NAME: + val->strval =3D srt->model_name; + break; + case POWER_SUPPLY_PROP_SERIAL_NUMBER: + val->strval =3D srt->serial; + break; + case POWER_SUPPLY_PROP_CAPACITY: + ret =3D srt_bat_get_value(client, REGW_CAPACITY, &val->intval); + break; + case POWER_SUPPLY_PROP_CHARGE_NOW: + ret =3D srt_bat_get_value(client, REGW_CHARGE_NOW, &val->intval); + break; + case POWER_SUPPLY_PROP_CHARGE_FULL: + ret =3D srt_bat_get_value(client, REGW_CHARGE_FULL, &val->intval); + break; + case POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN: + ret =3D srt_bat_get_value(client, REGW_CHARGE_FULL_DESIGN, + &val->intval); + break; + case POWER_SUPPLY_PROP_CURRENT_NOW: + ret =3D srt_bat_get_value(client, REGW_CURRENT_NOW, &val->intval); + break; + case POWER_SUPPLY_PROP_CYCLE_COUNT: + ret =3D srt_bat_get_value(client, REGW_CYCLE_COUNT, &val->intval); + break; + case POWER_SUPPLY_PROP_PRESENT: + val->intval =3D 1; + break; + case POWER_SUPPLY_PROP_ONLINE: + ret =3D srt_bat_get_value(client, REGB_ONLINE, &val->intval); + break; + case POWER_SUPPLY_PROP_STATUS: + if (srt->capacity < 100) + ret =3D srt_bat_get_value(client, REGB_STATUS, &val->intval); + else + val->intval =3D POWER_SUPPLY_STATUS_FULL; + break; + case POWER_SUPPLY_PROP_TECHNOLOGY: + val->intval =3D srt->technology; + break; + case POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN: + ret =3D srt_bat_get_value(client, REGW_VOLTAGE_MAX_DESIGN, + &val->intval); + break; + case POWER_SUPPLY_PROP_VOLTAGE_NOW: + ret =3D srt_bat_get_value(client, REGW_VOLTAGE_NOW, &val->intval); + break; + default: + return -EINVAL; + } + + return ret; +} + +static int srt_psy_power_supply_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct srt_ec_device *srt =3D power_supply_get_drvdata(psy); + struct i2c_client *client =3D srt->client; + int ret; + + switch (psp) { + case POWER_SUPPLY_PROP_ONLINE: + case POWER_SUPPLY_PROP_PRESENT: + ret =3D i2c_smbus_read_byte_data(client, REGB_ONLINE); + if (ret < 0) + return ret; + + val->intval =3D ret & BIT(0); + break; + default: + return -EINVAL; + } + + return 0; +} + +static void srt_bat_poll_work(struct work_struct *work) +{ + struct srt_ec_device *srt =3D + container_of(work, struct srt_ec_device, poll_work.work); + int ret, capacity; + + ret =3D srt_bat_get_value(srt->client, REGW_CAPACITY, &capacity); + if (!ret && capacity !=3D srt->capacity) { + srt->capacity =3D capacity; + power_supply_changed(srt->bat); + } + + /* continuously send uevent notification */ + schedule_delayed_work(&srt->poll_work, 30 * HZ); +} + +static irqreturn_t srt_psy_detect_irq(int irq, void *dev_id) +{ + struct srt_ec_device *srt =3D dev_id; + + power_supply_changed(srt->psy); + + return IRQ_HANDLED; +} + +static const struct power_supply_desc srt_bat_power_supply_desc =3D { + .name =3D "surface-rt-battery", + .type =3D POWER_SUPPLY_TYPE_BATTERY, + .properties =3D srt_bat_power_supply_props, + .num_properties =3D ARRAY_SIZE(srt_bat_power_supply_props), + .get_property =3D srt_bat_power_supply_get_property, + .external_power_changed =3D power_supply_changed, +}; + +static const struct power_supply_desc srt_psy_power_supply_desc =3D { + .name =3D "surface-rt-ac-adapter", + .type =3D POWER_SUPPLY_TYPE_MAINS, + .properties =3D srt_psy_power_supply_props, + .num_properties =3D ARRAY_SIZE(srt_psy_power_supply_props), + .get_property =3D srt_psy_power_supply_get_property, +}; + +static char *battery_supplied_to[] =3D { "surface-rt-battery" }; + +static int srt_ec_probe(struct i2c_client *client) +{ + struct power_supply_config bat_cfg =3D {}; + struct power_supply_config psy_cfg =3D {}; + struct device *dev =3D &client->dev; + struct srt_ec_device *srt; + char str_buf[4]; + int ret; + + srt =3D devm_kzalloc(dev, sizeof(*srt), GFP_KERNEL); + if (!srt) + return -ENOMEM; + + i2c_set_clientdata(client, srt); + srt->client =3D client; + + srt->enable_gpiod =3D devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); + if (IS_ERR(srt->enable_gpiod)) + return dev_err_probe(dev, PTR_ERR(srt->enable_gpiod), + "failed to get enable gpio\n"); + + /* wait till EC is ready */ + usleep_range(1000, 1500); + + ret =3D i2c_smbus_read_word_data(client, REGW_SERIAL_NUMBER); + if (ret < 0) + return ret; + + srt->serial =3D devm_kasprintf(dev, GFP_KERNEL, "%04x", ret); + if (!srt->serial) + return -ENOMEM; + + ret =3D i2c_smbus_read_i2c_block_data(client, REGS_MANUFACTURER, + sizeof(srt->manufacturer) - 1, + srt->manufacturer); + if (ret < 0) + return ret; + + ret =3D i2c_smbus_read_i2c_block_data(client, REGS_MODEL_NAME, + sizeof(srt->model_name) - 1, + srt->model_name); + if (ret < 0) + return ret; + + ret =3D i2c_smbus_read_i2c_block_data(client, REGS_TECHNOLOGY, + sizeof(str_buf), str_buf); + if (ret < 0) + return ret; + + if (!strncmp(str_buf, "LION", 4)) + srt->technology =3D POWER_SUPPLY_TECHNOLOGY_LION; + else + srt->technology =3D POWER_SUPPLY_TECHNOLOGY_UNKNOWN; + + bat_cfg.drv_data =3D srt; + bat_cfg.fwnode =3D dev_fwnode(dev); + + srt->bat =3D devm_power_supply_register(dev, &srt_bat_power_supply_desc, + &bat_cfg); + if (IS_ERR(srt->bat)) + return dev_err_probe(dev, PTR_ERR(srt->bat), + "failed to register battery power supply\n"); + + psy_cfg.drv_data =3D srt; + psy_cfg.fwnode =3D dev_fwnode(dev); + psy_cfg.supplied_to =3D battery_supplied_to; + psy_cfg.num_supplicants =3D ARRAY_SIZE(battery_supplied_to); + + srt->psy =3D devm_power_supply_register(dev, &srt_psy_power_supply_desc, + &psy_cfg); + if (IS_ERR(srt->psy)) + return dev_err_probe(dev, PTR_ERR(srt->psy), + "failed to register AC power supply\n"); + + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, srt_psy_detect_= irq, + IRQF_ONESHOT, client->name, srt); + if (ret < 0) + return dev_err_probe(dev, ret, "failed to request interrupt\n"); + + ret =3D devm_delayed_work_autocancel(dev, &srt->poll_work, srt_bat_poll_w= ork); + if (ret < 0) + return ret; + + schedule_delayed_work(&srt->poll_work, HZ); + + return 0; +} + +static int srt_ec_suspend(struct device *dev) +{ + struct srt_ec_device *srt =3D dev_get_drvdata(dev); + + cancel_delayed_work_sync(&srt->poll_work); + + return 0; +} + +static int srt_ec_resume(struct device *dev) +{ + struct srt_ec_device *srt =3D dev_get_drvdata(dev); + + schedule_delayed_work(&srt->poll_work, HZ); + + return 0; +} + +static DEFINE_SIMPLE_DEV_PM_OPS(srt_ec_pm_ops, srt_ec_suspend, srt_ec_resu= me); + +static const struct of_device_id srt_ec_of_match[] =3D { + { .compatible =3D "microsoft,surface-rt-ec" }, + { } +}; +MODULE_DEVICE_TABLE(of, srt_ec_of_match); + +static struct i2c_driver srt_ec_driver =3D { + .driver =3D { + .name =3D "surface-rt-ec", + .of_match_table =3D srt_ec_of_match, + .pm =3D &srt_ec_pm_ops, + }, + .probe =3D srt_ec_probe, +}; +module_i2c_driver(srt_ec_driver); + +MODULE_AUTHOR("Jonas Schw=C3=B6bel "); +MODULE_DESCRIPTION("Surface RT Embedded Controller driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0