From nobody Tue May 26 04:49:45 2026 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E44D43EAC8A for ; Thu, 7 May 2026 10:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778151103; cv=none; b=NP+5GWTRwv8Prj8//Wvn4LfNVEhSnbTmGxnxkGh/+DKDVQWXLQrHzwkNYFCDcYsuBXTSbjbEYF1aifPVbU1MhCKKivUW5+IPJIWQ9Aml4FEi4QUF6bURf99bMOCa1rhjGXYst32//S9fNNP0erLcBx/g/oKl8XeAXQpTO2wb4Tc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778151103; c=relaxed/simple; bh=H08BrTRalR0jUvy/90S50ZaX5dzgHvM0nJcBr5ocsmg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VoNd/M000bCNOfLN120XMNUS2QdtC56SAOi2Q50FpQ9fXnzrnFRPmpkwza//7OAla2CO0wU+ljqyrOWz5+lxbYdsF2ZLEmPXBOezB8nHJ4Smj8OpuerVo9HzJ0ciYQA6k5aLh1GCFoZJUtt1KKOw/0UYmbBY7UGFAOyPUD7H+3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MucplbBL; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MucplbBL" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-39396f873adso7472581fa.3 for ; Thu, 07 May 2026 03:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778151092; x=1778755892; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qnRfUwgP4GDJT73gEU34kWTDXjMinDYaY8kcXfNdp88=; b=MucplbBL1HXTH2B1ifhGCkGpW6XfXqP+OQ9q4z2GywbDt+e2IUVpMI7ytOyu+Txjpy McvjV390u/wsh/OdqjPNt6ICPelGKK82U3N9tKuxXG2gJ91n1d+oam7HCL23OHhykmFS +mH50MnwE7rxcCQgJ1mff0JEAGeLjp3kAhB4m6tI9N3+ieYEcMYzUnUi34iLs9tx4k7F jVLDon9QRWbO4EIUZrrtIj7hofUCyjko7r8Vzjl04wITVCpH0Rwk9VKOUeyXrYnBqM5s hbmAYQ4+XFgIVu1TAoaM4hEMGs1ligshBOamPJGxKb05jtGlb2QVKgr24XD5CYOL4Z4D gspA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778151092; x=1778755892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qnRfUwgP4GDJT73gEU34kWTDXjMinDYaY8kcXfNdp88=; b=EEN6lzAP6QeP+3F4xPCDo2XRMC6aWavCzAnKKBe6YyJ3zRB6h9vsUp5stBz2W0ZR7H l9VcLcJrzQLLh7x3qZRl94YBEQYEdrJ+jODjTM+cbapKltZMVCfqfBBhrHWFpDrnDmS7 4FCLZB0ZTnoC3xFROxMSmadFmUPwpKtw9KC4DEA/MXYSgk5QvMBE367sK+jpXl0LbW2H 7La1UUVEWIkq+uXaBMEu8SaZPEC819YJj9+xTc+n4F5ElndKj5hIcECWo5rRZSWvpTDG jYGejAE3GignZVigJKrG1IEi5ozlDwHFNcuFefqvDAxiAOIN1coRXQBQC8udcm7+Rqu8 2zgA== X-Forwarded-Encrypted: i=1; AFNElJ+zhetAYuhugTT/oknDigqpWp2EeFnS3QZUra1IdBUscqVHAhf+u2CuXhfXjK/I/5+Syzpz72yF++fy08Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9u9HITgPqI15uv56h5x2jFFEQsWMlixQ4Z6sUL6/mJN9ueMsE KH20elN+y3ALWrVBUBtz/vmvt5DXe0oZ0ou3ovdgS2A6XWJvxfOLitUb X-Gm-Gg: AeBDieuxzN50tJPNBGAC+B4KQVENm464Bo80QBNVG9SFUfc197QkgsC0IXSdJxnFHYz KbDHwVf1Rq/RsglhagXrEyQT0n0qQDRNWTmIEo/BWzCpAo32xLkptXmI9aV6qbT5b9UPAFTYxwZ s479ltWZMnLClKObpcApqsCPZECCqWID5mmM9MdgCWMXgdReKUMspLx4NGEGph0PJwD9qfdxhNe I4RiWRIS+7mPqdpqQ5FPaMbOF1mBDtRNOsx1kKWuYpGOn5KgLwzHvRC7FAeHY0Mt022ctPXUnBa NgmV7MrAeLdPZY7RGE04DujCMq7yLZatfJyFNvfSdy4km6Y6cKp0e2M98iPUCLG6dFDFDY/W4Nt DKj8lA7pDREZUx35gvNWmj9OGLopZncfByhFCPN6l9kAFqrvLzMrN+cwaDEagZTlWX6QrLWdQ79 ZsA3gIpnYeo/DlPwF99PqBygCBItqb//sPkdvLLI/Hoh3fonlZY7gXtlec4+iW/XXzp/WnUsxRZ JLbLvfMCAEmY40FE/DpqQtO X-Received: by 2002:a05:6512:3404:b0:5a7:4ac2:70b4 with SMTP id 2adb3069b0e04-5a887cec860mr3152383e87.40.1778151091930; Thu, 07 May 2026 03:51:31 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c341848sm5530224e87.65.2026.05.07.03.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 03:51:31 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Md Shofiqul Islam , jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, mike.looijmans@topic.nl Subject: [PATCH v2 1/3] iio: adc: ti-ads1298: Add parentheses around macro parameter Date: Thu, 7 May 2026 13:51:26 +0300 Message-ID: <20260507105129.25639-2-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260507105129.25639-1-shofiqtest@gmail.com> References: <20260507105129.25639-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ADS1298_REG_CHnSET() is missing parentheses around the parameter 'n'. Add them to follow kernel macro coding style and prevent potential operator precedence issues if the argument is an expression. Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index ae30b47e45..cf5f954206 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -66,7 +66,7 @@ #define ADS1298_MASK_CONFIG3_VREF_4V BIT(5) =20 #define ADS1298_REG_LOFF 0x04 -#define ADS1298_REG_CHnSET(n) (0x05 + n) +#define ADS1298_REG_CHnSET(n) (0x05 + (n)) #define ADS1298_MASK_CH_PD BIT(7) #define ADS1298_MASK_CH_PGA GENMASK(6, 4) #define ADS1298_MASK_CH_MUX GENMASK(2, 0) --=20 2.54.0.windows.1 From nobody Tue May 26 04:49:45 2026 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B9D3ECBFD for ; Thu, 7 May 2026 10:51:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778151105; cv=none; b=Dv46cwb+RafPoy3EvZcnXRbQI8Op+rxt2tX5DF09ASv8bu9YbBXyb7+cpcHL4sbPRRwMrBvvWgy+a1eM53B+zSEUHwXqp8zjttI4soodKztRsRaGqVO7ZZ8DSlr7ydpsQRjjnodf1hdS0bp/I6xBk+uvTb0CZlLwC/qqLpiCk2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778151105; c=relaxed/simple; bh=7wwEeddHxhCClQzgwuisu1/1yJfMaAt2aMlXmyRxTYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mG3vMK12FkcXHeaEVJJQBMHgLs4SWKd0PcPwneoow7r9b/aMMuVQnRKMEWV+uD2J1gB63dSsZF+clO+hPRQ+EYIIBAy6wFXSbxyB6pDzmJYylHvvHAy0v9BoK6NxXFqEgyiP8b5MlwLmzeK9zPyVwEPRP0O2JOuD3cZpIH1au+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iwqiopdD; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iwqiopdD" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5a8891febd2so747291e87.1 for ; Thu, 07 May 2026 03:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778151093; x=1778755893; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4zF8aJYC8sIqGUROlbDSF6MUK4SPWjcto9OGe/HwWY=; b=iwqiopdD+35jsAzlLNJuDfX+FvyCRzVQ0maiISK8s9ZQmrkk+WjaGmC+JocKTkSpWE H0wHYGH/oUSnKI1RgIYprAkOR9swCGtXXfkALa4PpJiJrwZIoQ637CL3bNB0t0nFT+Ke PohHN+xNzuzrI7pWzS92z9DGocD1i8+gIM0066MU6cIiKtNyAkoGjGkFFIU4D5r3FDeT xzfYyYRzHw/ZEwPP+PpejW4YPlGqcTyCepiv0RlExJoHG/n0q/Wa8+QcCvkeQySWh+yd TCQQZBBHxzs1BR6P5QoWjhdfz9L2IFoUuX0Yk3GgOqBYnRE183IErLlmKHDBgbWzanOx KHHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778151093; x=1778755893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U4zF8aJYC8sIqGUROlbDSF6MUK4SPWjcto9OGe/HwWY=; b=EJet05+W6DiPG6Cz0+9JBcj+abBlFNsWBCuyJDr9iZw8yAwj4Yp2Hy17FsqglPpHIS HYZBnXvwdaliE1RMo9Go2CaphhMCN1ch6mSdDNQhWf8XqnuOfOOVG1f1QwdkAbVPgEhR CyCXJiZ+UYz207XrQ+gl0M+bf6GfgumwRkADJZBsduedDV5J2WMn1fik35dFFEPpaUp4 THXQMr+IQa4zZrd3difJVyHSl+FQK7DARmCHTt5w6gwEXtjNLxOfFQ32/u/63wS6s1Ah Su2oHkjUFWgLbmwOGDAk3CdkNQZ8o2iB/D5nq0h6W8vwOJixEM+NcwxILXY/a35/Y+6V GVmg== X-Forwarded-Encrypted: i=1; AFNElJ8oCPIgOeRv4eL0KChpGJSOFfx6nUelSB040tUDKbG3O1LRExaisdU4G8KDBncyBv/jsC6t9USBObuJ8Vs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv7D+u9cqtu4CaHvr7+6RDboOHk84/Y7YdkysACb9ci9Lc4YCe WJCh7B4Ag4fbgaM2qRa8Z+DvwtrMKDlO/I61lFtHL3mWfQ9GqnXa4YZv X-Gm-Gg: AeBDieufQ/bBXqCWMEGASSd2HxTkgzbSOsn/ES8VcTgfrvfiapUuk0aL7IvcgD3gAtI qOhfZWDiBiUM2BAChQANiPGgBmuDGK9VNThp1yA0C6dB0EA6SuVcYmOR7aqlm7YhC9vr5+lsmk+ TXgGs4O0vUwZF6v1aSD1x9t6tnET3FBWIDDFYZD+IC6CccwE+4N5wkLIq3dT54b5Wbv6bSStmhZ hE2o/DyyX572mXUycRm2HrcBTUzRrLaGjl7Y0uS3lCFzWxiIbClBzrBIw23Ihcq6o1krXrr5S4o 6C2bXlLqb1xQz+F6iDENY2Gvuo0UBI6lKrFpcLVDsvzFeASL72jUm+CQeFxv8QMqNa/vzDwK8lo ebrL6mwJfdatmlV38KSpGF0YUbhv+qr/7RyI6g5ayZu/4INVmhGd3HucrvsJQVaUGpYp8j3HO8i AcHTUGGI0SdiMo0UCbwkn1YjmVdv70wA+fEaEeoLymUxlszmEMs8YrwG/AbIUDSV3yfQPdTOVph Zk= X-Received: by 2002:a05:6512:1113:b0:5a8:99bd:12cc with SMTP id 2adb3069b0e04-5a899bd137fmr960708e87.28.1778151092648; Thu, 07 May 2026 03:51:32 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c341848sm5530224e87.65.2026.05.07.03.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 03:51:32 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Md Shofiqul Islam , jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, mike.looijmans@topic.nl Subject: [PATCH v2 2/3] iio: adc: ti-ads1298: Fix incorrect timeout comment Date: Thu, 7 May 2026 13:51:27 +0300 Message-ID: <20260507105129.25639-3-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260507105129.25639-1-shofiqtest@gmail.com> References: <20260507105129.25639-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" At the lowest supported data rate of 250Hz, one conversion period is 4ms, not 40ms. Fix the comment to correctly reflect the timing. The 50ms timeout value itself is correct as a conservative margin. Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index cf5f954206..186bda3087 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -210,7 +210,7 @@ static int ads1298_read_one(struct ads1298_private *pri= v, int chan_index) return ret; } =20 - /* Cannot take longer than 40ms (250Hz) */ + /* Cannot take longer than 4ms at the lowest rate (250Hz) */ ret =3D wait_for_completion_timeout(&priv->completion, msecs_to_jiffies(5= 0)); if (!ret) return -ETIMEDOUT; --=20 2.54.0.windows.1 From nobody Tue May 26 04:49:45 2026 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20EC33EBF36 for ; Thu, 7 May 2026 10:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778151107; cv=none; b=BgxMD14RIitsXTaZ13l8lrDr19Z+OAOTj+CGVNmoPPvNiaCB31QYHSRNwymEd4MOUEs3pAfq9IA1BBjeLXNCGLDcPnw14ZS7TjAUfTO+7d+Xyc5/yviv8kviQt3gASOFGk+HAiplrJtQvyvz23VUw1HDwF2vX8b63GyALNMXrgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778151107; c=relaxed/simple; bh=8be50cgUO97dUmyXY8QEaFaIeWcvbyn4FZHCMFnyX9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sQITeJWht056eF2WtJjpQ8sThCXSimwuumFKivmzw1GMs2vky2Elulj46KcenCIRZTLUyuZ0HxMoVO5JaFuxEnQUvf8Dkko1bYs02cRyxzgCveQE4zKNhNvlARpKnwfjGtpvQKiR2bBdjXMD98YeuXQUDyHJ7fcLIs0y9lXucu4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OLbQ/Kg2; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OLbQ/Kg2" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5a8891f0c51so594549e87.1 for ; Thu, 07 May 2026 03:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778151094; x=1778755894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iev/RaR7ebPD8/QuDYCOu2PRxG+LdvAV0DZxv0cI94U=; b=OLbQ/Kg2Ab1Nw7b0o9rhRmuhauZ2HaSuOpQfUpIj4uySDNFnH6CgGvD7Mc/sW4UXSV zV+0wktTQFDPHQN1GQkVRrrTvM5hC3a7VmaOe1DJBDAw5Gb7CFTut8FUJIK0ExxD6n2p zFzZ71TP3gMFPyHsjm6daHIVozdr5kTpJOlc87+4L+EiNmh6ozkF4XkmKtSbT5azqjrI SH+qQbQwCrQStYtmUCTuy2XjHd0c70+eBd2pl8a59pAMV3Ex/5CbPrnGGQoscp56HIDQ rm+UusqD98fRu1+xv7hkbw9THovkrquCas5W8T1Ilbu7KwNpvPtPhuwFaOJKFhiXgiLe BlGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778151094; x=1778755894; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Iev/RaR7ebPD8/QuDYCOu2PRxG+LdvAV0DZxv0cI94U=; b=qopn/oUaKOBQzB8FDCkvvQLUneO2FQXDo4wgXrMs8ma8ZbxVOcgu9XflVknEavuCQr AeVzJ2J7+80QuBZazCRFBQsoQ0EXsvjGjCJcst/EmmXy6BdJB7kaE8n/MO6FmyddX3Cu LqLcosEJ/nZ+1vrv3vn/TVoCT/mF4+uZ908tP6GQfI5Zhkm8nHHJqw6s9lQ19kFnIjnZ iae4uhKClcuzc3q/xWsdGSMBCvn9Zq9K86gJUrc/zqkcpdtrYj9O0WP83gqauz+ZEq/B qFBS1JQfMXNUTKyGQvjlTCVZREsdYj8T5uWAGadG/mbSNWwVLMlDzDrYtwEUz0MTXXlw FWag== X-Forwarded-Encrypted: i=1; AFNElJ/D74P/a5Q4h+D4sZ6cNYt0YKKcYrSZopeq9RaQJ6U1ph5z/g3E0gIuombyKoZw9Ot1/wwJ3qt5+q2/Xvk=@vger.kernel.org X-Gm-Message-State: AOJu0YzGsyWZpiNH+dZbDg3yBHPMosFcu1WrAw71CU8E5pyCho1Kpc/9 YFJxITUpU9eunb/4ksTN+70jfbwk+TYNiMqSB1HfDUvttna0H6c88YyD X-Gm-Gg: AeBDieuJSIg/gDABG1mssRc8gQ6BNdU+xyLlLI3kADu8/UXMyPe40D9hvj18oCzeYsC ZFKq/8QvTIy8A/TA2wu3ppn1pW/PX4heKLq5dOZzK5o45tnFEGeQk/WXVNmOG0XvwbobxvFCpje KU7ur3t6I0Eb13vCBrlTcitXhjci8mhgZr88f9mkRLdNfmBSai7kxUx2o8TrivoN5NWLytyu7qT hpGoZe8rZAexmi5ySuZrY4Hn9jxGrYhnkJ/VRcmMy0KwyFv2QlOMmMDvzbzYENFgbjcVktuJpay S7Kaw+aJ9eNtDRQZJoYVFDMBZr9NO2l189LMTDHXoZWExlG1w0AmWLllyR0cbTrmpopEGuOqA2r oGkMCJsn+W2k7vcAi7yNgL5tXcHY3oLKUclmheZbGSQkgs/EGbY8KByDxa0Lg6+XNWjYxVa/AC1 f6005Vii60nVh8Uj202OFjX8ohZ8sUsC6MC1eoXnNAIwE9St4YK/U8pQn+uxjToBJQfmy4V7ZZ2 No= X-Received: by 2002:a05:6512:682:b0:5a8:7d6c:8b82 with SMTP id 2adb3069b0e04-5a887add82fmr2719997e87.7.1778151093418; Thu, 07 May 2026 03:51:33 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c341848sm5530224e87.65.2026.05.07.03.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 03:51:33 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Md Shofiqul Islam , jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, mike.looijmans@topic.nl Subject: [PATCH v2 3/3] iio: adc: ti-ads1298: Remove unnecessary CONFIG2 write during init Date: Thu, 7 May 2026 13:51:28 +0300 Message-ID: <20260507105129.25639-4-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260507105129.25639-1-shofiqtest@gmail.com> References: <20260507105129.25639-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver was enabling the internal test signal (INT_TEST), double amplitude (TEST_AMP), and fast frequency (TEST_FREQ_FAST) bits in CONFIG2 during initialization. These bits activate an internal square wave generator intended for device testing and calibration, not normal ECG operation. CONFIG2 defaults to having only the RESERVED bit set after reset, which is the correct value for normal operation. Remove the write entirely since it would just be writing the reset default value. Suggested-by: Mike Looijmans Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index 186bda3087..8957e873e1 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -615,15 +615,6 @@ static int ads1298_init(struct iio_dev *indio_dev) if (!indio_dev->name) return -ENOMEM; =20 - /* Enable internal test signal, double amplitude, double frequency */ - ret =3D regmap_write(priv->regmap, ADS1298_REG_CONFIG2, - ADS1298_MASK_CONFIG2_RESERVED | - ADS1298_MASK_CONFIG2_INT_TEST | - ADS1298_MASK_CONFIG2_TEST_AMP | - ADS1298_MASK_CONFIG2_TEST_FREQ_FAST); - if (ret) - return ret; - val =3D ADS1298_MASK_CONFIG3_RESERVED; /* Must write 1 always */ if (!priv->reg_vref) { /* Enable internal reference */ --=20 2.54.0.windows.1