From nobody Sat Jun 13 13:02:35 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E62393D4116 for ; Thu, 7 May 2026 10:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148792; cv=none; b=Bm1VOamMnM1g0AvV+uzUJaPJlyNJd/9EQ49Ez3YPoaaYeiyS7OL/GguhQugD2uB5xoYCmCgXjWEoXIoqqdSAgkS5NvHjiWrq4Ww9yNNj4hOs4+eTCaalrOvLdbWuCKP5DftyAx2fXSDUGsIbH8DdkWKqzSQPObS9DtMMY9OPHsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148792; c=relaxed/simple; bh=6KYWZrOtJuCtmkc6oXa80aIw5oQTa7O99g3ALeNngJI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X22vFnb6bNpVfqCSSgBFEfp4D1vUQE85GJ5fOC1n1QFOI4ll6YOTTedbLvKx4qvOFCW9DV8TR35Qp21rphCHUHIE43XPkPHTkFDwl6JbMLtIZlFDOwGjbIe09eoWBxjq/TZPHoJAo1rU+U2UnI0ceIS8y611esadV9OCc0Tc0v8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=diKidr2i; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="diKidr2i" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-83537a80ab6so355929b3a.1 for ; Thu, 07 May 2026 03:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778148790; x=1778753590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LxZbT380K0M24w7y1BCiVavbwUG7hQkkQTnQDue/tio=; b=diKidr2iIo4HgczVBRXY8n2yLdEhgwAALKwDHiLVbSGQqjrLGY0Sqv7cN6uiQVm6jq TsORaGil4Os5vweyyC46HmUh3SSSeLd4xqwJf+Mv+acve77gL7ykwMsQPXg2aOByHL9y zmmpKZ+2hwDHZN2+cZGa7VVnVfNoxseAqVkTpkmCq1SvPocQDQq13HK0z7GRbRpm7Mje +uWE/S1vwQIfvdyNsL/T1lyjUQGcZuGt24TInWnvQemxjwxFW6ZK6ln6ycaL8Z9q+v60 oZctszBZ/eviLXsr+44+kSqD0sHuqh8b9s/o+m/Uf/EsIbMde0l1BWOozLdgZBBriET1 xahw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778148790; x=1778753590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LxZbT380K0M24w7y1BCiVavbwUG7hQkkQTnQDue/tio=; b=fCNlahyDfhuQPLhATc0vc4CczgLqFmwJyQ19/UdOKu8XKQoYJsui+ZIBQnR+NS9irK GtpwGGwyq+4H3pRsqPFIPuS9LEO3HTt6DwuXkocCfIEBaWCnduYB3/cZS+NY7K/eQFTv GSiAadYbmqiu3JBISC3Mhpe22jg6sw3FbdTW6agVeM9ok1i7GOSDvX4IbSBwqj2NSING SmOsUtaAJdd+yTukB7+TBrAWoHkcXzhAlZgkdcn2G490tZvmd1GtM/vvSwLxB7kmiwLv gah1B3CQoYrudt51dlVGbpnLxiRcibnpv0rnG4Zihx46tXbw7mVRMq+ca+3CQVRSp3AI EpGg== X-Forwarded-Encrypted: i=1; AFNElJ/zQqq2Nt/xqnu7xnvn7PE92sRUTeNWPkLm364YQBi4jrZwilA56bkF6PG6TxKypsWRpzkeybON6ehkB58=@vger.kernel.org X-Gm-Message-State: AOJu0YzwzP9UpE2q4FFEeAw8ewRrKWAQ+BRM6ZCleMt6WK35gJIb+5jQ vFqcqOdc36BbdkpoWpN0In8SgnwqaQHJJifS7EpTVjCzY8MFQIcnhv/K X-Gm-Gg: AeBDievjwFVldG+GH4LBhPPGMIc0zvnmN0xZQpRr1tk98TJ1ipf5O+TR/XJDQgoxs8M Ulac66dULDL/PrK3/1ZktjAwz4gTltU0tQTOglgFpdvkqnhQ9W3YYSyYGKvfMYnMjQEaX3dQyf6 o/2ahuKXa1/QUJ2tyYVKPAoxCiMqBydJL8KNlKsIn1dnOEK4kuZsqQzUD3wt32c8QopdUTZWhTw x54ZEiAUcZVg8Fwpz/nzIA1YMWqUEUVrPkHTP6RjbN8quzsqXhGGxW0vcffs7TMOqmoi9EhBrT9 v57Aq66qcwk06B3CLc7/MK/ET01hczFBm8INXcHr0fbriIGp5etqA9+w6g9hc/01HI9b0a9f/dN rzLGjSi70umlh42FnRP1lP9SY0eYtsAQra/IMZUk8fKLnAkX5TNLMX6x3PIWglmSdaOog9FXQD9 9vAuwSLg27x3CwGBEFh9mTfFIUKbOH5SsBQuyIFI78yANdC1ebUK1DoOT5kZfchXPsFbczgpQtn nu2nn5yN7hbfzxOahY= X-Received: by 2002:a05:6a00:3695:b0:835:cc47:6ff9 with SMTP id d2e1a72fcca58-83a5dd5c829mr7121074b3a.28.1778148789864; Thu, 07 May 2026 03:13:09 -0700 (PDT) Received: from fedora ([103.181.54.100]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83967dbcf16sm9797998b3a.40.2026.05.07.03.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 03:13:09 -0700 (PDT) From: Ninad Naik To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-kernel-mentees@lists.linux.dev, Ninad Naik Subject: [PATCH 1/3] hwmon: lm93: Add missing blank lines after declarations Date: Thu, 7 May 2026 15:41:41 +0530 Message-ID: <20260507101143.559475-2-ninadnaik07@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260507101143.559475-1-ninadnaik07@gmail.com> References: <20260507101143.559475-1-ninadnaik07@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warning by adding blank lines after variable declaration. No functional changes are made. Signed-off-by: Ninad Naik --- drivers/hwmon/lm93.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/hwmon/lm93.c b/drivers/hwmon/lm93.c index be4853fad80f..c15e2a02dd86 100644 --- a/drivers/hwmon/lm93.c +++ b/drivers/hwmon/lm93.c @@ -372,6 +372,7 @@ static u8 LM93_IN_TO_REG(int nr, unsigned val) const long intercept =3D uv_min - slope * lm93_vin_reg_min[nr]; =20 u8 result =3D ((uv - intercept + (slope/2)) / slope); + result =3D clamp_val(result, lm93_vin_reg_min[nr], lm93_vin_reg_max[nr]); return result; @@ -383,6 +384,7 @@ static unsigned LM93_IN_REL_FROM_REG(u8 reg, int upper,= int vid) const long uv_offset =3D upper ? (((reg >> 4 & 0x0f) + 1) * 12500) : (((reg >> 0 & 0x0f) + 1) * -25000); const long uv_vid =3D vid * 1000; + return (uv_vid + uv_offset + 5000) / 10000; } =20 @@ -397,6 +399,7 @@ static unsigned LM93_IN_REL_FROM_REG(u8 reg, int upper,= int vid) static u8 LM93_IN_REL_TO_REG(unsigned val, int upper, int vid) { long uv_offset =3D vid * 1000 - val * 10000; + if (upper) { uv_offset =3D clamp_val(uv_offset, 12500, 200000); return (u8)((uv_offset / 12500 - 1) << 4); @@ -425,6 +428,7 @@ static int LM93_TEMP_FROM_REG(u8 reg) static u8 LM93_TEMP_TO_REG(long temp) { int ntemp =3D clamp_val(temp, LM93_TEMP_MIN, LM93_TEMP_MAX); + ntemp +=3D (ntemp < 0 ? -500 : 500); return (u8)(ntemp / 1000); } @@ -582,6 +586,7 @@ static int LM93_PWM_FROM_REG(u8 reg, enum pwm_freq freq) static u8 LM93_PWM_TO_REG(int pwm, enum pwm_freq freq) { int i; + for (i =3D 0; i < 13; i++) if (pwm <=3D lm93_pwm_map[freq][i]) break; @@ -632,6 +637,7 @@ static int LM93_PWM_FREQ_FROM_REG(u8 reg) static u8 LM93_PWM_FREQ_TO_REG(int freq) { int i; + for (i =3D 7; i > 0; i--) if (freq <=3D lm93_pwm_freq_map[i]) break; @@ -657,6 +663,7 @@ static int LM93_SPINUP_TIME_FROM_REG(u8 reg) static u8 LM93_SPINUP_TIME_TO_REG(int time) { int i; + for (i =3D 0; i < 7; i++) if (time <=3D lm93_spinup_time_map[i]) break; @@ -710,6 +717,7 @@ static int LM93_INTERVAL_FROM_REG(u8 reg) static u8 LM93_INTERVAL_TO_REG(long interval) { int i; + for (i =3D 0; i < 9; i++) if (interval <=3D lm93_interval_map[i]) break; @@ -772,6 +780,7 @@ static unsigned LM93_GPI_FROM_REG(u8 reg) static unsigned LM93_ALARMS_FROM_REG(struct block1_t b1) { unsigned result; + result =3D b1.host_status_2 & 0x3f; =20 if (vccp_limit_type[0]) @@ -1104,6 +1113,7 @@ static ssize_t in_show(struct device *dev, struct dev= ice_attribute *attr, int nr =3D (to_sensor_dev_attr(attr))->index; =20 struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_IN_FROM_REG(nr, data->block3[nr])); } =20 @@ -1259,6 +1269,7 @@ static ssize_t temp_show(struct device *dev, struct d= evice_attribute *attr, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_TEMP_FROM_REG(data->block2[nr])); } =20 @@ -1271,6 +1282,7 @@ static ssize_t temp_min_show(struct device *dev, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_TEMP_FROM_REG(data->temp_lim[nr].min)); } =20 @@ -1304,6 +1316,7 @@ static ssize_t temp_max_show(struct device *dev, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_TEMP_FROM_REG(data->temp_lim[nr].max)); } =20 @@ -1337,6 +1350,7 @@ static ssize_t temp_auto_base_show(struct device *dev, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_TEMP_FROM_REG(data->block10.base[nr])); } =20 @@ -1370,6 +1384,7 @@ static ssize_t temp_auto_boost_show(struct device *de= v, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_TEMP_FROM_REG(data->boost[nr])); } =20 @@ -1405,6 +1420,7 @@ static ssize_t temp_auto_boost_hyst_show(struct devic= e *dev, int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); int mode =3D LM93_TEMP_OFFSET_MODE_FROM_REG(data->sfc2, nr); + return sprintf(buf, "%d\n", LM93_AUTO_BOOST_HYST_FROM_REGS(data, nr, mode)); } @@ -1447,6 +1463,7 @@ static ssize_t temp_auto_offset_show(struct device *d= ev, int ofs =3D s_attr->nr; struct lm93_data *data =3D lm93_update_device(dev); int mode =3D LM93_TEMP_OFFSET_MODE_FROM_REG(data->sfc2, nr); + return sprintf(buf, "%d\n", LM93_TEMP_AUTO_OFFSET_FROM_REG(data->block10.offset[ofs], nr, mode)); @@ -1525,6 +1542,7 @@ static ssize_t temp_auto_pwm_min_show(struct device *= dev, int nr =3D (to_sensor_dev_attr(attr))->index; u8 reg, ctl4; struct lm93_data *data =3D lm93_update_device(dev); + reg =3D data->auto_pwm_min_hyst[nr/2] >> 4 & 0x0f; ctl4 =3D data->block9[nr][LM93_PWM_CTL4]; return sprintf(buf, "%d\n", LM93_PWM_FROM_REG(reg, (ctl4 & 0x07) ? @@ -1570,6 +1588,7 @@ static ssize_t temp_auto_offset_hyst_show(struct devi= ce *dev, int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); int mode =3D LM93_TEMP_OFFSET_MODE_FROM_REG(data->sfc2, nr); + return sprintf(buf, "%d\n", LM93_TEMP_OFFSET_FROM_REG( data->auto_pwm_min_hyst[nr / 2], mode)); } @@ -1921,6 +1940,7 @@ static ssize_t pwm_auto_channels_show(struct device *= dev, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", data->block9[nr][LM93_PWM_CTL1]); } =20 @@ -2000,6 +2020,7 @@ static ssize_t pwm_auto_spinup_time_show(struct devic= e *dev, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_SPINUP_TIME_FROM_REG( data->block9[nr][LM93_PWM_CTL3])); } @@ -2035,6 +2056,7 @@ static ssize_t pwm_auto_prochot_ramp_show(struct devi= ce *dev, struct device_attribute *attr, char *buf) { struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_RAMP_FROM_REG(data->pwm_ramp_ctl >> 4 & 0x0f)); } @@ -2067,6 +2089,7 @@ static ssize_t pwm_auto_vrdhot_ramp_show(struct devic= e *dev, struct device_attribute *attr, char *buf) { struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_RAMP_FROM_REG(data->pwm_ramp_ctl & 0x0f)); } @@ -2100,6 +2123,7 @@ static ssize_t vid_show(struct device *dev, struct de= vice_attribute *attr, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_VID_FROM_REG(data->vid[nr])); } =20 @@ -2111,6 +2135,7 @@ static ssize_t prochot_show(struct device *dev, struc= t device_attribute *attr, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", data->block4[nr].cur); } =20 @@ -2122,6 +2147,7 @@ static ssize_t prochot_avg_show(struct device *dev, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", data->block4[nr].avg); } =20 @@ -2133,6 +2159,7 @@ static ssize_t prochot_max_show(struct device *dev, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", data->prochot_max[nr]); } =20 @@ -2168,6 +2195,7 @@ static ssize_t prochot_override_show(struct device *d= ev, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", (data->prochot_override & prochot_override_mask[nr]) ? 1 : 0); } @@ -2206,6 +2234,7 @@ static ssize_t prochot_interval_show(struct device *d= ev, int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); u8 tmp; + if (nr =3D=3D 1) tmp =3D (data->prochot_interval & 0xf0) >> 4; else @@ -2248,6 +2277,7 @@ static ssize_t prochot_override_duty_cycle_show(struc= t device *dev, char *buf) { struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", data->prochot_override & 0x0f); } =20 @@ -2279,6 +2309,7 @@ static ssize_t prochot_short_show(struct device *dev, struct device_attribute *attr, char *buf) { struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", (data->config & 0x10) ? 1 : 0); } =20 @@ -2312,6 +2343,7 @@ static ssize_t vrdhot_show(struct device *dev, struct= device_attribute *attr, { int nr =3D (to_sensor_dev_attr(attr))->index; struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", data->block1.host_status_1 & (1 << (nr + 4)) ? 1 : 0); } @@ -2323,6 +2355,7 @@ static ssize_t gpio_show(struct device *dev, struct d= evice_attribute *attr, char *buf) { struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_GPI_FROM_REG(data->gpi)); } =20 @@ -2332,6 +2365,7 @@ static ssize_t alarms_show(struct device *dev, struct= device_attribute *attr, char *buf) { struct lm93_data *data =3D lm93_update_device(dev); + return sprintf(buf, "%d\n", LM93_ALARMS_FROM_REG(data->block1)); } =20 --=20 2.54.0 From nobody Sat Jun 13 13:02:35 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8298C3D646E for ; Thu, 7 May 2026 10:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148797; cv=none; b=ivj+MKFf0cf0DsHeJNaFqVDODugwvqqMPc+KGWs/f8lBRLt8ztf7a/nXfLOM0nyCAL/Zd20eJfjyBnUNPiQ8UFu2EbkLJ8IYY5XBFSkhxx3B4wJj2mqRjfEWJJ+HkWHR8bD9jR4mOlKHRC+4Mp40kRTT2M1RQ2Ok6nS1UXauIbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148797; c=relaxed/simple; bh=clTKCOBUcKKX0FwWohGCq2g/AFG/7UR6di+XJsvqHnM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EVA/7Z9eiK5L124nNhkQQomvLodgzMEZuu8/1SDTQxgKXqpo699462RACS0tFe7Zxq/m1+7DcMmxAAZHsYiC/TEHcifM+GuANADI/Er4JtnadOofydycrLV4TVFl2fGoY6kbEbSRY41fHvrFtRaqdN2VAaiECmv/kZqaMztqB9I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TKGNBIjO; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TKGNBIjO" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-824c9da9928so245323b3a.3 for ; Thu, 07 May 2026 03:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778148795; x=1778753595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MYskE9BUqqox/U6JdrYHEc52UZOzahoWEH2vbpdJhlU=; b=TKGNBIjONMNP0LSBa/dxKnZ/ktefSaIxuPgquDuUwJnATZzzXtsAMFmoPiJ5gEfYF5 1oep1r7aY2YbFTm7XE/Rk3oZYYLWFTOvjZtkOmfZYjUjdb/dqk4AdEofQa7aMgNDg2Dy Y7YD2nWFKDzKKAv7O7OBVZDTEnem3gHwp5hcTjXWiZkTZNwaQQPb84V9U4P9e1StNzom qrSPxtX+bhSgQS7aQUS9EcWD9aMDmZjFR94l97DcU9zkkQyFUk4ZyUeAwvykBzorv3eK abQZOU/9T41OqTV0EOcH4797hqbrIwK+hGRYbS3/wSx3jneY5MYAzsc4Lq9GODCFHpHe UoOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778148795; x=1778753595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MYskE9BUqqox/U6JdrYHEc52UZOzahoWEH2vbpdJhlU=; b=eGkkrS6No7/7uvw5vCT4z5H25or7I2Alvu0c+yKpqt83NyM8ELFW+YoqkkmrrxiKxd Pjs0xgBrkt9YY2ach257Iefim8telwIB0T81PHLK4nKqIgG8VQtmI6L1bt4O0cC7qRJ2 MvJKNHeBG1bpBPjgW+1dZkVA0SumkWS3g0bazGq1NQznYmr2o1+KNZST8tPcl0/dgnZL GRU4fyDdXF3sSRPPbI6HKc398kgyNFL7SnuqJtkGDgfk0I9occ7JsOsNC8/X216Bz2LJ 5ScaTXnDNgBoqhaY1hN7cVl2NiTsqchcJUx5qpmjPEwt0tOrnylDsXwwV+VXMABIIg2t wnwg== X-Forwarded-Encrypted: i=1; AFNElJ94tHceyMFjFKIXMCJhic0v38LX5Et4iwwwj6eyw/iVcwAjtQKJLMfiRURsigLALBdalU8UlG9Na1YCVqw=@vger.kernel.org X-Gm-Message-State: AOJu0YzXSvl6/7lZjWk47uRnyZpmkUkF7XXvJj6iohC6QGe5qt1NLjxc VjUREr1IDyvjrpR5s8nQDPNzGDcGbqXWVns0lVNGiFePfUk4Cr5RS/o4 X-Gm-Gg: AeBDietvmfs4LQ95pRHdBifEkjplfD99HOgKKyla6EadWxsUi3GpIOfrMn4fWOxSE80 lCh7xuN/kwrVFwunm06fXPp1v7/Ab6olp78pg6S53VocCl77KJICI3sMDZp2TBk+u+m7xVbzbOD zcoE7DKoUoHy+MbebhDk/jOC+NY7h4j9nS9HgcFH8ofRybbWZvycqQOAfbBx0/9vJ4z0sd1adJx 5f8eNeo0QpOzJBL+G3LNx3n6LDmVu3m4mw1cydAaDohxpPqHRuHtIFslBB9nSazkmmqR/5rvP0y ZE5HebqGBh61acQdYz0QZlfrCSJ1myXZ/T2/o4l/BVdxDDAYBnNYkd0yFqUdauCgBycVvOSgswn FE1yqxA5CXnK+5zjPa7gT6fYpf1hJh/+fRrNf6F5HBjF5tLloA0b3vjD/bXrM4qe2dY2ZmWU09B V0TSG7uaUzc90N+R+OD7n1NvqeYOfr93KHotlXJ5CLRQ5bwyQdyEtGgSHf83uEpSXxY4ayia3oW YrkmdtWe+Zn3pw3XHXkcIV26TAMHA== X-Received: by 2002:a05:6a00:6c95:b0:82c:eb46:acb9 with SMTP id d2e1a72fcca58-83a5d3875a0mr6479595b3a.24.1778148794764; Thu, 07 May 2026 03:13:14 -0700 (PDT) Received: from fedora ([103.181.54.100]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83967dbcf16sm9797998b3a.40.2026.05.07.03.13.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 03:13:14 -0700 (PDT) From: Ninad Naik To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-kernel-mentees@lists.linux.dev, Ninad Naik Subject: [PATCH 2/3] hwmon: lm93: Change unsigned to unsigned int for clarity Date: Thu, 7 May 2026 15:41:42 +0530 Message-ID: <20260507101143.559475-3-ninadnaik07@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260507101143.559475-1-ninadnaik07@gmail.com> References: <20260507101143.559475-1-ninadnaik07@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warning by changing unsigned to unsigned int for clarity and to follow latest kernel code style. No functional changes are made. Signed-off-by: Ninad Naik --- drivers/hwmon/lm93.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/hwmon/lm93.c b/drivers/hwmon/lm93.c index c15e2a02dd86..1a3b5da924b2 100644 --- a/drivers/hwmon/lm93.c +++ b/drivers/hwmon/lm93.c @@ -339,7 +339,7 @@ static const unsigned long lm93_vin_val_max[16] =3D { * }; */ =20 -static unsigned LM93_IN_FROM_REG(int nr, u8 reg) +static unsigned int LM93_IN_FROM_REG(int nr, u8 reg) { const long uv_max =3D lm93_vin_val_max[nr] * 1000; const long uv_min =3D lm93_vin_val_min[nr] * 1000; @@ -355,7 +355,7 @@ static unsigned LM93_IN_FROM_REG(int nr, u8 reg) * IN: mV, limits determined by channel nr * REG: scaling determined by channel nr */ -static u8 LM93_IN_TO_REG(int nr, unsigned val) +static u8 LM93_IN_TO_REG(int nr, unsigned int val) { /* range limit */ const long mv =3D clamp_val(val, @@ -379,7 +379,7 @@ static u8 LM93_IN_TO_REG(int nr, unsigned val) } =20 /* vid in mV, upper =3D=3D 0 indicates low limit, otherwise upper limit */ -static unsigned LM93_IN_REL_FROM_REG(u8 reg, int upper, int vid) +static unsigned int LM93_IN_REL_FROM_REG(u8 reg, int upper, int vid) { const long uv_offset =3D upper ? (((reg >> 4 & 0x0f) + 1) * 12500) : (((reg >> 0 & 0x0f) + 1) * -25000); @@ -396,7 +396,7 @@ static unsigned LM93_IN_REL_FROM_REG(u8 reg, int upper,= int vid) * upper also determines which nibble of the register is returned * (the other nibble will be 0x0) */ -static u8 LM93_IN_REL_TO_REG(unsigned val, int upper, int vid) +static u8 LM93_IN_REL_TO_REG(unsigned int val, int upper, int vid) { long uv_offset =3D vid * 1000 - val * 10000; =20 @@ -730,7 +730,7 @@ static u8 LM93_INTERVAL_TO_REG(long interval) * GPIO: 0-255, GPIO0 is LSB * REG: inverted */ -static unsigned LM93_GPI_FROM_REG(u8 reg) +static unsigned int LM93_GPI_FROM_REG(u8 reg) { return ~reg & 0xff; } @@ -777,9 +777,9 @@ static unsigned LM93_GPI_FROM_REG(u8 reg) #define LM93_ALARM_TEMP2 0x20000000 #define LM93_ALARM_TEMP3 0x40000000 =20 -static unsigned LM93_ALARMS_FROM_REG(struct block1_t b1) +static unsigned int LM93_ALARMS_FROM_REG(struct block1_t b1) { - unsigned result; + unsigned int result; =20 result =3D b1.host_status_2 & 0x3f; =20 --=20 2.54.0 From nobody Sat Jun 13 13:02:35 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 390743D6CB3 for ; Thu, 7 May 2026 10:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148804; cv=none; b=u8fv0txtIpNKFX+4dV6BWGR/I9BDSac0ryQKHbJXs1xr/7TNTbE1JknglCuwHjY1haLHY0OJP7/quIOqsrLF5P0VGETIB1CsG4g48WZt7ry+puQdiDQKFj0U/qSj1vxjtPcsO8Ad4vRodjSRj1uClAO+WjN2rQiRW1P+K1TxnyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148804; c=relaxed/simple; bh=k4GyIjdLbYgaUSdzQuPr/Z0UMqJ70IDsVBrK35Vp1n4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bYAJ5UCnI2yLMttQlIV/XUHTLGSBZ/y6NvqiyFdwYMgDjI9uYdS4CmHVKet1BEXqTfbWchPsBLeOELGRntv2b/FWaEheUq5/mneg3RarqlrbkeGeMvTJQ6DAcoXkjaoD8UKfPyrAm+YwkdvpaUouBqFbo66JNrnQYQIfONxP8Eo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a38Q85rs; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a38Q85rs" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8379e010b01so229852b3a.1 for ; Thu, 07 May 2026 03:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778148800; x=1778753600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dy+ItK45HyR1sGSCwF/1GxRLdvnupH/Yv9vU0vjlJL0=; b=a38Q85rs02MMW6z2x+MSkYGyytmO2Vm95yBvUTq0H2V5z152fHixYOqnld6MLeo9mo PV3ROwMMKnlF0NngQSnopt18YSHKC9HsYBhYYTbBr/3I0N2vDSaD7smxrrURjhGSbD4K Ndvc2xwULJ76ZGx+zlTWXQ81ttiFk8yGAwSTkSuAtIGbiSUBm9OrjH90W+er+V+fPfm6 ogTKywO7A3EcnufNSIT4DntzFNP5ft1AB07EcjT3jzaUFy4V4WyMPuBa/wxowL0ZJ2QR fcYgBg9smhMCKnNERMuPMXDuLcgCkfRNtI16vFMlBcLAlLZAuKSj+iWnQ/ftlPwz2rVh 2zCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778148800; x=1778753600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dy+ItK45HyR1sGSCwF/1GxRLdvnupH/Yv9vU0vjlJL0=; b=Ujd9OHe1E212yE2aXZcMkU2BsjWWOVy6kzTFUfSva2bp4OTHZD5hcFrNG+M8I1skhx yEwXmsUVwZhYld9bx3Uf4V3xOmF/giXUIs50FcArRuDETihv99edxlitq2PX8YARqat2 DhqgvjnNXrNzyK26bPpboYfyj/neKxQPjnstLN9c8vbj43L0OKvT+hxDDl4sjT32aY1H +DOWa0/AaP/Wv3aCNgYYYy2FMl+wkmTxMIDhAseysJAJxtfHg+x3+7cqIPmR7i/1BZnh PQd5j7mQGlXZr37nJhVxqRybb3mdMnEaXnDO1KX6kM8TUwQ27EH5C7jNvZlXRmC6GD0D g2kg== X-Forwarded-Encrypted: i=1; AFNElJ+1FeW3uwGSQnDoPEgHzVl8/LyVecOjrZ3QxZ5YKwykTFjsDyv6u7lABu8dkdFA6lU4P7ngVvm6G/6c9GA=@vger.kernel.org X-Gm-Message-State: AOJu0YzFD94sbpA/ngdovofySPrjlxjQhQwPJg2xTxirWiCY4dTtztPJ 93S28OsmHP2fOzXIkFaUzSvruaNfudzP/rLuWKy0Z8FPWX0PJEPUXY9m X-Gm-Gg: AeBDies377l5Y2DxXNohdzOS8zf93z2GIqvpSNXDK6/HQSQvrB8/Y2Z5pipnklqpAJ0 IfB+e/q5uqQSH+dG7R2iqOkNq7f0M7Ci/Y5VMlMRyj+mP2EfQeGYR+IpDdldOaGDHP5SaPJioWr pQUV62WH5lvqlvkObCFHC9iVAOroOYO4Z+yytaR9l1G+8Tgolx7dmiVxeVH2pBLU87N/N/UILm2 /+QwR5jMfIMLl4u2TW/7sV7vmhRdCf+zVKTfsuHJL8+Lar86h5nZFkFf2J63QqmUdVIF2lpAtR0 PhA+vZCCXSc4n40Y792v6xedWLLF3Eli80poPZ+8RItL309Hw5ojokXcZTMcb3syit+Kq2yxRcy cTeffF3Cbqy35K6m7XdfK2EVZHuSdqqwNF3M0NC22flxarQE4MrnDBDNMNuj3Ovj6Ql55XpJNe7 klc4P9ofazFXrAVjemwyYL4yC3UIVAeis+qOSIa7MsuNeJrwcZ/u2BlFELyvFI2wG9I95pBHsHh /q9UiOBSXKC0Y5Ye0hBcWgLZd0K2g== X-Received: by 2002:a05:6a00:4516:b0:81f:852b:a925 with SMTP id d2e1a72fcca58-83a5b2d2c8cmr6536577b3a.1.1778148799952; Thu, 07 May 2026 03:13:19 -0700 (PDT) Received: from fedora ([103.181.54.100]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83967dbcf16sm9797998b3a.40.2026.05.07.03.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 03:13:19 -0700 (PDT) From: Ninad Naik To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-kernel-mentees@lists.linux.dev, Ninad Naik Subject: [PATCH 3/3] hwmon: lm93: Remove else blocks after break or return for consistency Date: Thu, 7 May 2026 15:41:43 +0530 Message-ID: <20260507101143.559475-4-ninadnaik07@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260507101143.559475-1-ninadnaik07@gmail.com> References: <20260507101143.559475-1-ninadnaik07@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warnings by removing multiple else blocks after break or return statement to follow latest kernel code style. Compiled the file and verified the changes. No functional changes are made. Signed-off-by: Ninad Naik --- drivers/hwmon/lm93.c | 39 +++++++++++++++------------------------ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/drivers/hwmon/lm93.c b/drivers/hwmon/lm93.c index 1a3b5da924b2..ddc4c4377128 100644 --- a/drivers/hwmon/lm93.c +++ b/drivers/hwmon/lm93.c @@ -403,10 +403,9 @@ static u8 LM93_IN_REL_TO_REG(unsigned int val, int upp= er, int vid) if (upper) { uv_offset =3D clamp_val(uv_offset, 12500, 200000); return (u8)((uv_offset / 12500 - 1) << 4); - } else { - uv_offset =3D clamp_val(uv_offset, -400000, -25000); - return (u8)((uv_offset / -25000 - 1) << 0); } + uv_offset =3D clamp_val(uv_offset, -400000, -25000); + return (u8)((uv_offset / -25000 - 1) << 0); } =20 /* @@ -811,15 +810,12 @@ static u8 lm93_read_byte(struct i2c_client *client, u= 8 reg) /* retry in case of read errors */ for (i =3D 1; i <=3D MAX_RETRIES; i++) { value =3D i2c_smbus_read_byte_data(client, reg); - if (value >=3D 0) { + if (value >=3D 0) return value; - } else { - dev_warn(&client->dev, + dev_warn(&client->dev, "lm93: read byte data failed, address 0x%02x.\n", reg); - mdelay(i + 3); - } - + mdelay(i + 3); } =20 /* what to return in case of error? */ @@ -849,15 +845,12 @@ static u16 lm93_read_word(struct i2c_client *client, = u8 reg) /* retry in case of read errors */ for (i =3D 1; i <=3D MAX_RETRIES; i++) { value =3D i2c_smbus_read_word_data(client, reg); - if (value >=3D 0) { + if (value >=3D 0) return value; - } else { - dev_warn(&client->dev, - "lm93: read word data failed, address 0x%02x.\n", - reg); - mdelay(i + 3); - } - + dev_warn(&client->dev, + "lm93: read word data failed, address 0x%02x.\n", + reg); + mdelay(i + 3); } =20 /* what to return in case of error? */ @@ -895,14 +888,12 @@ static void lm93_read_block(struct i2c_client *client= , u8 fbn, u8 *values) result =3D i2c_smbus_read_block_data(client, lm93_block_read_cmds[fbn].cmd, lm93_block_buffer); =20 - if (result =3D=3D lm93_block_read_cmds[fbn].len) { + if (result =3D=3D lm93_block_read_cmds[fbn].len) break; - } else { - dev_warn(&client->dev, - "lm93: block read data failed, command 0x%02x.\n", - lm93_block_read_cmds[fbn].cmd); - mdelay(i + 3); - } + dev_warn(&client->dev, + "lm93: block read data failed, command 0x%02x.\n", + lm93_block_read_cmds[fbn].cmd); + mdelay(i + 3); } =20 if (result =3D=3D lm93_block_read_cmds[fbn].len) { --=20 2.54.0