From nobody Sat Jun 13 13:07:59 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01A5929C33F for ; Thu, 7 May 2026 07:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778140487; cv=none; b=LBwQ1RV1r596qLRzlsyXrdtJd8BUVOkMLghdAwJUa17hcuB1nbcrNXz7cpN2+mSyll0jCAzjLpVvf2BMDCuLiHAeCYWDnlnVLE6RChbZ1y5p2LoopGNSIydpvsAIXOH/Eq2pemJsJV5isf1H7HQF2zzlMJoHJBmcAWoCiUWLVtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778140487; c=relaxed/simple; bh=qc9u9/fYDnq3vimu3vL7M7+iTbPf5v+oJMZrF9Q4oEw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=CoHHviNjF8NDJTy7gbUQRX4JnxChgsJHet7Rok+797xjcjkX3dXNOIsoOq+QF1gXQZ/UdafY6lVgU8jJ47ER4WUNy2KVrJcqzHiaJOw879wKFGuFTd2FVfKYMKYON7/dCIkqgQyj+ZbCvzmUrRHYFbkju0LOX8OM53gtre5uI8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=HSEwHj8J; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="HSEwHj8J" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48a3e9862f0so3189515e9.1 for ; Thu, 07 May 2026 00:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778140483; x=1778745283; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=poCJ7kcu+gChRgoC86wgxQaZbs+9th6aVzlUcPl5Axw=; b=HSEwHj8Jnd1oOT4icwkoUEIJLNLQqDhK+tdRWCyLCmlmM0TRapXl+NMBN4P7EwhUt5 96hbe5je3PYd1Ex5kOju7WQlENYMPlwrWlODtEX6B1vZJYCM1iRhfTAXeKQwU4siNeyH 0VLp+dNQj1teuk1RTICT7O/TJs/7+QWVJvxU6vYizIqLUShUOeKzEh3kB6gZLqBZqE6B sER17nH1hiHyST/BcQcBTbJP6r4gQ+Xh8H6LvhmaED6im+w1+00snU21zpG6FjqpDC/p gwNw84GKccGxSLWaPaFXSll0VNX1ULkdepqlIBttfndsrcVqfFzO/mm99n/lJbFZBzTA vfCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778140483; x=1778745283; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=poCJ7kcu+gChRgoC86wgxQaZbs+9th6aVzlUcPl5Axw=; b=DPssNVfZvTlsQ6J+0DwQh6m2cGMm87ubdbTqjfq0rhFtaopBmkE070OGpOrSNDpcM5 I1paQrstP1q7mE+vyP688qaK5xn0FxxOB38+2XvWWPK0JF+0K2WlvlfnvSwJ91A73EJD SjRNf1V3N6nWKdrIUTP1H5tafDo8lJwfWC8Lzqn5zlcZ6/10+XKFLkV8d7UYiT3PbZ+r 1PMGueLOtehkqpR9fxnyXYSVxCZPQdhGcO2BTBh7b/c3hpPqBJWqp4xroRvX5BssBn2C 5C6at8wrclzvTJ3bTxrV80G/OblShkyuo9yuCbKesbnT+Vit6enF89gjwChFriILVLfo IcRg== X-Forwarded-Encrypted: i=1; AFNElJ9lKWTeThVTQDyTEsVXnVM2U2XqD+Bs4G0NyPLQBDt57HaaGM7vg9gcIqwTR3WZnK+rJmJ08hiGEEDBkYU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzzvb+qqoGcvx4uwVFPDR/kQVmlK44m8D5fobLp1Cleg520gUMJ HT9jxepJi7KD3JAq7g7EJPvEFqqQwrhbw8cEBGitK+sDZcKtJDkJPwTXPYqwvURl7lE= X-Gm-Gg: AeBDies+hSxvywuGarfXyo7J7jb72BEruMnIqL24PsM+0X4pawr3KN8yTmAt5TPmRli QZb2ck59RkBQeuHbZfS3jLAfMn7JhNTa2C17iodkvFSALmCwScwRw+SjHdonPBSBcK09OWPKnqw KyWPAmgNs/f9/n6O4mmkM8LvhOPpCtaeD58B48bPeC7D+mtpJDceFHFv53iVl/Zx/UwIkBJsCxh Qnpg5wRYZMcho+0awWDjwvL3ypB+Wj0zeyIIAbcjb7Rec5pjJqNy66rtqzIo6GTYnKUDU/9Q4GJ 8pYmrWg6ukdUAi7wg8crqejoLJZ7R2llL25A5CSEcOhFr5euorMd/WA/cuBi3ZPrlyynbgTFemG jFikH2wYICPzxLKy8+Sg3coFlf36B4Ojn0m3qvQg76JK3hD3+fYS8HXG69ya0P1zi+5Pdktzd/i g/WFVQi2SG6nMzTHaVvd8CXMHJ00SK+GSl8L0Z7zCKU4F6m1Z/j9rt4qZZc3LnlpOxoJQAczkvB +acw5j1kZ6v2Cor8qryWUTXfvAv2LRF298w X-Received: by 2002:a05:600c:630f:b0:486:f893:56c6 with SMTP id 5b1f17b1804b1-48e5dffab3dmr27996655e9.10.1778140483410; Thu, 07 May 2026 00:54:43 -0700 (PDT) Received: from localhost (p200300f65f114e08ac341e0bb79e5496.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:ac34:1e0b:b79e:5496]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48e52f5d299sm53030595e9.0.2026.05.07.00.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 00:54:43 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Chengchang Tang , Junxian Huang , Jason Gunthorpe , Leon Romanovsky Cc: Markus Schneider-Pargmann , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] RDMS/hns: Use named initializer for pci_device_id array Date: Thu, 7 May 2026 09:54:37 +0200 Message-ID: <20260507075437.2669363-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2637; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=qc9u9/fYDnq3vimu3vL7M7+iTbPf5v+oJMZrF9Q4oEw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBp/EU98pn4uHpul9V46gnE9oLXmfPXGkj3f86qf aJF1KUX4P2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCafxFPQAKCRCPgPtYfRL+ TsIdCACUjz39qCpxyPvtcE0wlZ1NDHHQL1yMsC3NPpKNLzSDopm/8IH18uqAtAfKAY/msRWzF/l seUyxueUtsJ/VY4mV9XM7GOX+4O04PCNCpeeH47J3m2xky966xnzFWn6FnL2vHumAxlfqxYIN7d Qv2wY7LW+K7YxhS4wLb3pyYOvyaOWNvCk2Cjvb3hevX8EYgQMd3gR4WgKMbpOJk9HKRUhXgqkuG cWGuwPR9CsQ5f43gX9x4XzfOYGSS+73011JrWNUwng28yr5db7OZJSbZZ/abmVAhBL3Cv8PRxiD 5MJzY2UeNInp+tyj7LKBjRDWwta0T8xniDGs0W7XTiqPMIn0 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable While being more verbose using a named initializer yields easier to understand code and doesn't rely on the two hidden zeros in the PCI_VDEVICE macro. While at it, also drop the explicit zero in the terminating entry. This doesn't introduce any changes to the compiled result of the array, which was confirmed on x86 and arm64. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) Reviewed-by: Junxian Huang --- Hello, while being a cleanup that can stand on its own this is also a preparation for making driver_data an anonymous union that requires that .driver_data is initialized by name and not by list order. The union allows to make better use of the C type system (see https://lore.kernel.org/all/20260507074102.2654314-2-u.kleine-koenig@baylib= re.com/ for an example), but inifiniband won't profit as no driver uses a pointer for driver_data. Best regards Uwe drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 32 ++++++++++++++++------ 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniban= d/hw/hns/hns_roce_hw_v2.c index fa36700d0db2..cfe5269ba6a8 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -7249,16 +7249,30 @@ static const struct hns_roce_hw hns_roce_hw_v2 =3D { }; =20 static const struct pci_device_id hns_roce_hw_v2_pci_tbl[] =3D { - {PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_25GE_RDMA), 0}, - {PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_25GE_RDMA_MACSEC), 0}, - {PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_50GE_RDMA), 0}, - {PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_50GE_RDMA_MACSEC), 0}, - {PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_100G_RDMA_MACSEC), 0}, - {PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_200G_RDMA), 0}, - {PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_RDMA_DCB_PFC_VF), - HNAE3_DEV_SUPPORT_ROCE_DCB_BITS}, + { + PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_25GE_RDMA), + .driver_data =3D 0, + }, { + PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_25GE_RDMA_MACSEC), + .driver_data =3D 0, + }, { + PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_50GE_RDMA), + .driver_data =3D 0, + }, { + PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_50GE_RDMA_MACSEC), + .driver_data =3D 0, + }, { + PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_100G_RDMA_MACSEC), + .driver_data =3D 0, + }, { + PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_200G_RDMA), + .driver_data =3D 0, + }, { + PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_RDMA_DCB_PFC_VF), + .driver_data =3D HNAE3_DEV_SUPPORT_ROCE_DCB_BITS, + }, /* required last entry */ - {0, } + { } }; =20 MODULE_DEVICE_TABLE(pci, hns_roce_hw_v2_pci_tbl); base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3