From nobody Sat Jun 13 14:02:41 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C0C31AF3B; Thu, 7 May 2026 04:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127258; cv=fail; b=m6sEZTHU2MbxHqOE29tgcOifguJT0He7OJXWRgiRPoBFgQGyLqIlbyH+91MNpc79DV0AXhnw+MJpMtKDpAaVYCs5uHvJxEI53DAnF//J3SuNdVBDKxjvcJkz7GG00MAglVC7lMBE82xAfKgGECuI4lOc55RBQ54+IXSY03w4BRQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127258; c=relaxed/simple; bh=cuYwx916blXHCN34Cyhk3HyLwcUb40xcXLtujwQ8hhw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=t14AfrIGt/kW0CJH6VRDTvgQc4466HV5SSvM24NU5JW720WmXHF3Ce8PvaMsBW0BGu4viedmUm/aVNKEP+X4GJeKeZiMa1Mv4kyD/P1w6rbcMD+alNA0oE49k0HJh8ndmDs7ebedc5cYy1mt8dKZf+N3JT+NwqdNtrXvne2cWiU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=PAD9j0ng; arc=fail smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="PAD9j0ng" Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6473aVj53638607; Wed, 6 May 2026 21:13:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=tUNdMa6QUSZMrWdZuwM7/fOdUiEUiV184V/ZaaKnZWk=; b= PAD9j0ng6bghraWm+zE2duGWX6nCAvqkwBv+wknK5BcOIIagIruLwta8Diy3aE3u GdwM/7yTZQjIHG1fUElXOiCKGIguF/ScQWj+BescqkTLYJBJaObXRNdoDK1s6u44 +xdosP39F62pKe1pRNm70UM6uV9kJHhLNR8OFcVas2Xqsl0qZHt7K4al4Ke73uBp YEzGq3qKMKcsRYnhVr7vveK+drML7ISNQPubCC3jNiz1tuyoQDto2QEtAUb6XQ1M aYnfLPAApEg4GELwCKQbJmbIGx8RTvpkzohA/jtDw/TAe7G8iYTvE3OHRWa4T0VE mhcvs10iZZ9/SksVahezrg== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012025.outbound.protection.outlook.com [52.101.53.25]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4dwgsddpst-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 06 May 2026 21:13:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Devm0y14GIva7KKnaolqRNCEILopKYWwYz0JwHVOCBgE39/uuI5TL4xlPigDlRhckkZYEWyDj70u6Zm11wk469FSqmW8zsAn+tcjt9lG7G+h7GwiN2vhrOzQH9ZY0VCf7uAAoeglvezHlfikTxt0DrSz3mtohRlp2F/uJt/QqrF7cZmyK3HmTG752iXjjPzqt8+GmaToxqAGyCJSmq+R03J35Z0pZ2hbh7fAItWK4InPb9SgjdiekL9MtddtRFJzy/V9Bfq/ANruXCACd9azRFYybo5jHcIq8u07oMVTgBSNqDpkNXjGFcQyp0ggaB7G7t6I2hRou6qjsxTrLMUlYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tUNdMa6QUSZMrWdZuwM7/fOdUiEUiV184V/ZaaKnZWk=; b=nrgXQhKXYoVztNuTokszLIOzzxhFOo1+8sdB6az8k2xJ3NmbfcfErNxXJl+dQSNw1TyftiU73/RTdRQUWPRbdUdfYffo4q2O9LSuY8nHDONhlqITTtp5mmUr5pE7g30++GtnSqf58vEFBFzMoEXGhvYMbru/rr+SzNyk4U0dw/AJ89d/P9N1IonDPmtfQYG1J2XF+GrWFdNiFl6LkMA6Z6AeNfWbNzFgsVGrgii0Kqd7FZOiR2CJEKJ8epBVo9DEeoURU4QVv/s9l7wBz7QV60urI6okUvgC0Ku31dgHN/I023f0WeeljtPXcooiUmeOsnjw/xNW58wMjwSwXx3EVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from SN7PR11MB7017.namprd11.prod.outlook.com (2603:10b6:806:2ac::17) by SA0PR11MB7159.namprd11.prod.outlook.com (2603:10b6:806:24b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Thu, 7 May 2026 04:13:46 +0000 Received: from SN7PR11MB7017.namprd11.prod.outlook.com ([fe80::44b9:5767:8577:dee8]) by SN7PR11MB7017.namprd11.prod.outlook.com ([fe80::44b9:5767:8577:dee8%6]) with mapi id 15.20.9891.015; Thu, 7 May 2026 04:13:46 +0000 From: Xiaolei Wang To: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, Frank.li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, jacopo@jmondi.org, guoniu.zhou@nxp.com, s.riedmueller@phytec.de, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3 1/4] media: imx8-isi: fix use-after-free on remove Date: Thu, 7 May 2026 12:13:15 +0800 Message-ID: <20260507041318.491594-2-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260507041318.491594-1-xiaolei.wang@windriver.com> References: <20260507041318.491594-1-xiaolei.wang@windriver.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SE2P216CA0026.KORP216.PROD.OUTLOOK.COM (2603:1096:101:114::10) To SN7PR11MB7017.namprd11.prod.outlook.com (2603:10b6:806:2ac::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR11MB7017:EE_|SA0PR11MB7159:EE_ X-MS-Office365-Filtering-Correlation-Id: 4361b1af-965c-4d57-bf79-08deabef088d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|56012099003|38350700014|921020|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: wwS/ONKxMV601N/WirZ+Od2J1MLYpNPS9gWVA+VTA6M3DBBVifvNWqiOTR8RO8+SZBeznIs9P+GJAIaYOYYNNfQlUDSHw5NeI+N/I7jennu3x2/QTMDtAicNRulDWYn7FK6YN1b0lVlY4x6VxR7Fi/RzH6KttxamK1vtjmjrRXPInDfMTbuVoAYraz9RdWzPNnI6i1B4lREYmWILgEL+BAOpv8CuAgHWpdMiZtH5hUnbS+Fb06bnP0Rec0duQOO6FM1vi0oH1tP6RxqcBw+aM1r5OEnd2qG/Fj4Tal1x5/FLn1szkcHL6LPHxnpRoUg8RMKZSJL4pL61uLWnxAVte7sYSEPLRtzO2ggHVo7NlPjLay5iyfGUeOWzRKENAHNVqjaLeSLP6r9186m157vh0XWsM+m1ey531JdV61HZ8eHXSbnZQh0VYgaItiVEmZExpW7xgnGVLTCfDiiQZ2dv75C9zPhD5qA1uAnmukGrJT0eDm95VT37YHHp6nNwtiS+ypqmbDOBZUshTCASZbPr6qRqbSv+XY8i2Vfka3AAle2A53DyKiPYWwobGu35MYuo3LUFbZpxsxELB1AyHj1iWjF2NoLG4p1cMajFJU0YP8HXGYsMrJA9cM88riIweQhSFmenji1weyijI1EEy2MGa/QoLixowf0tjQCu6otJGX64DIWJ6ARbT2RuawQJZJyOmGCWKeiGzwjAy8zZExI0TdjNvt5hOLckOoe2HXGUPCykVK0tJKdF5igtkFVKzIdbXGZIyt24omr6UwdyvThsBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR11MB7017.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(56012099003)(38350700014)(921020)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t1ND49axxz7iDbAah0rkj1MRcsmvPNo+QXD2GMtqqpJ7/wwRqWCvAUT8mu13?= =?us-ascii?Q?dLoMSgZSs9bUlM/SxgF4L0AA22US+Qo1jPHJbe65IeXzQvwS7hujC4BAp+g2?= =?us-ascii?Q?j3hWsfrhGcizuaebzewNKPNpkR6oqvzXYabm1tMrFTRK0cbabDRCJm1D99BS?= =?us-ascii?Q?oKLf0Sd/CgfEs2fqQ1B0CEmpNpGzL9nenT4NhgaRpArbx4p3GY6FF6XXIHJK?= =?us-ascii?Q?JW1w0Uuz/8JC8JZZvMEPNPnzLNdotKo3QpbnpcJ44GUO3gtAspAGMms59rkB?= =?us-ascii?Q?etGLsCJuTO9cFwr7X9t0s6iyJcJME6NcHUtPQGvDUE6vzb8EyeYqf23xItsS?= =?us-ascii?Q?r0BcmYkh3JDmQBUiWjdAOtVzdOS5w0evGrvlLKbJ7ioRHrG8MgTsUVHIqgo6?= =?us-ascii?Q?U5cTOAiYttXQTajWYFHX3kdAyu5ScKg8LpsocFgrX5CE+IocJaEcMpXtwPdJ?= =?us-ascii?Q?OD7iifdAq7X8PZ6BFs4ih1otgCDNUMKzlWUYlBRJGSz9aRAQ4P0EQzXGv5aS?= =?us-ascii?Q?Bukzftxo+8p5rmMAANjS1JNf8NniZ6PdDgvogche+rQgyslGR0xEGQAd1ISl?= =?us-ascii?Q?lTkhxoK9oKrnA/PHDCBQLMcwFBruJtvWqHVq5K6JJu1W4DGhVb3/46Pw8i7Y?= =?us-ascii?Q?WaufvG3SFqwdFPDRCMQjXCcPR94UX1zwRb5o4ShlTsWWQfsSK4xoQ19dTTX3?= =?us-ascii?Q?3kF5CC4zND7Cn02ZyYECRbKIIMA0m/AhNBSfWbejfeNTnfo6wLNfC0UMs2NM?= =?us-ascii?Q?lcCLa+NkslZkkI2IPGpxMN5Sh7Ha5kUH8SR5SAsHetDtZ+xrCy8rpwX6uq7Z?= =?us-ascii?Q?VFfhd3/QBVXtc9dyrWos6ikzy/OuNjs9lt2BVHjmk3MI6CbxoDhqRoi1ujt8?= =?us-ascii?Q?2QeYVEX76OFpp4O/6RdKWkNCEXuNxtdfp22Ry7upbPMhSfEw1PxuM0oWW0E0?= =?us-ascii?Q?5CDRb/Y8p/pLqhdS3vwdNzMvm2sw4Z2aQ/i6wmI7+a4QP5wRSNHJWdfjoLy+?= =?us-ascii?Q?EJvfNmH1RRpEVkJ9wLIH+Hb67RfF2fgYRYKxS33Ple/xDh+hElZg+B7aQnx7?= =?us-ascii?Q?+SpJmdi3CY9rPBIQt8+49R7z0jpLm8gPLafnV6Gph1xEvtWXSQ3xNYNeHVVs?= =?us-ascii?Q?103jdtkBA1dlt7TK+4gixRWxczAdTl1IKrnH1jHamDEska2o8vnjgZRMo5Te?= =?us-ascii?Q?LOMEESHlrWjO4E3oyrxd4ZBWupILcWY2HU+4m8484g/X/c2RvGYKCrMTlApp?= =?us-ascii?Q?xNDKtWKlh/5BHzl1pY6vDDttyHuMy64q1m/wYTpotT9j/gDrWxzD81HPhOYl?= =?us-ascii?Q?DA4sPzjv3+5OXFz5YpaY7vA+NC6M39m5Cw6V2TQcTm67TLpMVpeilsx9eb58?= =?us-ascii?Q?xG8MZTaxx72NXn2DQogXqqNJlD7LpwwY+zVWFOdTKJ9V0AQ2MOV6xhaimzoe?= =?us-ascii?Q?XxSHRF3lcDTlDNzGY/gHuKdnnK1/cXoVH5enMZtJsDfv5gc6K8GxPRKMWltC?= =?us-ascii?Q?JL+PT4eoHncbaHuhMHbp9v7YXcAPO3w1vFN+vOo2miMzIC9FyZW31WZcoxzy?= =?us-ascii?Q?yUZ+NhFlnzM14gForjko0ixuA1VyX+UoByEKmfM/FPA4hZc1PgnkkHYNsrn1?= =?us-ascii?Q?USKoV19n5ZQxFT+5BFdLaBb+HWtFSt//wzBr02XVROHbjLxq0D8ISWXX6IvP?= =?us-ascii?Q?HlP8U7m7r4Xs/7zrRyOscmJ1m4YMIYGq66tQ6YWPKOtFJKjc2lK7hHFC9rsm?= =?us-ascii?Q?SyhFv2I3nQSXhuEFscMSntcwegfRboU=3D?= X-Exchange-RoutingPolicyChecked: Fb6HS3agmn+Kcu7SigfHDWXrRCJtwnnunKvP8otquGQ07+j21CCLq5TMl39iGuGPaR+9cx3wWxSrm3mJuOiNrcL9wGYJu0jB84eYAtSzkGBlsy4ptlwpCcNWrM1EuqoswHhA+cWb+BNirjgW5TBZs9zJ1EP+eKcMktJ6uEkgfOjs843FJqSWcqqIaYM93elYukBNiFf7nXCXyXjswMb4PuglkVNiA08D3WWNpr9BHF4zrymcczyuO2zu7NM/OhMqCpgDbo1vbY6wC94V30v8cNn+FKqu3FpRdVTw/yor+KlOBFhbPsYAyJ0PNdzSUpg0/crYSkqiXWrtqq5FeYsVjA== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4361b1af-965c-4d57-bf79-08deabef088d X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2026 04:13:46.4620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wRCc/YrJa4vh5/k1X+so8/eEfXvIk3jaM4+srZUQXomiLciCxVkEYahDACZFTlH94mrKrzGoxB1vDNFdBljAlwGayG4F+KExEDDQXlQOK5Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB7159 X-Proofpoint-GUID: YyfgIvKtFa6AzJ4DUG51LxY-ZQS8IZJV X-Authority-Analysis: v=2.4 cv=JeGMa0KV c=1 sm=1 tr=0 ts=69fc117c cx=c_pps a=DkeX3LL2/Oc4yJO52xFMkw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=iKiJcTA2PjBS6x5JeXcw:22 a=t7CeM3EgAAAA:8 a=8AirrxEcAAAA:8 a=P1BnusSwAAAA:8 a=UgOjM9SW4ZuDxLeMq3wA:9 a=FdTzh2GWekK77mhwV6Dw:22 a=ST-jHhOKWsTCqRlWije3:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: YyfgIvKtFa6AzJ4DUG51LxY-ZQS8IZJV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDAzOCBTYWx0ZWRfXy2QBW+bDPkkM a3LkduMmB2oWJwTORyxQZpJEoxJd8NdDuRhFoRdmNw0Yy5gSYmkTyadKv9kjJAqDRInWe6kCfTl qTunPpknOGKD6lffog9nEKMWoVtZHe34PFeHEv1g8lnN9cVTvUS2l90dYp6OZlW3VtdU6oaHbBq TV7WtGhlWi/10RiCKXQZaa7mn9M4PLK0fgmP4OsL+n05X6/o2M/HvDdqWzfbQlfclTB1fURl0uu BQfp6+Ho4ur36WIfKl5L61DMdnb/K14DzRd4xfK2Xn3FEntqNyIbBs9WgfnRA/+ubNDx95Nojxl I30LiNUPwOVAtOYzjz2YnbLP7fheZg91r4btWzry3gv3IGZYwyFaPMOZcrPJsBTsCxqjM0nz7PN 1SM5gKLfb4YFsjBaGOMAaTYpyT8owvnaDbFxmQtKcZcrjnUh8Q1r0ePM5clMXYZVA3jZ8faXhT7 /KxnqBii80rv0MMwGYQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070038 Content-Type: text/plain; charset="utf-8" KASAN reports a slab-use-after-free in __media_entity_remove_link() during rmmod of imx8_isi: BUG: KASAN: slab-use-after-free in __media_entity_remove_link+0x608/0x650 Read of size 2 at addr ffff0000d47cb02a by task rmmod/724 Call trace: __media_entity_remove_link+0x608/0x650 __media_entity_remove_links+0x78/0x144 __media_device_unregister_entity+0x150/0x280 media_device_unregister_entity+0x48/0x68 v4l2_device_unregister_subdev+0x158/0x300 v4l2_async_unbind_subdev_one+0x22c/0x358 v4l2_async_nf_unbind_all_subdevs+0xfc/0x1c0 v4l2_async_nf_unregister+0x5c/0x14c mxc_isi_remove+0x124/0x2a0 [imx8_isi] Allocated by task 249: __kmalloc_noprof+0x27c/0x690 mxc_isi_crossbar_init+0x22c/0x560 [imx8_isi] Freed by task 724: kfree+0x1e4/0x5b0 mxc_isi_crossbar_cleanup+0x34/0x80 [imx8_isi] mxc_isi_remove+0x11c/0x2a0 [imx8_isi] The problem is that mxc_isi_remove() calls mxc_isi_crossbar_cleanup() before mxc_isi_v4l2_cleanup(). The crossbar cleanup frees the media entity pads, but the subsequent v4l2 cleanup still tries to remove media links that reference those pads. Fix this by calling mxc_isi_v4l2_cleanup() before mxc_isi_crossbar_cleanup() to ensure all media entities are properly unregistered while the pads are still valid. Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Signed-off-by: Xiaolei Wang Reviewed-by: Frank Li Reviewed-by: Laurent Pinchart --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 4bf8570e1b9e..2d639b789910 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -556,8 +556,8 @@ static void mxc_isi_remove(struct platform_device *pdev) mxc_isi_pipe_cleanup(pipe); } =20 - mxc_isi_crossbar_cleanup(&isi->crossbar); mxc_isi_v4l2_cleanup(isi); + mxc_isi_crossbar_cleanup(&isi->crossbar); } =20 static const struct of_device_id mxc_isi_of_match[] =3D { --=20 2.43.0 From nobody Sat Jun 13 14:02:41 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 410EB31E849; Thu, 7 May 2026 04:14:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127273; cv=fail; b=WNUriZhfnOBMC1zW5BTVsrwTPBX2Cv+YEGx1ZmkujO82DLjrVBR6PC6bmgPP4D3zYrc1MGO+sfMTgQVSWS9+Owz6wkwRCidBIWryc8PZ7Dm6GVvqM/yW8MkOjTTkInguXr3Y+ct9nrdn7Hk75IiZS0+RkpxB7luRBX+UJYB/UV4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127273; c=relaxed/simple; bh=8n4pNhkrdAJFGM0uHkevtG6xGyEekFZg9hHxz/0pPtU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=XsTJx2fHgVrzO0X0ZywjWLh/s4IHD79OS570fDs3BxB3RgbWom7YU0OukxxVzJadaiQzUGDskthvifSoL0bdC+940Jqc62rKriQMMPvd5iFqHL3s8VxsJWFwlODQO4VM5x96TnmNqu57CUXaCejxG9DwgzqW269ZIqA22R8RiO8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=f42RQ1QG; arc=fail smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="f42RQ1QG" Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6474DjSM3703407; Wed, 6 May 2026 21:13:54 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=KVxkIY+5+EoCac9yNdhCrvrsh7tTkzlDijvNzQDCeA8=; b= f42RQ1QGEQSBbzTh4aOkyl+c+9MAUmTLbg13tuVn8SfBLw2e26AzfqCKSt5eE2oB l++deLrrr9wN3DPeJ/m5vj35VFgTsXK7TgJQlDQsKXzIYXATeDWvN0VvlkB8o+Da L7ESuvapZEVMJqkViswERWXfIVtYYN86xByRIvMWmfpLnxSzx+Asvelc/sHPfdr2 Q/YtCe6VIiV1+mX7LMcTt/puUen1OJX+5SagrxGTTRgbugHKH3xIk4wRJUUJiRtp Vs2eV7qnzb9SZ4JYUiu+qG/k56eObXFWzdyAShbJ+L4BaN61ej43+tBfXktbqghh 0O/VNxrc6vFMorCKs2jI6Q== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012041.outbound.protection.outlook.com [52.101.53.41]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4dwgsddpsv-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 06 May 2026 21:13:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hgjdOXU45A+5TfiMo5rx0/IeNynFuqPeoopI3oPMjI6oVFz0Ii4k2wRqUWFhc313a+jDkqpCMhv9yvpMn98LpIu2ds4tNyIYOMZpkm7Oi7Vub9sArAE0AifmhNfejJ6hsdgIYT3akI4Hp/E2Yx5+lLK0lpxm2D5kM/ErvexXXM72FXOC/sdu/CNuVM6MHSd9QATe9/HrRIQu5ayQimOJQUHpOlXPmMSnACBP49nFut8fm9Rp7ikLXctnaLuI0DjX6WH+YspMLmh9CNka5rC79oL++JeGDgL1K2Lx+y1PX09KhrYJWrucMK2Hs2vdRO7u3He1KR98CqGHnXEDep+heA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KVxkIY+5+EoCac9yNdhCrvrsh7tTkzlDijvNzQDCeA8=; b=L1eHddyBiB874gq7bfh0HewIOenKD2LRh4o5N0vnZd2W6IUVGpYFA6xxj5YWNvAugmaiSH8R7bn3ODRBwCmWSJ1RfLkpC6TFTimvWhTbQn5Ur3k/dQFkmeuuX203ICdVJ0IQ8ftftOfmjLbWKIGOd+i7Bdl1wF1/xoxbJPb5VVTd5wXM3o26lLQwGhrquX/sib+34uigiSG2/OUIrFCFMBbL9ttsQUY5dTk81BELsyGt7wIApY6DG+Pxpz17DQuvCOqfDpe9+LDbPVKwVwgy4x6Bwht77WEwFcXS3hCLzZA9fTy2wnlsxaPLbU30Hq7jkik6yrMqfekIUQ76N+hRIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from SN7PR11MB7017.namprd11.prod.outlook.com (2603:10b6:806:2ac::17) by SA0PR11MB7159.namprd11.prod.outlook.com (2603:10b6:806:24b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Thu, 7 May 2026 04:13:51 +0000 Received: from SN7PR11MB7017.namprd11.prod.outlook.com ([fe80::44b9:5767:8577:dee8]) by SN7PR11MB7017.namprd11.prod.outlook.com ([fe80::44b9:5767:8577:dee8%6]) with mapi id 15.20.9891.015; Thu, 7 May 2026 04:13:51 +0000 From: Xiaolei Wang To: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, Frank.li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, jacopo@jmondi.org, guoniu.zhou@nxp.com, s.riedmueller@phytec.de, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3 2/4] media: imx8-isi: add missing v4l2_subdev_cleanup() in crossbar and pipe Date: Thu, 7 May 2026 12:13:16 +0800 Message-ID: <20260507041318.491594-3-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260507041318.491594-1-xiaolei.wang@windriver.com> References: <20260507041318.491594-1-xiaolei.wang@windriver.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SE2P216CA0026.KORP216.PROD.OUTLOOK.COM (2603:1096:101:114::10) To SN7PR11MB7017.namprd11.prod.outlook.com (2603:10b6:806:2ac::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR11MB7017:EE_|SA0PR11MB7159:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b42a449-fa25-4253-4a2e-08deabef0bb7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|56012099003|38350700014|921020|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 5s65l6RA/797e0O0EoikeU5/ppzyGcJjy1+/a4fueJiPuFo5ppNndiI+DoUDVR6ualWhFB6513yVHIX3+kDWeSjduA3FUa/HQrPJsFV4SM1zs63RB4HjoqPMuVsnsipFxPDcAz4xy3CbbJOQ8Wh0Ll7qgALTWUthseH83mGEMYQ/glKKUYHGPE/3PTU9cusei1rZwu1j/XQO0CCGaLzNL4BvpP0T8idZaDjusBve9mqbp8NkilCR5GskAmuKB4FGe9DTbpYeuZbm7L3715KeO/3plS7D2l0DZ25Y7LuIkHYpRscxofX6lM7/iHjnTC/6MqgZXqSdlA7XFsWECOlefQ+Pd3rBGl7PR9VcCY2+E0Yv4DVOuI7iPE4daUAJnr0FccxswzFdn/LSADxFl2Otxix4yFdf79EmOVMTzJHOKUpfF1KZD22K5979xH5miI5pkmUVbuHmuIxd2NJ/1oFn+Dj+HxgDkhWtSS8aOIZqKDe1lKvnGuhEKikmFVU6VoYjPExb8uxIogSQ9lyGS+flYCDNPo9fZxXO1Zbc1eb8ZUGiudpKqJgLjOWbhLIMm6FCwWLU+/ptNA86PiXmOEddCDv27alJ3E+MbAjeykYumLUkKrhxhz3mwzvd4AXjf6ooV3tTF/GAqksccs2/I6gQmd3UZXFriI/HeZ8QfJHUucHds1pQCoK1qFmk/MR5A+znjDSoJ0h0sombJswtJxkuLFnfwsQvlv77paSg8L08nT1XpcIKJnof3PmfA852XA2tPeY1Zxcq3OXMVT974H/Ilg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR11MB7017.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(56012099003)(38350700014)(921020)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K2cJra0ilrlW1AaOSihGyw95ZAiSeHnDixC602R2ZAKWob6h3FrC4I+DNblv?= =?us-ascii?Q?8/Lj/Hqp60s4WwSsea9PDvN/DjGtJHnkPoV0HHo8RY58PDJKtOewhpJMlQ5j?= =?us-ascii?Q?O/gJIzbnhaD//E0hr8t1zEFpjTsCJSRS2gWgsuTsHmDNap/lRPQjtCX4BqY4?= =?us-ascii?Q?1f8Q+DiBctFX1nPzaWmXUgdiTpPTy9Z1uFFMAVv72lrH2wdn8ZlOQGeFZR9j?= =?us-ascii?Q?WUIJ0h90rx7nRCqIuJOqVyMnHqd3E95kTWIJ1moMYWXOu2zZ544eeDfs6g5W?= =?us-ascii?Q?3KBN0AfBZMlPMCn8VxvTWATRw2/HuP74twh2wNF/4RmOKIPPK1Pg3CgSkn+r?= =?us-ascii?Q?ay2205A63CTxJd3YpEZpOFhgHeQUrikqN1q4heVxb898UlF/vxjTiCEFoqr1?= =?us-ascii?Q?QnZw73soTKxJHff60UUF8RFs6RG7cSGjfp4B6fIa4ucanaS7+JQsQhsE7+bU?= =?us-ascii?Q?eLT0HYQVPWac0BpHV0L2azP3DGV3b2hjc6SbuhNnAKRNEKwFbY7b2Aowo/IN?= =?us-ascii?Q?LDcmcnLk81Sg5dlk1Tpo1UlIU2/hxtNjdyBYDxJeUJLozbm6Kq3H1reGY6Br?= =?us-ascii?Q?KAbUeIP/PT400dk1ajoqt3NHJYW5JIKE3qThE/+FsdN+M+izuXW6pcbXEIrV?= =?us-ascii?Q?9Jxuc3QdQdC3j46jHgxZmHljMc+aE//Y/11XUjH+SZrE2RmZagEAy0Q1TFnh?= =?us-ascii?Q?Gfm76mMVi3fLwCnoKDl3EpV/If+mwC8VXKzcMPwBohwEltPluQKQaq757LQ7?= =?us-ascii?Q?oIUW34CfhfhSpU+9ar4vmBsaiSgEz40xvw48DPrIjArRiIvLF8gSaaNACvUd?= =?us-ascii?Q?K1HGfls0U/Y/3GqwHP6Uf3QR2ZUNcAyx4WWQhDYhR7G5uph1pvjCOwZ9Jmam?= =?us-ascii?Q?KtryV0wKoEmSdbHLlXXaq7wcw5FHMA0zyduz546I5r95AYnPRGFrnT5RdSES?= =?us-ascii?Q?7bmeq3WgsX+6SEAow1KjUUMefa2qzTfcS9+iE7bm5heeTDhYTogZC0iwyTHi?= =?us-ascii?Q?QGsN/PNTdYHhmcr4oFHZVzBh2t/EKrIbA6FBJJ2D1iqd32XQx3NklrgzNGiK?= =?us-ascii?Q?Ec3zXt9pZiDYVxHJ/zRtZzIGhmU7c+k27++v0nL11ptDRB4KNpr5mOrtFQ6H?= =?us-ascii?Q?tSRplwlzUJ+lJlsL8tefhzYVNzHmCTVPDaw1NqR7fdNcibuazRxrVJGtT4Mq?= =?us-ascii?Q?2/khG3Sc8IC/Oo+Jt1L9x9/AdObVoTNNj6EFduk6gepoQbwlgSf2wWPYnQv8?= =?us-ascii?Q?Ee2Y6t/HgyzMDAFcbOVGD/JIcCdYSr/sqo9+GMf2XH0xex8tjeK2ZTmXqOxM?= =?us-ascii?Q?OicwT3VaFeXnwn/d1Ut0iDloK6tUj1DHwmh+q0/xktUdj4Z4BdNRjmmLGuwf?= =?us-ascii?Q?4k3rLVfsv6B+Ct+/3Wh7MjcfuT7uTnUZtv5c/y0RWvp5Bh3N+JaGpEoPFBEq?= =?us-ascii?Q?EHBn0gMiNgvWCJRuuZgH0qDeen4y+tPhmPwxnYE4/YMFzOiM/MfsXbaBktbA?= =?us-ascii?Q?vLVpyjeMD9E9SiWjYhUkhyimdtcVD3vOcbl0yU+qvs96/jMaBBPA1kw0y+sG?= =?us-ascii?Q?wKAicyW90zxhL2JGE4KQAh5yPR82GO+cifAUjOS1+BfYHsPS7ugC1SqhKA2N?= =?us-ascii?Q?YeG6f219PekFtX+QhxRo/Xgs9GK+RCa9mO/PO5sAp5dQoUygIWF7O8IH9tU8?= =?us-ascii?Q?BuD0jSk56GogVpUBVvIpPQ2pP+zbh0qG/Fj1gXIVlgRAdfI1snKJRL69aWGU?= =?us-ascii?Q?CQwxfch6lkXqYMUcfOjOpdM+Vqf2s2c=3D?= X-Exchange-RoutingPolicyChecked: OJZrKk+JmO+1OPqG8ubB3ZcloEaKkq4wyjDa5V2Re2EohNdmV5D4Tzu4edkB8wZzmyAitNOWpH+tdG3KFg2sk8sbJO+RqXMk2IxP/YMxpLPpDtMci2IRj4dGoB/6kQ1rBPzoatcoLxpTzXuPu0w35MjW/9d9VxVOJBGmXycxg6NmexKWdRDyFPW4Tf5UIQ/sd+zyzNE92xqDHDq6ZmG+uQdwS4yeMJk+PyN2MnqQk6ahqmT3vq2Z3sG/n7JcUABr2zMLhNJCR0pbT1mJeVPSDHHqzCbf3Jj+NgmDNQVoxgczUwCWZonXNtrnaVCWOBFLBljXoIqbxSEm3kpPnxHWzg== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b42a449-fa25-4253-4a2e-08deabef0bb7 X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2026 04:13:51.7457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p/2ucjNvFtr7qkGUMhaFEAABjqnyhm0FBzexgCGdBrhYFhan+cR2oaPX+9CaL248SMAHJXabv6qJDsbMtkB2GxlKoPTsoV+Un0S0aL7rsA0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB7159 X-Proofpoint-GUID: dGxlkwxJMZjpsQdhaASLdRjYGV88RmrL X-Authority-Analysis: v=2.4 cv=JeGMa0KV c=1 sm=1 tr=0 ts=69fc1181 cx=c_pps a=yZuzC5SkKTYVmguxKPWuow==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=iKiJcTA2PjBS6x5JeXcw:22 a=t7CeM3EgAAAA:8 a=8AirrxEcAAAA:8 a=P1BnusSwAAAA:8 a=WOeiQqRcx3Q23kswDYUA:9 a=FdTzh2GWekK77mhwV6Dw:22 a=ST-jHhOKWsTCqRlWije3:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: dGxlkwxJMZjpsQdhaASLdRjYGV88RmrL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDAzOCBTYWx0ZWRfX039TPnIB5ZFE RSMzzM8SA/72k6ZBrSXE9ywL24mBm9du+B9Kz+aS9WUb+3cyxcnLfuwd9a1wtYdPStLL5IRjiJH IqBB7knByt45SHhHy95HmYSGJSR7j55YvelRRqjiHxTb9rFU3j8yXJI3W9SfqIklBYlmFmbK6On /EzSudxlseJs0ShqThGtGrFomqQHm85gWoeWFsvw33KKsZQAr9zXQ2HSTqDE4f4xdo/GatxRFev wZqHLx0Vr+ItEgygkpYnzo2O41iOi6py5+rCnqN3sBz+MsUbtdcEhIlLYlAjGoqq3BytAJv8uyk e9Uqr9Gi7OpZjWIqzhZCL8VRf0cwzMm6klTBnwflS/y81vRN3KpDPD8Nq4a2DVeiUgBMO6OBNCV B8S7twmVzClhuuGq1GnSVib5p9oXMKftXw0UQ2CofaJs4KXhza62BNlYelFgPXoDZgWQ7g4Uv6w 8/28JCZYD3XckIHZt7w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070038 Content-Type: text/plain; charset="utf-8" Both mxc_isi_crossbar_init() and mxc_isi_pipe_init() call v4l2_subdev_init_finalize() which allocates the subdev active state, but neither mxc_isi_crossbar_cleanup() nor mxc_isi_pipe_cleanup() calls v4l2_subdev_cleanup() to free it. This causes a memory leak on every rmmod, reported by kmemleak: unreferenced object 0xffff0000d06fc800 (size 192): comm "(udev-worker)", pid 254, jiffies 4294913455 backtrace (crc 36eeae58): kmemleak_alloc+0x34/0x40 __kvmalloc_node_noprof+0x5f8/0x7d8 __v4l2_subdev_state_alloc+0x1fc/0x30c __v4l2_subdev_init_finalize+0x178/0x368 Add the missing v4l2_subdev_cleanup() calls before media_entity_cleanup() in both crossbar and pipe cleanup paths. Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Signed-off-by: Xiaolei Wang Reviewed-by: Frank Li Reviewed-by: Laurent Pinchart --- drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 1 + drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/driv= ers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c index 605a45124103..c580c831972e 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c @@ -491,6 +491,7 @@ int mxc_isi_crossbar_init(struct mxc_isi_dev *isi) =20 void mxc_isi_crossbar_cleanup(struct mxc_isi_crossbar *xbar) { + v4l2_subdev_cleanup(&xbar->sd); media_entity_cleanup(&xbar->sd.entity); kfree(xbar->pads); kfree(xbar->inputs); diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-pipe.c index a41c51dd9ce0..cb50af2270f6 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c @@ -819,6 +819,7 @@ void mxc_isi_pipe_cleanup(struct mxc_isi_pipe *pipe) { struct v4l2_subdev *sd =3D &pipe->sd; =20 + v4l2_subdev_cleanup(sd); media_entity_cleanup(&sd->entity); mutex_destroy(&pipe->lock); } --=20 2.43.0 From nobody Sat Jun 13 14:02:41 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 607B1321F5F; Thu, 7 May 2026 04:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127264; cv=fail; b=ny+Uy0mwqf4rUcTDsTKV3YI08PRyO915HZtnM3/ycdQ1uP3q00Ed2MvqtKx0fuQrs2Kr3E1jmtoPuqNaRM5X7k/Hzx3yIr3kVZjA7xRFvSl5pdoNWJ9aPwbKPnwzjhHa2qyXWkXZDTH+4k1Bw8Jk0WWK5fw/uy/qTT43GbFRhnM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127264; c=relaxed/simple; bh=D9/baKfEzjQDgmtIVyXynABPEFtLWM2uhtlluvSHY+0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=RtoZVja0tJqhAIinZ6V0kpKIptHrg7KKVtWDV8t7DihU2vsVmM0exUwtK6kqE5z33+O4rqJAV0uwsl15fjbYXeuIJshIusCB0DYj80O6PkxpNby8IaPfybwNKI3HUlJtZ/PAHVY8QNxV/KCry/mZGbJiMJa3qiwqQrzGMy5+iw4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=h5GZ8qJR; arc=fail smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="h5GZ8qJR" Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6473o1wn3113943; Wed, 6 May 2026 21:13:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=zHCqU9lGXmJhTN+4BDxwVYKM+DTTXM3yH+nO+rgXKPM=; b= h5GZ8qJRCGQ/1lCHmgc9yu6B2Re9bEIqm3Ie+f1moODg5i7QmiNgcoMG6wgL+0dv z5iv8poIXHlLplPZwCzypiYEB312LQkR9Q/xIIe5jCFpjzNfx8hrFJ1QXJgynDXf VQPVGdjKJ8eqRnREMCNok/mP3A2Flm0GrRNjVqWl6NQii/HWYf9Kh80RN07TTvBR cTF69Ua/222KoXQ+/zX9o20rbdpTq3tw5Ou6O2HlRUhu701DPj8OLsyBKu9ho11Z PG+P9NOHCgn5JqSj2mMd70v4QLaM8vlH+ECTglyG+XXa3/0lbQOSfVB5FhkHY78m IjAgYAsSJ+yHoMubMN4v9Q== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012055.outbound.protection.outlook.com [52.101.53.55]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4dwchywts0-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 06 May 2026 21:13:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Tc8j+U7VBknxycTSe3VmvdVFrRPmip2k7y2bTqr4pxt1sqXIxdwDeZ+3E46bT5N27kcMGDopoIRH1Hl2ql8VAFZGlHv7fqvxadKBGdju1hMTc3cuvwrMnbislYZMaPlwxmTSMu+RU/9w1+Ug+/maFN1Q1yjqPPSMaEoay1ozytDsCRK8QzzfhCy/jrA9zIBWyeqdFQC/VJvtS0JB1qmiJOCdk9TfwjG2fdKaxXuxsGDohIntkEH73ns8hoGfE8963eBsrXZMfJ/Sn+NWS/WO4oprMkCkvMi4qgo/U27PxVNG5WgbgJQmISN37PmyTTu00oyPAv8VwQ9CBz3wEnu7/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zHCqU9lGXmJhTN+4BDxwVYKM+DTTXM3yH+nO+rgXKPM=; b=cbWluVb4bO4qicbvqeXwP9Vravfi0R4rPeQbYh49yHFiRnGsvID4GdGIjKZuddmqgkzF4DiqdNFkbGnOZDhsqjm5ut7v9p2siEdS/3lkNKc8ATZpfjeBhDPOc/Lp4XNyNmO+SUzSqyZ4Gdtsejmgx+4yiBWGJh1A0lUVm7Bddino8PSxeIDXzaP62SQ3n868XKwBh+ihffQBuKMAPVqZk98r8kz9tPg63LnK6QYgrF/76WSg2Wkivmi0/+B/99JnM5O3ocnV+8PeofBLqDqxY2B/K2RBzwFCkZMZICOy49RhY88OeHAoipuE8QM8VtFIy14vJ5YGe/7u/lMwsEnqpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from SN7PR11MB7017.namprd11.prod.outlook.com (2603:10b6:806:2ac::17) by SA0PR11MB7159.namprd11.prod.outlook.com (2603:10b6:806:24b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Thu, 7 May 2026 04:13:57 +0000 Received: from SN7PR11MB7017.namprd11.prod.outlook.com ([fe80::44b9:5767:8577:dee8]) by SN7PR11MB7017.namprd11.prod.outlook.com ([fe80::44b9:5767:8577:dee8%6]) with mapi id 15.20.9891.015; Thu, 7 May 2026 04:13:57 +0000 From: Xiaolei Wang To: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, Frank.li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, jacopo@jmondi.org, guoniu.zhou@nxp.com, s.riedmueller@phytec.de, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3 3/4] media: nxp: imx8-isi: Fix missing v4l2_subdev_cleanup() in pipe init error path Date: Thu, 7 May 2026 12:13:17 +0800 Message-ID: <20260507041318.491594-4-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260507041318.491594-1-xiaolei.wang@windriver.com> References: <20260507041318.491594-1-xiaolei.wang@windriver.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SE2P216CA0026.KORP216.PROD.OUTLOOK.COM (2603:1096:101:114::10) To SN7PR11MB7017.namprd11.prod.outlook.com (2603:10b6:806:2ac::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR11MB7017:EE_|SA0PR11MB7159:EE_ X-MS-Office365-Filtering-Correlation-Id: 73681704-7f3e-4a80-8b4f-08deabef0ed5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|56012099003|38350700014|921020|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: YqeROmrXMGlkTWtfOtH/DRteBTuVdh0gH/Q4jFs/9oe+wnQULJn5F8YXauRyKsm2eNVTN5+PB6e+TZlky1YGsIUtvQh45RuZa2wb5C6mcH8FrmniQHSbd/Pxjnirx5CLyV4BioT0iNVGWhGzdp9kNCpFbgtzaJbNvDUeusZW4N5Mp+COMtZItw8NSEQpbPIQDKz2vxYy+/51UglWuE0+cvL20sSJNvI+StTi/g/tXd+Z2H4pd2VmEfIt/UdVDNfuH7yrtI0CEVQohydVVLZMkXxlBn/rzZPm6b0HxgawztDGaXaBtWVcUaFbqxzBiZF+tQsJtrD09JW2OAXI86rjoVW9otYSbIucxLL4RnJdgwzyDdhLg7GxZSPQlt9uxofbM7hQV2VhFggNzKRmgKuhnVeqRgWTk9FHAvh/2wMmolQBKNYrB21GyebyJTVf0q2qtDh4fkm652pzK79LuhUJ6RkF5ft6iWxM16Pt9kjix62sfX6ppMB83XGCv9kuPr0OUY2BV/6N+ujVvUldW2cboEgdOEsucgxdBka/BP0vcD9+9zY4R6q+0cFe8jqIsp1GwHxr3EOpNWXR5nZeSkq347KtVvf5B/5u0OccQJ1lUbdOfRsK03GIeeu93y/LWzRT2CN/OzrUxO6gmBrLcnpRjwMlyP5w2OntowOOwwVhK05lUaRbKkYbqLg5dUdifqWN9S1vSg+2qjqPx/JA+MRGtcnkXltjh+zpXq/P6LHn55o+ip3ixf5q7FtlAQohgMZVD8A3PhzLIxBLR9LtCSUWvQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR11MB7017.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(56012099003)(38350700014)(921020)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0ASVPRWc4MXonwCxD2sCNK7ZSwS0Dme/kGzV/x1Q8osD7Yz2Wn3aiH1t6NE2?= =?us-ascii?Q?h521Q70/LAVEdoc7c1C9ARZnFW5SeVvkA1gx1edmdw4478Kfist8bCt+OFM+?= =?us-ascii?Q?uyD4DeCgpUkBR0yEYZx35IZWMGTRrgpq0DRcbYpOFPjp3hbSZWJ7ihCH1pAK?= =?us-ascii?Q?aF3RKykPS75HLov79AG0LkczBTMJxQhwz9c9oaNi7APR5DL0qbwD8u1zeoHs?= =?us-ascii?Q?fXsqnRSMUDJIHN2dMceN//kV+JimLAOdwBzyWfqpLskZ8aB2DCmI+kRD+XJw?= =?us-ascii?Q?flPKJsDrqNkY8n3Ji3hvmt4qgiUdSVDBnQU2It/6x1/Bm96lMXFCPn8fD1XR?= =?us-ascii?Q?EJYVR9FDi9rC2e5lxzAnGgVSjHbhap7IXV35ViJA7zI7Qv+Y8524P2qOLhBa?= =?us-ascii?Q?wIonZz2vqh8stDcBVACU2mHHxuMVZtdUfhgwxaDgUs1VIJSb5EplTyPzM2g9?= =?us-ascii?Q?gtubNWWpAXLCkYiLn3tEqqA/w6YaTg1W7Xtx1bfkY8QlsyjrO5Cn1rHnR0Lo?= =?us-ascii?Q?NpAcOQWds1gxaqXCembt+qDeT/FTvrQ9qmH7qJ6TQp0HObEo7G212gJv4V8C?= =?us-ascii?Q?Kidfylzw0w1GQ7GLZRUAbvd0Ry+YsQ2sBBcnUCRvq5oxlaaH1T50TSAgfUP1?= =?us-ascii?Q?xSeGlzS3KZHUAHo1D/1dQJeshkzwKk7/7G1uMqDx0u6OpoU4XFdpUwiOTot+?= =?us-ascii?Q?OpVOe9whrZmTgF9VxQAWS4dybxn6p7ih53q/rNjeQkJiQQhYihnrt6bX1xAj?= =?us-ascii?Q?rl7ls4rBSu7POnMpaPnjUIG1uOAa3IdhNCIVJBfwlHiKnMJ7OwsZXt3PviIN?= =?us-ascii?Q?wcZ7NklkhZ3MpE+YWHytu/WQTQuiOXkACekpB0kb0/kt7I1yJMwj3j7xZt2W?= =?us-ascii?Q?InEgxHRBa2SrntWzGCL6kYiywmDtWbq/0KXuJbcLgU/Up2iQKUancJi6n0cE?= =?us-ascii?Q?WERxjX7dZuCSY73ugNhzba9dTvVvKwyne/xC/CQcxmmRRCZYlf6nWQ0aLj6n?= =?us-ascii?Q?RXWIYcfRfcntscaMW12ozHYDNZPkgPV19Zc8hWBREtXZMdxUkCJogCXzB1td?= =?us-ascii?Q?JdJBMFv9XX1JAIPX5LIGcyBQhYWUSHjMSz9ojS5T8JgHFpZYnIsoCovg8IMt?= =?us-ascii?Q?iQZ2cUseNT4SQ753GcIUinpfAR8Jb86kDacNxCYTaQ86TKYCETZ6GGwd7AP6?= =?us-ascii?Q?ugk8K4ugrQ58vbu4H2I3ZgARrqrFwwvRYBtiTNGNDv0zIynrPncbFv6/2awE?= =?us-ascii?Q?Kq7wK4uOEkWbD0YjrKZshyr40sWN0DYs+m7dC+q2gVnU4STOUzY6OAkW7V+C?= =?us-ascii?Q?QMa+zV+8YfeQoLYUs2ACuCfGWpiQaZhROdR9mXNoDXC0oPCuxVAuqOoKuCrz?= =?us-ascii?Q?AYNVbLchXoaUvZiW0vhElhe4BiR1UVOvQM2TSD7/CHNlN8kw2g/kGc9mp0KE?= =?us-ascii?Q?Ym0UGC6Hma7qJNeB778wh6Le52G5HjGYPz8BfKj8zMaSAydWf48p9yVfzN7W?= =?us-ascii?Q?8gF8aWO+c6MlUnHBlVJsHOubx1daRFn6BmxT4d9zXVALa+/I3drR1gcMF5+3?= =?us-ascii?Q?Ncs4yWoe5pbr5Ml/Rs7suT+PFS9WS8HHFcwpdBn4ALEiSxs+227N5ZgWB2K6?= =?us-ascii?Q?z5Fj8CfJGBvdu4+1eAm6ui3P56cVda8WkK05P0bBy7m2I88x+z9t8GqxnRBh?= =?us-ascii?Q?uiQ3NR/LvHZehD4+N9Oephv+EH+Z1LoCzyjO4lErpGgoV/8PG37BroKm5TNQ?= =?us-ascii?Q?s4vaKkGTCIJhq1RomjpJCQbDKBGOso8=3D?= X-Exchange-RoutingPolicyChecked: bNuBun42r+WvtwSH8/VTM3Lkp48O74DRauvrcmP0dfgz+h16siMOew2Axdosc2B09KACzrU4XsISj0UOG/A9kSZDAANT/JEVMkGZq1+N2IQYyT2NF12QnbbKTOkgGvTlwV2rYIyu4JPq3H8RV0l3GwHozUXRU49fVg3rNUTEauZXllkOipTKrzlWve7i9N1GZR3rhfSL/zpQBzQwNnfd+i2cyv+TLbJaFKkSXSDvccn8x0i2NcW9I+VbFRvRknYJuxCjV24v0qmesnvQoKb1ngaRSHdy1HEg0T8cfszKf1z+sri/EHdt5vdFE7INk0fG3k3CIy4IRuxbLM+u3FMw/Q== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73681704-7f3e-4a80-8b4f-08deabef0ed5 X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2026 04:13:56.9475 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F1SR/yUd8oj8ExkoqV2CfHH/yczwxf1mXbb0TrrBWtE4XaQp1MrGA4dKfiLRDXIh0QJbLPX50YCnJjNm7rDahRabgV/8iunB3SmHPoI79OE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB7159 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDAzOCBTYWx0ZWRfX5en2IKLStyDX XVSdRgoZHUBwql2KbnW7np3TqUmvH9HQS1pP2k3gnfu/gDStYrUrvbWOERgYZzh6nyZcithuZnP wiO6GQTKztyZoxs1UeK2IFmEu5cHZ4qk/vvtT4HoKQ9JzjPpPFVuQgrM+xogTgHQv+tFLRR4+Vs HSWlV24EzQn1BymbEkMNhcY3ZBpQquyBe+Oy8INcu2EXoDLj3jj9cXM2wiJ8UQXUnQEeaXDegt0 1bVUCzGFz1sdQ6YAwR6+Ngq4VAhqW39qfHnWlCntgqottYfufc4tNL3Mp7Twk+X3T4A5HZAZokj rkGH/PIXQz2TwoCo57FQZHIvJ5HYNqNoWdU0ymO8OGCBqapmFb59v62aEDsCIRcdaoCkatQzEz5 Ch20uqTb2LNohbDlq6e9UhDPRWVM6bfHxYbK0VTUCY+FfEYk0EjaFQusfkQ4abzMuIsJfR5c27W jh7tcyQKikp/WdWohNg== X-Proofpoint-ORIG-GUID: BXRJOqI2cMGrUxyoEfzKqExELhLoF6Sh X-Authority-Analysis: v=2.4 cv=LsSiDHdc c=1 sm=1 tr=0 ts=69fc1187 cx=c_pps a=ffjDj9JMBHEDizK9ymob3w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=HK-ge7EqtdluswH-FwHe:22 a=t7CeM3EgAAAA:8 a=CGEsPDFH1TKow_CSP9sA:9 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-GUID: BXRJOqI2cMGrUxyoEfzKqExELhLoF6Sh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 suspectscore=0 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070038 Content-Type: text/plain; charset="utf-8" After v4l2_subdev_init_finalize() succeeds in mxc_isi_pipe_init(), if platform_get_irq() or devm_request_irq() fails, the error path jumps to a label that only calls media_entity_cleanup() and mutex_destroy(), missing the v4l2_subdev_cleanup() call needed to free the subdev active state allocated by v4l2_subdev_init_finalize(). Add an error_subdev label that calls v4l2_subdev_cleanup() before falling through to the existing error cleanup. Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Signed-off-by: Xiaolei Wang Reviewed-by: Laurent Pinchart --- drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-pipe.c index cb50af2270f6..a59b9456b590 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c @@ -796,18 +796,20 @@ int mxc_isi_pipe_init(struct mxc_isi_dev *isi, unsign= ed int id) irq =3D platform_get_irq(to_platform_device(isi->dev), id); if (irq < 0) { ret =3D irq; - goto error; + goto error_subdev; } =20 ret =3D devm_request_irq(isi->dev, irq, mxc_isi_pipe_irq_handler, 0, dev_name(isi->dev), pipe); if (ret < 0) { dev_err(isi->dev, "failed to request IRQ (%d)\n", ret); - goto error; + goto error_subdev; } =20 return 0; =20 +error_subdev: + v4l2_subdev_cleanup(sd); error: media_entity_cleanup(&sd->entity); mutex_destroy(&pipe->lock); --=20 2.43.0 From nobody Sat Jun 13 14:02:41 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADEA91F3BA2; Thu, 7 May 2026 04:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127274; cv=fail; b=druRFIEN1jXuO4S/b3NIqHQHawwp/X99h7mjZ8FBGbZmIQOHZ6wede5GVJZfhafb7RTHxczGyixULJuMyuwb7PsqH3lwydgSgz62dZ7ZwpUJ4HG7p3OQ+VFHHoksKaleNJvzbgVWNuqN7FYYNysV4liFRVREtA3rYpLFW3s9ORo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778127274; c=relaxed/simple; bh=PE2wtAwaP/8clvpMGz2a3MHZPyRngZdpx68+RV8Ijmk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Oku3icxcD5Oj/urvR8NzFaX6qOXEokT13axq8N4rHXDr60ER5VtxWE9K1poLVb/x61gIbIL3FMmBBUkyK4FhRk2prZEkOsd+dkkDJgk4H/dT5VcwkCmZIWx+lzXoCxPR21JRM2DiPXp3299QGDwnckadRTqKQA64CrDj3Y1Jbog= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=m+kUcWJq; arc=fail smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="m+kUcWJq" Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6473uExE3673670; Wed, 6 May 2026 21:14:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=nFJdsw7t+OMjxc6O4iWZ5SWmGyIf4lxm+oHnSYx0uKk=; b= m+kUcWJqvencUhi7AwTGbCNWNC1r2rEAm88aTEOqbkqToC7/21xFSgt3p5FzMCf/ c0XQI7ue6WEdCIGW2Ob7PKvfFg4wZa+YNwPO6TjGWaE5yUb8RooghhF4PbSwrI9t bzF0ZLL2MJ7y8F3/rmjfgO+0YwmtstLH8i/4cqc+i78LaRCNZhyaEd6dZB/SfhGk K8rWDlNaxcljb7d8Vam1yZXYLo1N/C0m87T5We3gqW71bBVrX8PSadG9YASygvFJ MOkcGyFPn9KFzxGPccZwsYBO7CTTSBuShScCWC5MfZN69hWkPFPTUKysf7Poc/WC RLscOVdx5QNBrhFq+/DLZQ== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012051.outbound.protection.outlook.com [52.101.53.51]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4dwgsddpt3-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 06 May 2026 21:14:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VfJuiuW/RrLqNanrBHEdKtffoF32Iypxn3CHAoNUq6H9L6ajQY6xMSCj5xj3tcXnucT0nfl7R3VIbS7Nx6zh5JD091qeh2zc/mGJguY94DOtTY0/RNEhvOG/TKeWN7L59Y5g3R6VTro2DaVZceQ2tvBZTyT7IZHGYSKsnYBcfSgIIMrz77Q1suMOJIJ29cJP3ZCwVEbp/ksDB3RedHXHiRnZLqqyqJttfNYa31zpDyv8ruAg81QDQvenM6JTyNRK5I+2CM6ajkCdP8sQlfmHXD85dkAQ5+yJML1355oxibffcMNIQNFDQ83fxN3sS5qqAB5iZI5G2KBeRvyDHzENjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nFJdsw7t+OMjxc6O4iWZ5SWmGyIf4lxm+oHnSYx0uKk=; b=FR1XCZDWyJKaBJJIolhMjhXaWuxTfJOAkECr9mCcSNBloFkFur0eHXUQ10zcw6/3/mMC/W/81m9ZXy7rfgm1nKCFHvV4jmARdcRaqulmUFRa2PcEpVvCrnsJzwLOSc7XjWPZh0LGiGKu5m8BOwFH9RnNiDI4xPJP1rtMqlO1dWjxoJHriIGOR8qu3REbOl1lXpLBadheXZXQfqdFrjS4DI7M6FtJ9I5nQHcpCFPQ2XpiysQFiLBpOU6K4LKgOlSc7YiWMUq4CBQA6cZItpl7QhhTt9oJ2xk7APzoqv5R8n5as1RqgsU2+fZc7kEoaPVVZ+w2ZhyV/f1ue4lUgFh7zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from SN7PR11MB7017.namprd11.prod.outlook.com (2603:10b6:806:2ac::17) by SA0PR11MB7159.namprd11.prod.outlook.com (2603:10b6:806:24b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Thu, 7 May 2026 04:14:02 +0000 Received: from SN7PR11MB7017.namprd11.prod.outlook.com ([fe80::44b9:5767:8577:dee8]) by SN7PR11MB7017.namprd11.prod.outlook.com ([fe80::44b9:5767:8577:dee8%6]) with mapi id 15.20.9891.015; Thu, 7 May 2026 04:14:02 +0000 From: Xiaolei Wang To: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, Frank.li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, jacopo@jmondi.org, guoniu.zhou@nxp.com, s.riedmueller@phytec.de, Xiaolei.Wang@windriver.com Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3 4/4] media: imx8-isi: clean up already-initialized pipes on probe failure Date: Thu, 7 May 2026 12:13:18 +0800 Message-ID: <20260507041318.491594-5-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260507041318.491594-1-xiaolei.wang@windriver.com> References: <20260507041318.491594-1-xiaolei.wang@windriver.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SE2P216CA0026.KORP216.PROD.OUTLOOK.COM (2603:1096:101:114::10) To SN7PR11MB7017.namprd11.prod.outlook.com (2603:10b6:806:2ac::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR11MB7017:EE_|SA0PR11MB7159:EE_ X-MS-Office365-Filtering-Correlation-Id: 05e7f1d5-06af-46a9-2f12-08deabef11f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|56012099003|38350700014|921020|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: gjWTy4gjm5lnXg8AGqLw44zhw18TxmOayQbb2ErKeBHvdHA9Wu1d8mwh2lgPUg3zwFmayfhS9WpHZc6q6K5Mnq+VPQkF6J6W0+cb0313SGgDq4Ok6m7rJG+j/3KXeGlICOO5DwSNnsU81p2ZSduSaSfRGvHfnf6WsdfvLaflvmS0TqBBG8Q45csc9f315ofIviQ0WElNHHn2Qf7BficFttonYR6+nyxuoxF2xToj0hpbHupjMm2/It3zw1zC2IvU/QrbiP5nQP9tYzTke6DMz1ZqIZMwcGpa79GwUmAYGB1/PcQGPdnKE4K9jC0eDpJCmMOpz28PfyEWDa8oMdWtXZBy2bQ6o+Oz2PRQnwVHUnusY7zP0dGp6mL6rpAIXXKXPFc557RJs1P57JAV6j3O5M7kpQB6Qj+v7YKliWMVcP5/jIDuqK1JKnXM1UEH34Jf7qXCvRqiOpRlrUBvOhA8jcHAVeA3of5OyHaG0wWG0pJa6qd7w8Oia6A0u+HVbcUfW/yaxAlQZpybYhZKtuXCrfmOxwj5WtOKXNfGOL08fy9UPCYyfFjjKyWWZGkaQ4A8MD2TBuT7+/sRJGfSizRmL3wGXm5lfiyRhbBkB16ePllvWViYhrjOHuGm2hOThP6IKBUyZNJBXBuJScAYqHdJsW0PB07/LZyVjJgpKsAim4bFagnv20TxjG2gWA5eZRtmN6kx1aJVaFnrnvAeWDoJLmQZI/tMSPlnmH+TrepU2nxiG4qCkcelJJlpn7ku9XTiuvp47FAsxLM7BodFIP5b0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR11MB7017.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(56012099003)(38350700014)(921020)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZbLjRviCbtRpkUXZ97uNFV5BJ/OS22d2C+ZgoZLXtReyonbDHUaFeE6olwJt?= =?us-ascii?Q?TjflCOhG4st2bldFXc94Hwzfn6h1kuXvdI9CqZ5WErsXx7U9WJJZQcEviJQ3?= =?us-ascii?Q?iDMS0mXn7jTnBECVZLTJC00JnSS36zB7y8GlKms9UCTSpKOK3Qj1GKPHDtzd?= =?us-ascii?Q?oae5Sr1yiUCKrb5u1FGofJ9t+DNLKjImsRNx+rrGCEBSeoQnolF2mf+YmEGE?= =?us-ascii?Q?SZBS4yOfhPbFw19s4sd7OvxpwEHUFnhMkPw+FeCpr18GTIC5r7RsHbG6xmFl?= =?us-ascii?Q?F7X0bVePtNYs9TmCY3+qDLx0P8kqN6xDJq/XAxva7U3ewNNhmMcovJpUujuz?= =?us-ascii?Q?xigPxSJrd3c7afIZXx9nRKzzlqqae6fok8We4IAQUs343hlgl1q7z4UV2bhc?= =?us-ascii?Q?i5hvHNfTUXWVzzKGbZYuA+SK7uMxkgRoV2Ne+Vm8fqHOw4XHkmt5Gi2eoiHx?= =?us-ascii?Q?5EELWgN9r0sOFFF6t5V/n2kftdaYLWoJXKR3TwhqTMO64UVxxNs7Fb4M3JmZ?= =?us-ascii?Q?BP2Xg1e61wdxuZ9dUsnC32W0/ioOuketTjWO7gPzE8XOkJXFM2rZygaVROAK?= =?us-ascii?Q?+TBwBmCAbe69C3xDn6JLtIYnEhXKt1F1APce/1mmFBmx9BEJAH5PspvRld/J?= =?us-ascii?Q?7iW2dt1KBpYsY+XkxGvsO3WPKyN7iPbxloahv+ic5WHd2CAYqWlUSJB+DtCQ?= =?us-ascii?Q?L5PNi9u1zC2MRSqQ0E7xhKAV7PlpMwlDs6/QBhrJiBDoDmCK6GN/y5cmoUT9?= =?us-ascii?Q?71LMuxQ75ZhZdfdOg/ipv3vstkKkK1D6GQSEE+s9gzZd5EXZDffRUNKpxfKx?= =?us-ascii?Q?Vkv5E8BJs/S741nk3qz5KWgtaSHjYtuWytwL/3I12c7FiaUbXDZH78tYdjW8?= =?us-ascii?Q?ig3NL3ZaFd+y1TtmR7abyJ4SsyvGx+y7HZxSAKH4mQMFMJxjZ1HZVDFxuk4e?= =?us-ascii?Q?qmvpD1Pak3fAZb9KjpiinY/Fjn5i0/UcCkpxEnEdl0dwtoKEN+leESVsJGTj?= =?us-ascii?Q?g+ACLA28gqPzGq04sQesvqhz74DsPcB2T5uoK27LumSX4FaBBVl3eLjLKnqG?= =?us-ascii?Q?aUQJMGKMfsrvF84OpVH38zzGkBD1pMfEATik9p7DdFugXWW4dRsorvVhvD8X?= =?us-ascii?Q?9nGo6KGkiGghCs+nhxOONhB+tKx0HAIW1pNVRUc3gtTfnfBEc005vnRbP6xy?= =?us-ascii?Q?25BW3ZKiNtEX7G60nr/5YltVW6pyRSwirbAdxl+9mVVsRF5EMV73L6ABCJGx?= =?us-ascii?Q?npS8iGzILOGe8GTMlbnUtRFtzWe7VN8fBaTnmx1iPyhuCsf3jEALLf2fqcyY?= =?us-ascii?Q?jS4p+2X1YMGt+aq9YqnI0wQmGJKo4AYhOwCf/Egk6/NpQC8x5g4ueLK+mjE9?= =?us-ascii?Q?Obse0lCCrQwXIf0wS2jILlE3NUqDhQ2f8j8h0twqTVmo7H+/HCKtLShfnVpK?= =?us-ascii?Q?L2yAOzkzoVdFMqK3RiJx/uBHV8K7hKubU5O+Tust8pGOSaNyPMN/Cj94SO2T?= =?us-ascii?Q?DO3oOZm1ieSTq4Z7LKEAOGdU5yRHhHqvmcOWFrg8URyxL0ghiLcwwE9AbtKG?= =?us-ascii?Q?lK61nMXIg+XSV3Qrtma/UzDKp78aLJ8ywoMVIcPVohB7AzDmHxwc42jfOOb5?= =?us-ascii?Q?XxWKb5m6JNZ8YIkySG1nDWBJb1iWpLPpgg+w3nFYLHTwTuQfudwFHbK84QO6?= =?us-ascii?Q?7bDQU9xCWKTBqj9BEvIoD8R0V0AhE8lkncjAXc3yIxvM5fW5zFBrN+KYGIvQ?= =?us-ascii?Q?TzesSVXj8fVUexzZfcoKEG/zkH4LpcU=3D?= X-Exchange-RoutingPolicyChecked: OphKTThutQ7RT34gD5n73Juog4zSiefukQed72yvzvdfVRYeKD5McIXhFTRQ6q3NVrt+vhDK/Jekg99HnN4NW76YqmUhBJ4s3MuiwfpgR1OwB8P7SffxydlUX6DBMg4O6paW3f/1xmD363VbO31N2Zmblu9VqOgZcFjY82yDkqekslgyCegbiMmerbtxNN8Fgk2xT1JnYFdUvcLf/B3vyWYWVQXbFghzwy7nGa0XCBc9gKS56MJHFKFxDTa7O1/YGCeclH22wdEv+JBs0TX6IbnPZDGsjYNAdQnlUXgmie01Vm6rA5JIF7oklAO6QxFtTVkqSXR2rRSGxDfEkz8kPg== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05e7f1d5-06af-46a9-2f12-08deabef11f2 X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2026 04:14:02.2485 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1mA4uE+rffbP18m1eUbeO8qbAQcKOUr327WOf6grzfk0ILc+cYPZY8IjLexGzaq0gPt+qWxVKFjh2ee/CWB9KcG2fPa62S19KOAR7PnxFp4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB7159 X-Proofpoint-GUID: 4LPWQsQ2TSkX3818o229osFDEPTVBghY X-Authority-Analysis: v=2.4 cv=JeGMa0KV c=1 sm=1 tr=0 ts=69fc118c cx=c_pps a=Q0mMAVO0nY0JadJ+SMvTrQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=iKiJcTA2PjBS6x5JeXcw:22 a=t7CeM3EgAAAA:8 a=P1BnusSwAAAA:8 a=8AirrxEcAAAA:8 a=ipK78nv7T2BkFH_b0c8A:9 a=FdTzh2GWekK77mhwV6Dw:22 a=D0XLA9XvdZm18NrgonBM:22 a=ST-jHhOKWsTCqRlWije3:22 X-Proofpoint-ORIG-GUID: 4LPWQsQ2TSkX3818o229osFDEPTVBghY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDAzOCBTYWx0ZWRfXwvIIG5JAhzxr HDxIKGFwW9v7XT0HyHmPikeC6c35i93LvVfW4xUQJDoEdFtZu9MN0ZVZkyz8DPcDyk5i+5QO+2s AsCCrNEs0BqeaUl3oswJz3yF2DsOmhEsD+TDQMRK6v1DHUIMpNN3W7By60YwG4FcNzdDNwP6/lL eSNdRaUglnEcmScyXM2kL2REPfQXNzAiRw9zCxbRoizYeaaq7j2bvsc6oX1r8xj/Qf0jccVqQqN kMVPurRuIJT8QgZ5CDKbCcfmxMxy35gV1iCXiYR4u5+UPQSPVz1bnCm24CQpEIWJOaZGtL+9ah5 a++RZzg5jCztfBlrXZV9f3ckZcC2bd9sFC7xUmdO9/KA0DYpS2VW25WwwvJwqipSSOUNcREzs8W KP+EUTwVkXQ3cRTbV9sGQC3txch4Z+/4u/C1tIdmmJecxsVkWNPJ/K2xuh2jFv1wbrh6+90TSmR ayq9eI7vCQYvy2SHdyA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070038 Content-Type: text/plain; charset="utf-8" When mxc_isi_pipe_init() fails partway through the channel loop or when mxc_isi_v4l2_init() fails, the already initialized pipes are not cleaned up. Fix this by calling mxc_isi_pipe_cleanup() for each already-initialized pipe in the err_xbar error path. Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") Signed-off-by: Xiaolei Wang Reviewed-by: Laurent Pinchart Reviewed-by: Frank Li --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/= media/platform/nxp/imx8-isi/imx8-isi-core.c index 2d639b789910..e8545761b5ff 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -538,6 +538,8 @@ static int mxc_isi_probe(struct platform_device *pdev) return 0; =20 err_xbar: + while (i--) + mxc_isi_pipe_cleanup(&isi->pipes[i]); mxc_isi_crossbar_cleanup(&isi->crossbar); =20 return ret; --=20 2.43.0