From nobody Sat Jun 13 15:17:41 2026 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8347E1A316E for ; Thu, 7 May 2026 00:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778114190; cv=none; b=CtCF5Ct9t1OLVv+wAB05DHP2gzW2ISTQzPmi15TPQm7DKZ1EEj4VAoX4gyCCGZb2RVDV1dtnq0UP7rrHaMzMRlqijvw3cSbVsQbQBVGbmRlbaT5gcaVum4WytTKZrdtkP1kFE8RWOcVwb+kiX2TLS0aHbeyt5tmcHAmExJhOwNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778114190; c=relaxed/simple; bh=Mg+OWu4To9gP4YDNSbdHOHMDvr+4y0G1KW2eN+mAZ7U=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=gTSdee+ZUHbKCJ9EmgyAGaTK/fYR3RQDY0AdzU2mqj6gicD131nplnlT4yDOCj+c4Jq2TK3+hMXdgw32G1hhAWKg9cAL6ZKXETwpJgafEKQWyV8AlBbf4jJaryiv43SvIEzpGdhvlswIxIGm8cMGZ5v9xIiR+S7+jnRRvBcVFXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--vannapurve.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=sC1wRbmG; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--vannapurve.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sC1wRbmG" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2ba838c5ff1so6454355ad.3 for ; Wed, 06 May 2026 17:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778114188; x=1778718988; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=NtFnsbFhhOhOusiCoeAQB82eTGbdASBkHtbXis4GHx4=; b=sC1wRbmGMjyyeYvZGnmJM1H4kid3UanYpZ10apemXqzPsv5uHYCivpQPaWJdlcy/qN +ZTzqzB4lYXgv6xLaT5fDf+0Ee8US/z53fk5mfImXAXRpJNctOkEQ19CeNYQ2TUlV3Zk hM8kr7z7xINslEQCHKez/i31MB9f/ylfG4y5Dr1wwlCQGYoL/t3/syIplNmiheL0pfbv a9AnAlbpWtvzglraGlvL+qxa6ZtGUwzoHSg5E4XzPoe5uDW29jq4KrUAh2VVtqB+JacN BIqHFo+FPhBXC/KCtH/wnKxGDHEIhVYYJ/Vs2uS8mpbIsi6xv71lrnBvaGcbotImfTyn gHFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778114188; x=1778718988; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NtFnsbFhhOhOusiCoeAQB82eTGbdASBkHtbXis4GHx4=; b=NHog4rtj1nsKkzZBs3C4f4cV/f8shkHINFmmcoeHXOIAGFbenLe1IqKXOdpBguFeS0 bhHeEEXM9sfMYdFkWMsANZH/m0faiExZluKKfIOl4/i60MILQRMGvxEGAMZHZf3wgL8E ul2+wCDcreWRJ8vC8dUVchhPxEmdJ0jH/VNWCbivWSU0VBLfAZ8/bovClzvIjeu0CqO1 rf28F8Bso0allvb7pLCepGWjc94Z+XY9dKi4/FuEFIdxvChfydQMiWKO24J9ZRqTBxsm /5nmnYPIxjv7USsTVB0J3PPDkDK2tYvdZiCeRLnUQHEnhlKHItV2mlRBIvpDvoRwPM1H 5BdQ== X-Forwarded-Encrypted: i=1; AFNElJ8vN8WaH15G/0/pSDzWKRQUOC20Wzht9psyqIAi5ZhobvwAXng6I8lHHZquL/al4xT2hpR67fMvvwN9KXk=@vger.kernel.org X-Gm-Message-State: AOJu0YwArYOa3TY2KG1H2t6lKU+bG6sw6zEoRoTUjUUQNRR6/rCVoZ5/ 4xu6XlzWzGJtOD8w/bX8gNP1k3mtt0P8ZLlH3rU9kb3LNRrjiASWpgRZ57Ex1SB5R1gQAKEDHj7 35UwM4ODSwfQN0w1NYx846w== X-Received: from plbje14.prod.google.com ([2002:a17:903:264e:b0:2ba:316c:2d88]) (user=vannapurve job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:bc4c:b0:2b0:4fb6:85ce with SMTP id d9443c01a7336-2ba79c22188mr38019025ad.21.1778114187534; Wed, 06 May 2026 17:36:27 -0700 (PDT) Date: Thu, 7 May 2026 00:36:12 +0000 In-Reply-To: <20260507003613.1784851-1-vannapurve@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260507003613.1784851-1-vannapurve@google.com> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Message-ID: <20260507003613.1784851-2-vannapurve@google.com> Subject: [PATCH v2 1/2] KVM: x86: Introduce arch specific has_protected_pmu state From: Vishal Annapurve To: seanjc@google.com, pbonzini@redhat.com, dave.hansen@linux.intel.com Cc: rick.p.edgecombe@intel.com, dapeng1.mi@linux.intel.com, mizhang@google.com, kai.huang@intel.com, jmattson@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Vishal Annapurve Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" PMU state for TDX VMs is virtualized by TDX Module [1]. Introduce has_protected_pmu state to track the pmu state for such scenarios. Disable KVM's PMU virtualization framework if pmu state is protected as additional enlightenment is needed within KVM to control/manage the visibility of PMU state to such VMs. Additionally disallow userspace VMM to toggle PMU state using KVM_CAP_PMU_CAPABILITY if pmu state is protected. [1] Section 15.2: https://cdrdv2.intel.com/v1/dl/getContent/733575 Suggested-by: Sean Christopherson Signed-off-by: Vishal Annapurve --- arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/x86.c | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_hos= t.h index c470e40a00aa..8371dcaaed1a 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1422,6 +1422,7 @@ struct kvm_arch { bool has_private_mem; bool has_protected_state; bool has_protected_eoi; + bool has_protected_pmu; bool pre_fault_allowed; struct hlist_head *mmu_page_hash; struct list_head active_mmu_pages; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 0a1b63c63d1a..4836e206f64a 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -6910,7 +6910,8 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, break; =20 mutex_lock(&kvm->lock); - if (!kvm->created_vcpus && !kvm->arch.created_mediated_pmu) { + if (!kvm->created_vcpus && !kvm->arch.created_mediated_pmu && + !kvm->arch.has_protected_pmu) { kvm->arch.enable_pmu =3D !(cap->args[0] & KVM_PMU_CAP_DISABLE); r =3D 0; } @@ -13375,7 +13376,10 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned lon= g type) kvm->arch.default_tsc_khz =3D max_tsc_khz ? : tsc_khz; kvm->arch.apic_bus_cycle_ns =3D APIC_BUS_CYCLE_NS_DEFAULT; kvm->arch.guest_can_read_msr_platform_info =3D true; - kvm->arch.enable_pmu =3D enable_pmu; + if (kvm->arch.has_protected_pmu) + kvm->arch.enable_pmu =3D false; + else + kvm->arch.enable_pmu =3D enable_pmu; =20 #if IS_ENABLED(CONFIG_HYPERV) spin_lock_init(&kvm->arch.hv_root_tdp_lock); --=20 2.54.0.563.g4f69b47b94-goog From nobody Sat Jun 13 15:17:41 2026 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57B1A17B505 for ; Thu, 7 May 2026 00:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778114193; cv=none; b=V4NcfNo2ck5f4Yn+1dxKN34u3O9tOMQtcHBUGPUTL9hM0KYjAZlmOBkq7wIsx7bl5qfO56sRkRUDL/9+V4U0m/mM4CJwREyZ07nuyUJmASiBHRue5WoesNv36TreL61ffUWDqJJAjefX9me6O4ozNeogiOQMaHZEXAacbbZcBR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778114193; c=relaxed/simple; bh=+5AU8rGamF1vecRbKjxWr/lQvmf6a9JLKGAu8xKx96A=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=lJD7vFXuW2aSk6GeP4ZTrfGwApcTUouItqNCvrVWExIcVr/6Sjt+6BOmEDK74nN5KKwvd5p62OIsTWxMGwizozXEWv550NCpN1op/wpaBD+KhDnDHo1UZhVSYj72iZ2nWBONSi6dLvTLssamiQMEvClQYLcIcZ4KerEOO8msBVw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--vannapurve.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fJeO8H1f; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--vannapurve.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fJeO8H1f" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2ba718173d1so6693365ad.0 for ; Wed, 06 May 2026 17:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778114192; x=1778718992; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=DYLKMfHFK1vymHGUXjRxxaujfJ3noxRqbCY5RNLKMH8=; b=fJeO8H1fSh6e4jWF26rByFHywRlXUaa3ZwoO6muRo8lbN/gZxEA+ephaXoQ8urUAsh krGbD85k5OxZuJXy3uffU/d8KqmXE5C7dRhBA93teTB9pwb5JTjetv80sprrf0nLBDBx FO/ymmYmvQ/HFeoBXtagn0VOSFZ6P50tn4oh3diUg1E5zx3wN2KN23JaD5dC0NbnvHDe z4UySFTaP1q4YvXFJ/ZQxZCwcfmFyv2dVdmeSuQgpnZCat2ZiuIpbkqRx0vwkhl/x2No NhM/3MyV/pghsjrT1/F21eXByhMqCrcBLMgVTsw8EDZ+kWReR6fd2gnmY8F0ioaEAXB6 4Zvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778114192; x=1778718992; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DYLKMfHFK1vymHGUXjRxxaujfJ3noxRqbCY5RNLKMH8=; b=YkfGc/pS0h1G4nFR5HZL6njb6ukxUiIEp6zB72fMYuglz00vNU1wFwgpf81OoKEQcK Ywgsvg6dWm/TEvANJbALnIxTPN1wieIIkaD6H+ZNsmgSGQs8TUMWSIqMoj1poCni8Hhd 0axl1b/6O1yjCMfZx0kBpJvNY3CMwTTQIUv5tnE6KT5cI6uLuysMcCtEKasExS1LwFrE kiZje+vhUXYG1V7BXSrWHDGd+fgZYgmwLmmCWWeiHDC9qq9dYTflXNR3JifNABe934VC 4WV0PEeJDrQlJCwljMBowD6yQhvgj82tJp7RUet2SB4pw5//XoVeMl63VlXNBDipBZFl llYw== X-Forwarded-Encrypted: i=1; AFNElJ8AM8a4Iv4Mcn8icsq0hPLAvJAufa04nFa+/KG3bBPGK1RDB1ZLPcmlzNICKsljNsUnXblqpnc5LBgR+mE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywv7ou75ek80ko7FbTvbvROEcogC+UbUfmd0c+MRdNxTex8jks6 TmvIQDW/UKser6C6GoBRwug81vogmOL8AhRM+r4yKLZkHJdusagFT8IzfwbM+CIg4XAC2gegFQd aQmEfDlMXsIkSk7KZuATcbA== X-Received: from plmk4.prod.google.com ([2002:a17:903:1804:b0:2ba:1011:efb7]) (user=vannapurve job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:2bcb:b0:2ba:924b:3948 with SMTP id d9443c01a7336-2ba924b3b5bmr38996695ad.15.1778114191481; Wed, 06 May 2026 17:36:31 -0700 (PDT) Date: Thu, 7 May 2026 00:36:13 +0000 In-Reply-To: <20260507003613.1784851-1-vannapurve@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260507003613.1784851-1-vannapurve@google.com> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Message-ID: <20260507003613.1784851-3-vannapurve@google.com> Subject: [PATCH v2 2/2] KVM: TDX: Set the has_protected_pmu flag for TDX VMs From: Vishal Annapurve To: seanjc@google.com, pbonzini@redhat.com, dave.hansen@linux.intel.com Cc: rick.p.edgecombe@intel.com, dapeng1.mi@linux.intel.com, mizhang@google.com, kai.huang@intel.com, jmattson@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Vishal Annapurve Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" TDX module virtualizes PMU for TDX VMs[1]. Host has following toggles to control the PMU functionality exposed to TDX VMs: 1) Configure TD_PARAMS to allow guests to use performance monitoring. 2) Restrict the TD to a subset of the PEBS counters if supported. 3) Limit the TD to setup a certain perfmon events using basic/enhanced event filtering. KVM will need to be enlightened to support these toggles. Explicitly set the hast_protected_pmu flag to avoid KVM trying to manage PMU state for TDX VMs using existing PMU virtualization framework. [1] Section 15.2: https://cdrdv2.intel.com/v1/dl/getContent/733575 Suggested-by: Sean Christopherson Signed-off-by: Vishal Annapurve --- arch/x86/kvm/vmx/tdx.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c index 1e47c194af53..eb4b4518e6f0 100644 --- a/arch/x86/kvm/vmx/tdx.c +++ b/arch/x86/kvm/vmx/tdx.c @@ -638,6 +638,12 @@ int tdx_vm_init(struct kvm *kvm) kvm->arch.has_private_mem =3D true; kvm->arch.disabled_quirks |=3D KVM_X86_QUIRK_IGNORE_GUEST_PAT; =20 + /* + * PMU support is provided by the TDX-Module (if enabled for the VM). + * From KVM's perspective, the VM doesn't have a virtual PMU. + */ + kvm->arch.has_protected_pmu =3D true; + /* * Because guest TD is protected, VMM can't parse the instruction in TD. * Instead, guest uses MMIO hypercall. For unmodified device driver, --=20 2.54.0.563.g4f69b47b94-goog