From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DEE43E958D for ; Thu, 7 May 2026 13:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158997; cv=none; b=iFuiwMHwgSyba41h2bR2+9CaGPO8w7mtGVpEBXnV+MXtp5dvkTsassjPmVqBLywIXT2NAwCSPX45xewFKSTaL7L/wO+h/NYGwOWTVJgxIzI87GFDtBtSq7ApYTP6DCzb4eZKCKt3L0WXQCe8AkYPPzySVAPjwjYPQVN4Nr66e0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158997; c=relaxed/simple; bh=Kozu0wunncGvYwCG5EH0ZsQjFu8nlXDiqIvydxEUX6s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=INUOFU+XjBnV4xjDAGZVpT89p6aNdztIoAdUCD39yserxgKoaS5y6IPuBzqV+ooy/UCFJAgVm431rmx3BxP34ObloCi3HuxDH3v1Gut8xeCGHV7iHAploG95Ql6w2H+d4/ffhFw2cLKnWKpulSPwgBoBpSnXTKrmQZF0bMn0Jzs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VUMptlAl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C7CJlV3o; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VUMptlAl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C7CJlV3o" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647AC8Oj879575 for ; Thu, 7 May 2026 13:03:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X6KUz3wSpH7ohTMCjp5EmeujJBZNyid0Bpvz882EV38=; b=VUMptlAlo1TVA70F 61wpVKQ1v996U4LqVu2BBGgtvmovvg0BYn3Z2NxLU8fCqfS6CDyK1kCDilzXTkCT in7QpARgnigAnGjcMfEMkxqplib5EPXRzOCRXpqx3Lkkw2LeCIRv06vKsKvVAvTu TWQwaWd/A1B1i3NljhonbJia70FJGEMlVTYzcrZBXq6lITkoEZZR8WSozUo4DECd I/SqRugFuZqwbGalVaisugiVT2PP45ERn98ZMTH1dgBDIvt5LtqW0YnPJGzpTMLh bojmZiF8jYk++nZwFV6/1t3HONfvoUH8oD2HxoIcfuO/3qxNooG4Zv2raG67sjlg o1bccg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kdq1v85-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:14 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ba115ab6bbso8406565ad.3 for ; Thu, 07 May 2026 06:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778158993; x=1778763793; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X6KUz3wSpH7ohTMCjp5EmeujJBZNyid0Bpvz882EV38=; b=C7CJlV3oZyuYc3CHvrhcHi5axCcT1vIX3y72KRVM5i8J9ygGBopfmiS1RZ520keF2e unO2UN3apro9laKYJnFDwTHk0bBegfsbI5OM9yYIeDw5ln2lwoGwW5tYrbtBGHrpKttj 8HU0BbXNRvtDkLTz/Xs0fouGqfjERTVHxOaitQk/kP6wNJ+UvejswtrJByOziV/I940g 6Rczp+PeWRU/KNHe+7kA2d8yCYehIbeyq0CM9eccMVweo02wnTwrNw3RmDuOxYrohk1g 22ZMdXeP6fBWd8KC/ODEYgW+7aKGYBmCBKBJeqwN87yd5BvTJnk1mgRzNNZgXeDxCqFB FJLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778158993; x=1778763793; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=X6KUz3wSpH7ohTMCjp5EmeujJBZNyid0Bpvz882EV38=; b=qM2U8Yg2g3M4Dlk547APU79XGykDeurMeHNRtQfIAiBLL+d6eK0TxEpjHASGX1xAXB DuVULZG45QP/T8snFDoeVUAnuDfAZCB/+KjvV1UNlvS3iEr4vYOTQVmgbH4wLJnGGZ6Z 67fU+ZKuVLFFLbkGkT2UeRQruJrWzFkvp1EcVNGlVG92fU4ozFopYOKJHJHrdwro7h5m pCGGFZWdPewdHAIfmQi4v3qL7uek2HI/q8qKL9Ij3TvT69tTFADEe6NY93UbZD8iMoGV ciEBHiYKFN67x8ohYtikaAP3TgexQDABY8yS0vZNAHD1C0pwI3iFHM51OlHflopnzQVp nSpg== X-Forwarded-Encrypted: i=1; AFNElJ9z8iVr8sU/sfJVjt1URdXdgKEuQTzaX2rugbfpng2uBzVk3fKm+BounRcM3hWTaABEJHdZ5nlC6rDnEyw=@vger.kernel.org X-Gm-Message-State: AOJu0YypnttKcZA3G+9Pv9d9zmh4C2YFxO7qI6dxhIGe7bhKoJCTaqqd t6TDulYnXfCeN3vnClXP0leK37ejSf02EGxnioJrG0k0EPPR0KKc0R+ZthzsJdjDh+DJomR0WYL jF+AduZLmat6136rSlsDA7KnLUbnaNZDtpSVGLEUtDPfzd1zamsiifQdmBY251fdfU2w= X-Gm-Gg: AeBDieuamF/Et7cvEO67ALZEAa8h2WYGFuJNcGIUgScJVGc6YdM2LMk6fOJfnZbIpk+ eHhDBQ+JCH75T1bqm4GXlqf4yNViZiniiT2DdsC1geuM6bVHDOkFTpEw65fBkk1p8o34C2wb+CO 4/lSx+kgq+4qggef4vbj8fDSVzuw7A5dQk4d9jhKeDFEFgBydV7wJzNWdTvUESHep2p14W5SCHI kszAe3x/7fJN5I9deDWGXXEbl/c7OeGgItLKnp/jNfev/Lnaa6gba7PtivVzu+ma4tN+9xrEAF2 obE0zgZcrzLTGbq3nBTaiUrmhWWQRJAPFiKIHl+xMlHepV5kx8tr06pna/ea7e3SwFGS+SAMptP BBWRbO0HXGiaJNWYCRuqFlRZR2nQVHyKew8IL69p7dtbZPMfut34Zv5rw9jv9zhAUUal8j9agMB ZNL5slmjkMEKtjqTfA07xLhxmy321OiMOjfLVm/peDQniC+Q== X-Received: by 2002:a17:902:8c82:b0:2b7:8a56:7cda with SMTP id d9443c01a7336-2ba79285cc2mr58205375ad.4.1778158991388; Thu, 07 May 2026 06:03:11 -0700 (PDT) X-Received: by 2002:a17:902:8c82:b0:2b7:8a56:7cda with SMTP id d9443c01a7336-2ba79285cc2mr58203655ad.4.1778158989667; Thu, 07 May 2026 06:03:09 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:07 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:02:57 +0300 Subject: [PATCH v4 01/29] drm/msm/mdss: correct UBWC programming sequences Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-1-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=6675; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Kozu0wunncGvYwCG5EH0ZsQjFu8nlXDiqIvydxEUX6s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2E/+1U6HEdnE740NkmOXVyfKbayNLqAo9yZ Dtd+73Xiu6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhAAKCRCLPIo+Aiko 1aSfB/4gonTvop5lJAUXSXXvIwDUphUXziJNTZU3Aa3tL2ndJdNPg5yB86gIYa3ZH7nfKERX0Gq PYhZ+jF6MQhuZTSvCeSc6C64q+XyI6xxqBnsOSaiINkjZ3d/zcqNhzOJjvhsi2I8p95Rwjk0YH2 WgR6HxMikNQyGdZpkb2q0aWBqVJBhIAe8TXpV857f8HbqwIVx+Irovjx8BjcUA2vVYQzPPUQ+9C BwYwvfaJz2d/PALHzUfNAS3tPa/du6C/5kyJL7FWUQRez4J3llME/b3q6uztt/rx69oKN3VJgOD FjIddyeP7h0a88l6C9H40Lnoz174Kr5cI8vIo4vUYeTAzf0n X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=P6IKQCAu c=1 sm=1 tr=0 ts=69fc8d92 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=hQCg4X1xv2bm5S_WMKMA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: ufd8VJW_osheOHXQREKKNPo73Trp-VdW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfXzYTTaFU1ACC8 bJlrf9lFTiGSFHbtcfM2o+FLQ8wMmySc7FoN8G6yLA9loHv7oBf64YgBJlZivAau9teQl4YASJF TPPhVE5w9FCRnHIvGfnOnLItnObKH0aezw+2kC2BbZK7MsNbG2tHxCZKG5LnwBFhkEYXqPLetdu gVyzFs6k3eeGZpLW5JSQHJrnGuU25sHRdYQtzAB7TXiuIvzdd/+SWrnXnH/UBiy1UQ76gRGufpB OLsYoQBrvEwcwlG0kw60T2/KIYZyzUdLgWkprCh/VtNiQLvKulJIAkzQDrFApDmQNcpY2cFE4nr GkYeTEAlDt2Ifba8bwCKEtQdH8rJSwcaIIug2oa2NAB+xq05H8SdzR5JIylOY8mEcqunpwBNkSa kJqAGSucmrKUh7/tjhyasJB3DRcw9ataB3kzU9MYd/JP3xgOCKFXbLRF1hgEdqUI+Q/o9ku96gX OPtsgr19M9YNyx/nFaA== X-Proofpoint-GUID: ufd8VJW_osheOHXQREKKNPo73Trp-VdW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 The UBWC registers in the MDSS region are not dependent on the UBWC version (it is an invalid assumption we inherited from the vendor SDE driver). Instead they are dependent only on the MDSS core revision. Rework UBWC programming to follow MDSS revision and to use required (aka encoder) UBWC version instead of the ubwc_dec_version. Fixes: d68db6069a8e ("drm/msm/mdss: convert UBWC setup to use match data") Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 115 +++++++++++++++----------------------= ---- 1 file changed, 41 insertions(+), 74 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 90c3fa0681a0..4a6acd468bc8 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -166,22 +166,19 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *= msm_mdss) return 0; } =20 -static void msm_mdss_setup_ubwc_dec_20(struct msm_mdss *msm_mdss) +static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->ubwc_bank_spread) - value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; - if (data->ubwc_enc_version =3D=3D UBWC_1_0) value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } =20 -static void msm_mdss_setup_ubwc_dec_30(struct msm_mdss *msm_mdss) +static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | @@ -199,11 +196,12 @@ static void msm_mdss_setup_ubwc_dec_30(struct msm_mds= s *msm_mdss) writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } =20 -static void msm_mdss_setup_ubwc_dec_40(struct msm_mdss *msm_mdss) +static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); + u32 ver, prediction_mode; =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -211,45 +209,42 @@ static void msm_mdss_setup_ubwc_dec_40(struct msm_mds= s *msm_mdss) if (data->macrotile_mode) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 - writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); - - if (data->ubwc_enc_version =3D=3D UBWC_3_0) { - writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - writel_relaxed(0, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); - } else { - if (data->ubwc_dec_version =3D=3D UBWC_4_3) - writel_relaxed(3, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - else - writel_relaxed(2, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); - } -} - -static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss *msm_mdss) -{ - const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | - MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - - if (data->ubwc_bank_spread) - value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; - - if (data->macrotile_mode) - value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; + if (data->ubwc_enc_version =3D=3D UBWC_1_0) + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); =20 - if (data->ubwc_dec_version =3D=3D UBWC_6_0) - writel_relaxed(5, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + if (data->ubwc_enc_version < UBWC_4_0) + prediction_mode =3D 0; else - writel_relaxed(4, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - - writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); + prediction_mode =3D 1; + + if (data->ubwc_enc_version >=3D UBWC_6_0) + ver =3D 5; + else if (data->ubwc_enc_version >=3D UBWC_5_0) + ver =3D 4; + else if (data->ubwc_enc_version >=3D UBWC_4_3) + ver =3D 3; + else if (data->ubwc_enc_version >=3D UBWC_4_0) + ver =3D 2; + else if (data->ubwc_enc_version >=3D UBWC_3_0) + ver =3D 1; + else /* UBWC 1.0 and 2.0 */ + ver =3D 0; + + writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION= _MODE); } =20 +#define MDSS_HW_VER(major, minor, step) \ + ((((major) & 0xf) << 28) | \ + (((minor) & 0xfff) << 16) | \ + ((step) & 0xffff)) + static int msm_mdss_enable(struct msm_mdss *msm_mdss) { int ret, i; + u32 hw_rev; =20 /* * Several components have AXI clocks that can only be turned on if @@ -283,43 +278,15 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss) if (msm_mdss->is_mdp5 || !msm_mdss->mdss_data) return 0; =20 - /* - * ubwc config is part of the "mdss" region which is not accessible - * from the rest of the driver. hardcode known configurations here - * - * Decoder version can be read from the UBWC_DEC_HW_VERSION reg, - * UBWC_n and the rest of params comes from hw data. - */ - switch (msm_mdss->mdss_data->ubwc_dec_version) { - case 0: /* no UBWC */ - case UBWC_1_0: - /* do nothing */ - break; - case UBWC_2_0: - msm_mdss_setup_ubwc_dec_20(msm_mdss); - break; - case UBWC_3_0: - msm_mdss_setup_ubwc_dec_30(msm_mdss); - break; - case UBWC_4_0: - case UBWC_4_3: - msm_mdss_setup_ubwc_dec_40(msm_mdss); - break; - case UBWC_5_0: - msm_mdss_setup_ubwc_dec_50(msm_mdss); - break; - case UBWC_6_0: - msm_mdss_setup_ubwc_dec_50(msm_mdss); - break; - default: - dev_err(msm_mdss->dev, "Unsupported UBWC decoder version %x\n", - msm_mdss->mdss_data->ubwc_dec_version); - dev_err(msm_mdss->dev, "HW_REV: 0x%x\n", - readl_relaxed(msm_mdss->mmio + REG_MDSS_HW_VERSION)); - dev_err(msm_mdss->dev, "UBWC_DEC_HW_VERSION: 0x%x\n", - readl_relaxed(msm_mdss->mmio + REG_MDSS_UBWC_DEC_HW_VERSION)); - break; - } + hw_rev =3D readl_relaxed(msm_mdss->mmio + REG_MDSS_HW_VERSION); + + if (hw_rev >=3D MDSS_HW_VER(6, 0, 0)) + msm_mdss_6x_setup_ubwc(msm_mdss); + else if (hw_rev >=3D MDSS_HW_VER(5, 0, 0)) + msm_mdss_5x_setup_ubwc(msm_mdss); + else if (hw_rev >=3D MDSS_HW_VER(4, 0, 0)) + msm_mdss_4x_setup_ubwc(msm_mdss); + /* else UBWC 1.0 or none, no params to program */ =20 return ret; } --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0EDE3ED13E for ; Thu, 7 May 2026 13:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158996; cv=none; b=gY6MyVyzgk7L+XllpL92IB0qsX/hdS+gWh4dfSSqDh0Cn7foTHxw1ZnkuugUuYOtjP4dMFU8RBPk2it2BcfTW99qYDfGRRbFMCGyGAZ5Mk79UsKsrE4HaZ7QBEpq6SUKOmK3Qxc1OntihBJwbiRhxKh1rktfht9hxvEXTElCu2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158996; c=relaxed/simple; bh=0jnnTKmBVzx8ajx5YR0+k88TfAux9nzkeECglU8qUoc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j8OBq41/qWeYl9nSfMlMWLGCZJCD6mGM3e0agw4k7/okRNC2R8BfgFayoY5ved/zBHVpBqmJRUjKERspyq+uGbP2SbKr5FILQa7owLDC+fdb4laMUgN+LPNcKwo2AVHGqX/n5+h1hoOKRZqnrIRz+usMiFypwxjGQsiDiCbQ9lw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CNB1LCzS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VtARs64W; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CNB1LCzS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VtARs64W" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647AGn57150864 for ; Thu, 7 May 2026 13:03:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DhLMvVZQbF3J03WMc2id/1RoXxcDZvjE9wQx5sGd7p4=; b=CNB1LCzSwOaKUMqW NuVAsiSTWgDFOpjphs/iTMewl09ugzqTVyUcWEnw7xBvF1z+mCuCXYX40KQ4DLJI U7KCVEFc3yCffY5gXGRyqiJDo03XnO7660Gqn8PfKg32pLDMX7OFlbm5p5qtgpCN hEFDk68rkp0JV4hYj4dhFKugs21hqHoOEXtTW/WvCqrR4evS7jB1z9uJuG0JPb4g lMunFZWShQAZQt2sXoAorcr5mz5Y/IevtZ2SFueTKuKfBPBW1PgP2UQCvkgmNf+R Ry7evAlORgU06+mnrHa+YL3Hg11RL0uKXENcBpJDF1dhlLGpkmHGuHdLpbCNn0aX JdtbXg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kctsvvm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:13 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b99eb06178so16970935ad.2 for ; Thu, 07 May 2026 06:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778158993; x=1778763793; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DhLMvVZQbF3J03WMc2id/1RoXxcDZvjE9wQx5sGd7p4=; b=VtARs64WePeTl+VjwuMSFMSrWK54GS7LaeG6IUbI3kOSRTrhF7Alq2zTNUzM0hL+9V BY5wGLyGfv1CSdd8R/L8uNV1h6SD0Q5KR6trKTX7wEsZrG07+DwWwQ9QxncBwAmEs7vu wHcWZPvYbjQIx2kr9xvy0Wy4YJRoB3i3K4ejTXPk0HLjRNOFxwusRSvRrmAjpsaBpmTg KAfkEUJQ6i5fl+D4aNnMUnLuEAsb2K8bhSuVskCYUij6tzwuFFiUXM9ZcIg+EK9ptnxW 9gymma6EtAj2pGMPxICY3iYu8vXDsmpnDq8xvawoptvXTzX/K4rQWhBxyowuLuhnqnhM ghbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778158993; x=1778763793; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DhLMvVZQbF3J03WMc2id/1RoXxcDZvjE9wQx5sGd7p4=; b=eYl135GcrnqhaZpytfl4HN5KZ5f+lhJzrl5Q3E3ET2Nfcio0xtQjAq5V18kZ/VDlU0 S4Tv+9sNTw0BZMG/BWCOFp1ezNVDvpmduDhJxkyesE8U3xrzdqSYJHnYtmhT2pcV4H72 w0uySh8gsWzzrwUEkKJLGD4bdf0cRjLodbhC24B50uPVSFGvaQzS4anIgzK5ga7dnt/S vYS6aHbGz7isNlLn1Ln+dOyo6ki0ZPyG1RTH4SnP3tGZHFZFeGLbTOabS7+IbgTMvo1t fNsvjiab4XrFK9QzjEIBRU76Sq1Djrf0PGiEwEDEgrqCNOplqaMLrO7BuBgFrNTW2r2w q4RA== X-Forwarded-Encrypted: i=1; AFNElJ8b/PoJsFJ26E79bckHVu3hdBIiOx3EPIJKJHdboNxghSfRyOfbjC3bUZfVs6e5S8D6DKK9BLleCjOyWmA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5fmEnx23IEcRkV9agWMRkoYco7waoGKzDeFVrRs2rocuaAkW5 agTiD2f03CiBUCfvQPJxAUvstY0cmN2WLc30TLQtiuHEbufWeTURx6GUMzyioFlsZABEaV9q0Ng l8epHDs01tk+hgA859arjHeoLkqjffqRIqstjoM3a/9+jQJ+es7CM2tQovUxgvI+lrZs= X-Gm-Gg: AeBDieta/emt7vNJVFFJcRs21rHzwri48ejO6YgiAh1O2kD39v/QdxzImLQ3KPN+zd6 8XUXWeOKrhSGA/dbPD9/efYHlv1hHe5jhbllsy5iPdTIZdIC3oZ1k0gUhKmxxeq5auGEBT9riv9 2/yUBHeODJZaBnAlRZeWdJb3DpqXpxlpMr3tT6O/ShwsqzdVjot0z7w1ukRvukW7zjTv3/gynJW 6EmqrlYmAceUL5JMoiJILwsqxlre4c+FlJ2GMFFJa9aqMIk4V/3wg9ZdzR4INtcXngxJ/DV2IFy UgrCkFERRYy+DTDatA0ZS5TAlMVPY4UCL9hXtXpwS2ouY+1CjYmzwTH4NcwVHLTiUgMDXUu2BSL zmCDQi62R1+zt4+W3vu4s8LtSFtrptx/iYO7LHcDgdxMYWjZsQ0FBK2Lw7IWFmZkE8205THZlDd QDd+rhxFJsbrm7wE3O1o/zNHV6UdqLojHmnvbBhf8HX5lIPg== X-Received: by 2002:a17:902:b585:b0:2b9:fb0b:b727 with SMTP id d9443c01a7336-2ba7a323e95mr58398755ad.39.1778158992695; Thu, 07 May 2026 06:03:12 -0700 (PDT) X-Received: by 2002:a17:902:b585:b0:2b9:fb0b:b727 with SMTP id d9443c01a7336-2ba7a323e95mr58398055ad.39.1778158992064; Thu, 07 May 2026 06:03:12 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:10 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:02:58 +0300 Subject: [PATCH v4 02/29] soc: qcom: ubwc: define UBWC 3.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-2-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=914; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=0jnnTKmBVzx8ajx5YR0+k88TfAux9nzkeECglU8qUoc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2EYco2h9cEnAxnfbeYL8OmlrpKoaezSZZYQ M1+0MKnP8OJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhAAKCRCLPIo+Aiko 1cGOB/0a01YO+OhyeKDba/Mk5dawJ0/xsqEaxlKqEVt7oSTAVlAyxCd1r4SS/Ho2BPiOU/dvZs9 6CkDY4NRK6YNqsShekmPuNnzcBpyA1zGh9pNq/cTnOyu8oQDEExBEuBqaCpqQ8M2qlUjvw019hy YiuGs0SLGhYwMKoF4tsHYNP8kpfDpfOwjEPJ+CSVwfBFIx7KM2hwfQjKb4t0CPCZPJy0wab3cLb 6571OMLfaI5iOI34b6rglUpLOmEygigjKCAXgDh+Q1o3a9u9IfIZxK/ek4Hj9CTU5HO6Zau6tC+ 5X2jDy7+Ln38yc6lmkcL4EC4P8F31swGe1MNTKRqTNmR3D6T X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=XsPK/1F9 c=1 sm=1 tr=0 ts=69fc8d91 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=o8D1m1ilSIXDguKSM1sA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: a11B_q3eQFFMsKqhy1voIv8EDZhXvnCu X-Proofpoint-ORIG-GUID: a11B_q3eQFFMsKqhy1voIv8EDZhXvnCu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfXwFfMPMofUqx2 jerk/czTXUfXHETon2oScCBPiFgnhwTaXFatRkYoDg9MF2NY1BGCbOeb3zlp3VSbnBxBPeTxkmG Ik07lHhUjUWTzhMmgPkBsWuBlBwIO7jtX/ylQiulMv2aZjhq1OQBps+5RQZh1bL1/MU6UFZbYY0 9S2g+zXqSERCuONuUiarofdsSvLO7cj+DipAnA/Da7DWrMYtyZXjTHnsH/zIs2Kqe6kyk923p7I naLIwfNpcEM5n8fawYjkfIK0dkA9u9ga44dFeCg8EHUD7CuhrcSWbcfdhN1Bs5IPvfn8q27EuuV TmVTvfkwpOExn498w4J/ydv4h3BXZFTdZxVgBwQUJOJ+AQG6x1sQmtRbnKaLepGgXCGS5uAd48s RbPcgCcnvlJUfgXUdzbI9FdlA2BnjpQa+e8apUSHvMIjOivMbMtQR7ZoBYIo56Xs+sLeMZw3UFA l/VqzUarJ5wcZKPhXCA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Follow the comment for the macrotile_mode and introduce separate revision for UBWC 3.0 + 8-channel macrotiling mode. It is not used by the database (since the drivers are not yet changed to handle it yet). Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- include/linux/soc/qcom/ubwc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index f5d0e2341261..319caed88775 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -50,6 +50,7 @@ struct qcom_ubwc_cfg_data { #define UBWC_1_0 0x10000000 #define UBWC_2_0 0x20000000 #define UBWC_3_0 0x30000000 +#define UBWC_3_1 0x30010000 /* UBWC 3.0 + Macrotile mode */ #define UBWC_4_0 0x40000000 #define UBWC_4_3 0x40030000 #define UBWC_5_0 0x50000000 --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44CED3F23D8 for ; Thu, 7 May 2026 13:03:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158999; cv=none; b=VUyYV3u8lCaV/1x/EHySL5xYvYfSenyHwDwQJk7FQbYHfuovgNYUW3b+MohrV+LhZUXJfSDjCMxcqapGqZjvjKuzY2tzGiAgHbxcV7KWOIlH/GTCnnDDGo8FH9LnkDURHow7izaNsCmQi84KqZgC8vML8etrRv5aV31mAvje5E8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158999; c=relaxed/simple; bh=NJiVsMMKzJws+Cks3lRdvlT1mL0gwv+c/6r+WaGQjLw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bdhBWndw86fIrWLuuELUu+cGQhENet+z214/CZ9YZ3zC/gqvvsmVvlP5MQWjEWA4IaBtP3GsYr6ZltV8DyLjIe065yFQua958pLxDRup4STWkp8Q7JYe3sJ3PtGFQOJeENim22AJbvWv68vuz1mrx6XQPfIUn3kfOBjpsoJuwy4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gPADgdc2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HsVP4JiC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gPADgdc2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HsVP4JiC" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6479AHUD258798 for ; Thu, 7 May 2026 13:03:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Jnv3IJHVveO9Wr2l9i2vrKyKNiwoqkqE7X6w0Obsuxs=; b=gPADgdc2GN4ODD2S 8381BlK7gBkFVvMWEq/3/bPMJpe0CImOdd326DS23RObjVb/DVr4nxobiI3QdtN7 SfPVeDbc9IOyaGj5CMll/snKoE3Kl9F7muRknQ67dGhwhQDvRP02bwHYkYlqUK+G CntKtL659EtMQ7LUNSlU4p8ILfXSwT7vpb7fU4lBjAeTNYTjdUxQHXlUa+qGxnjl 1DVj7/OGBrtdWrQ1xFx5CmKHNTCa+G/mrc8bJgBO0jBRZHmiUpNvqzyJy/WMeO/l rzT/qHPJC0/BBE1bjL2YgOo52IGztoSNXdkti9lBVabf6DZ1eq+lsshl7yf+huMH CL4xBQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0hr8t7h7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:16 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ba268cb5e6so10763485ad.1 for ; Thu, 07 May 2026 06:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778158996; x=1778763796; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Jnv3IJHVveO9Wr2l9i2vrKyKNiwoqkqE7X6w0Obsuxs=; b=HsVP4JiCpq+Rd3WLiySkP1P86KV1efOMDDaC4qDEaeZQKmgeTzWn7mNHj5ZSmF08/x lzJGZxhuglGoMUr831qp0lo1EtJsELQuqB0M0OAiMwJY/t1kN/zOqc6CiTQVTJLXN7Tk GomkqcFoOYN1xTYMdmF+iCLSjzWRquV12YvH8lZHhWhu6aJCgkDTTz4Ix9pnArn+Pm2P fzPcXYDR7txK6pf2jmoa1Dtgp5faO78OCOvU3co4H3MfM6Wk4MCoP4io48jTrGus8UqE BygL5W5wIFliDK4aTbkXZcOsGt5kB6YX8tA37Jen8oWKItDRXs9YKbrZ1cQw6HUj9wIe SvAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778158996; x=1778763796; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Jnv3IJHVveO9Wr2l9i2vrKyKNiwoqkqE7X6w0Obsuxs=; b=APwd3GU1rgR3DKcTxPyN86ES4DwinRttFAbuYPGaEYJ6y1FcLNtCqDExZABFn1ql3W hC6L0oLn+SpWa/1Qtt+2P9LwzmhcDHJzxUsFSUlwKYMSaBPCbh7sxzUR2HA8CrKI7PqT vOFCArrXVrGE/05+Yiu0uISwoXIdO1SEkplsihqtWzUlq2DrZAqEtHzMmvUphXRXzoep /U+w15sNjG714RVmr2xoitgIhi6Q+UQGI/5Jvw6l23wKB/MnDS2Zx/xYkTJFmKll9MMW LqcXYoLLA33IsfOe7aQGtzVsDVvehpYsirEbtc7et0YX4Kob6B2WJhoDOTca5ozDZ/HO gx6A== X-Forwarded-Encrypted: i=1; AFNElJ8KcYAT4ypkig02LP4pZM9YhdiASzxhnaIOeUa+Sjj7qyAFqY38jUS6bo3xtzt8AIv4n0TXov2Fv6Mqvg8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywyzanaax0Ap2zMjTOsle1VU1BsyGWPzwhyqBWaCIh239tzisns LaNpvNznBt/YGPHI0fU5MDlNrjZ2ApWiK7Oj9PBF2iJBNgeILpY9SYrBJW8ZAczBxhQwzf1IXf+ l1ok2I72sYN8R4vMO0DNlyIkfh8c/LBPVkA/1FysgwB9LDfLYrvv+4TANXRmo86Y0+54= X-Gm-Gg: AeBDiet6DJM1AESYvuFGItE52i7pIwcjOMAL9OJiW4r5coyyn5BnnX/WQl84eTVublr emaV1F5hdaoLXXseKlZhDAgZVWUrtkViWlHhqS5oGYuY2hxFRvcuiMEWOol5fqRiUjK7kqY1/1a s5mRQsHiyEX0j9i1o6PZlnvTqXHJKhXEUtpVTXXQxcVvu2J63CucrGPxync1+xlzdNhqwa/iFo+ mYAleuQB7ktBhJ6FprRIIKCz47QY7zKAxBGKZ/7FtoNrkpECq5cc0DGR3qx/TaorEoSPEFhFYy7 wGy4uQAXaBWIXpm3U/cSxzF+wTsQ1l/UW2A+b1QjF0hg2IkuuzLLhD06il1G9iSRU4P+cEuk8Ic I74Cms84q//kpXYwa/Sr65+kW51uYIxq+/BLf47llFlash49nc2Ka4iA8KCcUZyBwm/Yq8pE5Xh PalkJAUmeR3JRVWLfDMCZHgU/v2O9NjepNTCdrwkNnbfsvmw== X-Received: by 2002:a17:902:db04:b0:2ae:cb0e:fd59 with SMTP id d9443c01a7336-2ba78b30aaamr81120735ad.8.1778158995398; Thu, 07 May 2026 06:03:15 -0700 (PDT) X-Received: by 2002:a17:902:db04:b0:2ae:cb0e:fd59 with SMTP id d9443c01a7336-2ba78b30aaamr81119995ad.8.1778158994785; Thu, 07 May 2026 06:03:14 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:12 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:02:59 +0300 Subject: [PATCH v4 03/29] soc: qcom: ubwc: define helper for MDSS and Adreno drivers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-3-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1061; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=NJiVsMMKzJws+Cks3lRdvlT1mL0gwv+c/6r+WaGQjLw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2EJ+8pOGUuuyBu0o3d2qvdC5hAWHh0TuDb8 WyeNkc7lx2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhAAKCRCLPIo+Aiko 1R8lB/4uHk56IVUJ/QuYvoKuKjNL+ak7J6dJHZKiFN8JN1hLoBndS8JqNZOmU3587DTMScfG+pC 6vURC07s5Xwy3SlbakACSDvXGN7fqw7iE0CKwknZArh/qSOa53WZh5DBzwz70aVX9QaYz8Mlf8J Abzsnm4vFGBmnDj+xxtBEN9VdW2qaNDPqDzxyEjtp9JdX24AGk8s6AwhWgg/eL440WFM9ZUWnV5 Qt76sg8u5vuvf65Ld+VLGRJRifa9FDIoPyNgA+aCYrcKu1HO1dAXIhtimmFk3cMPY2O1YWOC5R/ X0+RGieOanVvF+uMil3Eo7SKo+jGxFoYF4EW/LERe2G1QVTc X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: 3ioYlQ3ZDxMpNJjQU8gnvj2ghQXRzJsZ X-Authority-Analysis: v=2.4 cv=caHiaHDM c=1 sm=1 tr=0 ts=69fc8d94 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=TXJx5zmxIxDbTTGRO54A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: 3ioYlQ3ZDxMpNJjQU8gnvj2ghQXRzJsZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX4c3tIqfXJ+XC 34vCcuDUgJ66TVC5ipyYPYoBZlZx0DxzcEQHvK0/K23Tfcdn2SlGCkhKYTqS3a3mB03Xig1XXYT MmeXlvQQDeW8XPCOhDOlnX3FF3Gkrw7Yj+yw834LioOmiDWkLbP3Gv3ztWdpwNw0sMRwgAAS847 VBvXCmfb2frz1t1Rdkkmq5rkYuPTAZeR6KT699c/WH2Mry75OP4OUsZ+LWP2fEaRUJGBThwKaOk 3I5QYx4XrdBDxlVhBUul/PZj8yddswFBwwxkin8XbHSV9dQ7sGDJw1n/IUIlfOwUpEm4Su5nD4b gqUUXimnBXZRXllxjwuu72cN8w+uQXuMnzikTxImiiRKgXNa5nZ3h3bxubuPUiNfg+HTOu4GpIB bPZWKGR9O+fUvY0nu1JoB3JQQxMhzUNu3pcxr+gO9TP4d5ioDwtwA6/jLhDV/rSFRnrKIw7vK6G 8Inq5laNcLF6QQ3PJvw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Define special helper returning version setting for MDSS and A8xx drivers. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- include/linux/soc/qcom/ubwc.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 319caed88775..8355ffe40f88 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -100,4 +100,20 @@ static inline u32 qcom_ubwc_swizzle(const struct qcom_= ubwc_cfg_data *cfg) return cfg->ubwc_swizzle; } =20 +static inline u32 qcom_ubwc_version_tag(const struct qcom_ubwc_cfg_data *c= fg) +{ + if (cfg->ubwc_enc_version >=3D UBWC_6_0) + return 5; + if (cfg->ubwc_enc_version >=3D UBWC_5_0) + return 4; + if (cfg->ubwc_enc_version >=3D UBWC_4_3) + return 3; + if (cfg->ubwc_enc_version >=3D UBWC_4_0) + return 2; + if (cfg->ubwc_enc_version >=3D UBWC_3_0) + return 1; + + return 0; +} + #endif /* __QCOM_UBWC_H__ */ --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD1E53F54AC for ; Thu, 7 May 2026 13:03:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159001; cv=none; b=pmrIPPvzBtnaYzDxeIe/7dLKndfju4eoNbBM+yuD1JCBrbJzNqzc9BJtNnTp7iS3sMn7u4bUVF0lOS6Jyb7v0lERj6s8jsSQAyD++kr2vldpfw2E2qf135VLTElMiT3nznI0f2d9Zv8fAbx0p59w6zy3CHapZGb/hG1MgZUrJIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159001; c=relaxed/simple; bh=DVzUVHYL1LwQyydsa5bse8Qdux0+ATejKvt7PdcnILs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kkWk4qZrkHDu1bcgcrUvE33gCTl47tV57UgWJfq0Do1cslpDGgzwO8tIhW7cK6IJM3nr992ozGiIag9+A5CSj7gi2THThyxvw3mYgU6wejYDBtZZFwJD0BObwsMPPK5xziIfPmhhc3JiY9PV0c6uLpWo+lfqrDObyR0+zchJPMc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n9b3PVLS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=chjbiONy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n9b3PVLS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="chjbiONy" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BZOhR3156913 for ; Thu, 7 May 2026 13:03:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l4shwfMjGLnh2T+SL6QX2H/uv+6YZBYhzZVvBdIDpp0=; b=n9b3PVLShnKv6Sub 2va3HJAJ8W+6JqjBAfRI7bUiojgvER9zWnItOdTuGEhmedATYSmIYiqLXN74gdWl yBF8CEtycNSR9BUc5LKL12sI9MYE4eNLJWBG7DtzL6JjCI6qWAsLT6qeDzIyF5vu +D3q1bwtC2isCguhQChFZAQpvmkcH6sIKBu1klQ9VPhMVgrmgOFoQ2DmmS0OCPas 3lYh5TXkK3D7fUdMBkt7aNBqWfICI9ZmWE7aLRLiKc+321Ruysg2/2EznDAr2Tja NKuwbSV3ahAMMhqW4ZnsUo2AgpChEbDSYOVITkDTvRX2mdmh2DQAtTUavwdNuj0u mmSWnA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0mhf1n02-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:19 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b7aba0af02so10278355ad.2 for ; Thu, 07 May 2026 06:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778158998; x=1778763798; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l4shwfMjGLnh2T+SL6QX2H/uv+6YZBYhzZVvBdIDpp0=; b=chjbiONynWmsYrpBJr+YaJyhzISRrnWDQZM8U85lRTRkgGR3R3qE6iqhf4Ztz25F4U dK0ixv2jSpXASDSWue2M7puY1yoX622TU+oSonC7oICEdyqdW2V5TWF+zpjC3aGqFAx6 IQSbW6h+8bG0GO2IJHtAxtJPQzpWbAwSkCiM+RPA6h2mKB/5U7RFLoLoEvFP1o+I9oT5 O/BJeet0q8yW7UmX8sdrdwYPwk3n7EEzE8g6/g6gJrlt4ICeF6cAcbJxpdMbmIzWLHoV kJbMlgssXLd81lj8MDCwLu7r9+9WbcB8ykNgDGBwR4txZEqqBzDIzQCpqPcbMrGLE9xo 4eJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778158998; x=1778763798; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=l4shwfMjGLnh2T+SL6QX2H/uv+6YZBYhzZVvBdIDpp0=; b=a/f1c2YWTkuoBNjJCyPuhM3UM87jsT778R1Kv05R025n3KZU+CCJD02ykaIz5iv8fY iHpRrSeR5cB0llQt5OXdKOZnf0p24xvrRweNC5XLc9OMhXU1x62ykQUPe4PtuQqH49hh ihZWRHZj+yejiGAgFs8iFIkCwZ49tuDtKBJZ3mOru2jUOdD6CUDo5IaAty4tMfiWSIk1 72W9iy24OdGpcBSoXIPjRS/pt1thRo9NcQjFxhVT5JbM47NUdZjEVu0ogHiPQ2fFwGWr 9TC6ORxSF0Pr4ES3g8dFg5/OLcAMT+XxVPeub3Dw/NvRVxQANqwOGb3gaoYr4xfrPg7n IXYw== X-Forwarded-Encrypted: i=1; AFNElJ9tYG2d/+QRIMqjSOjoyOZ/fDBxmYqHWZBr+gPOc3eZprMMsyw0iiM61DIlYzm2gX8cDqmst5EGZB1voIU=@vger.kernel.org X-Gm-Message-State: AOJu0YzV7akS6P1LfvsuOio7ab1lb9hKlxSqPtx1ECSiz+np/osUlgMn Dg+cFpdk4NQ17vViTmC4WclQ3sR73rUtTJvt6ljlIEZeJxRg+NL4+tandJEgWu1UcCh61I3Lo5r 5VK4AYtuzeApn9aH6derqx0j/KDzEX6d6dr0s8TQaNGDJlrfIe2C48t/ri90qNFa8BMM= X-Gm-Gg: AeBDievAnc3ms9fzeWCO3efyjTxVsQZ1Ms38cgqyhoOWV5cIoeeHAFOJRHgJHJKMKJf aBKJqEJXXMuHkogNYpUPYseROQHHz1YAr9NqZHoRHi8ZxhwzLwEktE/ugNWgAzvcG+zk2FAdMyg Wrv8rViztGDUB/huB+pmUKBfCJmbc6IKdCqCxyZrDcf7Z9XSPCyZEJCLH/gqWHZQq2qzw6+qy6Z hJdJ5A9shmpGKFOqAC67vZX7asrdCDBxw8CjlfuhUqiBuVY4jnm0FBpc+Z22+RP5XC11Xv+pUqA FuQIaxsLAXiUaE81i95Qfi+2RZlP8f1202EZSZwMtZcVElc1EPto5e895wn/6NZAA7xYOE/tt2+ eQg85te8Xo7MREpjf/N/c2zqx0yQEBi4XwVoQQkMC/UbAT0ZV/jSZJMpUOPvDw2NrqSPS3tIWvf MtLWsihD0jz+QuilNYoMPjszSDAy4VD2KgC5NGh18P/wFsig== X-Received: by 2002:a17:903:24f:b0:2b4:5f67:5914 with SMTP id d9443c01a7336-2ba79becc18mr81503715ad.33.1778158998295; Thu, 07 May 2026 06:03:18 -0700 (PDT) X-Received: by 2002:a17:903:24f:b0:2b4:5f67:5914 with SMTP id d9443c01a7336-2ba79becc18mr81502835ad.33.1778158997623; Thu, 07 May 2026 06:03:17 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:15 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:00 +0300 Subject: [PATCH v4 04/29] soc: qcom: ubwc: add helper controlling AMSBC enablement Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-4-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=758; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=DVzUVHYL1LwQyydsa5bse8Qdux0+ATejKvt7PdcnILs=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2EKmwuR6fxUI++RhBWUv+l2sKNuJCq0IGpr K6Db76TRTeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhAAKCRCLPIo+Aiko 1UwfB/4i4Cv+HSxLkStTNKa/XWbofh+QJ0Gqz3qoZKw6T7FhwdmpiiOolnFkFF5AEE41sAPxg0T i0vsFUSQ2ntnpMeKVF0bXJnJC5h2fNCpEWYBbVO2b5ASRno9xQz8K309j/bfAYdJtrHRhVQMqbq 48VSEj68PZAIzKKdCUkFwVaxpIT++76uST4OLalKIOUzAqplAk19wQcRjGfCTL+J3o+SnhcDeUy uVjDyT3q36qtKOyVk6dVcGf6yuwomuHe+54wfgDePNlm7kOCgXU5AiG9EJMI0aVKOJ7teOmKe1i y06GqyY1qb9ah2mnoXoKkR5NWDmrm9tJ4ZMvWi2KnKcRcIJ+ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfXypxOt0HQ3V8g XolewuuwCrO05nOV7xE6BUkps43Cq7qcRUK22MIzmJrg4PsbT+j6vP2FOZqNn9W5m67/CpphaXJ sXQQNvw5THuEyaNMKIoVg0aHdWm6B9lG7UwxlbEh/HkODwjkBwWMg8YsARdkgh3wlBUSmX/5fxO ypEzLs/9qdaYuSP1h5xpi8RFvL3Qg/KFSeG+gqD/rAEkVmUCHMZRzZ3jsz7sxsyRCc45vXnXVfk CIACO/ntwhFdY4Ns5YZIV7UM1kX5zq7m1whoKAbeB4pNewMuUIfHxFEphgv8euXQftXfNTnZSFo eQvgrObpQUDV4i3suCcpHFn4jnqPkxqhlfTL21BxIlrDQ2COJYJxyTFFR2IsrgmdO/qAfvKW2rC zvPCzMeoc6XadTAV2yA7ZlQyvKfr7PimmE8wjDnlcCzqfLlkbsXZUJKzq/OwfEZlOfu9jvjgL2U tiY8g6NC1mZtRf5MqzA== X-Proofpoint-ORIG-GUID: vhqM_7jtUA1TD8WWwY3S5WFIgiPPfao2 X-Authority-Analysis: v=2.4 cv=SuagLvO0 c=1 sm=1 tr=0 ts=69fc8d97 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=WuC1ZyUpIfxNvbBu5HYA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: vhqM_7jtUA1TD8WWwY3S5WFIgiPPfao2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Adreno and MDSS drivers need to know whether to enable AMSBC. Add separate helper, describing that feature. Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- include/linux/soc/qcom/ubwc.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 8355ffe40f88..83d2c2a7116c 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -116,4 +116,9 @@ static inline u32 qcom_ubwc_version_tag(const struct qc= om_ubwc_cfg_data *cfg) return 0; } =20 +static inline bool qcom_ubwc_enable_amsbc(const struct qcom_ubwc_cfg_data = *cfg) +{ + return cfg->ubwc_enc_version >=3D UBWC_3_0; +} + #endif /* __QCOM_UBWC_H__ */ --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E721A3F54B1 for ; Thu, 7 May 2026 13:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159004; cv=none; b=OHcRi6vda9AQTaDm+7gkNNdY5PunZDORgQJSQpB3VpNwjuFpDOCe27TTuFgytqNwMMO1AJbVDaFKDhpuBdp0ssm/3/K9FJroUiRqctpfmvCEr+YjTiLKk0XLOQIyunEtBTgM5THPlAJRANVDINzlsX8kUDObJRKyCSPA02wtbVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159004; c=relaxed/simple; bh=m7fUWBaY//k3BMdPpI3w6VGDO9pVlw+qrJQrPegYVpY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MzgbKBtImW66t2QvaHjjQeTFFPdxWQGXtOu8Z3JRgkVKYR3vNX7SgQD+sRWYyInOMGQG7SlcmgSoDy9QlHq6fd7VHPSbhYmLTvOUkTiLqSqq+QEmCdrb8F2uB95DHsYwOEmFHGH+GWHfN4m7rFaYO71uU6BmU/dApDBRzTOm8/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gk7eN6vB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FY6hxKQU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gk7eN6vB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FY6hxKQU" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BxZDU2734072 for ; Thu, 7 May 2026 13:03:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uowZPAe0p/cWkm8GtHlypt4vcKjscGJ6WfGzYlQEuf8=; b=gk7eN6vBYHaAk0pk vja9fa0W+hP56hqQu2NPbo03OhN5dJLdY1GEhM3fNjBGFue4pPzrLe6pBUSGkdeE rmGjhPnP38BpmZ/Nsj+rHdAb/oJX+SRcrkDgrad8ZbhzXY3EDez+WJ1/nnfMWkj7 jjLatUkXXO1iw2gWhdw4s3DRi1SjAXY0AjO8GjRTlksefU7I1anN9Al4Y8eCF4fa R34vMIhiWomLOlRc9j0veBGZylRCBJdBSh9TbZLjqJ2pNjKdouxuXXEoN1IvJwJ/ 2j9wNsmWceCmpLdBlPt3Cq25gnpeedLgmehN0kTXXKNVOYMN3U0bvSbac12AQuzh ZRFDbw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0tbqr6xy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:21 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b7aba0af02so10280425ad.2 for ; Thu, 07 May 2026 06:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159001; x=1778763801; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uowZPAe0p/cWkm8GtHlypt4vcKjscGJ6WfGzYlQEuf8=; b=FY6hxKQUEfznunC31f+Eugcw57ayfMwprO282tuaH99A44v0Er2WNiBHBLs5A0QXTE JFfUEXkCH/4OIoz3CI/ZKOa2QQgHdKaHBH6lFIiJQ+i0QvgMGuvSO9dhG85Ml/juH4VN zGdhYuwRbIwNIkOg6v2X2tCepJVJnPbiP8nzwBFhkaI8FfbcNn77IhyD4ttQ0T7LFZ88 EKaV9q0vy6L/iN7GvaB57J/7UBjQ1SOKkFiXqYdyK+Ubi4DeUfK2b7u58lFeUhBGL6aZ RNVl1eO0nxbOiy3EygXfKARx/6d6ayMbItUP/8wV7/e/A2WdF2r+/2z31R8NktpTY2Qr AyyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159001; x=1778763801; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uowZPAe0p/cWkm8GtHlypt4vcKjscGJ6WfGzYlQEuf8=; b=PW9nEunB5EgpgRaDDS+Jbv8VvA5SHNQnzcrQMSsnkvGbHuC5vgvOU8m+K00XOggMiZ +Qf07twHUpVECajI5OETWpEPXxPub0bn7kTq9Ug/G/llk+r8kM6jpnNIBlKXnqQemopI 90G267+p57sd5IRvUiH75fvFXm5STfoK8hzhMju66d16APtGdjyUKnGv68Gf79I1/Fjf 2h4WGkmN8iiQ1wnilDyIu6JeiypfRC+EfIaGsOhdL2p2gRa9gZ8KZnTRCYa5F4jAuYxZ s4BQ6/s0rrDW0ZTVScAdnJPpnKLe2jzXuORQErwefbnPrXTWH6q7Az+c3ZkV2UqQ7klV VelA== X-Forwarded-Encrypted: i=1; AFNElJ9axaIgVy9EGc4mMsoRqOLar0WZv9SrRas8G0iT3adKdFpCCZPLiDnFW2Fv90XGmwsfpnRHw4iRT1fMZo0=@vger.kernel.org X-Gm-Message-State: AOJu0YzPUi8sfj68gRVlMo85EdekokVsuKKeWUeMTUeuJmkLUIox3+EU niMtA/r8q5JyysxlukfKFdVj7sHPt9UTKKBm/ITZXYGgqFKZscli/RUl+ivemhwpdBdUzk4SsUX ogYUpLVnZFwmRSTwcHR9mgjNJLPFTzBl4Bw1AWK/5sG2AQe+hbFFtCdpjH7gc5bUuHg8= X-Gm-Gg: AeBDies91jo9WWdA6m6EeByXwGzH/yrwz6FO1FDEbNGl7X9X6pIq0Q7RhCabCdVS14w c/OXyEihBIyZvWdzev0mCMv1XJXeKH/Q6NgMsnomnJA/BI6r2Qfw2eT2seW40YCKLm2RHHfOxKP 4BsLmsy2oxHX6NHhAVtiuZbUMcpcRl1g45z/lwXphyuN1VF3lyQAPFuP99FvsFLdNK0sIN6S3ZU IdeTnKxoPoDwkUi3AP76XT+cM3k707SIrjgYvhkG/qrMjCJzg1WYhqNFW9DdM6tSeFKhXaZq+Cg 9TpdL+Hhim33sFfrn/23FbM2j7RynoSkTC/SLgld3OpETffhpEyaxJ7ZUHq2mvzgrVLVldBtzoL 8A85GsYUxJ11FAtwEJzM2HsMXFgUssxCU5vOyZmslywgg/VsIsS0L2OS/nh7lqIHHVMxuvxtVTp 6jDyYc0eTDGusZMTqqesvAE2KZUjgH6dxddIWya3UwvXq4QQ== X-Received: by 2002:a17:903:b46:b0:2b2:eb9d:1648 with SMTP id d9443c01a7336-2ba79c25ad9mr82066525ad.37.1778159001167; Thu, 07 May 2026 06:03:21 -0700 (PDT) X-Received: by 2002:a17:903:b46:b0:2b2:eb9d:1648 with SMTP id d9443c01a7336-2ba79c25ad9mr82065745ad.37.1778159000507; Thu, 07 May 2026 06:03:20 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:18 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:01 +0300 Subject: [PATCH v4 05/29] drm/msm/adreno: Trust the SSoT UBWC config Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-5-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=5880; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vKJ5Okv8/mY/+V92nlnNVbn5KJI7SCcR+qGexLCfQKA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2EmchDTOZURru4fhGhuxYu51QFJpZ+gv2t3 OmJhWoG+IyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhAAKCRCLPIo+Aiko 1YHLB/4hGDgjAN+g+/IfxdO1kUadLQo3qblGRGZpcSt2/UzQqQGzVB23s2ST5tHCprS1ZGi4llv JP4B87hY4kt9JhUR3Bjc5FB1hAcTLb4IAGL/Xz0tLmX2WLvxQ7bUkEg15xE194G+208HMFeTJke 9Mc+h8aoOkAx9cgwAEvgTfgPR256fDjkbm+B2iELYnFjEjEiPl962BnS1ZH7ZaG8+ugw+KWA7yj ldnIGWcK3yKOTja8ap3z7HyMF68G32wwVGRYkXkCkFvs/Lqr8aPuJtjVN57UE0f6IlQkfbvANsu SRxZu7HMeY+bzdUJxrrg8hBZE7segrr1OgbQctx1MHD5voQ7 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: LPJrJRDQycFz6oe2AYgMNwVoDqtX6E1v X-Authority-Analysis: v=2.4 cv=SJVykuvH c=1 sm=1 tr=0 ts=69fc8d9a cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=IhcC-CrlSmvFA89tYH4A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: LPJrJRDQycFz6oe2AYgMNwVoDqtX6E1v X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX8Xmtz78FtZSg 5S4EEfU6e9bvycoFUqlQUj1ISQBfQZI9AXZkwYiO9aMZVq1v0K7gKJPY/hI546abW4ANpTzzYC+ 9OEN1wXY9e8wdHHJo8Z7LSYdy250BqcAX5VraM9VrECksOYi1DAyzqWlU5ZiX0PYjPzxr595YOl D3Dh2b5DX2odbr0xpMaajotU+2vJOydxN7GYNE1levWqZoPMSbmLAWTR6jt+hf9xHiM9ZQHorl4 Gx6rEg7n6z5Nr2ej9izZY/8m1W0FI350gcv4CcaygU5dq91tw31NI/4jdMd61il/ZQN8TjmAlqH A3bIRftehJ/Vyv6kF+ZEgXkhfuPYj+Iz3C02Q0yCZE0PnFIum4ai+SiCWaDbcvkF/a6xGY8i5zz j8W62MGiG8NPfa+ejHoAWjth2M9B2laqVZXqWtaSrfyhWTLKQjxBYbKF9i18+UlwngI7C8zNriR +CWiDkT9Pv4UcjWvTZQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 From: Konrad Dybcio Now that the highest_bank_bit value is retrieved from the running system and the global config has been part of the tree for a couple of releases, there is no reason to keep any hardcoded values inside the GPU driver. Get rid of them. Signed-off-by: Konrad Dybcio Reviewed-by: Rob Clark Reviewed-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 11 ++--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 82 ++---------------------------= ---- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 -- 3 files changed, 6 insertions(+), 92 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a5xx_gpu.c index 79acae11154a..699fc0f551ed 100644 --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c @@ -1725,7 +1725,6 @@ static struct msm_gpu *a5xx_gpu_init(struct drm_devic= e *dev) struct msm_drm_private *priv =3D dev->dev_private; struct platform_device *pdev =3D priv->gpu_pdev; struct adreno_platform_config *config =3D pdev->dev.platform_data; - const struct qcom_ubwc_cfg_data *common_cfg; struct a5xx_gpu *a5xx_gpu =3D NULL; struct adreno_gpu *adreno_gpu; struct msm_gpu *gpu; @@ -1769,13 +1768,9 @@ static struct msm_gpu *a5xx_gpu_init(struct drm_devi= ce *dev) a5xx_preempt_init(gpu); =20 /* Inherit the common config and make some necessary fixups */ - common_cfg =3D qcom_ubwc_config_get_data(); - if (IS_ERR(common_cfg)) - return ERR_CAST(common_cfg); - - /* Copy the data into the internal struct to drop the const qualifier (te= mporarily) */ - adreno_gpu->_ubwc_config =3D *common_cfg; - adreno_gpu->ubwc_config =3D &adreno_gpu->_ubwc_config; + adreno_gpu->ubwc_config =3D qcom_ubwc_config_get_data(); + if (IS_ERR(adreno_gpu->ubwc_config)) + return ERR_CAST(adreno_gpu->ubwc_config); =20 adreno_gpu->uche_trap_base =3D 0x0001ffffffff0000ull; =20 diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index d5aba072f44c..1d998636c5a3 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -733,82 +733,6 @@ static void a6xx_set_cp_protect(struct msm_gpu *gpu) gpu_write(gpu, REG_A6XX_CP_PROTECT(protect->count_max - 1), protect->regs= [i]); } =20 -static int a6xx_calc_ubwc_config(struct adreno_gpu *gpu) -{ - const struct qcom_ubwc_cfg_data *common_cfg; - struct qcom_ubwc_cfg_data *cfg =3D &gpu->_ubwc_config; - - /* Inherit the common config and make some necessary fixups */ - common_cfg =3D qcom_ubwc_config_get_data(); - if (IS_ERR(common_cfg)) - return PTR_ERR(common_cfg); - - /* Copy the data into the internal struct to drop the const qualifier (te= mporarily) */ - *cfg =3D *common_cfg; - - /* Use common config as is for A8x */ - if (!adreno_is_a8xx(gpu)) { - cfg->ubwc_swizzle =3D 0x6; - cfg->highest_bank_bit =3D 15; - } - - if (adreno_is_a610(gpu)) { - cfg->highest_bank_bit =3D 13; - cfg->ubwc_swizzle =3D 0x7; - } - - if (adreno_is_a612(gpu)) - cfg->highest_bank_bit =3D 14; - - if (adreno_is_a618(gpu)) - cfg->highest_bank_bit =3D 14; - - if (adreno_is_a619(gpu)) - /* TODO: Should be 14 but causes corruption at e.g. 1920x1200 on DP */ - cfg->highest_bank_bit =3D 13; - - if (adreno_is_a619_holi(gpu)) - cfg->highest_bank_bit =3D 13; - - if (adreno_is_a621(gpu)) - cfg->highest_bank_bit =3D 13; - - if (adreno_is_a623(gpu)) - cfg->highest_bank_bit =3D 16; - - if (adreno_is_a650(gpu) || - adreno_is_a660(gpu) || - adreno_is_a690(gpu) || - adreno_is_a730(gpu) || - adreno_is_a740_family(gpu)) { - /* TODO: get ddr type from bootloader and use 15 for LPDDR4 */ - cfg->highest_bank_bit =3D 16; - } - - if (adreno_is_a663(gpu)) { - cfg->highest_bank_bit =3D 13; - cfg->ubwc_swizzle =3D 0x4; - } - - if (adreno_is_7c3(gpu)) - cfg->highest_bank_bit =3D 14; - - if (adreno_is_a702(gpu)) - cfg->highest_bank_bit =3D 14; - - if (cfg->highest_bank_bit !=3D common_cfg->highest_bank_bit) - DRM_WARN_ONCE("Inconclusive highest_bank_bit value: %u (GPU) vs %u (UBWC= _CFG)\n", - cfg->highest_bank_bit, common_cfg->highest_bank_bit); - - if (cfg->ubwc_swizzle !=3D common_cfg->ubwc_swizzle) - DRM_WARN_ONCE("Inconclusive ubwc_swizzle value: %u (GPU) vs %u (UBWC_CFG= )\n", - cfg->ubwc_swizzle, common_cfg->ubwc_swizzle); - - gpu->ubwc_config =3D &gpu->_ubwc_config; - - return 0; -} - static void a6xx_set_ubwc_config(struct msm_gpu *gpu) { struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); @@ -2701,10 +2625,10 @@ static struct msm_gpu *a6xx_gpu_init(struct drm_dev= ice *dev) msm_mmu_set_fault_handler(to_msm_vm(gpu->vm)->mmu, gpu, adreno_gpu->funcs->mmu_fault_handler); =20 - ret =3D a6xx_calc_ubwc_config(adreno_gpu); - if (ret) { + adreno_gpu->ubwc_config =3D qcom_ubwc_config_get_data(); + if (IS_ERR(adreno_gpu->ubwc_config)) { a6xx_destroy(&(a6xx_gpu->base.base)); - return ERR_PTR(ret); + return ERR_CAST(adreno_gpu->ubwc_config); } =20 /* Set up the preemption specific bits and pieces for each ringbuffer */ diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/= adreno/adreno_gpu.h index ec643b84646b..324319762383 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -236,12 +236,7 @@ struct adreno_gpu { /* firmware: */ const struct firmware *fw[ADRENO_FW_MAX]; =20 - /* - * The migration to the central UBWC config db is still in flight - keep - * a copy containing some local fixups until that's done. - */ const struct qcom_ubwc_cfg_data *ubwc_config; - struct qcom_ubwc_cfg_data _ubwc_config; =20 /* * Register offsets are different between some GPUs. --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C8E83F7AA9 for ; Thu, 7 May 2026 13:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159007; cv=none; b=G8sO2eOgmSP3n3ZibNg/q/yAEuU7cwpi0R0FvVQeaUxJii97A1fKwCcZRe0xi9rPyURxytzTpeXKzoxMs9DsYRvvswcjUXVRFAXUuwhibt49Ewci75NQ9vpHfK3B1PMWA5bF5l75FhSE6GTNCa6hA/HhmCI3/Q5vJfOVhK0LyoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159007; c=relaxed/simple; bh=taU2aKAGQBJ6W2MyCZ4bOSBa16fxBG0Rs7Rtqck5Xao=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mwz95WnmtrwOmhXyFwkX0TfEIjcpInw+28nOKapEszxvnVDeqxFEXiBvA73lygY3/Uulcz0+B5K6lG8Sj1ydiCwFGc91/JKg8xaNSaQtIoXptWatLGWd/VA6N8nqoPy7Mj37dLzISUNZYeVXUGq36odXqlFe90akwYcwwcaO04A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IDWHqlYf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PlMyspJ4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IDWHqlYf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PlMyspJ4" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6479N4Re3464902 for ; Thu, 7 May 2026 13:03:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lRizh296idxaeGEPnbWh+8suGLFulwB7M6vVue2aYVg=; b=IDWHqlYf2XmYUPKH sJFnDRMRH16Gy9+uC1UG2Y+xpZdJqptWtvg1/qU2c6wgK9s9MI+kkz82w1JdKCQR EqVlj3h4fFuOzP7dHm0g/H7DmcMowDcqYzcifr8X1LUfIlkaoKHLrLkXripbQrlr iBt1Xnnu+vzdGMVz1VR6MZEnxY3GuHLpqjtjL/BR9plCElaGsouWS7EAhBdPmphi tnx2SPEZflzC3qRSSlZXpvcZf3HLd7t6+KRbBhR6Gskl+Ge8D9ulBE+36TZRe7+d jXYYNDf/7/SS28Pw5EDlWQK4gR3PO2uAxtF6ugcA2YIQa+Yy1MOEchO4tqe68UnW O48HFA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0hvn25q4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:25 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b9a3c3c4eeso9504575ad.3 for ; Thu, 07 May 2026 06:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159005; x=1778763805; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lRizh296idxaeGEPnbWh+8suGLFulwB7M6vVue2aYVg=; b=PlMyspJ4ALCUaJ3PVGznYaSxW+bF1RBhLeAYqkofL2/Jmg5k2EhEg8wQ4fSZbi2O4K SJS9M6QoXwLHwfceLM/iH+KTNifZGCNpY79S1wbhNHbScOmaPQScvFPra350ekCedRrC J98O8LC6lxXQyTTaFKC/fuhkUVLUh4Dx5rAE7BmP2zv5znUISGuqsfvLqgkvFffwUfZ7 5yZO4pmjjJbF2aduC7/qljguD2LWym49rMQ6Q2UW5IEBsiQdKo3ESNcYArYK6xEqN8Z5 PHm4bbqu8g20H9xI2qb2fJVvxMkexBFwhEAJ2UA8i4UFbmYZVKFApbCUF4uS1mQrKCM2 jwFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159005; x=1778763805; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lRizh296idxaeGEPnbWh+8suGLFulwB7M6vVue2aYVg=; b=PGjNuFYeKNKDh2MgAsUar7gQPbHRycbnvIE0CTyWZso6LO0yRQbzdKPex9G9q4u1wz x3/C9sNiH+pvH3tB+OIQfeNCo6RLTjwfDbLxNFDXE5SUyNBhwqmSQVSP7WIhx5vTvlN9 TW9v66G8L8I1wN1psd0bqiAm6dMK0LrNXXayS94+U04840FH0MaPMY2Mxq9/3yhJdnav VuWAAJ/VRjs6vLfBZuz4QBnBGXN6z6R7FdcKpwL+0OwFPvxkadSYdAFoDUCEVshvenzW n/6FxaZqgDX6MpYy94Bs+c4JHJijf/zrr6DJ+TIq+3dCHzIqXXwgQpS3sIjw+NSR/VJr 0d3g== X-Forwarded-Encrypted: i=1; AFNElJ9ANkLAXEPzBPkVLitBlxh0MMsEnPjn62qm+WyfBHrls5OOqqiyYcU3W4mrA+4vVOe2DhYSrC0OuC/mfOQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyvZ3oRXcHRM3xYoqlxHzZsFRydM2Vm+9b+bDg5eVh4zCqyzBkp firnZThmqie/HZ6YUkRbUH2S0MU7GJN8hxKAFWTBj+wZYp+2Hyh5D0c3IsRA47wm9h1swmXjJsD mmNUxRzA9CMHfN6FDF14fGU/ziwGafSfnZZKcI3ZkmhiAHxgG88gZCXetRs8Dgfpdork= X-Gm-Gg: AeBDietltQHy70lgtuN8Ww5Y+NbRfYOa1yzK0PAwPaPmrskgEcpmdqkX8tV4Xea26/c O5mqzXTJD7hoyANfeawk+0v5DPIhN+leNP75NkudWrfubC5Ua+4x4r91CremDJMcLA3W3FdzwuK nNvAdUvs8zj56AuEJGLKfwudMhBDGki9dAUP6YkG4mWNFxX59EIsbddLkYtFkWgYbksjDqc59G8 2m1mywJuQj0UyHcrFf9tYtLky3RuluZ9KBpwwNqCQWYJ9q0wnDqkudKMYTJHiiPfsFMylXPtyDf 8AEaXR35R2KI+oq+lNVDVrmMcPLPiKLaC6moMwxMLNejEvHXLIjmZFTDms9F9PVgLzeTcwr2loq w0OxCHaEskPHLt8g9k45os6xWNThQr52LrA5HDlumrp1FlqrvoMi9shsVXxyL1IQmGyb+J+I8Eq XvD8cpf6+lR+j0UKFzs+oxJBqndkoqhfhF0Upbo/P9ybC4oQ== X-Received: by 2002:a17:902:e790:b0:2ba:bfc:76b5 with SMTP id d9443c01a7336-2ba78b40166mr83458565ad.4.1778159004330; Thu, 07 May 2026 06:03:24 -0700 (PDT) X-Received: by 2002:a17:902:e790:b0:2ba:bfc:76b5 with SMTP id d9443c01a7336-2ba78b40166mr83457155ad.4.1778159003317; Thu, 07 May 2026 06:03:23 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:21 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:02 +0300 Subject: [PATCH v4 06/29] drm/msm/adreno: use qcom_ubwc_version_tag() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-6-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1565; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=taU2aKAGQBJ6W2MyCZ4bOSBa16fxBG0Rs7Rtqck5Xao=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2EnmzZQ9Ysoo2V1PXmrQNKg0nbhsvvYayiU vxiP7NzJRaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhAAKCRCLPIo+Aiko 1RrhCACrPvBm62tRCkk7HoECYx2MJcGTM/IlTReOG3sDeHdoUQnzfkbAVF9yYO6JRXa9vF998pC y6+lGq0kFFtPSew2q9ggzIKfHpWgA9NviJ0EGGsjADx9A0ZJs4Dq8JBoQOQxaYPS3j3G6YClaE7 lifQEGGfy3UiQjT/Gvv22N2JECkALgXBGCvISbjfjKQ/AECXgCFeumjCcmmQxQ3OkWHqhO+2wVn C2UbpoNLvCUB9qwPF+jiOIzA+DuZBuZQZfGDlHvnMy6IWi7rYe+ptPm62Zh1Ioye/RfosCi8zo+ h4FMml3CgoBS1upR4DTxUoBeK74mZUbwHGVjlig621jDhjYe X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX3ppvDKG+oFkI IxL4wBIapWvFuZ3DjnTQu5LnTdB7jIk2+LNuIzWtGeegRO1y/NGd4lMj8V5OCocNPmQdntSDvdt bcWtWhFb4oJ+65PJ1n593HJxzgFMz91qCUOYiB0d08W1qgbX80u+5FdqBzSCK1oe1hfnLR70DAq PFA8jEFHxdhFPR1S5XMs6lkVj+KHvWTkQ9lfucxDsLoX++IxJj7T6kTqz2zdaR+WIJ/B3bqKD/1 6VACtB2XqcyQUssy/vQLb+TcCrY4+Uwsklk0Xlm/2ydRw0V+23GqA0BI/qwjH7Z33/86ooxaCUs 0Qx6DcrAP1cOZYtmYXxk/DoQTTQOci66u02zIbp8YEAXqYp8UihjYRUFqL9FTDiyzYyOiaITvzT H9jhSkRA6lgvBqkxwotlNb5h/25+44+S7SJa5GrCYOIrhBhn6Mv/9mrR4BgJ1BeeaxsHBQFsNBN MFwL7NUMyxT8KrWEjJg== X-Proofpoint-ORIG-GUID: vz2J7ydqcGF-a_lEP-JmnAP-BkBVH9id X-Proofpoint-GUID: vz2J7ydqcGF-a_lEP-JmnAP-BkBVH9id X-Authority-Analysis: v=2.4 cv=ZZ4t8MVA c=1 sm=1 tr=0 ts=69fc8d9d cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=xoTxleRWwXRO4XdZWWkA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use new helper defined to program UBWC version to the hardware. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index ccfccc45133f..1923f904d37d 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -282,35 +282,33 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) bool rgb565_predicator =3D false, amsbc =3D false; bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); u32 ubwc_version =3D cfg->ubwc_enc_version; - u32 hbb, hbb_hi, hbb_lo, mode =3D 1; + u32 hbb, hbb_hi, hbb_lo, mode; u8 uavflagprd_inv =3D 2; =20 switch (ubwc_version) { case UBWC_6_0: yuvnotcomptofc =3D true; - mode =3D 5; break; case UBWC_5_0: amsbc =3D true; rgb565_predicator =3D true; - mode =3D 4; break; case UBWC_4_0: amsbc =3D true; rgb565_predicator =3D true; fp16compoptdis =3D true; rgba8888_lossless =3D true; - mode =3D 2; break; case UBWC_3_0: amsbc =3D true; - mode =3D 1; break; default: dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); break; } =20 + mode =3D qcom_ubwc_version_tag(cfg); + /* * We subtract 13 from the highest bank bit (13 is the minimum value * allowed by hw) and write the lowest two bits of the remaining value --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F60C3FB06E for ; Thu, 7 May 2026 13:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159011; cv=none; b=hXZKBD11XYBOKrW9uFFSooy5PumCHwK1PCp5dqPCzJ/kOqZPvAQNzwVoIPhyKzFc4fuG+taZvSlf3CoMX5YOk2OdvO1FFqDAjCO+zqgC8eJRgK9mbHnFxI8QWq0i4tImGuGJYHpcxwisRVIkpQOeQKxLdUwlWHqayJ5ilgBX86s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159011; c=relaxed/simple; bh=pQcZSLClq75f0H7mdOxTbEo5DpGKFB3n0GBshQz7Fb8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TOPbfcyHTSAUQ5OmLVm+qi+omEZbVNhAgUHUWnlhU7F7Dm+GDJTACE1lHnF5sJ9kHq7KIaTKPqkYnbZVgZohNNIneqg9BdJIpUnVrEcqWhAKKf8XL233YsA8xK2VvpG0hKPsIREU2DydmIU/pjtNGXAcmsW2fV3D/GFnUv/f4T4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GBexpJWU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AzC34zzB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GBexpJWU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AzC34zzB" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647AVYgi151029 for ; Thu, 7 May 2026 13:03:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KrGdZ6Bna8qkROGke7rL/1evORye3ZzPkLd+P26j6Fs=; b=GBexpJWUB7j3H2Vs gh0De5AnopuN2Awsfv78GrepAEtx+UtVwH6f+0BxVfE+yzc4YIRxYzS3RCVYPgpP zRBPy+gyQXC/Kn71FX7jDnKhm0HcibpjrGTf72eRVLylmEpNFNh3NV90NFIW7Rg2 cUCs7ATJr7D83jIR37Hyg9GefPyZZwcdE9mJG1thdOXSQdQqhumzJ9F8U75IvDlv qyVmFCxfAAjAXj0bSEErYB4AmUkg/MIFmXrgDj/B2qcjdcuXoyBiLKAxCe+OQ+Cz tb0opRS3w7OjLnl840wJjxrDkJ7QlMzIrllI/LIro2MHTyxOdDX5omOt9V788W7T yh00CA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kctsvwm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:28 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b9b8137828so9510295ad.0 for ; Thu, 07 May 2026 06:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159008; x=1778763808; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KrGdZ6Bna8qkROGke7rL/1evORye3ZzPkLd+P26j6Fs=; b=AzC34zzBDIkrqlU9StmFf9k8Ia5b2zGA22uVHMw06qeb9Bv/gH5kNITj8ACqWKDFs0 DU5OC+RIuYyFxUQjptkLyITGGjN8KdIs9dJ+Kuc5jShPoG0NL9J/bPRlFHozyB5lPkmS joW0wavWMTwbbDndxi2qfz8EMMN0+RcgeIkw17TQNCzsXst42ppMnYyYU/uNLc3xrgde mX4VLLiVAS4gkOsHDL1YKFCYEx5On+o2f4u4z8RceU49Ix1DbKLo7oREWQS3NF6eOHHP FAAoWUzRO5ybfN4EP2MkntSCc0xBDHixz6Jv3EjKWoKMwYEDSDL5jS2GI2+fQ1HuDUny i2KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159008; x=1778763808; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KrGdZ6Bna8qkROGke7rL/1evORye3ZzPkLd+P26j6Fs=; b=V7y7WQQkqV0Y0xEW+oe8kvk/xqAoHbk5NzILwr5vMpRTf3Ikgr8OCEkCQ63raeU8FL MeFA4c+Y35Rgxyc68EL7skMPt7iyjBQGJgnJPiWe3UYwOyKyqPRWOVRTWZvwYc1VbFIM lKM70ANdSKXzeLSQHkGpczsFxXx9WDtcFETNKzhzZK3icgtNFT8AWpOPBOV9B7S5p6sU 4FmY3t0Y96VOYU3pVWDjTjVJ8pVp7GwHQoICZ9oqumpVaSEJzumDKkOhzK1XhMhQP80o 97BzFrWtxfwvJdX6W6GdGZ/1ELaViqA/K4oNM8NLBaWEFZl0Q9hITqsYjjvhYOVJgm1e 8i1Q== X-Forwarded-Encrypted: i=1; AFNElJ9KvFElFuAthnTNiIk7gIC9upYhVe+dNoUiF5uwzvduIGUSsk/e6zgqzZ2we57R02c7aPEV5z1+bnnIVJ8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywuk2YAjFSAZN+zh4tTX0+fEj9ZSnTgRg34F7vRrdep1EQ8JHTJ MH1rLYMUKLDo5h3DF5g4i05sEg8QK+/6Z5pOVZCCvtQR9/cEWdYjr+r3JZg/+7j8arfP+/LDV2s 8Xmq4AZTkpQrO+ZZlWRF4bPkzRRpQTv7LOsyN778rWV4mftDE4Ke1b5UTvxTMo1n7+pg= X-Gm-Gg: AeBDiesBf/9Qun3JoL41mcah2rNLVcIYel352tOEPJFEOp2+DBsPyxEQcfSAAkTPoZT Ugu8/b71zN9kiBzcFV2QQ9DNxhaaQCIMIecvRPeBWbANFDl32DYpB5lSEA2zg3kyUoVvfFLlhj7 kh9hOLoQnFBH7Z6q1FO4KviTaur2lPKOtyvePCLyvbc6JriT7GU95GFgprkTQdd2hctXW8ndODy 7qg9WrpYzsuhUmLQflcLD2wQO0aoN3W6W0r5WNnwwCsq8fu4Av1xi5Ux4SOi7jwcPCohfnmVYWq WTFjzLxfc/pucyzOnFd2hhyvj8edPVv/S/ku9QM5WGK7y2qFZHxIQW92chFhTxnCRDDeTF8R7to b4usrm4xPYPMsFKfDBcU87WOZruavQfkuzlE85BnndD2bPDfta3X2htlbTmLbryyXCn/bB5rhWQ 4zyQuo+nf3n+ZuyywXz7r3J+jurgwCLw6DSTum8XpAk5YzPQ== X-Received: by 2002:a17:903:291:b0:2b2:49a7:a5bc with SMTP id d9443c01a7336-2ba799d39c8mr77213155ad.39.1778159007531; Thu, 07 May 2026 06:03:27 -0700 (PDT) X-Received: by 2002:a17:903:291:b0:2b2:49a7:a5bc with SMTP id d9443c01a7336-2ba799d39c8mr77212145ad.39.1778159006887; Thu, 07 May 2026 06:03:26 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:24 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:03 +0300 Subject: [PATCH v4 07/29] drm/msm/mdss: use qcom_ubwc_version_tag() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-7-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1662; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=pQcZSLClq75f0H7mdOxTbEo5DpGKFB3n0GBshQz7Fb8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2F69Gf0+wrJZ+PAcIYbdCZBc3bLgBJpG3EJ 0+hZRvmqt2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhQAKCRCLPIo+Aiko 1YrBB/oDsZ6AVPY2ZhV7yKScT8oIWVeq2n5oJtdKLpgtIMphPmRL+a82CLnLw1RhBcNnlqpCFlZ cNiZPg4pWyklMEENCYwQ+zezrwoKmGcgl4cTjnHxqgOIFMgCL3YKmZQFwUpi/j+l0REimJwbl3B 8TrPkOFEwEKmz6nOB9FAfEqW2EvPQWmRTqhVdSj0cUUK/2vUYSsktZ+EtBH/iC1TGvjMO8a2bf0 OwieVYHZIOTH1AN64R2+6rJFspKZ2wydps8vAtybEyf9eVevJAQhFvdjsx/4UaiCKTvvaIOPVKg YR/4+lH4qMq8FEgn8ZUkD0Kj4+G9bZZ1xBy20PwJClCsUA34 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=XsPK/1F9 c=1 sm=1 tr=0 ts=69fc8da0 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=qBJULKV797PGQuHHbA8A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: P81Dii3DwD6SNuVURluSL4S0uEReiPqm X-Proofpoint-ORIG-GUID: P81Dii3DwD6SNuVURluSL4S0uEReiPqm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX0JqSmBqFDkBL 6XQe/1MX5vphxYLJLa4WmK9j7O1CJyaHhnyCvMiO6SG8h7AqSKF5P7x7YxwocXhFniijyScty2G F3Yd0E0LB5mjHF5iNgbcnQ5cdoqcDTfHvgRtCmmb0puAdFRVAgDMWShYZxszV+uF51F3Summ7Bt XKxxBG9x1NFanV22/iTor5vAHNfnld667QTWhT4KncrHSwHyDAlCZObdTTGxEXqD8ovyrYBmPyP JWG4KCm6TTfLD7a9TlDo6f+1AwKx1GOYHE8wzqd/RwO27dxOk5GKCOpCrZJUB11HBEwpVi0Yr7s BZTE+syQMqipi03VXkqxMhhrIwj0uInSIONONpfW9a/u8A3gGxsc6Aozms6/iEvFotSSMl3OZ7Y gHf136QHU4mHNu0DFwopqIDmFl0j5GlKG+BOilwkZfwHh+zJCsw1+SdOt/PpGoCXSP8+ftCGOkX qWtls5Pmub9K1rxJ6/g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use new helper defined to program UBWC version to the hardware. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 4a6acd468bc8..229b47415f29 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -201,7 +201,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - u32 ver, prediction_mode; + u32 prediction_mode; =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -219,20 +219,8 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *ms= m_mdss) else prediction_mode =3D 1; =20 - if (data->ubwc_enc_version >=3D UBWC_6_0) - ver =3D 5; - else if (data->ubwc_enc_version >=3D UBWC_5_0) - ver =3D 4; - else if (data->ubwc_enc_version >=3D UBWC_4_3) - ver =3D 3; - else if (data->ubwc_enc_version >=3D UBWC_4_0) - ver =3D 2; - else if (data->ubwc_enc_version >=3D UBWC_3_0) - ver =3D 1; - else /* UBWC 1.0 and 2.0 */ - ver =3D 0; - - writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + writel_relaxed(qcom_ubwc_version_tag(data), + msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION= _MODE); } =20 --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 526283F9F53 for ; Thu, 7 May 2026 13:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159015; cv=none; b=m3UkQKJKynswqbArYns5Uy6npDXEkIDBi7njZXFvhzcjAKh+n6ReUZtxSy/H7848X4lGpt17o9adUaZsh0qUh3F9lN+S/iCklIq2o9RqS6/BtiRKZ70TUEWOEyxWqJRn9Su82V+EcaX6UUdW4YNX4IwU54gXGjaJpqrn0I3nU3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159015; c=relaxed/simple; bh=u8w5QRXYz08nzTFeeOvvUABZylvk58f+hXEv/T/Xk9c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nMJkkGOGKEwvAWCukDGmjRhM1kwt5qV24JKfEXb4TlXqiiX+wXe7CKqX/+EFqC07v0K6lBahukXDcvZcreeRYV+71Yzrpipsjakq8rzBPZ837KBC7qNA0egu0sGT+2QHNE7+mEf3/5Vnip3vAKTmSH64Qabe0cHA7XmyEMXezo8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DGp8fkXr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SkS/TmAi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DGp8fkXr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SkS/TmAi" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BZ1DE3157880 for ; Thu, 7 May 2026 13:03:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VjEGhwhCmeNmMAb5JNSZqAnfeaakx8wynUdLZKg6xFk=; b=DGp8fkXrCuYypnaj AcDMa+a/vTMndheBd9DPirsrEHiVjkgp0VWHUR1daixP5IEPAI1R3DXJGb6egjfT schPSuiOzOhUEU8wdd3dt10IEoyVwMGeuxAYt2mNlvcdkCQBs0qrlEt+N0/Q897E wZK+XNRb9yX8u129pekGE8Jq0oaVnsiz37OIfTWgihAhn2Pyfr0NiiEhyfbyN2v8 eAEqfvfgZP2rMSkE/yKqZ/rRrC0yRFIL57snQJVtGb+FKbBShvS6pajn9LZsu7kG K//E4jhv0mqAwlgBBj4y5mLyNYUZBQJV3N/siDd7nDcKgSK1xdq5/HCT6r4oSZyO C5zm7Q== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0mhf1n16-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:32 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b79f4b35b7so8667135ad.0 for ; Thu, 07 May 2026 06:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159011; x=1778763811; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VjEGhwhCmeNmMAb5JNSZqAnfeaakx8wynUdLZKg6xFk=; b=SkS/TmAiEQqWbWb3YHFpFj7s9G6piBt+r+DkdUUt7rljltcGW83PVnGHcfExeMttYp uFpo/q975eqQftHS0RzkwLoAJsxtOezMQPfiSMy13CfHRUwHsAs+Uj3TSR5PNMMkv6xb 1+qR+TcXEbfzmrofLSkKzXf0FoEH0ZSQw4YWJA9t4HJI1X0bp4KiId1H53+Kichgrl1T cmfWDSZU+OSFUmi6KTlWQZiTYEb8ZyOykiRa07iav58nkPOmx5RdlRYJpBHnWPK/jW5+ GCSdrvWEOgYFK0Xx4YI3RrbQ6GFQOpFiMnf6rSvKYfSsatnbSmuSXUzQ/q0tK456JyMT uxTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159011; x=1778763811; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VjEGhwhCmeNmMAb5JNSZqAnfeaakx8wynUdLZKg6xFk=; b=PcsZyz/pZb2Q+31xt322bwVCdYsYpFycl/muyNa7ZVeAsCSfiiN1p+lR4NFXALJBMQ 4F/PuVRBcgwbJRCgZ6/05w9vPm4ptscZvawynn7tN+MN2hS/+N6NLcxT1YCaKidcXtul EYhyLZes92if1IJV+Q6mESYKfeRACy0R9U8eyNNAgErQ8AJIchLnROz/1KUMd5H+P79w sgX81VHVF30cCPZrzzJXte43dIt/5MERb8miJ7oV6HVU+wMSYWqX2v/mbNLbDEtpouQ4 v8QntyihKynZoPuEZXJ/hcKKZkap97AkxFOpey+3A3GyxyLgUhK+gRjW8gz5JsVnlKdl 3Fdw== X-Forwarded-Encrypted: i=1; AFNElJ9Ydny9rRV9TYDXZCISfhU1/g0gAQ28PCGQfr6iBJqN7uhkeyN8B7IssAN4Vd980QXV21jnet88K8IIuQo=@vger.kernel.org X-Gm-Message-State: AOJu0YwKGYz8zGovJIFSkPee0aI5wJTfLl+Pzb3RcW8iQ13usynX5dtO hwQLTEL0oSIXlqlOHtXRdiONLSSbUSjuuzxHlFOrnx2o9dzuet+OwkxcK6XkL0fXAGpm/8KKDJC 5sDHR1r6892u/TWaimKlL9Ov3KTp5QDduS3jPkfIMZyvAzMKOBVDVrincOetBNKYCHWk= X-Gm-Gg: AeBDietwh2l/8GiD0SDmeqihDWivfRunP7n5PxfvLBhRU6OHyy4wYMULGtilG6sJ/r/ r3H3m7nY/an6gG86Z6W/a9nFSXcViDf7O1+USqx0rXGoWeGe97HTm4UWziqP6RAS5JLdbCyyvCe tVkyOarGePZ7k1DhYIcfjEnmOqOChhU71priDZsoYmRWQ/D5l6Xh2ycYTH9M66mlNgynQLvs4XG 7mw0fWqVG8GWaTzgteAn1aaC5rn7yq4jGcdQ6FL+eJS9GSzsX5Bl6/Ei2LCPY6EAgReIqVPSWqg 3cGriCRFmRJgfB9Ppt+A5O57D8Fa2FOcJeYzKfJc8DC1rPsW6gPVPRIeojWr67guxL21uWkiQMr Fa1a1JhWqX3hwTfdedmGcpXxkVGF3yVwtsqiG452q79pedo7PGv+vu0ORvYE823eY0LdKNYuLZD 6WHZKCzD6rD7SBDU3u2sy3OdzIwGh4P3HtKPgK9J/fClOu8g== X-Received: by 2002:a17:903:390f:b0:2b0:5ae9:ee4 with SMTP id d9443c01a7336-2ba79285966mr77063645ad.5.1778159011025; Thu, 07 May 2026 06:03:31 -0700 (PDT) X-Received: by 2002:a17:903:390f:b0:2b0:5ae9:ee4 with SMTP id d9443c01a7336-2ba79285966mr77062925ad.5.1778159010398; Thu, 07 May 2026 06:03:30 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:27 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:04 +0300 Subject: [PATCH v4 08/29] drm/msm/adreno: use new helper to set min_acc length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-8-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1349; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=u8w5QRXYz08nzTFeeOvvUABZylvk58f+hXEv/T/Xk9c=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2F0+NpfaspL8pZUBBp+X6pZBEUAoZt0Z8/F qWGy5aY9D+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhQAKCRCLPIo+Aiko 1WBOB/0e0Rj4/4LpRbW1tMBmidfdTUOmpst7orERKAS5oMvMZ6Fzgf20IHn0/f2Ro47Kh54EGTC ToSD6h+9tJz1o8bbiAGX9uGhQs1d8IOpn+YYHKLVjHkmPVo5vuvV604vhULn6eNMhE8Bh7ITHda 6CuRLQgPOQXqtzTPXenTT4KbEodTsnrugbZEIXWxkscSLB5uTrkMYZdnxvIU5HEHyVVEWenxAIc 91qEZhqIWIOgFJxv9t/QT6fjG4xV3frBQV53+di8HYj2bYmypovZz+UZEKhtqH2kfrelFJc0HgH IjfpJvlsvdAXo8wOwXH5teP+yyn9U9wrtHk7yH836EBY2VES X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX/BgcnFpJDxQu Sx0AR0FQClKkPY83zfhaf1D6DathXvmjmEObRrL3oTBEmN1rVhatripUa+jt53qhnSgjIqupNtn /DJ7/xJGVHdnp5wyiuub3YB6qXCDZeiRyFQAYLZz3XIoFG1+BAR7XzIc4m9gSE0epvrAlpB9+ti Iv7uLDiBXoqS1Kaog2pTX9i6cdZORtzkIPCI15TMurF9QZOZiNZGjUk7HmW1E/VHsBLWq/BmpYF O1kUPrUipujvFWEwthr5z4pwUSz9iR8j/ADzie1g1sn9mKk1Ppb569nY+AJPlY7yQuSEaqIhR2H DGrPAPCS29DVX24bjn7T0G4lJMqrdMpDuAn8aIajo6XA7+GKXTIyvtN4dx7bXsN07rzbbcTv0RK YSS9Fy+TOwj0GX3IYUOEc3VEFXcF45/KZiP6dy2i9HL3JkYj455ODmD4bYG8w0jAJRs9fVPoKo3 Zi5zgW1dua/iMdu7nlg== X-Proofpoint-ORIG-GUID: ijPQAFvMEs_zhR8ej_MiejRwJWYu5QJ7 X-Authority-Analysis: v=2.4 cv=SuagLvO0 c=1 sm=1 tr=0 ts=69fc8da4 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: ijPQAFvMEs_zhR8ej_MiejRwJWYu5QJ7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 1d998636c5a3..812bb95e8011 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -748,7 +748,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; - bool min_acc_len_64b =3D false; + bool min_acc_len_64b; u8 uavflagprd_inv =3D 0; u32 hbb_hi =3D hbb >> 2; u32 hbb_lo =3D hbb & 3; @@ -756,8 +756,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) if (adreno_is_a650_family(adreno_gpu) || adreno_is_a7xx(adreno_gpu)) uavflagprd_inv =3D 2; =20 - if (adreno_is_a610(adreno_gpu) || adreno_is_a702(adreno_gpu)) - min_acc_len_64b =3D true; + min_acc_len_64b =3D qcom_ubwc_min_acc_length_64b(cfg); =20 gpu_write(gpu, REG_A6XX_RB_NC_MODE_CNTL, level2_swizzling_dis << 12 | --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 878753F7876 for ; Thu, 7 May 2026 13:03:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159017; cv=none; b=ART9EpgpXu0QDkrlyt9kNQPAGObFaN4YpT0A56nztc44ACKP+jyaaENrRgVLjBv8OwzdIbhZCkpnMmYgnpMj1rSFgk5YiAg0Pg7k8dKvdeWLRpwPwc6iiE5JbFH0Vtm1vcrW9ZGiSBRtiDXu7vDovN+mk4f5cu7x1LSYGUsPqFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159017; c=relaxed/simple; bh=2ZvEjuy2Z2pk8ChjGlcTOYKmEPN6QT5mYQGegDBtU+w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t8/+7b2PasZXpWtOYFs8UeS7Eh7gnlSaQ2Wlg76nqZ+ITN32apNOS0Pd7/wrvvsSXsYMVP3UYBsBJaqEr3u1s0dV+swIDmoSYZlwlEV8w8HbTov3mGw7iqozQMivnzva1KOP1Yn7Elxz47GOt+flubrbinEZCwpOdbOYu9oESxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JZVRG5Qw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QKM8W6R7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JZVRG5Qw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QKM8W6R7" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647C5cMq1971798 for ; Thu, 7 May 2026 13:03:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xeqmVqS4sWTzNC5Ka5lPWcTosbNT5mxXRMsZpQCt8rc=; b=JZVRG5QwiU9Dzm5O zlNRK4EJF5AftHsH0MYq3rY+eHwv1Xkq3LF+lGhsDgdknTccP3eEVkIoSl9DbGCy DxdHyWjoGbbnpfHYaNKIKdOaZPVdlA+PRwgJgs7X1fAKDNFLE3+y7WiNX5ESGv2p mk82kfphqV0EDjkxu68lAjJ4a+vXHTadso/jh/T/owkCUagEhVvy8IxJxyetSqyp SwH/RotGMOzhlHy6aXO3+CBXRO+bVw08fYc29BvnHgrMdb0xIqwllHAfR/DkG3Y3 l8zELjnAQ+GcaoVRIci9HHlIJxZ1hA59qExdaOZHoD4+c1/JsBQ3fduPcOb9/GMx c76Lvg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0tej86c5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:35 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b2e91add2aso10860585ad.1 for ; Thu, 07 May 2026 06:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159015; x=1778763815; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xeqmVqS4sWTzNC5Ka5lPWcTosbNT5mxXRMsZpQCt8rc=; b=QKM8W6R7xHoDjBmMV0+ewdTo5gxcQP0mehyuHVI35SKXXVvijSgY8s+nlcBIa0tzPk ay2QG2GcCT90U3DMJM4/sEEinonSQxaPtC3mA2866n0dCkt0N23VIVunDEYYNXKf0CGf KrNGCHQmtchqmiGS5CNrjYtgoHvSExOtJTqY0ZKF++WQTqpOaJMl8xCFNcJH/XXW1hzZ zB3ZcQKT/MYrGatLtY6du+LQt+wDBcKmFLg94AVTXwgq3bpHrZGHJDb7smUFLpOiX+tw l2QUKOYOYjvOdqDIvhwmlhjc0fZDXouR9TNvX1ClCSpHcFU4c6BtRNOKpzyLGKVjfKwJ GTZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159015; x=1778763815; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xeqmVqS4sWTzNC5Ka5lPWcTosbNT5mxXRMsZpQCt8rc=; b=bTpZOQdJIbidARGS6cftHKNlhqOdHsg48nll62g8bxjroAAu+pm4rX1tU0upeR6SZ9 DkP0ssZnVaVH11hvzq7CD+sBOyzoETZ1inRc5cVtxuIAVFBoXKo/qI7hVwdSiJGZVADW e8zJQrSXaAJyaC1bzaaNXkjeA2PaarK3/7IvoBaEfLqxvLLQN+V6eMixHrxqSrDPbEI1 k5kp2cjw+t544FjTdNcVv7RsLGDYvhQ00d6LtR2dGuRcQrxzW6+vMfJxPWuCBlkCFS4Q VlZ+IKw/GW+7Xo8ynRCrYGuZFdJDrRQTIOO3jzh3Krt9gIPQ0vtMcx5X7JpxvxP/4khr 3j0g== X-Forwarded-Encrypted: i=1; AFNElJ+LZkKEaL6mvpM33bznlcR7RZBeAusXhRwpNTlh5rnk9gwNk/qZzL1EXKfkY14FrxqrXmr5f8iqIBn/r1E=@vger.kernel.org X-Gm-Message-State: AOJu0YxY57V5/ORGv6Jy4HDquTJZPabr9jk7kPNxFskLPyEfKHtmUfaN hDG5FWLRhcPBpxcm/wHFUR61FKm3Nqnh8RHwOIZ/qvGnX2ZY4e81svElLfSdIrulCZUaHFy+EfJ 6YAIDjSW3FKE8aN2N9U1bbg5rd6mB3uEeu5TtM/YVrb2KfpjRyFPXGXM3AAaPhYj4+Oc= X-Gm-Gg: AeBDietwM3mq2mw4aQQG9Rg79uhtZT5wORT3P/y+KzLtLdlge1yefHYRF/DvjyQjI4Z exSyHOflmQDm5DVG7Ke3zrgCAuTnECuaROvQWvrEqORrZ88O90Q7xrNGAtaU59afOufEQ+e7tpx usRIdaFP40ZCScv+pt8jpfFkLNS3TfUzM3YJ+bKlG2grdHisVbMdwNnWrt3eQNgsMo+sYgFULLs hcTsIXENSmucSTdZR4kpAyfABpUaHGIe+8EmvQSYxNscHDipC+pawiIeQr+1uQBO9A+mXcjZy+s pVh68y1uqM1qT6hCbllHCETI7mZldvmaKq7f5mXF/ja3c+dloYI/L4/NhsReG5uj7w6RMd8xwDo sMrkdW4iw1JfEHLUU2mWe95XroqEHL7dV48cU/+Fn5vQq/PQowZQtVDCO4hRXB3fpru0oMGrpVu VdJExmCGyAYNKKma2UYe9OyVc6/Xdy2nYA0S1aTx1K+8KIDA== X-Received: by 2002:a17:902:e790:b0:2ba:bfc:76b5 with SMTP id d9443c01a7336-2ba78b40166mr83469775ad.4.1778159013448; Thu, 07 May 2026 06:03:33 -0700 (PDT) X-Received: by 2002:a17:902:e790:b0:2ba:bfc:76b5 with SMTP id d9443c01a7336-2ba78b40166mr83469255ad.4.1778159012871; Thu, 07 May 2026 06:03:32 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:31 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:05 +0300 Subject: [PATCH v4 09/29] drm/msm/mdss: use new helper to set min_acc length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-9-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1832; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=2ZvEjuy2Z2pk8ChjGlcTOYKmEPN6QT5mYQGegDBtU+w=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2Fs8iuCFnWQNAir5YldLxUHTFAidnver1rD e3RzpY84X+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhQAKCRCLPIo+Aiko 1SuOB/0V4A6AKf4Xq2JLN3dEzauZcdbsVigA1P2G7rcn1wTRmUUzfJy1MLCmkAbB9E6LbKtTU3i 0pp5ghS+oEnMckPZJhS/lG1YKeCe3+ACmvMpre6XWsO2C4kjOGFXwgMvqvCOCe+yQIpOvhQuL7N Ot1m/S2VoBCIoyF3DdfALknGheSQykaImIi2LZKD47+1J8oogx20Jm1iz8NvipIBuDyOY910R4g fMMo6hyZoOaceSVmLV/eap6xFqMwkDxegpVQibLc3Sdul8fCb8s8Df/JyRikyR5dcqJCTe7exgk kTjIS5/zJN7Q3IWcCZjBahmww/eNWC16TNQCKATExwxY+SS3 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX9T15Hg8J8DOY 9v0bIWaYC6COB1atNLqk8W1LYNwBJZoKRAPhbz4hneRe4t+4GcUGQJhEPcPRFHta3viseNgqnDN 3eT9hqIrh7at1xhFY4pDRIYrlkt859Xk7TLfePoMwEQ+HZ+RU41dxW+4RCTjwo0qmfy0pCvtjvf LQgv7YX7pIWkDufYEsDa07r/9K9wXMgZDlgLJwEKWo9yRPHx7G2alfoS3R+b+GLFkC8ik/0dMFX 0q8bZhngY1UP6Nqy67Uw2FNLqtoxolp2YuJf32tnIezTTrQs6ATL3JKlzeN6n1cew8mkhcV/aBQ 4od9wV8VfQuipschrPsEfz1juahfyJ46Q6t5Ypu5QS30azOhWvbR72Wmx2N7eGOjRy+cn++uSaK liP8BHzdN3Y/WVt9XccaaIFEiE5rr+d85MXOBRvsNZhCtt9ZSCT2xjUVTH/wKzEnpsohP3ZoufA tCJyhM3IQeR4Rk6W8UQ== X-Proofpoint-GUID: L3dl9zS2gibd3q7-VC_uiVbkN8Z5O9dp X-Authority-Analysis: v=2.4 cv=VNbtWdPX c=1 sm=1 tr=0 ts=69fc8da7 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: L3dl9zS2gibd3q7-VC_uiVbkN8Z5O9dp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 229b47415f29..9f2b366d45fc 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -172,8 +172,7 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm= _mdss) u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -190,8 +189,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) if (data->ubwc_enc_version =3D=3D UBWC_3_0) value |=3D MDSS_UBWC_STATIC_UBWC_AMSBC; =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -209,8 +207,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) if (data->macrotile_mode) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); =20 --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAB323FCB17 for ; Thu, 7 May 2026 13:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159020; cv=none; b=fX3779XUc8j413Qjx+6o3Zl4Ip4LA95B48NgTvK2X3cjK9Oet9SgY0PSE5NEwTls7/nTbXrWSm0RVX8mbatckBe+tk8FVQOHrhSYH8pFIwSpu3kGhSffebJnsJTzwIZ+5HLfWzmP8+W/JXWkKqpPr5HaJDXmq1YqklZLOsbvaXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159020; c=relaxed/simple; bh=c1cCr4HKFXH740TdXo8Awqf1bvuZNKoQdiwEy4u3ZaE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lbimzb4Rr01d9t9QRFAtA7Q+HnQ0jBAY54S0hvokBojyYlQT1jntfxcEVbBp0N+V6W3L+Hc8Z9155ii2FX7IZZzrEA5TMco4/Dw5FlMbioUDHgnySMtGcVnZb0LoLrzomzZg1PY901iJWcxoBSgu6G61Prp65ORiWTeYneIKHQI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hfd3Aypl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cVc+2Xtp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hfd3Aypl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cVc+2Xtp" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BZOhU3156913 for ; Thu, 7 May 2026 13:03:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xRxPggAxhmeUOtwPDQu0n6LredQeEbGzVxBFYRERYIc=; b=Hfd3AyplOqxpf1O6 pt/A4xic84I7hHNXuVeSYTzQe7sOXnMgZ2qN5NP7/uaqyKwHliS3dbC4fopMw4k8 9hreuWcgNzREW0p3vjMDrp2FSeJcpNCwn1iZT+U1aP3r8fcv+X4YN9nw/wuemR5x c26WLa208J/Dt1bzfJ4mUUg7yUHuqPGZ019ZL2cwAm5e23rh6migYn+6SKKddZ6B qh1NRQBJWp4BL5HYxAaunFIfEsg9WOEqeXgWyL49XvRy0Fyw+3LlMOvR8o2XJ1Vp p6AhZZq9IaGA8PpX6/OdCOFQ0F4M5l6/oNkwzw5jLTUttYTCr8uIkQvfNlAqB2bu 19EDFQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0mhf1n1r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:37 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b9fe2d6793so17040025ad.0 for ; Thu, 07 May 2026 06:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159017; x=1778763817; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xRxPggAxhmeUOtwPDQu0n6LredQeEbGzVxBFYRERYIc=; b=cVc+2XtprqEb1tjrdV73lB43NNR2FwvrzdtS1ibW2bF6PV8Zt2OuOYIL0oHQGSktN4 sT47Qn790srAwXi7IhJverVu97WZLaTk6Uh+OhyvggCMe9P1KMo8VNRAD5b00KPGWNbr vyU1tRGsXKWQj6/GkS0wWkTUM1qD8rdoADZOqUfNAEW/yb39cj1Hyh1h/XFJWL1QCQHf Tc7jFJu5HosA3Yquq+13euo5beDudSTxpqWAeghksE+4kpgT/SGt6Gh+MdAa1e99dfkV 2WQl9Y7n/WIkjhqipycYR+u6m0xA0Y92de/5/lbUDPD66b+RnzvLcPv+AeJHmdb5YpWL vpBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159017; x=1778763817; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xRxPggAxhmeUOtwPDQu0n6LredQeEbGzVxBFYRERYIc=; b=GVHcFnhYnw5YT2qehGfC5sQbWaeG692tBQtehlplH83RIcvls7Satk4vda44P5ROCb LzkBpbYEjSOVsYbgWWHlm8y0+V2lXCrv/uO40mG22xyHz202mXgGznOwOX1YNSjP9iZC xtGiivjlLi05E/JGDCn8rs20q0dGNIx4nP1bi3qMr+PObiLHGRm+8ZKLJrgq8Y5FzhBe lbzDgDvLT1aFk5fMv7CN8NJ6KTra63kpudxAI2dpZGlkQTQkEaJafhQjHhrrHLBB8lYM /88vMLCw/s/nprhk58/shXrNU4tTE2jm7lPouF0SDuwQGT89YO6u1tBUMcunoNHtSjzZ RoPw== X-Forwarded-Encrypted: i=1; AFNElJ8tKo0JKMzhVmGBiznE3TaOmZ2bnvoXaJQ/RGtmiFKBfZA/9N/hXt8rjQtVM5EYvHeG85C5L36IkNKXCGM=@vger.kernel.org X-Gm-Message-State: AOJu0YwfWZbk3k1KLkyDLSpXBmPcYNFuKqiXkNIG6VuXYAuD+SkfOGHb 5PbKF/BUOTbW1vNgTPb5eNl9NNAx5++tsdYh99IIPA3RZgc1Yjm/2NigxH6nu61E/pFOm+McLCl tDyFoYx7dRrMGNPacNt0xX4yf/gkIH26waBDwqj+L5i2g2Hf6s80xmqzuMrlXNEL47QQ= X-Gm-Gg: AeBDievvO8+4LJPP1rf8/6UtifOJNTsMneErhjIRFIoWv2jIHtQOpghMe+hMrT+vASG cC7t1ROhtuOVdzorr1uaSeoYBGLLxkI+ZTxJ/YPNUnvz9LcVxzM4RcvjCLXschh2s/C0vUonlp8 O5xr2XkPXc3ZsOY4eDlWZWAnoTdqkkFUc/98P7IpaOXCC2aCYDdhAUrmSf3HKXg84VTC0VjgBBn fRzBbnEeRrA+nD7HBVBAsEa5/i2C6L93IlzD4yL7K0Rhpuo5VE2SoufKOKbz2t3cl4HNXdKihsO EMW3idogDQIDYVPiD5l3//2UMC5iXRRZEaHsXzMh0SXapcwjJaawuSX+qM+mA0FM1K51OO6ACYz j5jZBNwoisBY/NXEZ6IFiBAf4juOy70oCQpMoLy03WtVFCCaTqfoM8DfZYwR7aXbbc3zOzQiA6d vl8AAAFNsav57m11Lp11gnO3EuPA19uUPMe2pKOPsGOSnI4A== X-Received: by 2002:a17:902:cec8:b0:2b5:ef7f:a47b with SMTP id d9443c01a7336-2ba794b7182mr81696525ad.21.1778159016803; Thu, 07 May 2026 06:03:36 -0700 (PDT) X-Received: by 2002:a17:902:cec8:b0:2b5:ef7f:a47b with SMTP id d9443c01a7336-2ba794b7182mr81695595ad.21.1778159015915; Thu, 07 May 2026 06:03:35 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:33 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:06 +0300 Subject: [PATCH v4 10/29] drm/msm/adreno: use new helper to set macrotile_mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-10-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1533; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=c1cCr4HKFXH740TdXo8Awqf1bvuZNKoQdiwEy4u3ZaE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2FAtOQQGHPCnd1jqarD8Ij7km1H1j8RLXpO UMff3OT1oWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhQAKCRCLPIo+Aiko 1ZVGB/45u1nMr5GHedlGzeF8o4xph7Gamk5/dijvOiVYTd3HbJfEQIOWzmKep659zT411oY6GoG r7s258/K49+Q9tysIud4POpc8GlQ0U0ox4WpNNAE0Qe1lpkcswSP11ccggQrkMeuDSW4nkws0FX ogufqZ7XBKT6nQgF4JJLqn9SSK5dRy3GKyAKbP8PYWi0bNkwckeA3HFtyPhULq6LxeK0Lb0NFfH Y5b7W7b4w3EAcH2EA0nv47rJtIUahZKXHPihttdvxP/FlH5SBVILFp92iLQDN9YNQVX3GyLz1CS WE+UOWMaS1PG4sqmNh9OExRBu1F4i161dox4/aVGNjwfjf0b X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX5ECV/DjlIr6x kuHsmFqALTl9XjXfIzsx6O49U1C5yC/vdyDWxAPRQj56VdJBidmEvqq7q27JRhTQ/s9mLdRhwuc IkDwMgsTxXWF6+UHZJ87fIRQsq4xHfZFMq070dE8hJv+hI6hFpvDdSIER9crbWefxf8N8i7uxvb vOE70I2A2KP3i3bjNwOuAPQK5fXdynodQucj+LvuZZm0PhbY0cKUDdeFhxHwtpgM/eDwg9D0OiG Rv3joE31iU72XBwsr7NosQArEtvzwrvlDsIkoGy7Y3Q7NVC6zt6jyMrhrFmQuzBuDlM/vsh9hM/ fEU341YwO9MI1MntQAPW3v344v+5qW++TtiFD/SE3svvzNDXC+NNUiapqNDXetqU75yqRHyWGsh ae03TA2XduASAWGbQCBUhetqTv+dXLpnKeBiwdkkjbcp94UJu+PSsVRPX85hmTrkT/23VWxT+hk UTgznGhL9Lu3FBMTTxg== X-Proofpoint-ORIG-GUID: XJiiQDHKSOjRKrfb2Hi-LelkLPqZkDRY X-Authority-Analysis: v=2.4 cv=SuagLvO0 c=1 sm=1 tr=0 ts=69fc8da9 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=8BxV0iZMnHvn5dZpj2MA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: XJiiQDHKSOjRKrfb2Hi-LelkLPqZkDRY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 812bb95e8011..76c681614416 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -791,7 +791,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) min_acc_len_64b << 23 | hbb_lo << 21); =20 gpu_write(gpu, REG_A6XX_RBBM_NC_MODE_CNTL, - cfg->macrotile_mode); + qcom_ubwc_macrotile_mode(cfg)); } =20 static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index 66f80f2d12f9..bf1572156b0b 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -433,7 +433,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_co= ntext *ctx, *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; return 0; case MSM_PARAM_MACROTILE_MODE: - *value =3D adreno_gpu->ubwc_config->macrotile_mode; + *value =3D qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); return 0; case MSM_PARAM_UCHE_TRAP_BASE: *value =3D adreno_gpu->uche_trap_base; --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D3903FCB38 for ; Thu, 7 May 2026 13:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159023; cv=none; b=ZUIA1U01SBASngVuw9PSUVmisivCIx4OAyFU3VZT/CxAVHe2y+wMBK+TkTJG+TvAmavJUUHxuSbDlcz4iYcgjuo+sMDm1i2rkweKSDZVm/kA1P/kaxGhWMIGQbstqU4ts915aN1mLatIbWFmfzu9cIj+XS7LU98O0vPjYYFSQUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159023; c=relaxed/simple; bh=gBDFjN7fs9zNZK1OT0Rge6uEp5iYTQNKw6PU4vljOxU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DrXNSOR6d9OLitOrxqxAT9aCNlxc04COtcZQH+sDljiyH6yheQLfbBqbZy9s+9v+zX2AXR6kbMoNsoI69gRXSGWPa5lo0HKw5QaOJAP8w56Key6S9TPGv8cyZ8hVigoM7A7z7sAqvpBF+s4DmD7FZqBooZXsejcofsjOZgDg0G8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WG97G3mC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S4vj8Qzo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WG97G3mC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S4vj8Qzo" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6478q7fo259326 for ; Thu, 7 May 2026 13:03:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SHppxJbIcnxAbn5e5BxkZY1HBroOaNwMncF5FMMJzNI=; b=WG97G3mChs0n7L+C uYBGbXBnuMYE+vX3krc/qcdPiptP+zAHzZeZ05GGSAf8F6sLNG+qdnzu/DbxIuCK WNBs8i6/BFfw3wMlJ2gW2N+08V4JLLGyhqKvN7N4nr4d0LUSFR515S551IpZk0NC cxtDT7xfStbQmxINu02RRfN9YcdNAxghMLa81xyTcnOqsW1zDfxuFjowbU4x7glS K0imK5pxzJuo7dSWHoyTGvIpN0pcTiIU5/nCFYB0oiIO4QMYOkOA1ZcRTmep29Br OPcsmipSaNmM5oLFApsfBOOWdCRo59YGw/ZSm4vB6bQyIngX+Yfd4WaspUayfxXr RdJuHw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0hr8t7k9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:41 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b9a6d84522so16260845ad.2 for ; Thu, 07 May 2026 06:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159020; x=1778763820; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SHppxJbIcnxAbn5e5BxkZY1HBroOaNwMncF5FMMJzNI=; b=S4vj8QzovhrLUc7YyzZpuSXLwYfE2R3dgKzAtn9ENUx7WHqouZwvMBqPrPeUStB5Sg ETashwyXLaEDLDUIbaOCXSc8OJ905sHeR654Ob/qwh9sMSVMbaThZYaCn2EiUyR9QaxS oA2I7PsePcUvzMKTvGgp9MocHHBnpWU1fLMjCVPVx24+aSmCjNilveDmM92IomkYGznb 578unJvcj3N6lkP13PQWSZteq0JdcCk4iXIxaUV3twd7jBCY66xj5Cchk7dC1L5YJtXZ gHBccpFHg50GkbUNtl1nlLyeCOl7rJmWr4TzG3+OEbCgDje9vTmDaKgr9+IHWlmhnQ+6 CaOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159020; x=1778763820; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SHppxJbIcnxAbn5e5BxkZY1HBroOaNwMncF5FMMJzNI=; b=M7pZlWmzTRzHQyLSPH7Gda1IL5vPWO8Ru58xYj5t6XYAe90JrgbPJRlnw8tg+vONvT FwMzdPgeGoGa8xE91gJg2+eFHgPsxbCCe9aJ54qrY2iiMbVCB7i4y4ZLLTa0id1U1oYL stGIfD298FeXCpygzFjonqltBONkdXF3I/YFtU0UR+8x5ZkC7LAsydNt/qPKLFSJ1tLr iAtk/wPe6vg/tMVI7ff7d1DrPfG7FGfDgIuNMwAc1u3FZh8mZGtbvpM2eaNQ8wU1WQti t2gl3SdToNWIkSFpKd0K4vlFidLveuoG5wrX+/+8HNYI16nE764OMzScVi7lePNKUI6G Nefw== X-Forwarded-Encrypted: i=1; AFNElJ/ug9Vct092jOeHMmmoIt+jeKMpPpCHWxaoTeILY0Ng8vvNgG9wCuC9wHzfhWT4GKgkeiI4G1X6bJh0YJ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt2WsCvSwkjOgDqwLa5UCuDJqH62SFkReYexKr11xnxICxC8gm DTdP0Yi3N1AwRSXz+5xleRns5YBOWleU2kBjTA7m7//g9pyuRJSxO0NfA0gWw2WSWA3KOqtNxvf +n4ojoXcu61AkbyjLwQdtXHFd378g698dLsV1iXnDC+5A8PYhua5l9gRx9+b7SsTeiYg= X-Gm-Gg: AeBDieuOUYwlfV4bkunYVxW82xT4WKpfxXj+8iwQWE21xYSKWZmjlQnpwbjPfqYm3Vj gpZOICdI9WVII/SzF+iFrR9x8m7o2vMvvyZE+AJKg9Xt/LV6/yikP1TmOFPFox2OMwQtT+Uy0Z1 bMNvQFBBMqyon0Z5E42uJz6vB79NvMYlKTS0Z1V+T4xfiloO9fgc4Gp+BNx0MnsSIHTIvIo9xsJ F6YHWF+MO2YG7SVhJuFjFFYa2w60QZ6Dr2Arbm4d94dJph8UgMdFxOQgaetZSmN6HOSrxP7xYUw kzBZEMzeVbL0P0n7Z1Pfoz9qpaphqWx/koXw1HLVPQ0YwY5dXURkZ4CDhCobCHkF9LkHL+IYpxv nJz7WHPMCI+QZc5Ryq4g+7PCXVnlS6Hl4An7I2caeb3gAZJ/CkUEiYInUXygRGSkZ/pYXVU6mTz knEdlvvM/DkjLBeBpPsDy0224DAdC73dkIMc4gs3iyjburEQ== X-Received: by 2002:a17:903:13c8:b0:2b9:8d39:5e87 with SMTP id d9443c01a7336-2ba78f4589bmr83668115ad.10.1778159020329; Thu, 07 May 2026 06:03:40 -0700 (PDT) X-Received: by 2002:a17:903:13c8:b0:2b9:8d39:5e87 with SMTP id d9443c01a7336-2ba78f4589bmr83667265ad.10.1778159019676; Thu, 07 May 2026 06:03:39 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:36 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:07 +0300 Subject: [PATCH v4 11/29] drm/msm/mdss: use new helper to set macrotile_mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-11-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1276; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=gBDFjN7fs9zNZK1OT0Rge6uEp5iYTQNKw6PU4vljOxU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2FDjnXbOAYSF90E+svp/o2+lKtGcJoJmH00 LRHRwi/y4KJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhQAKCRCLPIo+Aiko 1U7hB/4i8c2pLL/nU9G0mLQ7DZ4dWx9a4EZUS1RvCPKfdbug8mvb57g/dFuRVTTHpaSNEj+DTgK zOu4qIDormIXsdrNMG7fzPcZLodw+eYU5eGdH+sZHxw6cS1V41KxATtpk+BCLk8LB/nrfgVVVjL 517NcV/E2zf3ty6TNPoZ2Gxr6Bn0GOUX8cdKDUS8Bc0K4Oe8s44bU2vO4m6euxFwSAXhOqq8orR 0SUZ/wUoWLnIUBM4BHtYJ/YKUjhc0rmKfY0pUa9/+5dSplJxpHedAVSxvSy0RmIs0ul/cYT4e49 p6SdltpAfOF1V2Q3+Isc5Uws7rE4wgT4F0fSaxnE4uF61x3d X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: Btm2JXIyJKso-k2fY6_hl_Rx3mFMuInH X-Authority-Analysis: v=2.4 cv=caHiaHDM c=1 sm=1 tr=0 ts=69fc8dad cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=ujCctoy6CNRHcyqwK_8A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: Btm2JXIyJKso-k2fY6_hl_Rx3mFMuInH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfXwGBMqNaGdYVl jyoWURmMzesenAmHGYZtF6Idw4CgvrFYf8Z9UHYqIQ8vFGudFmAbZ11M7m6iiMyo4XpM7qKcBTq y19uMcNjOXyBCOTo46cznynp9kNUH2T1dnrD6yFH60EetzMeHtUDeFLx+BOAOGC6gEz6AyMXxGf QnMEAilzEVP+9QV9mb2HSJiCjS0QMujMtnLFvXYny3omSnuNHdkwm+8ifhRI2hQQL+fLh4+ym9M 8aeoHWqnF3JOYwodz6FXMa+4WIeY8Z+oVRH8lrI8C4FijxKbfXvnmFjKyaxmw/sqvF64jz2ARIq +ZI9YWBPXRNn1s1lyCP9o50Llzhm+ivqFKukgksZe3+fzLAk7DskUallH8Q/1/nUUfG4KHF+nzI n/mMxjPkto17Bto+PkjN+5Yls7y1KdIyA1ywXwQP0/nG70qSJXTtHmGRDHs/QFYl7urGp0vJZ/B ixtF8JeDTaVgEjEZ3ZA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 9f2b366d45fc..2742d4bb2a4d 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -183,7 +183,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->macrotile_mode) + if (qcom_ubwc_macrotile_mode(data)) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 if (data->ubwc_enc_version =3D=3D UBWC_3_0) @@ -204,7 +204,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; =20 - if (data->macrotile_mode) + if (qcom_ubwc_macrotile_mode(data)) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10AF23F7A83 for ; Thu, 7 May 2026 13:03:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159026; cv=none; b=At1Xkd47ynflUvr2locB5v0SjgBxDb8eqRU9uPJuCc36YbsFyWQmw39BC+RxINtA8uvhhh3xd8E3kdbCq3LMrLG/R5zEMvcKcxU8VaLDCbuOegWZwjNeKzgpzAjgjTc8b9gEqDLCM5uG49ZIVsUt29qiurMvGw84B6/VCd4GRw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159026; c=relaxed/simple; bh=05LhYAKGVaBgZaN0qt9lOXQChuEy0ARdc0e/ucvP2Qw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=e1Zl2L+2YAGvKVyqXT8BgZiL56/c7Km1Pi7kIW01+LRo0RBPDedJ3dLnD3pqN0Gf4RAEovdWm7YaukE+GJI96ZYISMMl3/pSXdbb/NOf7z9RK4VzcofyQlApog6Rtolp3AdGJF6P3y5CFjQPPXvIJK6X14RZZoMCpL3nsQJ4+a8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M4OlXS5A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cUdxjAI0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M4OlXS5A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cUdxjAI0" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6479Fx9a258729 for ; Thu, 7 May 2026 13:03:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oiUTlYZdmXRE6wHZobRlLY7t2S1s4URFF4b8EHPtYQc=; b=M4OlXS5ALFlhkFd9 lGFCXfCT5Cy+fR723ysKYQoY5UdnPwAtBVPIW5wQmIHDnvaF57qvyLQTfeAvpO0Z U6IcGpJNiWhCDEtG967GB+Dif/ENmmJHmHnTD+7mHGkK5e+vKKV4YYG2jsVMrq4c PQJsWJB0mwEECqVMV7mx/Jz11pWg+bUhtMq6meOq1wGec+mNdHcnrzIAfJMtmbqb vC1045ULf9UyeBVHKVYjfHfOLSEF0jVhyQJF+u8BQvhfS9LVZD5vR8os9bVqLK37 WP3qo4t16BpctT1z675jThbvyQraQ8nPU7fYiZruyWXxakOavZ5XpfIp40KTQvzO WtZZXg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0hr8t7kp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:44 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ba268cb5e6so10775525ad.1 for ; Thu, 07 May 2026 06:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159024; x=1778763824; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oiUTlYZdmXRE6wHZobRlLY7t2S1s4URFF4b8EHPtYQc=; b=cUdxjAI0kNh7qXjeEgbUeJq1OyOm5TnrQoFPCp2umNcUh3KelVI02zzzvglLAPTIMr eb71llfVdOI4waPK6Tpp7AUoxj0zAcI6l2TosOJa4zoAhbyslgM08f7+LyUwn8eywrcF I1YSXLnrrDUSrrPrGVYqV8NjfGrkyUE1oi1p5Ry21vB94t8xFyasnF1x+hA/JIw8oSTc WH9gSCkafQ2TXNJdMNZmtLxUMVfgQcn8A/W84y+3DcnNgHdluTG/nsUgaAU8jbD2KgPn JvfpluC1IugB3QLM282YxmOHYl0LSFVorDf9RPpbUUkVsI/rHc2pWvqY0jD7ybA6M0f0 n8HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159024; x=1778763824; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=oiUTlYZdmXRE6wHZobRlLY7t2S1s4URFF4b8EHPtYQc=; b=Z678rL4enk8FgmWSJEdiHZSmolkpqhvR8WZuFzZeHvlsnu4MgyT5ckoUheDx2suj8f 8qB2We2jTr067UwhtglDLjuwSCN1bWXS/YnLjQRQAkOZfTFSueB6n3lEdZfacP5S96FU NONobSxCxzQDrfasoyKmBXJUXrhES0BzcVB48a55zN4AcFDDobFELFz3WuBhTM4yGPmz vc4kJnXosJYGytW/bEcHMKub/U6dVNc6QCTJfyKHBw9Mp2kUwsFMzcllPW698PhyDwIK Nu7B1gTEbpqrV1acursddYMuXPj9YtAXxHc2h/0DIJaQ2w8d0lyADmxrfLcjcrBLBvEm hGKA== X-Forwarded-Encrypted: i=1; AFNElJ+r3qF9s30OVsLjq3Xu3uWfLR2w1ORJknTaU8t0inEmNln20S/v2HtbZC1Wj1hVrw7AnSph07U98gm0MP4=@vger.kernel.org X-Gm-Message-State: AOJu0YwiSq8Pryffd9yxc8EDwJ5bQcHS2Y2KH2hzYpaGJzdOIQkvbTlp hoE0f44L12BXNAnDf7dIUyr+oyKzA62saq3Jg0lmqZOfE9B5SmdAecwb76emjsoObiCNqsfjWsw PmfML5A204T0HCi0+XSK+My16rg0kREUMiNe+5ok8J4AwKqC1JaeAPkoaGC0gvhjLnYo= X-Gm-Gg: AeBDievOeSrdL1Dzy3YF1ebfwPH0DDSUe5nyxteYLVYa6O4iP9bBUwGNLzFSKWLOotn PbzXJSBS4bxzTdiEVP5L4cOgy9IeJljELxZbWtTiKqfXMSTLTlMP665yUW0j1zJBCeV6Q4i5TVh Z89IDc7jm/ZD4DkOkCRWVsQ8rQsXliILbYYgpY3/N7MOeOg9Jg53p3E+EqMQtoV6yMF1aoKyr44 R/r803OU4PNEyPSnZZf5Wm97hbfnHrpb8COjVZErdMNWo4pnv9hZyN54XJbGhgMKjxCdz5rsS/+ GrNhpl5y8X/lRnSvPWrgghAoVeRs7par14oUFueD8MJlplJqiv16Svyn409RQWoBoRdpw9twnnk +Q6vUW59kOVo0awIl+i/RQrbA7RA92yGXUm2qVQ5KSLH8IgcjpcDMJ9AfWuIrywlo3yJLdKQE3R ki1UDGi/QbxijwGLdmq0lFgl3DCNcTnNmBwYPe/7iOBEUvKA== X-Received: by 2002:a17:903:228c:b0:2b2:4194:9521 with SMTP id d9443c01a7336-2ba79287606mr83822655ad.25.1778159023425; Thu, 07 May 2026 06:03:43 -0700 (PDT) X-Received: by 2002:a17:903:228c:b0:2b2:4194:9521 with SMTP id d9443c01a7336-2ba79287606mr83821705ad.25.1778159022681; Thu, 07 May 2026 06:03:42 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:40 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:08 +0300 Subject: [PATCH v4 12/29] drm/msm/mdss: use new helper to set UBWC bank spreading Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-12-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=853; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=05LhYAKGVaBgZaN0qt9lOXQChuEy0ARdc0e/ucvP2Qw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2Fhhk+y1A/vA53ZjfHg0b1j3nZP1YRm9BP5 KmCDexqGM2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhQAKCRCLPIo+Aiko 1XleB/4yDRk+HvjFV1avro56hNN8IRnAnCgBilurLhhmm58AXYk2zSEzrvSs5Ybj6/NuMoAiSgr MouNFv9OqHDFlmAd/OuOLwiDpBe40kOWdY8B1itZnspKo6CI9ZCMPUucJg1smVMDZndAzMcVGib TKoIM/Pa6mjUtyhjHBS17piCGA0rbGij1NZH9WhhczUKI2WTn4qbBYYEWsecDT/YxCPIS8RG6Nu lzqkjTc2E3dLefeTMT50prp65Y5iDwD5SgXt9xEgY9WePG9AS750B345qCPe3tN+OCmmI7XGFI+ 1hA8ZRKnYfqkuQ/K2Z2rzdNgWxsyokiQ5PJBnJ+ub6xoGURM X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: cGptD4XTMBIdGbFbYYYQQxvYh9Ew7cJy X-Authority-Analysis: v=2.4 cv=caHiaHDM c=1 sm=1 tr=0 ts=69fc8db0 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=vkIeKiNhsAXvYQN2DwYA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: cGptD4XTMBIdGbFbYYYQQxvYh9Ew7cJy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX9BwlAAPuaFkm EZzsw4A9ZSbxjdaqFSX9C7uc1aIvyjquiV4kukba5mW6oVpH7uWJUFbgZB7q66acM2oHuZOlfjS T1/GNAyGmZpXSY8Jz81fvKc90veMp6ZM1K70kzDmtatI8eRmQF2GAszspakGliDoCZbIBIRwVoP IDrDQXZXry/gVNqhxgi78AzDDJidUGIcHHFWl+8/Hi3cQ8n4lGghzQAf3bIu5Er2FLi0lhjOVTO 9P1Z5+CSN+8XLmX7UVBFwBCdnC1VlIgHiLJt8+qjpSfmDE6WnqP83QIyXtxw72Ls9Sy67o+c0sJ 89lwWuYs3MGZMAxUe7FDox2zIdNXl3NsGR2KoSmjaUUYStY25watMmJCkp+fKYZkntKg0UIZPDH NLtH7V/x7ZyX7NeGsu7EX8WwC9gFzazDr6unElNtUcG5qYPJp8iaoKWVVc1mvaSeeufyuAvTFv5 3I9Bgfl20S9wwtUjgpA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 2742d4bb2a4d..bf106d849dea 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -201,7 +201,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); u32 prediction_mode; =20 - if (data->ubwc_bank_spread) + if (qcom_ubwc_bank_spread(data)) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; =20 if (qcom_ubwc_macrotile_mode(data)) --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7332E3F54CE for ; Thu, 7 May 2026 13:03:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159029; cv=none; b=nCFgYk620vNVEhDD2Bh5JGh9E665h5C3B4Es4L3l11xIzjPl4O4cLMFMiZFSa16lg3xmcDGBh497rFHwUcx11da/czin8Oy0DRsBT/UXSYYzmEq8bo+7go4xkYz8b11zj9qskL4qXw/PnpMgPt3PwTDzd/JIFoDfy6k7HXm3lRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159029; c=relaxed/simple; bh=VltiGEFHSGgs78MqO7UweBRuc9YVg0/om0I7X8C3TaQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TN4D6Ucrp61RaF6kAznm8brfbwdPCFWPbZZibMYes/TT77prgOSvVOYcnGC66LRC7MsOch5NjYDfYl7AO6gA0vKsIb3a9k6lqsmwS50/1vImNUcuS9RZCU6ctPVL8k/10HUuiy4TfcWp/QqaJxdegtvNU9rESMmZ+wusdEyMZD0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DyY7RbIx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WUODNGe2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DyY7RbIx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WUODNGe2" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647ATNUi879586 for ; Thu, 7 May 2026 13:03:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3nTcAznbkZwTer2iw0uNN35IcgnJNjhKf/8GRJBkZC0=; b=DyY7RbIxYbh2nKpE 1rEJbK7ZVNnnGsdLVtRsw2zvaK0rN1UVf2GBwUpYZ7AVWbu95KZvGtxjTHbMV4wP zInpeE7EmCtqaJF4/nL+4cGgTMl0fctLHCDijY/aMdmD/uH+J2O3zwNRTnJAxSiV eIIyzR+ophxkDUUTvLS6Njzk3+hG/DkZIjSPeu2aUsvgiLksKPVBaswmf4tb7Tad emvLwa/xazkFGhiZ5smlt8fSBV13PFVKTrR7KaCpc0aSTPuRFEgP2e5F8bcTWGI8 +oHLpLLamra1O6yaRiDw/7aehgTfTzBq09UqNIvBcPSMyOAuKKXctnA8qWcJUEek lelZBw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kdq1vbu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:47 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b9f5ac4e36so8738135ad.2 for ; Thu, 07 May 2026 06:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159026; x=1778763826; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3nTcAznbkZwTer2iw0uNN35IcgnJNjhKf/8GRJBkZC0=; b=WUODNGe2TkvYTM/62FNzlcxQH9K/dSF2gGF8JVut1q+Buwren7GL6Drt10nhor+N/a zVQCXKpyf722OE3Z/trqHEIeyzkaiwwddu/XefjYzEhaaljX91Z4TqBowKff6JntYIKb X5HXFpmr2j7mu0dp8P0S8/SxvQHBiXsDh3GbJDUFTQZ5BuMY0Uwr3PGT5vwl2kVrBzym gmw7LaM07hMukNzFtZGM0rys6h6EA4UVhfUrTR7d8PHEYS5Z49OKqxGAVaklO2gUf9eP KKWxA72arfzXtlublit7wQUl9Hn96GQkvStbPdQ2stHzADX7PYQuMzcyt5PmfnqozLRs TbAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159026; x=1778763826; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3nTcAznbkZwTer2iw0uNN35IcgnJNjhKf/8GRJBkZC0=; b=ECpBBV3Vs9p96B6xfJeln8/Lsia3nPIEOH5Ey/Lu2QoKZmixIBi9KGiSvfReLJxxZy ZN0hgYtbScvbfOUpUkH3n5NP9UG2niEo+dLDfa+m5Z3DjMkObfLZm82DMwV4vlcIEaWk 1+xHiwzcTdqaHbl0gAhG3Bz4ObyQVNR216VVgGZB8ovIzwIxWi4bCT1s624QireC8aGR pL0HU+M7+Ayvzy/8W4d7znh6KwjG10NeQFCJnTUVJl1IKtkcHDjsfKSUoQLytIlqFM9Q ulVWhQGTPBIU71rArPK3iWjtMEceiUSvPnM8j5G6QklNyIcTgmqMDEFpM/NqsmaBTz4m nAOg== X-Forwarded-Encrypted: i=1; AFNElJ8QJ8OC6SUTM/RJr54foW9NxXPJx1e6cb0hp3Pbrl33odeoj0q+PqwJxQZxKdqdBjta0//O1pIkr34+boQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxH2qKG5eR6m+l0pDQOkt3q9F0JsQ7fZcy+VUCzt/+GseyjUqX6 SgB6JPLIWiAUpkaJr/KBDXBBadqkNfOYhI8YMi3LKdxnmau1TrDf7oEx3X8TupiO904ofAMXMNh wMHZDUkEW2ozyw8YACCGcW+jMJ53qdfT4uCMXHrOxT/l5QJbytf4hKLahRUPPxE54CE4= X-Gm-Gg: AeBDiesqXBqQOpycBBwk1U+wzFhvv6xFzjF8ikp0p5WZoMEYl0c86mMcUOnzufXfvFg X3J51k0EDl15d3UqSVTJMO0oD5cqjlhp7mKPCanb9od4EyxG/qw9lbOy4XHwZKWpCYY2GDA2ZYX uTwX4H5bFPZZ7R/tbGvMFDU33BUT5gdywRSnyq2tPISDHjm+72K+28aH1GDtJuSJ13Fe3olpyAH JWu23tjmTPo0ITPIvONeHAx84Cee7EbLecCtu2VMONPQCq8WzHKuJNHybpB0DqWR4KyDEzN1WXH /Z2n809SoGAKCchG0hBDXP7uyu+m6ma1RavZzxWDbgKMvEjYh+FH3XhrPUcUA6KK7ngRqUuvs5Z HufIB3imS4PSVhimeH/T2ljMjcgUL0sdhZDjl46OSwTnrw4rHB9EB45N3iz+powlgVCM1xpCqn7 ADMGSMwqxKjIebGyDrsMYZKl7B8DdAOd37jX790rJPcu2SHDAKrF7cmn83 X-Received: by 2002:a17:903:280b:b0:2b4:65ab:57cd with SMTP id d9443c01a7336-2ba7a362979mr53135035ad.36.1778159026162; Thu, 07 May 2026 06:03:46 -0700 (PDT) X-Received: by 2002:a17:903:280b:b0:2b4:65ab:57cd with SMTP id d9443c01a7336-2ba7a362979mr53134665ad.36.1778159025532; Thu, 07 May 2026 06:03:45 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:43 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:09 +0300 Subject: [PATCH v4 13/29] drm/msm/adreno: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-13-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2707; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=VltiGEFHSGgs78MqO7UweBRuc9YVg0/om0I7X8C3TaQ=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+af3rZsu4rUyXLJG02kbPTsLHrFWO7fvKnQ+tj4isFeM ydtldudjMYsDIxcDLJiiiw+BS1TYzYlh33YMbUeZhArE8gUBi5OAZiIzzf2/yVrytOEbq0LWiVV /u/1R7PPS5dsymAIZ2SNeRUZ4bTk9JUrKS1Xn4ZO1Av7tr7UNPG//a7sR5eW7/nqcDWqc21X2q3 Vmd+kHLqlTCr4DlWx6rq+651TdIA/oSdM26DIv+XVv3X9bhnuh1JvLZiZ/uqAXGaOtWvJzxvnep Yo9j8q2ryH+/5+2UfXd/5j8FL5tcFi/fYCTsHJLMdMnDh41HeuDc0+k7n2d1F9QMAZZf0nmb/++ s673FgZYX1TMHeTRq/L8xstcZvCf9zjM8qQUdi9wzVe8JX/ySLPXZ8mMGVJCNRzzJphuDR63/RI CwPn6aEZahJq05TCDQsdo6T2Wfecip6W/SPU5InnxeQoAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=P6IKQCAu c=1 sm=1 tr=0 ts=69fc8db3 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=yqhp3bNzI1c8ER7VfgcA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: 3Cn9-3wzxvBKRLIGzJNZdcRbka6OwuwC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX8Vz23kjVOcLG uu36aUI1SMnkbsLWptjKEnlxhzctwjhX5uPDtbSoGcxpRsF4js+S9asOAHv3lavfhV9Q/fT0Nlh PS5kW0iSOsIP6StJnmEoycxNQMGzh4EBIenB/A+k/TesiFDrRobU1ukn8COxG2Qu/wd/PGdyP8A c3twHDYZ9++nJEiV+LUlnbdQ5FM6qs4MmP0Ty3xhdfHM2+L81bQli6jLACXEvalu2IzqRgbGJcR 8Xx+nhsFtUU0SIX7hynlDRVPdZaPk6Ju03R+cr3lNixx+Zqtr1vzrB+77aZOa9C+Nr7mmGscU/g eS5D/QQobAVUHOj/irV8/5b0I+k2X3mp8pKUkOR7eRyE4+TNJjmjfeuT3gw/hnjb3YYTH67Bkzt TFOZPAQJF5iKGXA78KpfsELDx8eyJ2E0F+M+qvfMP8xMCjr0AAlVaTsbvYxIhwEaKJcFMAh5QWI /X/Dt8ThGafLCYVrmbA== X-Proofpoint-GUID: 3Cn9-3wzxvBKRLIGzJNZdcRbka6OwuwC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 76c681614416..5c17565b0499 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -745,7 +745,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) BUG_ON(cfg->highest_bank_bit < 13); u32 hbb =3D cfg->highest_bank_bit - 13; bool rgb565_predicator =3D cfg->ubwc_enc_version >=3D UBWC_4_0; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; bool min_acc_len_64b; diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 1923f904d37d..53def136e0fc 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -275,8 +275,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) { struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); const struct qcom_ubwc_cfg_data *cfg =3D adreno_gpu->ubwc_config; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); - u32 level3_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L3); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); + u32 level3_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL3); bool rgba8888_lossless =3D false, fp16compoptdis =3D false; bool yuvnotcomptofc =3D false, min_acc_len_64b =3D false; bool rgb565_predicator =3D false, amsbc =3D false; diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index bf1572156b0b..d26985c88115 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -430,7 +430,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_co= ntext *ctx, *value =3D adreno_gpu->has_ray_tracing; return 0; case MSM_PARAM_UBWC_SWIZZLE: - *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; + *value =3D qcom_ubwc_swizzle(adreno_gpu->ubwc_config); return 0; case MSM_PARAM_MACROTILE_MODE: *value =3D qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32461401A09 for ; Thu, 7 May 2026 13:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159031; cv=none; b=B3KKL7v1Nfe6S9e5E67EZo3ZuHyyzXWrmTvibAyEjwwN/5GAgJL9BDkYdzhz0EnYdyNdf5soUuOxS+UYT0rNQcBiskrUmsxO7qUQjBwiUg7yrHXIQzn6uu+eQShxBHnm2Mtld+OfXAO/JdM4SfizxSJwEZ0r8QayNHAjihim41E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159031; c=relaxed/simple; bh=BQXxAsNkcgoIebP1VAZBuBHx3qvfk0HLeeYsTxoyeyM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nkuXIe2pFvTCsOl2NLlyYX0Pgvch1QS/yNynxoHrTzg+KmgMXCChKxACYHEpPpCIRIcR5Sjg3RiWvX/KPgnPNGWiEqaNUTQMjeTNNs0yNv8HUPwAFR+48z44hEnFzwAqJjM4Lvri+S74P8CkWa6DT8aLH3VBsQbv9xWK3IyYFI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VmY4plwD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N3BayVVi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VmY4plwD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N3BayVVi" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64790tjU258726 for ; Thu, 7 May 2026 13:03:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=VmY4plwDjhCHYlYM +Z+AAP7KgsP8llBGO/UbD9X3TbSWHtCYTmNMCia/A7EAbPcS4fdTwsbMYUKo9SXd rahkoVLcSzU4lrqMAeYQDAWTBAXTyuk4o9VSkewMn2WynRYp1NgsBQJ34DP1FnyQ nB5EeU6prn/by7zBP6gdRwPM6AsTd/yJjRZhpXIyp8LzvG1CMDVd1/fxaOLXrTDy IhbO8/T4SKriOzTrJMGZePLooZqj52Jfy7J5yJUnz1Vzpjy0Fuv8jCxTc4YxEl/X ZZvJa73v4WTuHGdX4xVFJnD/xcrytWgDHWJRu45ETMGclfIcyyJm4BxAcoOPEnIH WDM1ow== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0hr8t7m9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:49 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ba718173d1so16510805ad.0 for ; Thu, 07 May 2026 06:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159029; x=1778763829; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=N3BayVVixFujsBap8cpKNr09lZ/5k6Sw7b9awcnWuyk3gaTTD1FW47LTJ8Znn5Qb+G Il7A4UREQHNWSH5RL+Rroq9hxlkJeAc+0uQnIs7FYEG2gsJFvbHHKtQ4hmvkPJIcCe4Z qOGYMo/bKtfn6WcCBTfEcx+tZy7jBZgMj6NuPtNZCqAzE3b7gMOsp9kwDk4T8O34la3i YLy8/hoXj/EKeNhultPs0pN4OG2kRrAt2TNv/5oX7KvyflT4i/D7/rhq10rGr/9Fb4xH dXD+BsoPP7Pu9f52RL2v5BLllG/EGvjTqTV75KRrkGvbxUiZlXff5E5uwbPobRyCN4ti 6kFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159029; x=1778763829; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=dffY+kgMkB7mvBBCQM+rl//GfU+2vyBKLVo3xRsaetrQSeqHAxDLq2cMZ6msbIK5ec k7PhHQbomvreUkKtFdFxXVd8AJprB9it7dKAejIJMq22RCtCHAKsrY1QB7tWsgyyacKw cyS6YIZ7pWQgyW1bpzFPgsOvE3uKmrg5iUAgfBiXfTKzxs1Y7EgdFg4EYloAPE9q06p5 t8ubSxGNUeMZ5QnJNAIMym4+8C2CfM5WBCCVkMzQcrPwaxWGg+/wkBZXfiBTKNb3VJ8h km4l5PumQvRw4BEN47vwbOQxYKT4dqyie8JAgSaKZqPZaJJrSGlnIFARLdi/B116PYmN bpag== X-Forwarded-Encrypted: i=1; AFNElJ/Gd6rEVTTsUy1AG0UdhZogk7WUh5cn20TTql/N+ma7TsDAv7JeIIaEpCxnGEracpl97YcqsjYFcfNJ4Mk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9VHFW3jNm00CpchXtOvdhX27E4YHTBhurRH3cB219Is8JMsmS ++fOqRK4K0mUeL9rOCeldUFoqR22pnXOj+r83Pq2Wtyq5cs2BKOKVuuaMM/rf5zRjwQJRK/BRWM +xR2lIaLEB9NJ8dh4FnzzvhOkTgBgdJC96Q59krtKotEBgHBVjN1fFSRZktOk9f4NHyA= X-Gm-Gg: AeBDies3uIEJZ9Sh06/mx2g6Dh5sIvBAdNwpIq/Yaoak/D12jKXV4ns1AIkSqPiSJyP y3O0c3Cp+URgHAx6unIPnStf1sfvqo9nF6KvmHwWmx568xuI9eZ6XbCOQ1KK8KgwTBRYhSOeYgU OpQ0Zd3Isc1dvBldL+zYawrNhIWYIX9smQuHzeN/D5ijOwiVKLikmLPs2dijgYx6YOgGNWn5n64 8xxkIBilpd7JljPvA5YOQl/l5tyofTTceFZJgQLfCbi7Kmz5qmVaL+KoFa7CCE8bk5n6cZkPRls W2lOgN0miDqQzapK7J9j4uK7lfve5kzXxO1EWMxJBA09o7+bKv/lI21od6FmdA/ZAje1ZEyMYdb rCb0v/KrpliiEsqZXImenoAR4+Zy91VG1+B35lu66f5A8DSb2AhTd2dwEMkl1WCr4Jx6oDseHFT a2VsQCE2Wc0ChTX8sVRMUjxX3YQhKxphFHArnwZ9dISB07i8mfGJx9O8fW X-Received: by 2002:a17:903:4b03:b0:2b9:7ad1:bf2b with SMTP id d9443c01a7336-2ba7a2102eemr83850865ad.29.1778159028805; Thu, 07 May 2026 06:03:48 -0700 (PDT) X-Received: by 2002:a17:903:4b03:b0:2b9:7ad1:bf2b with SMTP id d9443c01a7336-2ba7a2102eemr83849895ad.29.1778159028153; Thu, 07 May 2026 06:03:48 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:46 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:10 +0300 Subject: [PATCH v4 14/29] drm/msm/dpu: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-14-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1592; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=BQXxAsNkcgoIebP1VAZBuBHx3qvfk0HLeeYsTxoyeyM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2Gg97HW7S2QBtityj6ZF3/0f1VawHXqg4xG fLihnyoO6CJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhgAKCRCLPIo+Aiko 1Y8DB/98etxhYYzreJFwxxpVfnzD1VfbodcVaUAhsHte5PZ7vdAu3l/05HpIogj2ZmlD8DJR2DE oj6/T2Esto34Sc5dlGNZSLdjBrXIcD9FPHV+SJSuT2vf0Ws6e3Hb3IUdeS1RMK/D8SXekm2f5UL Uv9OFqCU32NNRiGm+W5pHcdFcnjIfk5r2//igu2Q9J/e3QmO9Ur0FyxSXc/bI5djI7UtJZTNGfd prtffJVCuqfxZGPsN4PnCNT9FC/1GdT1Cm/nREzDhkqBS1XvTMcVr9XsEi1T1sh9/tEO+2VhTHl 9Wy/EYlkHHE8/QL9u5uSe85/5ej65cZ3E/A3s+dlTcFLSGOM X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: fqlYWGbW6z0KBDD3JEVL39MkRHLhFIlV X-Authority-Analysis: v=2.4 cv=caHiaHDM c=1 sm=1 tr=0 ts=69fc8db5 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=46QewcZEoJiMQYndSOUA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: fqlYWGbW6z0KBDD3JEVL39MkRHLhFIlV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX7RMp8QNkVH6J 85Wg0czy5HrBQBcod389aZ741Qa3ax2BJ/AHJHSjTHcm7DVRX9mheLTt5VHjrOFSsithxvKEzoJ 16okwHOVFjz73qGdqjBS25kQxPzoC4L9zQ+7Rzozto7pcFqQTDmW+9sfKqTCeVF3d4t1LhHm9sH 221UepHQCXBSsRZleAWRvnPzVbLV97hf/3Co/c4+uutt5xy4j0AZHlMa0vTKFRF39bnJt6eQ7pI hi0J3hBumQInFrbRzwbI26asQm3fZLtCbjcarNxwaEALZXF+buuW3xlT7qNsJ8MtYsxG7EsNC4C /huw42l1OOHkoO+w5idmRlG033GW0+JT9+5hOjs4jdtP+ABQFGMojDiq3gwoRJbknkTKbZACf0F jHjiR5uoDR879zgns5Sg7QzJwkKCGv4o2rGh1cKhG4CutkepetFDwrCVfPo5jj9y6QT3SzaF7TY Vqj0dDZKBcepJIWm0fw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index d3da70009234..6089a58074ac 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -318,13 +318,14 @@ void dpu_hw_setup_format_impl(struct dpu_sw_pipe *pip= e, const struct msm_format =20 if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - ctrl_val =3D fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + ctrl_val =3D fast_clear | + (qcom_ubwc_swizzle(ctx->ubwc) & UBWC_SWIZZLE_ENABLE_LVL1) | BIT(8) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - ctrl_val =3D fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + ctrl_val =3D fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { - ctrl_val =3D BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + ctrl_val =3D BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); } else if (ctx->ubwc->ubwc_enc_version <=3D UBWC_6_0) { --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D9B93F54CE for ; Thu, 7 May 2026 13:03:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159036; cv=none; b=OKwvW6+V9tQrA4bvJ1K5wimh+tPQF18+Ruyk8shuIterJ9vXykKqYrmhmYGqNzQvoEMCH263qGI4RFz8w1+XFAxipCMb4gd//Spgfr+03vmynrU0u8bdzXsg0gFllNL1/a17QPA9RFOflCI+6WDD19zSn7UmD4ZXsnvMUlGQyZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159036; c=relaxed/simple; bh=6iZnedW4RBQxA96XKjwsTUc9JsPI83to3JJHc5dyQQ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gIK6kSS2Jp72PWZIRjqN+zmFsmon/WNvGeVkVaU028l6SSEA2cUQO77IARKPREflIjIQi2xNF+CszJuGJVWZ1OooNHuDgyTMbezlOH/YkununszjB0H5Hlm8mvv4UvaEBYFTkkLhj4O+RE8CdbC/ueGgFQBL2ohTP/l/3Jdsv4k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X0UHr3AL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NexHgKSi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X0UHr3AL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NexHgKSi" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BCH313924172 for ; Thu, 7 May 2026 13:03:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uukH2Hr1fThFSWIyYnWWKO/3affNsowUSHW3Fd24TQE=; b=X0UHr3ALeJ2X85U2 5aKqfOdFP9Ga3vs76pr9M9mcPS7945AG7Mq904XnUcBJxxNTSPTPyYSyr395OsEz cuoBKD4ORvFQzksB4afNRARa0HDRrsuPqm7KbHphKGERb71Fp2wYs8slZ8uoyf+V 7NAylGFjkwxkTIwYiMMMErhx5SpNHDwp2KKmdpdbouxLb87TkteS4AADQX9+UnE1 FUHMSUYUxaVkVp6IdtImZBWYcSv5J6BKpSgmaSbkMYZGQkhR1kJyVoufrP0g2mf4 3/aZ0KN5yfkumFDXGy7L65Ioct2shd2t9mkImCzFd114jZOiO6q+EPUm99uLjdhL KD9RhA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0c88b5gx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:52 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b461b36990so10420815ad.3 for ; Thu, 07 May 2026 06:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159032; x=1778763832; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uukH2Hr1fThFSWIyYnWWKO/3affNsowUSHW3Fd24TQE=; b=NexHgKSiDAYTmAsd1NhQ/wvYrFYJhYrUn6SaBN3zxJLDwNvoD3UXaeEfVeqtl48F/w SzIvYu6yY9f4jxA12c9UOQgsd7z1T2nF/AyWGJrIK6dq1KhvLHKafizm4bVAuLeR9SJr iQQLKJrUB5hq87ab5AmLWZS115BMIPLAQxjfgCOZl/ajYbYz76SbcwBR4JlYAr3CIiT2 kSe585sxctpkYwx0haszRf8yW9GIcr1Tnq3+pizZ4e3HZeoUCMoK8PobydAT8EMziUh/ Z/VDqT4kYWiGflxZlXpWAT02oNhrv3/fPkyHNZUcBLhoiLpd1goxbTcJkeo4nhq7vRMg cwXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159032; x=1778763832; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uukH2Hr1fThFSWIyYnWWKO/3affNsowUSHW3Fd24TQE=; b=fhZ8Tc2OcJ0XuaHpsmBE9DygLQOEpQRSjp2CBo3WD8q2wXD6aixfNzfCB2D7u0irkO otRR/6TgsQm+4ibg86gaQdknD4PmPGu/6eIBj4S10h3uN7pDqiKbRFN2cHUELn7Hi7Pt jXGj+Xy0vtuaDkXkhGkAVnyipO0MPo4KJQwMZqV2r4u0Q3xl3FXEhZd2j+JuNGsr3n9h yf+k1sbVmGd+q/s5sO2nBl8upZSWjSCzP+AdVrg9Gq8eW3V7HRevtHzqg3q37nGnXU0b 7Dir++ibny4wlIfNCRJZ7eXwOUPJWFm9JU5YPZbK9d3+ZIxC4UGekXYqOrqeqFQfspBL uBOQ== X-Forwarded-Encrypted: i=1; AFNElJ/xTIWmnhqeSMZWJwvwLS3J+xg6wkFSHeJ5nz/arzthCbn4MFuAuj7+zEhOZ6xlx7/xSaos7Xc4ZegCW/Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yx83FKbXRzZB8BkMedSJsYHtpQu36JUBuliGN/RqVHGexLmiXcI stLEZLq8JZtwtpmWOoeVEDFDTeCg/SAAtpIJMvrVU6byTV7hLbQcq4aBdlqOVA0vOzz8skdD+fz vQu1qUYO7mYfmK/0Mr3W4tyf6lw+PuHelxNWIXDh0RRbmnMbZxLhIYiMHYLcOGwJE/38= X-Gm-Gg: AeBDiesPryEFlu/QLRKlgkELCKqrIDasraNixNcF9Mkjgj9d6ZHDrL+gSLadOJyJpZf 4JvAS7acnTRtxo5IaxIW8kAiwKgeIFMSwjILvwsN2V+kCR/zA/fjY+QxNN50II0NFtobwnHmclP d1nKqNXgUD/77Rkhl88Bw4jf3ScoegN2ky57enXTxWP3VuQRl3lwvkkdybKoPFbYzA7ilgrV/JZ DVTyis92nKjN+2rPoYYVuHxGTOx68rDROnfJwDZ2OJ2/oPlaf26lIT6UGul6T44aI/Dxe5qvosp SHX5dEM2CnbFWiQGkPCygIyXDbi7Y9z+MWDkWAs4vRxTBkvXJe/7QQXjmLomUUmbhSKn3DKt/eY obGEu3CXxIsshiV8vRgsK6pImDDxBnA4SsmwDeQpINWBmHWGAhoeSox49guol91L5aBknk3sd2w ooUSitYIu7pYAAMv7Gzm5CZB3H/FZVq8VRmFlXfAJioWsyhQ== X-Received: by 2002:a17:903:1aa6:b0:2b2:b117:1d5d with SMTP id d9443c01a7336-2ba7a358945mr82837615ad.33.1778159031531; Thu, 07 May 2026 06:03:51 -0700 (PDT) X-Received: by 2002:a17:903:1aa6:b0:2b2:b117:1d5d with SMTP id d9443c01a7336-2ba7a358945mr82836845ad.33.1778159030983; Thu, 07 May 2026 06:03:50 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:48 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:11 +0300 Subject: [PATCH v4 15/29] drm/msm/mdss: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-15-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2044; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=6iZnedW4RBQxA96XKjwsTUc9JsPI83to3JJHc5dyQQ4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2G9ANDXPjlZexp+XhfAK0XepXdN3d9kDcOB kYWyWUseyKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhgAKCRCLPIo+Aiko 1f2eCACpC1lnsPAc81O0pYhBeuPkG7mEdw2fwShl44wnSc0uzz1Ke4np7eTGJ3sNDJfEMVbGmZA SDtQST7+/BolNJvvzmWooCgJowDyCLUBOH9TMs+49kZrkbx2UmNbQnPUnGi+9HDXOzJ9KAs63kh EE51MckhcC4/vBYQgu7hoaZ87ffFPl2iWv0UMbXJkH49yi4qean9X0bDEpmtyhjbJLquLsinVTZ /EH4ab6GXPAGzPhLa8AxDOP06ykclcM4iT5IRKWiPhiARDoztOSbSZtsNo877qSak3X4nT5QvDk qiIlNGfZsvkX48s/w/XumIMX7qn9IcM54iZe1K9JeD6xNwc/ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: tm9PvCQqK72eyLe_jDLmczRk78bu-4UE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX3TRztjhlhnXR pcYfxbOF1S4EQ23xECfRI8sXTf/H8zjnsuaocOwoMpkIpcYTLT5UrSpeu6fiLbPQ2tP32aWV3VV yOrGZoJ3HeOclItqFr0Hh/TPlBXBLxUxA3WD/vimLfy/IS1pX/IepEhJT6PnDLOs8IKb59sKxdi XBZp+O61OGh/4NmuU8UQT2aDqCRFWTHK91I/vJG1AmZPgxxTG8120x4ElWsJD9Cv3vsrOTCwZNf ErtLGPSLDcAiQ54LQpMZa/h6ksKVE6cWYAApauL6fZVlV7TtEm2Z8jUmM69isbTpzHT6AgLwnn8 fneEbBzzT3G2KUJg8sTtKvbddtw8iQUT5UIjL34ch4MnVOVEGB0jU/H4tdZ7YwLZvPD7eWHms/a saGhDXzyaiTpeZO/SGiKypHTzApKtObJQ2jZktblf+VwV6H6m4zawcKX7El/N4PL2gDRy/Va7WR d52dqAi6Z7Om+sBQHPA== X-Proofpoint-GUID: tm9PvCQqK72eyLe_jDLmczRk78bu-4UE X-Authority-Analysis: v=2.4 cv=X8Zi7mTe c=1 sm=1 tr=0 ts=69fc8db8 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=crYPmtHWi7n-_IQ59sQA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index bf106d849dea..3c1f04f12c3d 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -169,7 +169,8 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *ms= m_mdss) static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); @@ -180,7 +181,8 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm= _mdss) static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 if (qcom_ubwc_macrotile_mode(data)) @@ -197,7 +199,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data)) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); u32 prediction_mode; =20 --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEB45401A09 for ; Thu, 7 May 2026 13:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159037; cv=none; b=nisRZ2UCqgBfLm7Bu0Fm3N1rO5CIPfBJRUUdIWNP2a+Y6EUoaCKjvRSyd1UaKQ74vokANg475kHzli0PzykYZlBU0m55g0dVhz3lhzZe1PAqQ+Xak1YjIonKP6X0NuQouW82uFjRwlLp1cldeyVt2R+trwadWgzzcyitcQgA5tY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159037; c=relaxed/simple; bh=q9RI/4rORLjuoIkao8D5cG6JGxpUvALVyWJahsPA044=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ez+jZtDolgzQrP7JdtsUGqxNA3Hq+hqG/6AwkbNREkUC/ekrMDXIuxftgUDjk7Mf/mbUgYyRqHJqyCLnhBouLC2kdpup/PTu+ArmEjl3uktz0yY8FT0j8syvvnh21ksyd5Zt1ULXYXtK7xk1AIYc+7oW29vJcErOAhft9NbNUt8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oEywWpGS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YI0h0a4l; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oEywWpGS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YI0h0a4l" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647C5aJP1971771 for ; Thu, 7 May 2026 13:03:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MiMZZ1052yDPRoDHI1EQCs5Lnko8TFUQgp+tMPDYfxQ=; b=oEywWpGSzWRePXJK gmG1MvdkLWgvs6152dzalF5sQftTpJxaqH1daASeYlBM0l5gYL6pLSiH5qWUfe4H ulAtdmChIW1WcQrRFRMDv+jKAyamkWAj8q+pcpvy1GfdhD5pTLTEQXFepJTimqKq oXpidnNp2Eu3jRbNtlnwIA+nv2PLFjUNt8deB9mcIFo0LhbmV0kVAyw99zuQqDLO 5ONobA05VEM5di7vVEqScyCEnIiVY1IFHo/n0gvqTWvRA9VgQTzOG/u+Zq1d8mId Ois3lr3MHOo8acLrGGpqJjE1Lfx8IlExdZns03/+lgjp7Pz7AxupBT1G5elMEZiM mrwKdg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0tej86ea-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:56 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b2ecc96a9aso9459115ad.1 for ; Thu, 07 May 2026 06:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159035; x=1778763835; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MiMZZ1052yDPRoDHI1EQCs5Lnko8TFUQgp+tMPDYfxQ=; b=YI0h0a4lwy2D1Pnc0i0p+AjGLy0ck7pYwlNEU/7emlVUPF1nM61pIV/WhEjTP9RSzZ 5kmr3OThH4CifStHPOVzCt0VzfbmwJMrJ/ohKS6AYUWrXfHaWPnEd802hXfqVXbAiNm5 ruirb58AUy5UZNzSHi9N3KTWCuzU/ED7vp62hPpWM8lc5qUJ/jU9QWLEl26HuiMUT3GK 3lcS9+3avBQC5kFU2FGtm+fUfXMgxjaT8Pznh/nnfAmdop5gW43dibaFt2kGoCBAhcpt K8yj+PFEQ5gX+F7R0pnrMUipBcNEDfAAvRWGbGBBW74P/WayyyqaexSEpULhp1hLCbKa R0tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159035; x=1778763835; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MiMZZ1052yDPRoDHI1EQCs5Lnko8TFUQgp+tMPDYfxQ=; b=XnE4yNV89Hfj5zD+MGBmQavb1EpnME1qjqZrB4/RYSYpEWh7zC0vunde0rA2EJa+ju gv1S5NavmUGFPCAVP9uMUfEphxfgwLqIUSrrPopJTFhMUTPPZAY0ap/9PmwC6WUSTJuk 7MCEfDCMLOF1IRtvgt0oY4Jqkg3w972yJKUcK/5CQAb6riRLpDmHJifc0nD2hXuCkiKS v5po1UAi8xKfcYz0/+NfXn4VrU2z3wZ+761xWIVDBqV0L9qjQn+r5UvU7L0lKUSY1xfd utwKVObcMfxEpUKe2WKTeTbCEP0azO+aWrPno/cya5Z9rKIEpxxxOTlkx/gEHZ+G4/3c +xKA== X-Forwarded-Encrypted: i=1; AFNElJ9YAqpmoP/ltHDToFDsvrdBpAQrXG7wQtoSOq9dMPQTVBa0UQ6PtyPsHRMraQqRl1SWU1QLDnROqw0M/kQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7YjY+g7nEBC9V6kn5g4pCNWsPM4x920d35xaH+IZ3vIiim410 Ibgu/R8t3Omv8g3znvWET1brt/gtoLoF1qGdUSgrz0xgjHZLXunMBAVW7eKM32ZaL+yIV9Z2rhw jnAcfNeWeDBASkyQAi7F1aXLW8sxXhmAWij7v/ygWECcEvipvQBVqjg4lB+1eBRbwcmc= X-Gm-Gg: AeBDietnk+Sau8/jTZDrynRwzgmxZ+Jas7z67MtqQgPJrf1m7ahFzNl4DHsAOE9vrN/ xbtNikFwKnaYEZAP+FxGzuiXsspAFnVJhoKPoTFHWysPkJoWnVVIEFk2oVFqOdFvm83Rt0QznM5 jtZSnIWuYbcLoW+YOsnJK3jFL/jGov638iM1vsIlLnGdiiHn7O2BLdREWwvpA8VY0Id4t+9TGcI 57LeqyzTNqaPcf8SFDr7isFL6NcmQYdYp8jpFAmXRMEMK1gDk1N1yPgr8tnVsL3xqUNrKd5laLq zedAGO+u/G9rSspFxSYmfTuRCLYO8tgitUEswhAMaSISea9oCHBYhq9kBrNLBLCNB5rHLeZZLPV c/cxvZquNi1pjJsGP62V+AQJqAw4uns7j6EoMdIEOGKNQbavsyimIzJJEICHuvT4BQ3kpjl38jV tMk2FyStcirwTs2j+4xk/JDjYT76MV4at3A3vEsLvCr5GaxA== X-Received: by 2002:a17:903:4b03:b0:2b7:ac66:27ff with SMTP id d9443c01a7336-2ba79c1032fmr77299075ad.25.1778159034984; Thu, 07 May 2026 06:03:54 -0700 (PDT) X-Received: by 2002:a17:903:4b03:b0:2b7:ac66:27ff with SMTP id d9443c01a7336-2ba79c1032fmr77298475ad.25.1778159034308; Thu, 07 May 2026 06:03:54 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:51 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:12 +0300 Subject: [PATCH v4 16/29] drm/msm/adreno: write reserved UBWC-related bits Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-16-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=912; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=q9RI/4rORLjuoIkao8D5cG6JGxpUvALVyWJahsPA044=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2GchYN7k+lOs1ISxjgfJ+YmoTHo6uU2sMGV ijFP89R/TCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhgAKCRCLPIo+Aiko 1We7B/4nSv9/kJ3DeWZeYVRCTBVttJUCHRTg8V1FDz/S49P6d3ChSpvqwAtC6qEbbwBMkPev70i hajv0BIcGPINEkBkx5Szj8sd9OuxWfWFZxhAoGTkAG7VHBGMjLVOt3ySYJt/t+beCHOUxmurbQx HPoEnTHbPhbDKzNX4T9tAPB3L/GJfAGyO7lvLPpxRkaDVzp0U9gybFNy6qNOn2e8p9sGVtVxK0I 6Z36Je1P7olk7igueQ1NWSgmlKYr8KFv/kTWzEjgHsqIdD8kziId5L7ePl1MJhTnIwQu/FWhIcb ePUi+V4fHBQFJq25foDv7SgGqmdLWsMvIA62sFVE+boCOL4v X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfXyo91QNNZbqQj U2bYB2Z8zBtQq/yRKEPsRzkwSHLqHdWp50kVkkxTDlhteGMBKTjk32RqIdka4FsuAue2Tvt5CQu 1FeJJexldGEcW0ONhrfKdcVqwVY+T+TRiGruU8853di3nWTKaTVPpkPvAV4WXiJqYNME/cKKObA iTddKXkSmgEQDFt+oaSidFv+glsrYn6ixneqdM7r6knm/fGsZk3sSjkOzLKyu/1g1lbiEnzJFsn la4N4Lf/tKaiPGrGZk7/lXPzCpP9/RBcs1FctgxpQILtyUUy4ogwwhOXvVxdjA1mNb7jfekPlfr D6xdf3L5RgTkKc+Qz0yajJgmkVi8MWshGT3Y/x941JwKpmpVwl5kf3E81zs/2NlH0Vj4s5B/58k gI8gjF2QP9/Fnf14bhaBaFPcx8uuuWxWvjFpDaa7N/u8D4F5t0u6OzeRz16IQyyn1Wy+iiU1Yrl REtj2LjMu/9e9ZCwTDQ== X-Proofpoint-GUID: mBfQXYEKOZhnDW7OofN4ownqyHV0BC_- X-Authority-Analysis: v=2.4 cv=VNbtWdPX c=1 sm=1 tr=0 ts=69fc8dbc cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=jQZLqUlzLjo5U5EXcnwA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: mBfQXYEKOZhnDW7OofN4ownqyHV0BC_- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 On the latest A8xx Adreno chips several of the bits in the UBWC-related registers are now hardwired to 1. Currently the driver doesn't write them because there is no side-effect. In the preparation for the refactoring in the next patch, write '1' to those bits anyway. Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 53def136e0fc..7a6223ddd8cf 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -288,6 +288,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) switch (ubwc_version) { case UBWC_6_0: yuvnotcomptofc =3D true; + amsbc =3D true; + rgb565_predicator =3D true; break; case UBWC_5_0: amsbc =3D true; --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B5040629C for ; Thu, 7 May 2026 13:03:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159041; cv=none; b=ThxsJZ8NlbLHnW7IHsBV4ps2/rjfw6EE06/48mlNBKG9mjAAkis2sclKLu9HndppbKpHPnvhNVB5JrYigvQTrizqw9Y8YHJADE1n/IiCyq4uhQiv9XKvqPDgGTnOj2oqWsnOHBLH5qhAETjtv6WTodvIgJ4ps5HBPDHI8Fwejp0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159041; c=relaxed/simple; bh=b5oeFZM8UPd7zv2z1rm1o1ivK8BBOWD5ytqdmxE1CA0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ap0hG0VdPHBZCDnhNwK5cQ+2iRvJzjNGQy8bi7LqMeGBopLsl7LIjDa373ycjyV5E1uUprmkt2wpTmS2DDavGH/OnC4r/hy8BAX88rnYGPfimpGGCiKV42OgaJUfoIWdpOnoHXfYnCjGzhuBAjIwtnOfnzLo8GUIugMaN0bcLxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZRcq+4ot; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YmaVHJBW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZRcq+4ot"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YmaVHJBW" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647Ben5H3157738 for ; Thu, 7 May 2026 13:03:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AeVRvHRKAYbWbJMpPrGT8xN78iC1aUQpOFXz3bq+KTg=; b=ZRcq+4otWaGHZqh1 bxnrlJIGhp0MaQq2+CAOumilZ4LzHZdZoJW+BDJwe6YXL+9o++IOgbY8w3Vd8+yP czeYPXSQqXMcEd4CRvNSjXG9LNv4y8PnCoCGf7uYglr/F9pZXFeA/541d5JMudaN 1HKkKcG0FonEzA6uWR6BB1zBGDGStvZcFl6QE41fbCC/jLXPAwwwaRc6Qb5WYoLK Zwu9tas/1BXUq0cqXN1rzOjRYN9l+GA/4qRFOIcUli/4dRPolJXdqA83bl5J43up FSZEpwjLzHWvSXGVwnrdwlfUwcUtdexExZa7cFrHDcf3fT2bj7uV0D/JZixuXIf0 5zAv3A== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0mhf1n3m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:03:58 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ba6ca20ceeso9491895ad.2 for ; Thu, 07 May 2026 06:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159038; x=1778763838; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AeVRvHRKAYbWbJMpPrGT8xN78iC1aUQpOFXz3bq+KTg=; b=YmaVHJBWFgV5U6MU0/QzKkjSmkzXT0TATmd7tNB/9FvB4/Ix2zCPG+pTReJL79wCJJ sIdNqG4uuYPFJagwbR4rSCFtExaF27T6qBjjaPKt2CCLy8RLON6rWQtHSmyEPChDEZlk ImX8OcdGbFBIL7oMSaY/tsVW0SW9+62BfEIQW3g5vnVMl2PInRJGY5HKvU9Y3nqG2E4Z C5zRzmPydfgfnsBX3bohD0HZOycRv0qsbbc43iJ7PjLZHYJlG8AhFZi7ZFbacPat4YJF GI4onnwcSk855TCghvA9JRd8Wqi7pjHhyMFBkjXtrEu58TclBB7NcFvhl4oaKOpGwnci LBkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159038; x=1778763838; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AeVRvHRKAYbWbJMpPrGT8xN78iC1aUQpOFXz3bq+KTg=; b=cqQBgBv25wNfLHYys0e6kmjMYSz220VszTQEedWVtD8tmWZSbq8a+QpbXBW/QzIZUG riLPY5vclU1ZmnyRrvis1yegs/ihHNPKNuNb91XBO3XICwXNzFxHMCadikpOyOazEbcX Lv3qJw789Qe1Zcafufggs9tI8i/7amthVhEmnVicQ4i2mE9GlW3kdPcVcdCeLRxvE8rx BPGkj8dzFl6Y5sHwYEYKfinQ+fNRPYgVnH7XmOX5ZqeTYEWjMxfNp/KqANqP+SVmJeAi 4o6XliSKhRdmhdrKl7KdKdYAck91N9um3tnYHqzTukVm6GB7PZWTpW3ssE+PJfkk7Et2 TRjA== X-Forwarded-Encrypted: i=1; AFNElJ+zIcVvq9kFOUazt9vT6WYuyzoJMJQefXgYaMwFCeKVDb+12s2iGY9CH9A8T3qMTLT4rANdD9j85UtcS8w=@vger.kernel.org X-Gm-Message-State: AOJu0YzKtU4+0mOoCPL97ipRl2cD55kAXfH1R/RHJkJUXG97xs+jFUmR odBdY5egEKnJDSycT+LFyDOcTaNRGONELT2eN4vctJaphiWoRXF0rE3Bme/8/UQlNGPmkG7vmJb 3/LPHiOquTnXjbv82yZZfla0aNk1uPDoA3YIdFqi2XoMGqfycT84L5bMoarYBH2AjM1E= X-Gm-Gg: AeBDiet+s8di0/9RWeBcElPnNyfFSq4v/3IsO2Eq9/BxPS0z8xsL+ZK+O/eI+lSRDRR 9xNMgY8dq4CMkXNHGhz+stji+r61a3ZU/VdiDCYos9dW+KpOFhnfqMpjaKyhXrH6Ej8Eg6cAcMZ UTfvqRtkk7yRU1Bebqj+rZakUr+rIc9wSsHgqaixz/8+bgCPFMgj4yuQJ5Z9o85YQoZ614Opi0F 3sSx3npuBUHybUmFCqhPg2/w1DqgHrrIi6fe6J3JNEch2sJgWAbKrJ4oOXyFh9uPyzT621LIu4i 0uBVLyLfaEvgiwH8zjLcDUrH+PiBeAYx7U3U/Hgi2hFaZIp0Ntex/2pjs+IvG0kfhBgJ6BoUYJz rFl0KZeeTwjUoqbO3AopphLa76XcuLM4QVxcPsr0UcKRSEIjIAiX6b9LMNs9rbDy0wNyDYLzsVT GoiF6xImDVOaLmPUU+LhK9v19uY9QrmoGnuddYIZrHSn0x+g== X-Received: by 2002:a17:903:144f:b0:2ba:359a:9b8e with SMTP id d9443c01a7336-2ba793bfacbmr84139365ad.10.1778159037723; Thu, 07 May 2026 06:03:57 -0700 (PDT) X-Received: by 2002:a17:903:144f:b0:2ba:359a:9b8e with SMTP id d9443c01a7336-2ba793bfacbmr84138475ad.10.1778159037036; Thu, 07 May 2026 06:03:57 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:55 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:13 +0300 Subject: [PATCH v4 17/29] drm/msm/adreno: set fp16compoptdis for UBWC 3.0 formats Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-17-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=745; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=b5oeFZM8UPd7zv2z1rm1o1ivK8BBOWD5ytqdmxE1CA0=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+af3rYX3FZbNBPE/r1uK7Y3d54lX2gczJ+Vaf7267U5n t92OLR2MhqzMDByMciKKbL4FLRMjdmUHPZhx9R6mEGsTCBTGLg4BWAihn/Z/9fwbwq7r+NVLptm uzfQtVBrxV/F/+L9Lzu1ZkofDpj25ei/X7xbnvidPeRyxnDJ3neZokdyj8vwb+XRu6DqmTdpsnK YL2d33tcjWu358zrDFhxnuZ4rZXSvfM/KZ28cf0upTt2oJVbuEXAo/rHBoWJH7ZrSP20Lghuqn/ UEXQm5fOiR23w9pboFHxekGd/NOmQbcEKavfq5RnbGhYgQ489cXQfbOO67ums9OutidPdPdgNPh /n+LX/3MlX3qO1u4F75TT3IRzP98Uk3V9umG3m6HhHlq9X9V/3bdLXm6rWIy/py3dVN5/V2L52S wFB+ZAO7SJHV3hV3Q4KaBNnDUkWvij1LW3758uoFj+NtAQ== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX7vd3EGvCGeUI 58RO4Sn02SVRP7ne25e69wZwkWvaI9Ob25lkj9qaqMUIrd8dGZkeA5s7kZHbkur6JFg3COg0d4V o8teiwJOML02xwI0Le9WiZNaJPPnHky3F/TSlM23UpGy2s+MFva4kXdGLO1KwyME90MOwyEYEJf o5JGrRzt/WcF72BZNqK5LgPvjVuK6Tqf9gjHGaCSbDEEmS+gqHsW6eS9PBH5u+5iieM2ubozl1M o6UIwrePQv1+cSkSC/4u/ap2BFlWAq6oNIhYW+T158Q1MLiolMDxoo4QJNVbyzuWcgS57RVp5Tw UKV6k8C1n+j9CrQanTsC42POZ22EE4LIh1hJfYWCTG8DnHprPakleQb0YkSX4nwUNG+ENKcUtR4 vTVkLVnTnnyZGbFDbt2uQGKD4APdpAzrboQ0vZIN7yMf9c7FMDyq2+Zirta+e1OVVHxLh+3s2EZ lznw6QbYewhtSzuuU9A== X-Proofpoint-ORIG-GUID: ASL-eRy_OAifF_3h5v1mMVih31xIPU-e X-Authority-Analysis: v=2.4 cv=SuagLvO0 c=1 sm=1 tr=0 ts=69fc8dbe cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=CoZj-JnWnDGe1ZqNdgAA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: ASL-eRy_OAifF_3h5v1mMVih31xIPU-e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 The fp16compoptdis bit should be set if the system targets UBWC 3.0 format in addition to UBWC 4.0. Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 7a6223ddd8cf..867c7d05f670 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -303,6 +303,7 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) break; case UBWC_3_0: amsbc =3D true; + fp16compoptdis =3D true; break; default: dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A019B40B6E7 for ; Thu, 7 May 2026 13:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159043; cv=none; b=ViMjURDpYxzqnrEuhSwr+AmJwb+TrViO6l8jUSip54bFYZKcp2SFQdafe77HFL+bAFnqz+pIX9R6BS9GEcWkuB06717nxiYD1rvC+ChT+LhJSFHSF54N/miDCrbL7811g2RKuyUd+P+aw3H/wMFCp0AGSO1WL626UItwNgnULJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159043; c=relaxed/simple; bh=Ibw1W4RxXxm+xTq1o2582iDKALgKQbHejlJobaatd7Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cJyG8MrsAW69SZ62BQf1M7MOVc3ULwmdBpP8nDxVe0/0nx93EDsaC0Dfw2tlBwFoGBALOzrfIlWEaHJpEWY4ef9lDYe20HZs4p0xpF/ieKkNG8+S5xMSbhX+gTlzC9u1N2OJPXZPne0xgSUtye4Xwis7sF7DcC1ZyDMlQUYTV1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o+xa7thf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OvJnVwZR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o+xa7thf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OvJnVwZR" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647AD6tR880640 for ; Thu, 7 May 2026 13:04:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nOhtk+T5Qeojg+oP0GMyR2EynxX1OfJWaHf6gSAwPPA=; b=o+xa7thf4YlEoVfX +SQQS25mphW2NL5GBsNLBD8jki8Zu22zEm8mtCw/JnyIraP7EOUbyyd9tTGO1rOf I0lQAOsk3IQ/YLO9pnp4NTtuLDGs9+a4tUJPG0jF4cGW8fltwsbyo5iPLwflXPw5 ZPVAn6zilGWwMdSi/XlTQIGiXP9pYMK2s8AhnFLcN9r9yuJLvUvLpHNUm/UDU9Eo XqHL39xztDfA0migHqRcJ2CrFuO/yqL3ah3pS2qEZfYVRJu6AQwOJTWbI+g5Ps8S c+O+A9sJPJLhxSHExZSiAiZbkJ93oPAsFqA5VBxoFj04GHU8EpQNA1m75jc6bGQe /clbog== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kdq1vd8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:01 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b2d83e7461so15775345ad.3 for ; Thu, 07 May 2026 06:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159040; x=1778763840; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nOhtk+T5Qeojg+oP0GMyR2EynxX1OfJWaHf6gSAwPPA=; b=OvJnVwZRaooI5tRzFa3VlB6WLRmdHs7LGH4UG4UYX1ahw5TY/YTJV4MSsfcWK/N3TX MZunNuINXq8PFjzUXiL1Xr0XvuH2MbkKB8i5CV2fR4XbWW8ETY3E262Gih7BCs4KlYZp +nYOI4wiXhqOmG3TG/NtulJkqdZ6q3wL8PD0zgsYrlv30+uRZpNZv+Rh6lOwDENDylFz QeErodnFZxO59D0H3SRW9VuoUsi7Dpd7qVESOyXa1p8DtBL2fXmwdCUzdGUq1cY6mIzs DxrNrt681yNSqDdeqavONlGX0Klrx8CYpWQQn/a0r/2oab33tKZQEgstgP61JvZurXS+ i79A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159040; x=1778763840; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nOhtk+T5Qeojg+oP0GMyR2EynxX1OfJWaHf6gSAwPPA=; b=rjIBKPYKtGgnGz7EeXvuZTLtivaB00EQEC1hMQEyanlCBALsw1AzQ7d0UDG2zw5g6i 9ItBy/GIW4Aqoodxlttoq6HjY8H6GZ3pBGFsKwjhVQ+0OM39RE6TPW4liORdMBiLKl5R jWujTAAd+Ts9S4nSFXQenU9zaDraDzDkd+be2dksYK7n3f1EImxyzYbIVOfF6NksfpYq bGfcVHe94Fp7IJKTPA6PazRPqmdonufgjdH+S+VTtfOTVRKJk3lGB9a9zFEV9iwI85kE C9PMXt9rwenD/UXyRFidVrNUSoxwMbC0KnWi6zs93cCzn/4YDlqhk4sAI4ymzkh3YUx5 cGiA== X-Forwarded-Encrypted: i=1; AFNElJ/5BzJxH0Hp/LSUyAcRT2H32T0/T6fuw8TRmZOtX95Y76eqEmILZK2JQZpR3hYWZDtpHM+LUwQ/Jqkj0XE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywvi2lUm59OpT62I2hzLac+P9TMLiMkwMmSSqRM/fJhGn0lfHlQ X9jcO+A1S8wVCYOc4AMvQ6GVfmHhZCIPXIi9OKphsZGNxFKEo901IDwSY/tjEkLrY0ZWgJbwG6r v24F7UyP5zRWzeIfByEgus0XYSgZRh9DV+PdhtOICIyqten84NlxAmZW6vJkaEgMEg9Y= X-Gm-Gg: AeBDievfI8cv6AywatSNn6+81bDLb1ufTCanH3IsxUztdEzRIjgIkZ1m4rz5ggB1232 UXeoOQ87whz9ow8BTmojXCcSmgE4aLvhkT60omj6y+gDwWhApZ9tTVTa6Ko1Van8XOSZAYEUcRo g+Zl6+0Kz6j2/s8MBLVXI/nFJ8eMgB8uombCazE+Fw/bi7fkh2uuFI1SvWk2MOU/DyGY/ojQWZ2 tetndZhUzKcogqK0RtDKY7FGubM2dZwrf8vRFQjdR599+D1B/K9oTjFUFDnQndPgJU64aRhFN+J viqumL5eSWTxOyoj3t8LJuUnjip0m0XO84jfWitoXZZgjyf0XD8ZMqSVi7wDltcWunuwAqb6yJB GOKSO4mLFMH7QFd9PRnCGKPxVJr0X+raTjNZTkaBdXvolK0cUM7RDVO8HrPPYq445P6pwC2krcJ PG9fdcRErztDibqF5Cg06C4Qj7XYCqfD2E12L7/fzqLY8Uml4XJb5/spLe X-Received: by 2002:a17:903:151:b0:2b4:5cea:f61c with SMTP id d9443c01a7336-2ba78b48767mr57604385ad.4.1778159040342; Thu, 07 May 2026 06:04:00 -0700 (PDT) X-Received: by 2002:a17:903:151:b0:2b4:5cea:f61c with SMTP id d9443c01a7336-2ba78b48767mr57603755ad.4.1778159039654; Thu, 07 May 2026 06:03:59 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:03:57 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:14 +0300 Subject: [PATCH v4 18/29] drm/msm/adreno: use new helper to set amsbc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-18-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2249; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Ibw1W4RxXxm+xTq1o2582iDKALgKQbHejlJobaatd7Q=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2GdeQsVex3N6owpP2pA9FewFltQW5GK42rB dz4tBHATp+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhgAKCRCLPIo+Aiko 1XWQCACgehnNB4GH/t78ejQi5pMD6T9QCqnBPc224Zs2w6wxkll2e1PSz4Rdl2BakSN0BD9lbqf lgatMMprwMfSfuMAHEjUflF60smTphqMqTp//8m8CaKjfsiLK6z8hrlwIO8dALiXOeJrOOSO/eH OqQva/bU3OVvAAp/MkwHMGGPVz7kcyFmlboECTg69GuP+SBeRp6voRakIdNEHqvOKpY29e9d2nj tAyZCO99prTbo6i1xDBmfl8MQfriIkd0hSXc3Se2X3lCjiz+XHH3R3/nfP3uQCXEaakffdpYa5v lkT3rZL++8OZBZQMyqeaFKeTnTHZ0IpdSmI5McMAbxSdfwGf X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=P6IKQCAu c=1 sm=1 tr=0 ts=69fc8dc1 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=ZxXxw7YCAI2S9HbMwnMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: y5eXoQnNyob-rZSYf0I9tW2XYcpzdOFh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX29vGlBj/fVA7 bCG4iAm2fAQt5vH16QyiJm6JK/BzV5qMWKmeJtt7tEosc7tKzztea8TPICoOOJ5ARH3mP7k+1Jq obV8O8na4m4Iv0adFWldgtbyBntabkBuVpycgSZJ5bBHF2q8kLi4gt5FlwjAsZn7j9W24/0YSSK k3BnqnlFbjL0FVyW7Ii1jAJyYgGfX8o6zkgEpm8XzE+CdSFl9Yst12+qUJ33D7G1pjuR61WOYA6 X7uXFYytBoEA/v4fc7BZ5tANrxSFe6xmxarEZre0wxjn142cWYrkPAZa930U4uJOinrluN7tlAw kLZz0SkCJ1idIXfEmaZMchG0thv736Qllc5S1tdWqZhph44dz3eHmg2NLz/8wqr1Q8XL4HJiAbU 9YW9EcXmA/FicxhP01ZbCtBqEJCLNu+mogEV/eoHcXQ5yIo44Ug7d85fxnoaAlpbbT80ZUc/NT1 Gkmv8A6sKTrJMCd8tZA== X-Proofpoint-GUID: y5eXoQnNyob-rZSYf0I9tW2XYcpzdOFh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of checking the UBWC version directly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 5c17565b0499..a88489bdad9a 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -747,7 +747,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) bool rgb565_predicator =3D cfg->ubwc_enc_version >=3D UBWC_4_0; u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); - bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; + bool amsbc =3D qcom_ubwc_enable_amsbc(cfg); bool min_acc_len_64b; u8 uavflagprd_inv =3D 0; u32 hbb_hi =3D hbb >> 2; diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 867c7d05f670..5c73a9ebb22b 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -279,7 +279,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) u32 level3_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL3); bool rgba8888_lossless =3D false, fp16compoptdis =3D false; bool yuvnotcomptofc =3D false, min_acc_len_64b =3D false; - bool rgb565_predicator =3D false, amsbc =3D false; + bool rgb565_predicator =3D false; + bool amsbc =3D qcom_ubwc_enable_amsbc(cfg); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); u32 ubwc_version =3D cfg->ubwc_enc_version; u32 hbb, hbb_hi, hbb_lo, mode; @@ -288,21 +289,17 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) switch (ubwc_version) { case UBWC_6_0: yuvnotcomptofc =3D true; - amsbc =3D true; rgb565_predicator =3D true; break; case UBWC_5_0: - amsbc =3D true; rgb565_predicator =3D true; break; case UBWC_4_0: - amsbc =3D true; rgb565_predicator =3D true; fp16compoptdis =3D true; rgba8888_lossless =3D true; break; case UBWC_3_0: - amsbc =3D true; fp16compoptdis =3D true; break; default: --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93BE7410D1E for ; Thu, 7 May 2026 13:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159046; cv=none; b=am+ZF7YOUglC9tuMJulRXPRx8F8Owk0nvBA1kEO+fJc4LcFLOuAtkcEc0mFke2/VbqMO2il5vbBeqp5/+0eNI02AvzjBhWy4pUMwEWhkEqS7DdT7uYQZQjKFLMkkqwHffNKrVrA0y/AELZz4WUyc7cXB3RVMW6WlXUpoRoO7bPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159046; c=relaxed/simple; bh=7nrYY1d9un3JHGJyq3BRJ2z/M2VzjkpGLEXSGdy8WNA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sYdT32HlqALru8y20Pbi1nSjBtW4Ic6PJ+qtADAyOjpI2dDrBBU9QNWofuTTiXJMGbgnsMjxSfWffAaTsJ3yBxgmZ4/pfAilv0oRoBP27gigQ0hnvaEtUdP5+8VbBPNaMY2I9Xsf7S3wfi2qdJG+7AMPUMyGmsovIeOv4YF4+rw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZGkqHeF1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NvbQ3sTJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZGkqHeF1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NvbQ3sTJ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BXbku3924960 for ; Thu, 7 May 2026 13:04:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ldlgil6T6/5NKJw8KrYulsZxvlpSBIcIWd4s+HQX6w4=; b=ZGkqHeF1URW+SCws e9IK+7TJRn6F/L5exOtydPHDI2U/ZaVuyWvSDNjjJYtPAImLL5e2y8IDkwZHaBb9 H5w2Rits0o5L1Ysk5avfwnDbAYcLdeanRQu0qNnSRygjvyAuS4xzjX906Baa+7GX shj7zB/8xcOvPDEP5raWDQttkBWDQN7ZkGV7GhE7kfWb9aa1wLDjV9e4RqMOJfY9 5ZTakvA904rUPyetsdOf+mLrQ4Ly7Toyi0PvwV60zgLlIvrK0qbodJpsiXZY+Ayy kHhTbO679wHBG3pcapmLQz34OZV3mJe47y2j+PLZ6J7uCrKxH7B7bKQ04USEc90m 2/5e5w== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0c88b5hy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:04 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ba268cb5e6so10789695ad.1 for ; Thu, 07 May 2026 06:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159043; x=1778763843; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ldlgil6T6/5NKJw8KrYulsZxvlpSBIcIWd4s+HQX6w4=; b=NvbQ3sTJpcJzzwaMCLPFT+ZZj2/eDLobfLJwuRttyQNK6Nl9TsojY89JvmtLSsP95k W1XgCXvZL37PKegKxsRuFHAMCYPNtLoUNF1mBWmo6z04vrCTkarYA6nFW5NwOo6vL4Tq aEw8UMWNCvuv3lRXlqMRCHpkC1Er8BbcSWrIb1ImZ0V4XWhlMk1e4niC47tVQyf+gJ4+ /5u5fsu+L0z3jlBGX/0yvFnbXUQvkmfHgAwg27PY5iEvjKve+D/8qr40by1mvoXGj52D H7yMXgtEKJdsSi/n9GtU625twkxoX0Q0bXOVaLQN9GpZGc/Jgz1pU9ObdbnTxi0SFVLq 6+wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159043; x=1778763843; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ldlgil6T6/5NKJw8KrYulsZxvlpSBIcIWd4s+HQX6w4=; b=jrHsqqZGaUgXjk71HSda3CGpHethYuVHqZMSazeYXKa1H0vtRu96Re6HeIkoAzSqR4 0HU44i5L9IOjZDZK9jibWre5+OUMa45DiXONc7Ls0/c4egPwS0p5K1aOT3blDSkFyUoK HFHTg0ZOehtHmK1PBIP1wa3d7ozN0gSlLaETn/j2VpBB91ZdAVtxq3TF1UWUU3tCA59U r2Fw5mq7tg/bYNBhD8nc0NZbcdlU3k+Ku/pwS87GNCzwC2tsX+DUr+icKXyHGM9W1nPe awy46+Rgm/t7TTuv76SdkhwNRZ/CCIqicJNquIKn/5wxeuIVaZfV+oT+mKgYV+/PXb/C LnOg== X-Forwarded-Encrypted: i=1; AFNElJ9vO9uV7/8AGxyLbOiJW4uLv8nd0x2lw/SkdCv4Tj7++BrOme+Rlo3RZ486IyE7hL5BLjFp9mYMGTnAM24=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk3AnHNs8PC5eWmJIRCBaLNxWOm47Czt2iXwdyhFSPxcHWupQv hNgj4MM/UNWs/DCKgi969HI+MrIGBZHVC99Hfn6ToD5g+LUCt6ltUyTed3UlFJNMFl2Nkh3oAwM U9uHXKfGe6s45zhNny3OixB+N4ZqTQigNEDjGfUTE4nqhGma4a+lDcyD7fVfqlKnFFUF9cPwAgz M= X-Gm-Gg: AeBDiet5XzFpSj6X/57k+FbThQH3aBb9J7KBkaedbv2XTHJ/7Kpj4FLQAu/tl+ZeP6P ZHtXNErK7/EgxD6mREgNRxS5wLIEGfQDc8AyEfd5VqElZUNHrY/OOIC8k3hDDjuqW2g1UnoczEO hXxTNdHW5c1XGTAdQeJnDagQW0hVp1f98APc7424yygAuFXP5nfaKMdyJNpPdIIGxkJXZxmg5ho wfufz7fA/+QvszM1qZiFAjFKrtiTJ0UV2rigedpPyYPKDGnSzfekQjQ497cKrz9gP5deDQg7Sxh 01R3/EM1MdpUbWHkDdrfOvAYYWlIHomy3TjGBjdJnc9VNQCVAkI1Qg3fo4RePjuPou9oJZ5btOn EaDbLgGPiCav9F5nP3HxHcGrIGMvWFwJ/Y3XoFvVoSxCZUU89Q/DExHKdAWiyuRfvlm03Z9Ynpr KE8BMDp4DuuJ1m06NedO9dTVuaSd8X2Trgc+AlkB09RwTo32fy6kjF/9OQ X-Received: by 2002:a17:902:e98e:b0:2b4:5e65:5d0e with SMTP id d9443c01a7336-2ba78c40260mr59501325ad.10.1778159043074; Thu, 07 May 2026 06:04:03 -0700 (PDT) X-Received: by 2002:a17:902:e98e:b0:2b4:5e65:5d0e with SMTP id d9443c01a7336-2ba78c40260mr59500525ad.10.1778159042416; Thu, 07 May 2026 06:04:02 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:00 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:15 +0300 Subject: [PATCH v4 19/29] drm/msm/adreno: use version ranges in A8xx UBWC code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-19-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1636; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=7nrYY1d9un3JHGJyq3BRJ2z/M2VzjkpGLEXSGdy8WNA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2HFV4iNIrPevcsyGW3PsJzGnufpXhvHluG9 3Ff4QHdI3GJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhwAKCRCLPIo+Aiko 1QDcB/437NhF9MKKW93Zd05HQPiicGhTU0u6hIPpew+wfkTAC4xq4RwTh1ts1t189E9zzu6VKar tW+jE/Bo4MLyoAjJmlMAyprUwA0p6rWl0pgjYNsd25R/FfA8cx6XywsVi6CLTM6JXP1/7nM1VJX N21pjP9hgGrVg5J2H7F2dCVWkn4fjK69vxr3q03fJFSiug2T678vJRKJI7oS4d0WHl8XQbbNCZv YxRtg3UX7IBa739UqCGDxo6M0dFFz2oDQ7wxVVhlESxhRljaCQr16B554hxXHXI1tMMvm7s7Lc4 9bMW2hILye+7e8SSFqEzQOdveSaT83ye8L34Wowi2XpNoZ7o X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: xBmU9bqeLrzVnRj_Q743jVXG671mhb-x X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfXyX4U8gkl5WUS QEYltuahEhX/M0STRNnN2MnHCz5GY/MADRgNCA6vINetfC94iH/dAjF8T7T48Rfpk+xnWBjH5BP EP6KUh+IZja0mwUAmprT8IsiSfTSV+nBxhbrx2xWwZdsUmk3li0LboRk8PGn4+UV4aebqzVB18N BcdnHrr+SHN7XjqdjCtufRL3nKxlN/fa2pXdfXDUA0aeVRN3nViZe+7L916yR34qatrpi8IzfBf y6LDSiNZ5vzgTjZA5KiNysaFJ8rbiGWJmKjaeAOdZNjnaiWw5lOoG9YezD4onT6OTXVZh6GjpZ6 yB6QzccccMNL/45nlUkl0JxqH8NI6hIyEPJex00SS+AM2DhqqpSxWvqIz3cBSn/HlleLf1AmwKP ILXDPpiqVhSZpC9SbZ1Kb2R4pwGuVLpWVykLZfDMb30B+rGZkkfrKnPtQvZgeAw+VYTkgpAa4Am 0PgmXTkUMN3K4zRnMkQ== X-Proofpoint-GUID: xBmU9bqeLrzVnRj_Q743jVXG671mhb-x X-Authority-Analysis: v=2.4 cv=X8Zi7mTe c=1 sm=1 tr=0 ts=69fc8dc4 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=gyY6hpWVHAyQZ-18BSkA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 In order to simplify handling of UBWC minor revisions (like 3.1 or 4.3) use version ranges instead of a case switch. Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 5c73a9ebb22b..29d559fe4683 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -286,26 +286,24 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) u32 hbb, hbb_hi, hbb_lo, mode; u8 uavflagprd_inv =3D 2; =20 - switch (ubwc_version) { - case UBWC_6_0: + if (ubwc_version > UBWC_6_0) + dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); + + if (ubwc_version =3D=3D UBWC_6_0) yuvnotcomptofc =3D true; - rgb565_predicator =3D true; - break; - case UBWC_5_0: - rgb565_predicator =3D true; - break; - case UBWC_4_0: - rgb565_predicator =3D true; - fp16compoptdis =3D true; + + if (ubwc_version < UBWC_5_0 && + ubwc_version >=3D UBWC_4_0) rgba8888_lossless =3D true; - break; - case UBWC_3_0: + + if (ubwc_version < UBWC_4_3) fp16compoptdis =3D true; - break; - default: - dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); - break; - } + + if (cfg->ubwc_enc_version >=3D UBWC_4_0) + rgb565_predicator =3D true; + + if (ubwc_version < UBWC_3_0) + dev_err(&gpu->pdev->dev, "Unsupported UBWC version: 0x%x\n", ubwc_versio= n); =20 mode =3D qcom_ubwc_version_tag(cfg); =20 --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 648FD413245 for ; Thu, 7 May 2026 13:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159049; cv=none; b=I2cWpcSU/t/lMJ+j4xnBPw6C6seWNHoBs2XUHZxdS16fzA+O+2SXQSI8LAUOQbIiz8Odx1nYUtp8nXrhhpzmG4JjZdwILhUDS3bjnw1Prf4FAihQorBIZ44DjvM19rgIRayNoetrievFKt0TkF6k2HaXdkhFrjpiYD0cLbTiy0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159049; c=relaxed/simple; bh=jfFUw3n+8zI8Hc5dMR/bUWCyARr7q9urbKP+Znc56fo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FTfLB7QEmUwANAHTrsiDheR0c+rAwUl1MnYf7hPzVayY0qEhy50Qim4HczxJ9qiKBrtvDQxce466CqvDcOUEVp4Gbuq6bpQniXAsMcbQB3mRUB8f65F2GMmNGqYcsnBgjqN7wePpNTrflw4vrxbiHfuApxykN28L2m7OphfVTtI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GClYmaxv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TuWp1Pob; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GClYmaxv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TuWp1Pob" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6479noX11669703 for ; Thu, 7 May 2026 13:04:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f5dcXSbi9JJIK5ZZ3AWL3CvHDAq4EZmVMbYdJ9eR8Xw=; b=GClYmaxvB4n3Cc9M 7PBRMQNPJ9uAe6+ZAP3+2zIBsVIp2hHhweod8Ham55regqQRwly/drh9VsvsVTy/ 4Q1gooVSf+IN6CgHq5yiSN/PpLN/V6F9yrkYaEmGZk4DLyCuP6xlBYFNsA5uglcg dTRNs7FSSrE84SWmWZeNy85s1/YUoeoXBwCvClSr9zvxMyzNkt9db/N8zK9kRTrq kKMV5JrF6MTAL7S+kODlEQDiGoKcop7K+PaMQ2iJpZP+UxVaweysgLDussI6sdw6 30fMjyUo0YlHDxYXEspY8dEUpA8WkZvnJu9NTna1QPy3ogjmyB2mO9EDhviqiicy cHnfWA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0k1p1xhy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:06 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ba6fe41283so10304445ad.1 for ; Thu, 07 May 2026 06:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159046; x=1778763846; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=f5dcXSbi9JJIK5ZZ3AWL3CvHDAq4EZmVMbYdJ9eR8Xw=; b=TuWp1Pobc+UOQdLEKKDa8ooZ6GMl1VyXAXKzSavvEMJSSzwXWPvDYljT478UiKZgrJ IjyMu1/40spdAEvr1jtw/DzjFDTT1YdtgD2KRMl3jdJ5vSMqqXHGjSmX+5H36X/HJL15 U/kI0cMM6aYVt0I4DnbRPIKavnhSXwUgk0l1JU95TbmxDXKfbBuaRkic5alnyxoNdU/T 2z02yQinnluXF1idq1FfkT9QvHQCZCzJqKa7YJehmm/j/YOrm+Z5D6Iqihftgy/l5ebZ 7ZhsTEg1mtczJvzv2tJtApzydbsqT11aTZq6J/5VLOc7xak/XKLgDsCfytk13CMoF/18 47Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159046; x=1778763846; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=f5dcXSbi9JJIK5ZZ3AWL3CvHDAq4EZmVMbYdJ9eR8Xw=; b=q0F6zJoqBxJ9ypSZzrsJrmU2pY623ffCPtqm2SRSdcXHw7CcG4gX2FO1LxfMclKzJo mz4gpbrwPdYW2Q0G3d1eGD85LQ8QM0HgAlskVEf2kHbl2zI2elYts/6DT2NfQOZM+Yhl 9Jgdi2RBAbLB14WZpbhD81O5y4XYiP0nLs98EkC105o0qApzRilE6/QP142DN44owacQ ucmuZkQy5zjr8ukj0peqj1/XNCRO3qjGotHEkrB+2L+Sk9enikGv1qlwdSxLNSp0sqsN HyvW29DVk/djAxuGzKUEZF4zsL4s7o6BeUgzeTOsyy64UdtLqP+K4CgRuNtkxtaKmncu PGMQ== X-Forwarded-Encrypted: i=1; AFNElJ+SqUYpKbeKbzWyhCP3pKKG9biVmoUjwVrYmMJqrYJNuaqOWJVTX44Km+OApALN+0UkgowCudfNaXWzSrk=@vger.kernel.org X-Gm-Message-State: AOJu0YwaiqbYbSC2rao0+0Fce0YfduUxQ0Wm+1z3el/U8XbXFCnCYzXB hjvS0a3grtUH0NegzX3fXB2+wN+48E1yq84H+LVbnHsjzbxjNQpAARBuBPEvvpvKLtlqnjitYEB hyKnU2TQhwqkW9DjUJmR1xIHjhRO4BybeGrng2uQQKHDMlKZQJzsfIec9LtrU19LCZBI= X-Gm-Gg: AeBDiesqtn3CW7iQ4ssZrjmgra0z5jSf8ajDZB+QF+bB4js0Vq4Kjs8Izcj/cy/ZBlt Z8zvjqDwBVXpg1swhBQ80NrQ5gmGHbNwkrcAxp5ifHop7hHQF/yOPTwSVZoqFr8CzQ/n3lBt4fh S7M0BygtdqP3ewvgWMZYGLeUVjBsi3UK/k9D+HEaPoGLeoVERCSFUqoAV+EFQ3H4hEhwcuyIewm Tf28LmAwK/gq8wYrshxz5nMTvUyd14MK0qBF6Rv/wqSOJ2xhYj7DjRjORyCrdjtDCZqgLu80IMN ihfjFNsqiGNj7v5HkZQiD5wxt27w5ClTqcXBrFIn+M+O2FGp7PueTDBKfVov/Smx+ulweQBd3RG uetkUmb10lrx6dWPz26k8WlXCw8Nag9OaW61zdxyksKNzOMAoGKe/dYzKUVkXgZ+r3bkBsjr7mM 22tp/bbLoWac2htr8J7picUzM0kgIeaM8V+rumIyqPRDJonQ== X-Received: by 2002:a17:903:1c8:b0:2b4:65d8:6a20 with SMTP id d9443c01a7336-2ba78f50177mr85900355ad.2.1778159045754; Thu, 07 May 2026 06:04:05 -0700 (PDT) X-Received: by 2002:a17:903:1c8:b0:2b4:65d8:6a20 with SMTP id d9443c01a7336-2ba78f50177mr85899735ad.2.1778159045163; Thu, 07 May 2026 06:04:05 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:03 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:16 +0300 Subject: [PATCH v4 20/29] drm/msm/mdss: use new helper to set amsbc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-20-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=831; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=jfFUw3n+8zI8Hc5dMR/bUWCyARr7q9urbKP+Znc56fo=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2H23kJy7WAVP5J8TYyfq/seV09GYmAtHwLB TfF7tgvuiGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhwAKCRCLPIo+Aiko 1Z+/B/9YnnwfpTigLvDcMWqXAicQLyW8JNZL3jAPE38t8gxHTptbUXSyn1EruOdI26Oumc0FaKz OmG5G3g441XroiM0xzBL9ikRilCBz7p2FrzDzoOfaTfiyQcoJS2+SVqK27zYFtT8/cwcDHvvFYo OHqrr7zv8aLh70PdDsmKCCfGisvU/3AHDDa/ALduhg8VvkyemtpZMx30FD9wM7TTBmqsqXUhU4j 1cug+tEOBk830LRoaPdGXtDG9HPQQ+7sC3/d3Voulv2OH+5BhW+GplNPc8xjYS/AY2WgQT7YUGN pqbqHfYD1ReeCwpq6Qj1s7olxq5cgBQsgQPJpGYuDxExVF2e X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfXz+t1ah0mGRR9 StGfvkVG+WSG35DkSIST6mkkRO9GknT/3L/la/xxLpxfvmEEgF1UXJMpll5oiqUxOL2T7tWeEPU aqFkWpxRNvMHfHjWFG36l5MR4r7YsIIbLTljkQN4dED8AjktBnpdzCwaDOs45IfITqnTezxQ5Pv ttXKVcGDoSHcq44BZG1V9oU3ZLPepP+FGpdut8BfJ6w/pxsGx22XzCjb6sDBps78Te8sL5xGWZI iepmwiUtprKjn6Y6kYefiWnlUxIqh4GK7wsXH0FxZ9j4Ys1x7qrl1mPouNGpq+eq+Locx2jtH9E m9NyO3ec28hoDXwmM8fJAyQchhqwwL1zd24xr1CYwh9IxozHf91h15GEAHsBeD0OvWWwwesUrpI qB27yzBblV+TJPMjLMWJtWhIe6ZwnF9PxUCFZ3nISuY6ptsFK1a2Mgijkkd3L8u7jQ5UifgXjlh 9O8gCohI4XeqDz+4tJA== X-Proofpoint-GUID: rf2v5UZyRgAqAqYb5InraCi8or-S5-om X-Proofpoint-ORIG-GUID: rf2v5UZyRgAqAqYb5InraCi8or-S5-om X-Authority-Analysis: v=2.4 cv=K4IS2SWI c=1 sm=1 tr=0 ts=69fc8dc6 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=o_KNKqYLTMeQBHdYLnoA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Use freshly defined helper instead of checking the UBWC version directly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 3c1f04f12c3d..4b230868ed90 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -188,7 +188,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) if (qcom_ubwc_macrotile_mode(data)) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 - if (data->ubwc_enc_version =3D=3D UBWC_3_0) + if (qcom_ubwc_enable_amsbc(data)) value |=3D MDSS_UBWC_STATIC_UBWC_AMSBC; =20 value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B389E41C310 for ; Thu, 7 May 2026 13:04:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159052; cv=none; b=WP4qJwICUutXYmFL8/lAdGdnWcDCpXsXltMKMrl7Ai21luX1+P3sTDFYRw/sNGcodAU9cf/S1jHnqn1k0xcn8esJLl/usnyHITXhmNlQUPRPEuqiuOEr4dTnX5p2dhvMIkVKYdsqF1evgf9w2ozPKIQDVJQ3jBhQs4GSbORvZIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159052; c=relaxed/simple; bh=6/5IEPHnHjsy/MNdRL68KMLC1ruE2SNNotIn7x431DE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L8/D754LUwfsVwfBhD/WxDdcs7Tmfoy/7gGdXs0RPaqpCNwoyveG9k6fiLPXl5W5ZSlVBb+G97f+5oaoAJsTAVTM+gBLGbv2+RRpxXu8KYdv5OsAqAzxXKfuwgdVx2kfsINBWiSrpeSyopqGdC3lqlSId1OCTrHxlUIoSIPn8iY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Uq1IJy/h; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DEDkCifj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Uq1IJy/h"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DEDkCifj" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647APvca150997 for ; Thu, 7 May 2026 13:04:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E8UKyBMI9aXDerKMMuS9I2o4XUlZFnkN8S7rKi7M+vI=; b=Uq1IJy/htIJt+NQP +97RGvKvMroukDlzt519f8z+PqWkQET+cP6dWSEoY8jeVlArZ4G1orGtyCazXWrP lCc5d/EhRaLPN3eSv1tZfYWUr7hEDCEU7ji2geJz6m8WXMysyihaYYMnpNj26Ygc DrInNxh4Q+oH2GNdiFa9FTpRstwGjaqhlCg8Hdx2krprQHfYAy/IBf07kS/BO44M rJ1b0oD0TQH4LWLKjlLyxThQu/AKCaG+AP4gZjXhTr2zsY/8wDgj4lBBkpAMV7MN ROiWwRNSQtnhCbSoggSsEBtDgHZCfyopMn5kafLVQoYBFAZWGi2ClYKel2h4HlY5 Zwwgzg== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kctsw1y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:09 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7dce1e67fccso796823a34.2 for ; Thu, 07 May 2026 06:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159049; x=1778763849; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E8UKyBMI9aXDerKMMuS9I2o4XUlZFnkN8S7rKi7M+vI=; b=DEDkCifjLBbylbbOOwnqpnm9sCoLA6UrkaPwqTbwNT6jTdArtAvl1s0YT0BQ8ysoE0 9tBsDVZpMynOolVTUTUIw2m0ZraGYoR5Px/3Yh3QgCeJhjE2dzvZKFUrAfuqVX5J2fiJ +M+uPoqLKVOmd3rhmt2vZRdV0qWsvZB2ONg4FfW2Wn+a7aVzQKLXS9Af6KJYslaeCYVE RagoP3PvEy3zCc3jx5xkAdD7nK1sYfNPUEVAJZnqP4Ga2b1A6f5N3deaisWUMBS9K37z WX9z1YGn/WAp5LIVV8f7xaUzvoKZibDG4Z5QOjreOuD9wQu7Aiiu/HEvs18T3J94CcVl DTbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159049; x=1778763849; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=E8UKyBMI9aXDerKMMuS9I2o4XUlZFnkN8S7rKi7M+vI=; b=tI6i69D/+hwP58PX+2tT8Ud9O4UkujxTwHgJLBbMGFK1TZvR5NpCSkedtmfDQWjHIb GtSlSjBGRlsxTW2ZrKDdiVqP3sxz2bu++t4P5ivW91ngyS/VzZ6YXZenZSbuOVe8vF4k P+nBChkKiiBDiAvv0Ru5ySkMZzmRlNFdDGfHncs/HigeOTbGnKJScv4ZzQpxXLOpAUky Jea6qfxjZeuiC4W7nbteW1cR/N91b6lO5wLrYOKuOi0llpvARksO25CtSN4dvnHoIaQ2 h/H44QvBGbfR81b2XF7RSMI5iZQxZDaZiySHqV8p0SFa6+hctOypA0j5GWs87Z2mfcao 4jxQ== X-Forwarded-Encrypted: i=1; AFNElJ9mk2/VO6TEHZP1+Z2YiPrj8j25zEkjv/pv3DJDd589zaFX7D/LoSoaPqMUpzC/Bmo2YQ9DeStU6nAwiF0=@vger.kernel.org X-Gm-Message-State: AOJu0YzmMc+ewzbEoirq8UbTdc7ySAA+uAuDb0mrOlUwVkyCIeBFmvDF uV7RHRowIshJWBy1HFJsAQoqezAMZrnVif39aLgGgoZyaWogBeDLv6Fsj8bpoxpPU6pjiD76Ido W+DTiKjB/+ZUQN34faZOUic34xTDC0LD9JvnjLlknBxnFK0GhboRAaqWuUF6MVGFDHoc= X-Gm-Gg: AeBDieu+HyoyL1ZRbI2q5i3oOhCta0NRz6E2YSVRsHaSpaZbt6RKDtTFlX3MwH3oFti IIRhWRxG9PEY0i8KxV+oV2zcXJ2Y2DtyUnbXRJ+zpL8aMlsPMSH4rKa7QCCKvp0l/K5iiA4mO5k tYD1INY74hgelC4S8CKCY4fRxmanTe7D2ps/Yax6p14hCbIjCHvgH/Wd7xL9nhGr1NRtf320AXu hLPk9/BvCUZJ2XmSPZ1ffYAhkISco+1NaIuIxNsUCQKLmQR/tFI+Qra5eZuSw3X06V4c/CAkBi4 PtZiKernt/FK9yy288oyk8N0RTgP7ThzUs1mzu9FkWLAzNlb0TZqcaU9uY3cT7ffNu0Plb/c/3s zU9Pe9yPgMiO3uT83VKxb7prOROKq7Dpz7H9zm7BrA/2U1U2vPud9cS8Iwf4tEk183NADfenLKT t2gj9lWbQMDFMnS6U6nyWlT6QQ28smbOcaRpz7eWWhSkuDXqfMsqWHPbwA X-Received: by 2002:a05:6830:d10:b0:7dc:c43b:9599 with SMTP id 46e09a7af769-7e1dee5c2a3mr4091724a34.7.1778159048740; Thu, 07 May 2026 06:04:08 -0700 (PDT) X-Received: by 2002:a05:6830:d10:b0:7dc:c43b:9599 with SMTP id 46e09a7af769-7e1dee5c2a3mr4091665a34.7.1778159048321; Thu, 07 May 2026 06:04:08 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:05 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:17 +0300 Subject: [PATCH v4 21/29] drm/msm/dpu: drop ubwc_dec_version Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-21-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1131; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=6/5IEPHnHjsy/MNdRL68KMLC1ruE2SNNotIn7x431DE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2Hiuz6OTOj8UzEXAFUw/dmR4jvL5EtTdsnI 2df/NhAQPGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhwAKCRCLPIo+Aiko 1e/2B/wMxNYcytNhIYIBg35i5k6yugSw72+pS1wXnY/InuMscCe5nB0HcZfOLizjCtlCAq7eL7d Fy8JHAuLUS53M8E2nhjNqIByrAWWSW25IOsGW9D/SKueRMcoc2RVu8UwE4qSWZSmYIJUV/+K4mG 6m17Ww0RMjc3Lf0L3gOHW4ZGWlVzget66HXzQgiNIasg7HcVJWhrvHy5iF3Aa7NbqNrX656jG9e nyNyA0C3HSB/KSgSYu5pt0Fag6Rl5R37o33oo/DedOjgB9TDZTwDu7rrOVN7E3v/OFaua6mS/Gi eHSCbmZ4mE1iAmT5Q73vIXlmtbKlf7m8XQt+fMtYq/2oEZc0 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=XsPK/1F9 c=1 sm=1 tr=0 ts=69fc8dc9 cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=OFVxzADIxEWc22agC70A:9 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-GUID: 1JAdzjppwWLka0Vo6IoXAA-0g4om2qGj X-Proofpoint-ORIG-GUID: 1JAdzjppwWLka0Vo6IoXAA-0g4om2qGj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX1pVdp0YAtAcB W6z1KW2nTBs5aLTjewxxga88rmZD1pGmkI7rUhkScsngmFJpmIRY7gtxRRl7IAmT0FBngxRAFq0 4z1I254xFjc+qMgWjbm9zDUlC4bjYiilLsP+dgwsIyZ5Ne3z/aGiqavMaBQz8apAh2elSwR81ZA HaHD8xdn8Q04DbyjbtGzXEKYJH7vNOfJ5gQiUiXXl6aQ9jqIILpx+6FyZfBnS51HbqaTEPAWthM CqCjt+pEByBagyUGmmx4p4+lLI8xgunD7M9yOOgvb0vUiUr26tajl2lgcJrYaXKzQcsZ6V/tphY 0Te3cevdWliqBcQOlAM3k+yHtx6xMgDYt98Kb844ZM7FpsSqAiDnFvGWpkSIelNmlsmi3Tb0D8V W88hYUHL3/+t7J4JT+q4a7gk5rDkoRUXaA7EymxXdtaZO4D7ZRUJUM2vAOKR3W9NF4jUeOfEeLm HNAoxCO2KbZ2X1GKgIg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Stop using ubwc_dec_version (the version of the UBWC block in the display subsystem) for detecting the enablement of the UBWC. Use only ubwc_enc_version, the version of the UBWC which we are setting up for. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/ms= m/disp/dpu1/dpu_plane.c index 3c315d5805b8..5f42058bedbb 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -1781,8 +1781,7 @@ static bool dpu_plane_format_mod_supported(struct drm= _plane *plane, uint32_t format, uint64_t modifier) { struct dpu_kms *dpu_kms =3D _dpu_plane_get_kms(plane); - bool has_no_ubwc =3D (dpu_kms->mdss->ubwc_enc_version =3D=3D 0) && - (dpu_kms->mdss->ubwc_dec_version =3D=3D 0); + bool has_no_ubwc =3D (dpu_kms->mdss->ubwc_enc_version =3D=3D 0); =20 if (modifier =3D=3D DRM_FORMAT_MOD_LINEAR) return true; --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2769F42188F for ; Thu, 7 May 2026 13:04:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159055; cv=none; b=cW1mx8NtW3yXEmJf75ooz5Q2Xn6GMjqDRu+YNXHVR7W+CHI0EKIwh5npyT1nAx/GWwcs5Jg7cr3WC3ZD/f6p5CMf0JR17JyTiLCu7qVXkvpwfOLLVrYgsT9U5qKMythZM99sEsscOlgN16IEB3zhsn1c7drzhYXsxhe1Tvh8doE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159055; c=relaxed/simple; bh=DoG4I3IZOv3niHJgYIouUp5Khp2qZBqtf+51O62ZQvs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n3N5Qsib34/gjm4PDo7m8d3bZB2c4du0GioWIA1r6FU8GtBYWs56sPdhdbi4DvVPt09vu3+aD2niamDvkQNHEU3HPRgJPEpoux8zjR5PK4D19CbGm4UqQDieL0NbWywWw89azngNPZeucxsHqg7GZ/6sb72iJk+QS121L6Jba/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P3yj3RP3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BW/8wuwS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P3yj3RP3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BW/8wuwS" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BZ1DL3157880 for ; Thu, 7 May 2026 13:04:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 65lXVsMjORBSo8yjl1njsl0vBunig5XThYQyN3YvEAg=; b=P3yj3RP34ynowjHc KH8tQ62u6AU6lrXx0CswJJpmBkwgPkj6ZCNxOzK13o9g3tetFB7qLoq5HGDKsUaf y+xFDsHnZ/bVJ8HRrHPqtVM1cksK4WYWOZsMxzd3JY+Ypx2jFzwwvAztVTlZplmT iVhH4vLTShxCaHoOE2c9u6enMAe6ZodTCJ09TEXMU6d/8SOOech0JI+9N/BtCmrK BIuriT0jfOhd6SQyaMJ8CPBfrkSur+wFMg4W4VHqzqeXMPJEXHvNVNLQ7rBO+AyD /GlTPK7zlQykc7ptTL1pNFmdH8hkskF0rITuwJO/YGnd03ON042gyb3K1nxdTJSd QYMLNw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0mhf1n4t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:12 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b4678c6171so8285595ad.1 for ; Thu, 07 May 2026 06:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159052; x=1778763852; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=65lXVsMjORBSo8yjl1njsl0vBunig5XThYQyN3YvEAg=; b=BW/8wuwSQBBLfbptfacbAEkxqVwiIdDiYCywSsg+6urMeyY3zvPWVm5KH8PH74grq9 GNLib2CQ3qwk9eAnrWWl/YYuzhQ+/cR5NRx1fLjlfpMBe6g+y+xu4soPPN3TqJLSB5K+ iIfjtPCCshIuBYmZF1UhQ6LvPRoRoRDeI9Mm5ADxImEb7yHcptTsjG9Paa1UROzh0fGu 2W+3x6Ok4wgw84YMNUS82d93/022S9n7X+MR5tk3GcKWmmJXTGKcBdl1YmkVyDgU0QI/ fcvOJ7P30IZtKDj6YUoYPv8dP1U/MpiP7DGj7FWpfzyd+C69K7uQzkqYi3phw/VJOLxc y0KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159052; x=1778763852; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=65lXVsMjORBSo8yjl1njsl0vBunig5XThYQyN3YvEAg=; b=B5uws9L7dJiKigSPp57RKj5sVTcoN8GpLFvf+SXXvaRBbQ3Ttzp3d/kvwNWUwHjxzH FpvXovucLflEcZR5Yf7entD/i8WS3CpTPATwx1JEbikRwCQ8i2ZHquXSd7US6uIWQ03F w+t626qoG0I/7RDcdt50Fzx1T/D+i5H9SS8zlG1gWn1lJ6jow72tLoXA80W/bNk/X8bd /PU4d7HyqhW5WPIsMjhEFqIl8pX/tro8lVjhaIlhHMT0GWPWmjT+6dkXCdwhVlb+slpe aIe4FsBMScq1vFpO4CwfYE7b0AbXIxW4uv8HMKd5yg1t+1OWlXu5xH/tmsOSZexPpGhP yGdQ== X-Forwarded-Encrypted: i=1; AFNElJ9r6LwKJKj4KudzaCBUmWtq9E538Y6iYsK6qgtpQWgHl65UR6UpwOCAEyhXgwm8+GwN0Q6+rNxxtG9vf9w=@vger.kernel.org X-Gm-Message-State: AOJu0YyW6/c5yImCQnh6U0+ZWwoZj6c1TaU1WgFY8QPz+oMYXpK0i/rr K8QjRoTEZ+LJxl6hBF7mdDZ4oFU0DQyHO+YlZSKj+0FnlfhdvgS3Sv4hc9yhxHJ2FwZOLobnrAj cx4dbO3IOfRR4AnAQ/qF7Vure5WLq6OVBpUHXX0pCCtHmNi+CkpsD6zj/iQb74hnD+uY= X-Gm-Gg: AeBDievLo3V+1U92CW0I12DCPqztiN2KQ+guu4eQ95+h2+ttO+Eizep3IVKpE/8Hi/b 7/M62Zqt31SasgfV93sfsvbK48blR1dV7bklj75gJJzzlLq/+ZeCYdjJ0IzTV1fmFs0MxvDyvRs vlBq++yvDNQ0LQvJt9IlNHRqInLKC8DwuPqZ8JE6F2ZydmLBZnVgwgSmKGvlGYJ8pXrl5mrOLBX cZ22nOfEObtRmFqiP9CuC1biCzzvk5CRIX4dywwdRGP7ix3HO1tfmflJ8oy2MsA8jQzeDDKdIlx eEGdonG56XnrCBlZfzNOKlIb6rvwQqW8ICyy3QcLaYEgyQ7572Bi2HEHlcoJy0kvBZvjp3wj4hB T7774vNUMJgv/PSx4bi09uFCoJSkN+0HVa5bRcKoA3m/zp2LRgo/+BMyvkuRMg3ac1ylFBCb8ke eBaFJbRgDBQA+TF8o613cu/+qTR3cJlaiS51SYxp318zKdPg== X-Received: by 2002:a17:903:4b2b:b0:2b7:aa20:3c61 with SMTP id d9443c01a7336-2ba798bb914mr91530765ad.33.1778159051780; Thu, 07 May 2026 06:04:11 -0700 (PDT) X-Received: by 2002:a17:903:4b2b:b0:2b7:aa20:3c61 with SMTP id d9443c01a7336-2ba798bb914mr91529775ad.33.1778159051156; Thu, 07 May 2026 06:04:11 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:08 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:18 +0300 Subject: [PATCH v4 22/29] drm/msm/dpu: invert the order of UBWC checks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-22-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3192; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=DoG4I3IZOv3niHJgYIouUp5Khp2qZBqtf+51O62ZQvs=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2HUEraf80SK8FcVrFsUgTTsbMX6pEtcrmT6 84e8ALkn/qJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhwAKCRCLPIo+Aiko 1T19B/9uakUauWGXv/L+z92aCcBh59+PkV7ZXbHO7mA2eOI2XrPKOIgYB5DmL+phKbxUDbcmFjv yesFNpJGkO+31N3Zee9gWy1GYKnAUIu7rg44/flECZjoWZaYDZLnT6W21fe1qgNmIUg37XhjIoB hBgGXgP5ReYxCdaHyWBFLVQd5bLS6A6EI6TuiOh8t3OtbIApjjJMdFKwYlGubAA4WGLJegis+58 ga5YeKmLVJ01/9fZQtMfgJOoIW04Hc2GqxVtOQzHZqduHDy1viyFHgsgn0KAVGVR+ySuhoyo/Z6 cxHJ76qcjN05aXbVN7+hLlK5bwdRtvJN8RzyZTnPMaMwRhu5 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX9kE397mLjzNN oasGwJXaC6UscSYwT0BGLcbp9tqVR0wllov41foKzBiLMDauVm0f7QbHmqsZfkiaJ57CgbGrqw4 PSH4ifkB0RAdAsqsA1XhLFKlZnW1T8OD15ILE4VCVLgtGSIugNzLzw8isrfRpiblQPU2NHY4qDv S5S6TUiQlOQFvEJ8+gApU9AqkGDwlaFVcI7FiKpXJTv3EkQfKS21ZWFHJq1E9ZiC160hezXbkzJ YuYoG7g355iuI4RVzusBLBfLGgiIYwBErv5lXQZaa05ADrnZ2QgzIAnqZKwjwqyUjl570/IsFOE Q5U7Hdv55lXCXJ2OG5xknbdbxU7IvP7dvlkr6/W0XcHIsZW7HkXrxqaN6Nn3oH/MnVs79UDnrLr gJjDdxzd9UFnOvNvZyW9hVxh2KNqDJjpvoIKskX+i9NIWTkcK4g8pGA186FCUXq9WQ2cy7gE6kT O20JdlZlukn/7CSBcWQ== X-Proofpoint-ORIG-GUID: Fx7SVIpepdVyXdO9TF6-10GoGikji-mp X-Authority-Analysis: v=2.4 cv=SuagLvO0 c=1 sm=1 tr=0 ts=69fc8dcc cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=l4KHnsLLE-ungWRp-RkA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: Fx7SVIpepdVyXdO9TF6-10GoGikji-mp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Unlike other drivers, the DPU driver checks for exact UBWC version, making it hard to add minor versions if necessary. Invert the order of UBWC checks, letting the DPU driver handle new minors transparently. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 36 ++++++++++++++-----------= ---- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6089a58074ac..b5e50fc1916f 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -310,35 +310,35 @@ void dpu_hw_setup_format_impl(struct dpu_sw_pipe *pip= e, const struct msm_format =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; - u32 ctrl_val; + u32 ctrl_val =3D 0; =20 if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; src_format |=3D (fmt->fetch_mode & 3) << 30; /*FRAME_FORMAT */ =20 - if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { + if (ctx->ubwc->ubwc_enc_version > UBWC_6_0) { + DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_vers= ion); + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_5_0) { + if (!MSM_FORMAT_IS_YUV(fmt)) { + ctrl_val =3D BIT(30); + if (!MSM_FORMAT_IS_DX(fmt)) /* and not FP16, but it's unsupported */ + ctrl_val |=3D BIT(31); + } + /* SDE also sets bits for lossy formats, but we don't support them yet = */ + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_4_0) { + ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_3_0) { + ctrl_val =3D BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_2_0) { + fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; + ctrl_val =3D fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; ctrl_val =3D fast_clear | (qcom_ubwc_swizzle(ctx->ubwc) & UBWC_SWIZZLE_ENABLE_LVL1) | BIT(8) | (hbb << 4); - } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { - fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - ctrl_val =3D fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); - } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { - ctrl_val =3D BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); - } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { - ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); - } else if (ctx->ubwc->ubwc_enc_version <=3D UBWC_6_0) { - if (MSM_FORMAT_IS_YUV(fmt)) - ctrl_val =3D 0; - else if (MSM_FORMAT_IS_DX(fmt)) /* or FP16, but it's unsupported */ - ctrl_val =3D BIT(30); - else - ctrl_val =3D BIT(30) | BIT(31); - /* SDE also sets bits for lossy formats, but we don't support them yet = */ } else { DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_vers= ion); - ctrl_val =3D 0; } =20 DPU_REG_WRITE(c, ubwc_ctrl_off, ctrl_val); --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B3E4421EEA for ; Thu, 7 May 2026 13:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159057; cv=none; b=Q87uc0d4KS3IBfuLiQCnOqKGYV3FbVUKT8bPlbROzhnDGF9NXxRGOC1JgTpIyQG8T/WeDBu3qvOaYa2pmGFwkITFAU2HA7SwTNEGCyH/iPD1enmQCF0jI1yIQC7L2q8KWY49j8nKshzGC3qtfL3zGvL/GLavQBK3dLNmiiLNBCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159057; c=relaxed/simple; bh=Nxn0ECja9MOevPIO6hY4R3LL49hKUqZQoSFEB/QFA80=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NRrC1g6jxriJT6mCf0ndbInwCHnX2U81P1mx2UCXld5C9a889u3X63YtPE1PVmRFd2AmvdHTlDZY34WjA1FdJDbKHem9bMKJeRYJ3nlzSKaAo8cHPnMGk+xpRuwtE2J+/79tLF/prqxTYL/f+7jqPEcoZNHxjYRtapLPz7irVnM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZG+WGyRq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hUfUswVZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZG+WGyRq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hUfUswVZ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BWfAR3924321 for ; Thu, 7 May 2026 13:04:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HGml7biXVVWjOOR6Y1Gdb7Ld32RnBgrsNfRj6o0i/eM=; b=ZG+WGyRqHDvOsl96 oAjPaXEzqoZrWjrQ7lUrLNR1vY2jdt/gUHiYAEadYdgJVY+6QUb+YwL28jIt0cAv BZuv6bqXUhPBtmMKQGY9mqhO0S8RT58N6jL6V1wx3CjKieCO2nv+qqRVjrp9RcRA 732AaqfsT9iRFvMKV8EdyWESJVrAanxURFgFs8iudMsj5Kcmi8JR/b1Kum8kQjyG egWR08CE/gEcbDr38PpKMcvkvHtDTf6YUo8EFvvlYgx29/xKj5xGU7JIauWp4+mO zW0vizXlc+U5BTVCkh9dY9uc3AeSeVaj9h2+5Xi+Q2kQ7oPvPWMHzLBQA/urT1l4 IWB8xA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0c88b5k1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:15 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ba115ab6bbso8421845ad.3 for ; Thu, 07 May 2026 06:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159054; x=1778763854; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HGml7biXVVWjOOR6Y1Gdb7Ld32RnBgrsNfRj6o0i/eM=; b=hUfUswVZYG/EK9R9BTGAZCGZ3+o2Lp3wdT1v9ju9pCZ4/KTpc2/HpkZVRzFahgOPMs ak0i5MPSl3kwHhYDrlbVTpuBcJx1bkmph/6A8URXoDdvDHPdcR0D8Uj611BERjsp+v1G 414JFvWD3mmTGaeQsTAO92+l5bfNdr6XnlAoNOztFW5JlHcnlhcL4Hp3UEjuENKypUYF iXIwsI7h7Y6ohKrubGNZUxyuQllxnItQKP728L8a7YjGQzDd3VA/D2cOYu1p44CV83fU ybovX1ZwcL7bM3sG83nNQYcZD4ddfT+i0dLpjsOEx1thOKqnL7f1BT7pHvUGC4pnHTiK /JRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159054; x=1778763854; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HGml7biXVVWjOOR6Y1Gdb7Ld32RnBgrsNfRj6o0i/eM=; b=gdFo+NBhjkK3HCUcBB86phE9JbkWGb0uqMuO3dJ9wg3HX5lEMsz/INVMgwT3hkG3VV 93jjEhRiaT/95og9IWRdenp4glBtLCmMjJoKWmXHoeWznOmNFhMPe39NfKnHjK4OBcfe aGFXFBpBsztWw3mnBOp86Cf7577XJH17xcmyXVfurqRwVoT2ETRIRbQXJYUzZm8zAl0S y/V2+JezNUyFh84ZrBVrthogzSvgTS4PniYaPr4mKU02m6586FWWGroZaE/Ao+4sngJ4 5TmNiP2WwAAJhSP8KDzcce0mFcOKF8f591TEPGSX0X2wcZy9TRZ3Rs0dAdBqn6tUfQb0 rwWg== X-Forwarded-Encrypted: i=1; AFNElJ+m+8ap+stw77t+/6tVk0emYVn9w7Miy1qHC1iyX51tBl9pd4p60YLsjg4JUPe47G6TA5TPPbNSGlekd/k=@vger.kernel.org X-Gm-Message-State: AOJu0YxEvqogJ/djP+IV3cYTj2k6LT0aX/DlsYhQhjjsuFygWeJdyKHM bwpqHK1BC+qWt14DI8XpYt2j39qrq/PN2be3/WR9j990CB14eK5+Eef3xDmUN8CK7WMf3Mf/8vu lDEXlC/2oZRzXhSwk6Tl33+lm0nROHnZUO/XdgnNnOim+vwb2FdojpefGcS33kA1b6Ic= X-Gm-Gg: AeBDietSokJZ6xqS1FE+9Yacs0I1QBDjs6TKdSnqEFtwrgCQ4sAOixmpuGRXJj05YiY KXuwipo59mGs/8bAuB5yEcVSD/h9RtORE5ViMAo/5HeRlq8DYfiDRvtsEkbkx4GLCcHBdlawXRX kXIm2nD23HMH2qrpwbQbgBDIR71FFtnsvohEApDGEOEIpnepT48qmZXLNgMxIM9iQrGAOLydvz7 iIPjybew4fRytS8o0diaO1YnHY64XbskWAomja/6e/9OlSXQMgZBfQwNQ3x84LTfszqbmIWlrFd kDG0nJGdbOJtHudceOEE9P+7FPAfNpP2KBpAQ4uX75uRlpTZbPKAcvci5c6FJTqo2o2CbDTVV1k Tesak0+F2XX6sLahW3/3hxWpqicd9F0BfcoYMJgm7CTbNMIhDVLXVp6IPDLw/rdKsAxCiBvjOIm f1gTiWMX4dwq92fm6WWTgt2JI14FioC8aVaf0uTU6Q4Paopg== X-Received: by 2002:a17:902:db12:b0:2b4:5cea:f619 with SMTP id d9443c01a7336-2ba79c10b84mr86598525ad.22.1778159054228; Thu, 07 May 2026 06:04:14 -0700 (PDT) X-Received: by 2002:a17:902:db12:b0:2b4:5cea:f619 with SMTP id d9443c01a7336-2ba79c10b84mr86597625ad.22.1778159053511; Thu, 07 May 2026 06:04:13 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:11 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:19 +0300 Subject: [PATCH v4 23/29] soc: qcom: ubwc: set min_acc length to 64 for all UBWC 1.0 targets Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-23-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1469; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Nxn0ECja9MOevPIO6hY4R3LL49hKUqZQoSFEB/QFA80=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2HBa1QLkqifwL/HBfz5x5nw7s2kRgdvsGq/ Fnr28Pz042JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhwAKCRCLPIo+Aiko 1XqyB/9dxAVdmuGnKS9oEtRY58nIh2ICpjHSxdwoEWDJ8ahzt2MX+4+9PZg1bwDw8VRYOpfJUZf 8uWOOIJy3XlHhyCrZt47Y9EWT7mGQ641L7+/Byu9drnE6Yca87Mrj2bft4ysOeVSBqSDzuKFeW+ sFW9KPECm/JGnYNxYXiYvOQlYgG/NzKpAQpnaHSjcAJmL8UEZayqaSHusWAAjdR5oizbRe2y5dm MQ8g+knty/WWrjGvdXDMo30W8hQjk91GswrbDfHxRiy92NzlTKYH6L4oZN0x4j/5CUTyb0Qs7Mg OJUxhtcRDFP6huwS49k0dX24NYlj5f0EeXkb0R+hifNUGdKA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: WjBNErSYHKPhgfwF935k2PihW_IoYijH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX+k9A48k2TP+O n1UUj2DMPxf2vejuVtAwMPK/DM5b/Qgbp1l5aiGPwi2GNUu9jcAa6j0SoKUFjGAQd2TYJ7bidjM XbPCwl6pNPALAeevH4lx1/qBMr/6AxA8E4EaScLlKKmLT7jjRlbhRrtyT3d7jrvgioLmWOw34W0 pB15x5s0v4caGeI7r9UhyOeZl+AQ7RnWfg00Aw9zDmqEJaJnWfkpuqBmDvY93XkpjAwezzvftqc nmtlvPQnwsysj4DpV8z5+GUaeAZTlkq5vr25CjRbBL998lJGcDWgM0Wrq2YJLzpB0niYDOoqfek liAg7sLkzCtVGVMDL1hmE4g1W6oAODDtLnfqaA4NfIfYBFFVVxDmsmvTWjd444RA9DlG2JiZsRj GINQ1skZ/u/OqlUufcZuDK3vacMQeW/YeyrtTDwf4eaPBXdktuvbq2CnaRXQKXRDiqvmN8FeoaV 6jAnT3Y65M2A/i7Qy4Q== X-Proofpoint-GUID: WjBNErSYHKPhgfwF935k2PihW_IoYijH X-Authority-Analysis: v=2.4 cv=X8Zi7mTe c=1 sm=1 tr=0 ts=69fc8dcf cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=5ZsywSmvcCt_NWGkcqUA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 According to the documentation, the MAL should be set for all UBWC 1.0 targets, no matter what is the version of the UBWC decoders are present on the device. The helper comes from DPU / GPU world, where there was no separate bit to control MAL before UBWC 2.0. As the helper is now being used by other drivers too, correct the helper to return the correct MAL value (Iris doesn't support UBWC 1.0 devices for now, so there is no changes of the behaviour). Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- include/linux/soc/qcom/ubwc.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 83d2c2a7116c..0b5aa9d0343b 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -75,14 +75,9 @@ static inline bool qcom_ubwc_get_ubwc_mode(const struct = qcom_ubwc_cfg_data *cfg) return ret; } =20 -/* - * This is the best guess, based on the MDSS driver, which worked so far. - */ static inline bool qcom_ubwc_min_acc_length_64b(const struct qcom_ubwc_cfg= _data *cfg) { - return cfg->ubwc_enc_version =3D=3D UBWC_1_0 && - (cfg->ubwc_dec_version =3D=3D UBWC_2_0 || - cfg->ubwc_dec_version =3D=3D UBWC_3_0); + return cfg->ubwc_enc_version =3D=3D UBWC_1_0; } =20 static inline bool qcom_ubwc_macrotile_mode(const struct qcom_ubwc_cfg_dat= a *cfg) --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21C8942316B for ; Thu, 7 May 2026 13:04:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159060; cv=none; b=ZOhzIjXhv7AJnms0q7wNhFFCTOz7bQVWPvoUOvC9fxX1fpXdoJ95Zl32ZOYV21d1BcBcohdON+tZ1tpBXXRuGOHx0P5Jr/eH66I16rF5qOZyV8uFMI9D/6fEOSVDux0fIKPd1+3aJHTwefEo8kHZNuOiDsdt5tdir6dcyyvD+Ko= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159060; c=relaxed/simple; bh=GaD3OADWseoOG5QeHpQmN/nkA6MzTACq4ooKbr03Zf4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l7aQ28XZ34Mdt3B/FMuN+F4UME5haG1XlT/oJkZjeskaiv9mFeARJCp7236TRiUHlYfAii5EkxWjTG1OrNEv5JAmsKMv/6Leh7LFNAX+ZK0aYzBH8Gm+xRWufY1YPJIMqaLr4oizyMMtMpibKaHbf18n9XAgsIKTt07w9IKHk6U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Uu9ocJ91; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L3dWd8W9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Uu9ocJ91"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L3dWd8W9" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647ArIbc880238 for ; Thu, 7 May 2026 13:04:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VGf89U6GYhkUCRMDjtnMSMgOlYsB5OBRKvGiOBHGpas=; b=Uu9ocJ91PN6+Ozbd QYQWijujKMLLrMBH9dh58k5kjc+EQxyjz2I7aSfPYuHpumm4KAMruALesF0GX6Dr fOA19pK6BLvR8ouykNMQJm1GjtgtVQuq+NwHYS/MemqHVBDXxlHzDRYdRPIkoj1t 82N4YR7yL0+yIKDMgOdPj15ysp9eTfLe/g+HPRQdmuP+7iz0gx4hxjRmtCWHroG6 PJXzMAD+PBvSRFwtZrq2q9Aa5Mf3lo+grCIbouFoK+K0lnV0ARi9YYd5Hf8iqika permiJt253sT0FVV1YDXuWXyc4qxeVmte5Cdwgp+XbBzVelws7B5G5GBhmTz+/OY u67n7Q== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kdq1vex-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:17 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2adef9d486bso8855815ad.2 for ; Thu, 07 May 2026 06:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159057; x=1778763857; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VGf89U6GYhkUCRMDjtnMSMgOlYsB5OBRKvGiOBHGpas=; b=L3dWd8W9IVXU1iskrL7tEIV6AHjdXW5xUigxEAc/biI3JMzjHddo+whvtY3woijv/b zm6WQHeF+umIFrVcncIblSL6ixoBXsEAs9yB6ztIH3doWMmJ/9BX83mHtyjMkAkwGb3O xY4h/gEZth6gu6/EeU7ZQvTnOlY8fdXfmtERWc2sD+0+P+VFb36L77xJ1DrYDuQ6ySqQ FLcb6lbxIPQAyhBKppH+OhtWTliaY8ccRCbS3iT5QZ+98c3yv2eKqOi9ilwl+AQb0gG+ 9TZDsza9Wc9ttoaCoGLX1xdRoQeuqFdbDsw8j/JCF4ejDHjIQSTXXTQ7v5KHbcG/g3+I 7zdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159057; x=1778763857; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VGf89U6GYhkUCRMDjtnMSMgOlYsB5OBRKvGiOBHGpas=; b=LoWxO1OOf5/sO7FwvPqY/b6EOLotVtz/KuABbjjOgBvz5r5HBZLpvxnBsNMjd+3Eel XVNEW+4LHQLpkBf5LGhmdlTver83gbgO+b/zma8MCX68L1tUCHUTMF4chBH71XhmYUVX BS2MXkFxDVcWz4Q4ffWiRIer/lBktD9fIfNFuBE0SE5jfDscjYqQ03/kWyAuqmFzllQk l7FOICUimYyo+NxNty8VD15spRWbh8umn3eiEP/tdG4XCDg3/Dk1j3uRnfIM2r6YYf0L I14KL5TtQd8m2yJhth0nSIQtp6mGPQo1F5iXm7C5NBZCEjI/4ckeNi9JiMWMrSCbj03z R+fA== X-Forwarded-Encrypted: i=1; AFNElJ8cjx+gANNBcCl3ENpQCisp6B8zoOU44sq44S/m5Y/msQsLnFBO/dLKYQW40H2RVPk+cbu9vWnBqjy25os=@vger.kernel.org X-Gm-Message-State: AOJu0YyqcliKw+gUAyEdLUoVYC14BA43Hi31nEQPpq3p+KGf8RULrpF9 KYBdr7w60bD4sMKXhs5lgkyOx5E+OBTK/RNDhf0S/z4JdspmaOiiZueq0BnEQanoJtI4JJwxHjX FAQG5BZy1L5joX4wwmfIFiQ16Bhf0q3XLlJG0ztm7d5DpRJ/DDHFgShBDaJgQt1XpO6A= X-Gm-Gg: AeBDietApVXDr1jxmmZ3OkFrdJBBrUjVXryRpFE2E82yVsIbuwz96rDDWTjrwmngBpo VPzjyjbaxXOphAzSG/UVOJMohRhjlxtjD8JmcSCYO3L87CRzPQ2i8CWjy6XIA/aO49fz4Z0oQod /2daFt2rS3Lda8OzgAuZMq4HJWMM6UByFckKnBvMJyPmcvJJnY4AgwbQ60Cp4d+TeUtTWBQwwyw EIQ8Y8//apYd5HKevpTM+bQgEljrh8cR8TfKJFkrrrlXa5XBhO+z97lQhzpYofIwWYZourEpXm3 YqAsk6NMg8ARHTQzivTi4L1q8BhdKyu3vgfThpfhUI3Dp8SqTwsaTZ+Vugzyt00vIDn0yNrCsyN yWvLzHfkx8xfCUHbxyiy6qxEbBSMJd/ER4TXcdwpeduBGZQYSz9q9xQ/OwqQLFdyyJjPwRwQjjl JrKLQaXzTheiQ60U3rZd6PsFGl2grWTIHkPlsVw+dDeAfyDw== X-Received: by 2002:a17:903:bd1:b0:2ba:f5f:14f8 with SMTP id d9443c01a7336-2ba798b1bf1mr57238305ad.39.1778159056560; Thu, 07 May 2026 06:04:16 -0700 (PDT) X-Received: by 2002:a17:903:bd1:b0:2ba:f5f:14f8 with SMTP id d9443c01a7336-2ba798b1bf1mr57237485ad.39.1778159055766; Thu, 07 May 2026 06:04:15 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:14 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:20 +0300 Subject: [PATCH v4 24/29] soc: qcom: ubwc: drop ubwc_dec_version Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-24-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=8355; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=GaD3OADWseoOG5QeHpQmN/nkA6MzTACq4ooKbr03Zf4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2Hd2+yAAyg07S8UgV+8frAvzxAxCrxv7Ogb Bbze9as/SOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNhwAKCRCLPIo+Aiko 1XPcB/4qUiMOO0DqP5nQOqKItSdkd3L3mhTkDj6UD0Hf5V5jhHp9UtBJ4y4CrBkaBWyym2JixZZ grEfbo4YNDymDdbFLHCaYPge7wlp+zRDLoXMiGH9xg7kDsSM6zqk0l4bwApCMJS61H46ETjU+tW mZDALXozy8Gha+uqOKMDqoyzJ6ZMnk48AIIs4/XewFQHjLzpcR3Rnb8+fEbJ/unMujwgLHRvA7y i75P5ZxJ0xnPyGJnnH98g2P35EKTOL7NbznQhjPFiJTQMVV2zUvQtcl5afJYsCTxNg8atILPqOz HsVoW+QNYBmPegO1oY0cKcuMYy+5P3W384jvEk5R6kyx/57F X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=P6IKQCAu c=1 sm=1 tr=0 ts=69fc8dd1 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=BpkRCZfudPv80oEIFw4A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: NxMdpsLTZ8B2zCuUqvS5PSf0yazJFVyF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX81yXQMI0TkKx n6r9rolAji4Z2y5ACyCw6pRGk+7rg2aasgHpu+KiQrT5Ws0O84OMdNVLbEcMge6jgiymZZrPQwW b633QhWiLgaoJEmIODOMxHrvhs+SZPUQYhJgWuIjK9PtSiaiKk2EzfwVyxNFVggHLWSQz16C7Ku UjRgS40eqyHk3y8JbZ1s/JIRBb4HjcaX04BwMGXYOoAUWeiuxSnn8rEEHHT5foKuVj3+PJAg6re 0E0D4s9rDclpH6b2x9J9Vt2d+XlC2wFv75PpBDS4NWElz3/+UNKVE6bWoo4eCwFNA7CzT9m51Yt 96cROF7n9QpW9mSliGkLp+4XbVjZ5gRnXmrEB0iTdLnD5BA+ne43Ii7eUQWscdHik9ubAKZZsPa HsCAzK1R67Zvo+SBgMv77JRyjzpMHryjG0aB7uputvIa2pf+v1s/6pyTmFxI/xaRxasrXz5rcCg KUGcovgcjj7NsG082kw== X-Proofpoint-GUID: NxMdpsLTZ8B2zCuUqvS5PSf0yazJFVyF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 The ubwc_dec_version field has been inherited from the MDSS driver and it is equal to the version of the UBWC decoder in the display block only. Other IP Cores can have different UBWC decoders and so the version would vary between blocks. As the value is no longer used as is not relevant to other UBWC database consumers, drop it from the UBWC database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 23 ----------------------- include/linux/soc/qcom/ubwc.h | 2 -- 2 files changed, 25 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 3fe47d8f0f63..1344cda0fb75 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -18,7 +18,6 @@ static const struct qcom_ubwc_cfg_data no_ubwc_data =3D { =20 static const struct qcom_ubwc_cfg_data eliza_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_dec_version =3D UBWC_5_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -29,7 +28,6 @@ static const struct qcom_ubwc_cfg_data eliza_data =3D { =20 static const struct qcom_ubwc_cfg_data kaanapali_data =3D { .ubwc_enc_version =3D UBWC_6_0, - .ubwc_dec_version =3D UBWC_6_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -39,7 +37,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { =20 static const struct qcom_ubwc_cfg_data msm8937_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_1_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -48,7 +45,6 @@ static const struct qcom_ubwc_cfg_data msm8937_data =3D { =20 static const struct qcom_ubwc_cfg_data msm8998_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_1_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -62,7 +58,6 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { =20 static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, @@ -71,7 +66,6 @@ static const struct qcom_ubwc_cfg_data sa8775p_data =3D { =20 static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ - .ubwc_dec_version =3D UBWC_4_3, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -81,7 +75,6 @@ static const struct qcom_ubwc_cfg_data sar2130p_data =3D { =20 static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -90,7 +83,6 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { =20 static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -100,7 +92,6 @@ static const struct qcom_ubwc_cfg_data sc7280_data =3D { =20 static const struct qcom_ubwc_cfg_data sc8180x_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_dec_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, @@ -109,7 +100,6 @@ static const struct qcom_ubwc_cfg_data sc8180x_data =3D= { =20 static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -119,7 +109,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data = =3D { =20 static const struct qcom_ubwc_cfg_data sdm670_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, @@ -127,7 +116,6 @@ static const struct qcom_ubwc_cfg_data sdm670_data =3D { =20 static const struct qcom_ubwc_cfg_data sdm845_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, @@ -135,7 +123,6 @@ static const struct qcom_ubwc_cfg_data sdm845_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -145,7 +132,6 @@ static const struct qcom_ubwc_cfg_data sm6115_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6125_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -154,7 +140,6 @@ static const struct qcom_ubwc_cfg_data sm6125_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, @@ -162,7 +147,6 @@ static const struct qcom_ubwc_cfg_data sm6150_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -171,7 +155,6 @@ static const struct qcom_ubwc_cfg_data sm6350_data =3D { =20 static const struct qcom_ubwc_cfg_data sm7150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, @@ -179,7 +162,6 @@ static const struct qcom_ubwc_cfg_data sm7150_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8150_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_dec_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, @@ -187,7 +169,6 @@ static const struct qcom_ubwc_cfg_data sm8150_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -198,7 +179,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -209,7 +189,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_3, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -220,7 +199,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_dec_version =3D UBWC_5_0, .ubwc_swizzle =3D 6, .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ @@ -230,7 +208,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_dec_version =3D UBWC_5_0, .ubwc_swizzle =3D 0, .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 0b5aa9d0343b..c3f9efae5db8 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -13,8 +13,6 @@ =20 struct qcom_ubwc_cfg_data { u32 ubwc_enc_version; - /* Can be read from MDSS_BASE + 0x58 */ - u32 ubwc_dec_version; =20 /** * @ubwc_swizzle: Whether to enable level 1, 2 & 3 bank swizzling. --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D980B423A8F for ; Thu, 7 May 2026 13:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159065; cv=none; b=uCh0qXMWeoSFKtUR4ZA2ba3d8sSN+tEMRwBP0lJ2R9OzTgpdBn33BBpZCUWKypGLsRaB4zrjE8fm5ttd7k3gr6VNkrenuzrB77BLb36nzbCwZ+lRCvspxc+LUi8B00DRGSXjvX0c1DNdhv6gJAyMssoNjGWy8IuBxF+MyonrAL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159065; c=relaxed/simple; bh=ELfSfo30Xq2szDKMHs49lszh5EmDwoOzMcxayrSn7iI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lGV8P3dnANTFZ2R0m5lsT/5aAEBlGveLfqWh+7d2GgN/yttn/gNiskiRXkgLD/WT/iWrQZ4ZZdzmAoN5po3FMXOd5/rkUc/O9UICV6gKZlxiOsYMhOnmWfpUd3kkIdZSIAiP3P/ajstCjRFHEMmR14CzmqdDzkj6JEBxYqnORUE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UAiAfS7A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JTUGietD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UAiAfS7A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JTUGietD" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BWfAS3924321 for ; Thu, 7 May 2026 13:04:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6pPTtabF6OA9v/5Dtpi3YOgqhDzAT72mJRYat9rS4JA=; b=UAiAfS7AXSl9KxLy vEUpzbidgXolvBSGbVAVDiMUcywD7E8g/xelkhGobn7UC4zFD2wegrHfxtZe2Ax2 mrE7RU6Vqn/cnr8y2lDingpzlh0Li9qzaUsGaDZN+wwX3bvsueKpnuRpeQnlHmKq 8oTDKZgM4J+dfacJMFeQRYhVFwgCzxczhtug/FKD9VtD3Ox06Y6Xn1dOg6VIuZmZ z0UFNkotPAVfD5zyAUWadBfH4+whx+6kO2DedAmr+0pKz5BWduhCGiKO0O0WQggp 2qPAyXkHUMkR/fRTcg2WptOgHI35SiE8dPIj0JRcNTce5l8od3pSZzvWtlhdTDtT iiKDIA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0c88b5kf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:20 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b461b36990so10439495ad.3 for ; Thu, 07 May 2026 06:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159060; x=1778763860; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6pPTtabF6OA9v/5Dtpi3YOgqhDzAT72mJRYat9rS4JA=; b=JTUGietDSq3QsBjK7l6NAn8IJfaDgoLlV5AuFunkT9auMTaoeLyLAFlDmyDVeUz6gW s6sZ6seU7YQA7pl5MU3+RhxaqqibmZI2ys6KFaAL548oC39pNn3XosH4+Dj+lFMsDD7H F6sjIqSL1d3/fQlqxtOMSl5k0AFes11OSAlAPazjiIaMpXfQaNPAYLxxEhlMljwau+Ii yP7uhhlSa5yoiw99fiVS7/vLul7qQEAIbCAAYJ1Y+i3+hDRKQbvCelK3m/o9Sz5t7nZ9 6+IeKd26XC9sDc9but7+0V9lffHoHc+yxkfKK8BLohGcRlV3lsF1LMpCBhsgcJwV9NfV 6tkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159060; x=1778763860; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6pPTtabF6OA9v/5Dtpi3YOgqhDzAT72mJRYat9rS4JA=; b=FIHa3S8klguloIgWG0+ppTDFUklvCM/vfvHzGv/OxphtLQigHh6uFyi56ACIMwqTDg avj5FPsZ8LnncfHGaoU1lMMAdD591GfWlbuLZrKHnUmFW5iUDU545Z5BFd3veXVB9OEj 2TaYp4Mdh1gbuCoij1YzQOU6HGuwNmDRyD9LZu5JZqbbCMDi32x5Xg3xeQB+LTvxNHt6 S6fzYdX9VVCpc1wN/wi1x5ARLkOdN8Kccd8rf6ky3R6CcdZKQAvfPIPA83+QGL4iRq5R vfs2Dvnt+eB3QCddIbvhIpwLpMdx1rkUJAzcGfieZ+tf2I++lRyLdYRMOP7U84B2IWVA OHng== X-Forwarded-Encrypted: i=1; AFNElJ8m0XSVIABvX2+5zuKQZ3co5GoeaBxHqTHb9rZMZH3JrbB6YOp4WiV9RJm6djJUkNaxQGuFXsNsGNiQu8I=@vger.kernel.org X-Gm-Message-State: AOJu0YxWW99lRXPVbv/iABiQ2Da7pokrTRBrv1MxP4SmOxgNMXNILDUu +LPLEEq88zuv0jEOQLSDcYUYs6FRquFoqnNXrlQvUmwc8fd44acK6ksM6Bs2thV2CgShesoOjke aivSEdtlLghYgEHYm/tjtD4t2x2fm1mI9F2v+eGAzP3HaIXUadfhu4AeIykpVKR87CfM= X-Gm-Gg: AeBDiet1B12SyReAr6jsdP6xpsR+zrf0AVjnuEjhCvskU7g7PATGcnTqBdyvCSFW5JZ N9sOmNGt7VjolAVABw6R/bWF2AZn/kCbgzPEuHcwU2pxEksQlx2iGioMRGfa3Nqtbt2QUdysmxu zs4SQgDYpeRzR1rWHMW9mRTaE8ifaPOSBUSabAL22a13VZkfMiImizFxu+qB1rR6j0F/Y/m33Y4 l5Sbep4wg+IZQq4Mef5BVoUl1dOqWb3u9u+FMEHXI/P/rf3Vpz3O8oOFeHpj789HNmUE7XTzBzX KUMli+9IhIbwDRkhfCjfpntuiXRXCmO2De2WiL2bFSB2jzRpPSx4WE038RMUEjxU8PD+V2DGTc7 RR69B2vZUSg6frsNPw/DLFJA6YXaM6kYdHAT0DbuDsJAgO9z36ZfWTSCJ+DlQOU9roM+SmqxhC2 q+hxoZQXzJcZMx10/W2fTNBuEV3OWJPAAka2mJDE+itrwX4A== X-Received: by 2002:a17:903:390d:b0:2ba:bfb5:9b9 with SMTP id d9443c01a7336-2babfb50f3cmr24843015ad.7.1778159059630; Thu, 07 May 2026 06:04:19 -0700 (PDT) X-Received: by 2002:a17:903:390d:b0:2ba:bfb5:9b9 with SMTP id d9443c01a7336-2babfb50f3cmr24842145ad.7.1778159058842; Thu, 07 May 2026 06:04:18 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:16 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:21 +0300 Subject: [PATCH v4 25/29] soc: qcom: ubwc: drop ubwc_bank_spread Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-25-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=5607; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=ELfSfo30Xq2szDKMHs49lszh5EmDwoOzMcxayrSn7iI=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2IcTMhxTq2oUuXpm5Li7mlEyZ5Nr/PM6smi UoEdM5tyUyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNiAAKCRCLPIo+Aiko 1UKzCACMTOpnFjz+6rQTWxRwHu/yhRdR8qZNoL3cqc3zSjWRqxL6EgLacUWyQymv79MkwTKn+a2 7Mi0JH+b2XTo9wQkHQ7+7rimjiun2iAKeNQf1ez4edCbb7P8oHTfZc8kH3lmy38k0+kZWJ5vmlH EcHVZFV2+jqC1/Ne9b5fSGGfJgwYxzlDdT/iSbGPKWpgAPRebQ+G/8oLTQL4tyTNJ8l8ZKkGuHX zer9jVBe4xZ3JmtysK4QBtvCDAosCZvXvdYFgNV6C9ZTgzAvamDVerx+CZFBNq0eddTOHHfVrre SHz8zOkE/hEEPbQQsvEH3rnINZ/ic87tw/6NcQQsd9gP03ji X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: R7GLyeQTcJ7Tgfa0FGpKY1tLShPKvAre X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX4YcKqFzu21kW qKbKxedM/5VIfkHDcXxtBFvO6gdkCJQuJlDrIVYX9eehtqicJwQazUSlHUtpVpn08IudgWtW7ih o52GB1tdsLZASVmLgOoNV9x4VqY6vNr/zonB1g/x/t8jnCf8b+cLFEZUoO/7v8UYb+Dnfbo0ztU Va5i3FOaQMv0HWc9plA5NDHZIwVe5opscvSRPsaAdM3hi7xwCx2rNapPo5IKzEbli9kWlFmIcoF Ok1kpS9XYtb8QXgPFDJ147Grmy7mYNdfGzc+Ahr4D7ewf7wAXjcoccY/WPxs6ZEf0d/ebPLA3We 2oRRw3mzchYHcptyN6fppHkRdCo7m7qqZ8p2GzKlt3iECl1YnV5A5OhSK/7XrRntjl0gGufKkKV zy2GJ1U8bTL597Z+nPQjsmsm626Y1Kl4BtQkxwoq/Nt7fX/HB2o3WVNkG+YZsyu4rsGLMTrcxFR lbyhUJPveQelZwMVJBQ== X-Proofpoint-GUID: R7GLyeQTcJ7Tgfa0FGpKY1tLShPKvAre X-Authority-Analysis: v=2.4 cv=X8Zi7mTe c=1 sm=1 tr=0 ts=69fc8dd4 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=VGmcmSc_WkMUHOMtpCQA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 According to the documentation, UBWC bank spreading should be enabled for all targets. It's just not all targets have separate bit to control it. Drop the bit from the database and make the helper always return true. If we need to change it later, the helper can be adjusted according to the programming guides. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 14 -------------- include/linux/soc/qcom/ubwc.h | 3 +-- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 1344cda0fb75..35cde4e9a238 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -20,7 +20,6 @@ static const struct qcom_ubwc_cfg_data eliza_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 14 for LP_DDR4 */ .highest_bank_bit =3D 15, .macrotile_mode =3D true, @@ -30,7 +29,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { .ubwc_enc_version =3D UBWC_6_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -59,7 +57,6 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -68,7 +65,6 @@ static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -77,7 +73,6 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -85,7 +80,6 @@ static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, .macrotile_mode =3D true, }; @@ -102,7 +96,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D= { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -126,7 +119,6 @@ static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -149,7 +141,6 @@ static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -171,7 +162,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -181,7 +171,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -191,7 +180,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -200,7 +188,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 6, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -209,7 +196,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 0, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index c3f9efae5db8..254721f5ea3c 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -33,7 +33,6 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; - bool ubwc_bank_spread; =20 /** * @macrotile_mode: Macrotile Mode @@ -85,7 +84,7 @@ static inline bool qcom_ubwc_macrotile_mode(const struct = qcom_ubwc_cfg_data *cfg =20 static inline bool qcom_ubwc_bank_spread(const struct qcom_ubwc_cfg_data *= cfg) { - return cfg->ubwc_bank_spread; + return true; } =20 static inline u32 qcom_ubwc_swizzle(const struct qcom_ubwc_cfg_data *cfg) --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE78D423A90 for ; Thu, 7 May 2026 13:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159066; cv=none; b=YyG7AQX5y4idZbvhhisQo5SH3lqF0xl8ZM+ip8FWbY3aoqx25OFCpreBH+RgCDkNQW4CQXYT/ZMYPH4qJU5ZnAqyKm4e2d5tRMXY10m6CMA9UxG+5E1JWGzqAnW1dlJ/H000pFhHlTzq6QFJomr7hIvpWSlzMbLY8rxg9+e44yk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159066; c=relaxed/simple; bh=TQBWqrbntLsRW914iL/lLCPXeMzB5PW4D9i0dro5eT8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a98RVAFzTrw9EGnQK686d/HMDO6KKdJW9QjLwh1c++BsMIFzBjWYVmrW460Nn0hKi3IVLXgX7O96ATXtoIPaQVvpNbUCFeAfHRnsYZJCM0Zwx6SwkS/BmKH22bqrYhCtVlnVbKznU5ZfQvbFqTKwIeL+KgaQW69rUdCqB8vvu8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QIJsswsB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bqeGiPAX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QIJsswsB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bqeGiPAX" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6479pAkO026511 for ; Thu, 7 May 2026 13:04:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UU2YSeVXfhEBEmAAjyzhaY7cQ/RaczZjSEOGJBsk4fE=; b=QIJsswsBaV3cBfW/ wFS1zBHwJEBVpTasN9vDxtqYb6Fz8RjpRCvUY45wJ/Nsossf8KytS5GBbvxegyx/ 5fMtsliXxtosSV/v+OE+mToh7uyEW1WaXo6IYyE1/l6bi2+s+KLWabor7eiQ7JSM oE37hHejYb54RDBBjgof2XHmAtAAnLZqMBG6+6dC3vQGJ674vUxfU2Le00UaZ3Q8 WJtPVKjfl/o3VnN1gfjn3NO4jaY2OxtCsZ2+1+mJoosnRiP2XpO4KErm7lAzcEVq AzXpszgyj2RNaYqcQLiBXUQVC+FRaXcTsXwWO0+PDLW3vulHnhrTccGMKy2v23E9 GNh1/Q== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0k1t1ywu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:23 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b79f4b35b7so8686115ad.0 for ; Thu, 07 May 2026 06:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159063; x=1778763863; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UU2YSeVXfhEBEmAAjyzhaY7cQ/RaczZjSEOGJBsk4fE=; b=bqeGiPAX/spADEvHR7WSyP0KleTPBn0zrd0GD1bOutUaVVuQOMnqVTTkQvAQwPPTNc W18xKNZAqI3VzEYgN9lm9kCoWf0naj/AV214UOFxpZIFvdGg79/m2oNqYu5kdGXuA+eS 6BR5GAziRV/Z+Ef4cArrPDEx0lSSbg24Y2SBlieym5SdWJmhexHsuOVeDkNVSdi7CzMC 6z3qK1n4jx7sI2stk77jt2QDThdvJ9XGkBHfQULnKTRQOtUSj7Al/UhPbgtu/rg0GpAq RlX+oQo7QAwGc9PVoXs+3eOkZWKBLP+kEGe14OyUGdRauVEXQBsEmPkEQv1J//Z1BDLZ BEZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159063; x=1778763863; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UU2YSeVXfhEBEmAAjyzhaY7cQ/RaczZjSEOGJBsk4fE=; b=DA9D9BqHNo0RTZjfUMIjqMS1wSdkl5rtT/T7eF80kGeno7K6mQBXTrd2R/0IlcLMX+ zDPNMFovzu+cX10dJ8m8NAXJfrkzotLrZXJO7qO/YH54+pSW1oKfTEpH6Gd0qG/uTnT3 W5Ixun7HvDZPhd4yNYexKGaMiA/afViYeaD2mg/dQOTDuuksJqj0ry6+6y4ZXsTwNP8i 2+Ciz8xSfN6dv1qNzB6PlfHWgBy0/MAWopkRDlprdG9IOPxKOX/ueBNOgKdIo/77NNAV ZGVU5VBpiyTdYfxWJD0IWTLbZNJTRKMpjDUZiqBc80ih5n3LxfeXHdlCFgbMHWcy4fKG kmFQ== X-Forwarded-Encrypted: i=1; AFNElJ8Z+ztX0H/Q+cQ6tv1f7T6Wjy9XvTtV83Z6iv57ZmY1obUFfXCUtcgXO28p2VWcDBhfuwR07PcZWiKP3mY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhph1vQY4dNiHSC7xB4HwoviCcTqzTkLHl0P6i8nrQwGYzNCvf ksO18hp8CAf0NcDN8vugAR2mVfgGSe44/C3uQbhlDsjDVSTkw1xkMYLfviiJxT8siiHJS+WPu1a 6WZzBEJN+WkG7HBu1gzO1I06xGYT17GNNV4WxZrYFus6Aa2nFYY9HeIWUGkU5E6HghUs= X-Gm-Gg: AeBDietItuermyfSKyGjP0bPQQTv7fGhNa4IaGnaps9dHCofvR20Wmma0loFmnCRdY4 EwbqjpdgPFFhe6ILRdc/+vzs8lKTRNSPUQMAhITt6A0GBZFT2fZvEfN/kowq1juBB5i+d4OcIiG SXPkU9CrawzXl6wtklIG8Fm6TEOJodmXYvJa0DbQVdNRXcPrjaOjjmgmPAvVVe4lkEyjv9F+8Br gN3iShyC8/q54s3E+w8gOJHGCTnEm4PqKQYKdKdSwfdrtydrRq1oh4weoZ33/9KtNbm5eDJU+3T ep2WfNhUvQBDMKLfuUl/0MNKynlu0OmqTB/zxlPuBUK55NKAusIwOUcsUcHjbrQgb7TCr8H3vWv R6pSqfJ+uVFbayKYBcixw20HhBPOUvO4VLXkluq12f75N6WeYck/P6an8TV47+/Hbmfasa2IBgH 5nUg3uUZy1kyMCPIJVtwAtvhvsYV/+ee38UasrR3Nuc8YgDw== X-Received: by 2002:a17:903:28c6:b0:2b9:4eaa:7153 with SMTP id d9443c01a7336-2ba79c0b87cmr53539685ad.19.1778159062642; Thu, 07 May 2026 06:04:22 -0700 (PDT) X-Received: by 2002:a17:903:28c6:b0:2b9:4eaa:7153 with SMTP id d9443c01a7336-2ba79c0b87cmr53539355ad.19.1778159062100; Thu, 07 May 2026 06:04:22 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:19 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:22 +0300 Subject: [PATCH v4 26/29] soc: qcom: ubwc: drop macrotile_mode from the database Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-26-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=5443; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=TQBWqrbntLsRW914iL/lLCPXeMzB5PW4D9i0dro5eT8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2IKQUemAYDaPbwp1eqn8buNyK99WTaDiAH8 4q0ilCMSAmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNiAAKCRCLPIo+Aiko 1V3+B/40zgyEk7XYIfbq4254GX5YzwNV1vsUQnEbtkeRa/pkexia3wvROYWvcD6/jRxgec5nEGD yfwjI5gl//YTheq6oIpzNVT/2JXzb61Lsh6/whA1jBMMLLTHCcfQBz37iMcfCI8sn9DtBYMfXGe Omej7tZdlj/AsrJQfE0HrD69xAUH5KK6yVlfBlzqcBG7wUv47amF+M9Pn9xLtPndCwc3ys9TsKe LWMJTGnMjK6Q6RGZkTbMv06ZUGs1chhTGwFdcIU+NUSA3w69/8F3JW6cTP2qsrFpiAHfsTtbwjl Yj80EPQ8yf6h5QO7NWffBuOm5iVw9icYtnniujQWAoYcYEEx X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=EoPiaycA c=1 sm=1 tr=0 ts=69fc8dd7 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=lOjMx_-Oxa8n0LcNG1gA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: u9n8oJrhckZ3KFpiwL_q-jDfeECpe1YK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfXwYZUcbT6JmTy 8FoVhiCERbBLcTD/7I3D7ss0Rbysn6iSP3o8aFbUS3au1p69ubE4NPzRoBU3R4r4/vahThgtoWk Tfv36yEsBRZ/A3MY8xgrg9/aK5hyqpDyLo8vAWg28Sf9JvpU+u92bvx1ABdQ+0sxLc4rrZzqLFG KmGG8ctXF5ccMMN3SFLZsuDQkYiKYSzijuyZlpBWQ3hDwKCoYQBYF2hJI/prUYqxav/DPjSn40q 1Bkl8shMsKh4zwkTKgxRlzngcupMzBI8ZWRSx/t8sBbgdZIkhPTNcAfdaLR1omt31MzUfjfbwzn BEUCOtohgnLJHvjs6MbrSEteWkpdUnY0i3cxr5oC1lTwWroAyOmHnOgIwAzc3R9klnCPSSh8whS dAa17ePuz0N/6OXHZJvzFR/4+BMTHvrCgIkwmSZX3k2uUMAMgHtpASZ9kQu0R0LCY4x45XWvd3Q QlT2YisN8Hc6TT3o/Bg== X-Proofpoint-GUID: u9n8oJrhckZ3KFpiwL_q-jDfeECpe1YK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 All the users have been migrated to using qcom_ubwc_macrotile_mode() instead of reading the raw value from the config structure. Drop the field from struct qcom_ubwc_cfg_data and replace it with the calculated value. Split single UBWC_3_0 into UBWC_3_0 (no macrotile mode) and UBWC_3_1 (with macrotile mode). Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/ubwc_config.c | 16 ++-------------- include/linux/soc/qcom/ubwc.h | 18 ++++++++---------- 2 files changed, 10 insertions(+), 24 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 35cde4e9a238..b880f77f448c 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -22,7 +22,6 @@ static const struct qcom_ubwc_cfg_data eliza_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 14 for LP_DDR4 */ .highest_bank_bit =3D 15, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data kaanapali_data =3D { @@ -30,7 +29,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data msm8937_data =3D { @@ -58,15 +56,13 @@ static const struct qcom_ubwc_cfg_data sa8775p_data =3D= { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 13, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sar2130p_data =3D { - .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ + .ubwc_enc_version =3D UBWC_3_1, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 13, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sc7180_data =3D { @@ -77,11 +73,10 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { }; =20 static const struct qcom_ubwc_cfg_data sc7280_data =3D { - .ubwc_enc_version =3D UBWC_3_0, + .ubwc_enc_version =3D UBWC_3_1, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sc8180x_data =3D { @@ -89,7 +84,6 @@ static const struct qcom_ubwc_cfg_data sc8180x_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { @@ -97,7 +91,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sdm670_data =3D { @@ -164,7 +157,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sm8350_data =3D { @@ -173,7 +165,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sm8550_data =3D { @@ -182,7 +173,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sm8750_data =3D { @@ -190,7 +180,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_swizzle =3D 6, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { @@ -198,7 +187,6 @@ static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_swizzle =3D 0, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct of_device_id qcom_ubwc_configs[] __maybe_unused =3D { diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 254721f5ea3c..fee778360ac2 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -33,15 +33,6 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; - - /** - * @macrotile_mode: Macrotile Mode - * - * Whether to use 4-channel macrotiling mode or the newer - * 8-channel macrotiling mode introduced in UBWC 3.1. 0 is - * 4-channel and 1 is 8-channel. - */ - bool macrotile_mode; }; =20 #define UBWC_1_0 0x10000000 @@ -77,9 +68,16 @@ static inline bool qcom_ubwc_min_acc_length_64b(const st= ruct qcom_ubwc_cfg_data return cfg->ubwc_enc_version =3D=3D UBWC_1_0; } =20 +/* + * @qcom_ubwc_macrotile_mode: whether to use 4-channel or 8-channel macrot= iling + * + * The 8-channel macrotiling mode was introduced in UBWC 3.1. + * + * Returns: false for the 4-channel and true for 8-channel. + */ static inline bool qcom_ubwc_macrotile_mode(const struct qcom_ubwc_cfg_dat= a *cfg) { - return cfg->macrotile_mode; + return cfg->ubwc_enc_version >=3D UBWC_3_1; } =20 static inline bool qcom_ubwc_bank_spread(const struct qcom_ubwc_cfg_data *= cfg) --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 243003F787D for ; Thu, 7 May 2026 13:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159069; cv=none; b=dXfSzKepQATZhdWfL42NP89wWWi1f02szXsUy7DO6UdVzq5iqMalArIm6CkLUnGK3yjj9FvQLzlg2BlH82+nIrBgaZaqAhdvQgkadF4LbcFjJsy9O6P6qKCZ7Fl96MJrXuSiLU8WSCHZUMJK3I4b/RTr+dJ3opZdh/dJVMCfxKk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159069; c=relaxed/simple; bh=/5g4ZeJetQrIZ/OLIdACHZoyX6KSJ172mYU4QYqK3To=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bIgSMekwZUys+e+bi6SFdabR89KsQZktyhHMTvfofx2NZ680Prse6Y9oojd/YR27y2z9zacJb3ZZXTwQGsL4Gc0PM3hIeCLl2jOuR8RXC7LNpSTfOrhI2kh77jWR95o8xTLZIAm9yHc5YPL7QVKz/tjqKooAHFW1Ws/heSzaago= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KZnzAd7d; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NAwjqPVZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KZnzAd7d"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NAwjqPVZ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BTIVT682791 for ; Thu, 7 May 2026 13:04:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y4Spcrvj56zhlbuoqjcYCgamAfaIhEXR+CzRTdPPVyQ=; b=KZnzAd7dboJyvw3b QEeY/og+Gq43AuAYkG4zoKG4udQJAW3jscRuhDLimAKL78JqMRABdTDBp7ndXx4E gaM4PBeKM3FEtoLaXHz951LYHPuH9nJGX1Qg3SLmdL9TU76SyChUJ8Tbf8hYFQ4G ie8waFEUtFKK46xsbnj6JzTTtsVvJcJ/9YO8ujjwmrMpsCReZ3Q4r5caYMuKHGri cOu8qtWft8JfYQKLgaoSI116939z2qlF/FW1HzrD6onpxCtEKPXKjK9ZLmwi4frr vfHVeIyzetf1HOCiAdvZLBR7HaIeP0kfj+Z53DKc6fNdAACPYfPVbsSnX6YFORsa IktPvw== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0mhasn1q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:26 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7dca6ecdd85so987919a34.1 for ; Thu, 07 May 2026 06:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159066; x=1778763866; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Y4Spcrvj56zhlbuoqjcYCgamAfaIhEXR+CzRTdPPVyQ=; b=NAwjqPVZgys9kfYn1BKb1nftdNw/Fhn8u5frbUFiBoa85zbUyIAety+ovB5kZGGYUl zAM0vs4XWVToltLU+vvl3cF0x3lVn0L1BW4PXEdqvN0QXhzyuyFv1L/EONLZzSylwmjl /v7Ya81bu3sHvA+lFZ/Ks3HZdNpp8kbDtlj6l0eE4mk9AM6niRFqYmGq4sdVsc2uhibD 0Pzos8CXgcPcgGkE51WZnj/Za2RnVaVCJUefkr/hhLtdgvafw4T9wJILZCzVzv4Gc3We QUBfeeYTDxr94/Xa5WpEBVnl10DTKdZSp56xBt5k8fxpfTewKcbDO9lz3lHEzmovvbmf Wlwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159066; x=1778763866; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Y4Spcrvj56zhlbuoqjcYCgamAfaIhEXR+CzRTdPPVyQ=; b=bDZLa8pwIJHuSyp5dQsyL55PBDbK7XJgkwy6ujJwIEtrUvdUL/orG9QAC2grwWqqMW LAUJ1eAcSEGFOoj1d5/ooPyKpl93GvI4oIvee481+hxB9obSf6/6NS5RUf5QsY3rBRlm wmzcChUgUaw7yJsqCXGDihb/pLO9wZ5ErwqhE2gOaYv/9vjAJwDJqYGs0bL+c0fr6ois 6v/RuwzOlw0Kht2ySO82oQbIA70xUE+3wcf6qpW+iZZDS62PO81MOHt7Tmya07bUA4d0 b/Xq+lOxbDN2nsOxzXskKTOJm53ISlf0ZxCoWpBr/t5AjaOeLwzEsOwlIL6c9/VdGxTE EEpA== X-Forwarded-Encrypted: i=1; AFNElJ94mhnabYGMEN3UZS95pfa1cL+CBROx4J3COWU+vk0uKFHmabYvtGkTwA/QvukUrvR5gTx2GjS8t+h7T/8=@vger.kernel.org X-Gm-Message-State: AOJu0YxWWHV6wtAcwl9e9FTZtQCj6wwIMDmNsX55jCNhpzu1HyrNmEcz CP8KVUXq+OFeWP6RfVf7x/IQlgWHpJBCRQy3+pY57kGnjRbPElLiVGtGcLDP4qI3fCkZhAkWFpc S0nanwONS11zHMVKJvIc7S+QRIo6/9eOoNqS6Gho07udz2SAHm9cLkdfQdp3cXSmV6hA= X-Gm-Gg: AeBDietcDvrLEe+k3PkPUIai0XrmBYFDZUZBLb6o8+TTXoJKpCpWaaK5FgL1DQYpC9f +Le/ompVjVRegttZM3L2QQ6NoVQX9nTxI9iMkPF4vofvFmNbeSm4t9aKS7wlqgI61QpSALdZ7bH WftzInu2D42fbrrMrl7jj/CfdP3H9euuRKjfo2qPG2Jb/xlUsoeM7HiDEoTkYOvLvbJ2oevcK6S ugTy4Eor0K47okO6o3fjh0yBAQflgAnruA0U04ft7j9R0h/uJJ2hRo0qz+DreKw1T0lbWv0IwWJ 7tOQo1TUO/QFX8kIVQ7d31J/YfYXy0fLH4/eTMpWAb4M3yRAnx6sSlfjR51/wCCKxBwSMHDXKwl Th0GFY1pB5q+9gm55uiV3K5LX7sls582DweOLZloq6Qjkmh6HeUVZqWkpdxld3O18TSAzAVNA/5 yjK0H2pw9RPIYQbjnFVdKOVIjUqJ0VLP77bTq8SwfibcQNtw== X-Received: by 2002:a05:6830:6d15:b0:7d9:71e7:abe5 with SMTP id 46e09a7af769-7e1dee9096amr4806014a34.10.1778159065540; Thu, 07 May 2026 06:04:25 -0700 (PDT) X-Received: by 2002:a05:6830:6d15:b0:7d9:71e7:abe5 with SMTP id 46e09a7af769-7e1dee9096amr4805946a34.10.1778159064857; Thu, 07 May 2026 06:04:24 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:22 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:23 +0300 Subject: [PATCH v4 27/29] soc: qcom: ubwc: use fixed values for UBWC swizzle for UBWC < 4.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-27-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=6082; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=/5g4ZeJetQrIZ/OLIdACHZoyX6KSJ172mYU4QYqK3To=; b=owEBbAGT/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2I84EjPL05HMIn4nKfUOTI20skhdFu77lwU 7T0ZHaspyCJATIEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNiAAKCRCLPIo+Aiko 1feVB/daTkBr9fSmmy0neS1IRKcDx1F+/xbzR35fHVHKFWq5T3vh19Dk+kqbBA6iYl3IhPXzDd4 KTvnvnWdUo3Ef+fqn2MhAk14ZMijGADt9os+idQYt85gPrZ2s5vkJtB09cyoDLruXMwfO03jHEM dDvETQ062Uywo7vKbgCeUz3QSxj3K1SmkmYHBOgtkKFmZasCL9RuQdxea9rDrwOi5Ymb9SLCV/J p0/9xZK0Mub/d9ZeJl4M62f8yG3RuOXhWuoXjaNxHsv4qHYu6fPP42N31sevhYIX6uuYW8B6dOK Olix2Cx9iNR3oBicygeHAvQxKnNmPk+CIjncnaVI3HN5vvI= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX4mdHUPOZelxt 7gH5nSXWEa4w++7HtpjPZQninOviikhawBDzSm2yIVbTZRDx1GKclmUO6z84oUnrmEs9wpaYI+Y RRKQHhRX0yeRggG+1VN79u8razZaMlpk6rwM2YqcPlbJfxab1y49H8btJCs0XuHLJQcGDJlDkb3 kEIpJah6qJDwWb3ON8T5H1ZEw9Jz5VCESO+K1BKWibJor0VQFXm63qLcIHJrmXnRLVU/Coj1Tu+ 9sv8zBWtD4RNAjskjIpQOgTpz2n4PsFy+Jg4zu8UQ4T58F16I7QZgxfJT7eQ6SlsN71JG2BiD8O jT7h+YgJbXnZHcfvIRdJwRgE01MgOrCXuRKEhvoBfO6WrilVykLo4b2S4DCzUjVv4rOBA2j2Xk8 dFnHVOaNnGBgXqaDnrlS98/idfx+IG2a6qFbbPQO85ppOvzrr/18UT2mt4qSnWxRDNexUgDkt9O iPRq8mxSK4lI+ZBMfWA== X-Proofpoint-ORIG-GUID: CiMcqlGZKR5LhMpDuwaXqniEEfWzArhl X-Proofpoint-GUID: CiMcqlGZKR5LhMpDuwaXqniEEfWzArhl X-Authority-Analysis: v=2.4 cv=ReWgzVtv c=1 sm=1 tr=0 ts=69fc8dda cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=vmkA5Hdfq4WBgaw8N_IA:9 a=QEXdDO2ut3YA:10 a=eYe2g0i6gJ5uXG_o6N4q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 UBWC devices before 4.0 use standard UBWC swizzle levels. As all the drivers now use the qcom_ubwc_swizzle() helper, move those values to the helper, leaving UBWC 4.0+ intact for now. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 34 ---------------------------------- include/linux/soc/qcom/ubwc.h | 33 ++++++++++++++++++++++++--------- 2 files changed, 24 insertions(+), 43 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index b880f77f448c..2509aed0e743 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -33,17 +33,11 @@ static const struct qcom_ubwc_cfg_data kaanapali_data = =3D { =20 static const struct qcom_ubwc_cfg_data msm8937_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data msm8998_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, }; =20 @@ -60,94 +54,66 @@ static const struct qcom_ubwc_cfg_data sa8775p_data =3D= { =20 static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_1, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 13, }; =20 static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_1, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sc8180x_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sdm670_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sdm845_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, }; =20 static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm6125_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm6150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm7150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm8150_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, }; =20 diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index fee778360ac2..7c9506741001 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -22,9 +22,6 @@ struct qcom_ubwc_cfg_data { * UBWC 4.0 adds the optional ability to disable levels 2 & 3. */ u32 ubwc_swizzle; -#define UBWC_SWIZZLE_ENABLE_LVL1 BIT(0) -#define UBWC_SWIZZLE_ENABLE_LVL2 BIT(1) -#define UBWC_SWIZZLE_ENABLE_LVL3 BIT(2) =20 /** * @highest_bank_bit: Highest Bank Bit @@ -55,12 +52,7 @@ static inline const struct qcom_ubwc_cfg_data *qcom_ubwc= _config_get_data(void) =20 static inline bool qcom_ubwc_get_ubwc_mode(const struct qcom_ubwc_cfg_data= *cfg) { - bool ret =3D cfg->ubwc_enc_version =3D=3D UBWC_1_0; - - if (ret && !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL1)) - pr_err("UBWC config discrepancy - level 1 swizzling disabled on UBWC 1.0= \n"); - - return ret; + return cfg->ubwc_enc_version =3D=3D UBWC_1_0; } =20 static inline bool qcom_ubwc_min_acc_length_64b(const struct qcom_ubwc_cfg= _data *cfg) @@ -85,8 +77,31 @@ static inline bool qcom_ubwc_bank_spread(const struct qc= om_ubwc_cfg_data *cfg) return true; } =20 +#define UBWC_SWIZZLE_ENABLE_LVL1 BIT(0) +#define UBWC_SWIZZLE_ENABLE_LVL2 BIT(1) +#define UBWC_SWIZZLE_ENABLE_LVL3 BIT(2) + +/** + * @qcom_ubwc_swizzle: Whether to enable level 1, 2 & 3 bank swizzling. + * + * UBWC 1.0 always enables all three levels. + * UBWC 2.0 removes level 1 bank swizzling, leaving levels 2 & 3. + * UBWC 4.0 adds the optional ability to disable levels 2 & 3. + */ static inline u32 qcom_ubwc_swizzle(const struct qcom_ubwc_cfg_data *cfg) { + if (cfg->ubwc_enc_version =3D=3D 0) + return 0; + + if (cfg->ubwc_enc_version =3D=3D UBWC_1_0) + return UBWC_SWIZZLE_ENABLE_LVL1 | + UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + + if (cfg->ubwc_enc_version < UBWC_4_0) + return UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + return cfg->ubwc_swizzle; } =20 --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCBFA423A8F for ; Thu, 7 May 2026 13:04:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159072; cv=none; b=LPq1jhjrTcZn3bYrl+0aTOprgn6wh7aTDiGB3o4mHLM8iSGlcs9bxR+KM34Am/hgALHkRBxBrj5wPloEa6uzB7nPBmHemAG1eh5untxxWCT4SiQidjnJVmyqh0XBChs7y2EFhbIazsAwZah018t74CEWm65DM/X1vQH48Yi4qMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159072; c=relaxed/simple; bh=gvMDo6slYGiqJv3R26vftFLiDexyE8LeQxJKV4S7Idw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XwOW7JMdvNlikB4aZBq8tef1NnGvi9NeBc76vhtLbavQqdLSbRydcaFKg9pBPUZmkfoWuhb02/QnibPSuSY3XwAzG46cUpxcvMtVsKt4zlkNN5loOlN+er5gEYNLHHnE68OXHjMUZcMAvqLTmx3GmbNdJ02QM6Gl3TdrYtwPcZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jAT2o7Fy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GAC5JmgQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jAT2o7Fy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GAC5JmgQ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6477pfjv1424581 for ; Thu, 7 May 2026 13:04:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4qvxpoQH2bQDtPLlCKngSNqf1Sqrv1yauYDlLuj2z2E=; b=jAT2o7Fydhfp38/1 bxu/JYB/3nMY2RtJgEByutw9KgcXpuUyeaHeYt1nZdR3zm9RZejBpyLbhcYA1mvD 1Oy0JtznyiaFV9zOgtFmyumY0k+k47upz3xBC8Za7PRdBCwjlxocidblZ0/9uXLB hnt5LvUnM+Kn++L1jIt57Xko9riY7A0YMgyxF7SOaFZ6x+ksrSGw5CQviZhacaxv ASdpCE4WphNKsXozJ+i3Dxe1LQGTq3TGQ68icvl4B8rKtGgonuEct4LwUFvE6wXL bP2Bflf035n/Xu/XzEz7eMMnFeSKy4YoyJgI0V9JyU9CUS8dM/byy8ZROxrEn8pE ksKwxg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0pqfs48v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:29 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2adc527eaf5so7592465ad.0 for ; Thu, 07 May 2026 06:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159069; x=1778763869; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4qvxpoQH2bQDtPLlCKngSNqf1Sqrv1yauYDlLuj2z2E=; b=GAC5JmgQUZf/LLJGsuwibxkBsEOE9ypPj4rtJNKuwcwqtQp/y90LqenaBCc9DCW5ja 857buDQDtpzsgxUt8FPp13S5H1JCl+MXshGQRUeyPHnMcJDYWNkQiQ9wql+LroRcC8/5 XpTIISV6hveK0rsawdoVx9Xg01pjIneoRhApLQ5SHvROs44uyOCZ0Q5YhcLd95QSESqZ jsb44q31birneDOQ0pPZzWFq2m6W8s1ofYWbfyCxAmUSDPHQd9x7l93DMt8q5mzQ2ox0 TuSUigUE9ODcQUqhr8iGq495eC1hl64v46lNcOr9ah3axRux9lOSln0NE5//RI8TutxA couQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159069; x=1778763869; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4qvxpoQH2bQDtPLlCKngSNqf1Sqrv1yauYDlLuj2z2E=; b=ZcbvXcKaSv+IrXStt48Qp//bxm1hIV2A4h30N38WaAxzlxJVqPC1bLbtLl+cB4F0FY oGb4Id8fGxPrPswvTsW+/CTdFjlnTnbtMFCeDD46n4lv1kH5ow/7DiMkCgu2VSOTXh3G AoX1XPs0NZR+V6xc782UlYrdWI1S0U2dbL2P/L9teZfBUCtDzho/FZiriCZUKbjH/CxD kxvLfRRCR4xnMwOcrlqU2YLIv/Y7WDW/bam3usU5uRePYz/PSqrre9K2852e1cLH1wgf hGZ1XTXyxMy04BUP2j/mJI93xLN9BTfQEu/GBQbI4sWAqioQZ/XUeojYSA14nVbTl8Y0 AHUQ== X-Forwarded-Encrypted: i=1; AFNElJ9my1VEhxvVnj+RyX/fM4XmyrI5QphEZX547dtJ3yq9xP3QKk7Krgt8TaHWzgah25BJPfJCVtI2iGljUZM=@vger.kernel.org X-Gm-Message-State: AOJu0YyUeqLXMvi8kbwuF8L/cbHUOG2/rBEryUMJLeW+znlktVPXLrmN x6tqs9fJ4x9gVRGzmTZtM8dYUnNVL24LYJZPXQrtWFM2yKugwnkA7ROnDOEpl160RwTidZlxXGW FyPxR5cENu9Aj1odtEVAUqilatC/AsbpEaZRWbF1IG+CfwFBqNvA/osxoQp+9JGdxMvo= X-Gm-Gg: AeBDiesO+ClKcTAK5U6RcOlsRKm/QkJogTW7mxll/18dZB+Hovfyqk1CQBTh6xAxwMD aLljrRaJm0D2bMVI73QL4ASb1m9gAzxFQLQjR2gE1Snt4ica/jNmig9jUPjzQblwqwOHAEK0QDd Cjh9+NnCgSfORj4Rx3Rv1M9qZMXbionecGcReumeFjZwIOl8R4bKeql8L+nwgnEtnsTlCb4Rw7S JPhb6bQJIdNdkELbv+RenyRTE6yXHDcLwK+4hrulY9v31cnp15dbrXCJ2IpiDmgF5gBphHLGZKb nfODMC8iTPStqMmB6TJcxw8t6h0rb37FMOzitZ4TYzpbG5JWEmpxNQ8od8uCqJaVofFnUnvhiaq w6hLycRncA6GMo7P+IAxeBfzXSAYR193e83bBvXVQ31A4dbr2eZsMsaMhD6NQnOBOv4nRRWPiMt 5W3SJuPpvrNmtoNvmPE2fW/Sdziv9jLuGyhtbRiHb2M6riOQ== X-Received: by 2002:a17:902:ebc9:b0:2b0:445a:8c7b with SMTP id d9443c01a7336-2ba7928e644mr86459925ad.15.1778159068392; Thu, 07 May 2026 06:04:28 -0700 (PDT) X-Received: by 2002:a17:902:ebc9:b0:2b0:445a:8c7b with SMTP id d9443c01a7336-2ba7928e644mr86458955ad.15.1778159067613; Thu, 07 May 2026 06:04:27 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:25 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:24 +0300 Subject: [PATCH v4 28/29] soc: qcom: ubwc: sort out the rest of the UBWC swizzle settings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-28-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4424; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=gvMDo6slYGiqJv3R26vftFLiDexyE8LeQxJKV4S7Idw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp/I2Id2NKe/WGj9GWDX+yBm6UHibLIS83qp3aH ga0aLNmTpCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafyNiAAKCRCLPIo+Aiko 1fjmB/979mhR6QqIm1YCLdRJ5GbJ1Hc4YUqVoo0XetJAndmbFzBLdLfvJjP46SjkIYTlNPz0OuA ABe3Hei0V2jrMSqVWFxitVIl6LKoV4EL5vf205bF7/fnuRNH6x9dKrWtjHEkOKY0mMAlzZHRjbC 3+rnl2+1dwlVvquF5qRF+nmc8uSsCq/ZENw45MeDkTDBa8WjyuNL+7hLij+Y+bMiLAV+mDa7zCQ 6NX29CRaa5TIq6EJ0nr7161es1HeBUzIrKis1Y2+L3LJm10kL7l8NsQJqps9/PRMnBiFYFvHo8x OYu9z0hwCS6/EE/7lCV+Jr0R2LUDGrOQCSpF1dva0Mf3RhUS X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=TJB1jVla c=1 sm=1 tr=0 ts=69fc8ddd cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=3htL6sknLGLhwEng4zIA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX68FqKTwWn03v WMwC2AJNK3JIj5yvN6F3Bx6hwlEYS+5GLnjf2QfvqAe4itXqV5s1iqVPAz1kxt8Yu50ejL3yv5r M8rjbLw6QcQ59xlrzkuOIAyzENWOCtpF0AsoDP5O9biETIBaOtplKJEpqq0ClH4xWr9/xCPfU4E kVL4aoyR54VU8dJb2LCmLU6Xr5xAbBIGBzzgV/DTcwOQx4lW4wKalNJo4G7y0lX+bnHPK/iczqd lPOyj9KlvlOZBLFVKhALfz7AA+hUrMLAh4OE5jpozB4bpO3ZxIvRaBkZMJ8xgt2BaDJ+MTV/eON N3JKnQkGf0gvvrn1HcdoAEiC0LYQIEgCS4C7fk0M4txcgprLGZTt0VyW40qLEtmaMPHzTBAyozR oulFA4nLn47vM0mnQUtJCIQo7qtQDnEN8vAkz3qETl6dKi9xOJVLchJMXsMZmvlwxSWh8RTXZwi NnFfxd4BINsch/Yecgg== X-Proofpoint-GUID: n3pIsJ9sjjfkO-F2SSE9bBbEmWG4DRsN X-Proofpoint-ORIG-GUID: n3pIsJ9sjjfkO-F2SSE9bBbEmWG4DRsN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 Sort out the remaining UBWC swizzle values, using flags to control whether level 2 and level 3 swizzling are enabled or not. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 16 +++------------- include/linux/soc/qcom/ubwc.h | 26 +++++++++++++------------- 2 files changed, 16 insertions(+), 26 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 2509aed0e743..e9a6063e9297 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -18,16 +18,12 @@ static const struct qcom_ubwc_cfg_data no_ubwc_data =3D= { =20 static const struct qcom_ubwc_cfg_data eliza_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 14 for LP_DDR4 */ .highest_bank_bit =3D 15, }; =20 static const struct qcom_ubwc_cfg_data kaanapali_data =3D { .ubwc_enc_version =3D UBWC_6_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, }; =20 @@ -48,7 +44,7 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { =20 static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, + .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2, .highest_bank_bit =3D 13, }; =20 @@ -119,38 +115,32 @@ static const struct qcom_ubwc_cfg_data sm8150_data = =3D { =20 static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_swizzle =3D 6, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_swizzle =3D 0, + .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2 | + UBWC_FLAG_DISABLE_SWIZZLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 7c9506741001..a7372d9c25fb 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -14,15 +14,6 @@ struct qcom_ubwc_cfg_data { u32 ubwc_enc_version; =20 - /** - * @ubwc_swizzle: Whether to enable level 1, 2 & 3 bank swizzling. - * - * UBWC 1.0 always enables all three levels. - * UBWC 2.0 removes level 1 bank swizzling, leaving levels 2 & 3. - * UBWC 4.0 adds the optional ability to disable levels 2 & 3. - */ - u32 ubwc_swizzle; - /** * @highest_bank_bit: Highest Bank Bit * @@ -30,6 +21,10 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; + + unsigned int flags; +#define UBWC_FLAG_DISABLE_SWIZZLE_LVL2 BIT(0) +#define UBWC_FLAG_DISABLE_SWIZZLE_LVL3 BIT(1) }; =20 #define UBWC_1_0 0x10000000 @@ -98,11 +93,16 @@ static inline u32 qcom_ubwc_swizzle(const struct qcom_u= bwc_cfg_data *cfg) UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3; =20 - if (cfg->ubwc_enc_version < UBWC_4_0) - return UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3; + u32 ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + + if (cfg->flags & UBWC_FLAG_DISABLE_SWIZZLE_LVL2) + ubwc_swizzle &=3D ~UBWC_SWIZZLE_ENABLE_LVL2; + + if (cfg->flags & UBWC_FLAG_DISABLE_SWIZZLE_LVL3) + ubwc_swizzle &=3D ~UBWC_SWIZZLE_ENABLE_LVL3; =20 - return cfg->ubwc_swizzle; + return ubwc_swizzle; } =20 static inline u32 qcom_ubwc_version_tag(const struct qcom_ubwc_cfg_data *c= fg) --=20 2.47.3 From nobody Sat Jun 13 13:38:19 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1F2B427A1B for ; Thu, 7 May 2026 13:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159074; cv=none; b=VRGC//HcvZMRaUq4B1OoNO8F+aa2NbO1JiYXNrZu/uXNkDfZt/WuGFHhEfQ7hfs+yjw3jajggyiVUML8K/HpmU4qEf1Y0L7vVtV8r932jvpgfBg5mlUdwKPAZYCpefbh7ZDVqf1oct3tdp6AMb6QXsMBGESyTy/78Eb8g2A/KI8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159074; c=relaxed/simple; bh=VdEc0V+CgbMbbFSsV1zoCvXw7tLTzSeBhBXkFoJKHQk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HyXonyWg0TEVjEpxJkK5HpuQte1pEbvVh5abXfcUjzdxpPuMYK3YWXeJvn4IVBM8DryDE0XsTigMrCYjMza/xN7l0j+Cfq9ALmcL5BjcdYdZxS1GzFmrQUp4jkeZy/pTOf3APH0B2Ykk0E3W5S0ERcQSa5kZr8nNniz2zfiTssY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VWm7liWN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dX8AH+PZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VWm7liWN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dX8AH+PZ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647AGn5M150864 for ; Thu, 7 May 2026 13:04:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GmZxMgg5s3XsOxk+uXEg9M7ZFIP2zQv+t0cFQ5giGtM=; b=VWm7liWN4MM6hA6P 4amlCsLL/dNyLgyKH7wA3iR+8QQQnKemoC0FlEI3/1qlCeiudrYN6UpmU2TpDc3P sQ5x+RNp0WpkW5vagL4AAVrrxWXNJC1XyukyhB55GX6eqSHIcuv1OacX7PwJcHTk RrDS8ly36s8irt7L95H4TmRfIB5oiTIm68MTFyUwjrt9DCx3yMgiz1diJzAIYYiN 99+by0iYmtKnVS4tlvkqXBR2Kqlyjo1gXHK+Sfme1kHDJB+GRJP46AVWxW3510iq 1R0y/UbguXAtV7voiYFXB8K7lIM2mBXnUk9FaA56AvNCH6CkLQ73KM/kY2mwiZe4 Yp3KEw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0kctsw3p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:04:31 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b79f4b35b7so8688955ad.0 for ; Thu, 07 May 2026 06:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159071; x=1778763871; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GmZxMgg5s3XsOxk+uXEg9M7ZFIP2zQv+t0cFQ5giGtM=; b=dX8AH+PZmk5lV1csz/77ZUnb5GArkjd9bYdHJI4u/wx7KuQOA3eL2OZQfMieOgEWXG T3fAj9YQogBUlv/BtXLEKSXzWydUw5IoE1T/Z/TgSyi0CQ/lcnqvss3uh14M1NiTdXbi 58vbhKHf81e0lT4lCE8vDJP0EYhj5V4YSTEpM/c6Akujbu/cUy6vySorAwlXqMoHQrGl +56owbcSL9wQ4GRwjPEY5a+c/bxQAfhNXH9INm80gGT3SuFUDWqBctoiLHPG7TaqBmaS c/wc74J2zxFVVssTYbluXIh9NOR0+N0BlWExQud2UWgDqbbUUxebCdkW8Sn2loN/G4n1 xjzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159071; x=1778763871; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GmZxMgg5s3XsOxk+uXEg9M7ZFIP2zQv+t0cFQ5giGtM=; b=pgSZwf8VDStge9l9KEU7l9nBONT3utC9wJCzlFT5fg5XFR63hrMs71xe+ZOcLOd3gv 1s6N1fBo9zu3uCGfT11xKB85RiBKO7GRgm7YKlmFmVKByM2cP2ZLZyVlkc/jLpU78PXz B56pgjK8viFYsXue3WCnx3eTVP5BPHf+jxOC6VcHowWTj5YvGKskXJdUKy9elpKkTwsz CKwTQT1pvRIWMZSODqS8r1ZVQoIqlovSLZCTsQAETdmsoacxFBZvuNhUwguyhLMH5YaR QjOlUzLGYEG2Cv5U2bTMChiXXAZqXVQ9rpnIyXspHwIszLx9lyhYqx/QEzUE4ifywMt1 Getw== X-Forwarded-Encrypted: i=1; AFNElJ+dinDkCqDH5uU+RSP3kEcjUwlI6sRP2dLNPnQL9Er6eYzHAh9WXCTvwclzajUtJP7GYQG8TQVbU7ozsz0=@vger.kernel.org X-Gm-Message-State: AOJu0YyGKvLh+dGTXZWT4wA+l6sqgdkOy3d3CuwhHvHO5tlUSrAW7hOM 7WWgpvfUg+si9xPl9oQoBgz3b3bllD2fLtBxPydkP78gA6VF7DW+1TRY+7lphQpsS6Air9D9Z75 6Bu4e3vdi8Vadv7ttD6Vy3q41x+CeI1AUGacxnclkeKYkQQfvTeT2BA1LoEcbULALBSo= X-Gm-Gg: AeBDieuXY4r1xSM2j02u0MeftHa+7eOIu1cjC8xyJCsHGfY9OAM5raXmiLdCfk5jXWd iDRSt1oD1a5rOyhb2+gviHveCbDgQRw3DAKFfl+teDnOZUCFO+0WUbO0+EEdVbSEMrRRl4BwvFs R34L5XLGnFrgLhQb7m+w2HFnsrMTRxOfvVXI61Xd216EHtEfymsZnIS2NtysSMM9nnTqbmAx6Fd A4qdrEzCf7yMlK1t4l29ako0giLURhQfan/g7C36qjQl+PjkZtmdx6nLX8TZgwMtTfG5ep27Zh0 SQAXO2wasflqqtzQVr3SapEguL2fOYk6F16zDOdU0JLwjZ3LHjXq+MGCEOyovXyfNgeaG2fBOj2 Q2x7EZvYNtFWTDiJ2MxN7MEMQZG6+BF6/2fwQGhOakvh6wgDL6pWPZ4FF3OcyBD/OS+IXPc2ZAQ uO194pijWAFKzXWHsCErok9UwRi7E0zzdgTE3QNea1G6qJQg== X-Received: by 2002:a17:903:124a:b0:2b2:497e:3f60 with SMTP id d9443c01a7336-2ba7a2253f6mr81254585ad.33.1778159070354; Thu, 07 May 2026 06:04:30 -0700 (PDT) X-Received: by 2002:a17:903:124a:b0:2b2:497e:3f60 with SMTP id d9443c01a7336-2ba7a2253f6mr81253885ad.33.1778159069718; Thu, 07 May 2026 06:04:29 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230c68sm5595959e87.19.2026.05.07.06.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:04:28 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 16:03:25 +0300 Subject: [PATCH v4 29/29] soc: qcom: ubwc: deduplicate UBWC configuration data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-ubwc-rework-v4-29-c19593d20c1d@oss.qualcomm.com> References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> In-Reply-To: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=11592; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=VdEc0V+CgbMbbFSsV1zoCvXw7tLTzSeBhBXkFoJKHQk=; b=kA0DAAoBizyKPgIpKNUByyZiAGn8jYjIGYLtyEUa8ItJzjA65pc87S5dGhqp61g3C/lWam8Xz okBMwQAAQoAHRYhBExwhJVcsmNW8LiVf4s8ij4CKSjVBQJp/I2IAAoJEIs8ij4CKSjV62AH+wbM 6Ii/82MYn24IACjcziXPAZu0WJfhM+DBQhFaTcEoDjt+fDXun0M3XKan/7GeXTC85wVOPK9pyuf osBKIkwz/2LzdHvLrYqzr152a24k7aUcyMxrOl11Me0JKHW7vkDuT+wQ/Qjh++1gw/6Nloe7f7O W20rgWzWuaoC5g2nU8o9YWEXy3DmRZbQRP9qahDHOa26CdPgU36fKjnezeJZHMVav+WyD2X9a5T RxP8n4/t6fs/Q+2otC2ES6PA2jdZmwRe7dmLbZPnbjy0jrDWKmoCz5O7otwjvGYyRwsjk6yrPTJ i8fafpfLmVG+U6lu45PCPyf7gxHz6EXdI8XdGk8= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=XsPK/1F9 c=1 sm=1 tr=0 ts=69fc8ddf cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=EdS0WidbVIiCbvCQNVEA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: 1U5KVctWlIF12f8n9PBSQJ8hBJBiRA08 X-Proofpoint-ORIG-GUID: 1U5KVctWlIF12f8n9PBSQJ8hBJBiRA08 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMCBTYWx0ZWRfX3f7AHn+tuA7L sBHMXeYZLT+eUU7uNXp4L75ZGdPBLL+G4//8j1PfxemPaeK2lJ1rkTXFh7rfLWEfm9QEda38tzB pfKDI8AsGfo/8LNwkOLluxDdWfBAz5QiJZgHX/fcISHX7E5hzyYK4SXYbLECx+jRIotLGH8Ms0F GJXsoWSEB13Toq734dIIOTGxePKT/vqWBuO9+KX9DVvnAdCIBkKkjqsVwnNRD6TwxI1j8sk2wwB eQ1ln6Te8EiHiaKWykWcZibJLzGOs7P18yzcSWEKfNqUJtpjICMZvtfYQlnayhUdHqFhI3CQjA2 RZuVjRNFhv8p7r4bGVxlEbDSqJ1QMscq+VzmAUIHREtC2YwDBFj0bLmPXwIklwhg/Pe8mYInFNa ++Z3EoGA7015xzk7o8Ddoo45n71RjqKe9wTzOc4h4v4G7fS1UY7IgMFnQ43caB7HKnNRap17hVS kiruo/T5nG+3r6zSZzA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070130 After removing all extra entries from the UBWC database it is easy to define generic entries, common for all machine classes. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 197 ++++++++++++++++---------------------= ---- 1 file changed, 74 insertions(+), 123 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index e9a6063e9297..37f1335069cd 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -16,125 +16,76 @@ static const struct qcom_ubwc_cfg_data no_ubwc_data = =3D { /* no UBWC, no HBB */ }; =20 -static const struct qcom_ubwc_cfg_data eliza_data =3D { - .ubwc_enc_version =3D UBWC_5_0, - /* TODO: highest_bank_bit =3D 14 for LP_DDR4 */ +static const struct qcom_ubwc_cfg_data ubwc_0_0_hbb15 =3D { + /* no UBWC */ .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data kaanapali_data =3D { - .ubwc_enc_version =3D UBWC_6_0, - .highest_bank_bit =3D 16, -}; - -static const struct qcom_ubwc_cfg_data msm8937_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_1_0_hbb14 =3D { .ubwc_enc_version =3D UBWC_1_0, .highest_bank_bit =3D 14, }; =20 -static const struct qcom_ubwc_cfg_data msm8998_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_1_0_hbb15 =3D { .ubwc_enc_version =3D UBWC_1_0, .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data qcm2290_data =3D { - /* no UBWC */ - .highest_bank_bit =3D 15, -}; - -static const struct qcom_ubwc_cfg_data sa8775p_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2, - .highest_bank_bit =3D 13, -}; - -static const struct qcom_ubwc_cfg_data sar2130p_data =3D { - .ubwc_enc_version =3D UBWC_3_1, - .highest_bank_bit =3D 13, -}; - -static const struct qcom_ubwc_cfg_data sc7180_data =3D { - .ubwc_enc_version =3D UBWC_2_0, - .highest_bank_bit =3D 14, -}; - -static const struct qcom_ubwc_cfg_data sc7280_data =3D { - .ubwc_enc_version =3D UBWC_3_1, - .highest_bank_bit =3D 14, -}; - -static const struct qcom_ubwc_cfg_data sc8180x_data =3D { - .ubwc_enc_version =3D UBWC_3_0, - .highest_bank_bit =3D 16, -}; - -static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - .highest_bank_bit =3D 16, -}; - -static const struct qcom_ubwc_cfg_data sdm670_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_2_0_hbb14 =3D { .ubwc_enc_version =3D UBWC_2_0, .highest_bank_bit =3D 14, }; =20 -static const struct qcom_ubwc_cfg_data sdm845_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_2_0_hbb15 =3D { .ubwc_enc_version =3D UBWC_2_0, .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data sm6115_data =3D { - .ubwc_enc_version =3D UBWC_1_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_3_0_hbb15 =3D { + .ubwc_enc_version =3D UBWC_3_0, + .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data sm6125_data =3D { - .ubwc_enc_version =3D UBWC_1_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_3_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_3_0, + .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm6150_data =3D { - .ubwc_enc_version =3D UBWC_2_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_3_1_hbb13 =3D { + .ubwc_enc_version =3D UBWC_3_1, + .highest_bank_bit =3D 13, }; =20 -static const struct qcom_ubwc_cfg_data sm6350_data =3D { - .ubwc_enc_version =3D UBWC_2_0, +static const struct qcom_ubwc_cfg_data ubwc_3_1_hbb14 =3D { + .ubwc_enc_version =3D UBWC_3_1, .highest_bank_bit =3D 14, }; =20 -static const struct qcom_ubwc_cfg_data sm7150_data =3D { - .ubwc_enc_version =3D UBWC_2_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_4_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_4_0, + .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm8150_data =3D { - .ubwc_enc_version =3D UBWC_3_0, +static const struct qcom_ubwc_cfg_data ubwc_5_0_hbb15 =3D { + .ubwc_enc_version =3D UBWC_5_0, + /* TODO: highest_bank_bit =3D 14 for LP_DDR4 */ .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data sm8250_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ +static const struct qcom_ubwc_cfg_data ubwc_5_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_5_0, .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm8350_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ +static const struct qcom_ubwc_cfg_data ubwc_6_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_6_0, .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm8550_data =3D { +static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ - .highest_bank_bit =3D 16, -}; - -static const struct qcom_ubwc_cfg_data sm8750_data =3D { - .ubwc_enc_version =3D UBWC_5_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ - .highest_bank_bit =3D 16, + .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2, + .highest_bank_bit =3D 13, }; =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { @@ -149,61 +100,61 @@ static const struct of_device_id qcom_ubwc_configs[] = __maybe_unused =3D { { .compatible =3D "qcom,apq8016", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,apq8026", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,apq8074", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,apq8096", .data =3D &msm8998_data }, - { .compatible =3D "qcom,eliza", .data =3D &eliza_data, }, - { .compatible =3D "qcom,kaanapali", .data =3D &kaanapali_data, }, + { .compatible =3D "qcom,apq8096", .data =3D &ubwc_1_0_hbb15 }, + { .compatible =3D "qcom,eliza", .data =3D &ubwc_5_0_hbb15 }, { .compatible =3D "qcom,glymur", .data =3D &glymur_data}, + { .compatible =3D "qcom,kaanapali", .data =3D &ubwc_6_0_hbb16 }, { .compatible =3D "qcom,mahua", .data =3D &glymur_data }, { .compatible =3D "qcom,msm8226", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8916", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8917", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,msm8937", .data =3D &msm8937_data }, + { .compatible =3D "qcom,msm8937", .data =3D &ubwc_1_0_hbb14 }, { .compatible =3D "qcom,msm8929", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8939", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,msm8953", .data =3D &msm8937_data }, + { .compatible =3D "qcom,msm8953", .data =3D &ubwc_1_0_hbb14 }, { .compatible =3D "qcom,msm8956", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8974", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8976", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,msm8996", .data =3D &msm8998_data }, - { .compatible =3D "qcom,msm8998", .data =3D &msm8998_data }, - { .compatible =3D "qcom,qcm2290", .data =3D &qcm2290_data, }, - { .compatible =3D "qcom,qcm6490", .data =3D &sc7280_data, }, - { .compatible =3D "qcom,qcs8300", .data =3D &sc8280xp_data, }, - { .compatible =3D "qcom,sa8155p", .data =3D &sm8150_data, }, - { .compatible =3D "qcom,sa8540p", .data =3D &sc8280xp_data, }, + { .compatible =3D "qcom,msm8996", .data =3D &ubwc_1_0_hbb15 }, + { .compatible =3D "qcom,msm8998", .data =3D &ubwc_1_0_hbb15 }, + { .compatible =3D "qcom,qcm2290", .data =3D &ubwc_0_0_hbb15, }, + { .compatible =3D "qcom,qcm6490", .data =3D &ubwc_3_1_hbb14, }, + { .compatible =3D "qcom,qcs8300", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sa8155p", .data =3D &ubwc_3_0_hbb15, }, + { .compatible =3D "qcom,sa8540p", .data =3D &ubwc_4_0_hbb16, }, { .compatible =3D "qcom,sa8775p", .data =3D &sa8775p_data, }, - { .compatible =3D "qcom,sar2130p", .data =3D &sar2130p_data }, - { .compatible =3D "qcom,sc7180", .data =3D &sc7180_data }, - { .compatible =3D "qcom,sc7280", .data =3D &sc7280_data, }, - { .compatible =3D "qcom,sc8180x", .data =3D &sc8180x_data, }, - { .compatible =3D "qcom,sc8280xp", .data =3D &sc8280xp_data, }, - { .compatible =3D "qcom,sda660", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm450", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm630", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm632", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm636", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm660", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm670", .data =3D &sdm670_data, }, - { .compatible =3D "qcom,sdm845", .data =3D &sdm845_data, }, - { .compatible =3D "qcom,sm4250", .data =3D &sm6115_data, }, - { .compatible =3D "qcom,sm6115", .data =3D &sm6115_data, }, - { .compatible =3D "qcom,sm6125", .data =3D &sm6125_data, }, - { .compatible =3D "qcom,sm6150", .data =3D &sm6150_data, }, - { .compatible =3D "qcom,sm6350", .data =3D &sm6350_data, }, - { .compatible =3D "qcom,sm6375", .data =3D &sm6350_data, }, - { .compatible =3D "qcom,sm7125", .data =3D &sc7180_data }, - { .compatible =3D "qcom,sm7150", .data =3D &sm7150_data, }, - { .compatible =3D "qcom,sm7225", .data =3D &sm6350_data, }, - { .compatible =3D "qcom,sm7325", .data =3D &sc7280_data, }, - { .compatible =3D "qcom,sm8150", .data =3D &sm8150_data, }, - { .compatible =3D "qcom,sm8250", .data =3D &sm8250_data, }, - { .compatible =3D "qcom,sm8350", .data =3D &sm8350_data, }, - { .compatible =3D "qcom,sm8450", .data =3D &sm8350_data, }, - { .compatible =3D "qcom,sm8550", .data =3D &sm8550_data, }, - { .compatible =3D "qcom,sm8650", .data =3D &sm8550_data, }, - { .compatible =3D "qcom,sm8750", .data =3D &sm8750_data, }, - { .compatible =3D "qcom,x1e80100", .data =3D &sm8550_data, }, - { .compatible =3D "qcom,x1p42100", .data =3D &sm8550_data, }, + { .compatible =3D "qcom,sar2130p", .data =3D &ubwc_3_1_hbb13 }, + { .compatible =3D "qcom,sc7180", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sc7280", .data =3D &ubwc_3_1_hbb14, }, + { .compatible =3D "qcom,sc8180x", .data =3D &ubwc_3_0_hbb16, }, + { .compatible =3D "qcom,sc8280xp", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sda660", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm450", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm630", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm632", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm636", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm660", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm670", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sdm845", .data =3D &ubwc_2_0_hbb15, }, + { .compatible =3D "qcom,sm4250", .data =3D &ubwc_1_0_hbb14, }, + { .compatible =3D "qcom,sm6115", .data =3D &ubwc_1_0_hbb14, }, + { .compatible =3D "qcom,sm6125", .data =3D &ubwc_1_0_hbb14, }, + { .compatible =3D "qcom,sm6150", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm6350", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm6375", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7125", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7150", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7225", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7325", .data =3D &ubwc_3_1_hbb14, }, + { .compatible =3D "qcom,sm8150", .data =3D &ubwc_3_0_hbb15, }, + { .compatible =3D "qcom,sm8250", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8350", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8450", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8550", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8650", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8750", .data =3D &ubwc_5_0_hbb16, }, + { .compatible =3D "qcom,x1e80100", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,x1p42100", .data =3D &ubwc_4_0_hbb16, }, { } }; =20 --=20 2.47.3