From nobody Sat Jun 13 13:32:57 2026 Received: from smtpbguseast1.qq.com (smtpbguseast1.qq.com [54.204.34.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DB5B346FCA; Thu, 7 May 2026 10:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.129 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778150097; cv=none; b=C/Ocv24fewM0EyMYUgBj4WrU5lxduZ3fUh7viRJvUHKF7sTLur1EjLZh8No1T1Dmvno93te+tkZMbctU+Ri7xn7cUMz1qME7XrAT7z2fQAzw8rPkpRrDPSdUnar6RSAxn5Xw1spTRKurBoTahGVCJOuezJNMlrby1mPHQA+YZk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778150097; c=relaxed/simple; bh=HevkQyYoy3kiO1VrBKioDTilzos+sth9T5xZNgNnIUQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uriS+EwIBzd0oRgfBhPtsmH32uXbppXp0uNc/OiiZDmYr8UFQdDhViLk05fgf93GabZ2PDw2r8eOsHAN48LKjphln5aMCidfQCgLh6CZz0V/hvs+1Afei/PDGwbaHwPB0/V4i1AiUWxi7zYJ+bj93uabZwa2cQsUc9kJ6Ob2oFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=mKz9LIST; arc=none smtp.client-ip=54.204.34.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="mKz9LIST" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1778150091; bh=AA/l8RpNRgQWhJKMhQO6AtegRn3p6g7Rx5XU5wAB/G8=; h=From:Date:Subject:MIME-Version:Message-Id:To; b=mKz9LISTxdOMjqAdw9/ysuTNUdNBJvPGHgdbyJbjQVeYjOIn5huQeN3d0qLv6bjQf akIFrETVUeB0PwePeJiBbBOn/MTMdTe4q1XFi6FsDnfNkqUTuIYLQRb45tEnoPa/bA 0F/HcnDfz28asZcCADwA+i710fewYN9rKEJ5rjdM= X-QQ-mid: zesmtpgz1t1778149914t5eb95826 X-QQ-Originating-IP: q0iU5z36pYpAszH2oFPO8xEGSgQLaSK2gKm4e5W7naI= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 07 May 2026 18:31:52 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 5667795704540246135 EX-QQ-RecipientCnt: 11 From: Troy Mitchell Date: Thu, 07 May 2026 18:31:42 +0800 Subject: [PATCH v2 1/3] ASoC: soc-dai: add shared BCLK clock for cross-DAI rate constraints Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-i2s-same-blk-v2-1-ede05a22f732@linux.spacemit.com> References: <20260507-i2s-same-blk-v2-0-ede05a22f732@linux.spacemit.com> In-Reply-To: <20260507-i2s-same-blk-v2-0-ede05a22f732@linux.spacemit.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Yixun Lan Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, jinmei.wei@spacemit.com, Troy Mitchell X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778149908; l=3103; i=troy.mitchell@linux.spacemit.com; s=20250710; h=from:subject:message-id; bh=HevkQyYoy3kiO1VrBKioDTilzos+sth9T5xZNgNnIUQ=; b=1wBfk5r93og4rl4TtfoXHWvQGYLKZnrhFvSIKzGC1ey5HGqMKcv7LK7VfR0vrHYQZCaGTkoyK Wbc0o53lQPQDdzDPTZEDHUk3FMXDaSVGgmHrvxWQmT9XMc4oMxyeXgU X-Developer-Key: i=troy.mitchell@linux.spacemit.com; a=ed25519; pk=lQa7BzLrq8DfZnChqmwJ5qQk8fP2USmY/4xZ2/MSsXc= X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: MHUne8CZIF193QyIEvKJroptxb4SosU2ca499hiPrYv0kIW9Rg4s/TeT IlcJrVec84QLjoM6RUeMELWtpzWDOMz9EfxckLTmWQ1w1S/qxPT28TEKKDl2o/k4+BDr3pn Llrj/iO9Nc8p2+kvFj2KWXFprjbqpKUfdmLUJsHDCOonuDvYrNSZLFrPrSsWk3YroZyLQhn aqhvo/o81wO2jML4sZtGx+2hbs7cXkAGmV4PmEEhutaEXOuZba8/z+4AbkdH5tWOKXabydN 3HXCE6B/jWsMTyXzoDwxCSEUXJa5pFPb1Hd06YlpqLO3NZ6vUUczNzUMVzzKNkG501L0WWL naBrqK63GPSmtd7ilUp4VPpcl2Dc4jFwLZysnLsX+IhzUFS2wZNDtambeAuyeEeBtht+rLc gIXz/OAE9hiqRCFXpGqTwY7LcnJ9wcsLTRs2PcWfJxHa9wMcN2fwM+uk6MulaN/Hadq7ffg pj1LegkDL/PL/5NsO7r6yEHsEuiUlqwqXkLSq7iQ3heWELD3H0wqc30Lj9q4bG1IyUVCLin mwmev7C41z4I3lHctn/boLfBKw7KdTXp9s0Mq6tmI0O+IJRYb+Sf5MgA3zrnLP4qoPG6YHN TULHIJbqROielcVVQgpTeaGs3bWVfIgiXdP2SNUKeDPfdvuvmRgQRLrOpe5yIxPn1ILjxXw Zq0ORXA0LE5swrTkUiSZr7kW4vrM0c7thAWxJfubUMdYV0pyAZLFlGUn/Gj2C2EkoNp+ARe BuXJPbHAWd9I9HK9PEHVr49T4R3PdRrJg6jKy6JzumkovRPjsieUHAJLLlOixD0SAdPP2cx HxE5FXw5jlqagl27pKSuISZtDwz9+3GorOUbfNH8JQMpRUgt8p+ARtfDKUG81i3OuvP1anF /Gis3hFBnepM5TDuK/x8ox3TTOGo1nU9WyJLFm1inet4pOxBz4tGoe40XkImDfCCupVwgaZ aa7D6cyAhd/o01TBSVp+MoI6WQ8xfSQZKvViIeC+r6XpG+054u9gKvYxWZNZJCHz8TDeOLv yVbyexUhqkA6spGqUtfFegi9muQ6JBJ5mffIiXL1wfVuJ1VERTwYrgivmBKgO8Z4tvCHJnE sZ72Gse2LkAb20IYN6Z4FWao1VqJfPgRlN8txT+AYL7ojQw+1MeprIt0CwvOt0uYu/PjdW1 HnGi X-QQ-XMRINFO: Nq+8W0+stu50tPAe92KXseR0ZZmBTk3gLg== X-QQ-RECHKSPAM: 0 Add a bclk field to struct snd_soc_dai and a helper function snd_soc_dai_set_bclk_clk() that platform drivers can use to declare which clock is their BCLK. Also cache the bclk_ratio in snd_soc_dai_set_bclk_ratio() so that the framework can use it later in hw_rule evaluation for TDM configurations where BCLK =3D rate * slots * slot_width. When multiple DAIs on the same card share the same physical BCLK (detected via clk_is_match()), the ASoC core can automatically constrain their hw_params so that the resulting BCLK rates are compatible. This commit adds the data structure support; the actual constraint logic follows in the next patch. Signed-off-by: Troy Mitchell --- include/sound/soc-dai.h | 7 +++++++ sound/soc/soc-dai.c | 18 ++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h index 6a42812bba8c..df010a91b350 100644 --- a/include/sound/soc-dai.h +++ b/include/sound/soc-dai.h @@ -17,6 +17,7 @@ struct snd_pcm_substream; struct snd_soc_dapm_widget; struct snd_compr_stream; +struct clk; =20 /* * DAI hardware audio formats. @@ -188,6 +189,8 @@ int snd_soc_dai_set_pll(struct snd_soc_dai *dai, =20 int snd_soc_dai_set_bclk_ratio(struct snd_soc_dai *dai, unsigned int ratio= ); =20 +void snd_soc_dai_set_bclk_clk(struct snd_soc_dai *dai, struct clk *bclk); + /* Digital Audio interface formatting */ int snd_soc_dai_get_fmt_max_priority(const struct snd_soc_pcm_runtime *rtd= ); u64 snd_soc_dai_get_fmt(const struct snd_soc_dai *dai, int priority); @@ -473,6 +476,10 @@ struct snd_soc_dai { unsigned int symmetric_channels; unsigned int symmetric_sample_bits; =20 + /* shared BCLK clock for cross-DAI rate constraints */ + struct clk *bclk; + unsigned int bclk_ratio; /* BCLK =3D rate * bclk_ratio (0 =3D use channel= s * sample_bits) */ + /* parent platform/codec */ struct snd_soc_component *component; =20 diff --git a/sound/soc/soc-dai.c b/sound/soc/soc-dai.c index 2f370fda1266..1719ddcefa4b 100644 --- a/sound/soc/soc-dai.c +++ b/sound/soc/soc-dai.c @@ -116,10 +116,28 @@ int snd_soc_dai_set_bclk_ratio(struct snd_soc_dai *da= i, unsigned int ratio) dai->driver->ops->set_bclk_ratio) ret =3D dai->driver->ops->set_bclk_ratio(dai, ratio); =20 + if (!ret) + dai->bclk_ratio =3D ratio; + return soc_dai_ret(dai, ret); } EXPORT_SYMBOL_GPL(snd_soc_dai_set_bclk_ratio); =20 +/** + * snd_soc_dai_set_bclk_clk - set the BCLK clock for shared clock detection + * @dai: DAI + * @bclk: BCLK clock pointer (or NULL to clear) + * + * When multiple DAIs share the same physical BCLK (detected via + * clk_is_match()), the ASoC core will automatically constrain their + * hw_params so that the resulting BCLK rates are compatible. + */ +void snd_soc_dai_set_bclk_clk(struct snd_soc_dai *dai, struct clk *bclk) +{ + dai->bclk =3D bclk; +} +EXPORT_SYMBOL_GPL(snd_soc_dai_set_bclk_clk); + int snd_soc_dai_get_fmt_max_priority(const struct snd_soc_pcm_runtime *rtd) { struct snd_soc_dai *dai; --=20 2.54.0 From nobody Sat Jun 13 13:32:57 2026 Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 045D72C0282; Thu, 7 May 2026 10:33:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778149983; cv=none; b=WKRqbAoLj2YcOQRy4sat8TZESAsnQqlOQmsFy7a1H4X2xtQPhZ8omw39jGvEzybXyv3Rc8NNFp+XV8Wq2xoZw2EgsyHg2waleoWGo8DuDRbWsy0qWoDn1oJkg9Zg2Ltk9B3wJRq79dieSImcYlnM5AuGTwwlKwiAyHjN8ogt+Ps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778149983; c=relaxed/simple; bh=dHcuwQewOQ91+lcIOJFibASbfSOLIkUa8mNyTgSGWBs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pGgayNC95cudJWp5FsLvPmvZtLvsjayWcWt2P+TZdJ2iAb9AHClt6XpVykv5XTFx5AdmQu5YUCrxFZ1y+5SqYe6Vs2TsD5ahIrF1hYtip/w5wsM523Kn9tjBeyFB8kqgqSODVBD7lw81xNV9ztGcy3zWOsyFUk2wyKHPViB4Yv8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=lUUZ9cT+; arc=none smtp.client-ip=54.204.34.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="lUUZ9cT+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1778149926; bh=MzLAGIAWkK+XCchAd4hGeXE2CHkEuJGkm4cHQuRIBJ0=; h=From:Date:Subject:MIME-Version:Message-Id:To; b=lUUZ9cT+GygDgLz6wdHzaE3Y3IQwIJzkI7slPaanjOcSMLA5E2SCUTFIzMVobD3sR 4yKrfwShNYDbS9u457NmEqCT9cX3T5Emcktsruh9y9vZnrOMyMsa7JS6D3Raulc2vE uSiR3W72yq0Jpxy+WfnQBEgYlAxNXmfKADzR3YO4= X-QQ-mid: esmtpgz16t1778149918tf7e27786 X-QQ-Originating-IP: mHa7ppekGTzd1+13tMcGS5yqyWnnUNMpj+ng21mAHZk= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 07 May 2026 18:31:56 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 15051299853537787261 EX-QQ-RecipientCnt: 11 From: Troy Mitchell Date: Thu, 07 May 2026 18:31:43 +0800 Subject: [PATCH v2 2/3] ASoC: soc-pcm: constrain hw_params when DAIs share the same BCLK Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-i2s-same-blk-v2-2-ede05a22f732@linux.spacemit.com> References: <20260507-i2s-same-blk-v2-0-ede05a22f732@linux.spacemit.com> In-Reply-To: <20260507-i2s-same-blk-v2-0-ede05a22f732@linux.spacemit.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Yixun Lan Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, jinmei.wei@spacemit.com, Troy Mitchell X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778149908; l=5785; i=troy.mitchell@linux.spacemit.com; s=20250710; h=from:subject:message-id; bh=dHcuwQewOQ91+lcIOJFibASbfSOLIkUa8mNyTgSGWBs=; b=NbtniqEW25n4xUv0iVA/ktb5BAl2nFn4hzHuUE0SFUHJHAcndBmILS4Oonh6PP9u3dYgZGyUA pm4l88XWS+KDFpmXtGlKehkpEsI2/oEDh61kfA8VU0l40jZOViVemRV X-Developer-Key: i=troy.mitchell@linux.spacemit.com; a=ed25519; pk=lQa7BzLrq8DfZnChqmwJ5qQk8fP2USmY/4xZ2/MSsXc= X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: MzOrCbSXFQdfTT7uEET/FBlgp5PRiXI+H3t4NRuIB6slvEH2swrf9GUa oYvFHPbeZFcbwjqgh+ks8vF0wSeKoW7HwcAhjECyJdJbGMGtVPyY81WYhZkEl0cl6yCSRel E7Rr/UY7+s/4etipwIA2iOjoVTnQfx9VwETNR1WvFJqDy/98MvZ90KpX9bcxfaqqL8I5aCC juQ26FYBD6cCJwNjz0y3Pv4eytDeWH9SlQNigQLtiVqPEqV5J0WP6RRMnYiQPjyXnJmZ0t7 lsdoCauCiM6qphlzHNPk8RQR2Cmu7wFBV2i9ky9V0/e2tJOJvrjXEsJdebFhntwEVB4bEk2 mL2lbpnxArRWMcU9s2YTnRe/7ifxgGrK6TQsnMBnppRnznQVg3dLksPlsMcHhIJn1tGjBrj PxpzZ1TstlfcZTL8yBEox5iPGTHdUVCNBpDxFahikOJwUQSdpE4t2DXnxWb/P8U/Wk8h0VF P/hK67Wea3ru0E3j2UunmXwU1GU+Pas3L3zSVQgW20LGUznr7r1Jr3JTQtF46babjHlkijY SSEfBFYAFgNyQ9pYvMMyhg5qmUBjX0pjpd8QEIPebGyAdkl6vALi6fbeClyPbKcITZYvsuG G68ThD2JTys0xoHkyZ7GxCJexBnN4DC0HMN+dfby4S+0IdG+xkcNWzw+i9PQsRo0xfPI98L lz4Bj+Y73UjrO3ZFu/pH5ITU8QXBgPLB/2mGVYsZ0qBtA8JblQw1aD8+0tUNJIlWMfS3qLL PfUZn/ndA8jZ+KKqPzaKSp4B8GHBRU0TXQoGgudRJxMdCo+YagapupgxthLL+wMA3Sux4ss vHkQUCF6IS4i3s3+zxrSwbotxbuI0bILPttR09ny4Ab4iuVdiGeGmLGvOZhOeA12qoS/SHm 7fW5b2s9u8mCX5imbKGl/DCRX6OWyDXo+GRtkl0A3CnktjnXwwNGaP7hzD7+r9K9YSgkmNn NXQCMEX5Ckf9qD76haAaxZXrPsnnAJ4dMcSI30Y4P40aD8gXUKtkKaHRZccaPK10aWoq1jf nOiRIWsv/2nekxgpLBbK1XAMtsCw1QE+RpUSC8iQXf9iNVvPE8oHd8YkTdAAl6PzlGC8Oy0 6PQSrnG2zbXal3X25Hy8wnzB8iYitOSc6b8J+rgTkTxIaJXvsMrwKsSwkfsTKHHJg== X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== X-QQ-RECHKSPAM: 0 When multiple CPU DAIs on the same sound card share the same physical BCLK, add a hw_rule during PCM open that constrains the sample rate so the resulting BCLK rate stays consistent across all sharing DAIs. The hw_rule is registered unconditionally for every DAI that has a bclk clock pointer set. The actual peer scanning happens inside the rule callback at hw_refine time: it walks all DAIs on the card, looking for an active peer that shares the same physical BCLK (via clk_is_match()) and has already completed hw_params (checked via dai->symmetric_rate !=3D 0). This ensures the constraint uses the real BCLK rate established by the peer's clk_set_rate() in hw_params, not a stale boot-time default. The first DAI to complete hw_params is unconstrained (no active peer yet); subsequent DAIs are constrained to match. The rule supports two modes: - If the DAI has an explicit bclk_ratio set (e.g. for TDM where BCLK =3D rate * slots * slot_width), the rate is constrained to active_bclk_rate / bclk_ratio. - Otherwise, the default formula BCLK =3D rate * channels * sample_bits is used to derive the valid rate range. The constraint is purely additive: DAIs that do not set a bclk clock pointer are completely unaffected. Signed-off-by: Troy Mitchell --- sound/soc/soc-pcm.c | 119 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 119 insertions(+) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 9b12eedb77c3..e75c343b8d4e 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -12,6 +12,7 @@ =20 #include #include +#include #include #include #include @@ -467,6 +468,117 @@ static int soc_pcm_apply_symmetry(struct snd_pcm_subs= tream *substream, return 0; } =20 +/* + * Shared BCLK constraint: when multiple DAIs share the same physical BCLK, + * constrain hw_params so that the BCLK rate (rate * channels * sample_bit= s, + * or rate * slots * slot_width for TDM) remains consistent. + */ + +static int soc_pcm_shared_bclk_rule_rate(struct snd_pcm_hw_params *params, + struct snd_pcm_hw_rule *rule) +{ + struct snd_soc_dai *dai =3D rule->private; + struct snd_soc_card *card =3D dai->component->card; + struct snd_soc_pcm_runtime *rtd; + struct snd_soc_dai *other_dai; + unsigned long active_bclk_rate =3D 0; + struct snd_interval *rate =3D hw_param_interval(params, SNDRV_PCM_HW_PARA= M_RATE); + struct snd_interval constraint =3D { .empty =3D 1 }; + unsigned int target_rate; + int i; + + /* + * Protect the rtd list traversal. No nesting: this callback runs + * from snd_pcm_hw_refine() which does not hold card->mutex. + */ + guard(mutex)(&card->mutex); + + /* Scan all DAIs on the card for an active peer sharing the same BCLK */ + for_each_card_rtds(card, rtd) { + for_each_rtd_cpu_dais(rtd, i, other_dai) { + if (other_dai =3D=3D dai) + continue; + if (!other_dai->bclk) + continue; + if (!snd_soc_dai_active(other_dai)) + continue; + /* + * Skip peers whose hw_params hasn't run yet. + * symmetric_rate is set by soc_pcm_set_dai_params() + * after snd_soc_dai_hw_params(), so non-zero means + * the DAI's clk_set_rate() has already executed. + */ + if (!other_dai->symmetric_rate) + continue; + if (!clk_is_match(dai->bclk, other_dai->bclk)) + continue; + + active_bclk_rate =3D clk_get_rate(other_dai->bclk); + if (active_bclk_rate) + goto found; + } + } + + return 0; + +found: + if (dai->bclk_ratio) { + /* + * Driver has set an explicit BCLK ratio (e.g. for TDM where + * BCLK =3D rate * slots * slot_width). The only valid rate is + * active_bclk_rate / bclk_ratio. + */ + target_rate =3D active_bclk_rate / dai->bclk_ratio; + + constraint.min =3D target_rate; + constraint.max =3D target_rate; + } else { + struct snd_interval *channels =3D hw_param_interval(params, + SNDRV_PCM_HW_PARAM_CHANNELS); + struct snd_interval *sample_bits =3D hw_param_interval(params, + SNDRV_PCM_HW_PARAM_SAMPLE_BITS); + + /* + * Default: BCLK =3D rate * channels * sample_bits. + * Calculate the range of valid rates given the current + * channel and sample_bits intervals. + */ + if (!channels->min || !sample_bits->min) + return 0; + + constraint.max =3D active_bclk_rate / + ((unsigned long)channels->min * sample_bits->min); + + if (channels->max && sample_bits->max) + constraint.min =3D active_bclk_rate / + ((unsigned long)channels->max * sample_bits->max); + else + constraint.min =3D constraint.max; + } + + constraint.integer =3D 1; + constraint.empty =3D 0; + + return snd_interval_refine(rate, &constraint); +} + +static int soc_pcm_apply_shared_bclk(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) +{ + if (!dai->bclk) + return 0; + + dev_dbg(dai->dev, + "ASoC: registering shared BCLK rate constraint\n"); + + return snd_pcm_hw_rule_add(substream->runtime, 0, + SNDRV_PCM_HW_PARAM_RATE, + soc_pcm_shared_bclk_rule_rate, dai, + SNDRV_PCM_HW_PARAM_CHANNELS, + SNDRV_PCM_HW_PARAM_SAMPLE_BITS, + -1); +} + static int soc_pcm_params_symmetry(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) { @@ -903,6 +1015,13 @@ static int __soc_pcm_open(struct snd_soc_pcm_runtime = *rtd, if (ret !=3D 0) goto err; } + + /* Shared BCLK constraint across DAIs on the same card */ + for_each_rtd_cpu_dais(rtd, i, dai) { + ret =3D soc_pcm_apply_shared_bclk(substream, dai); + if (ret !=3D 0) + goto err; + } dynamic: snd_soc_runtime_activate(rtd, substream->stream); ret =3D 0; --=20 2.54.0 From nobody Sat Jun 13 13:32:57 2026 Received: from smtpbgbr1.qq.com (smtpbgbr1.qq.com [54.207.19.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9347C3E9583; Thu, 7 May 2026 10:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.207.19.206 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778150006; cv=none; b=AKKH48Gm4C1fuWsunAz0lWIZxudH4rRowtUeKicQDs9h+kRuuWOJ9a0uNS6MgOHaYIv/JK3y4EH3XYlPbMMT14ZU4W0LDW0A9wXCW5bWkJvlV+jDL67FCLiMekjkUva+pV7KcPQYLCNcyrPqeMto6TH0vlJ8F6mVXdoTc5aPRTI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778150006; c=relaxed/simple; bh=vQLn7waS5YQShQIUWXO/tsFA0LGDPoWmjlUPJzVL2Q4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AE0rCOG62alPKi2dOnBARzninn0rFB1imxTusAUr6faRgs8ppfvbXCccqQ+sYbG0DLsNybpvuOMkaRpNvu4vS4+/ZH4ZD8GVdM9kNDHvvT9SPkzRzJTg4QIzhyxjm2hf/gfXjx8vxh8SXp1OZLBo/La1lzEyIqKH1q9bcLJkqBE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=DQ67tMfQ; arc=none smtp.client-ip=54.207.19.206 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="DQ67tMfQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1778149930; bh=pQljPH2SNh4kcf10v3g04g5z8vj9T67tuB4m1YPTOcs=; h=From:Date:Subject:MIME-Version:Message-Id:To; b=DQ67tMfQt2nVkeUtu7pkqzs7/BxVYCAyMg83E+UpleKwW+u2zR/3aU01u2SgBT2Qj UbhCz7DfpklbK2eF7PKwNSyQw232o51Cbn9J0caYR3xsT8ZH1Ssho3+2UZ94ReVKbu D07fYvKYpiMq5CS9J6cH45q8417XY9FgaShrlthc= X-QQ-mid: esmtpgz16t1778149922t616fb49f X-QQ-Originating-IP: ZoX3Gp77KHWkLJluBCp8gr3bverPKMUZMDDEvbhk92Y= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 07 May 2026 18:31:59 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 6853165117422555071 EX-QQ-RecipientCnt: 11 From: Troy Mitchell Date: Thu, 07 May 2026 18:31:44 +0800 Subject: [PATCH v2 3/3] ASoC: spacemit: declare shared BCLK for cross-DAI rate constraint Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260507-i2s-same-blk-v2-3-ede05a22f732@linux.spacemit.com> References: <20260507-i2s-same-blk-v2-0-ede05a22f732@linux.spacemit.com> In-Reply-To: <20260507-i2s-same-blk-v2-0-ede05a22f732@linux.spacemit.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Yixun Lan Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, jinmei.wei@spacemit.com, Troy Mitchell X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778149908; l=881; i=troy.mitchell@linux.spacemit.com; s=20250710; h=from:subject:message-id; bh=vQLn7waS5YQShQIUWXO/tsFA0LGDPoWmjlUPJzVL2Q4=; b=qO7xJTfmls5rv+Sej0SDVlp+b2NxV9JkJtCl9/EnoSmwclNgtLsf/45QPqg2kv69zoCKugnwc DNE0dq3veanAeExZctoW1h2bLmlJnk4VJVeAbXZsk/C+9i3rncerE9M X-Developer-Key: i=troy.mitchell@linux.spacemit.com; a=ed25519; pk=lQa7BzLrq8DfZnChqmwJ5qQk8fP2USmY/4xZ2/MSsXc= X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: M+Qa/yP3m2vGxZObmf0tSQ5IXLs5+bu4O2BJ+MtKHN+oC0mV7HhcBw3X RbifP3pK8/eyhXqktSACiSyGOCKVjBuopawxmAbXSUFuTjnFbym/3+b0zPyomBgdE59rm6a OuijhJWL+t+VHcoXENVMWYiFkv1nZLMScH+SKHwxfjNm7vd09x1TxomQERY6SHdYKQItpKT /nh1rmeqnk0Qpp49wwZd6hse1vPFLSnFeMw3wWN+bS6lbnZwnQ+AfzfVgWaxcLi5SSwFQFl w5wiPUlb61mfV9JVhsoxbG3BA5QazLpt1w0alpDDxBKxGbqrr0eeiADumtMvj/aEgVdPMwC fGCNWfyzQI+ZCAY1ROG14Yb9wEBE2xPE+mTZgtWIdFaMnruWXhcl5ZLb9f6rHMqUt/DqglR mtrepvnhoPCzxyAF3Phl8aLoVRoKN4i1gyVYY6MqvaVe7dmxLn4EnjkVN0zqtaxmawysRsO nWbiGcfxE03RZAZznf0or19aYp7g6yFN2ZhY5n0lMEtZmmz1ww5LNVlkz606Jg327nlEUKU 5nczLfwrHcjAAOsscnTdqEkQ1NGjPNM2ygxhNlkcOupOAmp9zlVePRncDzNRfWN1sVNPQhv 5JIXphuIi8h/0wrKgJNlPvbpl/6VU+bw+h0Nt2ps93gwam+D3lXiztCs8xU1B+boXzxt77T gAJH/TFDb13MGhkOR/guPm+saJ4CxdbYsv7IHfnjVBJXGnRJVNVuwjSHx8VSx4yFM2eBHh0 LL3Oh9JHe9tPGk5odLG4eyN/Dwhcsrnh4UOVCJMyc36NOBrHMqKaNXLAMi2g5SJBndyl/X1 cX9dugw7YdVL0MwsiSTc3OEEgkkFGIhn1P2nAf7GeAHgJFALdglb4hBe/q46vZsTM+c3ozP F22lIexSPRJzPmRjHehI3HymQEgnOnkzaD27FU7TcAtiyBv97XIZxdLV10Hpw15HXGIBpWI bf3o+hOH50Kesg2xvljrqnPM0mphdtsdIVJLIVdXVTrjjbrSgIwLSY9s2wHtwHFYdUeqXjI qWFjckjtuzEfx/M0amqhUd9rnM3wY6AxGV1V/wvW1xMErKuN4gOEVjz6o62fLYUytw56UQG v+unoVHOP5jfAiqLFxyROIix/mCoqOo1ltEpPbVw+P2NNO89hOYMKzxceYDwU08Mrgpos9l 1/GD X-QQ-XMRINFO: NyFYKkN4Ny6FuXrnB5Ye7Aabb3ujjtK+gg== X-QQ-RECHKSPAM: 0 On SpacemiT K3, multiple I2S controllers share the same physical BCLK (c_bclk). Declare this clock via snd_soc_dai_set_bclk_clk() so the ASoC core can automatically constrain hw_params when one controller is already streaming. For K1, c_bclk is NULL (obtained via devm_clk_get_optional_enabled), so this call is a no-op and behavior is unchanged. Signed-off-by: Troy Mitchell --- sound/soc/spacemit/k1_i2s.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/spacemit/k1_i2s.c b/sound/soc/spacemit/k1_i2s.c index 4e655d714623..989e82b3c5b4 100644 --- a/sound/soc/spacemit/k1_i2s.c +++ b/sound/soc/spacemit/k1_i2s.c @@ -306,6 +306,8 @@ static int spacemit_i2s_dai_probe(struct snd_soc_dai *d= ai) =20 spacemit_i2s_init(i2s); =20 + snd_soc_dai_set_bclk_clk(dai, i2s->c_bclk); + return 0; } =20 --=20 2.54.0