From nobody Mon May 25 11:55:29 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11021105.outbound.protection.outlook.com [52.101.57.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5A4C33E35F; Wed, 6 May 2026 20:06:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.105 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778097965; cv=fail; b=dSlmek+PWMIfTerEA1Ki8UOvKXt+V+vFDUAnp9wKE3Usc7dUFe4cW6/ZYStvaWdYrHBe/c68IRQdypQ/XdregU5pw5qVrURYzw02BMleEcaVk9P8LjnfiisnkGdYxDVKMAaexgBDgPGHnIhf+aXNzz6em4/mpTWFivKLhC7CzN8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778097965; c=relaxed/simple; bh=HDDqXJfCk50wsVhemjiiKC5z/K03u60B7PTh0vgiKu8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=tsxjwjGgeDmmP/TFDm0HutWyXIvz8MhV8AlVdWrYzmZ/BBejveTU9HOPeiECd0yWx3qgrWt7LkDNqVY2TgucXBw3mo0NzjDTStKletOjrVrCjtnbz00HjfH+RPygdiJz82NWzoRHWeAs3eGR9yyXDA3kAv/8dMlVJbKogwSs9is= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=in-advantage.com; spf=pass smtp.mailfrom=in-advantage.com; dkim=pass (1024-bit key) header.d=in-advantage.com header.i=@in-advantage.com header.b=OoaJUyvr; arc=fail smtp.client-ip=52.101.57.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=in-advantage.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=in-advantage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=in-advantage.com header.i=@in-advantage.com header.b="OoaJUyvr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XihWMxU2lgB3Fa9I6fHhis+W7B0Js15z3qlj+HazCBmdlHoCPdalIbzce2pyWB2eRVTOwYOl2A6kXhJRAe0TEzfk88iPzjyqPtHxDDo08OnkA/e3H16xTibnk1iOwNTlmjr6oYQ7VI6Wf5nNBp3dvxqkLmEszayLgdkXemUod/wVItFhGY6wMw5AzPeuvTBecYhANZThP1D/7Dab/d6QICCL6b6xamVww0VQl795zetq86jnMAMgQdV3wssxeumbE5ygAc5WuVmMS/1N2nF+DcIbkKxnD8dgfmWNhPgnZ3dfpEm7B/T1NnGOczT/kGfOA39SjHuBJzsXjRXiD3kZlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gb4kjh2kj01KXsyYCRkyUWgbL9JI4HVFvtmm47Kfad0=; b=Z8k9Cjibn/IHTD0me0DM48ck4NIOCWF5fhpYoNmGTZzIUqH3vZvIwfXHKWIqZyCC+DksVwv8SCOx9TLv2myDrhXd9LCgWZ4Fehg5kfrd8XkthcyXicytvHXQGHKCX/MYryGgdwvd40hv8meIPL8OxXv0LeDBodsJjsZUoLMkuhLocKfMWibgvAdonBYha5r1OA90VW4pWwKIutb5OfArqDTV7dzwS501D+XnET6CVCd9DroEiqgirg0cOuK2tTBq0fwPpQ37YEhgqlEgNyA/C6p+pNbNOpyX18f3a58kcaIvcK/Yy4oeAClppgy/nDqk3G+fy0cmONKiNUXvYrskTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=in-advantage.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gb4kjh2kj01KXsyYCRkyUWgbL9JI4HVFvtmm47Kfad0=; b=OoaJUyvrgOuk3vKMeKriixCLaZRdEEXPDY2ukqyMouM7Qa+1dqgwRla/Iskq8sMFumsRT/dMj5LMaI4gcuHb1s+eLAQqr5TSs91TytOdjEuNvCI/gZjkc4Bi77JqG++ktlT1DLX9CXzrWI59shpqgvi7cyBCXYmzknxrjOeHQKA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from SJ5PPF2BB505D96.namprd10.prod.outlook.com (2603:10b6:a0f:fc02::796) by DM4PR10MB6278.namprd10.prod.outlook.com (2603:10b6:8:b8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.27; Wed, 6 May 2026 20:05:59 +0000 Received: from SJ5PPF2BB505D96.namprd10.prod.outlook.com ([fe80::5876:2319:6c09:9a2b]) by SJ5PPF2BB505D96.namprd10.prod.outlook.com ([fe80::5876:2319:6c09:9a2b%4]) with mapi id 15.20.9891.008; Wed, 6 May 2026 20:05:59 +0000 From: Colin Foster To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Cc: Brian Masney , Shubhrajyoti Datta , Michal Simek , Stephen Boyd , Michael Turquette Subject: [PATCH v1 1/3] clk: clocking-wizard: fix clock difference detection Date: Wed, 6 May 2026 15:05:53 -0500 Message-ID: <20260506200555.2558434-2-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260506200555.2558434-1-colin.foster@in-advantage.com> References: <20260506200555.2558434-1-colin.foster@in-advantage.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0069.namprd13.prod.outlook.com (2603:10b6:208:2b8::14) To SJ5PPF2BB505D96.namprd10.prod.outlook.com (2603:10b6:a0f:fc02::796) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PPF2BB505D96:EE_|DM4PR10MB6278:EE_ X-MS-Office365-Filtering-Correlation-Id: bd52b037-48b7-40f1-2ccc-08deabaae420 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|56012099003|22082099003|18002099003|55112099003|3023799003; X-Microsoft-Antispam-Message-Info: CCWy4gyjkRM1eETnfXKFpJh1QnNyWpV2IYhZGV0954YIzmwxo/XmIxh+QbXfnlwzQK2/+RYTCPFfdeYXfgs3Qh5PtAWxVXLn7vuU9o2Srag9U+QI22PecuGWEi66edxUqgM8jorB//7hSHER7X8CNNp9yFIZZBPPdcHjdyMaewyQbzAZ7+8BZimgDFrp6IxCZqZKfzjjbvA3Uw0NhhJvfORedXK++CPRC0htTkwDP+WqYf2CgrGm1r3skQ+RZoenLIRP+JuEv9JcliFWcxIx4rGPUuYouVo5GrLIPr425M59GGL7VeWNgegdnNGGM3/qUPYD4vYPPMNQbux7GRKcX+zzaT0SjB/HiOvCULmT7a9mUqAtdmnsriM3URPxvfRfzOw5IdQHIYnQHUqj1J+Nq5SaLA9Nzy5Ft/2dqxyh/c0XHF5MIf38urqdG6YGjo5bGfO6/Eya0B1vRfeRF4KlrK7rfFusFSCg1WhBW4dZPjX5WTa4LZWsH+KtPIqEHdgFongURCEfqmR91hv3yBllKn89hZMTCPaKcycMlksYvEwmt8sYUuSRld8qi6xd9g2ruGx3vt6b6w4qpgSBXq01MIkxJmoZO4FrcSvuMy6LDSJtFI8Lz0ApWVuEhKOEnqHT+CXyZmxdxy43L8vYY9G4iCUeyNr+6oqjcVCzYe2/+PhJrg9ovLlnMvHFLBvITFpl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ5PPF2BB505D96.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(56012099003)(22082099003)(18002099003)(55112099003)(3023799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3qHlOfetnHidDMmqepVNZU1oIcDyfxCeG/2DzwvlqUlwj6EKipJESmAa79ZT?= =?us-ascii?Q?yriFe3D8nkAtQcGbf9mldhjmFjGicv/a6UO4/Ahy5UdFhQM89+lK9TaEaFNO?= =?us-ascii?Q?XYiGOvj8uR0mcrXf72fNPRS8TunbrT5kkcyQ7qX2B0uCv36Ee6fd5vJ5eiBJ?= =?us-ascii?Q?zNFnn3+epTcldB1Eajo5erVSzRVRu8LsL2sY8TZCsmrRfpE3r3aI64bbDxP8?= =?us-ascii?Q?PehsQ2aRT/krYNx2hY9SHoNO10We7K+2NuSJtcpYum1Rix5bcFxz2sEuB4Uk?= =?us-ascii?Q?9V2sB6+jjpnzRf409KfwTudQWqckzvHnL1T2JY1NAtdJKT41i7NaMNd5yNxM?= =?us-ascii?Q?JCmwGP60ITXI8iUPBBwhBNUBQC4imVLd6dh6hh15VO5u5U77zosvm8Xazb7M?= =?us-ascii?Q?amNEbQ2R8uyk1dKffKcqGY5YuIbzaq4FOXtHy1szj2Gq0Q2m2t3qjeD1+i3W?= =?us-ascii?Q?Ft6arbilk885iFkSrJjzDvOUouEBQaSrz5o48sYVJyGo8iFVN383smtJE/8u?= =?us-ascii?Q?I8juHNYZgf9eUgsjPe/p5MjWjuM2VDLJtZ8H9o87vDC8+EM9H6IT1PnGcZuW?= =?us-ascii?Q?7IX277yY37+hRf0VnqhI8jsMWzpwEk2qQcarn6zFUfdqUsOqoT2m6K9mQsuJ?= =?us-ascii?Q?h1CLn/+Q8EJj/cjgo2hOd7hgqClYsKCyN7O2ClVuATrn6phiHzlC4P+77Vr+?= =?us-ascii?Q?h1+OCSjlfOu0IYblhXA4ZR+89jJfkmQGlndDtxMmw9rlXrQ1tT5tBdWNwu9y?= =?us-ascii?Q?BNdrv1kums/tW1QvsXADfT8jwpUK+lzlfpDBdiwcuqcCzKZBfj4xGKHGuh6d?= =?us-ascii?Q?t902VvQE7nZ/8ZSqVyh4O4W9RjY/tcq0aQksw1sPhsscISlHQi1hD5llTnql?= =?us-ascii?Q?mMOduLrLLgIwmRHYteUB+YDm0sdVkUEOFoo4FY3lIYdGi9k4cHwBD0smwOa3?= =?us-ascii?Q?KDa4MZ+yggTkzefSpGAu/bjyNec3E2XBiZL7K1Vw/g5gI3kmotZnxVXO8AZi?= =?us-ascii?Q?RdAl9GTflv09RJTUB3qKJXAxEMjDORD2lwt8xZjwXUCKND3CNtiklYwhKpl+?= =?us-ascii?Q?qKwFB3FhXxFaP+cvtfCTSpQ8uNkIITG139Er9vXuqQVzaVn9C/5uu2xr64GW?= =?us-ascii?Q?gFZlua5RTbQIOqpNg7QGi0C/1agoXd0AVBTD51BYpqrFlBX2cOeug3OJFAx8?= =?us-ascii?Q?+rF00FExL40RVWyngMWhWrVtO1AVnkSHShBwHHjaP3/4CERsra7OtzYb/JP/?= =?us-ascii?Q?iFk2q18s9NigSWHsgJurE76/mr5t+txzpZiumUARJ2igtYMrSkh4evJzwph2?= =?us-ascii?Q?eSoMQeqGA+hgUm9nSzlKGMWLX4T3CJ7AcDdxqxdMMMVOB7XHas87MXUBz2lO?= =?us-ascii?Q?RgoUONPWqmyZCsQlFL/82C0K8tM6BBnHxT8TDx2HR62jmSJTLWESRtzZaGhH?= =?us-ascii?Q?FoWnePcTm5zJw5wHMe2k9Xw3fRC6bcfWPzBYoajLw9N7y2quA/obLrw8saEy?= =?us-ascii?Q?kfJ/K0fgqHeOThXNmxd2ugsZ6WReS4Pf+z5OaSk/LjLPpYSeQIyFSOvu/C2s?= =?us-ascii?Q?2VvPOenpbsWcI5n521+Lxv6aIU+sOZ4jtKnDGLX6z5tIC4r3oWdeNGSt49mV?= =?us-ascii?Q?V06+ZKz9qAHEHBqFewM64m5n8yqIuFU5YoK6N+z1fsTvEC+tSoSAiJJvMZc6?= =?us-ascii?Q?SO4BcUzuxc3mAQ5Y+xEz+A+jOztVV9X3Dk9VIpR43FB1rInKp0JoBY7wchr1?= =?us-ascii?Q?d8ZODloB2Qxw6s3vyeltARU/0Ifw6ls=3D?= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd52b037-48b7-40f1-2ccc-08deabaae420 X-MS-Exchange-CrossTenant-AuthSource: SJ5PPF2BB505D96.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2026 20:05:59.5311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: upDGinmr1UCajO6MV4tV7/rNCveT3BavFRM/r7vt8EyBpmPujfOeNZQMXBX2fSfE4L16yNgaGufGmYOBk90NgSgZWzxRdUwa6Ilc4wj/Reo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6278 Content-Type: text/plain; charset="utf-8" The diff calculation didn't take into account rollover. As such, a target clock frequency below the requested rate would not be considered. Before this change, bogus diffs would be used to determine the closest possible clock: 8<-------- clk-wizard-test: requesting 133312500 Hz on output 0 (clock NOT enabled) *** Clock wizard - Matching for rate 133312500 parent rate 99999000 m =3D 33, d =3D 1, o =3D 25, freq =3D 131998680, diff =3D 18446744073708237= 796 m =3D 34, d =3D 1, o =3D 26, freq =3D 130767923, diff =3D 18446744073707007= 039 m =3D 35, d =3D 1, o =3D 26, freq =3D 134614038, diff =3D 1301538 m =3D 36, d =3D 1, o =3D 27, freq =3D 133332000, diff =3D 19500 8<-------- After this change: 8<-------- clk-wizard-test: requesting 133312500 Hz on output 0 (clock NOT enabled) *** Clock wizard - Matching for rate 133312500 parent rate 99999000 m =3D 33, d =3D 1, o =3D 25, freq =3D 131998680, diff =3D 1313820 m =3D 35, d =3D 1, o =3D 26, freq =3D 134614038, diff =3D 1301538 m =3D 36, d =3D 1, o =3D 27, freq =3D 133332000, diff =3D 19500 8<-------- Signed-off-by: Colin Foster Reviewed-by: Shubhrajyoti Datta --- drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilin= x/clk-xlnx-clock-wizard.c index 032a688840d8..88b47b8cc387 100644 --- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c +++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c @@ -408,7 +408,7 @@ static int clk_wzrd_get_divisors(struct clk_hw *hw, uns= igned long rate, if (o < omin || o > omax) continue; freq =3D DIV_ROUND_CLOSEST_ULL(vco_freq, o); - diff =3D freq - rate; + diff =3D abs(freq - rate); =20 if (diff < best_diff) { printk("m =3D %d, d =3D %d, o =3D %d, freq =3D %llu, diff =3D %llu", m= , d, o, freq, diff); --=20 2.43.0 From nobody Mon May 25 11:55:29 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11021105.outbound.protection.outlook.com [52.101.57.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D60C34CFDA; Wed, 6 May 2026 20:06:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.105 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778097966; cv=fail; b=j3aJZhV4/msR3uRftPgzKKDkqBgL2a6pZ9FP2GKmk5Va3uh4NtB6Yjqyiw9Vso9T54NingBO5TVgMvGzCiZTH/xhKrMYCWudQuSrU7kIfdR6Z6PaxA8dC/J84ljaslkD0li5bUAqpbTqGfNJW3nzp74QE8J9C5KJX/o/cSkE9g4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778097966; c=relaxed/simple; bh=aCXy/ykOAQTWXmalKAIgntBRqF/4xdlRXzyzRdysC4E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=S4yk2fF3ySib5lNLPTvTlXkfFMpeCCcIvGEFvj2BvLQykD5Fgg85ad94c0/ZsYrXg+vR0Xt0miKzI1nE2DtlLdD12ptJpL4tQi25ztagVCe7NAs3NhjctrvEUbj7cC4TY+DnwQxz1BmkSGRGMGSuPkVWi3OEP9SnTRSAhJDRXeA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=in-advantage.com; spf=pass smtp.mailfrom=in-advantage.com; dkim=pass (1024-bit key) header.d=in-advantage.com header.i=@in-advantage.com header.b=apnS/dQm; arc=fail smtp.client-ip=52.101.57.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=in-advantage.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=in-advantage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=in-advantage.com header.i=@in-advantage.com header.b="apnS/dQm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F18E5QgJ9mTYP1aPx28MQNCzstSmNNGdOKfVT/6LDsYxHeCy+stBKhprcU/nt7G65w6OfPX5NEPrC4VwGz8TgsHcL/Od5FUIYjn/MKsYkRxuLPzE5m4IoOBUiSsvR4PWVvwl2lxrRc2ykUrIOorPGB/WXqyitWhiol+UuClY2Az9cd/GnW6hE4Iw9VZTs15l37DO7Y4L7syBgkqDJMpMjKACOyMyHfdhNquIjf3zm02XxD+bo3OLBW+UcCeCBKT2qwa3mdGAo3JDxxz9PdzoyfB6B0SGKsrWpNUdsDu4NvxF/YHKBmwqEey5QYYNOFZfyQ/srXSV+N2zGDdgo6w06w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w1ifcvzeF6tUAEk+T5o3m9r3y4zNqOwXGodJWBnwpNc=; b=yESvbgtYrr3t3kgaBBxBFXwRZMwuu1gFcQRlHZ7W+pPZKbD0BNq/FjEOfdBGnK59jRqE8de1YYCcbxKVUBdG70UQNgPssF3WBnA9cLkSZdJMpfNaJGIiee46zK+HtxPOT/yu4GWe/GEq6r/3YOFgFWicbqC3fjRWQmrds8GYquBmU/p7FrcIbD7/DWYKpAcVFT2i0TDfXkU9ohDMZWp6iJMlUzEeV4g/LPxEkw8rDdjM9rAJV4AK2m2KJFGPfXtwqDHPORgI8/lKJI9dMn8t8RDjc2BMU04+MpiO8s+7uk0qfKTkRQCz/xMU99pKVBR+I/I/tPuTVcytFA+3olC/BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=in-advantage.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w1ifcvzeF6tUAEk+T5o3m9r3y4zNqOwXGodJWBnwpNc=; b=apnS/dQmgQJTLgyqXoQ2P3ZIBs9W6Xs9esLwmGGCOSSVhnDAZRYbvi7QD3LcUPtn/5iK6llVYAqr9AOOcsFigkLAO58K3h2UDf8DC1uULaFbUwb76CfHHUstyflXldlFVDfQpe7JftPOmlkLAcftO5AR16y2b0rhGm+AhBLFqdo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from SJ5PPF2BB505D96.namprd10.prod.outlook.com (2603:10b6:a0f:fc02::796) by DM4PR10MB6278.namprd10.prod.outlook.com (2603:10b6:8:b8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.27; Wed, 6 May 2026 20:06:01 +0000 Received: from SJ5PPF2BB505D96.namprd10.prod.outlook.com ([fe80::5876:2319:6c09:9a2b]) by SJ5PPF2BB505D96.namprd10.prod.outlook.com ([fe80::5876:2319:6c09:9a2b%4]) with mapi id 15.20.9891.008; Wed, 6 May 2026 20:06:01 +0000 From: Colin Foster To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Cc: Brian Masney , Shubhrajyoti Datta , Michal Simek , Stephen Boyd , Michael Turquette Subject: [PATCH v1 2/3] clk: clocking-wizard: optimize clock search Date: Wed, 6 May 2026 15:05:54 -0500 Message-ID: <20260506200555.2558434-3-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260506200555.2558434-1-colin.foster@in-advantage.com> References: <20260506200555.2558434-1-colin.foster@in-advantage.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0P221CA0028.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:52a::16) To SJ5PPF2BB505D96.namprd10.prod.outlook.com (2603:10b6:a0f:fc02::796) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PPF2BB505D96:EE_|DM4PR10MB6278:EE_ X-MS-Office365-Filtering-Correlation-Id: 00bea0fc-57f2-4fd6-2e3c-08deabaae586 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|56012099003|22082099003|18002099003|55112099003; X-Microsoft-Antispam-Message-Info: xhb/qBLmOa4qoaf0Wg9x200IN5VEn68sJYXOcyYiy7/xOR178SEm/GkfZ3JGPco79qz8kFkPwbAMDU3PDFupVM16d2kZLxVkeyXz16BPvl2hqPXChm5wqNbQ2O39oU9V5CGefBj2PHbjuwj6iwP6RNR88yhBoVQy0vBkEzrFuS9zL5wN6IAJII0uf2bF3Kp/901wL+o0cYMPE8BUVlU3NyyEEdKuBXDqMjfdLakkD4N1czgUA1OSUpNK94BeJkSAccNVnq2Djo+w9afRSpvGv/U7/ix1Q0l7s59+WssmgqoTdz6SCmZcBrj1NN+6ya8s0YFZeq7dkm0QImIN8m6NjHRl4hcV+4SSOqg2wjMCnmM1bNblmnHUVCBVYccBxMXN1whL2X9BUJA6WHzvmF8Qu9kFlwuxjd0la7heTrnuoZKIxBouqvJr8Q0TPJvGeiCBzG1JG3LE+1fuFww83JyQdt/iXArMEx0F0LQn6OLF4R0vr4SN5hs+/siicWeUQCXCgW/oejGiK6hfDhqiDqxqhc0EcnEQlhg8yeDNfexUCBfe2+hmmyNrY8YAj/wfu/Wpbde9K1tav4u6d1jf0ZOt1NNQDm3wp38BdV2A2fuaUhonTmKaV9buf+xcoR92LTDfmOu8qTo2v08GOa5mpJkaEY8YPy9+gTJLkzIJqE9ZXGvslBy6sgRTuQ3g6NZeBc3f X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ5PPF2BB505D96.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(56012099003)(22082099003)(18002099003)(55112099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4EMfohdT4bxCVkUx5sK4np5XFFGVps71n80hn4oTYaloBTBz19Y2a440gasG?= =?us-ascii?Q?ROGZEOJ/SGe5vkOZVk1yPfQ/Vt1WYcCK2DNl4R0whMOry940kLahFrDz9YyS?= =?us-ascii?Q?NIWJeCenL7xezjLI2rPy+qs1fFTdekPqj4X44Hfkqmxf0o6yW+YcuoHjsi3f?= =?us-ascii?Q?U8utRYrYFGrIVhriiZQy1w/6R0ikJVY10ouQHg08GEHjBc2ec5Ux/aOifvU7?= =?us-ascii?Q?34PuHiJJPzyfuLP5p5+dZiNqIJXbJkbc0T1nSw6ADmRuaUW/we4VGGTf7s3D?= =?us-ascii?Q?5ae+kxjd0PmR6OpFLbhP8KMcx0HTV3EQGOYonxjF1hHP/gnY3M2hfjqJAw0h?= =?us-ascii?Q?p9QnJh9Gm7yarSYQBhJHC/WBR6QfE3/SdFaChnRXB9NkaEzW66FWplR86fwW?= =?us-ascii?Q?uRytXtRZApUZmmUCb+eHy7j8VUh8HV729h/T0a7z1Owp1HtpQOpDViBPxq5S?= =?us-ascii?Q?Yqde+7ARaRx90NgIeAP/SLTzPQ1nOzHYiHW2YU7fi6S0/YaRzw4sxh95Uu5i?= =?us-ascii?Q?DZptpALxKlCODuhrG3JgtzSTXCsTLz9i0vypeRNuUJRBdQA2+3qF9DwtN6Qx?= =?us-ascii?Q?CS/7eMiT8WUgmr403JGDSBAk/1cAs/ThV+Jbp2w0GZcyMrPmzLRYVF9xawPN?= =?us-ascii?Q?T9K55Ii1b2lGtiuO2j/NO3uxZZnOf9sDO1VFt2weSVyJxCKcPXFzEnIcg0lw?= =?us-ascii?Q?a8H1dyQgJ74iQDtbggLJoijANR65hybM7LQaUk5LKtEnEnk3uJR8l2OrdWOX?= =?us-ascii?Q?d1fmUjqPWxelYRzOrBjEZBTE5/6s2OXkSxKiwluR6+rQfq5gZrJcgALeeg0d?= =?us-ascii?Q?RaSKR0S9mJ7UgprNrsrvDZrJro0EmHqts6jMTefAVUWBRZNBMLwA+Wt9G6R+?= =?us-ascii?Q?wdZILNnNtvVK5au1s3b8P4vyXlFhf8Nxh69vlTsP+oM6E52TyFc+0EWlnusD?= =?us-ascii?Q?dXlox6bGFq2JWIxlVAQ2dd5/08rZXcmfMZBsMwIjBAHbKecOhUvmG+3Kl+Uv?= =?us-ascii?Q?hubfTgpc9UvPxSLHuKNLWBbZs78m5RCG6YuKW/OIWsDhiQVTDCujDwwajD7K?= =?us-ascii?Q?Ifd6U5fUNrSPpJ0bDrJrr5g59Bv3qS0313wHwRBjDXe6ycBtvT9pnV1OS7vI?= =?us-ascii?Q?E8mZb4BHOY0uPfWfj2kLl1mK2YEI9o4crkJ8KBOUb8caf6htImwvMzqqNFJC?= =?us-ascii?Q?9INC4mS2l1mZU60QuLE0LFjq2i5pIX0ZxvD8XS7TnQpMwDX74hwLzdGYz8Jm?= =?us-ascii?Q?5IHqKvis14TjcVHy9hN/oK4kvmZskjUecmv4HqDRkrnGV1sUvQcaUyQ//GnZ?= =?us-ascii?Q?NNcTUJ5hcyiVdZiEhK6edxLE7LJnQfTxMgXhTpZkCvUWfH/VAdEocGYBJS7Y?= =?us-ascii?Q?rXSoe/z075f1hL/5f+tnowmGt8LDbifcE49Fy7iQZ2vfxDuNVvRhjPQUu6JJ?= =?us-ascii?Q?F4KjnL4l6bHopdGSY7Z62MJD2LjxZaz9sFJWAcVKtIv513GsJ2x9QukGiN4F?= =?us-ascii?Q?j9/5ebemURbHUS6EZrY5RdqVyxjaZxI8G4lMR58LGV2vY701wzeD2b8JH/L0?= =?us-ascii?Q?dsOtGYNUVS5reJluxTR0/2Xpfj/Ekccqs4GyZBmeWRWdTHoTWpuvQaFYGaco?= =?us-ascii?Q?70V7/y17R/AnqAAr2Z7r2k+zg+dL+u88U9/xsO7kVKgS2/h6Len/msbUu3Dl?= =?us-ascii?Q?MV7d4hbCeH0PTc4o0jc4BizGpyMmsm+AV7qVUXcSjf8NyQOqCgbJ610zQYOQ?= =?us-ascii?Q?WvwS/EYprcYPdwrkNtJHZZW+C/x6ZBk=3D?= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00bea0fc-57f2-4fd6-2e3c-08deabaae586 X-MS-Exchange-CrossTenant-AuthSource: SJ5PPF2BB505D96.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2026 20:06:01.7948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VcNHKMWSjrC6l+Nkt86gz3T5QqCEsPRzQfLbXg/Qkdrupm0diNMo3Exb5mWC934fRo2kec+gfUuUk5wIRYT4WrBGP9sSEbx/OLCfBOvBFnA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6278 Content-Type: text/plain; charset="utf-8" When an exact clock match is found, there is no need to continue searching. This process was optimized for versal as part of 'commit e0a94c6bb5b4 ("clk: xilinx: Optimize divisor search in clk_wzrd_get_divisors_ver()")' but that logic wasn't applied to the non-versal driver. Apply this fast-exit logic to the non-versal driver. Signed-off-by: Colin Foster Reviewed-by: Shubhrajyoti Datta --- drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilin= x/clk-xlnx-clock-wizard.c index 88b47b8cc387..d43f20e9ac59 100644 --- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c +++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c @@ -419,6 +419,9 @@ static int clk_wzrd_get_divisors(struct clk_hw *hw, uns= igned long rate, divider->d =3D d; divider->o =3D o >> 3; divider->o_frac =3D (o - (divider->o << 3)) * 125; + + if (!diff) + return 0; } } } --=20 2.43.0 From nobody Mon May 25 11:55:29 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11021105.outbound.protection.outlook.com [52.101.57.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB90834750E; Wed, 6 May 2026 20:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.105 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778097969; cv=fail; b=GXT1nfP2hAe/iuPq6CIdrVpl5aw3VYKyemyMQfU0TwR4/dH1eJw8c4Ud28UWEoZfSKsRtbeDwBaG9UaDC6Ye9eS54ocPybM9Ock9vFdyIBSGq2ymrtNboIkMYk2PDNig/GOuDfDiVSoLgyGcjM/F18hJw0lQn82U7DGZVgJtqE0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778097969; c=relaxed/simple; bh=HyjmlHV74VbeB17FIDNcgQQlH96dWv1JK6KKdltqj2I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=tl6ccO6KBaDzGuxHTTKtEzyhVWS93XAamVwPBRG10EuC4W7Ru9Ieo3fYH+CZBFrstJd/qIfOsWzlYaHhZ3DAZ2yq7Kyudi8T6XlDv0FUtVX0wYS67PLz1ye1ONAnCKx4bARv+TcFZ+v5v1aK4iZvV8WEQZlE93nhp5NH1AFo/jw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=in-advantage.com; spf=pass smtp.mailfrom=in-advantage.com; dkim=pass (1024-bit key) header.d=in-advantage.com header.i=@in-advantage.com header.b=KwiqV+7K; arc=fail smtp.client-ip=52.101.57.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=in-advantage.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=in-advantage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=in-advantage.com header.i=@in-advantage.com header.b="KwiqV+7K" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ebq/jYsTApT9hU03auFSYMhTD3+vtk0b6Ks41ZUulDACLiS3QinC2GnvmkqZiq/kVFZRC1fZiJLTI76RSUek2r7KwIGAf33YFInE97ECo29uJKe2ZxsxNmrSEFPrcHKIjE0c5jOjgQhUf5lgRYJk8AMir2RZmK5w6WbV06rvuXsa0/+IX6X4SCspnQ3gd4lv16CjG6UwM3EPgKfJHtgBZZ2HTyFYriykvM2OgSTZhJj2n+Xt02Y4PsfZh4U+1EcnBmSyXHykoBfspB1FRR7JQ47MOCgUFpPx1z2VcHsgldwJzNjX30Pgv9yhH/XuD68Oxqyg62hSbMmX0rtf7TBHcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aX/6571b/PF8rQfWkyUfOmsUm1JjNdrPprla0WtOnvw=; b=uWbGUfAsv11sinO4/1clAunK5+pJM2PhsMNf+1gnK3fWQKLdT0IHSYDGt7DAqhht6IEIsvOwmsyIB/yu3pi2z09pcENDwusN6w4jB1IsbC+b48SGPjjLARPgFbvlmhdFjgCE+AL+K4SGiCB0UjRgg/AD3+ZGViqTLMpSXfgeJoUG7IalShrH2nGondeu4ourfS1Tb7KYRiCOQj/Qf3KS92uBc6yg4ZsEpkSGgEebzlF95eanvtkwdIJx13WcUSxrfuOxRXhZEtGCBuCePzryTEIQoql0RhoVIcFR7nS/MwWcBz+gG/6+3gfEE57kfEutizRDKeQHE1awMW0ORxuRpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=in-advantage.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aX/6571b/PF8rQfWkyUfOmsUm1JjNdrPprla0WtOnvw=; b=KwiqV+7KjwupoyZMIY8xQ/xJYBeGka6FJplCu+Q951Q2xzwqm0aoz0bu8ZZEPBIbqs47oGFYu+TCwQT9Uzb4cqpYu5guoG5mhqIQMeG4iHXxqz04QIIvTpcdQL5rMrm2yobPidv5iNWBonu4oOu00CweTrH6ht6Y4XkTRIvZrjA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from SJ5PPF2BB505D96.namprd10.prod.outlook.com (2603:10b6:a0f:fc02::796) by DM4PR10MB6278.namprd10.prod.outlook.com (2603:10b6:8:b8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.27; Wed, 6 May 2026 20:06:04 +0000 Received: from SJ5PPF2BB505D96.namprd10.prod.outlook.com ([fe80::5876:2319:6c09:9a2b]) by SJ5PPF2BB505D96.namprd10.prod.outlook.com ([fe80::5876:2319:6c09:9a2b%4]) with mapi id 15.20.9891.008; Wed, 6 May 2026 20:06:04 +0000 From: Colin Foster To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Cc: Brian Masney , Shubhrajyoti Datta , Michal Simek , Stephen Boyd , Michael Turquette Subject: [PATCH v1 3/3] clk: clocking-wizard: remove 20kHz restriction Date: Wed, 6 May 2026 15:05:55 -0500 Message-ID: <20260506200555.2558434-4-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260506200555.2558434-1-colin.foster@in-advantage.com> References: <20260506200555.2558434-1-colin.foster@in-advantage.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0P221CA0011.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:52a::8) To SJ5PPF2BB505D96.namprd10.prod.outlook.com (2603:10b6:a0f:fc02::796) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PPF2BB505D96:EE_|DM4PR10MB6278:EE_ X-MS-Office365-Filtering-Correlation-Id: 26eeeff0-f44f-4546-e71c-08deabaae6e7 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|56012099003|22082099003|18002099003|55112099003|3023799003; X-Microsoft-Antispam-Message-Info: sy/TG32VECDCTijhaLEJeOKh2oD7EAYBY3lxcAOtGJ4uxvHOd3fhwxC7hgOSYabqynQ3Hmzec9rZ3NKNw5DEzVe/1j0WcQhQVQ5hDde+86z2LuXDq+GQ0IRWKRpEffOygs1huxOSb3QfcDMUajPmiN8QftP/WjNyGrJ03RR4ChidszkmoriPdPe7O+7vGfDSkY1KqXcQQfsBAJ/+DzoXcnI5Ij/UyCrZvRv7ayyllCET6pglfWudGjQZccM4w5Y1aQxkslyilh/5gZsQAHj5qeeox9wqiAzStcK79qQwvelZE2IPB25cdyAB5ih/3Hn8kdEguxrpmYJ+q9wMUeqAzmD5neaOSOovXwxk1DRqX+DZh4fdttYriSgQ1IL4QtcloQEtFHxk39f/bOnkusT1HUcpshxeMiOzv1Dc3d8xIgfSD/gru9InOuyzoHco46wh932OkzBNBbDD51M7Mu76tc8Ft2dqow0Wy82ZX8uhTALtSgcm1Ht5ixjeVSxxXURFbF3Cx/K42rWAWBuNmz14VFAFa+QF3wpm3/HEubXW0kTuS6Mw9HMGqxR5BSy0A5VJoZNYa9N23JUifljuRJ+XLW7gqPSBeXTj6CRJgbLpNwWIp7L6DIDr8Y6XaxdJCp9efcYDmTGefkwzlqBw3wgn5UCKIRALuAa/wW+exRkK613jIznroYq4WdmQm8qgDVAl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ5PPF2BB505D96.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(56012099003)(22082099003)(18002099003)(55112099003)(3023799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9EgjkxmPnSrPVeAHsNnm1KMPhNHZXLS9RwLci21pygN1VO+px3IUAyTclzQK?= =?us-ascii?Q?vTKfz1cvHhJ7vqt0G6BZFHA9VZq1vyzAjVshZM4AwIW/c29UhwE3Nt9CFc92?= =?us-ascii?Q?rnOBPPj1WkLKGKxl/wcd/B6kHcv9TnxMQsZOOqjX8Q+DsVeEMiD4URBPWYQF?= =?us-ascii?Q?k1jKgsI5qYB4BM5TyAU5mUleRJEaOkilYNUtCtJRDFp9iN5VgpormWrMaP8h?= =?us-ascii?Q?0aTK32q3B7RQqkjXOUs+T1L83aD5HjmjgX3eXRUVpkUI5GjdwCdNBr6Uq4IO?= =?us-ascii?Q?0wUi1E4zkyPZtxMI0EyfPomGrAXMjd7h00WK/vDqbTEEIsCWDOLRcKRfxePc?= =?us-ascii?Q?WxQaDbHLj6TlZqFCvbOSEmmLIhVgaRFVQ18vUiPN2s6nQhispvoDmS/pBaSb?= =?us-ascii?Q?vv0B2FZ7QpnNcbOF4Hq10zVRZmsP5o3PfRkKTDC4WCzHIE4819ddej42iC6E?= =?us-ascii?Q?kU6QYLYlNFepV7txZQePMDGV+ivDN6Ugi4beuYUx7XIB/jo3Q73cOaudU3SG?= =?us-ascii?Q?TrzPMGh0fSDc/iUCxolm+9vXKWTfqDY18wCexp0OqrGm+/Q4SudeMhnoD56F?= =?us-ascii?Q?B6QbLnO1J4jJzN5EupB1gaKnpBEmXf1HpC4EUF2YY+K1KlvIyedqMO5XCUTs?= =?us-ascii?Q?hqsq75zpUHPGXu96geeYfPkMB75D4b0DnrtHYc8M56m1whcvl9QXWLVhmx4X?= =?us-ascii?Q?gdfpIMt+PxmIaksqunkXBZ98v16T4dCRQr82ycye6hDzo6BcPDaG3k8LIgJC?= =?us-ascii?Q?V7rVWgXnWH0fEfB3IrIf/JBJy8I5Sn78Dl3ednIGHaHzpx+1lbxO4CRqUOn7?= =?us-ascii?Q?zHusk0n6soiQ/PLsiBVClc6WAqBkzBlghXmj6NGt8t06lEBDqp3N2K7saoFA?= =?us-ascii?Q?UkUSMy2VEDmoNCZOpZDRv9tmJml42Kfq5Y4wrkKTthDPGXdoZZUU99seXWlk?= =?us-ascii?Q?qvyawHbcwHRl+xgyR9kg699am1wWHqkZHnJxH6Peipp8EusKGRvGEdf4//uL?= =?us-ascii?Q?1tVNtfSqfZ8JwrgQrBUSEOUsqb4iyfNGw3D3BCUNRai5AAhmmPPMe7pKqnKt?= =?us-ascii?Q?8PjHYmlvCmr9hekDbnzIYb7cohBlfa2ncw8wlgkkVNZYIEFB/T1QyMTuYADq?= =?us-ascii?Q?Qjh8zpKl74JEfTb7qCb4BC2lIo8hxPkwl6rGHj8sEXudPtHsJrViCdGJmjwl?= =?us-ascii?Q?AYzuNWIV7OadQ7gfufJWrp18Ojx2p6NykqmoS+UQYhpVQ/agzHcEetTi+JdM?= =?us-ascii?Q?qvMLfKxZEtx+AABTczzpymOa5AFJd0KRy+IYh94wjYuz4o7l4EWRkpgEiaLX?= =?us-ascii?Q?1X1ZcuKV7IFk3a4BNs3W73C1DwPrV7+8hod2/RB9cpdEbtevNK/bPy/aPIpU?= =?us-ascii?Q?qls15aLp9hGs6FnseDfTcl2zeVPLziB0N3Wit+8TAbx5YTv3iuuplotH9yR7?= =?us-ascii?Q?HwPs+spEh7Hd2f8GijJUc9YdsDTz4YVjEtn6M9OHrP9rmLnmubeLid7UuiE0?= =?us-ascii?Q?sFe65F0c8IkZAvMxBTiyAzpQ1HE3YPDjI0xrPYYhgb4pv347qX8eWy4zp6qz?= =?us-ascii?Q?opxcR/ml/VuarUDa5AWeHBP+Saq5DvqYZP4/pxk2WtVO2ciEjScwHYmAt4Sm?= =?us-ascii?Q?e4ff9HdiHzHetHLtpqJFN2SNPkUQwxIl725F0TmJYuTt/sp6c9dU9xDVFDna?= =?us-ascii?Q?UyX2Q28mUChB2BGZjaectM1uSaPJmbaYbS5pM+DkGwRfeYkMUPqm4jNxp7FA?= =?us-ascii?Q?EhjiHV694K+nm9CzAYJh/r4s7UVhpIw=3D?= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26eeeff0-f44f-4546-e71c-08deabaae6e7 X-MS-Exchange-CrossTenant-AuthSource: SJ5PPF2BB505D96.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2026 20:06:04.1861 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pXyPbidYJqk0H1W5qERZOv7UdWL/YN/kvDULkkUnIkcyuDa2iAImb5NPgf2W2/qzj+PYE2XQsEGs5G0ibIC+qXws0GOWM777DlG4jlCg/G4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6278 Content-Type: text/plain; charset="utf-8" There is a 20KHz minimum target for clock difference that was baked into the driver. This is unnecessary, and causes target clock frequencies to be rejected that should otherwise succeed. The discrepancy existed in versal drivers as well, but was removed as part of 'commit e0a94c6bb5b4 ("clk: xilinx: Optimize divisor search in clk_wzrd_get_divisors_ver()")' Apply the change to allow differences >=3D 20kHz. Before the change: 8<-------- clk-wizard-test: requesting 133312000 Hz on output 0 (clock NOT enabled) *** Clock wizard - Matching for rate 133312000 parent rate 99999000 m =3D 33, d =3D 1, o =3D 25, freq =3D 131998680, diff =3D 1313320 m =3D 35, d =3D 1, o =3D 26, freq =3D 134614038, diff =3D 1302038 m =3D 36, d =3D 1, o =3D 27, freq =3D 133332000, diff =3D 20000 *** Clock wizard - Matching for rate 133312000 parent rate 99999000 m =3D 33, d =3D 1, o =3D 25, freq =3D 131998680, diff =3D 1313320 m =3D 35, d =3D 1, o =3D 26, freq =3D 134614038, diff =3D 1302038 m =3D 36, d =3D 1, o =3D 27, freq =3D 133332000, diff =3D 20000 clk-wizard-test: clk_set_rate(133312000) failed: -22 8<-------- After the change: 8<-------- clk-wizard-test: requesting 133312000 Hz on output 0 (clock NOT enabled) *** Clock wizard - Matching for rate 133312000 parent rate 99999000 m =3D 33, d =3D 1, o =3D 25, freq =3D 131998680, diff =3D 1313320 m =3D 35, d =3D 1, o =3D 26, freq =3D 134614038, diff =3D 1302038 m =3D 36, d =3D 1, o =3D 27, freq =3D 133332000, diff =3D 20000 *** Clock wizard - Matching for rate 133312000 parent rate 99999000 m =3D 33, d =3D 1, o =3D 25, freq =3D 131998680, diff =3D 1313320 m =3D 35, d =3D 1, o =3D 26, freq =3D 134614038, diff =3D 1302038 m =3D 36, d =3D 1, o =3D 27, freq =3D 133332000, diff =3D 20000 *** Clock wizard - Matching for rate 133332000 parent rate 99999000 m =3D 33, d =3D 1, o =3D 25, freq =3D 131998680, diff =3D 1333320 m =3D 35, d =3D 1, o =3D 26, freq =3D 134614038, diff =3D 1282038 m =3D 36, d =3D 1, o =3D 27, freq =3D 133332000, diff =3D 0 clk-wizard-test: success -- actual rate: 133332000 Hz (requested 133312000 = Hz, error 20000 Hz) 8<-------- Signed-off-by: Colin Foster Reviewed-by: Shubhrajyoti Datta --- drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilin= x/clk-xlnx-clock-wizard.c index d43f20e9ac59..bc71d6155b06 100644 --- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c +++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c @@ -105,7 +105,6 @@ #define VER_WZRD_VCO_MAX 4320000000ULL #define VER_WZRD_O_MIN 2 #define VER_WZRD_O_MAX 511 -#define WZRD_MIN_ERR 20000 #define WZRD_FRAC_POINTS 1000 =20 /* Get the mask from width */ @@ -425,7 +424,7 @@ static int clk_wzrd_get_divisors(struct clk_hw *hw, uns= igned long rate, } } } - return best_diff < WZRD_MIN_ERR ? 0 : -EBUSY; + return best_diff !=3D -1ULL ? 0 : -EBUSY; } =20 static int clk_wzrd_reconfig(struct clk_wzrd_divider *divider, void __iome= m *div_addr) --=20 2.43.0