From nobody Tue May 26 03:57:55 2026 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 128814BCACD for ; Wed, 6 May 2026 18:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091319; cv=none; b=Idw9FWq4nVLFt5syxtXU0bNtDhPdqYSIM6zW0BGGN1A8NxExYchYHD/r9uPh/pQx3a73w4VX6psvQ1ptGtjoltWNxgzyyoWheMyjzmvFpfUHW+whStceNsCJdt7ml3qfYVgdQqDtV/HsO8E5pBa3ThvWmgS59J8I8IHATx9VX6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091319; c=relaxed/simple; bh=H08BrTRalR0jUvy/90S50ZaX5dzgHvM0nJcBr5ocsmg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pzJ2daGcoQNBXcgk4yAaI7WJy76VrBf10m86QjQOATFbVDx8cNqfSh4sy4dOiw9GyDX98Ki2EW9ZKdoNt3F+gCOzOLWFznk/65f17Br7aVYKVQIL8Rx+CRcVaKVamEhJXN6j88pZGjIYqfXGP/z9v80OVJL2RcgHdW+wTsqviYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I98m1bsn; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I98m1bsn" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5a87782588cso4947401e87.3 for ; Wed, 06 May 2026 11:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778091316; x=1778696116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qnRfUwgP4GDJT73gEU34kWTDXjMinDYaY8kcXfNdp88=; b=I98m1bsnN0jPkv+hXiOKZjFQA0kPFIVmmNGbQYRE4alFU7AirdbrpkMiRspfNugF/0 syFF8Yw7Jl3YAm2SsiwrKDFxj329V5/GEZ6TPocGyCxUmWAPHoQkUfPUYuiqURxWOldh yE412fvgho1eXgXTdJGEol5dmwSiXXbOthBTDr8FZxdowx2iWYxmDEL+WEM0A856PIHc tIBpYw0i0EA54hLoNRJ8NxAFrybJCKgOoyLGAxHlhHPf4kad1ZWZO4BSguQEMRn3VPZx WC87Aq1XK/MVMoFPGre/RcVajJNPJBeamoxxfLjUKkjgk3mMI8xLPBD8taIdaFClOuWK TLVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778091316; x=1778696116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qnRfUwgP4GDJT73gEU34kWTDXjMinDYaY8kcXfNdp88=; b=SRzKx4lSTJVnQ/ARSQ9IvngTWFM/TjvbaPJuiFlMD4sE9Qk3wNJBjF+nhujebEyoYv DAHqQU1yDgC5G8V+zfnQmPWslz0XCYADRMZUPXCLtkNddM5yaO0TP0VqafhFSXBtxKws MpqgFkyrvowJCJ5OSj8v1T8DzxCAWnGKkbKC6pOWfUmTYm8CiqZqW3tb7LftZBEpVf// 0q+NCGG1uK2FpId5jFjSQe7P8Lmmy+/VY6clupVF9eHs10/O71qY4HPcc3E8cOl5UbC4 6BGPRmeY+Ddzoiebg53yWfCY2ipl3AHV1SBaGOsxLVY45HWndvkTgyuAg5Qb0+ejdRfY M8JQ== X-Forwarded-Encrypted: i=1; AFNElJ9f53OrsiuF0zh38u2GQwAwoLOK48kaQ+wCTSn4dnau/5yHUkhn4NdCp1O11pjnMhvSQXIUdJBH2BEeP8M=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3c8WL6/RoOxzzE1E/ugoZojVXigbq0noo1DlzMcqvpQh3ANmY v/IK9MZf9domnOd1fw/bWYWpv1wR76ALqF+NvcL0AM8oU5rbapjquWkjHRCZp9Vj X-Gm-Gg: AeBDievD/QpxA3Z2c4QFYAYTLbxMw8mhDQxfeWGJUeP9dkZy7l+rUddUsYxGI7AUFC+ 6bStcELiPH5hJg0UxOJNwbhSpgmxIQOMhAHAJRiu2dbUriMc7S477QrOXtkN0bwF4hwwrWD6OW5 a02YjxvWg89SFdUhAA6iPFtFE4gPKnmqYpgAkN3QW+v+KeNQKHckB+fOssfjtiEH9wAGpv8t+my hh9Do8crSdToekWv864daSqoOgvrBjMizDyojoGXeqf6ATk19gNZc8eHjNzWXj3w8isMSQRJsE7 YZcc6i6uYbNgotpt12hqzAeM0/VuTxfim9cLpXpJ9fGMMenmkyeFyesrF1dhLr4qbLy76XATqXE JEjyVXOooq08ZxqazHmabCecRzREYpoyTo1XkXsKeXf+mzdfdGPm/wSn8OImIJtlYpTE0a+Ie5R 2m/vDUgMWQuY84UZym9FDP6hjzuifxKajtuV7tB71AHXNM6s2oFR02qRIeodhLEq6oqNLoHyzn5 mU= X-Received: by 2002:a05:6512:1150:b0:5a8:9672:e297 with SMTP id 2adb3069b0e04-5a89672e381mr124583e87.26.1778091315947; Wed, 06 May 2026 11:15:15 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c341848sm5037123e87.65.2026.05.06.11.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 11:15:14 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Md Shofiqul Islam , jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, mike.looijmans@topic.nl Subject: [PATCH 1/3] iio: adc: ti-ads1298: Add parentheses around macro parameter Date: Wed, 6 May 2026 21:15:04 +0300 Message-ID: <20260506181508.6813-2-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260506181508.6813-1-shofiqtest@gmail.com> References: <20260506181508.6813-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ADS1298_REG_CHnSET() is missing parentheses around the parameter 'n'. Add them to follow kernel macro coding style and prevent potential operator precedence issues if the argument is an expression. Signed-off-by: Md Shofiqul Islam Acked-by: Mike Looijmans --- drivers/iio/adc/ti-ads1298.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index ae30b47e45..cf5f954206 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -66,7 +66,7 @@ #define ADS1298_MASK_CONFIG3_VREF_4V BIT(5) =20 #define ADS1298_REG_LOFF 0x04 -#define ADS1298_REG_CHnSET(n) (0x05 + n) +#define ADS1298_REG_CHnSET(n) (0x05 + (n)) #define ADS1298_MASK_CH_PD BIT(7) #define ADS1298_MASK_CH_PGA GENMASK(6, 4) #define ADS1298_MASK_CH_MUX GENMASK(2, 0) --=20 2.54.0.windows.1 From nobody Tue May 26 03:57:55 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED28C4C0433 for ; Wed, 6 May 2026 18:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091321; cv=none; b=FmpTDLFah4CEOdyLBO5QsYfi1kgCm2+235R+UeCoHQnSJWWSh3e51Nh2oYavMrHWuLwEShJLn5q0PIfbmUbeSRXXLHfaDjWGp0MEGPHw4JMiB6FYTxn3c75kLr5gAWrd8upcrBGgt7T9np7AK24pKXFjze4gqdDU+ENZ4hyVEuE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091321; c=relaxed/simple; bh=7wwEeddHxhCClQzgwuisu1/1yJfMaAt2aMlXmyRxTYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JAhjYecRs/T5SLwuimOrCdT+xJUdyN1gxDxCo4VA5XRsaxhJom9lyj40XfU/yaax+ZaeBuUcz2Oz/2C6V9bO8judk4LjJyrwKEKlTBtWnkF3d/V5FBF1C5/xmb9uCPCmV9kC6BgoiQ/bvrnFVxSgKHkDdznOTUnWCOCz/Y/wem0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TAhUO2hv; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TAhUO2hv" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5a86bfa2a4eso6145861e87.1 for ; Wed, 06 May 2026 11:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778091318; x=1778696118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4zF8aJYC8sIqGUROlbDSF6MUK4SPWjcto9OGe/HwWY=; b=TAhUO2hvjU0iduy9AcZn85vixcylmjyBWcii9CAZtKzowYx3AChNxv1Xd6vlkAvzbK K4ND1agqXZuXY5EEkz0PxYWq1wIDzCcZ/d9dBjyHoN1tUU+t14fdITuOn4g3CdcvCGDE KS/kmEQImDVV0u5DZEe4iYjPuejjlKFjJvGV7TPJv1XWSmjvJ4WLVDN5iaVrap018BMz ddOzggy/Q22Vliwief4wdQmj3GpHeCGds6WZGVK6fZNTGje1ylnYXMg7BzWUSsEzcHfw YUJDi95dUm1F9f3vKAv3YxsFYjCRN6I4Z6KCv5Ccv2lkJwV6cQW4shYh9I5AIBu6z11F sr5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778091318; x=1778696118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U4zF8aJYC8sIqGUROlbDSF6MUK4SPWjcto9OGe/HwWY=; b=cfe1ma4/w8tA4PVyU5UIKbqTkB2eUiWwNSjUN/oY+fx/hmZSBuVTgaksduJ8aeXFag tZUag1cuzTd2bjzZK/P8811FAbE245QsxvtzCtOm8SH113yzJSKKJ30F+Xbn60M9j00y DLvE8phKn81moI0t4iS6B92JT38Q3JSBo5y6zvDhyNZEwUqApWv5lSikN3NxHVTCvjRI tSrm2HtVLSgtma32hAB4Sd/lslPAIqBpfEaAeOOgB40DU1vZRvqDFIcelaBwv8CYbjGF oo7J3GdBuDKftb/pHC/cE6zRFVEZp2XXQX5dAoD71wz27xL618CfPwumdn+C3lVJc79+ Ilgg== X-Forwarded-Encrypted: i=1; AFNElJ//6am6CkneiVdQgZt9AHhbWrJ+GwLXfC2AILk1NcrYBpXG7HnAJb9fuOjj6Bg/s9a5XzwO1RD9TnjNBkY=@vger.kernel.org X-Gm-Message-State: AOJu0Yww2yA1oD3+w18n9aVxLpi0o+ige6UCDAIbg55MZwEZzVFdsxqf +cKCplbFtbSFFHBMw1c8VsM7LuQKJkKMtNyzPbYUAURQNpWfFekYowFCQ02p9YzR X-Gm-Gg: AeBDieu13o+Qy5WK1ze7juYYBVntnFSJMCNTI/SJZdo3nARy0PXCt4BZNfkPRCwwpvD wzEpDk6PRg4Wu/em79mogOwV49BHbARVHq/Ex/2S9iQZ4QxCZaq7f8Bm6AVVY159YE738goxDBM tD1hCjQ0KSWuKuPN1WYW8pYeFBdTgsJwTVU93i9lXxOeIRVsbqx3Vb2ExcKYmLImbg3/GN0rN8F uxg4tTWEl8UjLWkU+YTe4X2Ykx0RhCg+O/yNyX4NVtvwkgkZrPGmq6UdRbOuJZWyBlek5In1mtv FBYuYI7qM92pN3hjnoNLsQ0QFCDhcNdoXuLGV0nkI7Tu+ycTKdg/peIvd5RvVQlFQiwvvCGMUbK yTXJBWwSplTB1NWm8QvbarJBMTR8q/UkupILt7u+Mjj7M8e+Mc/TWQcoDvQx7/jC2emvw23TsaT +/d3sHM7w5gTcqxjLZsge+jly+nPoYYWFyXmFAVmkTSvK4mkHgQC6Gdshz30hiqm/0436rt6UjE POoPic9nDxBLQ== X-Received: by 2002:a05:6512:3f1e:b0:5a8:7f58:5fba with SMTP id 2adb3069b0e04-5a887adfd8emr1872899e87.9.1778091317901; Wed, 06 May 2026 11:15:17 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c341848sm5037123e87.65.2026.05.06.11.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 11:15:17 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Md Shofiqul Islam , jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, mike.looijmans@topic.nl Subject: [PATCH 2/3] iio: adc: ti-ads1298: Fix incorrect timeout comment Date: Wed, 6 May 2026 21:15:05 +0300 Message-ID: <20260506181508.6813-3-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260506181508.6813-1-shofiqtest@gmail.com> References: <20260506181508.6813-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" At the lowest supported data rate of 250Hz, one conversion period is 4ms, not 40ms. Fix the comment to correctly reflect the timing. The 50ms timeout value itself is correct as a conservative margin. Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index cf5f954206..186bda3087 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -210,7 +210,7 @@ static int ads1298_read_one(struct ads1298_private *pri= v, int chan_index) return ret; } =20 - /* Cannot take longer than 40ms (250Hz) */ + /* Cannot take longer than 4ms at the lowest rate (250Hz) */ ret =3D wait_for_completion_timeout(&priv->completion, msecs_to_jiffies(5= 0)); if (!ret) return -ETIMEDOUT; --=20 2.54.0.windows.1 From nobody Tue May 26 03:57:55 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A020E4C043B for ; Wed, 6 May 2026 18:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091322; cv=none; b=C/R/Q1bLhO21naJBlDJxNJ1q1cRVWs8ErwUVGfgjMLcSQoIoA2b03rjNDibBOVHeYoiomKnqKCTS5n23dqkEoT2vLZX/nCSfrGDWZLU9ayMQDV/S3f/ENUD+4B9iR+tTDrTbM248sHF3xBflmUOJkFxIhuInpPMe/al29RIgnOo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091322; c=relaxed/simple; bh=KYHbEs1hFhbzdxRs3kjAitKOLVWL54iGr3ovFRvC3yk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nAYcZajH8I1DdnSxiKjOMgzA854OIF26xzpBjbchMnJ8oosNIZZCyxZyPjHmLsp4guYIspa70pQqDFX0g4KxAuzqcT4FpUG5qux9st2lsi08zJXvo2G/wT2TepiHJr8nvjkdqw4slMXyL/Y+y+5b/r+pXLSD8K9HoqkAr5DY0sg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=daIx9g0o; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="daIx9g0o" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5a0ff30b240so10011465e87.0 for ; Wed, 06 May 2026 11:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778091319; x=1778696119; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=urPJFirmQxK1PfI+Y4FpSbIT/Bsr9NE+HAChfqtMiKg=; b=daIx9g0on/PQSEE9MhzP8Nv9cyaaJuK8fgMwlUMPj8I1A+Vc6fOGB/hhbZq21D2wBy mXOrUzKqTu7gBpVCO3cNkxcZ5rLAYVpzP949GQqdNZMdZSz9ND6Tp+ATNa+RSZ5XvUCe Tqvd4vOtYYiw1rLq6lsQXJbRulJqxCfZwtJ1k3rflxRoEaq43gjbZlcM9pYOLOBFgPGt ivxwHkK/sorDqrbvl+pM4zd9JC6RlG/gel00HCDtTfvSG8IVlBjQRsYveSFHMmS6eVOT I/7bq5BsY8IKKE9J8uJVURXoHkZquzco7NPwKqptL7jIoRsAlHhQWHSR9rjD0feM3nr9 TZ6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778091319; x=1778696119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=urPJFirmQxK1PfI+Y4FpSbIT/Bsr9NE+HAChfqtMiKg=; b=KwFsJTCTq/u9ErQ+OP7IRc+et8KPw56vWV4Jc5cQrd2+R6pTk3MG/Xsoy/u7NSUnsk M4qQyM3nhf82vqD29AG88CF0WXo1wYxiRZn7+O81tw5aghcA8wri76Utp2NP+yqLPPGk WXr9XNCanRkSqF5DLKTld6wTbPJzZhvJGxh2NjCcUT8DZuXOIFzI6//yuKQylP/iU3+5 GEo3dfyPxOwExtTLABf1uMzUddlqozZTmQ0SC4jvSv0B/UbXG4Lysu/R1hdZn7ViSXw0 ZvaCv1IA/GI3kXBPc+X1J/C8dNtciZzsGbmZsahnYBF6aR0LR2U4UzKBai2DKvp3S99P VV5Q== X-Forwarded-Encrypted: i=1; AFNElJ/aPC88h7thm7wOsWedRBumbyi5HBT0N1UKR2p8mISNDRbp46e4EJhvgRILIhu1aeIHpUJ+V+/iRp60e70=@vger.kernel.org X-Gm-Message-State: AOJu0YyexFm1P+hCqnX3p5zYkNe2DEBejpxJflP9R8gzhAbiQN8c88yf WpQoQtrnyIRA33oPspJfc0ZwbzVvGZSqD1dswGCzoZQm5nKF3J6Qy+YJ X-Gm-Gg: AeBDieuwCB4qYnpdfjVZp3U3362ZNV+T3gfP3eYvQ7jKu6DS+TGUPUSDTJcmwK7id/J Sd87aUEyVA4cMM0s0Lnp1fdFksjLAA/VmbBQfxGBE7V2qdvFhMozlMPwArgb0pFKYOa8YpEAGiM swpvnr8rA/yU5mhJuESngI5r61F+BkxHhNJjxkK1siZN+tRk7x9vAQChRhGY8Wsgbn+GvIU7x2E x2x/+tSQCPqW4LeMBy7hFpwSxLHgkofhagU9oUHmNMM2Wnf3Br6r8FAFO3QfpRjKw2Nl8mlDqFj EYmwwsBYG4O03/U6kgITP+WafLnoYXt9ExD5bD58Q+sNyO7KXixjVonsjYfT7uzUK9rwNeXq9ZB y2E9uHQ+k73I9cqfV9Ck/mCSeBgWOu3AfYBKJHevGje1ltxjVFa6NCc2Zu6RAuK9YTFRDD+WpGc Dmvq+MWIcTehhdK4VxWv5mG3E7c1n4Lg5eyLAzap1Q8KTsmggQ4oQY/ruObRK5I9bYtTDXbAVHj Ps= X-Received: by 2002:ac2:4e45:0:b0:5a8:6b96:9d10 with SMTP id 2adb3069b0e04-5a887cef69fmr972792e87.40.1778091318831; Wed, 06 May 2026 11:15:18 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c341848sm5037123e87.65.2026.05.06.11.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 11:15:18 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Md Shofiqul Islam , jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, mike.looijmans@topic.nl Subject: [PATCH 3/3] iio: adc: ti-ads1298: Don't enable internal test signal during init Date: Wed, 6 May 2026 21:15:06 +0300 Message-ID: <20260506181508.6813-4-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260506181508.6813-1-shofiqtest@gmail.com> References: <20260506181508.6813-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver was enabling the internal test signal (INT_TEST), double amplitude (TEST_AMP), and fast frequency (TEST_FREQ_FAST) bits in CONFIG2 during initialization. These bits activate an internal square wave generator intended for device testing and calibration, not normal ECG operation. While the test signal does not affect channel measurements unless the channel MUX is explicitly set to route it (MUX =3D 101), enabling the test signal generator unnecessarily increases power consumption and is inappropriate for a medical ADC driver in normal operation. Keep only the RESERVED bit which the datasheet requires to always be written as 1. Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index 186bda3087..360dfd2fc8 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -615,12 +615,9 @@ static int ads1298_init(struct iio_dev *indio_dev) if (!indio_dev->name) return -ENOMEM; =20 - /* Enable internal test signal, double amplitude, double frequency */ + /* CONFIG2: reserved bit must always be written as 1 per datasheet */ ret =3D regmap_write(priv->regmap, ADS1298_REG_CONFIG2, - ADS1298_MASK_CONFIG2_RESERVED | - ADS1298_MASK_CONFIG2_INT_TEST | - ADS1298_MASK_CONFIG2_TEST_AMP | - ADS1298_MASK_CONFIG2_TEST_FREQ_FAST); + ADS1298_MASK_CONFIG2_RESERVED); if (ret) return ret; =20 --=20 2.54.0.windows.1