From nobody Mon May 25 16:40:08 2026 Received: from forward203d.mail.yandex.net (forward203d.mail.yandex.net [178.154.239.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04E81306B3D for ; Wed, 6 May 2026 17:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086824; cv=none; b=iwI9gI9CfQ1a2co4rc0p65M/vNK98VJPJb/h6ms+KVQp89pjXieUMQIEszrFiHKgQyAzzQkn7cYY6D1QFQAdfV/fR9iYyPbdLUhiTv5GZz8sBdvsXzBz0dzX68YuvuNn3yAgxyLnM+oxV5Hmh/INucghbIme6c9bJgh4Mm+eELg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086824; c=relaxed/simple; bh=qjtd8RhDjZMowo1/bZM85aIVsapyBPMu61NZxJDbOLs=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=JAShLTlY8OGyaoKp+mdz2fYiaNGI8JgeuDb0jbCwOohIUVtrLaJpE+62Tdu0/1KeuKpeUrWbZj3H6N8Cg++vOqSUhhqV4P3liL0qf2mU0cWv3H8RRgNfnypbMti8T8wc3HEhaIcd/5A7lMK/nB2kSHYbzUkiH6I45qcjaur8sPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=2005.tr; spf=pass smtp.mailfrom=2005.tr; dkim=pass (1024-bit key) header.d=2005.tr header.i=@2005.tr header.b=EMUn+NNK; arc=none smtp.client-ip=178.154.239.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=2005.tr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=2005.tr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=2005.tr header.i=@2005.tr header.b="EMUn+NNK" Received: from forward102d.mail.yandex.net (forward102d.mail.yandex.net [IPv6:2a02:6b8:c41:1300:1:45:d181:d102]) by forward203d.mail.yandex.net (Yandex) with ESMTPS id DC2FC88C57 for ; Wed, 06 May 2026 19:54:14 +0300 (MSK) Received: from mail-nwsmtp-smtp-production-main-94.klg.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-94.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:2646:0:640:add0:0]) by forward102d.mail.yandex.net (Yandex) with ESMTPS id 9F697C0120; Wed, 06 May 2026 19:54:06 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-94.klg.yp-c.yandex.net (smtp) with ESMTPSA id 2skcjWGSoW20-P2IKQ00u; Wed, 06 May 2026 19:54:05 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2005.tr; s=mail; t=1778086446; bh=kMg+VAvJYbWrlFbwgOjXF47h84s1aNcKOZEo+xRdNek=; h=Message-ID:Date:Subject:To:From; b=EMUn+NNK9frgcpxDgm6YNPziOkFgflwHuE1bs4IAuNT5R6GufHyROF74YrVCR6i2R 0DZOIenBeJBGlVtbAcdC3eg/OcItVNYRKZxQ9fPN9btOeXv7e0OVzjc2bXHn2oGfko lu1R108jAr/J+pY70L/fhuwudxQg0+ka7UYUgLXI= Authentication-Results: mail-nwsmtp-smtp-production-main-94.klg.yp-c.yandex.net; dkim=pass header.i=@2005.tr From: x@2005.tr To: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/rockchip: Open-code drm_simple_encoder_init() Date: Wed, 6 May 2026 19:53:45 +0300 Message-ID: <20260506165346.19819-1-x@2005.tr> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Favilances Noir drm_simple_encoder_init() wraps drm_encoder_init(). It uses drm_encoder_cleanup() as the encoder destroy callback. Add driver-local drm_encoder_funcs and call drm_encoder_init() directly. This is a TODO cleanup towards removing drm_simple_encoder_init(). No functional change intended. Signed-off-by: Favilances Noir Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/rockchip/rockchip_rgb.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rock= chip/rockchip_rgb.c index 5c0c6e2cc28d..fd93ffedad64 100644 --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c @@ -13,11 +13,11 @@ #include #include #include +#include #include #include #include #include -#include =20 #include "rockchip_drm_drv.h" #include "rockchip_rgb.h" @@ -70,6 +70,10 @@ struct drm_encoder_helper_funcs rockchip_rgb_encoder_hel= per_funcs =3D { .atomic_check =3D rockchip_rgb_encoder_atomic_check, }; =20 +static const struct drm_encoder_funcs rockchip_rgb_encoder_funcs =3D { + .destroy =3D drm_encoder_cleanup, +}; + struct rockchip_rgb *rockchip_rgb_init(struct device *dev, struct drm_crtc *crtc, struct drm_device *drm_dev, @@ -127,7 +131,8 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *d= ev, encoder =3D &rgb->encoder.encoder; encoder->possible_crtcs =3D drm_crtc_mask(crtc); =20 - ret =3D drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_NONE); + ret =3D drm_encoder_init(drm_dev, encoder, &rockchip_rgb_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); if (ret < 0) { DRM_DEV_ERROR(drm_dev->dev, "failed to initialize encoder: %d\n", ret); --=20 2.54.0