From nobody Sat Jun 27 17:09:04 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4069B4A1384 for ; Wed, 6 May 2026 16:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086165; cv=none; b=mShev2N3Ac1NOkgLTYu+zleHCSay2/BRaStdk2b0s+iHfKxfD/L+C1YzLmb8MuCMSmL9sZvKXjOoQdko11oXzxM4IwDWszM1jyj0TLIPmXpCiTQoaUkx8wmfuR/+pBIkjJNeXB/A/vK/q91DyIpkYNjMo8ADqWMZROinHpTyVS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086165; c=relaxed/simple; bh=XbIcmfBPvdUsZgt8hYQuWguV5+dMEMnvfD1TFRjc7zA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K/6EyOX8AaNIrXRLFNEu4bPPMP8O7nFXVuwbNciz0n243GKmb36ydk14Mwl98KchzkTB0SDkxH19shsnzVdXBGSDerFG+vZ5co1ZTzkHKs1mQii5M2cL8MaxrNNg8lATAHwwQUdkhShSefDjPjpG3w4s89+YB5/8JQVIVCIUtpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iSxO92UI; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iSxO92UI" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so94349495e9.0 for ; Wed, 06 May 2026 09:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778086162; x=1778690962; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H/baJx7mBsqKytKYQaKxdbG5hOnnWG1GzcGphYV5dXY=; b=iSxO92UI/pfpIBIpTJ9pEJUCdlNSyr0yOGYRhFT/a6aw3U3MeI+j6WsEzabt4mutsn pGxUvVLeFuNoziE+Y2xx7grQfRM8/fyyIJiRfTVfraS06toRB0xgx1EU1n0C7B3Ss6TZ fOXTaK/pKgUv2Eiv2x2HrO6rEVex71viiy+gNmK8sy0RtVzoUaRjbpVC6Gb7j4uYEH5z KSajT9+1fX1wrtWwEuxZ1oneybAvflnHUT1+g/1+ObW/rWaD2M9o5iUo33QlLDgY8xk9 HoXAsm28mVZ6vwTfqU8TxcE1+AWbVGHdIhWDv/5p/Apt8svqEheAQspvcE19Pc4subeh dgdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778086162; x=1778690962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H/baJx7mBsqKytKYQaKxdbG5hOnnWG1GzcGphYV5dXY=; b=QWWAoA5N8yj81LqKpDB9Vr8aN++8+3aWd9YRt3jy7sd9o5gk+v/hpqldLjEjpBsfOs NTMSi8cZNSYb4Mtn7T6TQV6gOIyyQCPVdcjYs3vEQgcqSxeLwgGHLRhiifx2S0gooRAL UQhi+xoozzU0OQT/SzUs9dS4irzjWxY8HPAJvD5opqM32xrob2LbNpylQ/3rsf7vXS3W MRBcZO+IdfPPqpxZKObaAGD5sHGqxYIOkgZLE7iYNnfk4ap+2S0YCTHCa5Z4m35zyLCK Kf1MHNr9vzvVn8sJo9ezfWrc0kUIlk3EIq5OC7E5v246cMJ2u4ywi1MUIT2j+Hd+Yg4p LJyw== X-Forwarded-Encrypted: i=1; AFNElJ97NNaUb2SfaHJ2d5u1XHKFtWnq6Lf/Ke9OcR7VNcA1Hkm3iDe3EnH/wqFzrukNYK8YudhP8DYzfKXUXHE=@vger.kernel.org X-Gm-Message-State: AOJu0YwudoKwnhDiO3emoN8fnJ5R0DE2m9+ttKL0k3tlHFnlt2OyANPb +4GqvOiYdMqYLt2s2xFAi5xfRn6vfWNxAOnxEgFeQxZ1t8x9yogF6boZ X-Gm-Gg: AeBDiet82dtLKxAUHHgPvOsZNzqE/lx10ouFki2jbXlmrxJJ5hIz6SxZpTELof5OzTE dBdndaeEZ3CFR+mQ4iR7IqWBF8y6chgsQoICOkB4tVjwBR6Aua/C8jyBgAM7ezISHRVhykJHEaN 7yIvgtz5U6ii72hV7ZeGzWwOwLeu/xMk6pRAONc+a2Bvuv0/q2ZeL7xeC8Tr0tYO4Bx4zvmtBII KqbNJXQb4jQ0etF3mciAcvqKtx9GJVUf8foLF+mPYBJJBYStAo9aMVDsS976/UsfN0KktLgSJd9 R6ssBGWzRprbtW6nYNupKGwOiyUQScqLPfhO0zZ61FCKvMRxhImQ4mcafjtcBDLetm0P+CiDwvS tK0LOuA95JjfflSaPjew3h9vwTQ1S8BUV064UvqWTm5QxNj31xHkem9Gvoa82fHYQC1TDWkcJZO nRuLCab3J4fe+Wbfe9UsDIyUMkymb+RqgaHbScbe3lovoKszxaqKyRr81/7EAkH8Pbs5TPVh5MT 8//bodY3lyaJ5yLFteYRETsSuGknSYPaVLTRQtYEh8YtG3vglGkZEEdnQ== X-Received: by 2002:a05:600d:10:b0:488:e7e4:8425 with SMTP id 5b1f17b1804b1-48e51f4ea40mr61630205e9.23.1778086161523; Wed, 06 May 2026 09:49:21 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:3dcb:40a8:a5b9:2327]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e530fdc50sm33060795e9.5.2026.05.06.09.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 09:49:20 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 5/5] rtc: renesas-rtca3: Factor out year decoding helper Date: Wed, 6 May 2026 17:49:14 +0100 Message-ID: <20260506164914.3987293-6-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar The logic to decode the year value from the hardware registers is duplicated in both rtca3_read_time() and rtca3_read_alarm(). Introduce a helper rtca3_decode_year() to centralize this conversion. Signed-off-by: Lad Prabhakar Reviewed-by: Claudiu Beznea Tested-by: Claudiu Beznea # on RZ/G3S --- drivers/rtc/rtc-renesas-rtca3.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index 97e7e65f59a5..b3875d041de5 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -228,12 +228,19 @@ static void rtca3_prepare_cntalrm_regs_for_read(struc= t rtca3_priv *priv, bool cn } } =20 +static u32 rtca3_decode_year(u8 mask, u16 year) +{ + u8 y =3D FIELD_GET(mask, year); + u32 century =3D bcd2bin((y =3D=3D 0x99) ? 0x19 : 0x20); + + return (century * 100 + bcd2bin(y)) - 1900; +} + static int rtca3_read_time(struct device *dev, struct rtc_time *tm) { struct rtca3_priv *priv =3D dev_get_drvdata(dev); u8 sec, min, hour, wday, mday, month, tmp; u8 trials =3D 0; - u32 year100; u16 year; =20 guard(spinlock_irqsave)(&priv->lock); @@ -274,9 +281,7 @@ static int rtca3_read_time(struct device *dev, struct r= tc_time *tm) tm->tm_wday =3D bcd2bin(FIELD_GET(RTCA3_RWKCNT_WK, wday)); tm->tm_mday =3D bcd2bin(FIELD_GET(RTCA3_RDAYCNT_DAY, mday)); tm->tm_mon =3D bcd2bin(FIELD_GET(RTCA3_RMONCNT_MONTH, month)) - 1; - year =3D FIELD_GET(RTCA3_RYRCNT_YEAR, year); - year100 =3D bcd2bin((year =3D=3D 0x99) ? 0x19 : 0x20); - tm->tm_year =3D (year100 * 100 + bcd2bin(year)) - 1900; + tm->tm_year =3D rtca3_decode_year(RTCA3_RYRCNT_YEAR, year); =20 return 0; } @@ -354,7 +359,6 @@ static int rtca3_read_alarm(struct device *dev, struct = rtc_wkalrm *wkalrm) struct rtca3_priv *priv =3D dev_get_drvdata(dev); u8 sec, min, hour, wday, mday, month; struct rtc_time *tm =3D &wkalrm->time; - u32 year100; u16 year; =20 guard(spinlock_irqsave)(&priv->lock); @@ -373,9 +377,7 @@ static int rtca3_read_alarm(struct device *dev, struct = rtc_wkalrm *wkalrm) tm->tm_wday =3D bcd2bin(FIELD_GET(RTCA3_RWKAR_DAYW, wday)); tm->tm_mday =3D bcd2bin(FIELD_GET(RTCA3_RDAYAR_DATE, mday)); tm->tm_mon =3D bcd2bin(FIELD_GET(RTCA3_RMONAR_MON, month)) - 1; - year =3D FIELD_GET(RTCA3_RYRAR_YR, year); - year100 =3D bcd2bin((year =3D=3D 0x99) ? 0x19 : 0x20); - tm->tm_year =3D (year100 * 100 + bcd2bin(year)) - 1900; + tm->tm_year =3D rtca3_decode_year(RTCA3_RYRAR_YR, year); =20 wkalrm->enabled =3D !!(readb(priv->base + RTCA3_RCR1) & RTCA3_RCR1_AIE); =20 --=20 2.54.0