From nobody Wed Jun 24 16:13:54 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED1A494A00 for ; Wed, 6 May 2026 16:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086161; cv=none; b=FsjDhen8r/JXtC59MHtd1f+zQ5j1VaaA0PQk6508NCW54ZTN6+LCTB1IIKdXDSFaevz/OLhzPaP3Ak5wU3vljsE1X7m4hBLTpE3jWmC3jF8gN/saIsG3UaxCI3c1QXHCeSR5Qkd4btcDIG6F5PMS1KLzgBjRCeOLiNoWDJXqxEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086161; c=relaxed/simple; bh=ydCT1/JE/JPYLI+J+iW6pMlD2xEDI2Bd5yteqX85Pl8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xn4Dmk5fmg2rB4o0b1xXupx41cyaM03caDjZ/cqW+gfr5yCaYph++No9CokSpDEyGQ4l6ZyYB9IZuRj+nDEeN9wQzt5wErf0AY6yXMIiNczBAzWBuB3AyUM7KxHPdIvNR7Yzi3jXTO2yvuTex9l4WKUKdNlvPjTzC/9AvxCuCys= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GuflnOgR; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GuflnOgR" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48909558b3aso73506925e9.0 for ; Wed, 06 May 2026 09:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778086158; x=1778690958; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WM+K0gilZXjULIrmHaDGvw/aYGEN7GMhe5rYaCexhFI=; b=GuflnOgRZpE4oGmRzQdVTRTQipqZOw50zLhrOZq7SOY9SbfXfiy/+A/HHVUEKXynGh pPafotKB6d4A/7LZUYg0j+jXd6AxnNeErBenhIzpOaftJSSmx8knYR249+LDBTKYntNv ry7+rleU2M9Wg8a1PO7PZCdHJfN0YWloVpjDKS2AnxXwRMNGdAfLoH4lh82fLw7O7DLd j5emGSKn8U+BOnXU3m2PTMb+POJU32+9488H3ZFRY8/ILcrye7O1VR/GIQo2DoUACq7q MmkViZeNl0U7XzN/jLEpOfAovgH8Jq7ui6XkSYeQI0yLRUY0gOQ9LJ5nfbclVBi7nkKs iMNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778086158; x=1778690958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WM+K0gilZXjULIrmHaDGvw/aYGEN7GMhe5rYaCexhFI=; b=NdF1fItLqsgN3+zub/7z0jEVz6QwqqLsHf2EAMVUM21bmc01gzUR7NrUkZRA+U4Pss szyMGVqPoAEvyPrvmIt6cJPoUr1T7PHWB2ytHe8NaWmEDX+Kjap4dd7AfkOEJb+Gj0Ue tb0QEEmsyCdilLCq+xpFTZ+XxFE3nPQQ9cPNoHOmhfwjl3FtLGrLU/ghqeqsyScW73pD tspdzWXiRWL32mctDlJ4TnKxb9oBAYQLpwflfg/15fKfrRKg5PCdOIQA22Ik8zorgYI/ 5rr+d9vTSqmfgu3lhg8SujIK5hfrzqyIWnNEBDwi1C8sLc9JVKj+MXxH0gTQfktHjtVP vEEg== X-Forwarded-Encrypted: i=1; AFNElJ+n9oTYLd3T7+wp/NU9ksYOZA69zfFQgyU5BiBNvuvnJBKLax81BbVtl98yYOhclsjiz5Go4+8x44mSCdU=@vger.kernel.org X-Gm-Message-State: AOJu0YxApyX1nz+3iHUeJylTb6kMcQuW1WhGTILyASUFqwOSvN3EClGm rGepr45Z/tiq6G38rfpSdZeF8swOYKIKJsefp6aGP84sObPHIAZt+lKt X-Gm-Gg: AeBDievxdXAS5QrsgJndx4rCecJHMO9ONGrhH/wpBgtqmxsO/mAF3G9rH5/rgwIdSIf /cpRRujaZq0dEiTFUVFDtDbEc1m8YxoAUEOfWqGE8oglJ/MIONZfn5h8fL56wD0KMYKbHbUDOyq WTNqEPhWGRJrME4S8Lc//tiGBIaP3g/Bbw3zGQq3y6B0r8yNR+ghG+YhGr8XtIkVfyLZ6uD/DvK Yflm5fxaAsz8VvL1aHbwbiHehBx637Z0JmSS1G7JWmjeqCbhGv+jd07+oss6+HrKeVwEsSqCTmv z69aYii5ga+ZxW2SgUEWsf0t4u1Z1hK//aF8QuYvQ1XiQNcg4hKWeln5mwds4FuTwxbqfnyaR6K /6tmto/BVcOEsqcbGVMq0fObXF7W26LDTzH7hPMYLSTOPIjLAORHBqCRgYQiM5goet91S5FHF+a PbRKPWDpp42ilvfFaxl3+1uWz5IZ8JYxDMiISw9ujJ3r+Ifp0C/DEens2vprEhcQtI1rvwO3v79 nSeaFJh3FltQ/5HcHi1m99IUso5nPxTOrdUFna2MUGBO9W2mX6kw7bZGczC4n+eyM17 X-Received: by 2002:a05:600c:6d7:b0:489:1d23:4524 with SMTP id 5b1f17b1804b1-48e51e0bc19mr45621445e9.5.1778086158014; Wed, 06 May 2026 09:49:18 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:3dcb:40a8:a5b9:2327]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e530fdc50sm33060795e9.5.2026.05.06.09.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 09:49:17 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 1/5] rtc: renesas-rtca3: Fix PIE clear polling condition in alarm setup error path Date: Wed, 6 May 2026 17:49:10 +0100 Message-ID: <20260506164914.3987293-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar In rtca3_set_alarm(), the setup_failed path attempts to disable the Periodic Interrupt Enable (PIE) bit and wait until it is cleared. However, the polling condition passed to readb_poll_timeout_atomic() uses an incorrect expression: !(tmp & ~RTCA3_RCR1_PIE) As ~RTCA3_RCR1_PIE evaluates to a mask of all bits except PIE, the condition effectively waits for all non-PIE bits to become zero, which is unrelated to the intended operation and is unlikely to ever be true. This causes the poll to time out unnecessarily. Fix the condition to check for the PIE bit itself being cleared: !(tmp & RTCA3_RCR1_PIE) This correctly waits until PIE is deasserted after being cleared. Signed-off-by: Lad Prabhakar Reviewed-by: Claudiu Beznea Tested-by: Claudiu Beznea # on RZ/G3S --- drivers/rtc/rtc-renesas-rtca3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index cbabaa4dc96a..2dc080d0eb6c 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -455,7 +455,7 @@ static int rtca3_set_alarm(struct device *dev, struct r= tc_wkalrm *wkalrm) * specified timeout for setup. */ writeb(rcr1 & ~RTCA3_RCR1_PIE, priv->base + RTCA3_RCR1); - readb_poll_timeout_atomic(priv->base + RTCA3_RCR1, tmp, !(tmp & ~RTCA3_R= CR1_PIE), + readb_poll_timeout_atomic(priv->base + RTCA3_RCR1, tmp, !(tmp & RTCA3_RC= R1_PIE), 10, RTCA3_DEFAULT_TIMEOUT_US); atomic_set(&priv->alrm_sstep, RTCA3_ALRM_SSTEP_DONE); } --=20 2.54.0