From nobody Sun May 31 10:45:05 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED1A494A00 for ; Wed, 6 May 2026 16:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086161; cv=none; b=FsjDhen8r/JXtC59MHtd1f+zQ5j1VaaA0PQk6508NCW54ZTN6+LCTB1IIKdXDSFaevz/OLhzPaP3Ak5wU3vljsE1X7m4hBLTpE3jWmC3jF8gN/saIsG3UaxCI3c1QXHCeSR5Qkd4btcDIG6F5PMS1KLzgBjRCeOLiNoWDJXqxEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086161; c=relaxed/simple; bh=ydCT1/JE/JPYLI+J+iW6pMlD2xEDI2Bd5yteqX85Pl8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xn4Dmk5fmg2rB4o0b1xXupx41cyaM03caDjZ/cqW+gfr5yCaYph++No9CokSpDEyGQ4l6ZyYB9IZuRj+nDEeN9wQzt5wErf0AY6yXMIiNczBAzWBuB3AyUM7KxHPdIvNR7Yzi3jXTO2yvuTex9l4WKUKdNlvPjTzC/9AvxCuCys= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GuflnOgR; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GuflnOgR" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48909558b3aso73506925e9.0 for ; Wed, 06 May 2026 09:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778086158; x=1778690958; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WM+K0gilZXjULIrmHaDGvw/aYGEN7GMhe5rYaCexhFI=; b=GuflnOgRZpE4oGmRzQdVTRTQipqZOw50zLhrOZq7SOY9SbfXfiy/+A/HHVUEKXynGh pPafotKB6d4A/7LZUYg0j+jXd6AxnNeErBenhIzpOaftJSSmx8knYR249+LDBTKYntNv ry7+rleU2M9Wg8a1PO7PZCdHJfN0YWloVpjDKS2AnxXwRMNGdAfLoH4lh82fLw7O7DLd j5emGSKn8U+BOnXU3m2PTMb+POJU32+9488H3ZFRY8/ILcrye7O1VR/GIQo2DoUACq7q MmkViZeNl0U7XzN/jLEpOfAovgH8Jq7ui6XkSYeQI0yLRUY0gOQ9LJ5nfbclVBi7nkKs iMNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778086158; x=1778690958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WM+K0gilZXjULIrmHaDGvw/aYGEN7GMhe5rYaCexhFI=; b=NdF1fItLqsgN3+zub/7z0jEVz6QwqqLsHf2EAMVUM21bmc01gzUR7NrUkZRA+U4Pss szyMGVqPoAEvyPrvmIt6cJPoUr1T7PHWB2ytHe8NaWmEDX+Kjap4dd7AfkOEJb+Gj0Ue tb0QEEmsyCdilLCq+xpFTZ+XxFE3nPQQ9cPNoHOmhfwjl3FtLGrLU/ghqeqsyScW73pD tspdzWXiRWL32mctDlJ4TnKxb9oBAYQLpwflfg/15fKfrRKg5PCdOIQA22Ik8zorgYI/ 5rr+d9vTSqmfgu3lhg8SujIK5hfrzqyIWnNEBDwi1C8sLc9JVKj+MXxH0gTQfktHjtVP vEEg== X-Forwarded-Encrypted: i=1; AFNElJ+n9oTYLd3T7+wp/NU9ksYOZA69zfFQgyU5BiBNvuvnJBKLax81BbVtl98yYOhclsjiz5Go4+8x44mSCdU=@vger.kernel.org X-Gm-Message-State: AOJu0YxApyX1nz+3iHUeJylTb6kMcQuW1WhGTILyASUFqwOSvN3EClGm rGepr45Z/tiq6G38rfpSdZeF8swOYKIKJsefp6aGP84sObPHIAZt+lKt X-Gm-Gg: AeBDievxdXAS5QrsgJndx4rCecJHMO9ONGrhH/wpBgtqmxsO/mAF3G9rH5/rgwIdSIf /cpRRujaZq0dEiTFUVFDtDbEc1m8YxoAUEOfWqGE8oglJ/MIONZfn5h8fL56wD0KMYKbHbUDOyq WTNqEPhWGRJrME4S8Lc//tiGBIaP3g/Bbw3zGQq3y6B0r8yNR+ghG+YhGr8XtIkVfyLZ6uD/DvK Yflm5fxaAsz8VvL1aHbwbiHehBx637Z0JmSS1G7JWmjeqCbhGv+jd07+oss6+HrKeVwEsSqCTmv z69aYii5ga+ZxW2SgUEWsf0t4u1Z1hK//aF8QuYvQ1XiQNcg4hKWeln5mwds4FuTwxbqfnyaR6K /6tmto/BVcOEsqcbGVMq0fObXF7W26LDTzH7hPMYLSTOPIjLAORHBqCRgYQiM5goet91S5FHF+a PbRKPWDpp42ilvfFaxl3+1uWz5IZ8JYxDMiISw9ujJ3r+Ifp0C/DEens2vprEhcQtI1rvwO3v79 nSeaFJh3FltQ/5HcHi1m99IUso5nPxTOrdUFna2MUGBO9W2mX6kw7bZGczC4n+eyM17 X-Received: by 2002:a05:600c:6d7:b0:489:1d23:4524 with SMTP id 5b1f17b1804b1-48e51e0bc19mr45621445e9.5.1778086158014; Wed, 06 May 2026 09:49:18 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:3dcb:40a8:a5b9:2327]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e530fdc50sm33060795e9.5.2026.05.06.09.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 09:49:17 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 1/5] rtc: renesas-rtca3: Fix PIE clear polling condition in alarm setup error path Date: Wed, 6 May 2026 17:49:10 +0100 Message-ID: <20260506164914.3987293-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar In rtca3_set_alarm(), the setup_failed path attempts to disable the Periodic Interrupt Enable (PIE) bit and wait until it is cleared. However, the polling condition passed to readb_poll_timeout_atomic() uses an incorrect expression: !(tmp & ~RTCA3_RCR1_PIE) As ~RTCA3_RCR1_PIE evaluates to a mask of all bits except PIE, the condition effectively waits for all non-PIE bits to become zero, which is unrelated to the intended operation and is unlikely to ever be true. This causes the poll to time out unnecessarily. Fix the condition to check for the PIE bit itself being cleared: !(tmp & RTCA3_RCR1_PIE) This correctly waits until PIE is deasserted after being cleared. Signed-off-by: Lad Prabhakar --- drivers/rtc/rtc-renesas-rtca3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index cbabaa4dc96a..2dc080d0eb6c 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -455,7 +455,7 @@ static int rtca3_set_alarm(struct device *dev, struct r= tc_wkalrm *wkalrm) * specified timeout for setup. */ writeb(rcr1 & ~RTCA3_RCR1_PIE, priv->base + RTCA3_RCR1); - readb_poll_timeout_atomic(priv->base + RTCA3_RCR1, tmp, !(tmp & ~RTCA3_R= CR1_PIE), + readb_poll_timeout_atomic(priv->base + RTCA3_RCR1, tmp, !(tmp & RTCA3_RC= R1_PIE), 10, RTCA3_DEFAULT_TIMEOUT_US); atomic_set(&priv->alrm_sstep, RTCA3_ALRM_SSTEP_DONE); } --=20 2.54.0 From nobody Sun May 31 10:45:05 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BCF249551E for ; Wed, 6 May 2026 16:49:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086162; cv=none; b=IxbiTxVZwGLeq7DcQmMOTAXJJomLlIFeD+8XAlBN/wRLgmxbSAQ+YmT1lBDPYbNNBw154F0TzM86D/ICU5gBfCnD8g62RSyC6ZeN8QH2Ho8nxVO3O1mxY27JnLZJ38GRUjy6dG2gGa492aGhaMnt71TmsA2hjv3cwvjcRWaJLb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086162; c=relaxed/simple; bh=Ic5kVY6Rq8d1btQ9z3kI93gZws6has0O855jspCPo30=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GZTYDvk2lQ0iRdEajpag35qHHxoADqvnP+YYINqEtTGodHW379GznwyVcREMV5bpuRyoYAfQEtWUhozGc++BGZOMLR7z6U2VJSUcj9tm8WqWovquyPxeJLWTZVPMwNsinh70vGQrvX+BNi5oUN25vsLVDrE+OZKJif7CpeW26ts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X36KRS78; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X36KRS78" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488b0046078so59306375e9.1 for ; Wed, 06 May 2026 09:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778086159; x=1778690959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zxWuPcuF0UKPqeCZ8y2hNLNnCZzaOu2O0vTDxb6yruo=; b=X36KRS78W6d7jJr13JyeZ1aOQ3EnhXbTn7VL3+ME9sejDevGEWQKucWQHnttvKmZTy nrEB55WREXmiAtUdK7LEN0EY2II9g77XxsYCHFYElpWYpd21s7UmZmot9Uwxhy0RU1Tt BQn89d8Xy43iOH8Mr/yFc+AOlYzXLliiydNpydpj0+JhyfstUxVOJ+X/pYlJl7EICegA 5BxnmQmx0Flq0sbjUfuLQ/wKL2S717o6choYfkU9e7n9ATC+ibKu/MqwM4/XBD0gtzNv 8RGOhGrX8HzEkD4AsD8sqsYazKYeKP6npzUQDAoLbPHeg9NaXQjQEc51sI6Bh5pOC8fJ ZWvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778086159; x=1778690959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zxWuPcuF0UKPqeCZ8y2hNLNnCZzaOu2O0vTDxb6yruo=; b=srdxEe52kWn9+pLD5oyrbwfFQoc9uc+YbOBbB/zJoH6ZvgcWiawHeYFJVl5yJmIGRH CAPAZ7xliqR/IDMlt8bloIwPa2BK2atmO4ehurJyjFqJQCZaB0JbAb4WEmZaDkQRqFON jjty7n9MpNuAo/rjekO2m2xygkS+O4BZ9aPHyazzsHb2vkbcIUvXBIBKUWb8dlTXqvz8 2iT92uCVa7j1ClfRGFSCsLob1mRnwyW5Z9BMcjzqrg7li227Cr7c1EvGDEgrbkf2qhlI q3OPj3UnHdJcLdLeCSyMXAppx+bggw+KuQVfaT2V+pKF4vDl4oqqSDOaYbJ5V98kSXil LsJA== X-Forwarded-Encrypted: i=1; AFNElJ/xQMCmfieT5R6X8r+Ck/fmqJXNrZUIpd6DQojScL+DzOHraYYbjGk75Lsce9VarSVuzC6cFoIOrFtr5fQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxAU8/5qSOSB5AROAtFz6F6BxOGmcxMhB/omYadYPe866duWsge vmMkpIwxQze33jqLCHSEqbRTy4tHJQBbPBK7lre2Bn754cZ5hACSXM5sT2DC1Hxm X-Gm-Gg: AeBDieuy821VpUXAGfdobgqksJbRwHXHaQhzbJXIXWW/1JuxNExGNDqnhG3qamEbt41 iIZNH+hCogrVkhR5TaN6jHvyPVNicUSYGyZBiZtV49vPHO78h1fxO2MKSE7l2zGpQqGOoJInlsY hLEUUlpBg0lVfuLaQxmWkORLBQLULykiva74HRcjRKKuTlqrNMISJz+VLN5RblBYfRmCo5GLbaM bKpQD0rorNDYqSqndQXLz7KaMoRRurDDYT/o7k8iHJwBzNWvYxDT/NF7Pco3V0kX5pFknpAJ0U1 lae9z1J1KETnSAir02VaOeNu2E+RbKO1ZA4xMTruTqONM99e+eeUZ7cSTdfl+8drhGBlk+RoLaS ME5U7JM9g2qEhsTzJQ4+QG3ARigS1LY2S1M98pUIIdUXy+JqBc5cMXTIv+WdxvC7XC/3GnRbOQC 6xPIVbENTrKCbZ7PBI8QwwWhATCp+QXXvyWNpRzqpI6gMX276fzIo3OFMc+f3ZfrMsJR6p7/F8c snYWDoHxzer+ELL9Gxbp3AP9kyKmS9rU7q0Q61zLoQ/BiTWHK7Jn0OkfH/CQwNpcuTi X-Received: by 2002:a05:600c:c082:b0:485:3ec6:e634 with SMTP id 5b1f17b1804b1-48e51f327fbmr52468335e9.15.1778086158703; Wed, 06 May 2026 09:49:18 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:3dcb:40a8:a5b9:2327]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e530fdc50sm33060795e9.5.2026.05.06.09.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 09:49:18 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 2/5] rtc: renesas-rtca3: Check RADJ poll result during initial setup Date: Wed, 6 May 2026 17:49:11 +0100 Message-ID: <20260506164914.3987293-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar In rtca3_initial_setup(), the driver clears the RTCA3_RADJ register and waits for it to reach zero using readb_poll_timeout(). Check the return value of readb_poll_timeout() and propagate the error if the poll fails. Signed-off-by: Lad Prabhakar --- drivers/rtc/rtc-renesas-rtca3.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index 2dc080d0eb6c..af2a3878289e 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -634,6 +634,8 @@ static int rtca3_initial_setup(struct clk *clk, struct = rtca3_priv *priv) writeb(0, priv->base + RTCA3_RADJ); ret =3D readb_poll_timeout(priv->base + RTCA3_RADJ, tmp, !tmp, 10, RTCA3_DEFAULT_TIMEOUT_US); + if (ret) + return ret; =20 /* Start the RTC and enable automatic time error adjustment. */ mask =3D RTCA3_RCR2_START | RTCA3_RCR2_AADJE; --=20 2.54.0 From nobody Sun May 31 10:45:05 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C5234949E3 for ; Wed, 6 May 2026 16:49:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086162; cv=none; b=PuYx5AoVy9rtsxBWlDnoc4XkFSn531ieLxi0jKfizbGZ91j+aEq+3DA/UpNQtJXWXcE9CgcLNfk7pMV/HK+Abtwa1FitG5NnUihoAi6NT+NR/Wy2yle1zHzem3ip5iYy2D9oP180D8Zjzga18KCATxLiol72ih+N4pVYTGh2g+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086162; c=relaxed/simple; bh=lFsX/jd4tZKyR1FusrQfBraeYnlcWQljOD4ISRSsBto=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qUvT6Goj96ZiWC6xglIHh8toZkT2eirpzuMS8QLQm+eLJDxaujN1Va4SJYu6fOf8T9HEP3Ohd7/bnOmUMyaJQ09gzn466pMHzfdBVqTKJ2QAe09NiIyYAFM0Ihql8JpYQVGvC5Vjy7w3w87l/9vjU5Y4gw06E9gw9D/Fn4sgyM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LPimbhyH; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LPimbhyH" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488b150559bso46390295e9.1 for ; Wed, 06 May 2026 09:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778086159; x=1778690959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pFSpHvDu0iC1ydwX82Iq+Gw2dgxQCozdU4APQk89sRY=; b=LPimbhyHxHo1KiEtJSSuoDJoMH/uJkoGEsXH8CTDPaizcQGd3CUL8ysY5qrnjQ1Sw9 25YWR+KBCvfPIoU9q5sT0SsmcbfFbiu/JQ5LVvUHqVXMi0dcdx/l2WXF6iZvNZKnl+oN qjdHszSOk1f0DuQYuuTP7XcdOsprhjkRIYD3mbTtlT+0Btv0G01CSg+OmXLLJX8L4Nmy YGZywQIHDDR1Yosx1KG+SjlnXecBDWcyVr1+9brdO2ZbxSeuz5cOJS2rzWI6a8O0CNVy /TVi0Db+x3gKJJGaxMTb/eyOSUjVedj/UnZpoYOHKR4JGoNTDV/9tgEurC9+rJ4rEHcR ljow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778086159; x=1778690959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pFSpHvDu0iC1ydwX82Iq+Gw2dgxQCozdU4APQk89sRY=; b=b84jnM2OrDiauIMGsIbxUJF2xmmkTd3hpQ/jwFWWookDTSwqe2AQj0+qiEzfHCaiD8 kh4YhMp4Ff06YfUcKo/5IrdoZMmN05iNqrGEQ8hOlUaDAtbp9E7/8RNqAIACnf1wUBiU oIoLYh76K1piiJQUoXrdm1bluvQMpBJo1gd/WYGNSXuyAmSmxHuiDUy5HcWlC8mwdSQ1 SLl5Msi935SbO+SUmhbtOavEDNWKYwFaJfuLa20ajtahKMH36Cpb27jifOREzqZtFNhd 1PjxjilC9DCUc990r6ottpMC+RyIsZqZq60XI6G8gcSGIss+bOPesmLImjZf7U25HlCg RY6w== X-Forwarded-Encrypted: i=1; AFNElJ/wyd1vyHv3wIXC6Wvx/4onSY45iSqmOoYXrWWhMPBADb8/Z83snS6LBT1rVhdmzi3C36kff88RKLJq8K4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy39AOPXE0f5GusPn65Yn4V2s2/EWZbOtr4bGC+KmCO285MIMPO 3LgfzJeHjCL1TbsuHB00P9up7IayyBXQFyvbkO/bFkoeB3w071STjyzw X-Gm-Gg: AeBDiet9Azd0XZCFer0PgcrbO/3GJ9TvovCaDiuVZ7/TFXl5uV7lrpyESUuEUi1b4Vy TyMnJ1nY0n0/3aNWjpGvhv0rBv/ab/+09ESYCJpQ7TfW7K0V75Y5nk1J42E1sQMowdy18doaMns hwcWCykWSVkv6/HK5WlGpTLL9knBEAUciaT4n0qkI+y4z9kq+b41Pa5iDC1YYikUp2na4WnWeBC GVKwKuv+W6iJkyaG4Ds9ytVn5bCKShve7dFCCJ4HGGCkiljW+H+INyXJyG6ZzzeyKqPAOqOqmIu +TrqNvjolDzlwJoRKOSmXhT3emeSXO9oL4vxVdIEAC+DhVRWVVFTCDs4ESuvGYP6mVYgH2qaP8k wljo4VovAvMh6pkFoFd87fPhmV4/aZG6+VB7zq+f7iOInGswZHt1HsMYoRYlAh90o0EB1sdeJPi AaVb20URWAB0o/ItPQsUP/Y08pQJKjWaOdnwYTTTd6iTvde8t/vQIHlKJlaJjXnRwf9eE8ZvmB4 TwB/E41djBjkil5AjWB0uu78ALgH6bKLkw2c+iP+J6NLqVP1nQpxKA9Uw== X-Received: by 2002:a05:600c:c096:b0:485:40db:d40c with SMTP id 5b1f17b1804b1-48e51e08fedmr52814505e9.3.1778086159420; Wed, 06 May 2026 09:49:19 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:3dcb:40a8:a5b9:2327]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e530fdc50sm33060795e9.5.2026.05.06.09.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 09:49:19 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 3/5] rtc: renesas-rtca3: Fix incorrect error message for reset assert Date: Wed, 6 May 2026 17:49:12 +0100 Message-ID: <20260506164914.3987293-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Update the message to "assert reset" to accurately reflect the operation being performed. Signed-off-by: Lad Prabhakar --- drivers/rtc/rtc-renesas-rtca3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index af2a3878289e..8763745b9172 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -702,7 +702,7 @@ static void rtca3_action(void *data) =20 ret =3D reset_control_assert(priv->rstc); if (ret) - dev_err(dev, "Failed to de-assert reset!"); + dev_err(dev, "Failed to assert reset!"); =20 ret =3D pm_runtime_put_sync(dev); if (ret < 0) --=20 2.54.0 From nobody Sun May 31 10:45:05 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C3FC4963C2 for ; Wed, 6 May 2026 16:49:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086165; cv=none; b=Ps7wwyo/L1N4AQ6J4hWjv38AjC/9xsm6EQIqLNuVJ6FJNnThbcqnLOSs/0k1x1ZG4P1sKrUUee3H+MNNo5vVKp2WgqDLT28lpQbSSFU8HZoAdyhll047JgnpLaFKk2Our0Q0ap2d/uEj5/9p3JZTROzKLdh14wvQ/tSSlucpTME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086165; c=relaxed/simple; bh=wzCBPvBCkMMqnErOKQmwD5AV3I93Zdz23r/gv5O1Gw8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iUm/1Ncl4xly7I1Kyenx5BJQVCkCzmU8VlRrUCdvu2uh4xPq6KBKXoLgPF4nW9e5nvbECaUP1psyot1YBkGfkx+S3ISfsDDtDIpEN3pkH7XKpP0gLTmW/DKLRgPURBJ6kf0BypKuweScxoEk/WBdeHPD8qfepVcXhl750UHUxjo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TkJvC5rX; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TkJvC5rX" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48a7fe4f40bso72149095e9.0 for ; Wed, 06 May 2026 09:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778086160; x=1778690960; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=STu6TPkqcvci8Vu+kzoZratWgCIQTVhRpqVSL/zlfsE=; b=TkJvC5rXIkAOMYOk5S8fvxdzGZ/VGOZyqGQ4LzcQkOOtASKHgvzNmAiE4vd2zQvAB5 CSrq/9dvF5UDWaobyEQxziXEsbbeg35Bx1aG6gjXPuopBaLM+nrlPp5MbP1MBn5blFoE 72nBNqorTn1AeQFAWzyhQI7V7F0YW8dJnlBNlPaoAPMI5j8/tc//jsvkHM0qJWzc2spN Nw4UQsySWftPQAeQSSzVP+8TQt5IgfnjLUdt2HdKjlgffgkxjNGurng4R59/7Kw9Hh0J cu6Utvf+OtS9snjM6H5Ycw87/WF9YCKRUcGNZTY+HZtiFuibhwZW9FV5WzXhXMEnkCvh 5cPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778086160; x=1778690960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=STu6TPkqcvci8Vu+kzoZratWgCIQTVhRpqVSL/zlfsE=; b=cpm4+jiOdy5gxEuklGEJja52Oh/LlPmGjLK1NKGspuAdXX4xjoNLTl6WXNyuL4XI9s drdrv0rmhI+Z134m1dzzIRAzG1bLny0qSnDEMC7kL7gVXe2Gs7G7zrhkOgJytTCmvHox 4kN2lvjVHD1luGJNHwE+iHtjgHxdgYyZg2W+13vj56KU6ov70iiiPMT/NkGedqAzUJzI uY57VLstR7RXj11MroB4S2ETNqmXvcV6CVoMMI2l8gJYzuo6NhE6tJx+jDc9RzvlIftb N0xCUjuocTmzvv1WeOb3DS0p46MdvqGlsBumjPD/gEzboft7wmqLkK5Us/wDc1beKD+R t8xQ== X-Forwarded-Encrypted: i=1; AFNElJ/9xfrfrzMSv2AD57oWErWEJ7pExnf/APK+qIvNJLRJafpERk8p0GDjm4WtXAEPICQh+0L40r81F4pfVPQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9TuDn9AAgMUqDdV/Tolsfqg11PVG9WuKiKt36Q1+p07anmkok kYHqwuTJKWENVSMgDiESkrER1GFZYC1fUpMVbRost7U9UmZePn8yThI5 X-Gm-Gg: AeBDiesGYq3in6bo1NLBrDi94Oxpf8pNK+fKVSp/CvcUOk1G8NNSwpbOAW3qzFc1oLe MTNqDtFpDgi5vIvFhe0Od73BoOpjc/R9GqniaC3s1d8KRNEagW0AH6w3WHyN2KFtXLr9gGHkkmr /1T1casrtiHiMB30hb8Rl5tZt0jCVDYttlx1zVZmcTGiL9ituYBLI861h6c9hjZ1SC51JwgyC2J S65F/WdQ2rMofAR0mkq37/ntlUGIjLU/LzJQdvVboc1Y/7rkp3fheNwELxL8cJmmiMHsGdcHYGU pRpyMqLm7/1btCmOLdhVtzUY/HBZC6IrwtvrVPF+Ab03L2nItVAI8Fm9Zb7hyqTJwxMfWtW2+G6 O0We0gyevn5mHujUMcWhXSfmhsAhDZPW+vsLI31Xz6kAPMDaKa7E7ECZsgIjABDtVMKmpK+Rj8S WYYkl9TpkWrFBWVweMt4dGUPh+vkxVbhD1G3YC7bcB9IcK1vHK9s6u3K7h+W9hUZjcrh/ttZgm7 /lFTpRWM2l/u+czvzoq9Ki/Ba2JD0GcM+gzkw2nQxSKCzFry5hElZUW9eoOZBRGDxxZOpcpCnPR dA8= X-Received: by 2002:a05:600c:c082:b0:489:6c22:e081 with SMTP id 5b1f17b1804b1-48e51dd3a1bmr55435145e9.0.1778086160424; Wed, 06 May 2026 09:49:20 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:3dcb:40a8:a5b9:2327]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e530fdc50sm33060795e9.5.2026.05.06.09.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 09:49:19 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 4/5] rtc: renesas-rtca3: Fix typo in rtca3_ppb_per_cycle documentation Date: Wed, 6 May 2026 17:49:13 +0100 Message-ID: <20260506164914.3987293-5-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Correct a typo in the kernel-doc comment for struct rtca3_ppb_per_cycle by fixing "adjutment" to "adjustment". Signed-off-by: Lad Prabhakar --- drivers/rtc/rtc-renesas-rtca3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index 8763745b9172..97e7e65f59a5 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -103,7 +103,7 @@ enum rtca3_alrm_set_step { =20 /** * struct rtca3_ppb_per_cycle - PPB per cycle - * @ten_sec: PPB per cycle in 10 seconds adjutment mode + * @ten_sec: PPB per cycle in 10 seconds adjustment mode * @sixty_sec: PPB per cycle in 60 seconds adjustment mode */ struct rtca3_ppb_per_cycle { --=20 2.54.0 From nobody Sun May 31 10:45:05 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4069B4A1384 for ; Wed, 6 May 2026 16:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086165; cv=none; b=mShev2N3Ac1NOkgLTYu+zleHCSay2/BRaStdk2b0s+iHfKxfD/L+C1YzLmb8MuCMSmL9sZvKXjOoQdko11oXzxM4IwDWszM1jyj0TLIPmXpCiTQoaUkx8wmfuR/+pBIkjJNeXB/A/vK/q91DyIpkYNjMo8ADqWMZROinHpTyVS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086165; c=relaxed/simple; bh=XbIcmfBPvdUsZgt8hYQuWguV5+dMEMnvfD1TFRjc7zA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K/6EyOX8AaNIrXRLFNEu4bPPMP8O7nFXVuwbNciz0n243GKmb36ydk14Mwl98KchzkTB0SDkxH19shsnzVdXBGSDerFG+vZ5co1ZTzkHKs1mQii5M2cL8MaxrNNg8lATAHwwQUdkhShSefDjPjpG3w4s89+YB5/8JQVIVCIUtpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iSxO92UI; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iSxO92UI" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so94349495e9.0 for ; Wed, 06 May 2026 09:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778086162; x=1778690962; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H/baJx7mBsqKytKYQaKxdbG5hOnnWG1GzcGphYV5dXY=; b=iSxO92UI/pfpIBIpTJ9pEJUCdlNSyr0yOGYRhFT/a6aw3U3MeI+j6WsEzabt4mutsn pGxUvVLeFuNoziE+Y2xx7grQfRM8/fyyIJiRfTVfraS06toRB0xgx1EU1n0C7B3Ss6TZ fOXTaK/pKgUv2Eiv2x2HrO6rEVex71viiy+gNmK8sy0RtVzoUaRjbpVC6Gb7j4uYEH5z KSajT9+1fX1wrtWwEuxZ1oneybAvflnHUT1+g/1+ObW/rWaD2M9o5iUo33QlLDgY8xk9 HoXAsm28mVZ6vwTfqU8TxcE1+AWbVGHdIhWDv/5p/Apt8svqEheAQspvcE19Pc4subeh dgdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778086162; x=1778690962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H/baJx7mBsqKytKYQaKxdbG5hOnnWG1GzcGphYV5dXY=; b=QWWAoA5N8yj81LqKpDB9Vr8aN++8+3aWd9YRt3jy7sd9o5gk+v/hpqldLjEjpBsfOs NTMSi8cZNSYb4Mtn7T6TQV6gOIyyQCPVdcjYs3vEQgcqSxeLwgGHLRhiifx2S0gooRAL UQhi+xoozzU0OQT/SzUs9dS4irzjWxY8HPAJvD5opqM32xrob2LbNpylQ/3rsf7vXS3W MRBcZO+IdfPPqpxZKObaAGD5sHGqxYIOkgZLE7iYNnfk4ap+2S0YCTHCa5Z4m35zyLCK Kf1MHNr9vzvVn8sJo9ezfWrc0kUIlk3EIq5OC7E5v246cMJ2u4ywi1MUIT2j+Hd+Yg4p LJyw== X-Forwarded-Encrypted: i=1; AFNElJ97NNaUb2SfaHJ2d5u1XHKFtWnq6Lf/Ke9OcR7VNcA1Hkm3iDe3EnH/wqFzrukNYK8YudhP8DYzfKXUXHE=@vger.kernel.org X-Gm-Message-State: AOJu0YwudoKwnhDiO3emoN8fnJ5R0DE2m9+ttKL0k3tlHFnlt2OyANPb +4GqvOiYdMqYLt2s2xFAi5xfRn6vfWNxAOnxEgFeQxZ1t8x9yogF6boZ X-Gm-Gg: AeBDiet82dtLKxAUHHgPvOsZNzqE/lx10ouFki2jbXlmrxJJ5hIz6SxZpTELof5OzTE dBdndaeEZ3CFR+mQ4iR7IqWBF8y6chgsQoICOkB4tVjwBR6Aua/C8jyBgAM7ezISHRVhykJHEaN 7yIvgtz5U6ii72hV7ZeGzWwOwLeu/xMk6pRAONc+a2Bvuv0/q2ZeL7xeC8Tr0tYO4Bx4zvmtBII KqbNJXQb4jQ0etF3mciAcvqKtx9GJVUf8foLF+mPYBJJBYStAo9aMVDsS976/UsfN0KktLgSJd9 R6ssBGWzRprbtW6nYNupKGwOiyUQScqLPfhO0zZ61FCKvMRxhImQ4mcafjtcBDLetm0P+CiDwvS tK0LOuA95JjfflSaPjew3h9vwTQ1S8BUV064UvqWTm5QxNj31xHkem9Gvoa82fHYQC1TDWkcJZO nRuLCab3J4fe+Wbfe9UsDIyUMkymb+RqgaHbScbe3lovoKszxaqKyRr81/7EAkH8Pbs5TPVh5MT 8//bodY3lyaJ5yLFteYRETsSuGknSYPaVLTRQtYEh8YtG3vglGkZEEdnQ== X-Received: by 2002:a05:600d:10:b0:488:e7e4:8425 with SMTP id 5b1f17b1804b1-48e51f4ea40mr61630205e9.23.1778086161523; Wed, 06 May 2026 09:49:21 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:3dcb:40a8:a5b9:2327]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e530fdc50sm33060795e9.5.2026.05.06.09.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 09:49:20 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven Cc: linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 5/5] rtc: renesas-rtca3: Factor out year decoding helper Date: Wed, 6 May 2026 17:49:14 +0100 Message-ID: <20260506164914.3987293-6-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260506164914.3987293-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar The logic to decode the year value from the hardware registers is duplicated in both rtca3_read_time() and rtca3_read_alarm(). Introduce a helper rtca3_decode_year() to centralize this conversion. Signed-off-by: Lad Prabhakar --- drivers/rtc/rtc-renesas-rtca3.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index 97e7e65f59a5..b3875d041de5 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -228,12 +228,19 @@ static void rtca3_prepare_cntalrm_regs_for_read(struc= t rtca3_priv *priv, bool cn } } =20 +static u32 rtca3_decode_year(u8 mask, u16 year) +{ + u8 y =3D FIELD_GET(mask, year); + u32 century =3D bcd2bin((y =3D=3D 0x99) ? 0x19 : 0x20); + + return (century * 100 + bcd2bin(y)) - 1900; +} + static int rtca3_read_time(struct device *dev, struct rtc_time *tm) { struct rtca3_priv *priv =3D dev_get_drvdata(dev); u8 sec, min, hour, wday, mday, month, tmp; u8 trials =3D 0; - u32 year100; u16 year; =20 guard(spinlock_irqsave)(&priv->lock); @@ -274,9 +281,7 @@ static int rtca3_read_time(struct device *dev, struct r= tc_time *tm) tm->tm_wday =3D bcd2bin(FIELD_GET(RTCA3_RWKCNT_WK, wday)); tm->tm_mday =3D bcd2bin(FIELD_GET(RTCA3_RDAYCNT_DAY, mday)); tm->tm_mon =3D bcd2bin(FIELD_GET(RTCA3_RMONCNT_MONTH, month)) - 1; - year =3D FIELD_GET(RTCA3_RYRCNT_YEAR, year); - year100 =3D bcd2bin((year =3D=3D 0x99) ? 0x19 : 0x20); - tm->tm_year =3D (year100 * 100 + bcd2bin(year)) - 1900; + tm->tm_year =3D rtca3_decode_year(RTCA3_RYRCNT_YEAR, year); =20 return 0; } @@ -354,7 +359,6 @@ static int rtca3_read_alarm(struct device *dev, struct = rtc_wkalrm *wkalrm) struct rtca3_priv *priv =3D dev_get_drvdata(dev); u8 sec, min, hour, wday, mday, month; struct rtc_time *tm =3D &wkalrm->time; - u32 year100; u16 year; =20 guard(spinlock_irqsave)(&priv->lock); @@ -373,9 +377,7 @@ static int rtca3_read_alarm(struct device *dev, struct = rtc_wkalrm *wkalrm) tm->tm_wday =3D bcd2bin(FIELD_GET(RTCA3_RWKAR_DAYW, wday)); tm->tm_mday =3D bcd2bin(FIELD_GET(RTCA3_RDAYAR_DATE, mday)); tm->tm_mon =3D bcd2bin(FIELD_GET(RTCA3_RMONAR_MON, month)) - 1; - year =3D FIELD_GET(RTCA3_RYRAR_YR, year); - year100 =3D bcd2bin((year =3D=3D 0x99) ? 0x19 : 0x20); - tm->tm_year =3D (year100 * 100 + bcd2bin(year)) - 1900; + tm->tm_year =3D rtca3_decode_year(RTCA3_RYRAR_YR, year); =20 wkalrm->enabled =3D !!(readb(priv->base + RTCA3_RCR1) & RTCA3_RCR1_AIE); =20 --=20 2.54.0